On Fri, 1 Dec 2023 at 07:20, Janne Grunau via B4 Relay <devnull+j.jannau....@kernel.org> wrote: > > From: Janne Grunau <j...@jannau.net> > > The memory maps for Apple's M2 Pro/Max/Ultra left MMIO space out which > was not used by any driver at the time. The display out exposed as > simple-framebuffer use a power-domain controlled by a device in an > unmapped region. > Add a map covering this region as well as another MMIO region in the > range 0x4'0000'0000 - 0x5'0000'0000. The added regions cover all MMIO > annotated in Apple's device tree in this range. > > Signed-off-by: Janne Grunau <j...@jannau.net>
Review comments addressed. Reviewed-by: Eric Curtin <ecur...@redhat.com> Is mise le meas/Regards, Eric Curtin > --- > Changes in v2: > - use SZ_1G as block size > - Link to v1: > https://lore.kernel.org/r/20231130-apple_t602x_extend_memmap-v1-1-cd96b251d...@jannau.net > --- > arch/arm/mach-apple/board.c | 48 > +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/arch/arm/mach-apple/board.c b/arch/arm/mach-apple/board.c > index 47393babbc..7a6151a972 100644 > --- a/arch/arm/mach-apple/board.c > +++ b/arch/arm/mach-apple/board.c > @@ -370,6 +370,22 @@ static struct mm_region t6020_mem_map[] = { > .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > PTE_BLOCK_NON_SHARE | > PTE_BLOCK_PXN | PTE_BLOCK_UXN > + }, { > + /* I/O */ > + .virt = 0x400000000, > + .phys = 0x400000000, > + .size = SZ_1G, > + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > + PTE_BLOCK_NON_SHARE | > + PTE_BLOCK_PXN | PTE_BLOCK_UXN > + }, { > + /* I/O */ > + .virt = 0x480000000, > + .phys = 0x480000000, > + .size = SZ_1G, > + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > + PTE_BLOCK_NON_SHARE | > + PTE_BLOCK_PXN | PTE_BLOCK_UXN > }, { > /* I/O */ > .virt = 0x580000000, > @@ -471,6 +487,22 @@ static struct mm_region t6022_mem_map[] = { > .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > PTE_BLOCK_NON_SHARE | > PTE_BLOCK_PXN | PTE_BLOCK_UXN > + }, { > + /* I/O */ > + .virt = 0x400000000, > + .phys = 0x400000000, > + .size = SZ_1G, > + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > + PTE_BLOCK_NON_SHARE | > + PTE_BLOCK_PXN | PTE_BLOCK_UXN > + }, { > + /* I/O */ > + .virt = 0x480000000, > + .phys = 0x480000000, > + .size = SZ_1G, > + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > + PTE_BLOCK_NON_SHARE | > + PTE_BLOCK_PXN | PTE_BLOCK_UXN > }, { > /* I/O */ > .virt = 0x580000000, > @@ -551,6 +583,22 @@ static struct mm_region t6022_mem_map[] = { > .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > PTE_BLOCK_NON_SHARE | > PTE_BLOCK_PXN | PTE_BLOCK_UXN > + }, { > + /* I/O */ > + .virt = 0x2400000000, > + .phys = 0x2400000000, > + .size = SZ_1G, > + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > + PTE_BLOCK_NON_SHARE | > + PTE_BLOCK_PXN | PTE_BLOCK_UXN > + }, { > + /* I/O */ > + .virt = 0x2480000000, > + .phys = 0x2480000000, > + .size = SZ_1G, > + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > + PTE_BLOCK_NON_SHARE | > + PTE_BLOCK_PXN | PTE_BLOCK_UXN > }, { > /* I/O */ > .virt = 0x2580000000, > > --- > base-commit: 43f2873fa98b1da6eb56d756315c7bd7db63db27 > change-id: 20231130-apple_t602x_extend_memmap-c82c522ca8c0 > > Best regards, > -- > Janne Grunau <j...@jannau.net> > >
