Hello Sughosh,
Sorry for this very late reply especially since I have a quite negative
feedback on the proposed changes.
I don't think FWU metadata version 1 should be removed from U-Boot support.
There are existing immutable boot agent relying on format v1, starting from the
Synquacer boards
address of offset 0 of a physical 4kB page. In such case, OP-TEE
secure world refuses to register the zero-sized shared memory
area and makes U-Boot optee service enumeration to fail.
Fixes: 94ccfb78a4d6 ("drivers: tee: optee: discover OP-TEE services")
Signed-off-by: Etienn
Signed-off-by: Etienne Carriere
---
drivers/tee/optee/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index 9a9b697e91..5308dd58ce 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers/tee/optee/core.c
@@ -841,7 +841,7
return ret;
> + }
> + if (version < SCMI_BASE_PROTOCOL_VERSION)
> + return -EINVAL;
LGTM. The open source SCMI server implementations I'm aware of (scp-firmware,
tf-a and optee-os) all report SCMI Base protocol version v2.0.
Reviewed-by: Etienne Carriere
work was added
> > in a prior commit.
> >
> > Signed-off-by: AKASHI Takahiro
> > ---
> > v5
> > * new commit
> > ---
> > arch/sandbox/dts/test.dts | 1 +
> > test/dm/scmi.c| 20 ++--
> > 2 files changed, 19 insertions(+), 2 deletions(-)
> >
>
> Reviewed-by: Simon Glass
>
Reviewed-by: Etienne Carriere
+
> > 2 files changed, 103 insertions(+)
> >
>
> Reviewed-by: Simon Glass
>
Reviewed-by: Etienne Carriere
i_agent-uclass.h | 8 +---
> 5 files changed, 18 insertions(+), 12 deletions(-)
>
Reviewed-by: Etienne Carriere
Thanks for addressing this protocol channel issue.
BR,
Etienne
--
> drivers/power/regulator/scmi_regulator.c | 26 ++
> drivers/reset/reset-scmi.c| 19 +---
> include/scmi_agent.h | 15 ++--
> 5 files changed, 104 insertions(+), 88 deletions(-)
>
Reviewed-by: Etienne Carriere
each of functions in ops
> ---
This patch v5 looks good to me. 2 suggestions.
Reviewed-by: Etienne Carriere with comments
addressed or not.
I have successfully tested the whole PATCH v5 series on my platform.
> drivers/firmware/scmi/Makefile | 1 +
> drivers/firmware/scmi/base.c | 65
SHI Takahiro
> Reviewed-by: Simon Glass
> Reviewed-by: Etienne Carriere
> ---
> v3
> * change char to u8 in vendor/agent names
> v2
> * use helper functions, removing direct uses of ops
> ---
This change breaks pytest ut_dm_dm_test_scmi_cmd.
CONFIG_CMD_SCMI=y
om SCMI server via
> the protocol and saved into the agent instance's local storage.
>
> Signed-off-by: AKASHI Takahiro
> Reviewed-by: Simon Glass
> Reviewed-by: Etienne Carriere
> ---
> v3
> * typo fix: add '@' for argument name in function description
> * eliminate dev_get_
basic information will be retrieved from SCMI server via
> the protocol and saved into the agent instance's local storage.
>
> Signed-off-by: AKASHI Takahiro
> Reviewed-by: Simon Glass
> Reviewed-by: Etienne Carriere
> ---
> v3
> * typo fix: add '@' for argument
Hello Akashi-san,
>
> From: AKASHI Takahiro
> Sent: Friday, September 8, 2023 04:51
>
> The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channel
> reference") added an explicit parameter, channel, but it seems to make
> the code complex.
>
> Hiding this parameter will allow
> From: AKASHI Takahiro
> Sent: Friday, September 8, 2023 04:51
>
> This framework allows SCMI protocols to be installed and bound to the agent
> so that the agent can manage and utilize them later.
>
> Signed-off-by: AKASHI Takahiro
> Reviewed-by: Simon Glass
Hello Akashi-san,
> From: AKASHI Takahiro
> Sent: Monday, August 7, 2023 12:03 PM
>
> Hi Etienne,
>
> On Thu, Aug 03, 2023 at 09:24:51AM +, Etienne CARRIERE wrote:
> > Hello Takahiro-san,
> >
> > Sorry again for this late feedback.
> > Testing the
> From: AKASHI Takahiro
> Sent: Friday, July 28, 2023 02:33
> Subject: [RFC 3/3] firmware: scmi: add a sanity check against protocol version
>
> SCMI_PROTOCOL_VERSION is a mandatory command for all the SCMI protocols.
> With this patch, this command is implemented on each protocol.
> Then, we
and the version check will be introduced.
> To finish "ut dm scmi_[clocks|resets|voltage_domains]" tests, sandbox SCMI
> agent should also implement/mimic this command.
>
> Signed-off-by: AKASHI Takahiro
Aside the typos, inherited from previous patch series, the patch looks all good
to me.
ed by the SCMI server (firmware).
>
> Signed-off-by: AKASHI Takahiro
> ---
Reviewed-by: Etienne Carriere
> drivers/firmware/scmi/scmi_agent-uclass.c | 41 +--
> 1 file changed, 38 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/scmi/scmi
SHI Takahiro
> Reviewed-by: Simon Glass
> ---
> v2
> * use helper functions, removing direct uses of ops
Reviewed-by: Etienne Carriere
with patch on dm_test_scmi_base() squashed in patch 9/12.
> ---
> test/dm/scmi.c | 59 +++
> From: AKASHI Takahiro
> Sent: Wednesday, July 26, 2023 10:38
>
> This is a help text for scmi command.
>
> Signed-off-by: AKASHI Takahiro
> ---
> v2
> * add more descriptions about SCMI
Reviewed-by: Etienne Carriere
> ---
&
gt; Signed-off-by: AKASHI Takahiro
> ---
> v2
> * remove sub command category, 'scmi base', for simplicity
Reviewed-by: Etienne Carriere
> ---
> cmd/Kconfig | 9 ++
> cmd/Makefile | 1 +
> cmd/scmi.c | 334 +++
> 3 files c
d as sandbox's device tree.
>
> Signed-off-by: AKASHI Takahiro
> ---
> v2
> * use helper functions, removing direct uses of ops
> ---
Reviewed-by: Etienne Carriere
with reported issue fixed.
> test/dm/scmi.c | 109 +
> 1 fi
gt; The test scenario is not changed at all.
>
> Signed-off-by: AKASHI Takahiro
> Reviewed-by: Simon Glass
> ---
Reviewed-by: Etienne Carriere
> arch/sandbox/include/asm/scmi_test.h | 7 ++-
> drivers/firmware/scmi/sandbox-scmi_agent.c | 20 +--
> drivers/firmware/s
> From: AKASHI Takahiro
> Sent: Wednesday, July 26, 2023 10:38
>
> This is a simple implementation of SCMI base protocol for sandbox.
> The main use is in SCMI unit test.
>
> Signed-off-by: AKASHI Takahiro
> Reviewed-by: Simon Glass
Reviewed-by: Etienne Carr
> From: AKASHI Takahiro
> Sent: Wednesday, July 26, 2023 10:38
>
> SCMI base protocol is mandatory and doesn't need to be listed in a device
> tree.
>
> Signed-off-by: AKASHI Takahiro
> Reviewed-by: Simon Glass
Reviewed-by: Etienne Carriere
> ---
> arch/sand
gent-uclass.c | 116 ++
> > > include/scmi_agent-uclass.h | 70 -
> > > 2 files changed, 184 insertions(+), 2 deletions(-)
> > >
> >
> > Reviewed-by: Simon Glass
Reviewed-by: Etienne Carriere
with below repor
ability of protocols
Reviewed-by: Etienne Carriere
with 2 minor comments and with .per_device_plat_auto value set
by this patch instead of from patch v2 01/12.
> ---
> drivers/firmware/scmi/scmi_agent-uclass.c | 100 +-
> include/scmi_agent-uclass.h
scmi/scmi_agent-uclass.c | 118 +++---
> 1 file changed, 59 insertions(+), 59 deletions(-)
>
Reviewed-by: Etienne Carriere
> diff --git a/drivers/firmware/scmi/scmi_agent-uclass.c
> b/drivers/firmware/scmi/scmi_agent-uclass.c
> index 39cf15c88f75..8693e4c447b7 100644
>
ops
> * add function descriptions for each of functions in ops
A reported typo and a question on use of strcpy().
Otherwise the patch look to me. If you strongly feel strcpy() is safe, please
get my R-b tag:
Reviewed-by: Etienne Carriere
> ---
> drivers/firmware/scmi/Makef
Hello Takahiro-san,
Sorry again for this late feedback.
Testing the series against stm32mp135f-dk board which is using SCMI resources,
I see the board fails to boot.
> From: AKASHI Takahiro
> To: tr...@konsulko.com, s...@chromium.org
> Cc: etienne.carri...@st.com, u-boot@lists.denx.de,
>
Hello Takahiro-san,
> From: U-Boot on behalf of Simon Glass
>
> Sent: Thursday, July 27, 2023 2:50 AM
>
> On Wed, 26 Jul 2023 at 02:38, AKASHI Takahiro
> wrote:
> >
> > The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channel
> > reference") added an explicit parameter,
Hello Jassi,
Few comments below.
On Tue, 11 Apr 2023 at 01:03, wrote:
>
> From: Masami Hiramatsu
>
> In the FWU Multi Bank Update feature, the information about the
> updatable images is stored as part of the metadata, on a separate
> region. Add a driver for reading from and writing to the
On Tue, 11 Apr 2023 at 01:03, wrote:
>
> From: Masami Hiramatsu
>
> Add 'mkfwumdata' tool to generate FWU metadata image for the meta-data
> partition to be used in A/B Update imeplementation.
>
> Signed-off-by: Sughosh Ganu
> Signed-off-by: Jassi Brar
> Signed-off-by: Masami Hiramatsu
> ---
box_defconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
I think the commit header line should mention developerbox defconfig.
Aside from that, Acked-by: Etienne Carriere fwiw.
Regards,
Etienne
>
> diff --git a/configs/synquacer_developerbox_defconfig
> b/configs/s
Hello Jassi,
On Tue, 11 Apr 2023 at 01:04, wrote:
>
> From: Jassi Brar
>
> Add code to support FWU_MULTI_BANK_UPDATE.
> The platform does not have gpt-partition storage for
> Banks and MetaData, rather it used SPI-NOR backed
> mtd regions for the purpose.
>
I think you should mention this
Hello Jassi,
On Tue, 28 Feb 2023 at 01:52, wrote:
>
> From: Jassi Brar
>
> Instead of each i/f having to implement their own meta-data verification
> and storage, move the logic in common code. This simplifies the i/f code
> much simpler and compact.
>
> Signed-off-by: Jassi Brar
> ---
>
On Tue, 28 Feb 2023 at 01:52, wrote:
>
> From: Jassi Brar
>
> Moving towards using common code for meta-data management,
> implement the read/write mdata hooks.
>
> Signed-off-by: Jassi Brar
> Reviewed-by: Etienne Carriere
> Reviewed-by: Ilias Apalodimas
> ---
- err = fwu_write_mdata(g_dev, mdata, part & PRIMARY_PART ? true : false);
On Mon, 27 Feb 2023 at 17:46, Jassi Brar wrote:
>
> On Mon, Feb 27, 2023 at 10:30 AM Etienne Carriere
> wrote:
> >
> > Hello Jassi,
> >
> > On Sun, 5 Feb 2023 at 04:01,
Hello Jassi,
On Sun, 5 Feb 2023 at 04:01, wrote:
>
> From: Jassi Brar
>
> Instead of each i/f having to implement their own meta-data verification
> and storage, move the logic in common code. This simplifies the i/f code
> much simpler and compact.
>
> Signed-off-by: Jassi Brar
> ---
>
On Thu, 16 Feb 2023 at 18:21, Etienne Carriere
wrote:
>
> Adds CONFIG_EFI_CAPSULE_MAX to configure the max index value used in
> EFI capsule reports. The config default value is 65535 as the index max
I forgot to update the commit message.
I'll fix in v3.
> value used before
of storage space.
Signed-off-by: Etienne Carriere
---
Changes since v1
- Changed CONFIG_EFI_CAPSULE_MAX default value from 65535 to 15.
---
lib/efi_loader/Kconfig | 8 ++
lib/efi_loader/efi_capsule.c | 48 +---
lib/efi_loader/efi_setup.c | 7
of storage space.
Signed-off-by: Etienne Carriere
---
lib/efi_loader/Kconfig | 8 ++
lib/efi_loader/efi_capsule.c | 48 +---
lib/efi_loader/efi_setup.c | 7 +-
3 files changed, 48 insertions(+), 15 deletions(-)
diff --git a/lib/efi_loader
this feature.
Co-developed-by: Ilias Apalodimas
Signed-off-by: Ilias Apalodimas
Signed-off-by: Etienne Carriere
---
Changes since v1
- Moved measurement to after DTB tweaks in efi_install_fdt() and change
its measure to hash only populated areas in the DTB (header, structs,
strings and reserved
Hello Heinrich and all,
On Wed, 1 Feb 2023 at 10:00, Heinrich Schuchardt
wrote:
>
>
>
> On 2/1/23 09:32, Rasmus Villemoes wrote:
> > On 31/01/2023 16.07, Tom Rini wrote:
> >> On Tue, Jan 31, 2023 at 02:03:10PM +0200, Ilias Apalodimas wrote:
> >>> Hi all,
> >>>
> >>> On Mon, Jan 30, 2023 at
On Thu, 19 Jan 2023 at 14:47, Ilias Apalodimas
wrote:
>
> Right,
> I'll answer to myself here.
>
> On Thu, 19 Jan 2023 at 15:26, Ilias Apalodimas
> wrote:
> >
> > Hi Etienne,
> >
> > On Thu, 19 Jan 2023 at 15:15, Etienne Carriere
> > wrote:
_tee.c
> > +++ b/drivers/tpm/tpm2_ftpm_tee.c
> > @@ -18,10 +18,12 @@
> > #include
> > #include
> > #include
> > +#include
> >
> > #include "tpm_tis.h"
> > #include "tpm2_ftpm_tee.h"
> >
> > +OPTEE_SERVIC
d, sizeof(uuid)))
> + if (!memcmp(uuid, loc_uuid, sizeof(*uuid)))
> return service;
> }
>
> --
> 2.38.1
>
Reviewed-by: Etienne Carriere
On Thu, 19 Jan 2023 at 13:53, Ilias Apalodimas
wrote:
>
> Hi Heinrich,
> On Thu, Jan 19, 2023 at 01:42:20PM +0100, Heinrich Schuchardt wrote:
> > On 1/19/23 12:45, Ilias Apalodimas wrote:
> > > Hi Etienne,
> > >
> > > On Thu, 19 Jan 20
On Thu, 19 Jan 2023 at 12:46, Ilias Apalodimas
wrote:
>
> Hi Etienne,
>
> On Thu, 19 Jan 2023 at 13:17, Etienne Carriere
> wrote:
> >
> > On Wed, 18 Jan 2023 at 17:12, Ilias Apalodimas
> > wrote:
> > >
> > > When we try to load EFI variables
On Wed, 18 Jan 2023 at 17:12, Ilias Apalodimas
wrote:
>
> When we try to load EFI variables from a file in the ESP partition and the
> file is missing We print a scary error looking like
> => printenv -e
> ** Unable to read file ubootefi.var **
> Failed to load EFI variables
>
> This is not an
failed to bind: %d\n", ret);
> > > + dev_warn(dev, "optee-rng failed to bind: %d\n",
> > > ret);
> > > }
> > >
> > > return 0;
> >
> >
> > I think you can add:
> >
> > Fixes: 476a3d58dfeb ("tee: optee: don't fail probe because of optee-rng")
> >
> >
> > Reviewed-by: Patrick Delaunay
>
> Sure I'll wait for additional reviews etc and respin
Reviewed-by: Etienne Carriere
Sorry for that :|
etienne
>
> Cheers
> /Ilias
> >
> > Thanks
> > Patrick
> >
> >
nd avoid parsing and scanning through partitions
> > > everytime for meta-data partitions because they can't change after bootup.
> > >
> > > Acked-by: Etienne Carriere
> > > Signed-off-by: Jassi Brar
> > > ---
> > > drivers/fwu-mdata/gpt_
Hello Eddie and all,
On Tue, 3 Jan 2023 at 21:42, Eddie James wrote:
>
> Add a configuration option to measure the boot through the bootm
> function.
>
> Signed-off-by: Eddie James
> ---
> boot/bootm.c| 53 +
> cmd/bootm.c | 2 ++
>
if (ret < 0) {
> > + log_debug("Error getting the FWU metadata partitions\n");
> > + return -ENOENT;
> > + }
> > +
> > + return gpt_read_write_mdata(desc, mdata, MDATA_WRITE,
> > +primary ? g_mdata_part[0] :
> > g_mdata_part[1]);
> > +}
> > +
> > static const struct fwu_mdata_ops fwu_gpt_blk_ops = {
> > + .read_mdata = fwu_gpt_read_mdata,
> > + .write_mdata = fwu_gpt_write_mdata,
> > .get_mdata = fwu_gpt_get_mdata,
> > .update_mdata = fwu_gpt_update_mdata,
> > .get_mdata_part_num = fwu_gpt_get_mdata_partitions,
> > --
> > 2.34.1
> >
>
>
> Other than that
> Reviewed-by: Ilias Apalodimas
>
Reviewed-by: Etienne Carriere with
Ilias' comments addressed.
c | 165 ---
> drivers/fwu-mdata/gpt_blk.c | 124 +-
> include/fwu.h| 199 ---
> lib/fwu_updates/fwu.c| 235 ---
> 5 files changed, 38 insertions(+), 702 deletions(-)
/fwu.h | 4 ++--
> lib/fwu_updates/fwu.c | 6 +++---
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
Reviewed-by: Etienne Carriere
> diff --git a/cmd/fwu_mdata.c b/cmd/fwu_mdata.c
> index 9b70340368..5ecda455df 100644
> --- a/cmd/fwu_mdata.c
> +++ b/cmd/fwu_mdata.c
>
Hello Jassi,
On Sat, 3 Dec 2022 at 04:17, wrote:
>
> From: Jassi Brar
>
> Instead of each i/f having to implement their own meta-data verification
> and storage, move the logic in common code. This simplifies the i/f code
> much simpler and compact.
>
> Signed-off-by: Jassi Brar
> ---
>
across reboots, there is
> >> > not point measuring it hence the config switch to allow platform to not
> >> > embed this feature.
> >> >
> >> > Co-developed-by: Ilias Apalodimas
> >> > Signed-off-by: Ilias Apalodimas
> >
Makes OP-TEE to enumerate also services depending on tee-supplicant
support in U-Boot. This change allows OP-TEE services like fTPM TA
to be discovered and get a TPM device registered in U-Boot.
Signed-off-by: Etienne Carriere
---
drivers/tee/optee/core.c | 32
Fixes optee-rng driver bind sequence in optee driver to print a warning
message but not report an error status when a optee-rng service driver
fails to be bound as the optee driver itself is still fully functional.
Signed-off-by: Etienne Carriere
---
drivers/tee/optee/core.c | 2 +-
1 file
Opens the fTPM session with TEE_LOGIN_REE_KERNEL as fTPM may restrict
access to that login when Linux based OS is running as applications are
expected to got through the Linux TPMv2 driver.
Signed-off-by: Etienne Carriere
---
drivers/tpm/tpm2_ftpm_tee.c | 1 +
1 file changed, 1 insertion
this feature.
Co-developed-by: Ilias Apalodimas
Signed-off-by: Ilias Apalodimas
Signed-off-by: Etienne Carriere
---
cmd/bootefi.c | 9 +
include/efi_loader.h | 2 ++
include/efi_tcg2.h| 10 ++
include/tpm-v2.h | 2 ++
lib/efi_loader/Kconfig| 12
Hello Jassi,
On Mon, 7 Nov 2022 at 19:29, Jassi Brar wrote:
>
> On Mon, Nov 7, 2022 at 11:24 AM Etienne Carriere
> wrote:
> > On Fri, 4 Nov 2022 at 03:43, wrote:
> > >
> > > +/**
> > > + * fwu_get_verified_mdata() - Read, verify and return the
Hello Jassi,
Acked-by: Etienne Carriere
with the 2 below comments addressed.
On Fri, 4 Nov 2022 at 03:42, wrote:
>
> From: Jassi Brar
>
> Use cached values and avoid parsing and scanning through partitions
> everytime for meta-data partitions because they can't change after boo
Hello Jassi,
On Fri, 4 Nov 2022 at 03:43, wrote:
>
> From: Jassi Brar
>
> Instead of each i/f having to implement their own meta-data verification
> and storage, move the logic in common code. This simplifies the i/f code
> much simpler and compact.
>
> Signed-off-by: Jassi Brar
> ---
>
On Fri, 4 Nov 2022 at 03:43, wrote:
>
> From: Jassi Brar
>
> Moving towards using common code for meta-data management,
> implement the read/write mdata hooks.
>
> Signed-off-by: Jassi Brar
> ---
> drivers/fwu-mdata/gpt_blk.c | 36
> 1 file changed, 36
Hello Jassi,
FYI, I've successfully tested this series on stm32mp1 for FWU, once
the few typos fixed to build it them.
On Fri, 4 Nov 2022 at 03:43, wrote:
>
> From: Jassi Brar
>
> The common code can now read, verify and fix meta-data copies
> while exposing one consistent structure to users.
Hello Sughosh,
For the v15 series: Tested-by: Etienne Carriere
Best regards,
Etienne
On Fri, 21 Oct 2022 at 14:47, Sughosh Ganu wrote:
>
> Add support for setting OEM flags in the capsule header. As per the
> UEFI specification, bits 0-15 of the flags member of the capsule
>
Hello Kojima-san,
On Tue, 25 Oct 2022 at 05:17, Masahisa Kojima
wrote:
>
> This commit adds the menu-driven UEFI Secure Boot Key
> enrollment interface. User can enroll the PK, KEK, db
> and dbx by selecting EFI Signature Lists file.
> After the PK is enrolled, UEFI Secure Boot is enabled and
>
Hi Sughosh,
For info I successfully tested your v14 series on my boards.
(note i did not test case with a power failure in between mdata
partition updates, discussed in patch v14 02/15).
I'll run another tests round on next v15 to post my Tested-by tag.
Br,
Etienne
On Tue, 18 Oct 2022 at 13:45,
On Thu, 20 Oct 2022 at 16:11, Sughosh Ganu wrote:
>
> On Thu, 20 Oct 2022 at 19:25, Etienne Carriere
> wrote:
> >
> > On Tue, 18 Oct 2022 at 13:44, Sughosh Ganu wrote:
> > >
> > > Add support for setting OEM flags in the capsule header. As per
iewed-by: Simon Glass
> Reviewed-by: Ilias Apalodimas
> ---
> Changes since V13: None
>
Acked-by: Etienne Carriere
> common/board_r.c | 3 +++
> common/event.c | 3 +++
> include/event.h | 3 +++
> 3 files changed, 9 insertions(+)
>
> diff --git a/common/board_r.
nay
> Acked-by: Ilias Apalodimas
> ---
> Changes since V13: None
>
Acked-by: Etienne Carriere
> arch/arm/mach-stm32mp/include/mach/stm32.h | 5 +
> board/st/stm32mp1/stm32mp1.c | 21 +
> include/fwu.h | 12 ++
13: None
>
> doc/mkeficapsule.1 | 29 +
> tools/eficapsule.h | 8
> tools/mkeficapsule.c | 96
> 3 files changed, 119 insertions(+), 14 deletions(-)
>
Acked-by: Etienne Carriere
> diff --git a/doc/mkeficapsule.1 b/doc/mkef
; +
> > +The task of accepting the different firmware images, post an update
> > +may be done by multiple, separate components in the Operating
> > +System. To help identify the firmware image that is being accepted,
> > +the accept capsule passes the image GUID of the firmware imag
On Tue, 18 Oct 2022 at 13:44, Sughosh Ganu wrote:
>
> Add support for setting OEM flags in the capsule header. As per the
> UEFI specification, bits 0-15 of the flags member of the capsule
> header can be defined per capsule GUID.
>
> The oemflags will be used for the FWU Multi Bank update
Hi Sughosh, Ilias,
On Wed, 19 Oct 2022 at 21:56, Ilias Apalodimas
wrote:
>
> Hi Sughosh
>
>
> [...]
>
> > + *
> > + * Read both the metadata copies from the storage media, verify their
> > checksum,
> > + * and ascertain that both copies match. If one of the copies has gone bad,
> > + * restore
aunay
> Acked-by: Ilias Apalodimas
> Acked-by: Etienne Carriere
> ---
> Changes since V12: None
>
> arch/arm/dts/stm32mp157c-dk2-u-boot.dtsi | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/dts/stm32mp157c-dk2-u-boot.dtsi
> b/arch/
Hi Sughosh,
On Fri, 7 Oct 2022 at 05:16, Sughosh Ganu wrote:
>
> hi Etienne,
>
> On Thu, 6 Oct 2022 at 19:36, Etienne Carriere
> wrote:
> >
> > Hi Sughosh,
> >
> > On Thu, 6 Oct 2022 at 11:07, Sughosh Ganu wrote:
> > >
> > > Add
Hi Sughosh,
On Thu, 6 Oct 2022 at 11:07, Sughosh Ganu wrote:
>
> Add test cases for accessing the FWU Metadata on the sandbox
> platform. The sandbox platform also uses the metadata access driver
> for GPT partitioned block devices.
>
> The FWU feature will be tested on the sandbox64 variant
.
>
> Signed-off-by: Sughosh Ganu
> Reviewed-by: Patrick Delaunay
> Acked-by: Etienne Carriere
> ---
> Changes since V11:
> * Add a function fwu_alt_num_for_dfu_dev() to get the alt number based
> on the DFU backend device as suggested by Ilias
> * Change the logic
Hello Jassi,
On Wed, 28 Sept 2022 at 17:17, Jassi Brar wrote:
>
> Hi Etienne,
>
> On Wed, Sep 28, 2022 at 2:30 AM Etienne Carriere
> wrote:
> > Hello Jassi, Sughosh and all,
> >
> > >>> But a malicious user may force some old vulnerable im
Hello Sughosh,
2 comments on the documentation. Otherwise it looks all good to me.
Best regards,
Etienne
On Wed, 28 Sept 2022 at 11:31, Sughosh Ganu wrote:
>
> Add documentation for the FWU Multi Bank Update feature. The document
> describes the steps needed for setting up the platform for the
t; partition. Add a driver for reading from and writing to the metadata
> when the updatable images and the metadata are stored on a block
> device which is formatted with GPT based partition scheme.
>
> Signed-off-by: Sughosh Ganu
> Reviewed-by: Patrick Delaunay
> Reviewed-by: Eti
-by: Patrick Delaunay
> Reviewed-by: Etienne Carriere
> ---
> Changes since V10:
> * s/fwu_update_active_index/fwu_set_active_index as per comment from
> Jassi
> * Change the argument type of fwu_set_active_index() to uint from u32
> as per comment from Jassi
> * s/
-by: Patrick Delaunay
> Reviewed-by: Ilias Apalodimas
> ---
Reviewed-by: Etienne Carriere with 1 comment:
Could the commit header line be updated? the patch no more targets
only DK2 among stm32mp1 platforms:
- stm32mp1: dk2: Add image information for capsule updates
+stm32mp1: Add im
Hello,
For info, this patch currently applies on branch 'next'.
It depends on commit 94ccfb78a4d6 ("drivers: tee: optee: discover
OP-TEE services") not yet merged in 'master'.
br,
etienne
On Wed, 28 Sept 2022 at 09:48, Etienne Carriere
wrote:
>
> This change makes OP-TEE t
On Mon, 26 Sept 2022 at 09:06, Sumit Garg wrote:
>
> On Fri, 23 Sept 2022 at 11:16, Etienne Carriere
> wrote:
> >
> > Hello Sumit,
> >
> >
> > On Thu, 22 Sept 2022 at 12:15, Sumit Garg wrote:
> > >
> > > On Thu, 22 Sept 2022 at 14:22, Eti
.
Signed-off-by: Etienne Carriere
---
drivers/tee/optee/core.c | 32 +++-
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c
index 9240277579..7da35f2eda 100644
--- a/drivers/tee/optee/core.c
+++ b/drivers
Hello Jassi, Sughosh and all,
On Wed, 28 Sept 2022 at 08:23, Sughosh Ganu wrote:
>
> On Tue, 27 Sept 2022 at 22:19, Jassi Brar wrote:
> >
> > On Tue, Sep 27, 2022 at 2:22 AM Sughosh Ganu
> > wrote:
> > >
> > > On Mon, 26 Sept 2022 at 20:24, Jassi Brar
> > > wrote:
> > > >
> > > > On Mon,
Hello Sughosh,
Thanks for the documentation. See comments on few typos found (with
help of my editor) and suggestions.
Best regards,
Etienne
On Thu, 15 Sept 2022 at 10:16, Sughosh Ganu wrote:
>
> Add documentattion for the FWU Multi Bank Update feature. The document
On Thu, 15 Sept 2022 at 10:15, Sughosh Ganu wrote:
>
> The FWU Multi Bank Update feature allows the platform to boot the
> firmware images from one of the partitions(banks). The first stage
> bootloader(fsbl) passes the value of the boot index, i.e. the bank
> from which the firmware images were
on a block
> > > device which is formatted with GPT based partition scheme.
> > >
> > > Signed-off-by: Sughosh Ganu
> > > Reviewed-by: Patrick Delaunay
> > > Reviewed-by: Etienne Carriere
> > > ---
> > > Changes since V9:
> &g
Hello Sumit,
On Thu, 22 Sept 2022 at 12:15, Sumit Garg wrote:
>
> On Thu, 22 Sept 2022 at 14:22, Etienne Carriere
> wrote:
> >
> > Hello Patrick and all,
> >
> > On Mon, 19 Sept 2022 at 16:49, Patrick DELAUNAY
> > wrote:
> > >
> > >
On Thu, 22 Sept 2022 at 13:27, Simon Glass wrote:
>
> Hi Etienne,
>
> On Thu, 22 Sept 2022 at 10:52, Etienne Carriere
> wrote:
> >
> > Hello Patrick and all,
> >
> > On Mon, 19 Sept 2022 at 16:49, Patrick DELAUNAY
> > wrote:
> > >
> >
ready have a workaround for RNG. The details are in
> >>>>>> commit 70812bb83da6 ("tee: optee: bind rng optee driver")
> >>>>>>
> >>>>>> So let's add a list of devices based on U-Boot Kconfig options
> >>>&
eturn
> EFI_ALREADY_STARTED when dealing with an U-Boot internal device.
>
> Reported-by: Etienne Carriere
> Fixes: b406eb04c360 ("efi_loader: disk: a helper function to delete efi_disk
> objects")
> Signed-off-by: Heinrich Schuchardt
> ---
> lib/efi_driver/efi_uclass.c |
Hello Heinirch,
On Fri, 9 Sept 2022 at 08:55, Heinrich Schuchardt wrote:
>
> On 9/8/22 07:56, Heinrich Schuchardt wrote:
> > On 9/7/22 23:10, Simon Glass wrote:
> >> Hi Etienne,
> >>
> >> On Wed, 7 Sept 2022 at 02:20, Etienne Carriere
> >&g
; testing.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> I just need the binary currently for testing.
> Probably we will need something simulating 'connect -r' in the unit tests.
> ---
>
Acked-by: Etienne Carriere
> lib/efi_selftest/Makefile
Hello Heinrich,
Thanks a lot for the detailed feedback on how to address root issue. Indeed
not an obvious fix.
Regards,
Etienne
On Thu, 8 Sept 2022 at 08:03, Heinrich Schuchardt
wrote:
> On 9/7/22 10:20, Etienne Carriere wrote:
> > Changes efi_delete_handle() to not free EF
1 - 100 of 322 matches
Mail list logo
