Re: [PATCH 2/3] rockchip: fix wrong PCI range address in rk3568 dtsi

2024-07-07 Thread Etienne Dublé
Le 25/06/2024 à 13:31, Etienne Dublé a écrit : The bus addresses should be isolated to each pci controller if I am not mistaken, so changing the bus address was probably just done as a workaround because of some other unknown bug. OK. Hum, could be an issue in pci core of U-Boot that

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

2024-06-27 Thread Etienne Dublé
Hi Quentin, Le 27/06/2024 à 14:27, Quentin Schulz a écrit : Hi Etienne, On 6/25/24 1:42 PM, Etienne Dublé wrote: Hello, Le 25/06/2024 à 12:25, Dragan Simic a écrit : Another option may be to name them "rtl8169@", with "" reflecting the PCI region address (so it

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

2024-06-25 Thread Etienne Dublé
ing fixed rules that would be based on the PCI region address. OK but the renaming occurs in the rtl8169 driver, that is used by several boards, whereas the PCI region addresses come from the device-tree, so they differ from board to board. Regards, Etienne -- Etienne Dublé CNRS / LIG - Bâtime

Re: [PATCH 2/3] rockchip: fix wrong PCI range address in rk3568 dtsi

2024-06-25 Thread Etienne Dublé
trollers. Will run some quick tests on my R5C later. OK, thanks for looking at it. Regards, Etienne -- Etienne Dublé CNRS / LIG - Bâtiment IMAG 700 avenue Centrale - 38401 St Martin d'Hères Bureau 426 - Tel 0457421431

Re: [PATCH 2/3] rockchip: fix wrong PCI range address in rk3568 dtsi

2024-06-25 Thread Etienne Dublé
er make it work until I found this suspecting PCI address. Cheers, Etienne -- Etienne Dublé CNRS / LIG - Bâtiment IMAG 700 avenue Centrale - 38401 St Martin d'Hères Bureau 426 - Tel 0457421431

Re: [PATCH 2/3] rockchip: fix wrong PCI range address in rk3568 dtsi

2024-06-24 Thread Etienne Dublé
in u-boot because of that. With the correct value (found in FriendlyElec's downstream u-boot repository), this 2nd ethernet interface now works. Signed-off-by: Etienne Dublé ---   dts/upstream/src/arm64/rockchip/rk3568.dtsi | 2 +- dts/upstream is only for patches coming from **merged** Lin

Re: [PATCH 1/3] net: give a different name to rtl8169 interfaces

2024-06-24 Thread Etienne Dublé
are (at least on this Nanopi board). The ethernet interfaces are only detected when running "pci enum". Another option may be to name them "rtl8169@", with "" reflecting the PCI region address (so it is unique and stable). What do you think? Cheers, Etienne -- Eti

Re: [PATCH v2] watchdog: Add a watchdog driver for Raspberry Pi boards

2023-01-25 Thread Etienne Dublé
ot; Set CONFIG_WATCHDOG_TIMEOUT_MSECS=15000 at most " +    "to avoid this warning.\n"); This seems way too long for a warning from this driver. Please shorten it to one line. The comment above already covers this limitation AFAICT. OK. Thanks, Etienne -- Etienne

Re: [PATCH] watchdog: Add a watchdog driver for Raspberry Pi boards

2023-01-24 Thread Etienne Dublé
Hi Stefan, Thanks for the feedback. I will send a v2 to fix those issues. Regards, Etienne Le 24/01/2023 à 14:38, Stefan Roese a écrit : Hi Etienne, On 1/24/23 14:20, Etienne Dublé wrote: This driver supports the bcm2835 watchdog found on Raspberry Pi boards. It is derived from the Linux

[PATCH] watchdog: Add a watchdog driver for Raspberry Pi boards

2023-01-24 Thread Etienne Dublé
This driver supports the bcm2835 watchdog found on Raspberry Pi boards. It is derived from the Linux driver and was tested on two Raspberry Pi board versions (B+ and 3B+). Signed-off-by: Etienne Dublé --- drivers/watchdog/Kconfig | 9 +++ drivers/watchdog/Makefile | 1

Re: [PATCH] bcmgenet: fix DMA buffer management

2020-07-20 Thread Etienne Dublé
ot;joe hershberger" Cc: u-boot@lists.denx.de, "ETIENNE DUBLE" Envoyé: Jeudi 16 Juillet 2020 18:02:11 Objet: Re: [PATCH] bcmgenet: fix DMA buffer management On 7/16/20 7:02 AM, Jason Wessel wrote: > On 7/9/20 3:11 AM, etienne.du...@gmail.com wrote: >> From: Etienne