Fix warnings after adding printf-like attribute format for
run_commandf():
warning: too many arguments for format [-Wformat-extra-args]
Signed-off-by: Evgeny Bachinin
Reviewed-by: Simon Glass
---
test/cmd/exit.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff
uot;, addr);
^
Signed-off-by: Evgeny Bachinin
Cc: Marek Vasut
---
Changes for v2:
- fdt_test_move(): due to addition of __printf(), fix compilation
after rebase atop 79bcd809f49 ("test: cmd: fdt: Test fdt move")
- not apply Reviewed-by due to changes above
As run_commandf() is variadic version of run_command() and just a wrapper,
hence apply similar run_command's test-cases.
Let's avoid warning about empty string passing:
warning: zero-length gnu_printf format string [-Wformat-zero-length]
assert(run_commandf("") == 0);
S
eters's type.
* Fix compilation error in case of -Wall, -Werror, -Wextra:
error: variable āiā set but not used [-Werror=unused-but-set-variable]
* Drop extra ret variable.
Signed-off-by: Evgeny Bachinin
---
Changes for v2:
- s/pr_err/pr_debug/ to reduce code size for rare errors
- s/EINVAL/E
hecks
[2]
https://lore.kernel.org/u-boot/20230310185409.22254-1-eabachi...@sberdevices.ru/
Evgeny Bachinin (4):
cli: run_commandf(): small fixups
unit-test: cover run_commandf() by test-cases
test: fdt: fix run_commandf() warnings
test: exit: fix run_commandf() warnings
common/cli.c
Fix warnings after adding printf-like attribute format for
run_commandf():
warning: too many arguments for format [-Wformat-extra-args]
Signed-off-by: Evgeny Bachinin
---
test/cmd/exit.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/test/cmd/exit.c b
uot;, addr);
^
Signed-off-by: Evgeny Bachinin
---
test/cmd/fdt.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/test/cmd/fdt.c b/test/cmd/fdt.c
index 7974c88c0d..be99bef134 100644
--- a/test/cmd/fdt.c
+++ b/test/cmd/fdt.c
@@ -72,7 +72,7 @@
As run_commandf() is variadic version of run_command() and just a wrapper,
hence apply similar run_command's test-cases.
Let's avoid warning about empty string passing:
warning: zero-length gnu_printf format string [-Wformat-zero-length]
assert(run_commandf("") == 0);
S
eters's type.
* Fix compilation error in case of -Wall, -Werror, -Wextra:
error: variable āiā set but not used [-Werror=unused-but-set-variable]
* Drop extra ret variable.
Signed-off-by: Evgeny Bachinin
---
common/cli.c | 19 ++-
include/command.h | 13 ++---
2 fil
ub CI loop has been passed successfully without
regression in context of github PR [1].
Links: [1] https://github.com/u-boot/u-boot/pull/277/checks
Evgeny Bachinin (4):
cli: run_commandf(): small fixups
unit-test: cover run_commandf() by test-cases
test: fdt: fix run_commandf() warnings
test:
10 matches
Mail list logo