Re: [PATCH] mmc: Add SPL_MMC_PWRSEQ to fix link issue when building SPL

2023-10-29 Thread Ferass El Hafidi
.9aef31ea5deb 100644 > --- a/include/mmc.h > +++ b/include/mmc.h > @@ -590,7 +590,7 @@ struct mmc_config { > uint f_max; > uint b_max; > unsigned char part_type; > -#ifdef CONFIG_MMC_PWRSEQ > +#if CONFIG_IS_ENABLED(MMC_PWRSEQ) > struct udevice *pwr_dev; > #endif > }; > @@ -808,7 +808,7 @@ int mmc_deinit(struct mmc *mmc); > */ > int mmc_of_parse(struct udevice *dev, struct mmc_config *cfg); > > -#ifdef CONFIG_MMC_PWRSEQ > +#if CONFIG_IS_ENABLED(MMC_PWRSEQ) > /** > * mmc_pwrseq_get_power() - get a power device from device tree > * > -- > 2.42.0 Otherwise, looks good to me. Acked-by: Ferass El Hafidi

Re: [PATCH 0/4] ARM: meson: Add boot over DFU RAM as an USB boot step

2023-10-23 Thread Ferass El Hafidi
Hi, > Add boot over DFU RAM as an alternate to running script at > a fixed address like done today. > > The main culprit is that it's not possible to do that > on G12A/SM1 platforms due to changes in the USB boot protocol. > > With this, U-Boot will present a DFU device with a ram slot where >

Re: [RFC] mmc: Remove alignment hole for cmdidx in struct mmc_cmd

2023-09-30 Thread Ferass El Hafidi
On Sat Sep 30, 2023 at 1:06 AM CEST, Jonas Karlman wrote: > The alignment hole caused by cmdidx in struct mmc_cmd cause strange > issues together with the peephole2 optimization on Amlogic SoCs. > Following was observed while working on SPL support for Amlogic SoCs. > > sd_get_capabilities()

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-29 Thread Ferass El Hafidi
> We should understand the implications of your patch on the code size. If > it leads to binary code growth, we should evaluate alternatives. This is not my patch, but Jonas'. But sure. Cheers.

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-29 Thread Ferass El Hafidi
On Fri Sep 29, 2023 at 1:42 AM CEST, Simon Glass wrote: > On Wed, 27 Sept 2023 at 15:44, Jonas Karlman wrote: > > > > spl_board_prepare_for_boot() is not called before jumping/invoking atf, > > optee, opensbi or linux images. > > > > Jump to image at the end of board_init_r() to fix this. > > > >

Re: [PATCH] spl: Jump to image at end of board_init_r

2023-09-29 Thread Ferass El Hafidi
Hi Heinrich, On Fri Sep 29, 2023 at 2:57 AM CEST, Heinrich Schuchardt wrote: > In SPL we are fighting for every byte of binary size. > > What is the impact of this change on the code size? > > I would expect that your increasing it; especially if only one of the > CONFIG_OPTIONS is enabled. > >

Re: [PATCH] mmc: Add SPL_MMC_PWRSEQ to fix link issue when building SPL

2023-09-28 Thread Ferass El Hafidi
On Mon Sep 25, 2023 at 11:55 PM CEST, Jonas Karlman wrote: > With MMC_PWRSEQ enabled the following link issue may happen when > building SPL and SPL_PWRSEQ is not enabled. > > aarch64-linux-gnu-ld.bfd: drivers/mmc/meson_gx_mmc.o: in function > `meson_mmc_probe': >

Re: [PATCH v2 0/1] meson: Demonstration of using binman to produce the image

2023-08-31 Thread Ferass El Hafidi
Hi Simon, On Thu Aug 31, 2023 at 9:54 AM CEST, neil.armstrong wrote: > > Thanks for your efforts on this. I look forward to seeing where it ends up. I hope we can get it to at least boot! > >> Honestly, in my opinion, including proprietary and poorly-written > >> Amlogic utilities lacking a

Re: [PATCH v2 0/1] meson: Demonstration of using binman to produce the image

2023-08-30 Thread Ferass El Hafidi
Hi Simon, > So I wonder how best to move this forward so that we can build things > using binman and everything works? It's still not ready yet, but I'm working on porting U-Boot SPL to some Amlogic SoCs [1]. I'm currently working on Amlogic S905 boards, but eventually I'll work on Amlogic S905X

Re: [PATCH v3 0/3] initial support for the Videostrong KII Pro

2023-05-13 Thread Ferass EL HAFIDI
> Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-amlogic > (u-boot-amlogic) No problem. I'm happy to help. -- f_

Re: [PATCH v2 0/3] initial support for the Videostrong KII Pro

2023-05-07 Thread Ferass EL HAFIDI
Superseded by v3 -- f_

[PATCH v3 3/3] doc: boards: amlogic: add documentation for KII Pro

2023-05-07 Thread Ferass El Hafidi
Add build instructions for the KII Pro set-top box. Signed-off-by: Ferass El Hafidi --- board/amlogic/p200/MAINTAINERS| 1 + doc/board/amlogic/index.rst | 1 + doc/board/amlogic/videostrong-kii-pro.rst | 112 ++ 3 files changed, 114 insertions

[PATCH v3 2/3] boards: amlogic: add KII Pro defconfig

2023-05-07 Thread Ferass El Hafidi
Add configurations for the Videostrong KII Pro set-top box. This defconfig is cloned from the WeTek Play2's. Signed-off-by: Ferass El Hafidi --- board/amlogic/p200/MAINTAINERS| 1 + configs/videostrong-kii-pro_defconfig | 70 +++ 2 files changed, 71 insertions

[PATCH v3 1/3] arm: dts: add support for Videostrong KII Pro

2023-05-07 Thread Ferass El Hafidi
Import the device tree from mainline linux (v6.4-rc1) and add the old PHY reset bindings in the PHY node, else U-Boot and linux won't be able to use the PHY. Signed-off-by: Ferass El Hafidi --- arch/arm/dts/Makefile | 1 + arch/arm/dts/meson-gxbb-kii-pro-u-boot.dtsi

[PATCH v3 0/3] initial support for the Videostrong KII Pro

2023-05-07 Thread Ferass El Hafidi
uot;From:" Changes since v2: * Update defconfig to work with U-Boot/master Ferass El Hafidi (3): arm: dts: add support for Videostrong KII Pro boards: amlogic: add KII Pro defconfig doc: boards: amlogic: add documentation for KII Pro arch/arm/dts/Makefile | 1 +

Re: [PATCH 0/3] initial support for the Videostrong KII Pro

2023-05-07 Thread Ferass EL HAFIDI
Superseded by v2 (will appear soon) -- f_

[PATCH v2 3/3] doc: boards: amlogic: add documentation for KII Pro

2023-05-07 Thread Ferass El Hafidi
Add build instructions for the KII Pro set-top box. Signed-off-by: Ferass El Hafidi --- board/amlogic/p200/MAINTAINERS| 1 + doc/board/amlogic/index.rst | 1 + doc/board/amlogic/videostrong-kii-pro.rst | 112 ++ 3 files changed, 114 insertions

[PATCH v2 2/3] boards: amlogic: add KII Pro defconfig

2023-05-07 Thread Ferass El Hafidi
Add configurations for the Videostrong KII Pro set-top box. This defconfig is cloned from the WeTek Play2's. Signed-off-by: Ferass El Hafidi --- board/amlogic/p200/MAINTAINERS| 1 + configs/videostrong-kii-pro_defconfig | 70 +++ 2 files changed, 71 insertions

[PATCH v2 1/3] arm: dts: add support for Videostrong KII Pro

2023-05-07 Thread Ferass El Hafidi
Import the device tree from mainline linux (v6.4-rc1) and add the old PHY reset bindings in the PHY node, else U-Boot and linux won't be able to use the PHY. Signed-off-by: Ferass El Hafidi --- arch/arm/dts/Makefile | 1 + arch/arm/dts/meson-gxbb-kii-pro-u-boot.dtsi

[PATCH v2 0/3] initial support for the Videostrong KII Pro

2023-05-07 Thread Ferass El Hafidi
/60Hz display - 3x USB 2.0 host - 1x USB 2.0 otg - microSD - Infrared receiver - Blue LED - Red LED - Power button (case, front) - Reset button (underside) - DVB Card: DVB-S and DVB-T/C Changes since v1: - Fix typo ("Boardcom" -> "Broadcom") - Remove duplicate &q

[PATCH 3/3] doc: boards: amlogic: add documentation for KII Pro

2023-05-06 Thread Ferass El Hafidi
From: Ferass El Hafidi Add build instructions for the KII Pro set-top box. Signed-off-by: Ferass El Hafidi --- board/amlogic/p200/MAINTAINERS| 1 + doc/board/amlogic/index.rst | 1 + doc/board/amlogic/videostrong-kii-pro.rst | 112 ++ 3 files

[PATCH 2/3] boards: amlogic: add KII Pro defconfig

2023-05-06 Thread Ferass El Hafidi
From: Ferass El Hafidi Add configurations for the Videostrong KII Pro set-top box. This defconfig is cloned from the WeTek Play2's. Signed-off-by: Ferass El Hafidi --- board/amlogic/p200/MAINTAINERS| 1 + configs/videostrong-kii-pro_defconfig | 70 +++ 2 files

[PATCH 1/3] arm: dts: add support for Videostrong KII Pro

2023-05-06 Thread Ferass El Hafidi
From: Ferass El Hafidi Import the device tree from mainline linux (v6.4-rc1) and add the old PHY reset bindings in the PHY node, else U-Boot and linux won't be able to use the PHY. Signed-off-by: Ferass El Hafidi --- arch/arm/dts/Makefile | 1 + arch/arm/dts/meson-gxbb

[PATCH 0/3] initial support for the Videostrong KII Pro

2023-05-06 Thread Ferass El Hafidi
From: Ferass El Hafidi The Videostrong KII Pro is a set-top box based on the Amlogic p201 reference board and with the following specification: - Amlogic S905 ARM Cortex-A53 quad-core SoC @ 1.5GHz - ARM Mali 450 GPU - 2GB DDR3 SDRAM - 16GB eMMC - Gigabit Ethernet - Boardcom BCM4335 WiFi