RE: [PATCH v1 1/1] arm64: zynqmp: Fix k24 psu_init_gpl.c clocking

2023-12-14 Thread Frager, Neal
Hi Michal, > >> This patch corrects the k24 som clocking configuration such that the serdes > >> Corrects the ... > > Ok. > >> clocks are correctly enabled and the usb0 is configured to use the psgtr >> refclk2 for usb3 mode. > >> I sort of have no problem with this patch but it should be bet

RE: [PATCH v1 1/1] arm64: zynqmp: Fix k24 psu_init_gpl.c clocking

2023-12-14 Thread Frager, Neal
Hi Michal, > This patch corrects the k24 som clocking configuration such that the serdes > Corrects the ... Ok. > clocks are correctly enabled and the usb0 is configured to use the psgtr > refclk2 for usb3 mode. > I sort of have no problem with this patch but it should be better described. > P

RE: [PATCH v2 1/1] arm64: zynqmp: Add output-enable pins to SOMs

2023-12-14 Thread Frager, Neal
Hi Michal, > Now that the zynqmp pinctrl driver supports the tri-state registers, make > sure that the pins requiring output-enable are configured appropriately for > SOMs. > > Without it, all tristate setting for MIOs, which are not related to SOM > itself, are using default configuration which

RE: [PATCH v1 1/1] arm64: zynqmp: Add output-enable pins to SOMs

2023-12-11 Thread Frager, Neal
> Now that the zynqmp pinctrl driver supports the tri-state registers, make > sure that the pins requiring output-enable are configured appropriately for > SOMs. > Without it, all tristate setting for MIOs, which are not related to SOM > itself, are using default configuration which is not corr

RE: [PATCH v1 1/1] arch/arm/dts/zynqmp-sck-kr-g-revB.dts: add output-enable pins

2023-08-31 Thread Frager, Neal
Hi Michal, > Hi Neal, > regarding subject. > arm64: zynqmp: Add output-enable pins for kr260-revB > should be better option. Ok, no problem. > Now that the zynqmp pinctrl driver supports the tri-state registers, > this patch > remove "this patch" Ok > makes sure that the pins requiring ou

RE: [PATCH v1 1/1] makefile: add multi_dtb_fit dep

2022-12-22 Thread Frager, Neal
Hi Simon, > > With certain gcc compilers, the u-boot.itb is built immediately after > dtb generation. If CONFIG_MULTI_DTB_FIT is used, it is possible that > the fit-dtb.blob is not finished in time. > > This patch adds a necessary dependency to guarantee that the > fit-dtb.blob is built before