[U-Boot] [PATCH] Add some missing endian conversions in fdt_support.c

2011-11-08 Thread Gabe Black
. This change adds the missing conversions. Signed-off-by: Gabe Black gabebl...@chromium.org --- common/fdt_support.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/fdt_support.c b/common/fdt_support.c index bdda64d..c501604 100644 --- a/common/fdt_support.c +++ b

[U-Boot] [PATCH] [fdt] Fix constness of the fdt void pointer in fdt_getprop_u32_default

2011-11-08 Thread Gabe Black
The function fdt_getprop_u32_default doesn't modify the fdt, so it can use a const void * for its fdt argument. Signed-off-by: Gabe Black gabebl...@chromium.org --- common/fdt_support.c |4 ++-- include/fdt_support.h |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[U-Boot] [PATCH] [build] Automatically build the device tree if DEV_TREE_SEPARATE is set

2011-11-08 Thread Gabe Black
to know the value of $(obj) when invoking make. Signed-off-by: Gabe Black gabebl...@chromium.org --- Makefile |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 294c762..654e07e 100644 --- a/Makefile +++ b/Makefile @@ -371,6 +371,10 @@ $(obj)u

[U-Boot] [PATCH] [x86] [zboot] Change printf to puts to avoid a buffer overflow

2011-11-08 Thread Gabe Black
with a few calls to puts that have the same effect. This may perform slightly better because it should avoid a copy and scanning for format specifiers. The amount of time it actually takes up is very tiny relative to everything else so in practice that's probably irrelevant. Signed-off-by: Gabe Black

[U-Boot] [PATCH] [x86] Wrap small helper functions from libgcc to avoid an ABI mismatch

2011-11-08 Thread Gabe Black
unmodified. Signed-off-by: Gabe Black gabebl...@chromium.org --- arch/x86/config.mk|3 +++ arch/x86/lib/Makefile |1 + arch/x86/lib/gcc.c| 38 ++ 3 files changed, 42 insertions(+), 0 deletions(-) create mode 100644 arch/x86/lib/gcc.c diff --git

[U-Boot] [PATCH] [x86] Fix some bugs in the i8402 driver when no controller is present

2011-11-08 Thread Gabe Black
as the return value of the function. That would give the right answer if it wasn't for that extra decrement because a timeout would indicate that the buffer never became empty. This change fixes both of those bugs. Signed-off-by: Gabe Black gabebl...@chromium.org --- drivers/input/i8042.c | 12

[U-Boot] [PATCH] Import the glibc implementation of x86 memset into u-boot

2011-11-08 Thread Gabe Black
The new implementation is about twice as fast as the old. Signed-off-by: Gabe Black gabebl...@chromium.org --- arch/x86/include/asm/string.h |2 +- arch/x86/lib/Makefile |1 + arch/x86/lib/string.c | 87 + 3 files changed, 89

Re: [U-Boot] [PATCH v2] [x86] Don't relocate symbols which point to things that aren't relocated

2011-11-08 Thread Gabe Black
it's outside the scope of this change. Gabe On Tue, Nov 8, 2011 at 5:46 AM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 08 November 2011 02:08:42 Gabe Black wrote: This change adds an upper bound for symbols which are fixed up after u-boot is relocated into RAM. This way portions

[U-Boot] [PATCH v2] [driver][cfb] Make the software cursor non-destructive

2011-11-08 Thread Gabe Black
to be, the end result is that the cursor is where it's supposed to be with the other text preserved. Signed-off-by: Gabe Black gabebl...@chromium.org --- Changes in v2: - Tidy up commit message wording. - Undo change to documenting comment. - Undo minor whitespace tweak. - Consolidate CONFIG_CONSOLE_CURSOR

[U-Boot] [PATCH v2] x86: Fix how the location of the realmode and bios blobs are calculated

2011-11-08 Thread Gabe Black
in bios_setup so that it refers to the version in RAM (if one existed) instead of the one in ROM. To correct for that, the offset actually needs to be subtracted out again to translate the address back into the ROM. The net effect is that for both blobs, a + needs to be changed to a -. Signed-off-by: Gabe

[U-Boot] [PATCH v3] x86: Don't relocate symbols which point to things that aren't relocated

2011-11-08 Thread Gabe Black
This change adds an upper bound for symbols which are fixed up after u-boot is relocated into RAM. This way portions that are left at their original location can be referred to without having to manually fix up any pointers. Signed-off-by: Gabe Black gabebl...@chromium.org --- Changes in v2

Re: [U-Boot] [PATCH] [x86] Wrap small helper functions from libgcc to avoid an ABI mismatch

2011-11-08 Thread Gabe Black
On Tue, Nov 8, 2011 at 5:33 AM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 08 November 2011 04:27:44 Gabe Black wrote: When gcc compiles some 64 bit operations on a 32 bit machine, it generates calls to small functions instead of instructions which do the job directly. Those

[U-Boot] [PATCH v2] x86: Wrap small helper functions from libgcc to avoid an ABI mismatch

2011-11-08 Thread Gabe Black
of the symbols covered by the coreboot code, so it was used unmodified. Signed-off-by: Gabe Black gabebl...@chromium.org --- Changes in v2: - Change the [x86] tag to x86: - Mention -mregparm in the commit message. - Get rid of a stray line which snuck in during a rebase. arch/x86/config.mk|2 ++ arch

Re: [U-Boot] [PATCH] [PCI] Update pci_ids.h from current Linux sources

2011-11-08 Thread Gabe Black
On Tue, Nov 8, 2011 at 5:34 AM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 08 November 2011 04:43:32 Gabe Black wrote: This change copies over the pci_ids.h file from Linux verbatim, plus a few ids that had been added by hand. to be clear, the few ids you refer to are already

[U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Gabe Black
The new implementation is about twice as fast as the old. Signed-off-by: Gabe Black gabebl...@chromium.org --- Changes in v2: Update the commit summary as suggested by Mike Frysinger. arch/x86/include/asm/string.h |2 +- arch/x86/lib/Makefile |1 + arch/x86/lib/string.c

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Gabe Black
, Nov 8, 2011 at 4:45 PM, Graeme Russ graeme.r...@gmail.com wrote: Hi Gabe, On Wed, Nov 9, 2011 at 9:40 AM, Gabe Black gabebl...@chromium.org wrote: The new implementation is about twice as fast as the old. I don't get it - If this is the glibc implementation, we aren't we just using

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Gabe Black
On Tue, Nov 8, 2011 at 5:10 PM, Graeme Russ graeme.r...@gmail.com wrote: Hi Gabe, first up - Please stop top-posting On Wed, Nov 9, 2011 at 11:59 AM, Gabe Black gabebl...@chromium.org wrote: I'm pretty sure u-boot doesn't link with glibc. I'd expect that to cause all sorts of problems

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Gabe Black
On Tue, Nov 8, 2011 at 5:25 PM, Graeme Russ graeme.r...@gmail.com wrote: On Wed, Nov 9, 2011 at 12:15 PM, Gabe Black gabebl...@google.com wrote: On Tue, Nov 8, 2011 at 5:10 PM, Graeme Russ graeme.r...@gmail.com wrote: Hi Gabe, first up - Please stop top-posting On Wed, Nov 9

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Gabe Black
On Tue, Nov 8, 2011 at 8:55 PM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 08 November 2011 21:53:04 Graeme Russ wrote: Oops, I meant U-Boot implements a subset of (g)libc. I think I understand why - U-Boot needs specific implementations of stdio (printf() and friends) Because we

[U-Boot] [PATCH] [x86] Fix how the location of the realmode and bios blobs are calculated

2011-11-07 Thread Gabe Black
in bios_setup so that it refers to the version in RAM (if one existed) instead of the one in ROM. To correct for that, the offset actually needs to be subtracted out again to translate the address back into the ROM. The net effect is that for both blobs, a + needs to be changed to a -. Signed-off-by: Gabe

[U-Boot] [PATCH] [x86] Don't relocate symbols which point to things that aren't relocated

2011-11-07 Thread Gabe Black
This change adds an upper bound for symbols which are fixed up after u-boot is relocated into RAM. This way portions that are left at their original location can be referred to without having to manually fix up any pointers. Signed-off-by: Gabe Black gabebl...@chromium.org --- arch/x86/lib

Re: [U-Boot] [PATCH] [x86] Don't relocate symbols which point to things that aren't relocated

2011-11-07 Thread Gabe Black
a bug and is important to get in, while the second improves the mechanism to avoid the bug all together. Gabe On Mon, Nov 7, 2011 at 10:58 PM, Gabe Black gabebl...@chromium.org wrote: This change adds an upper bound for symbols which are fixed up after u-boot is relocated into RAM. This way

[U-Boot] [PATCH v2] [x86] Don't relocate symbols which point to things that aren't relocated

2011-11-07 Thread Gabe Black
This change adds an upper bound for symbols which are fixed up after u-boot is relocated into RAM. This way portions that are left at their original location can be referred to without having to manually fix up any pointers. Signed-off-by: Gabe Black gabebl...@chromium.org --- Changes in v2

[U-Boot] [PATCH v2] [x86] Add a target for running as a coreboot payload

2011-11-04 Thread Gabe Black
Add a target for running u-boot as a coreboot payload in boards.cfg. --- Changes in v2: Change capitalization of the x86 tag. Signed-off-by: Gabe Black gabebl...@chromium.org boards.cfg |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/boards.cfg b/boards.cfg index

[U-Boot] [PATCH v3] [x86] Add a target for running as a coreboot payload

2011-11-04 Thread Gabe Black
From: Gabe Black gabebl...@google.com Add a target for running u-boot as a coreboot payload in boards.cfg. Signed-off-by: Gabe Black gabebl...@chromium.org --- Changes in v2: Change capitalization of the x86 tag. Changes in v3: Move the Signed-off-by line up. boards.cfg |1 + 1 files

[U-Boot] [PATCH] [x86] Add a basic implementation for a coreboot board

2011-11-04 Thread Gabe Black
Signed-off-by: Gabe Black gabebl...@chromium.org --- board/chromebook-x86/coreboot/Makefile | 59 +++ board/chromebook-x86/coreboot/coreboot.c | 88 ++ board/chromebook-x86/coreboot/coreboot_pci.c | 30 board/chromebook-x86

[U-Boot] [PATCH v2] [x86] Add a basic implementation for a coreboot board

2011-11-04 Thread Gabe Black
From: Gabe Black gabebl...@google.com Signed-off-by: Gabe Black gabebl...@chromium.org --- Changes in v2: Get rid of some dead/unnecessary code in the Makefile and coreboot.c. board/chromebook-x86/coreboot/Makefile | 53 +++ board/chromebook-x86/coreboot/coreboot.c

Re: [U-Boot] [PATCH v2] [x86] Add a basic implementation for a coreboot board

2011-11-04 Thread Gabe Black
The early startup code is in arch/x86/cpu/start.S or start16.S depending on the state of the CPU when u-boot is entered, and this code is called back into at various points during startup. You can see that those callbacks stubbed out where there's a label and then a jump back immediately after it,

[U-Boot] [PATCH] [X86] Add a target for running as a coreboot payload

2011-11-03 Thread Gabe Black
Add a target for running u-boot as a coreboot payload in boards.cfg. Signed-off-by: Gabe Black gabebl...@chromium.org --- boards.cfg |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/boards.cfg b/boards.cfg index 604becf..cc7dd2b 100644 --- a/boards.cfg +++ b/boards.cfg

Re: [U-Boot] [PATCH] Move the SC520 specific pci.h header into an sc520 directory.

2011-10-31 Thread Gabe Black
://patchwork.ozlabs.org/patch/120011/ Also, you patch does a delete then create rather than a file rename - When you use git-format-patch, use the --find-renames option Regards, Graeme On 29/10/11 09:34, Gabe Black wrote: The arch/i386/include/asm/ic/pci.h header file include definitions which were

Re: [U-Boot] [PATCH] The type expected by %zd is ssize_t, but it was being passed a size_t.

2011-10-31 Thread Gabe Black
This was necessary at one point, but I've been trying to get that warning to happen again so I can add it to the change message and it won't. These early patches were done 5 or 6 months ago with a different version of the repository, a different compiler, on a different system, etc., so it'd be

[U-Boot] [PATCH] The type expected by %zd is ssize_t, but it was being passed a size_t.

2011-10-28 Thread Gabe Black
Signed-off-by: Gabe Black gabebl...@chromium.org --- common/cmd_nvedit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index 396a171..d9dc3f2 100644 --- a/common/cmd_nvedit.c +++ b/common/cmd_nvedit.c @@ -862,7 +862,7 @@ static

[U-Boot] [PATCH] Move the SC520 specific pci.h header into an sc520 directory.

2011-10-28 Thread Gabe Black
The arch/i386/include/asm/ic/pci.h header file include definitions which were not generic to i386 and where specifically for SC520. This change moves that header into a directory which more accurately reflects that. Signed-off-by: Gabe Black gabebl...@chromium.org --- arch/x86/include/asm/ic

[U-Boot] [PATCH] [x86] Remove the prototype for the unused function board_init

2011-10-28 Thread Gabe Black
From: Gabe Black gabebl...@google.com Signed-off-by: Gabe Black gabebl...@chromium.org --- arch/x86/include/asm/u-boot-x86.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/x86/include/asm/u-boot-x86.h b/arch/x86/include/asm/u-boot-x86.h index accc8fa..d3e2f4c

[U-Boot] [PATCH v1] Fix a compiler warning in arch/x86/lib/realmode.c

2011-10-20 Thread Gabe Black
Ensure that the value being passed to a %d format specifier is of type int. Signed-off-by: Gabe Black gabebl...@chromium.org --- arch/x86/lib/realmode.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/lib/realmode.c b/arch/x86/lib/realmode.c index c113393

<    1   2