Re: [PATCH v2 1/5] boot: android: Provide vendor_bootimg_addr in boot_get_fdt()

if (android_image_get_dtb_by_index((ulong)hdr, 0, > + if (android_image_get_dtb_by_index((ulong)hdr, > get_avendor_bootimg_addr(), >dtb_idx, _addr, > _size)) { > fdt_blob = (char *)map_sysmem(fdt_addr, 0); > if (fd

Re: [PATCH 2/3] avb: Implement get_preloaded_partition callback

_data; > > ops_data->ops.read_from_partition = read_from_partition; > +#ifdef CONFIG_ANDROID_BOOT_IMAGE Please use CONFIG_IS_ENABLED() macro > + ops_data->ops.get_preloaded_partition = get_preloaded_partition; > +#endif > ops_data->ops.write_to_partition = write_to_partition; > ops_data->ops.validate_vbmeta_public_key = validate_vbmeta_public_key; > ops_data->ops.read_rollback_index = read_rollback_index; > -- > 2.40.1 > -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk

Re: [PATCH 3/3] abootimg: Implement smart image load feature

clude/image.h > index c5b288f62b..7d8ff40c3f 100644 > --- a/include/image.h > +++ b/include/image.h > @@ -1826,6 +1826,18 @@ struct andr_image_data; > bool android_image_get_data(const void *boot_hdr, const void > *vendor_boot_hdr, > struct andr_image_data *data); > > +/** > + * android_image_get_valuable_size() - get the size of the android image > + * > + * This function checks if the image is Android boot image and returns the > + * valuable size of the image. > + * > + * @hdr_addr: Boot image header address (boot or vendor_boot) > + * > + * @return size of the image on success, 0 on failure > + */ > +size_t android_image_get_valuable_size(const void *hdr_addr); > + > struct andr_boot_img_hdr_v0; > > /** > -- > 2.40.1 > -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk

Re: [PATCH] android: Fix ramdisk loading for bootimage v3+

img_data.ramdisk_ptr, DIV_ROUND_UP(img_data.ramdisk_size, > 1024)); > + img_data.ramdisk_addr, DIV_ROUND_UP(img_data.ramdisk_size, > 1024)); > > - *rd_data = img_data.ramdisk_ptr; > + *rd_data = img_data.ramdisk_addr; > > *rd_len = img_data.ramdisk_size; > return 0; > -- > 2.40.1 > Reviewed-by: Igor Opaniuk -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk

Re: [PATCH 5/6] bootstd: Add a bootmeth for Android

w, > + .read_file = android_read_file, > + .boot = android_boot, > +}; > + > +static const struct udevice_id android_bootmeth_ids[] = { > + { .compatible = "u-boot,android" }, > + { } > +}; > + > +U_BOOT_DRIVER(

Re: [PATCH 4/6] android: boot: Add set_abootimg_addr() and set_avendor_bootimg_addr()

Android vendor boot image address > + * > + * Return: no returned results > + */ > +void set_avendor_bootimg_addr(ulong addr); > + > /** > * board_fit_config_name_match() - Check for a matching board name > * > > -- > 2.45.0 > Reviewed-by: Igor Opaniuk -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk

Re: [PATCH 3/6] bootstd: Add bootflow_iter_check_mmc() helper

is used (e.g. ethernet) > + */ > +int bootflow_iter_check_mmc(const struct bootflow_iter *iter); > + > /** > * bootflow_iter_check_sf() - Check that a bootflow uses SPI FLASH > * > > -- > 2.45.0 > Reviewed-by: Igor Opaniuk A bit offtopic (just an idea for futu

Re: [PATCH 2/6] boot: android: Add image_android_get_version()

oid_image_get_data() declaration, and just use andr_boot_img_hdr_v0 *boot_hdr as first param instead (like it's done for example in android_boot_image_v0_v1_v2_parse_hdr()) and then rely on implicit cast when this function is used. this is of course all a matter of preference, just thinking out loud -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk

Re: [PATCH 1/6] boot: android: Provide vendor_bootimg_addr in boot_get_fdt()

_addr, > _size)) { > fdt_blob = (char *)map_sysmem(fdt_addr, 0); > if (fdt_check_header(fdt_blob)) > > -- > 2.45.0 > Reviewed-by: Igor Opaniuk -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk

Re: [PATCH 1/1] dm: typo prbing

such as prbing or removing a device. Subsystems can > + operations, such as probing or removing a device. Subsystems can > register a 'spy' function that is called when the event occurs. Such > subsystems must select this option. > > -- > 2.43.0 >

Re: [PATCH] ARM: stm32: Ping IWDG on exit from PSCI suspend code

ved immediately afterward, but too late to be > handled by the suspend main loop. In case either of the IWDG is > enabled, ping it first and then return to the OS. > > Signed-off-by: Marek Vasut > --- > Cc: Igor Opaniuk > Cc: Patrice Chotard > Cc: Patrick Delaunay > Cc: Si

Re: [PATCH v2 05/28] image: remove redundant hash includes

--- a/boot/image.c > +++ b/boot/image.c > @@ -26,8 +26,6 @@ > #endif > > #include > -#include > -#include > #include > #include > > -- > 2.25.1 > Reviewed-by: Igor Opaniuk -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk

Re: Distro Boot instructions with examples

tpc.h:84:#include ./include/configs/imx8mp_venice.h:21:#include ./include/configs/stm32f746-disco.h:30:#include ... Hope this helps. [1] https://developer.toradex.com/linux-bsp/os-development/boot/distro-boot/ -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mail

Re: [PATCH 070/149] board: hisilicon: Remove and add needed includes

On Tue, Apr 30, 2024 at 7:44 PM Tom Rini wrote: > > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Peter Griffin > Cc: Manivannan Sadhasivam > Cc: Jorge Ramirez-Ortiz > Cc:

[PATCH v1] tee: sandbox: check for buffer size

Add additional check for buffer size when reading out persistent storage value and provide back actual value size. Signed-off-by: Igor Opaniuk --- drivers/tee/sandbox.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/tee/sandbox.c b/drivers/tee/sandbox.c

Re: [PATCH v1 05/25] configs: stm32mp1: Enable BUTTON_GPIO flag for stm32mp13_defconfig

USE_DT=y > +CONFIG_BUTTON=y > +CONFIG_BUTTON_GPIO=y > CONFIG_CLK_SCMI=y > CONFIG_SET_DFU_ALT_INFO=y > CONFIG_USB_FUNCTION_FASTBOOT=y > -- > 2.25.1 > Reviewed-by: Igor Opaniuk -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk

Re: [PATCH v1 01/25] configs: stm32mp13: Enable FASTBOOT

T_DOWNLOAD=y > CONFIG_ERRNO_STR=y > # CONFIG_LMB_USE_MAX_REGIONS is not set > CONFIG_LMB_MEMORY_REGIONS=2 > -- > 2.25.1 > Reviewed-by: Igor Opaniuk -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk

Re: [PATCH 1/1] test: typo curren

+# Check the current BootOrder > for i in ('test 3', 'Quit'): > u_boot_console.p.expect([i]) > > -- > 2.43.0 > Reviewed-by: Igor Opaniuk -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk

Re: [PATCH 1/5] zfs: Fix malloc() success check

} > if (level == 0) { > err = zio_read(bp, endian, buf, 0, data); > endian = (zfs_to_cpu64(bp->blk_prop, endian) >> > 63) & 1; > -- > 2.44.0 > > -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk <http://ua.linkedin.com/in/iopaniuk>

[PATCH v5 5/5] tee: remove common.h inclusion

Apalodimas Signed-off-by: Igor Opaniuk --- Changes in v5: - Extended commit message for "cmd: optee_rpmb: close tee session" - Added R-b tag Changes in v4: - Rebased on the latest master and excluded "tee: sandbox: fix spelling errors", as it was merged already by Heinrich Schu

[PATCH v5 4/5] test: py: add optee_rpmb tests

Add read/write tests for optee_rpmb cmd. Signed-off-by: Igor Opaniuk --- (no changes since v1) test/py/tests/test_optee_rpmb.py | 20 1 file changed, 20 insertions(+) create mode 100644 test/py/tests/test_optee_rpmb.py diff --git a/test/py/tests/test_optee_rpmb.py b

[PATCH v5 3/5] cmd: optee_rpmb: build cmd for sandbox

Tested-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk --- (no changes since v2) Changes in v2: - Applied R-b and T-b tags cmd/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index 61e280fb1a4..227d66a7eea 100644 --- a/cmd/Kconfig +++ b/cmd/K

[PATCH v5 2/5] cmd: optee_rpmb: close tee session

registered in OP-TEE OS core (obvious resource leak). Signed-off-by: Igor Opaniuk --- Changes in v5: - Extended commit message, added more details about the reasons why the change was needed cmd/optee_rpmb.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff

[PATCH v5 1/5] tee: optee: fix description in Kconfig

Fix OPTEE_TA_AVB symbol description in Kconfig: s/"write"rb"/"write_rb"/g Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas Signed-off-by: Igor Opaniuk --- (no changes since v2) Changes in v2: - Applied R-b tags drivers/tee/optee/Kconfig | 2 +- 1

[PATCH v5 0/5] TEE: minor cleanup

in v3: - Added calls for closing tee session after every read/write operation Changes in v2: - Fixed chimp_optee.c:37:9: error: implicit declaration of function 'memset' - Applied R-b and T-b tags Igor Opaniuk (5): tee: optee: fix description in Kconfig cmd: optee_rpmb: close tee session cmd: o

Re: [PATCH v4 2/5] cmd: optee_rpmb: close tee session

Ilias, On Thu, Apr 4, 2024 at 1:00 PM Ilias Apalodimas wrote: > Hi Igor, > > On Thu, 4 Apr 2024 at 13:18, Igor Opaniuk wrote: > > > > Hi Ilias, > > > > On Thu, Apr 4, 2024 at 10:54 AM Ilias Apalodimas < > ilias.apalodi...@linaro.org> wrote: > >&g

Re: [PATCH v4 2/5] cmd: optee_rpmb: close tee session

HI Ilias On Thu, Apr 4, 2024 at 12:15 PM Igor Opaniuk wrote: > Hi Ilias, > > On Thu, Apr 4, 2024 at 10:40 AM Ilias Apalodimas < > ilias.apalodi...@linaro.org> wrote: > >> Hi Igor, >> >> I was about to apply the series, but noticed neither me or

[PATCH v1] MAINTAINERS: add entries for tee-related orphaned files

Add orphaned TEE/OP-TEE-related files to TEE subsystem entry in MAINTAINERS. This includes: - optee_rpmb cmd and test for it - Misc. OP-TEE tests - OP-TEE SCMI agent implementation - Documentation, including device tree bindings Signed-off-by: Igor Opaniuk --- MAINTAINERS | 9 + 1 file

Re: [PATCH v4 2/5] cmd: optee_rpmb: close tee session

Jens were > cc'ed > > on this. Adding Jens to the party > > > > On Thu, Apr 04, 2024 at 10:13:49AM +0200, Igor Opaniuk wrote: > > > Add calls for closing tee session after every read/write operation. > > > > What the patch is pretty obvious, but I am missing

Re: [PATCH v4 2/5] cmd: optee_rpmb: close tee session

by patman. Looks like there is no entry in MAINTAINERS for this specific file, that's why only Tom was added. I'll send a patch for that if you don't mind. > On Thu, Apr 04, 2024 at 10:13:49AM +0200, Igor Opaniuk wrote: > > Add calls for closing tee session after every read/write operation

[PATCH v4 5/5] tee: remove common.h inclusion

The usage of the common.h include file is deprecated [1], and has already been removed from several files. Get rid of all inclusions in the "drivers/tee" directory, and replace it with required include files directly where needed. [1] doc/develop/codingstyle.rst Signed-off-by: Ig

[PATCH v4 4/5] test: py: add optee_rpmb tests

Add read/write tests for optee_rpmb cmd. Signed-off-by: Igor Opaniuk --- (no changes since v1) test/py/tests/test_optee_rpmb.py | 20 1 file changed, 20 insertions(+) create mode 100644 test/py/tests/test_optee_rpmb.py diff --git a/test/py/tests/test_optee_rpmb.py b

[PATCH v4 3/5] cmd: optee_rpmb: build cmd for sandbox

Tested-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk --- (no changes since v2) Changes in v2: - Applied R-b and T-b tags cmd/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index 61e280fb1a4..227d66a7eea 100644 --- a/cmd/Kconfig +++ b/cmd/K

[PATCH v4 2/5] cmd: optee_rpmb: close tee session

Add calls for closing tee session after every read/write operation. Signed-off-by: Igor Opaniuk --- (no changes since v1) cmd/optee_rpmb.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/cmd/optee_rpmb.c b/cmd/optee_rpmb.c index e0e44bbed04

[PATCH v4 1/5] tee: optee: fix description in Kconfig

Fix OPTEE_TA_AVB symbol description in Kconfig: s/"write"rb"/"write_rb"/g Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas Signed-off-by: Igor Opaniuk --- (no changes since v2) Changes in v2: - Applied R-b tags drivers/tee/optee/Kconfig | 2 +- 1

[PATCH v4 0/5] TEE: minor cleanup

tee.c:37:9: error: implicit declaration of function 'memset' - Applied R-b and T-b tags Igor Opaniuk (5): tee: optee: fix description in Kconfig cmd: optee_rpmb: close tee session cmd: optee_rpmb: build cmd for sandbox test: py: add optee_rpmb tests tee: remove common.h inclusion c

Re: [PATCH] mvebu: Enable preboot start for pci/usb/scsi/nvme

[1] include/configs/mvebu_armada-37xx.h [2] include/config_distro_bootcmd.h -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk https://www.linkedin.com/in/iopaniuk <http://ua.linkedin.com/in/iopaniuk>

Re: [PATCH v3 0/6] TEE: minor cleanup

Ilias, On Mon, Mar 4, 2024 at 6:45 PM Igor Opaniuk wrote: > - Address some spelling errors and typos > - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests > - Remove common.h inclusion for drivers/tee > - Add calls for closing tee session after every read/wri

Re: [PATCH v4 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

UP_OFFSET); > > - if (ret < 0) { > > - free(backup_abc); > > - free(abc); > > - return ret; > > + if (CONFIG_ANDROID_AB_BACKUP_OFFSET) { > > + /* > > + * If t

Re: [PATCH v4 1/2] android_ab: Add missing semicolon

log_err("ANDROID: Invalid backup CRC-32 "); > log_err("expected %.8x, found %.8x),", > crc32_le, backup_abc->crc32_le); > #endif > -- > 2.34.1 > > Reviewed-by: Igor Opaniuk -- Best regard

Re: ECDSA related PRs

t in with greater ease. > > > > Yeah. For this kind of thing you wouldn't want to make a bunch of > > checkpatch changes. They sometimes pull crypto and compression > > libraries into the Linux kernel pretty much unmodified as well for the > > same reason. > >

Re: [PATCH 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

d (with CONFIG_VAL macro) as explained in [1]. - > 2.43.2 > > > > > CONFIDENTIALITY NOTICE: This email and any attachments are for the sole > use of the intended recipient(s) and contain information that may be Garmin > confidential and/

Re: [PATCH v2 0/5] TEE: minor cleanup

Hi Ilias, On Mon, Mar 4, 2024 at 12:16 PM Ilias Apalodimas < ilias.apalodi...@linaro.org> wrote: > Hi Igor, > > On Sun, 3 Mar 2024 at 00:01, Igor Opaniuk wrote: > > > > > > - Address some spelling errors and typos > > - Support CMD_OPTEE_RPMB for SAND

[PATCH v3 6/6] tee: remove common.h inclusion

The usage of the common.h include file is deprecated [1], and has already been removed from several files. Get rid of all inclusions in the "drivers/tee" directory, and replace it with required include files directly where needed. [1] doc/develop/codingstyle.rst Signed-off-by: Ig

[PATCH v3 5/6] test: py: add optee_rpmb tests

Add read/write tests for optee_rpmb cmd. Signed-off-by: Igor Opaniuk --- (no changes since v1) test/py/tests/test_optee_rpmb.py | 20 1 file changed, 20 insertions(+) create mode 100644 test/py/tests/test_optee_rpmb.py diff --git a/test/py/tests/test_optee_rpmb.py b

[PATCH v3 4/6] cmd: optee_rpmb: build cmd for sandbox

Tested-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk --- (no changes since v2) Changes in v2: - Applied R-b and T-b tags cmd/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index a86b5705174..8ad8c0c542c 100644 --- a/cmd/Kconfig +++ b/cmd/K

[PATCH v3 3/6] cmd: optee_rpmb: close tee session

Add calls for closing tee session after every read/write operation. Signed-off-by: Igor Opaniuk --- (no changes since v1) cmd/optee_rpmb.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/cmd/optee_rpmb.c b/cmd/optee_rpmb.c index e0e44bbed04

[PATCH v3 2/6] tee: sandbox: fix spelling errors

Fix spelling errors in comments. Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas Signed-off-by: Igor Opaniuk --- (no changes since v2) Changes in v2: - Applied R-b tags drivers/tee/sandbox.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v3 1/6] tee: optee: fix description in Kconfig

Fix OPTEE_TA_AVB symbol description in Kconfig: s/"write"rb"/"write_rb"/g Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas Signed-off-by: Igor Opaniuk --- (no changes since v2) Changes in v2: - Applied R-b tags drivers/tee/optee/Kconfig | 2 +- 1

[PATCH v3 0/6] TEE: minor cleanup

/results?buildId=28=results Changes in v3: - Added calls for closing tee session after every read/write operation Changes in v2: - Fixed chimp_optee.c:37:9: error: implicit declaration of function 'memset' - Applied R-b and T-b tags Igor Opaniuk (6): tee: optee: fix description in Kconfig tee

Re: [PATCH v2 0/5] TEE: minor cleanup

Hi Ilias, On Mon, Mar 4, 2024 at 12:16 PM Ilias Apalodimas < ilias.apalodi...@linaro.org> wrote: > Hi Igor, > > On Sun, 3 Mar 2024 at 00:01, Igor Opaniuk wrote: > > > > > > - Address some spelling errors and typos > > - Support CMD_OPTEE_RPMB for SAND

Re: [PATCH v1 0/5] TEE: minor cleanup

Hello Ilias, On Fri, Mar 1, 2024 at 10:41 AM Ilias Apalodimas < ilias.apalodi...@linaro.org> wrote: > Hi Igor, > > On Thu, 29 Feb 2024 at 21:11, Igor Opaniuk wrote: > > > > Hi Ilias, > > > > On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk > wrote

[PATCH v2 5/5] tee: remove common.h inclusion

The usage of the common.h include file is deprecated [1], and has already been removed from several files. Get rid of all inclusions in the "drivers/tee" directory, and replace it with required include files directly where needed. [1] doc/develop/codingstyle.rst Signed-off-by: Ig

[PATCH v2 4/5] test: py: add optee_rpmb tests

Add read/write tests for optee_rpmb cmd. Signed-off-by: Igor Opaniuk --- (no changes since v1) test/py/tests/test_optee_rpmb.py | 20 1 file changed, 20 insertions(+) create mode 100644 test/py/tests/test_optee_rpmb.py diff --git a/test/py/tests/test_optee_rpmb.py b

[PATCH v2 3/5] cmd: optee_rpmb: build cmd for sandbox

Tested-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk --- Changes in v2: - Applied R-b and T-b tags cmd/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index a86b5705174..8ad8c0c542c 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1370,7 +

[PATCH v2 2/5] tee: sandbox: fix spelling errors

Fix spelling errors in comments. Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas Signed-off-by: Igor Opaniuk --- Changes in v2: - Applied R-b tags drivers/tee/sandbox.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tee/sandbox.c b/drivers

[PATCH v2 1/5] tee: optee: fix description in Kconfig

Fix OPTEE_TA_AVB symbol description in Kconfig: s/"write"rb"/"write_rb"/g Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas Signed-off-by: Igor Opaniuk --- Changes in v2: - Applied R-b tags drivers/tee/optee/Kconfig | 2 +- 1 file changed, 1 insertio

[PATCH v2 0/5] TEE: minor cleanup

- Address some spelling errors and typos - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests - Remove common.h inclusion for drivers/tee Changes in v2: - Fixed chimp_optee.c:37:9: error: implicit declaration of function 'memset' - Applied R-b and T-b tags Igor Opaniuk (5

Re: [PATCH v1] cmd: md5sum: use hash_command

Hi Tom, On Sat, Mar 2, 2024 at 12:31 AM Tom Rini wrote: > On Sun, Feb 11, 2024 at 07:56:16PM +0100, Igor Opaniuk wrote: > > > From: Igor Opaniuk > > > > Drop old implementation and use hash_command() instead, as > > how it's currently done for crc32

[PATCH v2] cmd: md5sum: use hash_command

Drop old implementation and use hash_command() instead, as how it's currently done for crc32 and sha1sum cmds. Test: => md5sum 0x6000 0x200 md5 for 6000 ... 61ff ==> e6bbbe95f5b41996f4a9b9af7bbd4050 Signed-off-by: Igor Opaniuk --- Changes in v2: - Addressed build issues o

Re: [PATCH v1] cmd: md5sum: use hash_command

Hello Tom, On Sun, Feb 11, 2024 at 7:56 PM Igor Opaniuk wrote: > From: Igor Opaniuk > > Drop old implementation and use hash_command() instead, as > how it's currently done for crc32 and sha1sum cmds. > > Test: > => md5sum 0x6000 0x200 > md

Re: [PATCH v1 0/5] TEE: minor cleanup

Hi Ilias, On Wed, Feb 14, 2024 at 7:34 PM Igor Opaniuk wrote: > - Address some spelling errors and typos > - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests > - Remove common.h inclusion for drivers/tee > > Igor Opaniuk (5): > tee: optee: fix desc

Re: [PATCH v1] include: android_bootloader_message.h: sync with AOSP upstream

+CC Mattijs On Mon, Feb 19, 2024 at 11:16 AM Igor Opaniuk wrote: > This takes the latest changes from AOSP from [1][2] (as this > header was split on two) with minimal changes (this could lead > to warnings reported by checkpatch). > > Some local changes have been appli

Re: ECDSA related PRs

not too controversial) adds an ecdsa > >>> verify driver (UCLASS_ECDSA) which utilizes tinycrypt to do the crypto > >>> work. > >>> > >> > >> Do we already use tiny crypt in the project, if not things like license > >> need to be taken into account in the context of the GPLv2 > >> > >> Please advise on how best to proceed. Happy to work within the confines of > >>> what works best for the larger group. > >>> > >>> Thanks, > >>> Bob Wolff > >>> > >> -- Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk Senior Software Engineer, Embedded & Security E: igor.opan...@foundries.io W: www.foundries.io

Re: [PATCH v1 5/7] toradex: common: Add sysinfo driver

struct udevice *dev) > +{ > + return valid_cfgblock ? 0 : -EINVAL; > +} > + > +static int tdx_get_str(struct udevice *dev, int id, size_t size, char *val) > +{ > + int ret = -ENOTSUPP; > + > + switch (id) { > + case SYSINFO_ID_BOARD_MODEL: > + snprintf(val, size, > +"Toradex %04d %s %s", > +tdx_hw_tag.prodid, > +toradex_modules[tdx_hw_tag.prodid].name, > +tdx_board_rev_str); > + > + ret = 0; > + } > + > + return ret; > +} > + > +static const struct udevice_id sysinfo_tdx_ids[] = { > + { .compatible = "toradex,sysinfo" }, > + { /* sentinel */ } > +}; > + > +static const struct sysinfo_ops sysinfo_tdx_ops = { > + .detect = tdx_detect, > + .get_str= tdx_get_str, > +}; > + > +U_BOOT_DRIVER(sysinfo_toradex) = { > + .name = "sysinfo_toradex", > + .id = UCLASS_SYSINFO, > + .of_match = sysinfo_tdx_ids, > + .ops= _tdx_ops, > +}; > + > #ifdef CONFIG_TDX_CFG_BLOCK_USB_GADGET_PID > int g_dnl_bind_fixup(struct usb_device_descriptor *dev, const char *name) > { > -- > 2.39.2 > -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk http://ua.linkedin.com/in/iopaniuk

Re: [PATCH v1] include: android_bootloader_message.h: sync with AOSP upstream

Hi Sam, On Tue, Feb 20, 2024 at 7:29 PM Sam Protsenko wrote: > > On Mon, Feb 19, 2024 at 4:16 AM Igor Opaniuk wrote: > > > > This takes the latest changes from AOSP from [1][2] (as this > > header was split on two) with minimal changes (this could lead > > to w

Re: LTO build failure with GCC 13.2.1

in function `init_have_lse_atomics': lse-init.c:(.text.startup+0xc): undefined reference to `__getauxval' This is happening because we are linking against our own libcflat which doesn't implement the function __getauxval(). Disable the use of the out-of-line functions by compiling with -mno-outl

[PATCH v1] include: android_bootloader_message.h: sync with AOSP upstream

tps://android.googlesource.com/platform/hardware/interfaces/+/main/boot/1.1/default/boot_control/include/private/boot_control_definition.h CC: Alex Deymo CC: Sam Protsenko CC: Eugeniu Rosca CC: Simon Glass Signed-off-by: Igor Opaniuk --- include/android_bootloader_message.h |

[PATCH v1 5/5] tee: remove common.h inclusion

The usage of the common.h include file is deprecated [1], and has already been removed from several files. Get rid of all inclusions in the "drivers/tee" directory, and replace it with required include files directly where needed. [1] doc/develop/codingstyle.rst Signed-off-by: Ig

[PATCH v1 4/5] test: py: add optee_rpmb tests

Add read/write tests for optee_rpmb cmd. Signed-off-by: Igor Opaniuk --- test/py/tests/test_optee_rpmb.py | 20 1 file changed, 20 insertions(+) create mode 100644 test/py/tests/test_optee_rpmb.py diff --git a/test/py/tests/test_optee_rpmb.py b/test/py/tests

[PATCH v1 2/5] tee: sandbox: fix spelling errors

Fix spelling errors in comments. Signed-off-by: Igor Opaniuk --- drivers/tee/sandbox.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tee/sandbox.c b/drivers/tee/sandbox.c index 86219a9bb1a..ec66401878c 100644 --- a/drivers/tee/sandbox.c +++ b/drivers/tee

[PATCH v1 1/5] tee: optee: fix description in Kconfig

Fix OPTEE_TA_AVB symbol description in Kconfig: s/"write"rb"/"write_rb"/g Signed-off-by: Igor Opaniuk --- drivers/tee/optee/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig index 9dc65b

[PATCH v1 3/5] cmd: optee_rpmb: build cmd for sandbox

Support CMD_OPTEE_RPMB for SANDBOX configurations. Test: $ ./u-boot -d arch/sandbox/dts/test.dtb ... => optee_rpmb write_pvalue test_variable test_value Wrote 11 bytes => optee_rpmb read_pvalue test_variable 11 Read 11 bytes, value = test_value Signed-off-by: Igor Opaniuk --- cmd/Kconf

[PATCH v1 0/5] TEE: minor cleanup

- Address some spelling errors and typos - Support CMD_OPTEE_RPMB for SANDBOX configurations and add python tests - Remove common.h inclusion for drivers/tee Igor Opaniuk (5): tee: optee: fix description in Kconfig tee: sandbox: fix spelling errors cmd: optee_rpmb: build cmd for sandbox

Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

Hi Mattijs, On Tue, Feb 13, 2024 at 9:13 AM Mattijs Korpershoek wrote: > > Hi Igor, > > On lun., févr. 12, 2024 at 09:05, Igor Opaniuk wrote: > > > Hi Dan, > > > > On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter > > wrote: > >> > >> On

[RESEND PATCH v1] MAINTAINERS: add custodian tree info for AVB/AB

From: Igor Opaniuk Add information about a custodian tree [1] for AVB/AB, which is maintained by Mattijs Korpershoek. [1] https://source.denx.de/u-boot/custodians/u-boot-dfu Signed-off-by: Igor Opaniuk --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b

[PATCH v1] MAINTAINERS: add custodian tree info for AV/AVB

From: Igor Opaniuk Add information about a custodian tree [1] for AVB/AB, which is maintained by Mattijs Korpershoek. [1] https://source.denx.de/u-boot/custodians/u-boot-dfu Signed-off-by: Igor Opaniuk --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b

[PATCH v2] armv8: crypto: SHA-512 using ARMv8 Crypto Extensions

From: Igor Opaniuk Add support for the SHA-512 Secure Hash Algorithm which uses ARMv8 Crypto Extensions. The CPU should support ARMv8.2 instruction set and implement SHA512H, SHA512H2, SHA512SU0, and SHA512SU1 instructions. This information can be obtained from ID_AA64ISAR0_EL1 (AArch64

Re: [PATCH] configs: khadas-vim3*_android: fix AVB oom error

b/configs/khadas-vim3l_android_defconfig > @@ -3,6 +3,7 @@ CONFIG_SYS_BOARD="vim3" > CONFIG_SYS_CONFIG_NAME="khadas-vim3l_android" > CONFIG_ARCH_MESON=y > CONFIG_TEXT_BASE=0x0100 > +CONFIG_SYS_MALLOC_LEN=0x0800 > CONFIG_NR_DRAM_BANKS=1 >

Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

Hi Dan, On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter wrote: > > On Fri, Feb 09, 2024 at 08:20:39PM +0100, Igor Opaniuk wrote: > > From: Igor Opaniuk > > > > mmc_switch_part() is used for switching between hw partitions > > on eMMC (boot0, boot1, user, rpm

[PATCH v1] cmd: md5sum: use hash_command

From: Igor Opaniuk Drop old implementation and use hash_command() instead, as how it's currently done for crc32 and sha1sum cmds. Test: => md5sum 0x6000 0x200 md5 for 6000 ... 61ff ==> e6bbbe95f5b41996f4a9b9af7bbd4050 Signed-off-by: Igor Opaniuk --- cmd/md5sum.c

Re: [PATCH] doc/develop/codingstyle.rst: Clarify include section

at and nitpick: s/ccode/code/g > +replace it with any required include files directly is much appreciated. > > If your file uses driver model, include in the C file. Do not include > dm.h in a header file. Try to use forward declarations (e.g. ``struct > -- > 2.34.1 > Reviewed-by: Igor Opaniuk -- Best regards - Atentamente - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk http://ua.linkedin.com/in/iopaniuk

Re: [PATCH v1] armv8: crypto: SHA-512 using ARMv8 Crypto Extensions

Hi Tom, On Sun, Feb 11, 2024 at 1:37 AM Tom Rini wrote: > > On Sat, Feb 10, 2024 at 01:07:09PM +0100, Igor Opaniuk wrote: > > > From: Igor Opaniuk > > > > Add support for the SHA-512 Secure Hash Algorithm which uses ARMv8 Crypto > > Extensions. The CPU shoul

Re: [PATCH v1] armv8: crypto: SHA-512 using ARMv8 Crypto Extensions

Hello Marc, On Sun, Feb 11, 2024 at 12:12 AM Marc Zyngier wrote: > > [Fixing Ard's email address for something more current.] > > On Sat, 10 Feb 2024 12:07:09 +0000, > Igor Opaniuk wrote: > > > > From: Igor Opaniuk > > > > Add support for the SHA-512

[PATCH v1] armv8: crypto: SHA-512 using ARMv8 Crypto Extensions

From: Igor Opaniuk Add support for the SHA-512 Secure Hash Algorithm which uses ARMv8 Crypto Extensions. The CPU should support ARMv8.2 instruction set and implement SHA512H, SHA512H2, SHA512SU0, and SHA512SU1 instructions. This information can be obtained from ID_AA64ISAR0_EL1 (AArch64

Re: [PATCH v2 1/3] imx93: Use a header for imx9_probe_mu declaration

@@ > > #include > #include > +#include > #include > #include > #include > @@ -99,7 +100,6 @@ int power_init_board(void) > return 0; > } > > -extern int imx9_probe_mu(void *ctx, struct event *event); > void board_init_f(ulong dummy) > { >

[PATCH v2 7/7] doc: android: avb: sync usage details

From: Igor Opaniuk Sync usage info with the one cmd/avb.c. Signed-off-by: Igor Opaniuk --- Changes in v2: - Address Mattijs comment about usage info, sync with cmd/avb.c doc/android/avb2.rst | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/doc/android

[PATCH v2 6/7] cmd: avb: rework do_avb_verify_part

From: Igor Opaniuk Use existing str_avb_slot_error() function for obtaining verification fail reason details. Take into account device lock state for setting correct androidboot.verifiedbootstate kernel cmdline parameter. Reviewed-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk

[PATCH v2 5/7] common: avb_verify: add str_avb_io_error/str_avb_slot_error

From: Igor Opaniuk Introduce str_avb_io_error() and str_avb_slot_error() functions, that provide a pointer to AVB runtime error message. Reviewed-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk --- Changes in v2: - Mattijs Korpershoek R-b tag applied common/avb_verify.c | 49

[PATCH v2 4/7] cmd: avb: rework prints

From: Igor Opaniuk Simplify and add more context for prints where it's needed. Signed-off-by: Igor Opaniuk --- Changes in v2: - Drop AVB_OPS_CHECK macro and leave previous check cmd/avb.c | 123 +- 1 file changed, 75 insertions(+), 48

[PATCH v2 3/7] common: avb_verify: rework error/debug prints

From: Igor Opaniuk Make error prints more verbose with additional context. Also s/print/debug/g for prints, which might be relevant only for debugging purposes. Reviewed-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk --- Changes in v2: - Mattijs Korpershoek R-b tag applied common

[PATCH v2 2/7] avb: move SPDX license identifiers to the first line

From: Igor Opaniuk Move SPDX license identifiers to the first line, so it conforms to license placement rule [1]: Placement: The SPDX license identifier in kernel files shall be added at the first possible line in a file which can contain a comment. For the majority of files this is the first

[PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

From: Igor Opaniuk mmc_switch_part() is used for switching between hw partitions on eMMC (boot0, boot1, user, rpmb). There is no need to do that for SD card. Reviewed-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk --- Changes in v2: - Mattijs Korpershoek R-b tag applied common

[PATCH v2 0/7] AVB: cosmetic adjustments/improvements

for eMMC. - Rework do_avb_verify_part, take into account device lock state for setting correct androidboot.verifiedbootstate. - Adjust AVB documentation, sync usage info with the one cmd/avb.c. Igor Opaniuk (7): common: avb_verify: don't call mmc_switch_part for SD avb: move SPDX license

Re: [AVB/AB] Overhaul plans

Hello Mattijs, On Fri, Feb 9, 2024 at 11:30 AM Mattijs Korpershoek wrote: > > Hi Igor, > > On ven., févr. 09, 2024 at 11:14, Igor Opaniuk wrote: > > > Hi everyone, > > > > I'm currently planning a big overhaul of the current implementation of > > AVB/AB

[AVB/AB] Overhaul plans

salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk http://ua.linkedin.com/in/iopaniuk

Re: [PATCH v1 4/7] cmd: avb: rework prints

Hi Mattijs, On Thu, Feb 8, 2024 at 3:00 PM Mattijs Korpershoek wrote: > > Hi Igor, > > Thank you for the patch. > > On mar., févr. 06, 2024 at 23:31, Igor Opaniuk > wrote: > > > From: Igor Opaniuk > > > > Introduce AVB_OPS_CHECK macro for checkin

Re: [PATCH v1 7/7] doc: android: avb: add slot_suffix param details

Hi Mattijs, On Thu, Feb 8, 2024 at 3:12 PM Mattijs Korpershoek wrote: > > Hi Igor, > > Thank you for the patch. > > On mar., févr. 06, 2024 at 23:31, Igor Opaniuk > wrote: > > > From: Igor Opaniuk > > > > Add info about slot_suffix param for avb v

Re: [RFC] Drop md5sum, crc32 and sha1 cmds in favor of hash cmd

Hello Tom, Peter, On Wed, Feb 7, 2024 at 3:16 PM Peter Robinson wrote: > > On Wed, 7 Feb 2024 at 13:48, Tom Rini wrote: > > > > On Wed, Feb 07, 2024 at 02:00:16PM +0100, Igor Opaniuk wrote: > > > Hello, > > > > > > I was playing a bit with different

Re: [PATCH v1] cmd: hash: fix param count check

Hi Tom, On Wed, Feb 7, 2024 at 1:01 AM Igor Opaniuk wrote: > > From: Igor Opaniuk > > Add correct check for parameter count. > > This fixes this issue when `hash` cmd is invoked without params: > > => hash > data abort > pc : [] lr : [] > reloc

  1   2   3   4   5   6   7   8   9   10   >