On 18/Mar/2019 13:26, Ismael Luceno wrote:
> clk_get_rate may return -ENODEV if the clock isn't valid.
>
> Also, make the error cases go through a single path.
>
> Fixes: ff8eee0330a6 ("cmd: clk: Add trivial implementation of clock dump
> for DM")
>
> Signed-off-by: Ismael Luceno
> Review
Signed-off-by: Ismael Luceno
---
fs/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/Makefile b/fs/Makefile
index 10c735ad43..2ed4aeac0e 100644
--- a/fs/Makefile
+++ b/fs/Makefile
@@ -15,7 +15,7 @@ obj-$(CONFIG_FS_BTRFS) += btrfs/
obj-$(CONFIG_FS_CBFS) += cbfs/
ob
On 08/Apr/2019 15:38, Christian Gmeiner wrote:
> Might be useful to see the serial number.
>
> v2: add missing \n.
Seems to be still missing it...
>
> Signed-off-by: Christian Gmeiner
> ---
> cmd/mmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/cmd/mmc.c b/cmd/mmc.c
> index 8bc
Current code is plain wrong, and there's no need to have a mutable string,
so fix function type and remove the intermediate variable.
Signed-off-by: Ismael Luceno
---
cmd/usb.c| 18 +-
common/usb_hub.c | 18 +-
2 files changed, 10 insertions(+), 26 deletio
Drop the counter, it has no meaning other than being the order in which
the interface is found; the name assigned to the USB host controller
interface is a better indicator.
Example of the original output:
> USB0: USB EHCI 1.10
> scanning bus 0 for devices... 2 USB Device(s) found
>scann
On 19/Mar/2019 02:14, Marek Vasut wrote:
> On 3/18/19 2:21 PM, Ismael Luceno Cortes wrote:
> > Drop the counter, it has no meaning other than being the order in which
> > the interface is found; the name assigned to the USB host controller
> > interface is a better indicator
Drop the counter, it has no meaning other than being the order in which
the interface is found; the name assigned to the USB host controller
interface is a better indicator.
Example of the original output:
> USB0: USB EHCI 1.10
> scanning bus 0 for devices... 2 USB Device(s) found
>scann
The name assigned to the USB host controller interface is a better
indicator than the counter currently in use (which has no meaning other
than being the order in which the interface is found).
Example of the original output:
> USB0: USB EHCI 1.10
> scanning bus 0 for devices... 2 USB Device(s)
clk_get_rate may return -ENODEV if the clock isn't valid.
Also, make the error cases go through a single path.
Fixes: ff8eee0330a6 ("cmd: clk: Add trivial implementation of clock dump
for DM")
Signed-off-by: Ismael Luceno
Reviewed-by: Matthias Brugger
Reviewed-by: Marek Vasut
---
Not
On 16/Mar/2019 02:41, Marek Vasut wrote:
> On 3/15/19 8:50 PM, Ismael Luceno Cortes wrote:
> > On 15/Mar/2019 18:34, Marek Vasut wrote:
> >> On 3/14/19 5:19 PM, Ismael Luceno Cortes wrote:
> >>> On 14/Mar/2019 16:09, Marek Vasut wrote:
> >>>> O
On 22/Feb/2019 16:52, Ismael Luceno wrote:
> clk_get_rate may return -ENODEV if the clock isn't valid.
>
> Also, make the error cases go through a single path.
>
> Fixes: ff8eee0330a6 ("cmd: clk: Add trivial implementation of clock dump
> for DM")
>
> Signed-off-by: Ismael Luceno
> Review
On 15/Mar/2019 18:34, Marek Vasut wrote:
> On 3/14/19 5:19 PM, Ismael Luceno Cortes wrote:
> > On 14/Mar/2019 16:09, Marek Vasut wrote:
> >> On 3/14/19 1:57 PM, Ismael Luceno Cortes wrote:
> >>> On 14/Mar/2019 12:55, Marek Vasut wrote:
> >>>> On
On 08/Mar/2019 18:28, Martin Husemann wrote:
> On Fri, Mar 08, 2019 at 12:17:09PM -0500, Tom Rini wrote:
> > OK, so a few thoughts here.
> > - What's the portable way to do hex-based math? If we really need it?
>
> Use printf(3) to convert to/from hex, and standard shell arithmetic
> with $(( )).
On 14/Mar/2019 16:09, Marek Vasut wrote:
> On 3/14/19 1:57 PM, Ismael Luceno Cortes wrote:
> > On 14/Mar/2019 12:55, Marek Vasut wrote:
> >> On 3/14/19 12:44 PM, Ismael Luceno Cortes wrote:
> >>> On 18/Feb/2019 09:23, Ismael Luceno Cortes wrote:
>
On 14/Mar/2019 12:55, Marek Vasut wrote:
> On 3/14/19 12:44 PM, Ismael Luceno Cortes wrote:
> > On 18/Feb/2019 09:23, Ismael Luceno Cortes wrote:
> >> Signed-off-by: Ismael Luceno
> >> ---
> >> drivers/usb/host/usb-uclass.c | 2 +-
> >>
On 18/Feb/2019 09:23, Ismael Luceno Cortes wrote:
> Signed-off-by: Ismael Luceno
> ---
> drivers/usb/host/usb-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c
> index 611ea97a
Do the reset before clearing the MSR, otherwise it may result in a read
or write operation instead if the start condition is repeated.
Signed-off-by: Ismael Luceno
Reviewed-by: Marek Vasut
Reviewed-by: Heiko Schocher
---
Notes:
Changes since v1:
- Rebased on top of patch 1050650 ("i2c:
Cosmetic change. Any call to the recover function would need to do the
same check afterwards, so it's sensible to make it part of the function.
Signed-off-by: Ismael Luceno
---
Notes:
Changes since v3:
- Removed unused variable val @ rcar_i2c_set_addr
Changes since v2:
- Fi
Document the meaning of macros related to registers and values to be
written to them.
Signed-off-by: Ismael Luceno
Reviewed-by: Marek Vasut
Reviewed-by: Heiko Schocher
---
Notes:
Changes since v2:
- Fixed style of comments
Changes since v1:
- Rebased on top of patch 105065
It needs to be done for both reads and writes, so do it at rcar_i2c_xfer
to avoid duplication.
Signed-off-by: Ismael Luceno
Reviewed-by: Marek Vasut
Reviewed-by: Heiko Schocher
---
Notes:
Changes since v2:
- Fixed commit message
Changes since v1:
- Rebased on top of patch
Fix rcar_i2c_xfer return value, previously it was always returning
-EREMOTEIO when dealing with errors from calls to the read/write
functions.
Signed-off-by: Ismael Luceno
Reviewed-by: Marek Vasut
Reviewed-by: Heiko Schocher
---
Notes:
Changes since v2:
- Fixed commit message
Setting up the delay only needs to be done once; move it to
rcar_i2c_set_speed so it's done at initialization time.
Signed-off-by: Ismael Luceno
Reviewed-by: Marek Vasut
Reviewed-by: Heiko Schocher
---
Notes:
Changes since v2:
- Improved commit message
- Style fixes
drivers/i2c/r
This series is meant to be applied on top of the "i2c: rcar_i2c: Add
Gen3 SoC support" patch.
v5 is just an edit over v4; a change ended up in the wrong commit in that
version.
Ismael Luceno (6):
i2c: rcar_i2c: Setup SCL/SDA delay at rcar_i2c_set_speed
i2c: rcar_i2c: Add comments about regist
Please ignore this series; I made a mistake, I'll submit a v5.
On 07/Mar/2019 13:34, Ismael Luceno Cortes wrote:
> This series is meant to be applied on top of the "i2c: rcar_i2c: Add
> Gen3 SoC support" patch.
>
>
> Ismael Luceno (6):
> i2c:
On 07/Mar/2019 22:54, Masahiro Yamada wrote:
<...>
> Each defconfig supports multiple boards
> by using a different DEVICE_TREE.
>
> If you are interested, doc/README.uniphier
> explains it supports much more boards than defconfig.
>
> The drawback of this ways will increase the image size
> sinc
It needs to be done for both reads and writes, so do it at rcar_i2c_xfer
to avoid duplication.
Signed-off-by: Ismael Luceno
---
Notes:
Changes since v2:
- Fixed commit message
Changes since v1:
- Rebased on top of patch 1050650 ("i2c: rcar_i2c: Add Gen3 SoC support")
- F
Cosmetic change. Any call to the recover function would need to do the
same check afterwards, so it's sensible to make it part of the function.
Signed-off-by: Ismael Luceno
---
Notes:
Changes since v2:
- Fixed variable names
- Fixed return value to be standard
Changes since
Do the reset before clearing the MSR, otherwise it may result in a read
or write operation instead if the start condition is repeated.
Signed-off-by: Ismael Luceno
Reviewed-by: Marek Vasut
---
Notes:
Changes since v1:
- Rebased on top of patch 1050650 ("i2c: rcar_i2c: Add Gen3 SoC suppo
Fix rcar_i2c_xfer return value, previously it was always returning
-EREMOTEIO when dealing with errors from calls to the read/write
functions.
Signed-off-by: Ismael Luceno
---
Notes:
Changes since v2:
- Fixed commit message
Changes since v1:
- Rebased on top of patch 1050650
Document the meaning of macros related to registers and values to be
written to them.
Signed-off-by: Ismael Luceno
---
Notes:
Changes since v2:
- Fixed style of comments
Changes since v1:
- Rebased on top of patch 1050650 ("i2c: rcar_i2c: Add Gen3 SoC support")
drivers/i2c
Setting up the delay only needs to be done once; move it to
rcar_i2c_set_speed so it's done at initialization time.
Signed-off-by: Ismael Luceno
---
Notes:
Changes since v3:
- Removed unused variable val @ rcar_i2c_set_addr
Changes since v2:
- Improved commit message
- S
This series is meant to be applied on top of the "i2c: rcar_i2c: Add
Gen3 SoC support" patch.
Ismael Luceno (6):
i2c: rcar_i2c: Setup SCL/SDA delay at rcar_i2c_set_speed
i2c: rcar_i2c: Add comments about registers & values
i2c: rcar_i2c: Fix sending of slave addresses
i2c: rcar_i2c: Don't
On 07/Mar/2019 12:59, Heiko Schocher wrote:
<...>
> This change brings travis build to fail, see:
>
> https://travis-ci.org/hsdenx/u-boot-i2c/jobs/502984991#L1265
>
> On which hardware have you tested this patchset?
I didn't had -Werror enabled, so it slipped.
> So, please, send a v4, Thanks!
Do the reset before clearing the MSR, otherwise it may result in a read
or write operation instead if the start condition is repeated.
Signed-off-by: Ismael Luceno
Reviewed-by: Marek Vasut
---
drivers/i2c/rcar_i2c.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/
Cosmetic change. Any call to the recover function would need to do the
same check afterwards, so it's sensible to make it part of the function.
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/rcar
It needs to be done for both reads and writes, so do it at rcar_i2c_xfer
to avoid duplication.
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar_i2c.c
index 9223eaec
Fix rcar_i2c_xfer return value, previously it was always returning
-EREMOTEIO when dealing with errors from calls to the read/write
functions.
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/rcar_i2c.c b/driv
Setting up the delay only needs to be done once; move it to
rcar_i2c_set_speed so it's done at initialization time.
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar_i2c.c
Document the meaning of macros related to registers and values to be
written to them.
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 47 +++---
1 file changed, 26 insertions(+), 21 deletions(-)
diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar
On 05/Mar/2019 19:32, Marek Vasut wrote:
> On 3/5/19 12:23 PM, Ismael Luceno Cortes wrote:
> > Cosmetic change. Any call to the recover function would need to do the
> > same check afterwards, so it's sensible to make it part of the function.
> >
> &
Cosmetic change. Any call to the recover function would need to do the
same check afterwards, so it's sensible to make it part of the function.
Signed-off-by: Ismael Luceno
---
Notes:
Changes since v1:
- Rebased on top of patch 1050650 ("i2c: rcar_i2c: Add Gen3 SoC support")
- Expla
Do the reset before clearing the MSR, otherwise it may result in a read
or write operation instead if the start condition is repeated.
Signed-off-by: Ismael Luceno
---
Notes:
Changes since v1:
- Rebased on top of patch 1050650 ("i2c: rcar_i2c: Add Gen3 SoC support")
drivers/i2c/rcar_i2
Signed-off-by: Ismael Luceno
---
Notes:
Changes since v1:
- Rebased on top of patch 1050650 ("i2c: rcar_i2c: Add Gen3 SoC support")
- Fixed masking of return value from rcar_i2c_set_addr
drivers/i2c/rcar_i2c.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
dif
Signed-off-by: Ismael Luceno
---
Notes:
Changes since v1:
- Rebased on top of patch 1050650 ("i2c: rcar_i2c: Add Gen3 SoC support")
drivers/i2c/rcar_i2c.c | 45 +-
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/drivers/i2c/rcar_i2
Signed-off-by: Ismael Luceno
---
Notes:
Changes since v1:
- Rebased on top of patch 1050650 ("i2c: rcar_i2c: Add Gen3 SoC support")
drivers/i2c/rcar_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar_i2c.c
index 7131f0c994
It only needs to be done once.
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar_i2c.c
index 10b0f8bad4..74643b085e 100644
--- a/drivers/i2c/rcar_i2c.c
+++ b/drivers/i2c/rc
On 04/Mar/2019 20:46, Marek Vasut wrote:
> On 3/4/19 3:19 PM, Ismael Luceno Cortes wrote:
> > Signed-off-by: Ismael Luceno
> > ---
> > drivers/i2c/rcar_i2c.c | 14 +-
> > 1 file changed, 5 insertions(+), 9 deletions(-)
> >
> > diff --git
On 04/Mar/2019 20:45, Marek Vasut wrote:
> On 3/4/19 3:19 PM, Ismael Luceno Cortes wrote:
>
> Hello Ismael,
>
> the patch is missing commit message, please fix globally.
>
> I sent this patch [1] two days ago, I believe it fixes the same issue,
> can you rebase the serie
On 04/Mar/2019 20:47, Marek Vasut wrote:
> On 3/4/19 3:19 PM, Ismael Luceno Cortes wrote:
>
> Why is this change needed ? A commit message explaining it would help a lot.
It's cosmetic. Any call to the recover function would need to do the
same check afterwards, so it' sensi
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar_i2c.c
index 8cdd37c006..b4cc0c55b1 100644
--- a/drivers/i2c/rcar_i2c.c
+++ b/drivers/i2c/rcar_i2c.c
@@ -207,7 +207,7 @@ static int
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar_i2c.c
index 5e04b68d95..b829e8b20d 100644
--- a/drivers/i2c/rcar_i2c.c
+++ b/drivers/i2c/rcar_i2c.c
@@ -68,7 +68,7 @@ st
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar_i2c.c
index b4cc0c55b1..5e04b68d95 100644
--- a/drivers/i2c/rcar_i2c.c
+++ b/drivers/i2c/rcar_i2c.c
@@ -144,10 +144,
Do the reset before clearing the MSR, otherwise it may result in a read
or write operation instead if the start condition is repeated.
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar_i2c.c
index bd7c37a207..7212587234 100644
--- a/drivers/i2c/rcar_i2c.c
+++ b/drivers/i2c
Signed-off-by: Ismael Luceno
---
drivers/i2c/rcar_i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar_i2c.c
index 8d87c73713..bd7c37a207 100644
--- a/drivers/i2c/rcar_i2c.c
+++ b/drivers/i2c/rcar_i2c.c
@@ -34,9 +34,9 @@
#define
clk_get_rate may return -ENODEV if the clock isn't valid.
Also, make the error cases go through a single path.
Fixes: ff8eee0330a6 ("cmd: clk: Add trivial implementation of clock dump
for DM")
Signed-off-by: Ismael Luceno
Reviewed-by: Matthias Brugger
---
CC: Matthias Brugger
Notes:
clk_get_rate may return -ENODEV if the clock isn't valid.
Also, make all the error cases go through a single path.
Signed-off-by: Ismael Luceno
---
CC: Matthias Brugger
Notes:
Changes since v1:
- Added further explanation to the commit message.
cmd/clk.c | 23 +-
Signed-off-by: Ismael Luceno
---
cmd/clk.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/cmd/clk.c b/cmd/clk.c
index fd4231589c..41f2ae0a50 100644
--- a/cmd/clk.c
+++ b/cmd/clk.c
@@ -26,20 +26,23 @@ int __weak soc_clk_dump(void)
uclass_forea
Signed-off-by: Ismael Luceno
---
drivers/usb/host/usb-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c
index 611ea97a72..0575f5393b 100644
--- a/drivers/usb/host/usb-uclass.c
+++ b/drivers/usb/host/usb-uclas
Signed-off-by: Ismael Luceno
---
cmd/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/Makefile b/cmd/Makefile
index 15ae4d250f..a127a99539 100644
--- a/cmd/Makefile
+++ b/cmd/Makefile
@@ -104,7 +104,7 @@ obj-$(CONFIG_CMD_PART) += part.o
ifdef CONFIG_PCI
obj-$(CON
Signed-off-by: Ismael Luceno
---
drivers/usb/host/usb-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c
index 611ea97a72..0575f5393b 100644
--- a/drivers/usb/host/usb-uclass.c
+++ b/drivers/usb/host/usb-uclas
61 matches
Mail list logo
