Re: [PATCH v4 4/6] cmd: fru: add product info area parsing support

2022-09-22 Thread Jae Hyun Yoo
Hello Michal, On 9/22/2022 12:19 AM, Michal Simek wrote: Hi, On 9/22/22 08:39, Jae Hyun Yoo wrote: Hello Michal, On 9/21/2022 6:52 AM, Michal Simek wrote: On 8/25/22 18:42, Jae Hyun Yoo wrote: Add product info area parsing support. Custom board fields can be added dynamically using

Re: [PATCH v4 1/6] xilinx: common: refactor FRU handling support

2022-09-22 Thread Jae Hyun Yoo
Hi, On 9/22/2022 12:29 AM, Michal Simek wrote: Hi, On 9/22/22 08:39, Jae Hyun Yoo wrote: Hello Michal, On 9/21/2022 6:40 AM, Michal Simek wrote: On 8/25/22 18:42, Jae Hyun Yoo wrote: Refactor FRU handling support to remove Xilinx customization dependency. With this change, single

Re: [PATCH v4 5/6] doc: fru: add documentation for the fru command and APIs

2022-09-22 Thread Jae Hyun Yoo
Hello Michal, On 9/21/2022 6:54 AM, Michal Simek wrote: On 8/25/22 18:42, Jae Hyun Yoo wrote: Add a usage document for the 'fru' u-boot command. Add kerneldocs for . Signed-off-by: Jae Hyun Yoo --- Changes from v3:   * None. Changes from v2:   * Added kerneldocs to 'include/fru.h'. (Simon

Re: [PATCH v4 4/6] cmd: fru: add product info area parsing support

2022-09-22 Thread Jae Hyun Yoo
Hello Michal, On 9/21/2022 6:52 AM, Michal Simek wrote: On 8/25/22 18:42, Jae Hyun Yoo wrote: Add product info area parsing support. Custom board fields can be added dynamically using linked list so that each board support can utilize them in their own custom way. Signed-off-by: Jae Hyun

Re: [PATCH v4 1/6] xilinx: common: refactor FRU handling support

2022-09-22 Thread Jae Hyun Yoo
Hello Michal, On 9/21/2022 6:40 AM, Michal Simek wrote: On 8/25/22 18:42, Jae Hyun Yoo wrote: Refactor FRU handling support to remove Xilinx customization dependency. With this change, single or multiple custom board fields and multi-records can be added dynamically using linked list so

Re: [PATCH v4 3/6] cmd: fru: fix a sandbox segfault issue

2022-09-22 Thread Jae Hyun Yoo
Hello Michal, On 9/21/2022 6:07 AM, Michal Simek wrote: On 8/25/22 18:42, Jae Hyun Yoo wrote: This command doesn't work with sandbox because direct memory access causes a segfault error. Fix it up using map_sysmem(). Signed-off-by: Jae Hyun Yoo Reviewed-by: Simon Glass --- Changes from v3

Re: [PATCH v4 0/6] cmd/fru: move FRU handling support to common region

2022-09-15 Thread Jae Hyun Yoo
Gentle ping for this series. On 8/25/2022 9:42 AM, Jae Hyun Yoo wrote: Hello, The FRU handling was added as a Xilinx board dependent support but it is also useful for other boards, so this commit moves the FRU handling support to the common region so that it can be enabled by CONFIG_CMD_FRU

[PATCH v4 5/6] doc: fru: add documentation for the fru command and APIs

2022-08-25 Thread Jae Hyun Yoo
Add a usage document for the 'fru' u-boot command. Add kerneldocs for . Signed-off-by: Jae Hyun Yoo --- Changes from v3: * None. Changes from v2: * Added kerneldocs to 'include/fru.h'. (Simon) Changes from v1: * Newly added in v2. (Heinrich) doc/usage/cmd/fru.rst | 144

[PATCH v4 4/6] cmd: fru: add product info area parsing support

2022-08-25 Thread Jae Hyun Yoo
Add product info area parsing support. Custom board fields can be added dynamically using linked list so that each board support can utilize them in their own custom way. Signed-off-by: Jae Hyun Yoo --- Changes from v3: * None. Changes from v2: * Changed 'struct fru_board_info_member

[PATCH v4 6/6] test: cmd: fru: add unit test for the fru command

2022-08-25 Thread Jae Hyun Yoo
Add test cases for the fru command. Signed-off-by: Jae Hyun Yoo Reviewed-by: Simon Glass --- Changes from v3: * Added a 'Reviewed-by' tag. (Simon) Changes from v2: * Newly added in v3. (Simon) include/test/suites.h | 1 + test/cmd/Makefile | 1 + test/cmd/fru.c| 84

[PATCH v4 2/6] cmd: fru: move FRU handling support to common region

2022-08-25 Thread Jae Hyun Yoo
From: Graeme Gregory The FRU handling was added as a Xilinx board dependent support but it is also useful for other boards too, so this commit moves the FRU handling support to the common region so that it can be enabled by CONFIG_CMD_FRU. Signed-off-by: Graeme Gregory Signed-off-by: Jae Hyun

[PATCH v4 1/6] xilinx: common: refactor FRU handling support

2022-08-25 Thread Jae Hyun Yoo
the FRU command support to common region. Signed-off-by: Jae Hyun Yoo --- Changes from v3: * None. Changes from v2: * None. Changes from v1: * Newly added in v2. board/xilinx/common/board.c | 63 -- board/xilinx/common/fru.c | 12 +- board/xilinx/common/fru.h | 76

[PATCH v4 0/6] cmd/fru: move FRU handling support to common region

2022-08-25 Thread Jae Hyun Yoo
support to common region Jae Hyun Yoo (5): xilinx: common: refactor FRU handling support cmd: fru: fix a sandbox segfault issue cmd: fru: add product info area parsing support doc: fru: add documentation for the fru command and APIs test: cmd: fru: add unit test for the fru command board

[PATCH v4 3/6] cmd: fru: fix a sandbox segfault issue

2022-08-25 Thread Jae Hyun Yoo
This command doesn't work with sandbox because direct memory access causes a segfault error. Fix it up using map_sysmem(). Signed-off-by: Jae Hyun Yoo Reviewed-by: Simon Glass --- Changes from v3: * None. Changes from v2: * Added a 'Reviewed-by' tag. (Simon) Changes from v1: * Newly added

Re: [PATCH v3 6/7] test: py: fru: add a test for the fru command

2022-08-25 Thread Jae Hyun Yoo
On 8/24/2022 6:25 PM, Simon Glass wrote: Hi, On Tue, 23 Aug 2022 at 14:53, Jae Hyun Yoo wrote: Add a simple test for the 'fru' command. Signed-off-by: Jae Hyun Yoo --- Changes from v2: * Added CONFIG_CMD_FRU=y only into the sandbox_defconfig. (Simon) Changes from v1: * Newly added

Re: [PATCH v3 7/7] test: cmd: fru: add unit test for the fru command

2022-08-25 Thread Jae Hyun Yoo
Hi Simon, On 8/24/2022 6:25 PM, Simon Glass wrote: On Tue, 23 Aug 2022 at 14:53, Jae Hyun Yoo wrote: Add test cases for the fru command. Signed-off-by: Jae Hyun Yoo --- Changes from v2: * Newly added in v3. (Simon) include/test/suites.h | 1 + test/cmd/Makefile | 1 + test/cmd

Re: [PATCH v3 4/7] cmd: fru: add product info area parsing support

2022-08-25 Thread Jae Hyun Yoo
Hi Simon, On 8/24/2022 6:25 PM, Simon Glass wrote: Hi Jae, On Tue, 23 Aug 2022 at 14:53, Jae Hyun Yoo wrote: Add product info area parsing support. Custom board fields can be added dynamically using linked list so that each board support can utilize them in their own custom way. Signed-off

[PATCH v3 5/7] doc: fru: add documentation for the fru command and APIs

2022-08-23 Thread Jae Hyun Yoo
Add a usage document for the 'fru' u-boot command. Add kerneldocs for . Signed-off-by: Jae Hyun Yoo --- Changes from v2: * Added kerneldocs to 'include/fru.h'. (Simon) Changes from v1: * Newly added in v2. (Heinrich) doc/usage/cmd/fru.rst | 144 + doc/usage

[PATCH v3 7/7] test: cmd: fru: add unit test for the fru command

2022-08-23 Thread Jae Hyun Yoo
Add test cases for the fru command. Signed-off-by: Jae Hyun Yoo --- Changes from v2: * Newly added in v3. (Simon) include/test/suites.h | 1 + test/cmd/Makefile | 1 + test/cmd/fru.c| 84 +++ test/cmd_ut.c | 6 4 files

[PATCH v3 4/7] cmd: fru: add product info area parsing support

2022-08-23 Thread Jae Hyun Yoo
Add product info area parsing support. Custom board fields can be added dynamically using linked list so that each board support can utilize them in their own custom way. Signed-off-by: Jae Hyun Yoo --- Changes from v2: * Changed 'struct fru_board_info_member' to 'struct fru_common_info_member

[PATCH v3 6/7] test: py: fru: add a test for the fru command

2022-08-23 Thread Jae Hyun Yoo
Add a simple test for the 'fru' command. Signed-off-by: Jae Hyun Yoo --- Changes from v2: * Added CONFIG_CMD_FRU=y only into the sandbox_defconfig. (Simon) Changes from v1: * Newly added in v2. (Heinrich) configs/sandbox_defconfig | 1 + test/py/tests/test_fru.py | 47

[PATCH v3 3/7] cmd: fru: fix a sandbox segfault issue

2022-08-23 Thread Jae Hyun Yoo
This command doesn't work with sandbox because direct memory access causes a segfault error. Fix it up using map_sysmem(). Signed-off-by: Jae Hyun Yoo Reviewed-by: Simon Glass --- Changes from v2: * Added a 'Reviewed-by' tag. (Simon) Changes from v1: * Newly added in v2. board/xilinx

[PATCH v3 1/7] xilinx: common: refactor FRU handling support

2022-08-23 Thread Jae Hyun Yoo
the FRU command support to common region. Signed-off-by: Jae Hyun Yoo --- Changes from v2: * None. Changes from v1: * Newly added in v2. board/xilinx/common/board.c | 63 -- board/xilinx/common/fru.c | 12 +- board/xilinx/common/fru.h | 76 +++- board/xilinx

[PATCH v3 0/7] cmd/fru: move FRU handling support to common region

2022-08-23 Thread Jae Hyun Yoo
support to common region Jae Hyun Yoo (6): xilinx: common: refactor FRU handling support cmd: fru: fix a sandbox segfault issue cmd: fru: add product info area parsing support doc: fru: add documentation for the fru command and APIs test: py: fru: add a test for the fru command test: cmd

[PATCH v3 2/7] cmd: fru: move FRU handling support to common region

2022-08-23 Thread Jae Hyun Yoo
From: Graeme Gregory The FRU handling was added as a Xilinx board dependent support but it is also useful for other boards too, so this commit moves the FRU handling support to the common region so that it can be enabled by CONFIG_CMD_FRU. Signed-off-by: Graeme Gregory Signed-off-by: Jae Hyun

Re: [PATCH v2 6/6] test: py: fru: add a test for the fru command

2022-08-16 Thread Jae Hyun Yoo
Hi Simon, On 8/16/2022 1:42 PM, Simon Glass wrote: Hi Jae, On Mon, 15 Aug 2022 at 16:58, Jae Hyun Yoo wrote: Add a simple test for the 'fru' command. Signed-off-by: Jae Hyun Yoo --- Changes from v1: * Newly added in v2. (Heinrich) configs/sandbox64_defconfig| 1 + configs

Re: [PATCH v2 3/6] cmd: fru: fix a sandbox segfault issue

2022-08-16 Thread Jae Hyun Yoo
Hi Simon, On 8/16/2022 1:42 PM, Simon Glass wrote: [...] Reviewed-by: Simon Glass Thanks for your review! [...] int fru_display(int verbose); -int fru_capture(unsigned long addr); -int fru_generate(unsigned long addr, int argc, char *const argv[]); +int fru_capture(const void

[PATCH v2 6/6] test: py: fru: add a test for the fru command

2022-08-15 Thread Jae Hyun Yoo
Add a simple test for the 'fru' command. Signed-off-by: Jae Hyun Yoo --- Changes from v1: * Newly added in v2. (Heinrich) configs/sandbox64_defconfig| 1 + configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 1 + configs/sandbox_noinst_defconfig | 1

[PATCH v2 4/6] cmd: fru: add product info area parsing support

2022-08-15 Thread Jae Hyun Yoo
Add product info area parsing support. Custom board fields can be added dynamically using linked list so that each board support can utilize them in their own custom way. Signed-off-by: Jae Hyun Yoo --- Changes from v1: * Refactored using linked list instead of calling a custom parsing callback

[PATCH v2 5/6] doc: fru: add documentation for the fru command

2022-08-15 Thread Jae Hyun Yoo
Add a usage document for the 'fru' u-boot command. Signed-off-by: Jae Hyun Yoo --- Changes from v1: * Newly added in v2. (Heinrich) doc/usage/cmd/fru.rst | 144 ++ doc/usage/index.rst | 1 + 2 files changed, 145 insertions(+) create mode 100644 doc

[PATCH v2 1/6] xilinx: common: refactor FRU handling support

2022-08-15 Thread Jae Hyun Yoo
the FRU command support to common region. Signed-off-by: Jae Hyun Yoo --- board/xilinx/common/board.c | 63 -- board/xilinx/common/fru.c | 12 +- board/xilinx/common/fru.h | 76 +++- board/xilinx/common/fru_ops.c | 228 -- 4 files

[PATCH v2 2/6] cmd: fru: move FRU handling support to common region

2022-08-15 Thread Jae Hyun Yoo
From: Graeme Gregory The FRU handling was added as a Xilinx board dependent support but it is also useful for other boards, so this commit moves the FRU handling support to the common region so that it can be enabled by CONFIG_CMD_FRU. Signed-off-by: Graeme Gregory Signed-off-by: Jae Hyun Yoo

[PATCH v2 3/6] cmd: fru: fix a sandbox segfault issue

2022-08-15 Thread Jae Hyun Yoo
This command doesn't work with sandbox because direct memory access causes a segfault error. Fix it up using map_sysmem(). Signed-off-by: Jae Hyun Yoo --- Changes from v1: * Newly added in v2. board/xilinx/common/board.c | 2 +- cmd/fru.c | 20 +--- include

[PATCH v2 0/6] cmd/fru: move FRU handling support to common region

2022-08-15 Thread Jae Hyun Yoo
support to common region Jae Hyun Yoo (5): xilinx: common: refactor FRU handling support cmd: fru: fix a sandbox segfault issue cmd: fru: add product info area parsing support doc: fru: add documentation for the fru command test: py: fru: add a test for the fru command board/xilinx/Kconfig

Re: [PATCH v1 2/2] cmd: fru: add product info area parsing support

2022-08-01 Thread Jae Hyun Yoo
On 8/1/2022 5:37 AM, Heinrich Schuchardt wrote: On 7/29/22 23:54, Jae Hyun Yoo wrote: Add product info area parsing support. Custom product info field parsing function 'fru_parse_product_custom' can be replaced with a board specific implementation. Signed-off-by: Jae Hyun Yoo --- Changes from

Re: [PATCH v1 1/2] cmd: fru: move FRU handling support to common region

2022-08-01 Thread Jae Hyun Yoo
On 8/1/2022 5:34 AM, Heinrich Schuchardt wrote: On 7/29/22 23:54, Jae Hyun Yoo wrote: From: Graeme Gregory The FRU handling was added as a Xilinx board dependent support but it would be useful for other boards too, so this commit moves the FRU handling support to the common region so

Re: [PATCH v1 0/2] cmd/fru: move FRU handling support to common region

2022-08-01 Thread Jae Hyun Yoo
Hi Michal, On 8/1/2022 3:29 AM, Michal Simek wrote: On 7/29/22 23:54, Jae Hyun Yoo wrote: Hello, The FRU handling was added as a Xilinx board dependent support but it would be useful for other boards too, so this commit moves the FRU handling support to the common region so that it can

[PATCH v1 2/2] cmd: fru: add product info area parsing support

2022-07-29 Thread Jae Hyun Yoo
Add product info area parsing support. Custom product info field parsing function 'fru_parse_product_custom' can be replaced with a board specific implementation. Signed-off-by: Jae Hyun Yoo --- Changes from RFC: * Added manufacturer custom product info fields parsing flow. common/fru_ops.c

[PATCH v1 1/2] cmd: fru: move FRU handling support to common region

2022-07-29 Thread Jae Hyun Yoo
Gregory Signed-off-by: Jae Hyun Yoo --- Changes from RFC: * Made FRU typecode string table as a generic and sharable table. (Michal) * Made OEM multirecord parsing call happen only on customizable type IDs. (Michal) * Added manufacturer custom board info fields parsing flow. (Michal) board

[PATCH v1 0/2] cmd/fru: move FRU handling support to common region

2022-07-29 Thread Jae Hyun Yoo
' parsing support. Please review! Thanks, Jae Graeme Gregory (1): cmd: fru: move FRU handling support to common region Jae Hyun Yoo (1): cmd: fru: add product info area parsing support board/xilinx/Kconfig | 8 - board/xilinx/common/Makefile | 3 - board

Re: [RFC PATCH 1/2] cmd/fru: cmd/fru: move FRU handling support to common region

2022-07-29 Thread Jae Hyun Yoo
Hello Michal, On 7/29/2022 7:38 AM, Jae Hyun Yoo wrote: On 7/29/2022 4:13 AM, Michal Simek wrote: The main reason why I didn't added to generic location was that in board field there are xilinx specific custom fields. With other vendor this won't work. I think this should be solved before

Re: [RFC PATCH 1/2] cmd/fru: cmd/fru: move FRU handling support to common region

2022-07-29 Thread Jae Hyun Yoo
Hello Michal, On 7/29/2022 4:13 AM, Michal Simek wrote: You should fix subject. Ah, I'll remove one of 'cmd/fru:' prefix in the title. On 7/27/22 01:50, Jae Hyun Yoo wrote: From: Graeme Gregory The FRU handling was added as a Xilinx board dependent support but it would be useful

Re: [RFC PATCH 2/2] cmd/fru: add product info area parsing support

2022-07-29 Thread Jae Hyun Yoo
Hello Michal, On 7/29/2022 4:11 AM, Michal Simek wrote: +    static const char * const typecode[] = { +    "Binary/Unspecified", +    "BCD plus", +    "6-bit ASCII", +    "8-bit ASCII", +    "2-byte UNICODE" +    }; This should be generic for all records and should be

[RFC PATCH 2/2] cmd/fru: add product info area parsing support

2022-07-26 Thread Jae Hyun Yoo
Add product info area parsing support. Signed-off-by: Jae Hyun Yoo --- common/fru_ops.c | 134 ++- include/fru.h| 22 2 files changed, 155 insertions(+), 1 deletion(-) diff --git a/common/fru_ops.c b/common/fru_ops.c index 0c5e264226ed

[RFC PATCH 1/2] cmd/fru: cmd/fru: move FRU handling support to common region

2022-07-26 Thread Jae Hyun Yoo
OEM board specifically, it defines 'fru_parse_multirec' as a weak function so that it can be replaced with the board specific implementation. Signed-off-by: Graeme Gregory Signed-off-by: Jae Hyun Yoo --- board/xilinx/Kconfig | 8 --- board/xilinx/common/Makefile

[RFC PATCH 0/2] cmd/fru: move FRU handling support to common region

2022-07-26 Thread Jae Hyun Yoo
region Jae Hyun Yoo (1): cmd/fru: add product info area parsing support board/xilinx/Kconfig | 8 - board/xilinx/common/Makefile | 3 - board/xilinx/common/board.c | 63 ++-- cmd/Kconfig | 8 + cmd

Re: [PATCH] mtd: spi-nor-ids: add winbond w25q512nw family support

2022-07-10 Thread Jae Hyun Yoo
Hello Jagan, On 7/9/2022 10:20 PM, Jagan Teki wrote: On Sat, Jul 9, 2022 at 12:10 AM Jae Hyun Yoo wrote: Add Winbond w25q512nwiq/in and w25q512nwim support. datasheet: https://www.winbond.com/resource-files/W25Q512NW%20RevB%2007192021.pdf Signed-off-by: Jae Hyun Yoo --- Applied to u

[PATCH v2] mtd: spi-nor-ids: add winbond w25q512nw family support

2022-07-08 Thread Jae Hyun Yoo
Add Winbond w25q512nwq/n and w25q512nwm support. datasheet: https://www.winbond.com/resource-files/W25Q512NW%20RevB%2007192021.pdf Signed-off-by: Jae Hyun Yoo --- Changes in v2: * Changed name from w25q512nwiq and w25q512nwim to w25q512nwq and w25q512nwm respectively to make them sync

[PATCH] mtd: spi-nor-ids: add winbond w25q512nw family support

2022-07-08 Thread Jae Hyun Yoo
Add Winbond w25q512nwiq/in and w25q512nwim support. datasheet: https://www.winbond.com/resource-files/W25Q512NW%20RevB%2007192021.pdf Signed-off-by: Jae Hyun Yoo --- drivers/mtd/spi/spi-nor-ids.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/mtd/spi/spi-nor-ids.c b