Re: [PATCH 2/3] TI QSPI: add support for dual and quad-bit I/O read

Pratyush, On Mon, Nov 30, 2020 at 2:09 PM Pratyush Yadav wrote: > > Hi Jean, > > Quick disclaimer: I am not familiar with the IP or the driver so I just > gave this patch a brief read and did not dig into it a lot. This is in > no way a comprehensive review. > > On 29/1

Re: [PATCH 1/3] mtd: spi nor: add support for dual and quad bit transfers

Hi Pratyush, On Mon, Nov 30, 2020 at 1:37 PM Pratyush Yadav wrote: > > Hi Jean, > > On 29/11/20 11:39AM, Jean Pihet wrote: > > Use the flags field of the SPI slave struct to pass the dual and quad > > read properties, from the SPI NOR layer to the low level driver. >

[PATCH 3/3] TI QSPI: prevent a 4-byte write to the flash on read access

In MMIO mode, a write to the flash generates write commands to the device. Prevent this from happening when reading from the device. Signed-off-by: Jean Pihet --- drivers/spi/ti_qspi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/ti_qspi.c b/drivers/spi/ti_qspi.c index

[PATCH 2/3] TI QSPI: add support for dual and quad-bit I/O read

frequency in order to correctly generate the required SPI CLK frequency. Signed-off-by: Jean Pihet --- drivers/spi/Kconfig | 9 ++ drivers/spi/ti_qspi.c | 68 --- 2 files changed, 66 insertions(+), 11 deletions(-) diff --git a/drivers/spi/Kconfig b

[PATCH 1/3] mtd: spi nor: add support for dual and quad bit transfers

Use the flags field of the SPI slave struct to pass the dual and quad read properties, from the SPI NOR layer to the low level driver. Tested with TI QSPI in 1, 2 and 4 bits modes. Signed-off-by: Jean Pihet --- drivers/mtd/spi/spi-nor-core.c | 34 +++--- drivers/spi