Re: [U-Boot] [OE-core] [PATCH] u-boot: Upgrade to 2017.11 release

2017-11-16 Thread Jeroen Hofstee
Hello Ledislav, While I see no reason U-Boot list was cc'ed on this patch, your attitude is almost perfect example how _not_ to do opensource development. As an occasional reader, it seems that this is a rather harsh, I am sure Marex and Otavio can handle it themselves.. Regards, Jeroen

Re: [U-Boot] [PATCH v2 1/1] malloc: don't compare pointers to 0

2017-11-12 Thread Jeroen Hofstee
Hello Heinrich, On 11/10/2017 09:46 PM, Heinrich Schuchardt wrote: 0 is not a pointer. So do not compare pointers to 0. Do not return 0 from functions with a pointer return type. Problem identified with Coccinelle. Perhaps you can elaborate on what problem you are solving? As far as I know i

Re: [U-Boot] [PATCH] omap2: nand: Make NAND_OMAP_GPMC_PREFETCH default

2017-10-21 Thread Jeroen Hofstee
ed-by: Jeroen Hofstee As a side note, tweaking the gpmc timing can potentially make reading from NAND a bit faster as well. Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-22 Thread Jeroen Hofstee
Hello Siarhei, On 07/21/2017 08:46 PM, Siarhei Siamashka wrote: On Wed, 19 Jul 2017 20:26:54 +0200 Jeroen Hofstee wrote: Hi, On 07/18/2017 08:10 PM, Joe Hershberger wrote: Hi Maxime, On Wed, Jul 12, 2017 at 9:34 AM, Maxime Ripard wrote: The -mno-unaligned-access flag used on ARM to

Re: [U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

2017-07-19 Thread Jeroen Hofstee
Hi, On 07/18/2017 08:10 PM, Joe Hershberger wrote: Hi Maxime, On Wed, Jul 12, 2017 at 9:34 AM, Maxime Ripard wrote: The -mno-unaligned-access flag used on ARM to prevent GCC from generating unaligned accesses (obviously) will only do so on packed structures. It seems like gcc 7.1 is a bit s

Re: [U-Boot] [PATCH] net: Disable the format-extra-args warning

2017-05-10 Thread Jeroen Hofstee
Hello Tom, right, a bit outdated knowledge, but at least more then two years ago, working around this warning would always lead to code increase and I can't think of a reason why the code can actually fail. Suppressing the warning seems fine with me. Regards, Jeroen On 05/10/2017 09:26 PM, To

[U-Boot] twister fails to start u-boot from NAND

2017-01-21 Thread Jeroen Hofstee
Hi, I am facing some issues when booting u-boot (755b06d1c0f) from _NAND_ on a twister board. It works fine when booting from mmc. u-boot v2016.09 works fine from NAND as well. The first issue is that it hangs after DRAM initialization / before NAND is found. Git bisect points to 085be482f6 (ARM

Re: [U-Boot] [PATCH v2 2/4] kconfig: Add a FREEBSD option

2017-01-21 Thread Jeroen Hofstee
Hello Simon, On 21-01-17 04:51, Simon Glass wrote: Hi, On 17 January 2017 at 08:50, Emmanuel Vadot wrote: Add a FreeBSD option that enable the API and enable the data cache command as it is needed to boot the FreeBSD loader. Signed-off-by: Emmanuel Vadot --- common/Kconfig | 9 +

Re: [U-Boot] [PATCH v3 02/14] ARM: zynq: Remove CONFIG_API

2015-12-03 Thread Jeroen Hofstee
Hi, On 03-12-15 17:09, Jagan Teki wrote: On 3 December 2015 at 20:17, Michal Simek wrote: CONFIG_API is causing compilation error when DM_ETH is enabled because eth_get_dev() is not available. Then how come, freebsd elf generate w/o CONFIG_API? Signed-off-by: Michal Simek --- Changes in v

Re: [U-Boot] [PATCH] arm, ubifs: fix gcc5.x compiler warning

2015-11-30 Thread Jeroen Hofstee
Hello Heiko, On 30-11-15 11:03, Heiko Schocher wrote: Am 30.11.2015 um 10:20 schrieb Jeroen Hofstee: Hello Heiko, On 30-11-15 08:47, Heiko Schocher wrote: compiling U-Boot for openrd_base_defconfig with gcc 5.x shows the following warning: CC fs/ubifs/super.o In file included from

Re: [U-Boot] [PATCH] arm, ubifs: fix gcc5.x compiler warning

2015-11-30 Thread Jeroen Hofstee
Hello Heiko, On 30-11-15 08:47, Heiko Schocher wrote: compiling U-Boot for openrd_base_defconfig with gcc 5.x shows the following warning: CC fs/ubifs/super.o In file included from fs/ubifs/ubifs.h:35:0, from fs/ubifs/super.c:37: fs/ubifs/super.c: In function 'atomic_i

[U-Boot] [PATCH] imx: mx6: add missing return value

2015-11-29 Thread Jeroen Hofstee
cc: Peng Fan Signed-off-by: Jeroen Hofstee --- not tested ;) arch/arm/cpu/armv7/mx6/clock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c index 67e0f32..4f6fe86 100644 --- a/arch/arm/cpu/armv7/mx6/clock.c +++ b/arch/arm

Re: [U-Boot] GCC5.x support for old u-boot version

2015-11-25 Thread Jeroen Hofstee
Hello Ayoub, On 25-11-15 10:35, Ayoub Zaki wrote: we have an am335x based custom board that use for our Project. At the moment only a customized version of uboot-2013.01.01 supports this board. As we use Yocto toolchains and we plan to upgrade to latest Yocto-2.0 that comes with GCC5.2. I would

Re: [U-Boot] Very slow fatload on bcm2835

2015-06-17 Thread Jeroen Hofstee
Hello Marek, -while (get_timer(bcm_host->last_write) < bcm_host->twoticks_delay) +while (timer_get_us() < bcm_host->last_write + bcm_host->twoticks_delay) ; Can this counter / the right side of the comparison not overflow? Regards, Jeroen ___

Re: [U-Boot] [PATCH] net: davinci_emac: don't teardown inactive rx channel

2015-06-08 Thread Jeroen Hofstee
+cc (forget them somehow) On 07-06-15 17:30, Jeroen Hofstee wrote: Tearing down an unitialized rx channel causes a pending address hole event to be queued. When booting linux it will report this pending as something like "Address Hole seen by USB_OTG at address 57fff584", since u-bo

[U-Boot] [PATCH] net: davinci_emac: don't teardown inactive rx channel

2015-06-07 Thread Jeroen Hofstee
own the rx channel, when not receiving. Signed-off-by: Jeroen Hofstee --- To replicate this: - ROMcode must not use the emac - U-Boot must use the emac - only on cold start --- drivers/net/davinci_emac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/davinci_emac.c

Re: [U-Boot] Query on weak function for board specific initialisation

2015-05-30 Thread Jeroen Hofstee
Hello Maity, On 30-04-15 14:57, maitysancha...@gmail.com wrote: Hello, I am trying to use a weak function in able to provide a board specific initialisation. To be more specific, I am trying to use the __weak board_ehci_hcd_init function in the usb driver code which is called in ehci_hcd_init,

[U-Boot] [RFC] tam3517: add GPMC nand timing (brutally)

2015-05-30 Thread Jeroen Hofstee
cc: Stefano Babic Cc: Scott Wood Cc: Tom Rini Cc: Tapani Utriainen cc: Simon Glass --- Hi, This patch intends to set the proper timing for the MT29F4G16ABBDAHC as used on the tam3517 SOM by brutally changing the defaults values. Some ascii art is included to describe why I believe these timin

[U-Boot] [PATCH 3/3] boards: tam3517-common: enable gpmc prefetch mode

2015-05-30 Thread Jeroen Hofstee
Since the tam3517 base board has a 16bit wide nand connected to the gpmc, enable the prefetch mode, since that is now supported. Cc: Scott Wood Cc: Tom Rini Cc: pekon gupta Cc: Nishanth Menon Cc: Daniel Mack Cc: Tapani Utriainen Signed-off-by: Jeroen Hofstee --- include/configs/tam3517

[U-Boot] [PATCH 0/3] nand, gpmc: support 16nand prefetch mode

2015-05-30 Thread Jeroen Hofstee
This patchset enables the gpmc prefetch mode for 16bit addressed nand and enables it for tam3517 derived boards. Jeroen Hofstee (3): omap_gpmc: move prefetch out of CONFIG_NAND_OMAP_ELM mtd: OMAP: Enable GPMC prefetch mode for 16 bit access boards: tam3517-common: enable gpmc prefetch mode

[U-Boot] [PATCH 1/3] omap_gpmc: move prefetch out of CONFIG_NAND_OMAP_ELM

2015-05-30 Thread Jeroen Hofstee
The prefech mode is a feature of the gpmc, not the ELM. An am3517 does not have an elm, but can do prefeches, so move the code out of the CONFIG_NAND_OMAP_ELM ifdef. Cc: Scott Wood Cc: Tom Rini Cc: Daniel Mack Signed-off-by: Jeroen Hofstee --- drivers/mtd/nand/omap_gpmc.c | 218

[U-Boot] [PATCH 2/3] mtd: OMAP: Enable GPMC prefetch mode for 16 bit access

2015-05-30 Thread Jeroen Hofstee
commit c316f57 "mtd: OMAP: Enable GPMC prefetch mode" only enabled prefetch mode for 8 bit nand access, this adds 16 bit as well. Cc: Scott Wood Cc: Tom Rini Cc: Daniel Mack Signed-off-by: Jeroen Hofstee --- drivers/mtd/nand/omap_gpmc.c | 28 ++-- 1 file c

Re: [U-Boot] [PATCH 01/10] Move board_init_f_mem() into a common location

2015-04-16 Thread Jeroen Hofstee
Hello Simon, On 16-04-15 03:14, Simon Glass wrote: + +DECLARE_GLOBAL_DATA_PTR; + +ulong board_init_f_mem(ulong top) +{ + /* TODO(s...@chromium.org): Figure out how x86 can use this */ +#ifndef CONFIG_X86 + /* Leave space for the stack we are running with now */ + top -= 0x40; +

Re: [U-Boot] Where can I find u-boot which supports Raspberry Pi B+

2015-04-11 Thread Jeroen Hofstee
Hello Huan, On 05-04-15 03:37, Huan Ngo wrote: Hi, I want to boot up Raspberry Pi B+ with u-boot. Where can I get a u-boot source code/image that can boot up my Raspberry Pi B+? Regards, Huan You can obtain u-boot sources by the meth

Re: [U-Boot] Can't boot DaVinci EVM with Green Hills' Integrity OS

2015-03-31 Thread Jeroen Hofstee
Hello Idan, On 31-03-15 06:02, Idan Noti wrote: Why do you think caches have something to do with the problem? By booting the image with the bootelf command you jump to it with some caches still enabled / not flushed (which is likely not what your debug interface does and your kernel might n

Re: [U-Boot] Can't boot DaVinci EVM with Green Hills' Integrity OS

2015-03-30 Thread Jeroen Hofstee
Hello noti1234, On 30-03-15 20:44, noti1234 wrote: I'm having problems booting my DaVinci board with Green-Hills' Integrity OS. My setup is: Hardware: TI's DaVinci EVM: http://www.spectrumdigital.com/product_info.php?products_id=192 u-boot: u-boot-2015.4-rc3. Configured for dvevm with elf suppor

Re: [U-Boot] [PATCH] sandbox: Adjust the order of the NO_SDL check

2015-02-12 Thread Jeroen Hofstee
_NO_SDL -endif yup, feel free to commit this (it can't do any harm just prevents some warnings). Which I guess translates to Acked-by: Jeroen Hofstee Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] sandbox on FreeBSD

2015-02-09 Thread Jeroen Hofstee
Hello Simon, On 02/07/15 16:10, Simon Glass wrote: I am not giving up, I think it is sane if a tool which adds a header and a checksum does not use linker magic. Sandbox biggest problem is not the linking, but the fact that linux headers and std* are included, it is a different topic. This

Re: [U-Boot] recent tools on FreeBSD

2015-02-08 Thread Jeroen Hofstee
Hello Simon, On 07-02-15 22:02, Simon Glass wrote: If this still fails, you can always build it from source, but needs a bit of patience. Somthing like this should always work: portsnap fetch portsnap extract cd /usr/ports/devel/git make config-recursive make make install Let me know if you s

Re: [U-Boot] [RFC PATCH] tools/imagetool: remove linker generated list

2015-02-07 Thread Jeroen Hofstee
Thanks, On 02/07/15 22:19, Andreas Bießmann wrote: Commit a93648d197df48fa46dd55f925ff70468bd81c71 introduced linker generated lists for imagetool which is part of mkimage. It is a nice feature to remove the annoying register function calls, but is not portable. Unfortunately some host compilers

Re: [U-Boot] recent tools on FreeBSD

2015-02-07 Thread Jeroen Hofstee
Hello Simon, On 07-02-15 16:10, Simon Glass wrote: On 7 February 2015 at 03:04, Jeroen Hofstee wrote: I am missing the point, u-boot and its tools build fine until v2015.04-rc1 on FreeBSD and a mac. And this is easily fixed by not using linker magic for tools. (and yes sandbox likely fails

Re: [U-Boot] recent tools on FreeBSD

2015-02-07 Thread Jeroen Hofstee
Hi Simon, On 06-02-15 22:00, Simon Glass wrote: Hi, On 6 February 2015 at 13:40, Andreas Bießmann wrote: Hi, On 06.02.15 20:56, Jeroen Hofstee wrote: Hello Simon, +Andreas, On 06-02-15 04:05, Simon Glass wrote: Hi Jeroen, On 5 February 2015 at 12:51, Jeroen Hofstee wrote: Hello

Re: [U-Boot] recent tools on FreeBSD

2015-02-06 Thread Jeroen Hofstee
Hello Simon, +Andreas, On 06-02-15 04:05, Simon Glass wrote: Hi Jeroen, On 5 February 2015 at 12:51, Jeroen Hofstee wrote: Hello Guilherme, Thanks for commenting on this, On 02/05/15 13:27, Guilherme Maciel Ferreira wrote: Hi Jeroen, My apologies, I didn't test the tools on BSD

Re: [U-Boot] recent tools on FreeBSD

2015-02-05 Thread Jeroen Hofstee
Hello Guilherme, Thanks for commenting on this, On 02/05/15 13:27, Guilherme Maciel Ferreira wrote: Hi Jeroen, My apologies, I didn't test the tools on BSD. The answers are inline. Best regards, Guilherme Am 04.02.2015 19:37 schrieb "Jeroen Hofstee" : Hello Guilherme / S

Re: [U-Boot] recent tools on FreeBSD

2015-02-04 Thread Jeroen Hofstee
Hi Simon, On 05-02-15 04:34, Simon Glass wrote: Hi Jeroen, On 4 February 2015 at 12:37, Jeroen Hofstee wrote: Hello Guilherme / Simon, It seems that commit f86ed6a8d52c99bb2d17d3cac1647edca0c4399c, "tools: moved code common to all image tools to a separated module." cause some tr

[U-Boot] recent tools on FreeBSD

2015-02-04 Thread Jeroen Hofstee
Hello Guilherme / Simon, It seems that commit f86ed6a8d52c99bb2d17d3cac1647edca0c4399c, "tools: moved code common to all image tools to a separated module." cause some trouble when building on FreeBSD. /usr/bin/ld:./tools/imagetool.lds:24: syntax error cc: error: linker command failed with exit

Re: [U-Boot] [PATCH 1/2] image: bootm: Add OpenRTOS image type

2014-12-16 Thread Jeroen Hofstee
Hello Marek, On 16-12-14 14:07, Marek Vasut wrote: Add separate image type for the Wittenstein OpenRTOS . Signed-off-by: Marek Vasut Cc: Simon Glass Cc: Tom Rini --- common/bootm_os.c | 29 + common/image.c| 4 include/image.h | 1 + 3 files chan

Re: [U-Boot] uBoot services

2014-12-13 Thread Jeroen Hofstee
Hello Gary, On 13-12-14 20:20, Gary Partis wrote: Hi all I am using a Xilinx Zynq device (dual core ARM) which has uBoot in its internal boot flash. I am sure I have read somewhere that uBoot has a number of services available to "bare metal" applications, such as malloc et Al. Is this so? I

Re: [U-Boot] ti, am3517: errata 430973 workaround

2014-12-10 Thread Jeroen Hofstee
Hello Robert, Andreas, On 09-12-14 22:45, Robert Nelson wrote: On Mon, Dec 8, 2014 at 4:19 PM, Jeroen Hofstee wrote: Hi, A while ago [1], a RFC was posted to disable workaround for besides others, errata 430973. It is a bit unclear to me which revision actually need this workaround, but as

[U-Boot] ti, am3517: errata 430973 workaround

2014-12-08 Thread Jeroen Hofstee
Hi, A while ago [1], a RFC was posted to disable workaround for besides others, errata 430973. It is a bit unclear to me which revision actually need this workaround, but as suggested in [2] also enabling this workaround in Linux seem to make some weird problems go away in linux (signal 4, bad in

Re: [U-Boot] [PATCH] Revert "ARM: SPL: do not set gd again"

2014-11-28 Thread Jeroen Hofstee
Hi all, On 11-11-14 22:57, Tom Rini wrote: On Mon, Nov 10, 2014 at 03:13:44PM -0700, Simon Glass wrote: +Albert Hi Tom, On 16 September 2014 18:47, Tom Rini wrote: On Tue, Sep 16, 2014 at 08:27:23PM -0400, Tom Rini wrote: At the high level, the problem is that we set gd multiple times (an

Re: [U-Boot] [PATCH] fix: tools: kwbimage.c: Initialize headersz to suppress warning

2014-11-21 Thread Jeroen Hofstee
Hello Albert, On 21-11-14 16:30, Albert ARIBAUD wrote: On Fri, 21 Nov 2014 13:34:41 +0100, Jeroen Hofstee wrote: But oh well, if it fixes a warning :-) I didn't claim that there is a bug in the code :-). I just get annoying when on my continuous integration script I see the same wa

Re: [U-Boot] [PATCH] fix: tools: kwbimage.c: Initialize headersz to suppress warning

2014-11-21 Thread Jeroen Hofstee
Hi, On 21-11-14 10:20, Lukasz Majewski wrote: Hi Thomas, Dear Lukasz Majewski, Thanks for your patch. On Fri, 21 Nov 2014 09:22:43 +0100, Lukasz Majewski wrote: When building with my toolchain (4.8.2): CROSS_COMPILE=/home/lukma/work/ptxdist/toolchains/arm/OSELAS.Toolchain-2013.12.0/arm-v7a-

Re: [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds

2014-11-20 Thread Jeroen Hofstee
Hi, On 20-11-14 19:21, Bill Pringlemeir wrote: --- arch/arm/lib/memset.S | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/arch/arm/lib/memset.S b/arch/arm/lib/memset.S index 0cdf895..4fe38f6 100644 --- a/arch/arm/lib/memset.S +++ b/arc

Re: [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds

2014-11-20 Thread Jeroen Hofstee
Hi, On 20-11-14 16:18, Bill Pringlemeir wrote: --- arch/arm/lib/memset.S | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/arch/arm/lib/memset.S b/arch/arm/lib/memset.S index 0cdf895..4fe38f6 100644 --- a/arch/arm/lib/memset.S +++ b/a

Re: [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds

2014-11-20 Thread Jeroen Hofstee
Hello Stefan, On 20-11-14 13:15, Stefan Agner wrote: Hi Jeroen, On 2014-11-20 10:21, Jeroen Hofstee wrote: Hello Stefan, On 19-11-14 15:16, Stefan Agner wrote: Resynchronize memcpy/memset with kernel and build them explicitly in Thumb2 mode (unified syntax). Those assembler files can be

Re: [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds

2014-11-20 Thread Jeroen Hofstee
Hello Stefan, On 19-11-14 15:16, Stefan Agner wrote: Resynchronize memcpy/memset with kernel and build them explicitly in Thumb2 mode (unified syntax). Those assembler files can be built and linked in ARM mode too, however when calling them from Thumb2 built code, the stack got corrupted and the

Re: [U-Boot] [PATCH] tools/kwbimage.c: fix parser error handling

2014-11-13 Thread Jeroen Hofstee
Hello Andreas, On 27-10-14 13:06, Jeroen Hofstee wrote: Hello Andreas, On 24-10-14 23:25, andreas.de...@googlemail.com wrote: From: Andreas Bießmann The two error checks for image_boot_mode_id and image_nand_ecc_mode_id where wrong and would never fail, fix that! This was detected by

Re: [U-Boot] [PATCH v2 6/8] imx6: SPL support for iMX6 SabreSD

2014-11-08 Thread Jeroen Hofstee
Hello John, On 08-11-14 19:22, John Tobias wrote: This patch will enable the support for SPL on iMX6 SabreSD. It tested on SD2 and SD3 mmc port. --- board/freescale/mx6sabresd/mx6sabresd.c | 216 1 file changed, 216 insertions(+) diff --git a/board/freesc

Re: [U-Boot] buildman: using wrong libgcc.a

2014-11-05 Thread Jeroen Hofstee
Hello Simon, On 03-11-14 22:14, Simon Glass wrote: Hi, On 30 October 2014 14:57, Jeroen Hofstee wrote: Hello Steve, On 30-10-14 21:42, Steve Rae wrote: H -- maybe it would be better to specify the entire path for the CROSS_COMPILE, and not rely on the PATH to find the cross compile

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-04 Thread Jeroen Hofstee
Hello Peng, On 04-11-14 14:36, Peng Fan wrote: Hi Jeroen, 在 11/4/2014 7:40 PM, Jeroen Hofstee 写道: Hello Peng, On 04-11-14 08:50, Peng Fan wrote: Include a weak function board_ehci_usb_mode to gives board code a choice. If the board want the otg port work in host mode but not device mode

Re: [U-Boot] [PATCH v2 1/3] usb:ehci-mx6 add board_ehci_usb_mode function

2014-11-04 Thread Jeroen Hofstee
Hello Peng, On 04-11-14 08:50, Peng Fan wrote: Include a weak function board_ehci_usb_mode to gives board code a choice. If the board want the otg port work in host mode but not device mode, this should be handled. Signed-off-by: Peng Fan Signed-off-by: Ye Li --- Changes v2: Introduce a ne

Re: [U-Boot] Building fw_printenv (e.g. make env) failing

2014-11-02 Thread Jeroen Hofstee
Hello Marcel, On 02-11-14 02:46, Marcel Ziswiler wrote: Quick question: How does one actually go about building fw_printenv nowadays? At lest just doing 'make env' fails for me: [user@host u-boot.git]$ make env HOSTCC tools/env/aes.o HOSTCC tools/env/crc32.o HOSTCC tools/env/ctype.o

Re: [U-Boot] buildman: using wrong libgcc.a

2014-10-30 Thread Jeroen Hofstee
Hello Steve, On 30-10-14 21:42, Steve Rae wrote: H -- maybe it would be better to specify the entire path for the CROSS_COMPILE, and not rely on the PATH to find the cross compile tools: diff --git a/tools/buildman/toolchain.py b/tools/buildman/toolchain.py index 27dc318..58c7b1f 100644 --

Re: [U-Boot] [PATCH 3/3] common: introduce board_preboot_os hook

2014-10-29 Thread Jeroen Hofstee
Hello Nikita, On 29-10-14 14:08, Nikita Kiryanov wrote: Introduce board specific function board_preboot_os() to allow for board specific config before we boot, and use it on cm_fx6 to power off sata so that Linux will be able to setup it correctly. Signed-off-by: Nikita Kiryanov Cc: Igor Grinb

Re: [U-Boot] [PATCH] dwc_ahsata: use bitwise operator in sata_port_status

2014-10-28 Thread Jeroen Hofstee
Hello Nikita, On 28-10-14 13:59, Nikita Kiryanov wrote: The logic of the return statement in sata_port_status() calls for a bitwise 'AND' operator, not logical 'AND'. Fix the typo. Reported-by: Jeroen Hofstee Cc: Jeroen Hofstee Cc: Stefano Babic Signed-off-by: Nikita Kir

Re: [U-Boot] [PATCH 02/10] Add some standard headers external code might need

2014-10-28 Thread Jeroen Hofstee
Hello Simon, On 28-10-14 18:33, Simon Glass wrote: Hi Masahiro, On 28 October 2014 10:38, Masahiro YAMADA wrote: Hi Simon, 2014-10-29 1:29 GMT+09:00 Simon Glass : Hi Masahiro, On 28 October 2014 10:25, Masahiro YAMADA wrote: Hi Gabe, Simon, 2014-10-15 19:38 GMT+09:00 Simon Glass : Fr

[U-Boot] clang warning

2014-10-27 Thread Jeroen Hofstee
Hello Nikita, Commit dc383dd introduces the following clang warning: drivers/block/dwc_ahsata.c:881:35: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] return readl(&(port_mmio->ssts)) && SATA_PORT_SSTS_DET_MASK;

[U-Boot] [PATCH v3 0/3] reduce warnings with W=1

2014-10-27 Thread Jeroen Hofstee
split i2c: use __weak (included i2c and l2_cache) - redo serial: add prototypes for init functions Jeroen Hofstee (3): i2c: use __weak arm926ejs: cache: use __weak serial: add prototypes for init functions arch/arm/cpu/arm926ejs/cache.c | 5 +- drivers/i2c/i2c_core.c | 8 +-

[U-Boot] [PATCH v3 1/3] i2c: use __weak

2014-10-27 Thread Jeroen Hofstee
Cc: Heiko Schocher Signed-off-by: Jeroen Hofstee --- drivers/i2c/i2c_core.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/i2c_core.c b/drivers/i2c/i2c_core.c index 18d6736..d34b749 100644 --- a/drivers/i2c/i2c_core.c +++ b/drivers/i2c/i2c_core.c

Re: [U-Boot] [PATCH 04/49] i2c: use __weak

2014-10-27 Thread Jeroen Hofstee
Hello Tom, On 27-10-14 01:31, Tom Rini wrote: On Thu, Oct 09, 2014 at 08:14:40PM +0200, Jeroen Hofstee wrote: Hello Heiko, On 09-10-14 07:00, Heiko Schocher wrote: Am 08.10.2014 22:57, schrieb Jeroen Hofstee: Signed-off-by: Jeroen Hofstee --- arch/arm/cpu/arm926ejs/cache.c | 5

[U-Boot] [PATCH v2, rebased 3/3] serial: add prototypes for init functions

2014-10-27 Thread Jeroen Hofstee
While at it, sort them. Cc: Tom Rini Cc: Simon Glass Signed-off-by: Jeroen Hofstee --- drivers/serial/serial.c | 140 include/serial.h| 49 + 2 files changed, 119 insertions(+), 70 deletions(-) diff --git a/drivers

[U-Boot] [PATCH v2, rebased 2/3] arm926ejs: cache: use __weak

2014-10-27 Thread Jeroen Hofstee
Cc: Albert Aribaud Signed-off-by: Jeroen Hofstee --- arch/arm/cpu/arm926ejs/cache.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/arm/cpu/arm926ejs/cache.c b/arch/arm/cpu/arm926ejs/cache.c index e86c2ed..8d7873c 100644 --- a/arch/arm/cpu/arm926ejs/cache.c +++ b

[U-Boot] [PATCH v2, rebased 1/3] i2c: use __weak

2014-10-27 Thread Jeroen Hofstee
Acked-by: Heiko Schocher Signed-off-by: Jeroen Hofstee --- drivers/i2c/i2c_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/i2c_core.c b/drivers/i2c/i2c_core.c index 18d6736..7f63987 100644 --- a/drivers/i2c/i2c_core.c +++ b/drivers/i2c/i2c_core.c

[U-Boot] [PATCH v2, rebased 0/3] reduce warnings with W=1

2014-10-27 Thread Jeroen Hofstee
tatic". Tom posted a more complete cleanup. - Drop common/cmd_elf.c: add missing include (a slightly adjusted version was applied). - split i2c: use __weak (included i2c and l2_cache) - redo serial: add prototypes for init functions Jeroen Hofstee (3): i2c: use __weak arm926ejs:

Re: [U-Boot] [PATCH] tools/kwbimage.c: fix parser error handling

2014-10-27 Thread Jeroen Hofstee
Hello Andreas, On 24-10-14 23:25, andreas.de...@googlemail.com wrote: From: Andreas Bießmann The two error checks for image_boot_mode_id and image_nand_ecc_mode_id where wrong and would never fail, fix that! This was detected by Apple's clang compiler: ---8<--- HOSTCC tools/kwbimage.o too

Re: [U-Boot] [PATCH 0/10] Provide inttypes.h to avoid 32/64 bit problems with printf()

2014-10-26 Thread Jeroen Hofstee
Hello Simon, On 24-10-14 03:03, Simon Glass wrote: +Jeroen Hi, On 15 October 2014 04:38, Simon Glass wrote: In quite a few situations we have to print a 64-bit value. Unfortunately the type used for 64-bit can vary depending on the machine. For 64-bit machines it might be 'long' and for 32-b

Re: [U-Boot] [PATCH 0/10] Provide inttypes.h to avoid 32/64 bit problems with printf()

2014-10-26 Thread Jeroen Hofstee
Hi Simon, attempt two.. On 24-10-14 03:03, Simon Glass wrote: +Jeroen Hi, On 15 October 2014 04:38, Simon Glass wrote: In quite a few situations we have to print a 64-bit value. Unfortunately the type used for 64-bit can vary depending on the machine. For 64-bit machines it might be 'long' a

Re: [U-Boot] [PATCH v3] board: wandboard: add usb storage

2014-10-23 Thread Jeroen Hofstee
Hello Fabio, On 23-10-14 23:04, Fabio Estevam wrote: On Thu, Oct 23, 2014 at 7:02 PM, Jeroen Hofstee wrote: Cc: Fabio Estevam Signed-off-by: Jeroen Hofstee Acked-by: Fabio Estevam Please add Stefano on Cc next time. I would have normally, but get_maintainer instructed me not to do so

[U-Boot] [PATCH v3] board: wandboard: add usb storage

2014-10-23 Thread Jeroen Hofstee
Cc: Fabio Estevam Signed-off-by: Jeroen Hofstee --- version 3: - don't blindly copy get_mainter output - don't forget the subject-prefix version 2: - remove the duplicated CONFIG_CMD_FAT --- include/configs/wandboard.h | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [U-Boot] [PATCH] board: wandboard: add usb storage

2014-10-23 Thread Jeroen Hofstee
Hello Fabio, On 23-10-14 22:49, Fabio Estevam wrote: Hi Jeroen, On Thu, Oct 23, 2014 at 6:47 PM, Jeroen Hofstee wrote: Fabio Estevam (maintainer:WANDBOARD BOARD) Patch looks good, but this commit log doesn't. yes, I see, subject of the reposted patch is not correct as well. Lets t

[U-Boot] [PATCH] board: wandboard: add usb storage

2014-10-23 Thread Jeroen Hofstee
Fabio Estevam (maintainer:WANDBOARD BOARD) Signed-off-by: Jeroen Hofstee --- version 2: remove the duplicated CONFIG_CMD_FAT --- include/configs/wandboard.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h index 37e3429

[U-Boot] [PATCH] board: wandboard: add usb storage

2014-10-23 Thread Jeroen Hofstee
Fabio Estevam (maintainer:WANDBOARD BOARD) Signed-off-by: Jeroen Hofstee --- include/configs/wandboard.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h index 37e3429..070ce92 100644 --- a/include/configs/wandboard.h

Re: [U-Boot] [PATCH] mx6sabresd: Add Seiko WVGA panel support

2014-10-22 Thread Jeroen Hofstee
On 22-10-14 15:10, Fabio Estevam wrote: On Wed, Oct 22, 2014 at 11:07 AM, Jeroen Hofstee wrote: Did you check this with a scope? I am quite sure I needed to do this for u-boot v2014.10 still, but I don't have the board available now to double check. I didn't check it with the s

Re: [U-Boot] [PATCH] mx6sabresd: Add Seiko WVGA panel support

2014-10-22 Thread Jeroen Hofstee
Hello Fabio, On 22-10-14 14:15, Fabio Estevam wrote: Hi Jeroen, On Wed, Oct 22, 2014 at 6:47 AM, Jeroen Hofstee wrote: If [1] is a datasheet for this lcd, you likely want to add #include <../drivers/video/mxcfb.h> .sync = FB_SYNC_CLK_LAT_FALL, Or something similar, sin

Re: [U-Boot] [PATCH] mx6sabresd: Add Seiko WVGA panel support

2014-10-22 Thread Jeroen Hofstee
Hello Fabio, On 22-10-14 01:14, Fabio Estevam wrote: From: Fabio Estevam Add support for the 4.3'' Seiko WVGA parallel display. In order to direct the splash screen to the Seiko display: => setenv panel SEIKO-WVGA => save => reset Signed-off-by: Fabio Estevam --- [snip] +} }, { + .

Re: [U-Boot] [PATCH] doc: fix README.standalone

2014-10-21 Thread Jeroen Hofstee
d gp on Nios II. The x86 architecture does not use such a register; instead, the pointer to the 'global_data' structure is passed as 'argv[-1]' pointer. Acked-by: Jeroen Hofstee Thanks, Jeroen ___ U-Boot mailing list U

Re: [U-Boot] [PATCH] kbuild: clear VENDOR variable to fix build error on tcsh

2014-10-21 Thread Jeroen Hofstee
. Stop. make[1]: *** [board/unknown/wandboard] Error 2 make: *** [__build_one_by_one] Error 2 Signed-off-by: Masahiro Yamada Reported-by: Tom Everett Reported-by: Jeroen Hofstee --- config.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/config.mk b/config.mk index 2157537..00

Re: [U-Boot] compile issue with U-boot-2014.10-rc2 & Cubieboard

2014-10-20 Thread Jeroen Hofstee
Hello Masahiro, On 19-10-14 16:28, Jeroen Hofstee wrote: Hello Tom, On 01-10-14 17:31, Jeroen Hofstee wrote: On 30-09-14 03:29, Tom Everett wrote: I am getting this compile error: scripts/Makefile.build:55: /tank/home/tom/freebsd/uboot/u-boot-2014.10-rc2/board/amd/sunxi/Makefile: No

Re: [U-Boot] compile issue with U-boot-2014.10-rc2 & Cubieboard

2014-10-19 Thread Jeroen Hofstee
Hello Tom, On 01-10-14 17:31, Jeroen Hofstee wrote: On 30-09-14 03:29, Tom Everett wrote: I am getting this compile error: scripts/Makefile.build:55: /tank/home/tom/freebsd/uboot/u-boot-2014.10-rc2/board/amd/sunxi/Makefile: No such file or directory gmake[1]: *** No rule to make target

Re: [U-Boot] [PATCH] Revert "sunxi: dram: Use divisor P=1 for PLL5"

2014-10-16 Thread Jeroen Hofstee
Hi Hans, On 16-10-14 10:48, Hans de Goede wrote: [snip] So for now I believe we really should revert the PLL5 u-boot changes as they break some kernels from booting. U-boot and the kernel should be independent. Hence u-boot cannot break kernels from booting or the kernel is bugged and should

Re: [U-Boot] [PATCH] sunxi: Add CONFIG_MACH_TYPE defines to sun4i, sun5i and sun7i

2014-10-16 Thread Jeroen Hofstee
Hello Hans, On 16-10-14 10:50, Hans de Goede wrote: [...] Erm, no the mach_type-s are not "safety-guards", they are absolutely necessary to get old non devicetree kernels to work at all. fyi: That is not strictly true, you should be able to do: setenv machid 4283 and it should work as well. An

Re: [U-Boot] [PATCH 2/2] video: ipu_disp: remove pixclk fixup

2014-10-15 Thread Jeroen Hofstee
Hello Stefano, On 14-10-14 20:37, Jeroen Hofstee wrote: The ipu display insists on having a lower_margin smaller then 2. If this is not the case it will attempt to force it and adjust the pixclk accordingly. This multiplies pixclk in Hz with the width and height, since this is typically a * 10

[U-Boot] [PATCH 1/2] video: ipo: fix debug and comment

2014-10-14 Thread Jeroen Hofstee
- fix debug pixel clk display and add unit - fix some comments Cc: Stefano Babic Signed-off-by: Jeroen Hofstee --- drivers/video/ipu_disp.c | 2 +- drivers/video/mxc_ipuv3_fb.c | 7 +++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/video/ipu_disp.c b/drivers

[U-Boot] [PATCH 2/2] video: ipu_disp: remove pixclk fixup

2014-10-14 Thread Jeroen Hofstee
make things even worse. Since this is a bootloader and the adjustment is neglectible, just force it to two and warn about it. Cc: Stefano Babic Signed-off-by: Jeroen Hofstee --- drivers/video/ipu_disp.c | 31 ++- 1 file changed, 6 insertions(+), 25 deletions(-) diff

Re: [U-Boot] [PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-12 Thread Jeroen Hofstee
Hello Simon, On 13-10-14 07:14, Simon Glass wrote: Hi Jeroen, On 12 October 2014 10:13, Jeroen Hofstee wrote: Hello Hans, On 12-10-14 12:25, Hans de Goede wrote: Hi, This one seems to have fallen through the cracks. Regards, Hans (for U-boot) nope, you replace an innocent warning

Re: [U-Boot] [PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-12 Thread Jeroen Hofstee
Hello Hans, On 12-10-14 12:25, Hans de Goede wrote: Hi, This one seems to have fallen through the cracks. Regards, Hans (for U-boot) nope, you replace an innocent warning (_might_ be) with bad code, without any comment it is just because gcc failed to recognize it is fine. Nor did you resp

Re: [U-Boot] [RFC PATCH] genboardscfg.py: use Python2 from default path

2014-10-12 Thread Jeroen Hofstee
Hello Wolfgang, On 30-09-14 10:17, Wolfgang Denk wrote: Instead of searching for Python2 in $PATH, use the one installed by the system (i. e. /usr/bin/python2). This prevents failures like this: -> ./MAKEALL m53evk Traceback (most recent call last): File "tools/genboardscfg.py", line 19, in

Re: [U-Boot] Discussion topics / issues

2014-10-12 Thread Jeroen Hofstee
Hello Wolfgang / Albert / others, On 10-10-14 16:04, Jeroen Hofstee wrote: Hello Wolfgang, On 10-10-14 14:22, Wolfgang Denk wrote: It does not mention puts() vs. printf(), if it is indeed meant to be u-boot policy. This is not just U-Boot philosophy, but something that I would consider a

Re: [U-Boot] Discussion topics / issues

2014-10-10 Thread Jeroen Hofstee
Hello Albert, On 10-10-14 21:51, Albert ARIBAUD wrote: Hi Jeroen, On Fri, 10 Oct 2014 18:09:19 +0200, Jeroen Hofstee wrote: Hello Marek, On 10-10-14 16:26, Marek Vasut wrote: On Friday, October 10, 2014 at 04:04:40 PM, Jeroen Hofstee wrote: Hello Wolfgang, On 10-10-14 14:22, Wolfgang

Re: [U-Boot] Discussion topics / issues

2014-10-10 Thread Jeroen Hofstee
Hello Marek, On 10-10-14 16:26, Marek Vasut wrote: On Friday, October 10, 2014 at 04:04:40 PM, Jeroen Hofstee wrote: Hello Wolfgang, On 10-10-14 14:22, Wolfgang Denk wrote: It does not mention puts() vs. printf(), if it is indeed meant to be u-boot policy. This is not just U-Boot philosophy

Re: [U-Boot] Discussion topics / issues

2014-10-10 Thread Jeroen Hofstee
Hello Wolfgang, On 10-10-14 14:22, Wolfgang Denk wrote: It does not mention puts() vs. printf(), if it is indeed meant to be u-boot policy. This is not just U-Boot philosophy, but something that I would consider a matter of course when writing code - using the appropriate tools for the task at

Re: [U-Boot] [U-Boot, 49/49] i2c: designware: add an implement i2c protos

2014-10-09 Thread Jeroen Hofstee
Hello Heiko, On 09-10-14 07:05, Heiko Schocher wrote: Hello Jeroen, Am 08.10.2014 22:58, schrieb Jeroen Hofstee: Include the i2c header and change the non confirming functions to do so. Cc: Heiko Schocher Signed-off-by: Jeroen Hofstee --- drivers/i2c/designware_i2c.c | 17

Re: [U-Boot] [PATCH 04/49] i2c: use __weak

2014-10-09 Thread Jeroen Hofstee
Hello Heiko, On 09-10-14 07:00, Heiko Schocher wrote: Am 08.10.2014 22:57, schrieb Jeroen Hofstee: Signed-off-by: Jeroen Hofstee --- arch/arm/cpu/arm926ejs/cache.c | 5 + This change seems to have nothing to do with the subject ... could you please split this? No problem, I likely

Re: [U-Boot] [PATCH 03/49] cti_flash.c: use __weak when requested

2014-10-09 Thread Jeroen Hofstee
On 08-10-14 22:57, Jeroen Hofstee wrote: For performance reason there seems to be a CONFIG_xyz. Introduce a __maybe_weak to allow using __weak directly instead of relying on aliases. Signed-off-by: Jeroen Hofstee --- drivers/mtd/cfi_flash.c | 50

[U-Boot] [PATCH 44/49] ide: add missing prototype

2014-10-08 Thread Jeroen Hofstee
Signed-off-by: Jeroen Hofstee --- include/ide.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/ide.h b/include/ide.h index c2a48e0..d5e05e9 100644 --- a/include/ide.h +++ b/include/ide.h @@ -23,6 +23,7 @@ extern ulong ide_bus_offset[]; #define LED_IDE2 0x02 #define

[U-Boot] [PATCH 48/49] tegra: add proto for pin_mux_mmc

2014-10-08 Thread Jeroen Hofstee
while at it, fix a typo Signed-off-by: Jeroen Hofstee --- arch/arm/include/asm/arch-tegra/board.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/include/asm/arch-tegra/board.h b/arch/arm/include/asm/arch-tegra/board.h index ff77364..783bb3c 100644

[U-Boot] [PATCH 49/49] i2c: designware: add an implement i2c protos

2014-10-08 Thread Jeroen Hofstee
Include the i2c header and change the non confirming functions to do so. Cc: Heiko Schocher Signed-off-by: Jeroen Hofstee --- drivers/i2c/designware_i2c.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c

[U-Boot] [PATCH 46/49] serial: add prototypes for init functions

2014-10-08 Thread Jeroen Hofstee
While at it, sort them. Signed-off-by: Jeroen Hofstee --- drivers/serial/serial.c | 141 include/serial.h| 49 + 2 files changed, 120 insertions(+), 70 deletions(-) diff --git a/drivers/serial/serial.c b/drivers/serial

[U-Boot] [PATCH 47/49] spl: add prototype for jump_to_image_no_args

2014-10-08 Thread Jeroen Hofstee
Signed-off-by: Jeroen Hofstee --- include/spl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/spl.h b/include/spl.h index a7e41da..cee251f 100644 --- a/include/spl.h +++ b/include/spl.h @@ -72,6 +72,8 @@ void spl_sata_load_image(void); int spl_load_image_fat(block_dev_desc_t

  1   2   3   4   5   6   >