Thanks so much for porting this, Alex!
On Tue, Apr 24, 2018 at 4:58 AM Alex Kiernan wrote:
> On Tue, Apr 24, 2018 at 11:24 AM, Alex Deymo wrote:
> > +Jocelyn.
> >
> > Thanks Alex for taking the time to port this!!
>
> It turned out to be a great opportunity to play with coccinelle on
> somethin
Great, I will check out v2! And yes free to add a "Signed-off-by" for me on
any of the original patchsets.
On Mon, Apr 30, 2018 at 1:37 AM Alex Kiernan wrote:
> On Fri, Apr 27, 2018 at 1:20 PM, Alex Kiernan
> wrote:
> > On Fri, Apr 27, 2018 at 9:04 AM, Lukasz Majewski wrote:
> >> Hi Kever,
> >
@param reason The second part of the response
> + * @param repsonsePointer to fastboot response buffer
> + */
> +static void write_fb_response(const char *tag, const char *reason,
> + char *response)
> +{
> + strncpy(response, tag, strlen(t
On Mon, Apr 30, 2018 at 1:33 AM Alex Kiernan wrote:
> Extract fb_set_reboot_flag() from USB code and ensure all the overides
> are included, then make the UDP fastboot code go through this same
> path.
>
> Note this changes the behaviour of the fastboot net code such that
> "reboot-bootloader" is
On Tue, May 1, 2018 at 1:21 AM Alex Kiernan wrote:
> On Tue, May 1, 2018 at 8:22 AM Alex Kiernan
> wrote:
>
>
> > On Tue, May 1, 2018 at 7:50 AM Jocelyn Bohr wrote:
>
>
>
> > > On Mon, Apr 30, 2018 at 1:33 AM Alex Kiernan
> > wrote:
>
> >
On Tue, May 1, 2018 at 10:46 PM Jocelyn Bohr wrote:
>
>
> On Tue, May 1, 2018 at 1:21 AM Alex Kiernan
> wrote:
>
>> On Tue, May 1, 2018 at 8:22 AM Alex Kiernan
>> wrote:
>>
>>
>> > On Tue, May 1, 2018 at 7:50 AM Jocelyn Bohr wrote:
>>
>
Hi Alex,
I think this approach looks really good so far, and will make maintaining
both
implementations easier going forward. I haven't looked at every change here
yet, but when going through the patches should I add a "Reviewed-by:" line
if
the change looks good to me?
Thanks,
Jocelyn
On Mon, A
t; Signed-off-by: Alex Kiernan
>
> Acked-by: Joe Hershberger
>
Reviewed-by: Jocelyn Bohr
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
>
> Acked-by: Joe Hershberger
>
Reviewed-by: Jocelyn Bohr
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
t; > the USB fastboot behaviour.
>
> Good, I was considering recommending this approach.
>
> Acked-by: Joe Hershberger
Agreed, this is really the correct behavior of continue.
Reviewed-by: Jocelyn Bohr
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
ned-off-by: Alex Kiernan
>
> Acked-by: Joe Hershberger
>
Reviewed-by: Jocelyn Bohr
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
allows the UDP implementation to remain the same. If after
> > running 'fastbootcmd' the board has not booted, control is returned
> > to U-Boot and the fastboot process ends.
> >
> > Signed-off-by: Alex Kiernan
>
> Nit below...
>
> Acked-by: Joe H
On Mon, Apr 30, 2018 at 1:33 AM Alex Kiernan wrote:
> Add NAND support to fastboot UDP flash/erase commands
>
> Signed-off-by: Alex Kiernan
> ---
>
> Changes in v2: None
>
> net/fastboot.c | 17 ++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/net/fastboot.c
On Thu, May 3, 2018 at 2:26 PM Joe Hershberger
wrote:
> On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan
> wrote:
> > If we don't have a partition name passed, report it as not found.
> >
> > Signed-off-by: Alex Kiernan
>
> Acked-by: Joe Hershb
On Thu, May 3, 2018 at 2:27 PM Joe Hershberger
wrote:
> On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan
> wrote:
> > Add newlines so we format our output correctly.
> >
> > Signed-off-by: Alex Kiernan
>
> Acked-by: Joe Hershberger
On Wed, May 2, 2018 at 1:14 AM Alex Kiernan wrote:
> On Wed, May 2, 2018 at 7:34 AM Jocelyn Bohr wrote:
>
> > Hi Alex,
>
> > I think this approach looks really good so far, and will make maintaining
> both
> > implementations easier going forward. I haven't lo
On Tue, May 8, 2018 at 2:09 AM Alex Kiernan wrote:
> On Tue, May 8, 2018 at 8:20 AM Joe Hershberger
> wrote:
>
> > On Tue, May 8, 2018 at 1:53 AM, Jocelyn Bohr wrote:
> > > On Mon, Apr 30, 2018 at 1:33 AM Alex Kiernan
> wrote:
> > >
> > >> Add N
On Thu, May 3, 2018 at 2:24 PM Joe Hershberger
wrote:
> On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan
> wrote:
> > Add NAND support to fastboot UDP flash/erase commands
> >
> > Signed-off-by: Alex Kiernan
>
> Acked-by: Joe Hershberger
18 matches
Mail list logo
