Re: [U-Boot] [PATCH v2] patman: Use the Change-Id, version, and prefix in the Message-Id

2019-10-11 Thread Johannes Berg
Doug, > > --- save as .git/hooks/sendemail-validate --- > > #!/bin/sh > > > > set -e > > > > changeid=$(sed 's/^Change-Id: \(I.*\)$/\1/;t;d' $1) > > date=$(date +%s) > > sed 's/^Change-Id: I.*$//;T;d' -i $1 > > sed "s/^From: /Message-Id: <$date-$changeid@changeid>\nFrom: /" -i $1 > > #--- end

Re: [U-Boot] [PATCH v2] patman: Use the Change-Id, version, and prefix in the Message-Id

2019-09-16 Thread Johannes Berg
Hi Doug, > > Actually, the important part for me is to be to be able to have change- > > ids locally (e.g. for working with gerrit), and not have that leak out > > to the community (that doesn't like them). > > > > As a maintainer in the community, I'll also need to change the > >

Re: [U-Boot] [PATCH v2] patman: Use the Change-Id, version, and prefix in the Message-Id

2019-09-05 Thread Johannes Berg
On Thu, 2019-09-05 at 21:48 +0200, Johannes Berg wrote: > > As a maintainer in the community, I'll also need to change the > .git/hooks/commit-msg script that comes with gerrit to not add a Change- > Id if the commit comes with a Link: tag already, but that should be > easy.

Re: [U-Boot] [PATCH v2] patman: Use the Change-Id, version, and prefix in the Message-Id

2019-09-05 Thread Johannes Berg
On Tue, 2019-09-03 at 13:15 -0700, Douglas Anderson wrote: > > Let's give that a try. > > In theory (if there is enough adoption) this could help a tool more > reliably find various versions of a commit. It's not quite as good as this (yet), but a very simple version of it for git-send-email

Re: [U-Boot] [RFC PATCH] patman: Use the Change-Id, version, and prefix in the Message-Id

2019-08-29 Thread Johannes Berg
Hi Doug, Some comments on the actual mechanics here (vs. on the kernel list I picked this up from). It seems like perhaps you could increase the "count" variable. You got: 20190828132723.0.RFC.Ie6289f437ae533d7fcaddfcee9202f0e92c6b2b9@changeid but usually patches are numbered starting from 1,