Re: [U-Boot] [U-Boot,v5,09/11] S3C24XX: Add NAND Flash driver

2013-11-14 Thread José Miguel Gonçalves
01:56, Scott Wood wrote: On Fri, Sep 21, 2012 at 07:47:46PM +0100, José Miguel Gonçalves wrote: NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - U

Re: [U-Boot] About patch "S3C24XX: Add support to MINI2416 board"

2013-09-25 Thread José Miguel Gonçalves
On 25-09-2013 10:30, Minkyu Kang wrote: On 25/09/13 18:18, José Miguel Gonçalves wrote: Hi Minkyu, On 25-09-2013 09:55, Minkyu Kang wrote: Hello, On 25/09/13 17:06, José Miguel Gonçalves wrote: On 21-09-2013 16:56, Marek Vasut wrote: Hi, Precisely one year after my patch submission to add

Re: [U-Boot] About patch "S3C24XX: Add support to MINI2416 board"

2013-09-25 Thread José Miguel Gonçalves
Hi Minkyu, On 25-09-2013 09:55, Minkyu Kang wrote: Hello, On 25/09/13 17:06, José Miguel Gonçalves wrote: On 21-09-2013 16:56, Marek Vasut wrote: Hi, Precisely one year after my patch submission to add support to the MINI2416 board, seems a good time to ask this question, is there any good

Re: [U-Boot] About patch "S3C24XX: Add support to MINI2416 board"

2013-09-25 Thread José Miguel Gonçalves
On 21-09-2013 16:56, Marek Vasut wrote: Hi, Precisely one year after my patch submission to add support to the MINI2416 board, seems a good time to ask this question, is there any good reason for not integrating this patch on the u-boot mainline? http://lists.denx.de/pipermail/u-boot/2012-Sep

Re: [U-Boot] s3c2416 usb ohci issue

2013-09-24 Thread José Miguel Gonçalves
Hi Zoltan, Did not try this myself on the MINI2416 board, so I can not give you any hints on that. But I'm curious, why do you need u-boot's OHCI support for that board? Best regards, José Gonçalves ___ U-Boot mailing list U-Boot@lists.denx.de http:/

Re: [U-Boot] Does u-boot support S3C24xx nand ecc?

2013-09-24 Thread José Miguel Gonçalves
I've added this support for an S3C2416 based board over 2012.10 u-boot sources. Please check this patch at: http://patchwork.ozlabs.org/patch/185885/ José Gonçalves ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-b

[U-Boot] About patch "S3C24XX: Add support to MINI2416 board"

2013-09-21 Thread José Miguel Gonçalves
Hi, Precisely one year after my patch submission to add support to the MINI2416 board, seems a good time to ask this question, is there any good reason for not integrating this patch on the u-boot mainline? http://lists.denx.de/pipermail/u-boot/2012-September/134779.html Best regards, José G

Re: [U-Boot] [PATCH v5 00/11] S3C24XX: Add support to MINI2416 board

2012-11-27 Thread José Miguel Gonçalves
Hi, Can you tell me if this patch series is going to be included on next u-boot release? Do you need anything from my side in order to push this? Best regards, José Gonçalves On 21-09-2012 19:47, José Miguel Gonçalves wrote: Support for the MINI2416 board based on a Samsung's S3C241

[U-Boot] [PATCH v5 09/11] S3C24XX: Add NAND Flash driver

2012-09-21 Thread José Miguel Gonçalves
NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of clrsetbits_le32() - Use of register bit macros instead of magic numbers Changes for v3: - Removed

[U-Boot] [PATCH v5 06/11] rtc: Improve rtc_get() on s3c24x0_rtc

2012-09-21 Thread José Miguel Gonçalves
A better approach to avoid reading the RTC during updates, as sugested in the S3C2416 User's Manual. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - Removed unneeded parenthesis Changes for v4: - None Changes for v5: - None --- driver

[U-Boot] [PATCH v5 10/11] Add u-boot-with-spl.bin target to the Makefile

2012-09-21 Thread José Miguel Gonçalves
Samsung's S3C24XX SoCs need this in order to generate a binary image with a padded SPL concatenated with U-Boot. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - None Changes for v3: - Changed new binary target name from u-boot-ubl.bin to u-boot-pad.bin Changes f

[U-Boot] [PATCH v5 00/11] S3C24XX: Add support to MINI2416 board

2012-09-21 Thread José Miguel Gonçalves
in the NAND Flash driver - Coding style cleanup - Removal of #define CONFIG_SYS_BAUDRATE_TABLE as this in the defaults now - Checkpatch clean with the exceptions indicated in the v3 changes José Miguel Gonçalves (11): Add configuration option to select printf() inclusion on SPL S3C24XX: Add c

[U-Boot] [PATCH v5 03/11] serial: Add support to 4 ports in serial_s3c24x0

2012-09-21 Thread José Miguel Gonçalves
S3C2416 and S3C2450 have 4 UARTs insted of 3 found on older chips. This patch adds support to the additional UART port and changes the mapping between CONFIG_SERIAL? and S3C24X0_UART? in order they have a direct correspondence. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New

[U-Boot] [PATCH v5 11/11] S3C24XX: Add support to MINI2416 board

2012-09-21 Thread José Miguel Gonçalves
inese providers that can supply it with a selectable NAND chip from 128MB to 1GB. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of Use of clrbits_le32(), setbits_le32() and clrsetbits_le32() - Use of register bit macros instead of magic numbers - Use of s

[U-Boot] [PATCH v5 08/11] rtc: Don't allow setting unsuported years on s3c24x0_rtc

2012-09-21 Thread José Miguel Gonçalves
This RTC only supports a 100 years range so rtc_set() should not allow setting years bellow 1970 or above 2069. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - None Changes for v4: - None Changes for v5: - None --- drivers/rtc/s3c24x0_rtc.c

[U-Boot] [PATCH v5 05/11] serial: Remove unnecessary delay in serial_s3c24x0

2012-09-21 Thread José Miguel Gonçalves
The loop used to make a delay after baudrate setting is not necessary. Moreover it is removed by the GCC optimizer (at least with GCC 4.6). Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - None Changes for v4: - None Changes for v5: - None

[U-Boot] [PATCH v5 01/11] Add configuration option to select printf() inclusion on SPL

2012-09-21 Thread José Miguel Gonçalves
The printf() implementation needs 4~5KB of storage space which may not be available when building an SPL for SoCs with scarce internal RAM (8KB or less). This patch adds a new option, CONFIG_SPL_PRINTF_SUPPORT, to deal with this. Signed-off-by: José Miguel Gonçalves --- Changes for v3: - New

[U-Boot] [PATCH v5 07/11] rtc: Fix rtc_reset() on s3c24x0_rtc

2012-09-21 Thread José Miguel Gonçalves
rtc_reset() must set the RTC date to the UNIX Epoch. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - None Changes for v4: - None Changes for v5: - None --- drivers/rtc/s3c24x0_rtc.c | 15 +++ 1 file changed, 11 insertions(+), 4

[U-Boot] [PATCH v5 04/11] serial: Use a more precise baud rate generation for serial_s3c24x0

2012-09-21 Thread José Miguel Gonçalves
The values stored in the baud rate divisor register (UBRDIVn) and dividing slot register (UDIVSLOTn), are used to determine the serial baudrate. Previously only UBRDIVn was set. This patch initializes also UDIVSLOTn which allows to obtain a more precise baudrate. Signed-off-by: José Miguel

Re: [U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile

2012-09-21 Thread José Miguel Gonçalves
On 21-09-2012 17:13, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/21/12 08:52, Wolfgang Denk wrote: Dear José Miguel Gonçalves, In message <505c21bb.7000...@inov.pt> you wrote: It is very important to me that we do NOT include any architectures, SoCs, or board s

Re: [U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile

2012-09-21 Thread José Miguel Gonçalves
Hi Wolfgang, On 09/21/2012 06:43 AM, Wolfgang Denk wrote: Dear Tom, In message <5fbf8e85ca34454794f0f7ecba79798f379f6fd...@hqmail04.nvidia.com> you wrote: If you flash u-boot-dtb-tegra.bin, you'll get a fully functioning U-Boot. There's an intermediate file (u-boot-dtb.bin) that I assume is u

Re: [U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile

2012-09-20 Thread José Miguel Gonçalves
On 20-09-2012 19:09, Scott Wood wrote: On 09/20/2012 11:01:42 AM, Tom Warren wrote: > -Original Message- > From: Tom Rini [mailto:tr...@ti.com] > Sent: Wednesday, September 19, 2012 6:29 PM > To: José Miguel Gonçalves > Cc: Scott Wood; u-boot@lists.denx.de; ma...

Re: [U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile

2012-09-19 Thread José Miguel Gonçalves
6 AM, José Miguel Gonçalves wrote: Samsung's S3C24XX SoCs need this in order to generate a binary image with a padded SPL concatenated with U-Boot. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - None Changes for v3: - Changed new binary target name from u-boot-ubl.bin to u-boo

Re: [U-Boot] [PATCH v4 11/11] S3C24XX: Add support to MINI2416 board

2012-09-19 Thread José Miguel Gonçalves
On 09/19/2012 08:18 PM, Tom Rini wrote: On Wed, Sep 19, 2012 at 12:25:27PM +0100, Jos?? Miguel Gon??alves wrote: The MINI2416 board is based on a Samsung's S3C2416 SoC and has 64MB DDR2 SDRAM, 256MB NAND Flash, a LAN9220 Ethernet Controller and a WM8731 Audio CODEC. This U-Boot port was implemen

Re: [U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile

2012-09-19 Thread José Miguel Gonçalves
On 19-09-2012 19:19, Tom Rini wrote: On Wed, Sep 19, 2012 at 11:11:08AM -0600, Stephen Warren wrote: On 09/19/2012 10:58 AM, Jos? Miguel Gon?alves wrote: On 19-09-2012 17:10, Scott Wood wrote: On 09/19/2012 06:25:26 AM, Jos? Miguel Gon?alves wrote: Samsung's S3C24XX SoCs need this in order to

Re: [U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile

2012-09-19 Thread José Miguel Gonçalves
On 19-09-2012 18:08, Scott Wood wrote: On 09/19/2012 11:58:06 AM, José Miguel Gonçalves wrote: On 19-09-2012 17:10, Scott Wood wrote: On 09/19/2012 06:25:26 AM, José Miguel Gonçalves wrote: Samsung's S3C24XX SoCs need this in order to generate a binary image with a padded SPL concate

Re: [U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile

2012-09-19 Thread José Miguel Gonçalves
On 19-09-2012 17:10, Scott Wood wrote: On 09/19/2012 06:25:26 AM, José Miguel Gonçalves wrote: Samsung's S3C24XX SoCs need this in order to generate a binary image with a padded SPL concatenated with U-Boot. I still think "pad" is a lousy name for this. It refers to a minor

Re: [U-Boot] [PATCH v4 09/11] S3C24XX: Add NAND Flash driver

2012-09-19 Thread José Miguel Gonçalves
On 19-09-2012 17:19, Scott Wood wrote: On 09/19/2012 06:25:25 AM, José Miguel Gonçalves wrote: NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of

[U-Boot] [PATCH v4 00/11] S3C24XX: Add support to MINI2416 board

2012-09-19 Thread José Miguel Gonçalves
: WARNING: please, no spaces at the start of a line #1716: FILE: include/common.h:631: +defined(CONFIG_S3C24XX) || \$ Changes for v4: - NAND Flash driver cleanup and optimization José Miguel Gonçalves (11): Add configuration option to select printf() inclusion o

[U-Boot] [PATCH v4 09/11] S3C24XX: Add NAND Flash driver

2012-09-19 Thread José Miguel Gonçalves
NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of clrsetbits_le32() - Use of register bit macros instead of magic numbers Changes for v3: - Removed

[U-Boot] [PATCH v4 03/11] serial: Add support to 4 ports in serial_s3c24x0

2012-09-19 Thread José Miguel Gonçalves
S3C2416 and S3C2450 have 4 UARTs insted of 3 found on older chips. This patch adds support to the additional UART port and changes the mapping between CONFIG_SERIAL? and S3C24X0_UART? in order they have a direct correspondence. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New

[U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile

2012-09-19 Thread José Miguel Gonçalves
Samsung's S3C24XX SoCs need this in order to generate a binary image with a padded SPL concatenated with U-Boot. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - None Changes for v3: - Changed new binary target name from u-boot-ubl.bin to u-boot-pad.bin Changes f

[U-Boot] [PATCH v4 08/11] rtc: Don't allow setting unsuported years on s3c24x0_rtc

2012-09-19 Thread José Miguel Gonçalves
This RTC only supports a 100 years range so rtc_set() should not allow setting years bellow 1970 or above 2069. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - None Changes for v4: - None --- drivers/rtc/s3c24x0_rtc.c |5 + 1 file

[U-Boot] [PATCH v4 04/11] serial: Use a more precise baud rate generation for serial_s3c24x0

2012-09-19 Thread José Miguel Gonçalves
The values stored in the baud rate divisor register (UBRDIVn) and dividing slot register (UDIVSLOTn), are used to determine the serial baudrate. Previously only UBRDIVn was set. This patch initializes also UDIVSLOTn which allows to obtain a more precise baudrate. Signed-off-by: José Miguel

[U-Boot] [PATCH v4 01/11] Add configuration option to select printf() inclusion on SPL

2012-09-19 Thread José Miguel Gonçalves
The printf() implementation needs 4~5KB of storage space which may not be available when building an SPL for SoCs with scarce internal RAM (8KB or less). This patch adds a new option, CONFIG_SPL_PRINTF_SUPPORT, to deal with this. Signed-off-by: José Miguel Gonçalves --- Changes for v3: - New

[U-Boot] [PATCH v4 06/11] rtc: Improve rtc_get() on s3c24x0_rtc

2012-09-19 Thread José Miguel Gonçalves
A better approach to avoid reading the RTC during updates, as sugested in the S3C2416 User's Manual. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - Removed unneeded parenthesis Changes for v4: - None --- drivers/rtc/s3c24x0_rtc.c |

[U-Boot] [PATCH v4 07/11] rtc: Fix rtc_reset() on s3c24x0_rtc

2012-09-19 Thread José Miguel Gonçalves
rtc_reset() must set the RTC date to the UNIX Epoch. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - None Changes for v4: - None --- drivers/rtc/s3c24x0_rtc.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a

[U-Boot] [PATCH v4 11/11] S3C24XX: Add support to MINI2416 board

2012-09-19 Thread José Miguel Gonçalves
inese providers that can supply it with a selectable NAND chip from 128MB to 1GB. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of Use of clrbits_le32(), setbits_le32() and clrsetbits_le32() - Use of register bit macros instead of magic numbers - Use of s

[U-Boot] [PATCH v4 05/11] serial: Remove unnecessary delay in serial_s3c24x0

2012-09-19 Thread José Miguel Gonçalves
The loop used to make a delay after baudrate setting is not necessary. Moreover it is removed by the GCC optimizer (at least with GCC 4.6). Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - None Changes for v4: - None --- drivers/serial

Re: [U-Boot] [PATCH v3 09/11] S3C24XX: Add NAND Flash driver

2012-09-18 Thread José Miguel Gonçalves
On 18-09-2012 19:30, Scott Wood wrote: On 09/18/2012 01:22:58 PM, José Miguel Gonçalves wrote: On 18-09-2012 19:02, Scott Wood wrote: On 09/18/2012 12:40:36 PM, José Miguel Gonçalves wrote: +#define TACLS_VAL7/* CLE & ALE duration setting (0~7) */ +#defineTWRPH0_VAL

Re: [U-Boot] [PATCH v3 09/11] S3C24XX: Add NAND Flash driver

2012-09-18 Thread José Miguel Gonçalves
On 18-09-2012 19:02, Scott Wood wrote: On 09/18/2012 12:40:36 PM, José Miguel Gonçalves wrote: NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of

[U-Boot] [PATCH v3 11/11] S3C24XX: Add support to MINI2416 board

2012-09-18 Thread José Miguel Gonçalves
inese providers that can supply it with a selectable NAND chip from 128MB to 1GB. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of Use of clrbits_le32(), setbits_le32() and clrsetbits_le32() - Use of register bit macros instead of magic numbers - Use of s

[U-Boot] [PATCH v3 09/11] S3C24XX: Add NAND Flash driver

2012-09-18 Thread José Miguel Gonçalves
NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of clrsetbits_le32() - Use of register bit macros instead of magic numbers Changes for v3: - Removed

[U-Boot] [PATCH v3 10/11] Add u-boot-pad.bin target to the Makefile

2012-09-18 Thread José Miguel Gonçalves
Samsung's S3C24XX SoCs need this in order to generate a binary image with a padded SPL concatenated with U-Boot. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - None Changes for v3: - Changed new binary target name from u-boot-ubl.bin to u-boot-pad.bin --- Makefile |

[U-Boot] [PATCH v3 03/11] serial: Add support to 4 ports in serial_s3c24x0

2012-09-18 Thread José Miguel Gonçalves
S3C2416 and S3C2450 have 4 UARTs insted of 3 found on older chips. This patch adds support to the additional UART port and changes the mapping between CONFIG_SERIAL? and S3C24X0_UART? in order they have a direct correspondence. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New

[U-Boot] [PATCH v3 06/11] rtc: Improve rtc_get() on s3c24x0_rtc

2012-09-18 Thread José Miguel Gonçalves
A better approach to avoid reading the RTC during updates, as sugested in the S3C2416 User's Manual. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - Removed unneeded parenthesis --- drivers/rtc/s3c24x0_rtc.c | 10 -- 1 file chang

[U-Boot] [PATCH v3 08/11] rtc: Don't allow setting unsuported years on s3c24x0_rtc

2012-09-18 Thread José Miguel Gonçalves
This RTC only supports a 100 years range so rtc_set() should not allow setting years bellow 1970 or above 2069. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - None --- drivers/rtc/s3c24x0_rtc.c |5 + 1 file changed, 5 insertions(+) diff

[U-Boot] [PATCH v3 00/11] S3C24XX: Add support to MINI2416 board

2012-09-18 Thread José Miguel Gonçalves
: WARNING: please, no spaces at the start of a line #1716: FILE: include/common.h:631: +defined(CONFIG_S3C24XX) || \$ José Miguel Gonçalves (11): Add configuration option to select printf() inclusion on SPL S3C24XX: Add core support for Samsung's S3C24XX SoCs

[U-Boot] [PATCH v3 04/11] serial: Use a more precise baud rate generation for serial_s3c24x0

2012-09-18 Thread José Miguel Gonçalves
The values stored in the baud rate divisor register (UBRDIVn) and dividing slot register (UDIVSLOTn), are used to determine the serial baudrate. Previously only UBRDIVn was set. This patch initializes also UDIVSLOTn which allows to obtain a more precise baudrate. Signed-off-by: José Miguel

[U-Boot] [PATCH v3 07/11] rtc: Fix rtc_reset() on s3c24x0_rtc

2012-09-18 Thread José Miguel Gonçalves
rtc_reset() must set the RTC date to the UNIX Epoch. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - None --- drivers/rtc/s3c24x0_rtc.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/s3c24x0_rtc.c

[U-Boot] [PATCH v3 05/11] serial: Remove unnecessary delay in serial_s3c24x0

2012-09-18 Thread José Miguel Gonçalves
The loop used to make a delay after baudrate setting is not necessary. Moreover it is removed by the GCC optimizer (at least with GCC 4.6). Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch Changes for v3: - None --- drivers/serial/serial_s3c24x0.c |3 --- 1 file

[U-Boot] [PATCH v3 01/11] Add configuration option to select printf() inclusion on SPL

2012-09-18 Thread José Miguel Gonçalves
The printf() implementation needs 4~5KB of storage space which may not be available when building an SPL for SoCs with scarce internal RAM (8KB or less). This patch adds a new option, CONFIG_SPL_PRINTF_SUPPORT, to deal with this. Signed-off-by: José Miguel Gonçalves --- Changes for v3: - new

Re: [U-Boot] [PATCH v2 11/11] S3C24XX: Add support to MINI2416 board

2012-09-18 Thread José Miguel Gonçalves
Hi Tom, On 17-09-2012 16:11, Tom Rini wrote: On Mon, Sep 17, 2012 at 03:47:46PM +0100, Jos? Miguel Gon?alves wrote: On 17-09-2012 15:39, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:11:07AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 07:58 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 06:2

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
On 17-09-2012 19:27, Tom Rini wrote: On Mon, Sep 17, 2012 at 07:05:48PM +0100, Jos? Miguel Gon?alves wrote: On 17-09-2012 18:56, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 10:08, Jos? Miguel Gon?alves wrote: On 17-09-2012 17:57, Tom Rini wrote: On Sun, Sep 16,

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
On 17-09-2012 18:56, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 10:08, José Miguel Gonçalves wrote: On 17-09-2012 17:57, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep

Re: [U-Boot] [PATCH v2 01/11] ARM: fix relocation on ARM926EJS

2012-09-17 Thread José Miguel Gonçalves
On 17-09-2012 18:18, Tom Rini wrote: On Sun, Sep 16, 2012 at 05:36:47PM +0200, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, On 09/16/2012 11:06 AM, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, On 09/15/2012 07:03 PM, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, Jumping to board_ini

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
On 17-09-2012 17:57, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: On 14-09-2012 19:21, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, NAND

Re: [U-Boot] [PATCH v2 11/11] S3C24XX: Add support to MINI2416 board

2012-09-17 Thread José Miguel Gonçalves
On 17-09-2012 15:39, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:11:07AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 07:58 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 06:29:02PM +0100, Jos?? Miguel Gon??alves wrote: The MINI2416 board is based on a Samsung's S3C2416 SoC and has 64MB DDR2

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
Hi Marek, On 14-09-2012 19:21, Marek Vasut wrote: Dear José Miguel Gonçalves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves [...] +#include +#include +#include +#include +#include + +#define

Re: [U-Boot] [PATCH v2 10/11] Add u-boot-ubl.bin target to the Makefile

2012-09-17 Thread José Miguel Gonçalves
On 09/17/2012 10:10 AM, Christian Riesch wrote: On Mon, Sep 17, 2012 at 10:30 AM, José Miguel Gonçalves wrote: On 09/17/2012 07:47 AM, Christian Riesch wrote: Hi, On Sun, Sep 16, 2012 at 11:27 AM, José Miguel Gonçalves wrote: On 09/14/2012 08:08 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at

Re: [U-Boot] [PATCH v2 01/11] ARM: fix relocation on ARM926EJS

2012-09-17 Thread José Miguel Gonçalves
Hi Christian, On 09/17/2012 10:03 AM, Christian Riesch wrote: Hi, On Mon, Sep 17, 2012 at 10:34 AM, José Miguel Gonçalves wrote: On 09/17/2012 07:28 AM, Christian Riesch wrote: Hi, On Sun, Sep 16, 2012 at 5:36 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, On 09/16/2012 11:06 AM

Re: [U-Boot] [PATCH v2 01/11] ARM: fix relocation on ARM926EJS

2012-09-17 Thread José Miguel Gonçalves
On 09/17/2012 07:28 AM, Christian Riesch wrote: Hi, On Sun, Sep 16, 2012 at 5:36 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, On 09/16/2012 11:06 AM, Marek Vasut wrote: Dear José Miguel Gonçalves, On 09/15/2012 07:03 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, Jumping to

Re: [U-Boot] [PATCH v2 10/11] Add u-boot-ubl.bin target to the Makefile

2012-09-17 Thread José Miguel Gonçalves
On 09/17/2012 07:47 AM, Christian Riesch wrote: Hi, On Sun, Sep 16, 2012 at 11:27 AM, José Miguel Gonçalves wrote: On 09/14/2012 08:08 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 06:29:01PM +0100, Jos?? Miguel Gon??alves wrote: Samsung's S3C24XX SoCs need this in order to generate a b

Re: [U-Boot] [PATCH v2 01/11] ARM: fix relocation on ARM926EJS

2012-09-16 Thread José Miguel Gonçalves
On 09/16/2012 04:36 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, On 09/16/2012 11:06 AM, Marek Vasut wrote: Dear José Miguel Gonçalves, On 09/15/2012 07:03 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, Jumping to board_init_r is not performed due to a bug on address

Re: [U-Boot] [PATCH v2 01/11] ARM: fix relocation on ARM926EJS

2012-09-16 Thread José Miguel Gonçalves
On 09/16/2012 11:06 AM, Marek Vasut wrote: Dear José Miguel Gonçalves, On 09/15/2012 07:03 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, Jumping to board_init_r is not performed due to a bug on address computation. Is your CONFIG_SYS_TEXT_BASE configured correctly? I don't detec

Re: [U-Boot] [PATCH v2 01/11] ARM: fix relocation on ARM926EJS

2012-09-16 Thread José Miguel Gonçalves
On 09/15/2012 07:03 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, Jumping to board_init_r is not performed due to a bug on address computation. Is your CONFIG_SYS_TEXT_BASE configured correctly? I don't detect any misbehavior on my arm926 boards. Maybe because you are not using

Re: [U-Boot] [PATCH v2 10/11] Add u-boot-ubl.bin target to the Makefile

2012-09-16 Thread José Miguel Gonçalves
On 09/14/2012 08:08 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 06:29:01PM +0100, Jos?? Miguel Gon??alves wrote: Samsung's S3C24XX SoCs need this in order to generate a binary image with the SPL and U-Boot concatenated. Signed-off-by: Jos?? Miguel Gon??alves --- Changes for v2: - None ---

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-16 Thread José Miguel Gonçalves
On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: On 14-09-2012 19:21, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: Jos

Re: [U-Boot] [PATCH v2 11/11] S3C24XX: Add support to MINI2416 board

2012-09-16 Thread José Miguel Gonçalves
On 09/14/2012 07:58 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 06:29:02PM +0100, Jos?? Miguel Gon??alves wrote: The MINI2416 board is based on a Samsung's S3C2416 SoC and has 64MB DDR2 SDRAM, 256MB NAND Flash, a LAN9220 Ethernet Controller and a WM8731 Audio CODEC. This U-Boot port was impleme

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread José Miguel Gonçalves
On 14-09-2012 19:21, Marek Vasut wrote: Dear José Miguel Gonçalves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves [...] +#include +#include +#include +#include +#include + +#define MAX_CHIPS 2

[U-Boot] [PATCH v2 11/11] S3C24XX: Add support to MINI2416 board

2012-09-14 Thread José Miguel Gonçalves
inese providers that can supply it with a selectable NAND chip from 128MB to 1GB. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of Use of clrbits_le32(), setbits_le32() and clrsetbits_le32() - Use of register bit macros instead of magic numbers - Use of s

[U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread José Miguel Gonçalves
NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of clrsetbits_le32() - Use of register bit macros instead of magic numbers --- drivers/mtd/nand/Makefile

[U-Boot] [PATCH v2 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs

2012-09-14 Thread José Miguel Gonçalves
This patch adds the support for Samsung's S3C24XX SoCs that have an ARM926EJS core. Currently it supports S3C2412, S3C2413, S3C2416 and S3C2450. Tested on an S3C2416 platform. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Added register bit macros to avoid magic nu

[U-Boot] [PATCH v2 10/11] Add u-boot-ubl.bin target to the Makefile

2012-09-14 Thread José Miguel Gonçalves
Samsung's S3C24XX SoCs need this in order to generate a binary image with the SPL and U-Boot concatenated. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - None --- Makefile |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile

[U-Boot] [PATCH v2 03/11] serial: Add support to 4 ports in serial_s3c24x0

2012-09-14 Thread José Miguel Gonçalves
S3C2416 and S3C2450 have 4 UARTs insted of 3 found on older chips. This patch adds support to the additional UART port and changes the mapping between CONFIG_SERIAL? and S3C24X0_UART? in order they have a direct correspondence. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New

[U-Boot] [PATCH v2 08/11] rtc: Don't allow setting unsuported years on s3c24x0_rtc

2012-09-14 Thread José Miguel Gonçalves
This RTC only supports a 100 years range so rtc_set() should not allow setting years bellow 1970 or above 2069. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch --- drivers/rtc/s3c24x0_rtc.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/rtc

[U-Boot] [PATCH v2 04/11] serial: Use a more precise baud rate generation for serial_s3c24x0

2012-09-14 Thread José Miguel Gonçalves
Program udivslot register in order to obtain a more precise baudrate. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch --- drivers/serial/serial_s3c24x0.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/serial

[U-Boot] [PATCH v2 00/11] S3C24XX: Add support to MINI2416 board

2012-09-14 Thread José Miguel Gonçalves
Support for the MINI2416 board based on a Samsung's S3C2416 SoC with 64MB DDR2 SDRAM, 256MB NAND Flash, a LAN9220 Ethernet Controller and a WM8731 Audio CODEC. Changes for v2: - Coding style cleanup - Removed new serial and rtc drivers - Use of in-tree serial and rtc drivers José M

[U-Boot] [PATCH v2 07/11] rtc: Fix rtc_reset() on s3c24x0_rtc

2012-09-14 Thread José Miguel Gonçalves
rtc_reset() must set the RTC date to the UNIX Epoch. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch --- drivers/rtc/s3c24x0_rtc.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/s3c24x0_rtc.c b/drivers/rtc/s3c24x0_rtc.c

[U-Boot] [PATCH v2 05/11] serial: Remove unnecessary delay in serial_s3c24x0

2012-09-14 Thread José Miguel Gonçalves
The loop used to make a delay after baudrate setting is not necessary. Moreover it is removed by the GCC optimizer (at least with GCC 4.6). Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch --- drivers/serial/serial_s3c24x0.c |3 --- 1 file changed, 3 deletions

[U-Boot] [PATCH v2 06/11] rtc: Improve rtc_get() on s3c24x0_rtc

2012-09-14 Thread José Miguel Gonçalves
A better approach to avoid reading the RTC during updates, as sugested in the S3C2416 User's Manual. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - New patch --- drivers/rtc/s3c24x0_rtc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/driver

[U-Boot] [PATCH v2 01/11] ARM: fix relocation on ARM926EJS

2012-09-14 Thread José Miguel Gonçalves
Jumping to board_init_r is not performed due to a bug on address computation. Relocation offsets are not needed when building SPL. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - None --- arch/arm/cpu/arm926ejs/start.S |4 +++- 1 file changed, 3 insertions(+), 1 deletion

Re: [U-Boot] [PATCH 3/7] S3C24XX: Add serial driver

2012-09-13 Thread José Miguel Gonçalves
Hi Marek, On 09/13/2012 10:17 AM, Marek Vasut wrote: Dear José Miguel Gonçalves, Hi Marek, On 09/12/2012 10:01 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, Serial driver for the S3C24XX SoCs. Signed-off-by: José Miguel Gonçalves --- drivers/serial/Makefile |1

Re: [U-Boot] [PATCH 3/7] S3C24XX: Add serial driver

2012-09-12 Thread José Miguel Gonçalves
Hi Marek, On 09/12/2012 10:01 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, Serial driver for the S3C24XX SoCs. Signed-off-by: José Miguel Gonçalves --- drivers/serial/Makefile |1 + drivers/serial/s3c24xx_serial.c | 146 +++ 2 files

Re: [U-Boot] [PATCH 5/7] S3C24XX: Add NAND Flash driver

2012-09-12 Thread José Miguel Gonçalves
On 09/13/2012 01:24 AM, Marek Vasut wrote: Dear José Miguel Gonçalves, Hi Scott, On 09/13/2012 12:20 AM, Scott Wood wrote: On 09/12/2012 06:16 PM, José Miguel Gonçalves wrote: Hi Marek, On 09/12/2012 10:11 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, + +/* + * Hardware specific

Re: [U-Boot] [PATCH 5/7] S3C24XX: Add NAND Flash driver

2012-09-12 Thread José Miguel Gonçalves
Hi Scott, On 09/13/2012 12:20 AM, Scott Wood wrote: On 09/12/2012 06:16 PM, José Miguel Gonçalves wrote: Hi Marek, On 09/12/2012 10:11 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, + +/* + * Hardware specific access to control-lines function + */ +static void s3c_nand_hwcontrol(struct

Re: [U-Boot] [PATCH 5/7] S3C24XX: Add NAND Flash driver

2012-09-12 Thread José Miguel Gonçalves
On 09/13/2012 12:45 AM, Marek Vasut wrote: Dear José Miguel Gonçalves, Hi Marek, On 09/12/2012 10:11 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, + +/* + * Hardware specific access to control-lines function + */ +static void s3c_nand_hwcontrol(struct mtd_info *mtd, int cmd, unsigned

Re: [U-Boot] [PATCH 4/7] S3C24XX: Add RTC driver

2012-09-12 Thread José Miguel Gonçalves
Hi Marek, On 09/12/2012 10:03 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, +static inline void rtc_access_disable(void) +{ + s3c24xx_rtc *const rtc = s3c24xx_get_base_rtc(); + uchar rtccon; + + rtccon = readb(&rtc->rtccon); + rtccon &= ~0x01; Magic n

Re: [U-Boot] [PATCH 5/7] S3C24XX: Add NAND Flash driver

2012-09-12 Thread José Miguel Gonçalves
Hi Marek, On 09/12/2012 10:11 PM, Marek Vasut wrote: Dear José Miguel Gonçalves, + +/* + * Hardware specific access to control-lines function + */ +static void s3c_nand_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int ctrl) +{ + s3c24xx_nand *const nand = s3c24xx_get_base_nand

[U-Boot] [PATCH 2/7] S3C24XX: Add core support for Samsung's S3C24XX SoCs

2012-09-12 Thread José Miguel Gonçalves
This patch adds the support for Samsung's S3C24XX SoCs that have an ARM926EJS core. Currently it supports S3C2412, S3C2413, S3C2416 and S3C2450. Tested on an S3C2416 platform. Signed-off-by: José Miguel Gonçalves --- arch/arm/cpu/arm926ejs/s3c24xx/Makefile | 52 +++ arch/ar

[U-Boot] [PATCH 0/7] Add support to MINI2416 board

2012-09-12 Thread José Miguel Gonçalves
Support for the MINI2416 board based on a Samsung's S3C2416 SoC with 64MB DDR2 SDRAM, 256MB NAND Flash, a LAN9220 Ethernet Controller and a WM8731 Audio CODEC. José Miguel Gonçalves (7): ARM: fix relocation on ARM926EJS S3C24XX: Add core support for Samsung's S3C24XX SoCs S3

[U-Boot] [PATCH 7/7] S3C24XX: Add support to MINI2416 board

2012-09-12 Thread José Miguel Gonçalves
inese providers that can supply it with a selectable NAND chip from 128MB to 1GB. Signed-off-by: José Miguel Gonçalves --- MAINTAINERS|4 + board/boardcon/mini2416/Makefile | 47 +++ board/boardcon/mini2416/config.mk |4 + board/boardcon/mini2416/mini2

[U-Boot] [PATCH 5/7] S3C24XX: Add NAND Flash driver

2012-09-12 Thread José Miguel Gonçalves
NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves --- drivers/mtd/nand/Makefile |1 + drivers/mtd/nand/s3c24xx_nand.c | 269 +++ 2 files changed, 270 insertions

[U-Boot] [PATCH 3/7] S3C24XX: Add serial driver

2012-09-12 Thread José Miguel Gonçalves
Serial driver for the S3C24XX SoCs. Signed-off-by: José Miguel Gonçalves --- drivers/serial/Makefile |1 + drivers/serial/s3c24xx_serial.c | 146 +++ 2 files changed, 147 insertions(+) create mode 100644 drivers/serial/s3c24xx_serial.c diff

[U-Boot] [PATCH 1/7] ARM: fix relocation on ARM926EJS

2012-09-12 Thread José Miguel Gonçalves
Jumping to board_init_r is not performed due to a bug on address computation. Relocation offsets are not needed when building SPL. Signed-off-by: José Miguel Gonçalves --- arch/arm/cpu/arm926ejs/start.S |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/cpu

[U-Boot] [PATCH 6/7] Add u-boot-ubl.bin target to the Makefile

2012-09-12 Thread José Miguel Gonçalves
Samsung's S3C24XX SoCs need this in order to generate a binary image with the SPL and U-Boot concatenated. Signed-off-by: José Miguel Gonçalves --- Makefile |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 058fb53..595b5f6 100644

[U-Boot] [PATCH 4/7] S3C24XX: Add RTC driver

2012-09-12 Thread José Miguel Gonçalves
RTC driver for the S3C24XX SoCs. Signed-off-by: José Miguel Gonçalves --- drivers/rtc/Makefile |1 + drivers/rtc/s3c24xx_rtc.c | 166 + 2 files changed, 167 insertions(+) create mode 100644 drivers/rtc/s3c24xx_rtc.c diff --git a/drivers

[U-Boot] Memtest end address

2012-08-31 Thread José Miguel Gonçalves
Hi, The end address for memtest set with CONFIG_SYS_MEMTEST_END is supposed to be included or not in the test? Checking on the source code I see that the quick implementation does not include it, but the more extensive implementation enabled with CONFIG_SYS_ALT_MEMTEST does include the end a