Re: [RFC PATCH 2/2] board: ti: am65x: Move to using Extension framework

2023-10-06 Thread Köry Maincent
On Wed, 4 Oct 2023 15:39:23 +0300 Roger Quadros wrote: Hello, Thanks for adding me in cc. Also it seems I forgot to add myself to MAINTAINERS for the extension_board.c file. > >>> Before this goes too far I think this should move to using a linker > >>> list to declare the driver (or a

Re: [PATCH 1/1] cmd: undefined return value of do_extension_apply()

2022-07-19 Thread Köry Maincent
Hello Heinrich, On Mon, 11 Jul 2022 20:01:12 +0200 Heinrich Schuchardt wrote: > If 'extension apply all' is executed and no extension is found, the return > value of do_extension_apply() is undefined. Return CMD_RET_FAILURE in this > case. > > Fixes: 2f84e9cf06d3 ("cmd: add support for a new

Re: [PATCH] usb: kbd: allow probing even if usbkbd not in stdin

2022-06-27 Thread Köry Maincent
On Mon, 27 Jun 2022 13:39:03 +0200 Marek Vasut wrote: > >> Can you document the usecase in a bit more detail ? > > > > My usecase is to get a key press from the USB keyboard and do some thing > > about it in board_init. I do not want to multiplex the keyboard input to > > stdin but I still

Re: [PATCH] usb: kbd: allow probing even if usbkbd not in stdin

2022-06-27 Thread Köry Maincent
Hello Marek, On Fri, 24 Jun 2022 20:12:31 +0200 Marek Vasut wrote: > On 6/22/22 10:59, kory.mainc...@bootlin.com wrote: > > From: Kory Maincent > > > > For now the driver does not probe if usbkbd was not present in stdin. > > This presents two issues, we can not probe the driver before

Re: [PATCH v5 08/10] configs: CHIP: add support for DIP detect functionality

2021-05-17 Thread Köry Maincent
Hello Andre, On Thu, 13 May 2021 12:03:05 +0100 Andre Przywara wrote: > On Tue, 4 May 2021 19:31:28 +0200 > Kory Maincent wrote: > > > This commit enables using the extension board detection mechanism on > > CHIP boards > > > > Signed-off-by: Kory Maincent > > Acked-by: Maxime Ripard >

Re: [PATCH v3 07/10] arm: sunxi: add support for DIP detection to CHIP board

2021-04-15 Thread Köry Maincent
On Thu, 15 Apr 2021 11:32:48 +0200 Maxime Ripard wrote: > Hi, > > On Thu, Apr 15, 2021 at 10:38:43AM +0200, Köry Maincent wrote: > > > > arch/arm/mach-sunxi/Kconfig | 9 > > > > board/sunxi/Makefile| 1 + > >

Re: [PATCH v3 07/10] arm: sunxi: add support for DIP detection to CHIP board

2021-04-15 Thread Köry Maincent
o.o > > +obj-$(CONFIG_CHIP_DIP_SCAN)+= chip.o > > diff --git a/board/sunxi/chip.c b/board/sunxi/chip.c > > new file mode 100644 > > index 00..9be2ede57b > > --- /dev/null > > +++ b/board/sunxi/chip.c > > @@ -0,0 +1,104 @@ > > +// SPDX-Licen

Re: [PATCH v2 10/12] sun5i: add support for DIP detection to CHIP board

2021-03-02 Thread Köry Maincent
i/chip.c > > @@ -0,0 +1,104 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * (C) Copyright 2021 > > + * Köry Maincent, Bootlin, > > + * Based on initial code from Maxime Ripard > > + */ > > + > > +#include > > +#include > >

Re: [PATCH 08/10] sun5i: add support for DIP detection to CHIP board

2021-02-23 Thread Köry Maincent
Hello Andre, On Tue, 23 Feb 2021 13:30:38 + Andre Przywara wrote: y extension_board_scan board specific function, would you prefer if I > > move to callback like below instead of Kconfig? > > > > if (of_machine_is_compatible("nextthing,chip")) > >

Re: [PATCH 08/10] sun5i: add support for DIP detection to CHIP board

2021-02-22 Thread Köry Maincent
Hi Tom, Andre Thanks for your reviews. On Fri, 19 Feb 2021 17:29:26 + Andre Przywara wrote: > > > > And then based on my comment in the previous patch, similar to > > PINEPHONE_DT_SELECTION and other board-specific options, add a > > CHIP_DIP_SCAN option or similar. > > Yes, indeed,

Re: [PATCH v4 10/16] dm: gpio: Add a way to update flags

2021-02-08 Thread Köry Maincent
On Thu, 4 Feb 2021 21:22:03 -0700 Simon Glass wrote: > It is convenient to be able to adjust some of the flags for a GPIO while > leaving others alone. Add a function for this. > > Update dm_gpio_set_dir_flags() to make use of this. > > Also update dm_gpio_set_value() to use this also, since

Re: [PATCH] gpio-uclass: fix gpio flags save condition

2021-02-05 Thread Köry Maincent
Hi Simon, On Thu, 4 Feb 2021 19:45:22 -0700 Simon Glass wrote: > Thank you for that. I think that is because dm_gpio_set_dir_flags() > does not clear the flags first. But we now do actually update > desc->flags, where as before it was just supposed to happen. So I > think this function needs

Re: [PATCH v3] sysboot: add zboot support to boot x86 Linux kernel image

2021-02-02 Thread Köry Maincent
Hi Simon, Thanks for the review. On Mon, 1 Feb 2021 13:44:46 -0700 Simon Glass wrote: > Hi Kory, > > On Mon, 1 Feb 2021 at 08:31, Kory Maincent wrote: > > > > Add "zboot" command to the list of supported boot in the label_boot > > function. > > > > Signed-off-by: Kory Maincent > > --- > > >

Re: [PATCH] gpio-uclass: fix gpio flags save condition

2021-01-25 Thread Köry Maincent
Hello Simon, On Sun, 24 Jan 2021 13:24:14 -0700 Simon Glass wrote: > Hi Kory, > > On Fri, 22 Jan 2021 at 08:23, Kory Maincent wrote: > > > > The commit cd2faeba1a moves the location where we save the flags to the gpio > > descriptor but it adds a "!" character. > > This breaks the condition

Run U-Boot as Legacy Bios payload?

2020-12-14 Thread Köry Maincent
Hello, Does U-Boot can be built and run as a Legacy BIOS payload, like GRUB or SeaBios? Indeed GRUB or SeaBios have a stage 1 binary to be merge in GPT/MBR partition table. I did not find something like that with U-Boot. I do not want to use U-Boot with UEFI, I have already done it. I saw U-boot