Re: [RFC PATCH 02/28] cli: Add LIL shell

2021-07-06 Thread Kostas Michalopoulos
On 7/6/2021 6:43 PM, Tom Rini wrote: I don't know if it's right either. But drawing on my comment just now and above about complex boot scripts, I also don't know if "it's sh but quirky and incomplete, WHY DOESN'T THIS WORK RIGHT" is better than "It's TCL? I don't know that, let me hit stackove

Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL

2021-07-06 Thread Kostas Michalopoulos
On 7/6/2021 6:33 PM, Tom Rini wrote: Mature? And still without consequent error checking? And done, i. e. this will never be fixed? Intentional design by upstream, and then for the actual problem part (error checking, test suite), Sean is saying he'll fix it, and has started on it. To clar

Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

2021-07-02 Thread Kostas Michalopoulos
On 7/2/2021 4:38 PM, Sean Anderson wrote: I have not. I'm not sure what changes I've made are compatible with the vision he has for LIL. He's CC'd on this series, so perhaps he can comment. Yeah, sadly several of the changes i've seen in the code are not backwards compatible and backwards comp