Hi Jaehoon,
If there are no more feedback, I will send out version2 patch soon.
On 11/7/23 14:24, Kuan Lim Lee wrote:
>
> Hi Jaehoon,
>
> On 11/1/23 08:20, Jaehoon Chung wrote:
> > From: Jaehoon Chung Hi
> >
> > On 10/3/23 16:22, Kuan Lim Lee wrote:
> > > From: Kuan Lim Lee
> > >
> > > Cadence
Hi,
May anyone please help to review to this version 2 patch?
Best Regards,
KL Lee
On 11/6/23 13:13, Kuan Lim Lee wrote:
> Subject: [PATCH v2] timer: starfive: Add Starfive timer support
>
> Add timer driver in Starfive SoC. It is an timer that outside of CPU core and
> inside Starfive SoC.
>
Hi Jaehoon,
On 11/1/23 08:20, Jaehoon Chung wrote:
> From: Jaehoon Chung
> Hi
>
> On 10/3/23 16:22, Kuan Lim Lee wrote:
> > From: Kuan Lim Lee
> >
> > Cadence SDMMC v6 controller has a lot of changes on initialize
> > compared to v4 controller. PHY is needed by v6 controller.
> >
> > Signed-off
Hi Anderson,
Thanks for your feedback.
Please ignore this patch.
Best Regards,
KuanLim
On 10/3/23 14:21, Kuan Lim Lee wrote:
> On 10/18/23 13:27, Sean Anderson wrote:
> > On 10/3/23 00:16, Kuan Lim Lee wrote:
> > > When selecting MMCSD_MODE_EMMCBOOT as boot_mode, emmc do not
> > load
> > > U-bo
> > > > + ret = clk_enable(&clk);
> > > > + if (ret)
> > > > + return ret;
> > > > + uc_priv->clock_rate = clk_get_rate(&clk);
> > > > +
> > > > + /* Initiate timer, channel 0 */
> > > > + /* Unmask Interrupt Mask */
> > >
> > > multi-line comment style is:
> > >
> > > /*
> > > * line 1
> > > * line 2
> > > */
> > >
> > Noted.
> > > > + writel(0, priv->base + STF_TIMER_INT_MASK);
> > > > + /* Single run mode Setting */
> > > > + if (dev_read_bool(dev, "single-run"))
> > > > + writel(1, priv->base + STF_TIMER_CTL);
> > > > + /* Set Reload value */
> > > > + priv->timer_size = dev_read_u32_default(dev,
> > > > + "timer-size", 0x);
> > >
> > > -1U ?
> > >
> > Will replace 0x to -1U
> > > > + writel(priv->timer_size, priv->base + STF_TIMER_LOAD);
> > > > + /* Enable to start timer */
> > > > + writel(1, priv->base + STF_TIMER_ENABLE);
> > > > +
> > > > + return 0;
> > > > +}
> > > > +
> > > > +static const struct udevice_id starfive_ids[] = {
> > > > + { .compatible = "starfive,jh8100-timers" },
> > > > + { }
> > > > +};
> > > > +
> > > > +U_BOOT_DRIVER(jh8100_starfive_timer) = {
> > > > + .name = "jh8100_starfive_timer",
> > >
> > Will use name " starfive_timer" instead of "jh8100_starfive_timer"
> > > What is jh8100 ? Do you need that?
> > >
> > > > + .id = UCLASS_TIMER,
> > > > + .of_match = starfive_ids,
> > > > + .probe = starfive_probe,
> > > > + .ops= &starfive_ops,
> > > > + .priv_auto = sizeof(struct starfive_timer_priv),
> > > > +};
> > > > --
> > > > 2.34.1
> > > >
> > >
>
> Regards,
> Simon
Hi Simon,
Please tell me if I am doing something wrong, I will do my best to correct it.
Best Regards,
KuanLim Lee
On 10/18/23 13:27, Sean Anderson wrote:
> On 10/3/23 00:16, Kuan Lim Lee wrote:
> > When selecting MMCSD_MODE_EMMCBOOT as boot_mode, emmc do not
> load
> > U-boot proper image after switched hardware partition.
> >
> > Signed-off-by: Kuan Lim Lee
> > Reviewed-by: Chee Hong Ang
> > Reviewed-by: We
Hi maintainers,
Could anyone of you help to review the patch?
> -Original Message-
> From: KuanLim.Lee
> Sent: Tuesday, October 3, 2023 3:23 PM
> To: u-boot@lists.denx.de
> Cc: Yuklin Soo ; WeiLiang Lim
> ; Kuan Lim Lee
> ; KuanLim.Lee
>
> Subject: [PATCH] mmc: sdhci-cadence: Add suppo
Hi Simon,
Please be reminded that to give some review if it still has some issues.
> -Original Message-
> From: KuanLim.Lee
> Sent: Wednesday, October 4, 2023 5:49 PM
> To: 'Simon Glass'
> Cc: u-boot@lists.denx.de; WeiLiang Lim
> Subject: RE: [PATCH] timer: starfive: Add Starfive timer
Hi maintainers,
Could anyone of you help to review the patch?
> -Original Message-
> From: KuanLim.Lee
> Sent: Tuesday, October 3, 2023 12:17 PM
> To: u-boot@lists.denx.de
> Cc: Cheehong Ang ; WeiLiang Lim
> ; KuanLim.Lee
>
> Subject: [PATCH] spl: mmc: Resolve emmc not load image after
Hi Simon,
If there are no more issue, I will send out version 2 patch.
> -Original Message-
> From: Simon Glass
> Sent: Tuesday, October 10, 2023 9:45 PM
> To: KuanLim.Lee
> Cc: u-boot@lists.denx.de; WeiLiang Lim
> Subject: Re: [PATCH] timer: starfive: Add Starfive timer support
>
> H
Hi there,
May I know that these patches has any issue?
> -Original Message-
> From: KuanLim.Lee
> Sent: Tuesday, October 3, 2023 3:23 PM
> To: u-boot@lists.denx.de
> Cc: Yuklin Soo ; WeiLiang Lim
> ; Kuan Lim Lee
> ; KuanLim.Lee
>
> Subject: [PATCH] mmc: sdhci-cadence: Add support for C
Hi,
Is this patch considered as accepted?
> -Original Message-
> From: KuanLim.Lee
> Sent: Tuesday, October 3, 2023 12:17 PM
> To: u-boot@lists.denx.de
> Cc: Cheehong Ang ; WeiLiang Lim
> ; KuanLim.Lee
>
> Subject: [PATCH] spl: mmc: Resolve emmc not load image after switched hw
> partit
Hi Simon,
Do my questions and replies are proper? Sorry for this time is my first time
upstream.
> -Original Message-
> From: KuanLim.Lee
> Sent: Wednesday, October 4, 2023 5:49 PM
> To: 'Simon Glass'
> Cc: u-boot@lists.denx.de; WeiLiang Lim
> Subject: RE: [PATCH] timer: starfive: Add
Hi Simon,
> -Original Message-
> From: Simon Glass
> Sent: Wednesday, October 4, 2023 10:11 AM
> To: KuanLim.Lee
> Cc: u-boot@lists.denx.de; WeiLiang Lim
> Subject: Re: [PATCH] timer: starfive: Add Starfive timer support
>
> On Tue, 19 Sept 2023 at 06:08, Kuan Lim Lee
> wrote:
> >
> >
14 matches
Mail list logo
