Re: [PATCH] boot: fdt: Turn all addresses and sizes into u64

2024-04-14 Thread Laurent Pinchart
On Sun, Apr 14, 2024 at 11:25:06PM +0200, Marek Vasut wrote: > On 4/14/24 9:29 PM, Laurent Pinchart wrote: > > Hi Marek, > > > > Thank you for the patch. > > > > On Sun, Apr 14, 2024 at 08:37:20PM +0200, Marek Vasut wrote: > >> In case of systems

Re: [PATCH] boot: fdt: Turn all addresses and sizes into u64

2024-04-14 Thread Laurent Pinchart
t") > Signed-off-by: Marek Vasut > --- > Cc: Laurent Pinchart > Cc: Matthias Schiffer > Cc: Simon Glass > Cc: Tom Rini > --- > boot/image-fdt.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/boot/image-fdt.c b/boot/image-fdt.c &g

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Laurent Pinchart
Hi Florian, On Tue, Apr 02, 2024 at 01:18:35PM -0700, Florian Fainelli wrote: > On 4/2/24 13:08, Laurent Pinchart wrote: > > On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: > >> Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: > >>> On 2024-03-28

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Laurent Pinchart
Hello, On Tue, Apr 02, 2024 at 09:52:06PM +0200, Stefan Wahren wrote: > Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: > > On 2024-03-28 01:37, Laurent Pinchart wrote: > >> On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: > >>> Hi, > >>>

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-03-27 Thread Laurent Pinchart
On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: > Hi, > > [add Peter and Ivan] > > Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > > Hello, > > > > This small series includes a few drive-by fixes for DT validation > > errors. > > &

Re: [PATCH v2 2/4] boot: fdt: Clean up env_get_bootm_size()

2024-03-20 Thread Laurent Pinchart
On Wed, Mar 20, 2024 at 09:52:34PM +0100, Marek Vasut wrote: > On 3/18/24 5:18 PM, Laurent Pinchart wrote: > > >> @@ -142,7 +140,7 @@ phys_size_t env_get_bootm_size(void) > >> > >>s = env_get("bootm_low"); > >>if (s) > >&

Re: [PATCH v2 3/4] boot: fdt: Drop lmb_alloc*() typecasts

2024-03-18 Thread Laurent Pinchart
Hi Marek, Thank you for the patch. On Mon, Mar 18, 2024 at 04:00:46PM +0100, Marek Vasut wrote: > The lmb_alloc_base() returns phys_addr_t , map_sysmem() accepts > phys_addr_t as first parameter. Declare 'addr' as phys_addr_t and > get rid of the casts. > > Reported-by: L

Re: [PATCH v2 2/4] boot: fdt: Clean up env_get_bootm_size()

2024-03-18 Thread Laurent Pinchart
proves the code. > Signed-off-by: Marek Vasut > --- > Cc: Heinrich Schuchardt > Cc: Kuninori Morimoto > Cc: Laurent Pinchart > Cc: Simon Glass > Cc: Tom Rini > --- > V2: - New patch > --- > boot/image-board.c | 8 +++- > 1 file changed, 3 insertions

Re: [PATCH 3/3] boot: fdt: Move usable variable below updated comment

2024-03-17 Thread Laurent Pinchart
Hi Marek, Thank you for the patch. On Sun, Mar 17, 2024 at 07:16:31AM +0100, Marek Vasut wrote: > Move the variable below comment which explains what the variable means. > Update the comment. No functional change. > > Suggested-by: Laurent Pinchart > Signed-off-by: Marek Va

Re: [PATCH 2/3] boot: fdt: Drop lmb_alloc*() typecasts

2024-03-17 Thread Laurent Pinchart
ted-by: Laurent Pinchart > Signed-off-by: Marek Vasut > --- > Cc: Heinrich Schuchardt > Cc: Kuninori Morimoto > Cc: Laurent Pinchart > Cc: Simon Glass > Cc: Tom Rini > --- > boot/image-fdt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > &g

Re: [PATCH 1/3] boot: fdt: Change type of env_get_bootm_low() to phys_addr_t

2024-03-17 Thread Laurent Pinchart
l returns ulong. This is potentially dangerous > on 64bit systems, where ulong might not be large enough to hold the content > of "bootm_low" environment variable. Fix it by using phys_addr_t, similar to > what env_get_bootm_size() does, which returns phys_size_t . > > Repor

Re: [PATCH] fdt: Fix bootm_low handling

2024-03-03 Thread Laurent Pinchart
otherwise the reserved memory may be below bootm_low address. > > In case of multiple DRAM banks, the current change reserves top part of > the first bank, and reserves the rest of memory in the follow up banks. > > Signed-off-by: Marek Vasut > --- > Cc: Geert Uytterhoeven

Re: [PATCH] arm64: zynqmp: Remove snps,enable_guctl1_ipd_quirk property

2024-02-28 Thread Laurent Pinchart
k Reviewed-by: Laurent Pinchart > --- > > For more information please take a look at: > https://lore.kernel.org/r/1708023665-1441674-1-git-send-email-radhey.shyam.pan...@amd.com > https://lore.kernel.org/r/1708717523-4006664-1-git-send-email-radhey.shyam.pan...@amd.com > --- > arc

Re: [PATCH v9 2/2] arm64: boot: Support Flat Image Tree

2023-12-09 Thread Laurent Pinchart
On Sat, Dec 09, 2023 at 10:13:59PM +0900, Chen-Yu Tsai wrote: > On Thu, Dec 7, 2023 at 11:38 PM Laurent Pinchart > wrote: > > > > On Thu, Dec 07, 2023 at 10:27:23PM +0800, Chen-Yu Tsai wrote: > > > On Sun, Dec 03, 2023 at 05:34:01PM +0200, Laurent Pinch

Re: [PATCH v9 2/2] arm64: boot: Support Flat Image Tree

2023-12-07 Thread Laurent Pinchart
On Thu, Dec 07, 2023 at 01:52:53PM -0700, Simon Glass wrote: > On Thu, 7 Dec 2023 at 07:38, Laurent Pinchart wrote: > > On Thu, Dec 07, 2023 at 10:27:23PM +0800, Chen-Yu Tsai wrote: > > > On Sun, Dec 03, 2023 at 05:34:01PM +0200, Laurent Pinchart wrote: > > > > Hi Si

Re: [PATCH v9 2/2] arm64: boot: Support Flat Image Tree

2023-12-07 Thread Laurent Pinchart
On Thu, Dec 07, 2023 at 10:27:23PM +0800, Chen-Yu Tsai wrote: > On Sun, Dec 03, 2023 at 05:34:01PM +0200, Laurent Pinchart wrote: > > Hi Simon, > > > > Thank you for the patch. > > > > On Fri, Dec 01, 2023 at 08:54:42PM -0700, Simon Glass wrote: > > >

Re: [PATCH v9 2/2] arm64: boot: Support Flat Image Tree

2023-12-03 Thread Laurent Pinchart
for dirpath, _, fnames in os.walk(path): > +for fname in fnames: > +if os.path.splitext(fname)[1] != '.dtb': > +continue > +pathname = os.path.join(dirpath, fname) > +seq += 1 > +size += os.path.getsize(pathname) > +model, compat = output_dtb(fsw, seq, pathname, > + args.arch, args.compress) > +entries.append([model, compat]) > + > +finish_fit(fsw, entries) > + > +# Include the kernel itself in the returned file count > +return fsw.as_fdt().as_bytearray(), seq + 1, size > + > + > +def run_make_fit(): > +"""Run the tool's main logic""" > +args = parse_args() > + > +out_data, count, size = build_fit(args) > +with open(args.fit, 'wb') as outf: > +outf.write(out_data) > + > +ext_fit_size = None > +if args.external: > +mkimage = os.environ.get('MKIMAGE', 'mkimage') > +subprocess.check_call([mkimage, '-E', '-F', args.fit], > + stdout=subprocess.DEVNULL) > + > +with open(args.fit, 'rb') as inf: > +data = inf.read() > +ext_fit = libfdt.FdtRo(data) > +ext_fit_size = ext_fit.totalsize() > + > +comp_size = len(out_data) > +print(f'FIT size {comp_size:#x}/{comp_size / 1024 / 1024:.1f} MB', > end='') > +if ext_fit_size: > +print(f', header {ext_fit_size:#x}/{ext_fit_size / 1024:.1f} KB', > end='') > +print(f', {count} files, uncompressed {size / 1024 / 1024:.1f} MB') > + > + > +if __name__ == "__main__": > +sys.exit(run_make_fit()) -- Regards, Laurent Pinchart

Re: [RFC/PATCH] lib/Kconfig: Enable OF_LIBFDT_OVERLAY by default when FIT is enabled

2023-03-12 Thread Laurent Pinchart
Hi Tom, On Fri, Mar 10, 2023 at 01:12:24PM -0500, Tom Rini wrote: > On Sun, Jan 29, 2023 at 06:30:22PM +0200, Laurent Pinchart wrote: > > > FIT image support is commonly used to bundle a kernel image, a device > > tree, and device tree overlays. Applying

[RFC/PATCH] lib/Kconfig: Enable OF_LIBFDT_OVERLAY by default when FIT is enabled

2023-01-29 Thread Laurent Pinchart
This enables the FDT library (libfdt) overlay support. base-commit: f147aa80f52989c7455022ca1ab959e8545feccc -- Regards, Laurent Pinchart

Re: TFTP hangs with fragmented IP packets

2022-04-05 Thread Laurent Pinchart
Hi Ramon, On Sun, Apr 03, 2022 at 02:17:26AM +0300, Ramon Fried wrote: > On Thu, Mar 31, 2022 at 8:43 AM Ramon Fried wrote: > > On Tue, Mar 29, 2022 at 11:28 PM Laurent Pinchart wrote: > > > > > > Hello, > > > > > > I've banged my head a few

TFTP hangs with fragmented IP packets

2022-03-29 Thread Laurent Pinchart
to avoid fragmentation works around the problem. Arguably a TFTP block size of 4096 bytes should probably not be used with a 1500 bytes MTU network, but I thought it would be useful to fix the issue nonetheless. I can test patches. -- Regards, Laurent Pinchart test.bin Description: Binary data

Re: [U-Boot] [RFC] ARM: rmobile: create DT memory nodes for R8A7795 3.0 and newer

2018-06-19 Thread Laurent Pinchart
Hi Geert, On Tuesday, 19 June 2018 09:58:59 EEST Geert Uytterhoeven wrote: > On Tue, Jun 19, 2018 at 4:15 AM Laurent Pinchart wrote: > > On Sunday, 17 June 2018 03:08:02 EEST Marek Vasut wrote: > >> On 06/16/2018 05:44 PM, Laurent Pinchart wrote: > >>> On Saturd

Re: [U-Boot] [RFC] ARM: rmobile: create DT memory nodes for R8A7795 3.0 and newer

2018-06-18 Thread Laurent Pinchart
Hi Magnus, On Tuesday, 19 June 2018 08:43:31 EEST Magnus Damm wrote: > On Tue, Jun 19, 2018 at 11:15 AM, Laurent Pinchart wrote: > > On Sunday, 17 June 2018 03:08:02 EEST Marek Vasut wrote: > >> On 06/16/2018 05:44 PM, Laurent Pinchart wrote: > >>> On Saturday, 16

Re: [U-Boot] [RFC] ARM: rmobile: create DT memory nodes for R8A7795 3.0 and newer

2018-06-18 Thread Laurent Pinchart
On Sunday, 17 June 2018 03:08:02 EEST Marek Vasut wrote: > On 06/16/2018 05:44 PM, Laurent Pinchart wrote: > > Hi Marek, > > > > On Saturday, 16 June 2018 02:42:30 EEST Marek Vasut wrote: > >> On 06/16/2018 01:21 AM, Laurent Pinchart wrote: > >>> On Frid

Re: [U-Boot] [RFC] ARM: rmobile: create DT memory nodes for R8A7795 3.0 and newer

2018-06-17 Thread Laurent Pinchart
Hi Marek, On Saturday, 16 June 2018 02:42:30 EEST Marek Vasut wrote: > On 06/16/2018 01:21 AM, Laurent Pinchart wrote: > > On Friday, 15 June 2018 15:00:31 EEST Marek Vasut wrote: > >> On 06/15/2018 01:43 PM, Marek Vasut wrote: > >>> On 06/15/2018 12:37 PM, Ulrich H

Re: [U-Boot] [RFC] ARM: rmobile: create DT memory nodes for R8A7795 3.0 and newer

2018-06-15 Thread Laurent Pinchart
ale. The API here uses some ad-hoc constants to > > identify memory layout tables which have to be encoded both in ATF and > > U-Boot, both of which must be kept in sync. > > > > The ATF already has those memory layout tables, it's only a matter of > > passing them t

Re: [U-Boot] cmd/fdt: support single value replacement within an array

2017-08-18 Thread Laurent Pinchart
Hi Hannes, On Friday 18 Aug 2017 10:07:19 Hannes Schmelzer wrote: > Laurent Pinchart schrieb am 04.08.2017 23:23:19: > > Hi Laurent, > > as told a few days ago i'm now coming back to this issue. Thank you. > > (I'm not subscribed to the list, please keep me CC'ed on repl

Re: [U-Boot] cmd/fdt: support single value replacement within an array

2017-08-04 Thread Laurent Pinchart
etprop(): %s\n", > fdt_strerror(ret)); > @@ -766,7 +775,11 @@ static int fdt_parse_prop(char * const *newval, int > count, char *data, int *len) > cp = newp; > tmp = simple_strtoul(cp, , 0); > > - *(fdt32_t *

[U-Boot] [PATCH] Remove duplicate Spartan-3E definition.

2008-09-17 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart [EMAIL PROTECTED] --- include/spartan3.h |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/include/spartan3.h b/include/spartan3.h index 235dbc0..2262278 100644 --- a/include/spartan3.h +++ b/include/spartan3.h @@ -81,9 +81,6

[U-Boot] [PATCH] Fix Spartan-3 definitions.

2008-09-17 Thread Laurent Pinchart
A few Spartan-3 definitions erroneously use Spartan-3E size constants. This patch fixes them. Signed-off-by: Laurent Pinchart [EMAIL PROTECTED] --- include/spartan3.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/spartan3.h b/include/spartan3.h index