Hi,
On Wed, 24 Apr 2024 13:09:11 +0530, Ravi Gunasekaran wrote:
> When the device port is in a low power state [U3/L2/Not Connected],
> accesses to usb device registers may take a long time. This could lead to
> potential core hang when the controller registers are accessed after the
> port is
6,7 @@ static int cdns3_gadget_udc_stop(struct usb_gadget
>> *gadget)
>>
>> /* disable interrupt for device */
>> writel(0, _dev->regs->usb_ien);
>> +writel(0, _dev->regs->usb_pwr);
>> writel(USB_CONF_DEVDS, _dev->regs->usb_conf);
>>
>> return ret;
>>
>> base-commit: bc39e06778168a34bb4e0a34fbee4edbde4414d8
>
> Since this is gadget stuff, +CC Mattijs , that should go through their tree.
>
> Thanks!
Thank you Marek for CC'ing me, I missed this patch.
Reviewed-by: Mattijs Korpershoek
Hi Greg,
On ven., avril 19, 2024 at 15:21, Greg Malysa wrote:
> Hi Mattijs,
>
>> Please avoid top-posting when replying, it makes following the
>> discussion more difficult:
>>
Hi Tom,
Here is a new development for master:
- new "fastboot oem board" command
This CI job is at
https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/20427
Thanks,
Mattijs
The following changes since commit 2c3fa4b8add3cb6a440184ab67debc6867d383c0:
sandbox: don't call
Hi,
On Thu, 18 Apr 2024 13:01:28 +0300, Alexey Romanov wrote:
> Changes V1 -> V2 [1]:
> - Added an example of using the command as requested
> by Sean Anderson [2].
>
> Changes V2 -> V3 [3]:
> - Rebase over uboot/master.
> - Add documentation.
> - Remove example added in V2 [1].
>
>
gt;
> $ fastboot stage bootloader.img
> $ fastboot oem board:write_bootloader
>
> - erasing:
>
> $ fastboot oem board:erase_env
>
> Signed-off-by: Alexey Romanov
> Reviewed-by: Mattijs Korpershoek
After applying this patch on master, it seems that the CI broke:
gt; Signed-off-by: Michal Simek
Reviewed-by: Mattijs Korpershoek
> ---
>
> boot/Kconfig | 1 -
> cmd/Kconfig | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/boot/Kconfig b/boot/Kconfig
> index 777e408e2438..bb61e8b24f1c 100644
> --- a/boot/Kconfig
> ++
Hi,
On ven., avril 12, 2024 at 18:54, Aren wrote:
> On Thu, Apr 11, 2024 at 04:46:17PM +1000, John Watts wrote:
>> On Sun, Dec 31, 2023 at 03:38:37PM -0500, Aren Moynihan wrote:
>> > Add support for building the sunxi-musb driver with DM_USB_GADGET
>> > including adding a separate IRQ handling
Hi Jon,
On jeu., avril 11, 2024 at 15:30, Jon Humphreys wrote:
> Mattijs Korpershoek writes:
>
>> Hi Jonathan,
>>
>> Thank you for the patch.
>>
>> On lun., avril 08, 2024 at 17:31, Jonathan Humphreys
>> wrote:
>>
>>> Signed-off-by:
Hi Caleb,;
Thank you for the patch.
On jeu., avril 11, 2024 at 18:05, Caleb Connolly
wrote:
> The revision is different for these, add the additional check as in
> xhci-dwc3 core_init code.
>
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> drive
off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> disk/part_efi.c | 1 +
> include/part.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/disk/part_efi.c b/disk/part_efi.c
> index 4ce9243ef25c..d3ce4dd01dcd 100644
> --- a/disk/par
Hi Caleb,
Thank you for the patch.
On mar., avril 09, 2024 at 15:55, Caleb Connolly
wrote:
> This is extremely similar to the MMC backend, but there are some notable
> differences.
>
> Works with a DFU string like
>
> scsi 4=u-boot-bin part 11
>
> Where "4" is the SCSI dev number
Hi Greg,
Thank you for the contribution.
On mar., mars 26, 2024 at 11:36, Greg Malysa wrote:
Please avoid top-posting when replying, it makes following the
discussion more difficult:
On mar., avril 16, 2024 at 10:50, Mattijs Korpershoek
wrote:
> Hi Kongyang,
>
> Thank you for the patch.
>
> On jeu., mars 28, 2024 at 21:14, Kongyang Liu
> wrote:
>
>> Starting from version 4.20a, there has been a change in the reset method.
>> A new bi
has been completed.
>
> Signed-off-by: Kongyang Liu
I've compared this with the equivalent Linux patch found here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=65dc2e725286106f99c6f6b78e3d9c52c15f3a9c
Reviewed-by: Mattijs Korpershoek
Also tested on VIM3 t
Hi,
On Mon, 08 Apr 2024 13:15:51 +0300, Alexey Romanov wrote:
> Changes V1 -> V2 [1]:
> - Added an example of using the command as requested
> by Sean Anderson [2].
>
> Changes V2 -> V3 [3]:
> - Rebase over uboot/master.
> - Add documentation.
> - Remove example added in V2 [1].
>
>
i-u-boot/commit/?h=ti-u-boot-2023.04=c5296d943c2c84dd6dcb3b91305d006ac46f3157
Before patch:
=> reset
resetting ...
System reset not supported on this platform
### ERROR ### Please RESET the board ###
With patch applied:
=> reset
resetting ...
Tested-by: Mattijs Korpershoek # on am62x sk ev
>$ fastboot stage bootloader.img
>> >$ fastboot oem board:write_bootloader
>> >
>> > - erasing:
>> >
>> >$ fastboot oem board:erase_env
>> >
>> > Signed-off-by: Alexey Romanov
>> > Reviewed-by: Mattijs Korper
Hi Tom,
Thank you for the review.
On lun., avril 08, 2024 at 14:11, Tom Rini wrote:
> On Fri, Apr 05, 2024 at 08:16:19AM +0200, Mattijs Korpershoek wrote:
>
>
>> commit cacc0b2678c0 ("CI: Move to latest container image") updated the
>> docker container i
t;
> - flashing:
>
> $ fastboot stage bootloader.img
> $ fastboot oem board:write_bootloader
>
> - erasing:
>
> $ fastboot oem board:erase_env
>
> Signed-off-by: Alexey Romanov
Reviewed-by: Mattijs Korpershoek
Thank you for being patient on this topic!
I'll be aw
Hi Alexey,
On lun., mars 04, 2024 at 14:03, Alexey Romanov
wrote:
> Hello Mattijs,
>
> On Thu, Feb 15, 2024 at 10:24:11AM +0100, Mattijs Korpershoek wrote:
>> On jeu., f'evr. 01, 2024 at 12:20, Alexey Romanov
>> wrote:
>>
>> > An example of how w
Hi Alexey,
On lun., mars 04, 2024 at 14:11, Alexey Romanov
wrote:
> Hello,
>
> On Thu, Feb 15, 2024 at 10:14:13AM +0100, Mattijs Korpershoek wrote:
>> Hi Alexey,
>>
>> Thank you for the patch.
>>
>> On jeu., f'evr. 01, 2024 at 12:20, Alexey Romanov
ers, I have re-considered this and I'm willing to pick it up.
Please rebase, as this no longer applies.
Also see some review comments below
>
> On Thu, Feb 15, 2024 at 10:14:13AM +0100, Mattijs Korpershoek wrote:
>> Hi Alexey,
>>
>> Thank you for the patch.
>>
>>
: Patrick Delaunay
> Cc: Simon Glass
> Cc: Mattijs Korpershoek
> Cc: Ying-Chun Liu (PaulLiu)
> ---
> drivers/fastboot/fb_command.c | 8
> drivers/fastboot/fb_common.c | 15 +++
> drivers/fastboot/fb_getvar.c | 8 +++-
> 3 files changed, 26 insert
ick Delaunay
> Cc: Simon Glass
> Cc: Mattijs Korpershoek
> Cc: Ying-Chun Liu (PaulLiu)
This change (when applied along with 1/4 and 2/4) introduces a build for
sandbox:
$ make sandbox_defconfig
$ make
[...]
drivers/fastboot/fb_mmc.c: In function 'fastboot_mmc_erase':
drivers/fastbo
Hi Dmitrii,
Thank you for the patch and sorry for the review delay.
On mer., mars 06, 2024 at 18:59, Dmitrii Merkurev wrote:
> Signed-off-by: Dmitrii Merkurev
> Cc: Patrick Delaunay
> Cc: Simon Glass
> Cc: Mattijs Korpershoek
> Cc: Ying-Chun Liu (PaulLiu)
> ---
> dri
, Dmitrii Merkurev wrote:
> Co-developed-by: Cody Schuffelen
> Signed-off-by: Cody Schuffelen
> Signed-off-by: Dmitrii Merkurev
> Cc: Tuomas Tynkkynen
> Cc: Simon Glass
> Cc: Mattijs Korpershoek
> Cc: Ying-Chun Liu (PaulLiu)
I'm not super familiar with virtio, so I've not re
".
This fixes the HTML rendering.
Signed-off-by: Mattijs Korpershoek
---
doc/build/gen_compile_commands.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/build/gen_compile_commands.rst
b/doc/build/gen_compile_commands.rst
index 50305cec4a83..d503764f9e3f 100644
--- a/
commit cacc0b2678c0 ("CI: Move to latest container image") updated the
docker container image.
Reflect the change in the documentation.
Signed-off-by: Mattijs Korpershoek
---
Note: maybe we can consider doing the doc change each time we update
.gitlab-ci.yml ?
---
doc/build/dock
implementation
> - Documentation, including device tree bindings
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
> ---
>
> MAINTAINERS | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0462ade4ac6..0f7325d6045 1
Hi Tom,
Here are some fixes for master including:
- Fix #if logic in android_ab command
- Fix ANDROID_AB_BACKUP_OFFSET in android_ab
The CI job is at
https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/20142
Thanks,
Mattijs
The following changes since commit
Hi Tom,
Here are some developments for next including:
- Implement Qualcomm wrapper for dwc3
- Multiple sector size support for UMS
- CDC ACM gadget initialization fix
- Refactor board code from dwc3 to prepare better interrupt support
- Bugfix for for qcom-smmu when compiling with -DDEBUG
The
Hi,
On Sun, 17 Mar 2024 05:42:52 +0100, Marek Vasut wrote:
> The dm_usb_gadget_handle_interrupts() has no place in board code. Move
> this into DWC3 driver. The OMAP implementation is special, add new weak
> dwc3_uboot_interrupt_status() function to decide whether DWC3 interrupt
> handling should
[1] https://lore.kernel.org/r/87a5mqei67@baylibre.com
> ---
> Cc: Mattijs Korpershoek
> ---
> drivers/usb/gadget/f_mass_storage.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_mass_storage.c
> b/d
lab.com/amlogic-foss/amlogic-u-boot-autotest/-/pipelines/1233461384
>
> Signed-off-by: Neil Armstrong
> ---
> Changes in v2:
> - add change to remove prefix in fdtfile
> - collected review tags
> - Link to v1:
> https://lore.kernel.org/r/20240319-u-boot-of-upstream-v1-0-f8
Hi,
On jeu., mars 28, 2024 at 09:21, Neil Armstrong
wrote:
> Hi Mattijs,
>
> On 19/03/2024 15:42, Neil Armstrong wrote:
>> Enable OF_UPSTREAM to use upstream DT and add amlogic/ prefix to the
>> DEFAULT_DEVICE_TREE. And thereby directly build DTB from dts/upstream/src/
>> including
On jeu., mars 21, 2024 at 20:38, Marek Vasut wrote:
> On 3/21/24 11:01 AM, Mattijs Korpershoek wrote:
>> Hi Marek,
>>
>> Thank you for the patch.
>>
>> On dim., mars 17, 2024 at 05:42, Marek Vasut
>> wrote:
>>
>>> The dm_usb_gadge
Hi Caleb,
On jeu., mars 21, 2024 at 17:01, Caleb Connolly
wrote:
> On 21/03/2024 16:48, Mattijs Korpershoek wrote:
>> Hi Caleb,
>>
>> Thank you for the patch.
>>
>> On jeu., mars 21, 2024 at 15:28, Caleb Connolly
>> wrote:
>>
>>>
Hi,
On Tue, 12 Mar 2024 07:57:27 -0500, Colin McAllister wrote:
> - Addresses compiler error due to missing semicolon
> - Removes use of preprocessor macros with ANDROID_AB_BACKUP_OFFSET
>
> Bug was found by noticing a semicolon was missing and not causing a
> compiler error when
. Replace these divisions with calls to
> lldiv() to handle this correctly.
>
> Fixes: 74e56e0c5065 ("usb: gadget: UMS: support multiple sector sizes")
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
Would it be okay if I squashed this into
commit 74e56e0c5065 (&quo
:
f_mass_storage.c:946:(.text.do_write.lto_priv.0+0x1de): undefined reference to
`__aeabi_ldivmod'
Could you have a look, please?
Thank you.
Mattijs
On jeu., mars 21, 2024 at 10:23, Mattijs Korpershoek
wrote:
> Hi,
>
> On Wed, 20 Mar 2024 14:30:46 +, Caleb Connolly wrote:
>&
On jeu., mars 21, 2024 at 11:34, Caleb Connolly
wrote:
> Hi,
>
> On 21/03/2024 09:25, Mattijs Korpershoek wrote:
>> Hi Caleb, Marek,
>>
>> On jeu., mars 21, 2024 at 06:34, Marek Vasut wrote:
>>
>>> On 3/13/24 7:22 PM, Caleb Connolly wrote:
&g
itialised in
> that case.
>
> CONFIG_BUTTON is now enabled automatically and was removed when running
> save_defconfig.
>
> Fixes: e761035b6423 ("boot: add support for button commands")
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> Pipeline:
called from board code as well.
>
> Signed-off-by: Marek Vasut
> ---
> Cc: Angus Ainslie
> Cc: Caleb Connolly
> Cc: Eugen Hristev
> Cc: Igor Prusov
> Cc: Mattijs Korpershoek
> Cc: Nishanth Menon
> Cc: Patrice Chotard
> Cc: Simon Glass
> Cc: Stefan Bosch
&
e whether DWC3 interrupt
> handling should be called, and override it in OMAP DWC3 code, to repair
> the special OMAP interrupt handling code until OMAP gets switched over
> to DM UDC proper.
>
> Signed-off-by: Marek Vasut
Reviewed-by: Mattijs Korpershoek
Tested that I could s
contributions!
Mattijs
On mer., mars 13, 2024 at 18:22, Igor Opaniuk wrote:
> Hi Colin,
>
> On Tue, Mar 12, 2024 at 4:19 PM Mattijs Korpershoek <
> mkorpersh...@baylibre.com> wrote:
>
>> Hi Colin,
>>
>> Thank you for the patch.
>>
>> On mar.,
Hi Caleb, Marek,
On jeu., mars 21, 2024 at 06:34, Marek Vasut wrote:
> On 3/13/24 7:22 PM, Caleb Connolly wrote:
>
> [...]
>
+static inline void dwc3_qcom_setbits(void __iomem *base, u32 offset,
u32 val)
+{
+ u32 reg;
+
+ reg = readl(base + offset);
+
Hi,
On Wed, 20 Mar 2024 14:30:46 +, Caleb Connolly wrote:
> This series enables support for Qualcomm platforms in the DWC3 driver,
> adds support for arbitrary sector sizes to the USB mass storage gadget,
> and fixes an issue with the CDC ACM driver where it wouldn't initialise
> the USB
* to the backup offset
> - */
> - if (memcmp(backup_abc, abc, sizeof(*abc)) != 0) {
> - ret = ab_control_store(dev_desc, part_info, abc,
> -ANDROID_AB_BACKUP_OFFSET);
> - if (ret < 0) {
> - fr
#if.
>
> Fixes: 3430f24bc6 ("android_ab: Try backup booloader_message")
> Signed-off-by: Colin McAllister
> Cc: Joshua Watt
> Cc: Simon Glass
> Signed-off-by: Colin McAllister
Reviewed-by: Mattijs Korpershoek
Since Sam gave his review in [1]:
https://lore.kernel.
d using my personal email, but that email isn’t subscribed
> to this ML so I think the patches are pending approval to be added to the ML.
Yep, seems they got approved. I will follow-up on the v4 series.
>
> Best,
> Colin
>
> From: Mattijs Korpershoek
> Sent: Tuesday, March 12,
On jeu., mars 07, 2024 at 16:54, Sam Protsenko
wrote:
> On Thu, Mar 7, 2024 at 4:11 PM Colin McAllister
> wrote:
>>
>> Found a missing semicolon in code protected by a #if that will never
>> evaluate to true due to a separate issue. Fixing this issue before
>> addressing the #if.
>>
>>
Hi Colin,
On ven., mars 08, 2024 at 15:59, Sam Protsenko
wrote:
> On Fri, Mar 8, 2024 at 1:24 PM McAllister, Colin
> wrote:
>>
>> > Ah, ok, I see you replied to my comment here.
>>
>> Yes, sorry. Outlook is terrible to send inline responses too. I figured
>> just adding responses in the patch
Hi Igor, Sam,
On mar., févr. 20, 2024 at 20:08, Igor Opaniuk
wrote:
> Hi Sam,
>
> On Tue, Feb 20, 2024 at 7:29 PM Sam Protsenko
> wrote:
>>
>> On Mon, Feb 19, 2024 at 4:16 AM Igor Opaniuk wrote:
>> >
>> > This takes the latest changes from AOSP from [1][2] (as this
>> > header was split on
niu Rosca
> CC: Simon Glass
> Signed-off-by: Igor Opaniuk
Tested on Khadas VIM3 that I could reboot into fastbootd (recovery)
and into fastboot(u-boot) from Android using:
$ adb reboot fastboot
$ adb reboot bootloader
Reviewed-by: Mattijs Korpershoek
Tested-by: Mattijs Korpershoek #
Hi Jonas, thank you for the patch.
On lun., févr. 26, 2024 at 13:36, Jonas Karlman wrote:
> On 2024-02-26 11:18, Marek Vasut wrote:
>> On 2/26/24 10:50 AM, Jonas Karlman wrote:
>>> On 2024-02-26 09:22, Marek Vasut wrote:
On 2/26/24 8:54 AM, Jonas Karlman wrote:
> On 2024-02-26 02:47,
Hi Tom,
Here are some developments for master including:
- Fix avb_verify command with SD cards
- Add u-boot-dfu maintainer tree for AB/AVB
- Avb: report verified boot state based on lock state
- Misc avb refactors improve code quality
The CI job is at
11 bytes
> => optee_rpmb read_pvalue test_variable 11
> Read 11 bytes, value = test_value
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
Tested-by: Mattijs Korpershoek # on sandbox
> ---
>
> cmd/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 del
On jeu., févr. 01, 2024 at 12:20, Alexey Romanov
wrote:
> An example of how we use fastboot oeam board subcommand
> for Sean Anderson.
>
> 1 - OEM_BOARD_WRITE_BOOTLOADER_CMD:
>
> We use it for custom Amlogic bootloader + tpl
> flashing protocol.
>
> 2 - OEM_BOARD_ERASE_CMD:
>
> Custom logic for
Hi Alexey,
Thank you for the patch.
On jeu., févr. 01, 2024 at 12:20, Alexey Romanov
wrote:
> Currently, fastboot protocol in U-Boot has no opportunity
> to execute vendor custom code with verifed boot. This patch
> introduce new fastboot subcommand fastboot oem board:,
> which allow to run
Hi Igor,
On Fri, Feb 09, 2024 at 17:17, Igor Opaniuk wrote:
> Hello Mattijs,
>
> On Fri, Feb 9, 2024 at 11:30 AM Mattijs Korpershoek
> wrote:
>>
>> Hi Igor,
>>
>> On ven., févr. 09, 2024 at 11:14, Igor Opaniuk
>> wrote:
>>
>> > Hi
Hi,
On Fri, 09 Feb 2024 20:20:38 +0100, Igor Opaniuk wrote:
> This is the first patch series for incoming major
> improvements for AVB implementation, that include:
> - Simplify and add more context for debug/error prints where it's needed.
> - Move SPDX license identifiers to the first line, so
Hi,
On Tue, 13 Feb 2024 08:36:38 +0100, Igor Opaniuk wrote:
> Add information about a custodian tree [1] for AVB/AB, which is
> maintained by Mattijs Korpershoek.
>
> [1] https://source.denx.de/u-boot/custodians/u-boot-dfu
>
>
Thanks, Applied to https://source.denx.de/u-boot
Hi Igor,
On mar., févr. 13, 2024 at 12:19, Igor Opaniuk wrote:
> Hi Mattijs,
>
> On Tue, Feb 13, 2024 at 9:13 AM Mattijs Korpershoek
> wrote:
>>
>> Hi Igor,
>>
>> On lun., févr. 12, 2024 at 09:05, Igor Opaniuk
>> wrote:
>>
>> > Hi Dan
Hi Marek,
Thank you for your review.
On mar., févr. 13, 2024 at 12:55, Marek Vasut wrote:
> On 2/13/24 08:32, Igor Opaniuk wrote:
>> From: Igor Opaniuk
>>
>> Add information about a custodian tree [1] for AVB/AB, which is
>> maintained by Mattijs Ko
Hi Igor,
Thank you for the patch.
On mar., févr. 13, 2024 at 08:36, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Add information about a custodian tree [1] for AVB/AB, which is
> maintained by Mattijs Korpershoek.
>
> [1] https://source.denx.de/u-boot/custodians/u-boo
Hi Igor,
Thank you for the patch.
On ven., févr. 09, 2024 at 20:20, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Sync usage info with the one cmd/avb.c.
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
> ---
>
> Changes in v2:
> - Address Matti
Hi Igor,
Thank you for the patch.
On ven., févr. 09, 2024 at 20:20, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Simplify and add more context for prints where it's needed.
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
> ---
>
> Changes in v2
Hi Igor,
On lun., févr. 12, 2024 at 09:05, Igor Opaniuk wrote:
> Hi Dan,
>
> On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter
> wrote:
>>
>> On Fri, Feb 09, 2024 at 08:20:39PM +0100, Igor Opaniuk wrote:
>> > From: Igor Opaniuk
>> >
>> > mmc_switch_part() is used for switching between hw
additions (AVB, AB) of myself to the MAINTAINERS file
Mattijs Korpershoek (2):
MAINTAINERS: add Mattijs for Android AB
MAINTAINERS: add Mattijs for Android AVB
Sean Anderson (1):
lib: sparse: Fix error checking
Hi Igor,
On ven., févr. 09, 2024 at 11:14, Igor Opaniuk wrote:
> Hi everyone,
>
> I'm currently planning a big overhaul of the current implementation of
> AVB/AB in U-Boot during the 2024 year, which I have barely touched since
> 2019. I used to believe that it was stillborn, but looks like
setting correct
> androidboot.verifiedbootstate kernel cmdline parameter.
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
Nitpick: the error handling migration could have been part of PATCH 5/7
but it's fine to keep as is.
> ---
>
> cmd/avb.c | 50 +--
36e9f8 ("Convert CONFIG_SYS_MALLOC_LEN to Kconfig")
Add it back to fix AVB verification on VIM3/VIM3L.
Fixes: 7cfbba36e9f8 ("Convert CONFIG_SYS_MALLOC_LEN to Kconfig")
Co-developed-by: Guillaume La Roque
Signed-off-by: Guillaume La Roque
Signed-off-by: Mattijs Korpershoek
---
configs/k
Hi Igor,
Thank you for the patch.
On mar., févr. 06, 2024 at 23:31, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Add info about slot_suffix param for avb verify.
>
> Signed-off-by: Igor Opaniuk
> ---
>
> doc/android/avb2.rst | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
Hi Igor,
Thank you for the patch.
On mar., févr. 06, 2024 at 23:31, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Introduce str_avb_io_error() and str_avb_slot_error() functions,
> that provide a pointer to AVB runtime error message.
>
> Signed-off-by: Igor Opaniuk
Re
Hi Igor,
Thank you for the patch.
On mar., févr. 06, 2024 at 23:31, Igor Opaniuk
wrote:
> From: Igor Opaniuk
>
> Introduce AVB_OPS_CHECK macro for checking AvbOps before using
> it to avoid code duplication.
> Simplify and add more context for prints where it's needed.
>
> Signed-off-by:
-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
> ---
>
> common/avb_verify.c | 31 ++-
> 1 file changed, 18 insertions(+), 13 deletions(-)
>
> diff --git a/common/avb_verify.c b/common/avb_verify.c
> index 938a5383b5d..ed58239cf8a 100644
gt;
> [1] https://www.kernel.org/doc/Documentation/process/license-rules.rst
>
> Signed-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
Nitpick in the title: itdentifiers -> identifiers.
If no other remarks in the series, will fix when applying.
> ---
>
>
-off-by: Igor Opaniuk
Reviewed-by: Mattijs Korpershoek
> ---
>
> common/avb_verify.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/common/avb_verify.c b/common/avb_verify.c
> index 48ba8db51e5..59f2c25e0de 100644
> --- a/common/avb_ver
Hi Sjoerd,
Thank you for the patch.
On ven., janv. 12, 2024 at 09:52, Sjoerd Simons wrote:
> Enable USB host as well as USB gadget and DFU support for a53; For the
> r5 due to the smaller available size create a config fragment for DFU
> supports which disables support for persistent storage
Hi,
On Thu, 01 Feb 2024 13:18:51 -0500, Sean Anderson wrote:
> The return value of write_sparse_chunk_raw is unsigned, so the existing
> check has no effect. Use IS_ERR_VALUE to detect error instead, which is
> what write_sparse_chunk_raw does itself.
>
>
Thanks, Applied to
Hi Caleb,
On Thu, Feb 01, 2024 at 14:24, Caleb Connolly wrote:
> On 01/02/2024 09:34, Mattijs Korpershoek wrote:
>> Hi Caleb,
>>
>> Thank you for the patch.
>>
>> On mer., janv. 31, 2024 at 14:57, Caleb Connolly
>> wrote:
>>
>>> The Q
>
> Fixes: 62649165cb0 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned")
> Reported-by: Dan Carpenter
> Link:
> https://lore.kernel.org/u-boot/1b323ec3-59b0-490b-a2f0-fd961dafcf49@moroto.mountain/
> Signed-off-by: Sean Anderson
Reviewed-by: Mattijs Korpershoek
> ---
Hi Caleb,
Thank you for the patch.
On mer., janv. 31, 2024 at 14:57, Caleb Connolly
wrote:
> The priv struct was wrong in dump_boot_mappings(). Causing errors when
> compiling with -DDEBUG. Fix this.
>
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
&
Hi Caleb,
Thank you for the patch.
On mer., janv. 31, 2024 at 14:57, Caleb Connolly
wrote:
> UFS storage often uses a 4096-byte sector size, add support for dynamic
> sector sizes based loosely on the Linux implementation.
>
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs
> Signed-off-by: Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> drivers/usb/gadget/f_acm.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/gadget/f_acm.c
> index de42e0189e8d..ba216128ab27 100644
> ---
Caleb Connolly
Reviewed-by: Mattijs Korpershoek
> ---
> drivers/usb/dwc3/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index c0c8c16fd9c2..8a70bc682322 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/dr
Hi Caleb,
Thank you for the patch.
On mer., janv. 31, 2024 at 14:57, Caleb Connolly
wrote:
> The Qualcomm specific dwc3 wrapper isn't hugely complicated, implemented
> the missing initialisation for host and gadget mode.
>
> Signed-off-by: Caleb Connolly
> ---
>
Hi Sjoerd
Thank you for the patch.
On ven., janv. 12, 2024 at 09:52, Sjoerd Simons wrote:
> Enable usb0 in all boot phases for use with DFU
>
> Signed-off-by: Sjoerd Simons
>
> ---
>
> Changes in v4:
> - Don't force usb0 into peripheral mode
I know that dr_mode = "peripheral" has been
> +uploaded one by one with a tool like dfu-util.
> +
> +.. am62x_evm_rst_include_start_dfu_boot
> +
> +The initial ROM will have a DFU alt named `bootloader` for the initial R5 spl
> +upload. The next stages as exposed by u-boot have target alts matching the
> name
s/u-boo
Hi Sjoerd,
Thank you for the patch.
On ven., janv. 12, 2024 at 09:52, Sjoerd Simons wrote:
> Include standard TI K3 dfu environment
>
> Signed-off-by: Sjoerd Simons
Reviewed-by: Mattijs Korpershoek
>
> ---
>
> (no changes since v3)
>
> Changes in v3:
> -
Hi Sjoerd, Caleb
On ven., janv. 12, 2024 at 12:55, Caleb Connolly
wrote:
> Hi Sjoerd,
>
> On 12/01/2024 08:52, Sjoerd Simons wrote:
>> When dr_mode is "otg" the dwc3 is initially configured in _OTG mode;
>> However in this mode the gadget functionality doesn't work without
>> further
gadget start switch to _DEVICE
> mode globally and go back to _OTG on stop again.
>
> For this the dwc3_set_mode is renamed to dwc3_core_set_mode to avoid a
> conflict with the same function exposed by xhci-dwc3
>
> Signed-off-by: Sjoerd Simons
Reviewed-by: Mattijs Korpershoek
if (IS_ERR(syscon)) {
> + dev_err(dev, "unable to get ti,syscon-phy-pll-refclk regmap\n");
> + return;
> + }
> +
> + ret = ofnode_parse_phandle_with_args(dev_ofnode(dev),
> "ti,syscon-phy-pll-refclk", NULL, 1,
> +
280
Err: serial@280
Net: No ethernet found.
Press SPACE to abort autoboot in 2 seconds
I've also tested (from the DFU'd U-Boot) that I could scan for usb keys:
=> usb start
[..]
1 USB Device(s) found
So for the series:
Tested-by: Mattijs Korpershoek # on beagle play
>
> I wi
Hi,
On Fri, 12 Jan 2024 09:40:43 +0100, Mattijs Korpershoek wrote:
> Igor has not been active for quite some time on lore:
> https://lore.kernel.org/all/?q=igor.opan...@gmail.com
>
> It seems that Android AB and AVB could use some help maintaining.
>
> I'm interested in helpin
Hi Tom, all,
On ven., janv. 12, 2024 at 08:50, Tom Rini wrote:
> On Fri, Jan 12, 2024 at 09:40:43AM +0100, Mattijs Korpershoek wrote:
>
>> Igor has not been active for quite some time on lore:
>> https://lore.kernel.org/all/?q=igor.opan...@gmail.com
>>
>> It seems
Hi Sjoerd, Nishanth,
On Fri, Jan 12, 2024 at 13:58, Sjoerd Simons wrote:
> On Fri, 2024-01-12 at 06:36 -0600, Nishanth Menon wrote:
>> On 09:52-20240112, Sjoerd Simons wrote:
>> >
>> > +DFU based boot
>> > +--
>> > +
>> > +To boot the board over DFU, ensure there is no SD card
he error code to the caller.
>>
>> Signed-off-by: Alexey Romanov
>> Reviewed-by: Mattijs Korpershoek
>> ---
>> boot/android_ab.c | 16 ++--
>> 1 file changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/boot/android_ab
for Android AVB.
Signed-off-by: Mattijs Korpershoek
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3c73d8c35c4a..4978470c1664 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -70,6 +70,7 @@ F:test/py/tests/test_android/test_ab.py
ANDROID AVB
M
101 - 200 of 493 matches
Mail list logo
