Re: [PATCH v1 3/5] cmd: optee_rpmb: build cmd for sandbox

2024-02-15 Thread Mattijs Korpershoek
11 bytes > => optee_rpmb read_pvalue test_variable 11 > Read 11 bytes, value = test_value > > Signed-off-by: Igor Opaniuk Reviewed-by: Mattijs Korpershoek Tested-by: Mattijs Korpershoek # on sandbox > --- > > cmd/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 del

Re: [RFC PATCH v2 2/2] board: ad401: example of fastboot oem board realization

2024-02-15 Thread Mattijs Korpershoek
On jeu., févr. 01, 2024 at 12:20, Alexey Romanov wrote: > An example of how we use fastboot oeam board subcommand > for Sean Anderson. > > 1 - OEM_BOARD_WRITE_BOOTLOADER_CMD: > > We use it for custom Amlogic bootloader + tpl > flashing protocol. > > 2 - OEM_BOARD_ERASE_CMD: > > Custom logic for

Re: [RFC PATCH v2 1/2] fastboot: introduce 'oem board' subcommand

2024-02-15 Thread Mattijs Korpershoek
Hi Alexey, Thank you for the patch. On jeu., févr. 01, 2024 at 12:20, Alexey Romanov wrote: > Currently, fastboot protocol in U-Boot has no opportunity > to execute vendor custom code with verifed boot. This patch > introduce new fastboot subcommand fastboot oem board:, > which allow to run

Re: [AVB/AB] Overhaul plans

2024-02-14 Thread Mattijs Korpershoek
Hi Igor, On Fri, Feb 09, 2024 at 17:17, Igor Opaniuk wrote: > Hello Mattijs, > > On Fri, Feb 9, 2024 at 11:30 AM Mattijs Korpershoek > wrote: >> >> Hi Igor, >> >> On ven., févr. 09, 2024 at 11:14, Igor Opaniuk >> wrote: >> >> > Hi

Re: [PATCH v2 0/7] AVB: cosmetic adjustments/improvements

2024-02-13 Thread Mattijs Korpershoek
Hi, On Fri, 09 Feb 2024 20:20:38 +0100, Igor Opaniuk wrote: > This is the first patch series for incoming major > improvements for AVB implementation, that include: > - Simplify and add more context for debug/error prints where it's needed. > - Move SPDX license identifiers to the first line, so

Re: [RESEND PATCH v1] MAINTAINERS: add custodian tree info for AVB/AB

2024-02-13 Thread Mattijs Korpershoek
Hi, On Tue, 13 Feb 2024 08:36:38 +0100, Igor Opaniuk wrote: > Add information about a custodian tree [1] for AVB/AB, which is > maintained by Mattijs Korpershoek. > > [1] https://source.denx.de/u-boot/custodians/u-boot-dfu > > Thanks, Applied to https://source.denx.de/u-boot

Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-13 Thread Mattijs Korpershoek
Hi Igor, On mar., févr. 13, 2024 at 12:19, Igor Opaniuk wrote: > Hi Mattijs, > > On Tue, Feb 13, 2024 at 9:13 AM Mattijs Korpershoek > wrote: >> >> Hi Igor, >> >> On lun., févr. 12, 2024 at 09:05, Igor Opaniuk >> wrote: >> >> > Hi Dan

Re: [PATCH v1] MAINTAINERS: add custodian tree info for AV/AVB

2024-02-13 Thread Mattijs Korpershoek
Hi Marek, Thank you for your review. On mar., févr. 13, 2024 at 12:55, Marek Vasut wrote: > On 2/13/24 08:32, Igor Opaniuk wrote: >> From: Igor Opaniuk >> >> Add information about a custodian tree [1] for AVB/AB, which is >> maintained by Mattijs Ko

Re: [RESEND PATCH v1] MAINTAINERS: add custodian tree info for AVB/AB

2024-02-13 Thread Mattijs Korpershoek
Hi Igor, Thank you for the patch. On mar., févr. 13, 2024 at 08:36, Igor Opaniuk wrote: > From: Igor Opaniuk > > Add information about a custodian tree [1] for AVB/AB, which is > maintained by Mattijs Korpershoek. > > [1] https://source.denx.de/u-boot/custodians/u-boo

Re: [PATCH v2 7/7] doc: android: avb: sync usage details

2024-02-13 Thread Mattijs Korpershoek
Hi Igor, Thank you for the patch. On ven., févr. 09, 2024 at 20:20, Igor Opaniuk wrote: > From: Igor Opaniuk > > Sync usage info with the one cmd/avb.c. > > Signed-off-by: Igor Opaniuk Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: > - Address Matti

Re: [PATCH v2 4/7] cmd: avb: rework prints

2024-02-13 Thread Mattijs Korpershoek
Hi Igor, Thank you for the patch. On ven., févr. 09, 2024 at 20:20, Igor Opaniuk wrote: > From: Igor Opaniuk > > Simplify and add more context for prints where it's needed. > > Signed-off-by: Igor Opaniuk Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2

Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-13 Thread Mattijs Korpershoek
Hi Igor, On lun., févr. 12, 2024 at 09:05, Igor Opaniuk wrote: > Hi Dan, > > On Mon, Feb 12, 2024 at 8:05 AM Dan Carpenter > wrote: >> >> On Fri, Feb 09, 2024 at 08:20:39PM +0100, Igor Opaniuk wrote: >> > From: Igor Opaniuk >> > >> > mmc_switch_part() is used for switching between hw

[GIT PULL] Please pull u-boot-dfu-20240209

2024-02-09 Thread Mattijs Korpershoek
additions (AVB, AB) of myself to the MAINTAINERS file Mattijs Korpershoek (2): MAINTAINERS: add Mattijs for Android AB MAINTAINERS: add Mattijs for Android AVB Sean Anderson (1): lib: sparse: Fix error checking

Re: [AVB/AB] Overhaul plans

2024-02-09 Thread Mattijs Korpershoek
Hi Igor, On ven., févr. 09, 2024 at 11:14, Igor Opaniuk wrote: > Hi everyone, > > I'm currently planning a big overhaul of the current implementation of > AVB/AB in U-Boot during the 2024 year, which I have barely touched since > 2019. I used to believe that it was stillborn, but looks like

Re: [PATCH v1 6/7] cmd: avb: rework do_avb_verify_part

2024-02-09 Thread Mattijs Korpershoek
setting correct > androidboot.verifiedbootstate kernel cmdline parameter. > > Signed-off-by: Igor Opaniuk Reviewed-by: Mattijs Korpershoek Nitpick: the error handling migration could have been part of PATCH 5/7 but it's fine to keep as is. > --- > > cmd/avb.c | 50 +--

[PATCH] configs: khadas-vim3*_android: fix AVB oom error

2024-02-09 Thread Mattijs Korpershoek
36e9f8 ("Convert CONFIG_SYS_MALLOC_LEN to Kconfig") Add it back to fix AVB verification on VIM3/VIM3L. Fixes: 7cfbba36e9f8 ("Convert CONFIG_SYS_MALLOC_LEN to Kconfig") Co-developed-by: Guillaume La Roque Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- configs/k

Re: [PATCH v1 7/7] doc: android: avb: add slot_suffix param details

2024-02-08 Thread Mattijs Korpershoek
Hi Igor, Thank you for the patch. On mar., févr. 06, 2024 at 23:31, Igor Opaniuk wrote: > From: Igor Opaniuk > > Add info about slot_suffix param for avb verify. > > Signed-off-by: Igor Opaniuk > --- > > doc/android/avb2.rst | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) >

Re: [PATCH v1 5/7] common: avb_verify: add str_avb_io_error/str_avb_slot_error

2024-02-08 Thread Mattijs Korpershoek
Hi Igor, Thank you for the patch. On mar., févr. 06, 2024 at 23:31, Igor Opaniuk wrote: > From: Igor Opaniuk > > Introduce str_avb_io_error() and str_avb_slot_error() functions, > that provide a pointer to AVB runtime error message. > > Signed-off-by: Igor Opaniuk Re

Re: [PATCH v1 4/7] cmd: avb: rework prints

2024-02-08 Thread Mattijs Korpershoek
Hi Igor, Thank you for the patch. On mar., févr. 06, 2024 at 23:31, Igor Opaniuk wrote: > From: Igor Opaniuk > > Introduce AVB_OPS_CHECK macro for checking AvbOps before using > it to avoid code duplication. > Simplify and add more context for prints where it's needed. > > Signed-off-by:

Re: [PATCH v1 3/7] common: avb_verify: rework error/debug prints

2024-02-08 Thread Mattijs Korpershoek
-off-by: Igor Opaniuk Reviewed-by: Mattijs Korpershoek > --- > > common/avb_verify.c | 31 ++- > 1 file changed, 18 insertions(+), 13 deletions(-) > > diff --git a/common/avb_verify.c b/common/avb_verify.c > index 938a5383b5d..ed58239cf8a 100644

Re: [PATCH v1 2/7] avb: move SPDX license itdentifiers to the first line

2024-02-08 Thread Mattijs Korpershoek
gt; > [1] https://www.kernel.org/doc/Documentation/process/license-rules.rst > > Signed-off-by: Igor Opaniuk Reviewed-by: Mattijs Korpershoek Nitpick in the title: itdentifiers -> identifiers. If no other remarks in the series, will fix when applying. > --- > >

Re: [PATCH v1 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-08 Thread Mattijs Korpershoek
-off-by: Igor Opaniuk Reviewed-by: Mattijs Korpershoek > --- > > common/avb_verify.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/common/avb_verify.c b/common/avb_verify.c > index 48ba8db51e5..59f2c25e0de 100644 > --- a/common/avb_ver

Re: [PATCH v4 5/7] configs: am62x_evm_*: Enable USB and DFU support

2024-02-08 Thread Mattijs Korpershoek
Hi Sjoerd, Thank you for the patch. On ven., janv. 12, 2024 at 09:52, Sjoerd Simons wrote: > Enable USB host as well as USB gadget and DFU support for a53; For the > r5 due to the smaller available size create a config fragment for DFU > supports which disables support for persistent storage

Re: [PATCH] lib: sparse: Fix error checking for write_sparse_chunk_raw

2024-02-06 Thread Mattijs Korpershoek
Hi, On Thu, 01 Feb 2024 13:18:51 -0500, Sean Anderson wrote: > The return value of write_sparse_chunk_raw is unsigned, so the existing > check has no effect. Use IS_ERR_VALUE to detect error instead, which is > what write_sparse_chunk_raw does itself. > > Thanks, Applied to

Re: [PATCH 1/5] usb: dwc3-generic: implement Qualcomm wrapper

2024-02-02 Thread Mattijs Korpershoek
Hi Caleb, On Thu, Feb 01, 2024 at 14:24, Caleb Connolly wrote: > On 01/02/2024 09:34, Mattijs Korpershoek wrote: >> Hi Caleb, >> >> Thank you for the patch. >> >> On mer., janv. 31, 2024 at 14:57, Caleb Connolly >> wrote: >> >>> The Q

Re: [PATCH] lib: sparse: Fix error checking for write_sparse_chunk_raw

2024-02-02 Thread Mattijs Korpershoek
> > Fixes: 62649165cb0 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") > Reported-by: Dan Carpenter > Link: > https://lore.kernel.org/u-boot/1b323ec3-59b0-490b-a2f0-fd961dafcf49@moroto.mountain/ > Signed-off-by: Sean Anderson Reviewed-by: Mattijs Korpershoek > ---

Re: [PATCH 5/5] iommu: qcom-smmu: fix debugging

2024-02-01 Thread Mattijs Korpershoek
Hi Caleb, Thank you for the patch. On mer., janv. 31, 2024 at 14:57, Caleb Connolly wrote: > The priv struct was wrong in dump_boot_mappings(). Causing errors when > compiling with -DDEBUG. Fix this. > > Signed-off-by: Caleb Connolly Reviewed-by: Mattijs Korpershoek > --- &

Re: [PATCH 4/5] usb: gadget: UMS: support multiple sector sizes

2024-02-01 Thread Mattijs Korpershoek
Hi Caleb, Thank you for the patch. On mer., janv. 31, 2024 at 14:57, Caleb Connolly wrote: > UFS storage often uses a 4096-byte sector size, add support for dynamic > sector sizes based loosely on the Linux implementation. > > Signed-off-by: Caleb Connolly Reviewed-by: Mattijs

Re: [PATCH 3/5] usb: gadget: CDC ACM: call usb_gadget_initialize

2024-02-01 Thread Mattijs Korpershoek
> Signed-off-by: Caleb Connolly Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/f_acm.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/gadget/f_acm.c > index de42e0189e8d..ba216128ab27 100644 > ---

Re: [PATCH 2/5] usb: dwc3: select DM_USB_GADGET

2024-02-01 Thread Mattijs Korpershoek
Caleb Connolly Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/dwc3/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig > index c0c8c16fd9c2..8a70bc682322 100644 > --- a/drivers/usb/dwc3/Kconfig > +++ b/dr

Re: [PATCH 1/5] usb: dwc3-generic: implement Qualcomm wrapper

2024-02-01 Thread Mattijs Korpershoek
Hi Caleb, Thank you for the patch. On mer., janv. 31, 2024 at 14:57, Caleb Connolly wrote: > The Qualcomm specific dwc3 wrapper isn't hugely complicated, implemented > the missing initialisation for host and gadget mode. > > Signed-off-by: Caleb Connolly > --- >

Re: [PATCH v4 4/7] arm: dts: k3-am625-sk: Enable usb port in u-boot

2024-01-16 Thread Mattijs Korpershoek
Hi Sjoerd Thank you for the patch. On ven., janv. 12, 2024 at 09:52, Sjoerd Simons wrote: > Enable usb0 in all boot phases for use with DFU > > Signed-off-by: Sjoerd Simons > > --- > > Changes in v4: > - Don't force usb0 into peripheral mode I know that dr_mode = "peripheral" has been

Re: [PATCH v4 7/7] doc: board: Add document for DFU boot on am62x SoCs

2024-01-16 Thread Mattijs Korpershoek
> +uploaded one by one with a tool like dfu-util. > + > +.. am62x_evm_rst_include_start_dfu_boot > + > +The initial ROM will have a DFU alt named `bootloader` for the initial R5 spl > +upload. The next stages as exposed by u-boot have target alts matching the > name s/u-boo

Re: [PATCH v4 3/7] board: ti: am62x: am62x: include env for DFU

2024-01-16 Thread Mattijs Korpershoek
Hi Sjoerd, Thank you for the patch. On ven., janv. 12, 2024 at 09:52, Sjoerd Simons wrote: > Include standard TI K3 dfu environment > > Signed-off-by: Sjoerd Simons Reviewed-by: Mattijs Korpershoek > > --- > > (no changes since v3) > > Changes in v3: > -

Re: [PATCH v4 2/7] usb: dwc3: Switch to device mode on gadget start

2024-01-16 Thread Mattijs Korpershoek
Hi Sjoerd, Caleb On ven., janv. 12, 2024 at 12:55, Caleb Connolly wrote: > Hi Sjoerd, > > On 12/01/2024 08:52, Sjoerd Simons wrote: >> When dr_mode is "otg" the dwc3 is initially configured in _OTG mode; >> However in this mode the gadget functionality doesn't work without >> further

Re: [PATCH v4 2/7] usb: dwc3: Switch to device mode on gadget start

2024-01-16 Thread Mattijs Korpershoek
gadget start switch to _DEVICE > mode globally and go back to _OTG on stop again. > > For this the dwc3_set_mode is renamed to dwc3_core_set_mode to avoid a > conflict with the same function exposed by xhci-dwc3 > > Signed-off-by: Sjoerd Simons Reviewed-by: Mattijs Korpershoek

Re: [PATCH v4 1/7] usb: dwc3: Add dwc3 glue driver for am62

2024-01-16 Thread Mattijs Korpershoek
if (IS_ERR(syscon)) { > + dev_err(dev, "unable to get ti,syscon-phy-pll-refclk regmap\n"); > + return; > + } > + > + ret = ofnode_parse_phandle_with_args(dev_ofnode(dev), > "ti,syscon-phy-pll-refclk", NULL, 1, > +

Re: [PATCH v4 0/7] Add DFU and usb boot for TI am62x SK and beagleplay

2024-01-16 Thread Mattijs Korpershoek
280 Err: serial@280 Net: No ethernet found. Press SPACE to abort autoboot in 2 seconds I've also tested (from the DFU'd U-Boot) that I could scan for usb keys: => usb start [..] 1 USB Device(s) found So for the series: Tested-by: Mattijs Korpershoek # on beagle play > > I wi

Re: [PATCH 0/2] MAINTAINERS: add Mattijs for Android AB / AVB

2024-01-16 Thread Mattijs Korpershoek
Hi, On Fri, 12 Jan 2024 09:40:43 +0100, Mattijs Korpershoek wrote: > Igor has not been active for quite some time on lore: > https://lore.kernel.org/all/?q=igor.opan...@gmail.com > > It seems that Android AB and AVB could use some help maintaining. > > I'm interested in helpin

Re: [PATCH 0/2] MAINTAINERS: add Mattijs for Android AB / AVB

2024-01-16 Thread Mattijs Korpershoek
Hi Tom, all, On ven., janv. 12, 2024 at 08:50, Tom Rini wrote: > On Fri, Jan 12, 2024 at 09:40:43AM +0100, Mattijs Korpershoek wrote: > >> Igor has not been active for quite some time on lore: >> https://lore.kernel.org/all/?q=igor.opan...@gmail.com >> >> It seems

Re: [PATCH v4 7/7] doc: board: Add document for DFU boot on am62x SoCs

2024-01-12 Thread Mattijs Korpershoek
Hi Sjoerd, Nishanth, On Fri, Jan 12, 2024 at 13:58, Sjoerd Simons wrote: > On Fri, 2024-01-12 at 06:36 -0600, Nishanth Menon wrote: >> On 09:52-20240112, Sjoerd Simons wrote: >> > >> > +DFU based boot >> > +-- >> > + >> > +To boot the board over DFU, ensure there is no SD card

Re: [PATCH v2] android_ab: don't ignore ab_control_store return code

2024-01-12 Thread Mattijs Korpershoek
he error code to the caller. >> >> Signed-off-by: Alexey Romanov >> Reviewed-by: Mattijs Korpershoek >> --- >> boot/android_ab.c | 16 ++-- >> 1 file changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/boot/android_ab

[PATCH 2/2] MAINTAINERS: add Mattijs for Android AVB

2024-01-12 Thread Mattijs Korpershoek
for Android AVB. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3c73d8c35c4a..4978470c1664 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -70,6 +70,7 @@ F:test/py/tests/test_android/test_ab.py ANDROID AVB M

[PATCH 1/2] MAINTAINERS: add Mattijs for Android AB

2024-01-12 Thread Mattijs Korpershoek
AB. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4fec063a242f..3c73d8c35c4a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -59,6 +59,7 @@ F:lib/acpi/ ANDROID AB M: Igor Opaniuk +M: Mattijs

[PATCH 0/2] MAINTAINERS: add Mattijs for Android AB / AVB

2024-01-12 Thread Mattijs Korpershoek
is still doing android work. Add myself as maintainer for Android AB and for Android AVB. Note: the patches are split because I discussed taking over AB privately with Sam, but I did not discuss taking over AVB. Signed-off-by: Mattijs Korpershoek --- Mattijs Korpershoek (2): MAINTAINERS

[GIT PULL] Please pull u-boot-dfu-20240111

2024-01-11 Thread Mattijs Korpershoek
Hi Tom, Here are some developments for master including: - Implement fastboot multi-response. This allows multi-line response and most importantly, finally adds support for fastboot getvar all command. - New 'fastboot oem console' command. Useful for debugging to send data the u-boot shell

Re: [PATCH v1] fastboot: introduce 'oem board' subcommand

2024-01-11 Thread Mattijs Korpershoek
Hi Alexey, Sean, On mer., janv. 10, 2024 at 08:03, Alexey Romanov wrote: > Hi, > > On Tue, Jan 09, 2024 at 10:45:46AM -0500, Sean Anderson wrote: >> On 1/9/24 05:27, Alexey Romanov wrote: >> > Hello Sean! >> > >> > Thanks for you reply. >> > >> > On Thu, Dec 28, 2023 at 11:45:04AM -0500,

Re: [PATCH v7 0/7] Implement fastboot multiresponce

2024-01-09 Thread Mattijs Korpershoek
Hi, On Fri, 05 Jan 2024 09:22:05 +0200, Svyatoslav Ryhel wrote: > Currently u-boot fastboot can only send one message back to host, > so if there is a need to print more than one line messages must be > kept sending until all the required data is obtained. This behavior > can be adjusted using

Re: [PATCH] doc: fix three-dash references in reStructuredText

2024-01-09 Thread Mattijs Korpershoek
ent > its conversion; that is, enclose it in a pair of double backquotes (`). > > Signed-off-by: Grzegorz Szymaszek Reviewed-by: Mattijs Korpershoek > --- > doc/develop/sending_patches.rst | 4 ++-- > tools/patman/patman.rst | 2 +- > 2 files changed, 3 insertions(+

Re: [PATCH v7 7/7] test: hush: dollar: fix bagous behavior

2024-01-09 Thread Mattijs Korpershoek
Hi Svyatoslav, On mar., janv. 09, 2024 at 15:57, Svyatoslav wrote: > 9 січня 2024 р. 15:54:32 GMT+02:00, Mattijs Korpershoek > написав(-ла): >>Hi Svyatoslav, >> >>Thank you for the patch. >> >>On ven., janv. 05, 2024 at 09:22, Svyatoslav Ry

Re: [PATCH 2/2] include: env: ti: add default for do_main_cpsw0_qsgmii_phyinit

2024-01-09 Thread Mattijs Korpershoek
boot >## Error: "main_cpsw0_qsgmii_phyinit" not defined >[...] > > Fixes: 0d72b0f2f83b ("include: env: ti: ti_common: Run > main_cpsw0_qsgmii_phyinit conditionally") > > Signed-off-by: Manorit Chawdhry Reviewed-by: Mattijs Korpershoek > --- > include/env/

Re: [PATCH 1/2] include: env: ti: ti_common: Fix a missing semicolon

2024-01-09 Thread Mattijs Korpershoek
("include: env: ti: ti_common: Run > main_cpsw0_qsgmii_phyinit conditionally") > > Signed-off-by: Manorit Chawdhry Reviewed-by: Mattijs Korpershoek > --- > include/env/ti/ti_common.env | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [PATCH v7 7/7] test: hush: dollar: fix bagous behavior

2024-01-09 Thread Mattijs Korpershoek
ut_assert_skipline(); > ut_assert_console_end(); > > Same thing should be done with the if block mentioned above that calls > console_record_reset_enable(). > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel I confirm this fixes the problem repo

Re: [PATCH v6 0/6] Implement fastboot multiresponce

2024-01-09 Thread Mattijs Korpershoek
ord_reset_enable(). That makes sense. Thank you for looking into this. I see that Svyatoslav included your suggestion in https://patchwork.ozlabs.org/project/uboot/patch/20240105072212.6615-8-clamo...@gmail.com/ I will review it there. > > Regards, > Ion > > El jue, 4 ene 2024 a l

Re: [PATCH v6 4/6] common: console: record console from the beginning

2024-01-04 Thread Mattijs Korpershoek
Hi Simon, On mer., janv. 03, 2024 at 18:38, Simon Glass wrote: > Hi Mattijs, > > On Wed, Jan 3, 2024 at 5:41 AM Mattijs Korpershoek > wrote: >> >> Hi Simon, >> >> On Tue, Jan 02, 2024 at 07:06, Simon Glass wrote: >> >> > Hi Mattijs, >>

Re: [PATCH v6 0/6] Implement fastboot multiresponce

2024-01-04 Thread Mattijs Korpershoek
Hello Svyatoslav, On jeu., déc. 28, 2023 at 20:01, Svyatoslav Ryhel wrote: > Currently u-boot fastboot can only send one message back to host, > so if there is a need to print more than one line messages must be > kept sending until all the required data is obtained. This behavior > can be

Re: [PATCH v6 4/6] common: console: record console from the beginning

2024-01-03 Thread Mattijs Korpershoek
Hi Simon, On Tue, Jan 02, 2024 at 07:06, Simon Glass wrote: > Hi Mattijs, > > On Tue, Jan 2, 2024 at 2:52 AM Mattijs Korpershoek > wrote: >> >> Hi Simon, Svyatoslav, >> >> On Thu, Dec 28, 2023 at 21:52, Svyatoslav Ryhel wrote: >> >>

[PATCH] doc: dfu: fix a handful of typos

2024-01-03 Thread Mattijs Korpershoek
Reword some sentences, add missing periods and fix various typos in the dfu documentation. This was originally contributed on [1] [1] https://github.com/Maalobs/u-boot/commit/9a21ed8ba722d904b68945f40ca6697b4b1cc4d4 Signed-off-by: Mattijs Korpershoek --- The author wished to remain anonymous

Re: [PATCH v1 12/12] fastboot: fb_nand: add missing newlines in pr_err() macro

2024-01-02 Thread Mattijs Korpershoek
Hi Alexey, Thank you for the patch. On Thu, Dec 28, 2023 at 18:39, Alexey Romanov wrote: > pr_err() doesn't add an newline symbol when printing. > > Signed-off-by: Alexey Romanov Reviewed-by: Mattijs Korpershoek > --- > drivers/fastboot/fb_nand.c | 10 +- >

Re: [PATCH v1 11/12] fastboot: enable FASTBOOT_FLASH option for SPI NAND devices

2024-01-02 Thread Mattijs Korpershoek
Hi Alexey, Thank you for the patch. On Thu, Dec 28, 2023 at 18:39, Alexey Romanov wrote: > From now we can use FASTBOOT_FLASH_NAND option for SPI NAND. > > Signed-off-by: Alexey Romanov Reviewed-by: Mattijs Korpershoek > --- > drivers/fastboot/Kconfig | 4 ++-- >

Re: [PATCH v1 10/12] fastboot: check device type for SPI NAND too

2024-01-02 Thread Mattijs Korpershoek
Hi Alexey, Thank you for the patch. On Thu, Dec 28, 2023 at 18:39, Alexey Romanov wrote: > SPI NAND devices also supports 'fastboot erase / flash' commands. > > Signed-off-by: Alexey Romanov Reviewed-by: Mattijs Korpershoek > --- > drivers/fastboot/fb_nand.c | 2 +- >

Re: [PATCH v6 4/6] common: console: record console from the beginning

2024-01-02 Thread Mattijs Korpershoek
lag to enable console record on console_record_init >> > and not only on console_record_reset_enable. This fixes >> > missing start of U-Boot log for fastboot oem console >> > command. >> > >> > Signed-off-by: Ion Agorria >> > Signed-off-by: Svyatoslav R

[PATCH v2] MAINTAINERS: Fix ANDROID AB unknown file entry

2023-12-21 Thread Mattijs Korpershoek
Commit 19a91f2464a8 ("Create a new boot/ directory") moved the android_ab.c code under boot/android_ab but did not update the MAINTAINERS entry. Update it so that the maintainer will get cc'ed again. Fixes: 19a91f2464a8 ("Create a new boot/ directory") Signed-off-by:

Re: [PATCH] MAINTAINERS: Fix ANDROID AB unknown file entry

2023-12-21 Thread Mattijs Korpershoek
Hi Sam, Thank you for your review. On Thu, Dec 21, 2023 at 08:15, Sam Protsenko wrote: > Hi Mattijs, > > On Wed, Dec 20, 2023 at 10:43 AM Mattijs Korpershoek > wrote: >> >> Commit 19a91f2464a8 ("Create a new boot/ directory") moved the >> android

Re: [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally

2023-12-20 Thread Mattijs Korpershoek
ii_phyinit command is run > only for such SoCs. > > Signed-off-by: Manorit Chawdhry > Signed-off-by: Siddharth Vadapalli Reviewed-by: Mattijs Korpershoek > --- > > Hello, > > This patch is based on commit > 65eed68772 test/py: Disable error E0611 in two cases for pyli

Re: [PATCH v1] android_ab: don't ignore ab_control_store return code

2023-12-20 Thread Mattijs Korpershoek
free(abc); > + log_err("ANDROID: failed to store boot control block: > %d\n", ret); Same here With that addressed: Reviewed-by: Mattijs Korpershoek > + return ret; > + } > } > free(backup_abc); > #endif > -- > 2.39.2

[PATCH] MAINTAINERS: Fix ANDROID AB unknown file entry

2023-12-20 Thread Mattijs Korpershoek
Commit 19a91f2464a8 ("Create a new boot/ directory") moved the android_ab.c code under boot/android_ab but did not update the MAINTAINERS entry. Update it so that the maintainer will get cc'ed again. Signed-off-by: Mattijs Korpershoek --- MAINTAINERS | 2 +- 1 file changed, 1 inser

Re: [PATCH v2] clk: fix clk_get_rate() always return ulong

2023-12-15 Thread Mattijs Korpershoek
> > Signed-off-by: Julien Masson Reviewed-by: Mattijs Korpershoek > --- > Changes in v2: > - remove local var ret (fix warning) > - Link to v1: https://lore.kernel.org/all/871qcj5frz@baylibre.com > --- > drivers/clk/clk-uclass.c | 7 +-- > 1 file changed, 1 i

Re: [PATCH] clk: fix clk_get_rate() always return ulong

2023-12-15 Thread Mattijs Korpershoek
On ven., déc. 15, 2023 at 13:34, Mattijs Korpershoek wrote: > Hi Julien, > > Thank you for the patch. > > On mar., nov. 21, 2023 at 15:42, Julien Masson wrote: > >> When we call clk_get_rate(), we expect to get clock rate value as >> ulong. >> In that ca

Re: [PATCH] clk: fix clk_get_rate() always return ulong

2023-12-15 Thread Mattijs Korpershoek
happens when log_reg is enabled via CONFIG_LOG_ERROR_RETURN. > Otherwise we may return an invalid/truncated clock rate value. > > Signed-off-by: Julien Masson I'm wondering if there are any other places where this happens, but this change looks good to me. Reviewed-by: Mattijs Korpersho

Re: [PATCH v2 09/16] doc: Mention fastboot dependency on CMDLINE

2023-12-15 Thread Mattijs Korpershoek
Rini Reviewed-by: Mattijs Korpershoek > --- > > (no changes since v1) > > doc/android/fastboot.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/doc/android/fastboot.rst b/doc/android/fastboot.rst > index 1ad8a897c853..933a652538c7 100644 > --- a

Re: [PATCH v2 08/16] fastboot: Remove dependencies on CMDLINE

2023-12-15 Thread Mattijs Korpershoek
lass Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: > - Avoid changing the logic when a command is not set > > drivers/fastboot/Kconfig | 1 - > drivers/fastboot/fb_common.c | 30 ++ > 2 files changed, 14 insertions(+), 17 deletio

Re: [PATCH v2 11/21] bootm: Move do_bootm_states() comment to header file

2023-12-15 Thread Mattijs Korpershoek
Hi Simon, Thank you for the patch. On jeu., déc. 14, 2023 at 09:50, Simon Glass wrote: > This is an exported function, so move the function comment to the > bootm.h header file. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2

Re: [PATCH v2 06/21] bootm: Adjust how the board is reset

2023-12-15 Thread Mattijs Korpershoek
m command. > > Signed-off-by: Simon Glass > Reviewed-by: Tom Rini Reviewed-by: Mattijs Korpershoek > --- > > (no changes since v1) > > boot/bootm.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/boot/bootm.c b/boot/bootm.c

Re: [PATCH 06/14] fastboot: Change fastboot_buf_addr to an address

2023-12-06 Thread Mattijs Korpershoek
On Tue, Dec 05, 2023 at 20:54, Simon Glass wrote: > Hi Mattijs, > > On Tue, 5 Dec 2023 at 02:16, Mattijs Korpershoek > wrote: >> >> Hi Simon, >> >> Thank you for your patch. >> >> On dim., déc. 03, 2023 at 17:31, Simon Glass wrote: &g

Re: [PATCH 3/6] dt-bindings: power: add power-domain header for MediaTek MT8365 SoC

2023-12-05 Thread Mattijs Korpershoek
Hi Julien, Thank you for your patch. On lun., déc. 04, 2023 at 11:48, Julien Masson wrote: > Add power-domain header for MediaTek MT8365 SoC copied from Linux > source code tag v6.7-rc2. > (commit a1571f1f333c2fced076f0d54ed771d1838d827f) > > Signed-off-by: Julien Masson Revie

Re: [PATCH 2/6] clk: mediatek: add clock driver support for MediaTek MT8365 SoC

2023-12-05 Thread Mattijs Korpershoek
les: > - clk-mt8365.c (a96cbb146a9736f501fe66ebda6a9018735e5e8a) > - clk-mt8365-apmixedsys.c (65c9ad77cbc0eed78db94d80041aba675cfbdfa9) > And adapted following the clk attributes supported by U-Boot. > > Signed-off-by: Julien Masson Reviewed-by: Mattijs Korpershoek > --- > driver

Re: [PATCH 1/6] dt-bindings: clock: add Mediatek MT8365 SoC clock bindings

2023-12-05 Thread Mattijs Korpershoek
; +#define CLK_TOP_VPLL_DPIX_EN 133 > +#define CLK_TOP_SSUSB_TOP_CK_EN 134 > +#define CLK_TOP_SSUSB_PHY_CK_EN 135 > +#define CLK_TOP_CONN_32K 136 > +#define CLK_TOP_CONN_26M 137 > +#define CLK_TOP_DSP_32K

Re: [PATCH 06/14] fastboot: Change fastboot_buf_addr to an address

2023-12-05 Thread Mattijs Korpershoek
reflash AOSP on the Khadas VIM 3 board. Tested-by: Mattijs Korpershoek # on vim3 Reviewed-by: Mattijs Korpershoek Some small nit/question below. > --- > > cmd/fastboot.c| 2 +- > drivers/fastboot/fb_command.c | 13 - > drivers/fastboot/fb_common.c | 15

[GIT PULL] Please pull u-boot-dfu-next-20231124

2023-11-24 Thread Mattijs Korpershoek
Hi Tom, Here are some developments for next including: - Make dfu entity name size configurable in KConfig - Implement start-stop for UMS (graceful shutdown via eject) - Improve help messages for cmd/bind - Improve help message for udc bind failures The CI job is at

[GIT PULL] Please pull u-boot-dfu-20231124

2023-11-24 Thread Mattijs Korpershoek
Hi Tom, Here are some fixes for master including: - Fix reinit for ChipIdea controller - Add missing newline in fastboot error handling This CI job is at https://source.denx.de/u-boot/custodians/u-boot-dfu/-/pipelines/18703 Thanks, Mattijs The following changes since commit

[PATCH] doc: sending_patches.rst: s/Superseeded/Superseded

2023-11-21 Thread Mattijs Korpershoek
This is a common typo listed in scripts/spelling.txt. Fix it to match the patchwork status, which is superseded. Signed-off-by: Mattijs Korpershoek --- doc/develop/sending_patches.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/develop/sending_patches.rst b/doc

Re: [PATCH v3 0/3] Improve the experience with USB gadgets

2023-11-21 Thread Mattijs Korpershoek
Hi, On Tue, 10 Oct 2023 11:03:01 +0200, Miquel Raynal wrote: > Try to ease the use of USB gadgets for people not fully aware of all the > terms and constraints. With more helpful error messages a little bit of > guidance anyone should be able to adapt to the bind/unbind game that is > now

Re: [PATCH v5 05/12] usb: Avoid unbinding devices in use by bootflows

2023-11-21 Thread Mattijs Korpershoek
Rathore > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek > --- > > Changes in v5: > - Adjust motivation for patch, since the EFI hang is fixed > > Changes in v4: > - Don't rename the legacy-USB functions > - Add a bit more detail to the comment > > Ch

Re: [PATCH v2 2/5] fastboot: implement "getvar all"

2023-11-21 Thread Mattijs Korpershoek
es fastboot multiresponse. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel > Reviewed-by: Mattijs Korpershoek > --- > doc/android/fastboot-protocol.rst | 3 ++ > drivers/fastboot/fb_command.c | 3 ++ > drivers/fastboot/fb_getvar.c | 75 ++

Re: [PATCH V2 0/4] arm: dts: k3-am625*: Upgrade kernel dts to v6.7-rc1

2023-11-21 Thread Mattijs Korpershoek
> arm: dts: k3-am625-beagleplay-u-boot: drop duplicate bootph-nodes > arm: dts: k3-am625-sk-r5/u-boot: Drop duplicate bootph-nodes Boot tested eMMC boot on AM62 SK EVM. For the whole series: Tested-by: Mattijs Korpershoek # am625 sk > > arch/arm/dts/k3-am62-main.dtsi

Re: [PATCH v2 5/5] fastboot: add oem console command support

2023-11-21 Thread Mattijs Korpershoek
Hi Svyatoslav, Thank you for your patch On mer., nov. 15, 2023 at 17:38, Svyatoslav Ryhel wrote: > From: Ion Agorria > > "oem console" serves to read console record buffer. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattij

Re: [PATCH v2 4/5] lib: membuff: fix readline not returning line in case of overflow

2023-11-21 Thread Mattijs Korpershoek
rria > Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek > --- > boot/bootmeth_extlinux.c | 2 +- > common/console.c | 2 +- > include/membuff.h| 5 +++-- > lib/membuff.c| 4 ++-- > 4 files changed, 7 insertions(+), 6 deletions(-) > >

Re: [PATCH v2 3/5] common: console: introduce overflow and isempty calls

2023-11-21 Thread Mattijs Korpershoek
| console_record_reset The following diff fixes it: diff --git a/include/console.h b/include/console.h index c053bc9ba82c..b5adae740650 100644 --- a/include/console.h +++ b/include/console.h @@ -145,6 +145,12 @@ static inline int console_in_puts(const char *

Re: [PATCH v2 1/5] fastboot: multiresponse support

2023-11-21 Thread Mattijs Korpershoek
ll the required data is obtained. This behavior > can be adjusted using multiresponce ability (getting multiple lines > of response) proposed in this patch. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek > --- >

Re: [PATCH v2 1/2] usb: ci: Fix gadget reinit

2023-11-21 Thread Mattijs Korpershoek
Hi, On Mon, 20 Nov 2023 01:08:34 +0100, Simon Holesch wrote: > The ChipIdea device controller wasn't properly cleaned up when disabled. > So enabling it again left it in a broken state. The problem occurred for > example when the host unbinds the driver and binds it again. > > During the first

Re: [PATCH v2 2/2] usb: fastboot: Add missing newline in pr_err

2023-11-21 Thread Mattijs Korpershoek
Hi Marek, On lun., nov. 20, 2023 at 03:07, Marek Vasut wrote: > On 11/20/23 01:08, Simon Holesch wrote: >> Add missing newline in pr_err. >> >> Signed-off-by: Simon Holesch >> Reviewed-by: Marek Vasut >> --- >> >> Changes in v2: >> - add commit message body >> >> Thanks for the review! > >

Re: [PATCH v2 2/2] usb: fastboot: Add missing newline in pr_err

2023-11-21 Thread Mattijs Korpershoek
Hi Simon, Thank you for your patch. On lun., nov. 20, 2023 at 01:08, Simon Holesch wrote: > Add missing newline in pr_err. > > Signed-off-by: Simon Holesch > Reviewed-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: > - add commit

Re: [PATCH v2 1/2] usb: ci: Fix gadget reinit

2023-11-21 Thread Mattijs Korpershoek
er overflow". > > Fixed by clearing the primed buffers with the `epflush` (`ENDPTFLUSH`) > register. > > Signed-off-by: Simon Holesch > Reviewed-by: Marek Vasut Reviewed-by: Mattijs Korpershoek > --- > > Changes in v2: > - use wait_for_bit_le32(), clrbits_le32

Re: [PATCH v1 5/5] fastboot: add oem console command support

2023-11-14 Thread Mattijs Korpershoek
Hi Svyatoslav, On mar., nov. 14, 2023 at 12:30, Svyatoslav Ryhel wrote: > 14 листопада 2023 р. 12:24:52 GMT+02:00, Mattijs Korpershoek > написав(-ла): >>Hi Svyatoslav, >> >>Thank you for your patch. >> >>On mar., nov. 07, 2023 at 14:42, Svyatoslav Ry

Re: [PATCH v1 5/5] fastboot: add oem console command support

2023-11-14 Thread Mattijs Korpershoek
Hi Svyatoslav, Thank you for your patch. On mar., nov. 07, 2023 at 14:42, Svyatoslav Ryhel wrote: > From: Ion Agorria > > "oem console" serves to read console record buffer. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel > --- > doc/android/fastboot.rst | 1 + >

Re: [PATCH v1 2/5] fastboot: implement "getvar all"

2023-11-14 Thread Mattijs Korpershoek
es fastboot multiresponse. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel Some small comments below. With those addressed, please add: Reviewed-by: Mattijs Korpershoek > --- > doc/android/fastboot-protocol.rst | 3 ++ > drivers/fastboot/fb_command.c

Re: [PATCH v1 1/5] fastboot: multiresponse support

2023-11-14 Thread Mattijs Korpershoek
Hi Svyatoslav, Thank you for your patch. On mar., nov. 07, 2023 at 14:42, Svyatoslav Ryhel wrote: > From: Ion Agorria > > Currently u-boot fastboot can only send one message back to host, > so if there is a need to print more than one line messages must be > kept sending until all the

Re: [PATCH 0/2] cmd: bcb: extend BCB APIs to support Android boot flow

2023-11-14 Thread Mattijs Korpershoek
rev wrote: > Following patches introduce various block interfaces support > and extend API of BCB (bootloader control block) to reuse it > for Android boot flow of Cuttlefish virtual device. > > Signed-off-by: Dmitrii Merkurev > Cc: Eugeniu Rosca > Cc: Ying-Chun Liu (PaulLiu) &

Re: [PATCH v2 1/2] cmd: bcb: support various block device interfaces for BCB command

2023-11-14 Thread Mattijs Korpershoek
Cc: Eugeniu Rosca > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Cc: Mattijs Korpershoek > Cc: Sean Anderson > Cc: Cody Schuffelen I confirm that I can reboot from U-Boot into other modes (like fastbootd) using the default U-boot environment Tested-by: Mattijs Korpershoek

<    1   2   3   4   5   6   >