Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Michael Nazzareno Trimarchi
n > > this. > > I'm sorry I don't fully understand your answer. I assume you agree with > the generic approach quoted above. > > > If a clock is enabled by another stage and we don't aware about > > it we need to mark > > as enabled.

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Michael Nazzareno Trimarchi
renting. > > > > That's exactly the link above, whose diff is pasted here for reference: > > > > @@ -595,6 +595,10 @@ int clk_set_parent(struct clk *clk, struct clk *parent) > > if (!ops->set_parent) > > return -ENOSYS; > > >

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-10-01 Thread Michael Nazzareno Trimarchi
patch, which is more > future and platform agnostic, fixed it: > > https://lore.kernel.org/u-boot/20240910101344.110633-3-miquel.ray...@bootlin.com/ > The clock patches are not specific at all. You need to have it working for the parent for each component. This is a

Re: [PATCH 08/26] power: Add iMX8M block ctrl driver for dispmix

2024-09-30 Thread Michael Nazzareno Trimarchi
CRITICAL)); > >> > >> instead of using imx8m_clk_composite, and dropped my approach to > >> get clocks up and working. > >> > >> Also dropped my similiar approach for mediablock and used your > >> > >> power: Add iMX8M block c

Re: [PATCH v2 2/7] mtd: rawnand: brcmnand: Fix potential false time out warning

2024-09-29 Thread Michael Nazzareno Trimarchi
ase the CPU was busy and the > > driver > > + * did not get enough time to perform the polling to avoid false > > alarms > > + */ > > + val = brcmnand_read_reg(ctrl, BRCMNAND_INTFC_STATUS); > > + if ((val & mask) == expec

Re: [PATCH v2 1/7] mtd: rawnand: brcmnand: Fix ECC level field setting for v7.2 controller

2024-09-29 Thread Michael Nazzareno Trimarchi
l &= ~brcmnand_ecc_level_mask(ctrl); > + acc_control |= host->hwcfg.ecc_level << ctrl->ecc_level_shift; > } else { > acc_control &= ~ecc_flags; /* disable RD/WR ECC */ > acc_control &= ~brcmnand_ecc_level_mask(

Re: [PATCH 0/7] mtd: nand: brcmnand: Backported fixes from Linux

2024-09-27 Thread Michael Nazzareno Trimarchi
Hi Il sab 28 set 2024, 00:10 Linus Walleij ha scritto: > Hi Dario, > > On Wed, Sep 11, 2024 at 9:11 AM Linus Walleij > wrote: > > > These are a number of assorted upstream Linux fixes to the > > BRCMNAND driver that I have backported in an attempt to get > > BRCMBCA working with U-Boot (still n

Re: [PATCH v4 01/11] led: toggle LED on initial SW blink

2024-09-21 Thread Michael Nazzareno Trimarchi
call */ > - sw_blink->state = LED_SW_BLINK_ST_OFF; > + sw_blink->state = curr_state == LEDST_ON ? > LED_SW_BLINK_ST_OFF : > + LED_SW_BLINK_ST_ON; > return true; > } &g

Re: [PATCH 3/8] clk: imx8mp: Add media related clocks

2024-09-12 Thread Michael Nazzareno Trimarchi
ecessary code growth for those > who don't need > splash screen on i.MX8MP. I think that we can wait a bit on those patches, I will send my video series and try to arrange it back and rebase and work together with Miquel Michael -- Michael Nazzareno Trimarchi Co-Founder & Chief

Re: [PATCH 0/8] Add imx8mp video support

2024-09-11 Thread Michael Nazzareno Trimarchi
at too ad-hoc logic and would probably benefit > from being migrated to the driver I propose, which does make use of > the (DM) clock, power domain and DT API. I am really happy with the > core helper I've added retrieving a device in front of a graph > endpoint, which m

Re: [PATCH 0/8] Add imx8mp video support

2024-09-10 Thread Michael Nazzareno Trimarchi
drivers/video/imx/lcdif.c | 315 ++ > drivers/video/imx/ldb.c | 251 + > include/dm/uclass.h | 21 ++ > 13 files changed, 909 insertions(+), 2 deletions(-) > create mode 100644

Re: [PATCH] mtd: nand: raw: atmel: remove unnecessary return value

2024-08-30 Thread Michael Nazzareno Trimarchi
condition for copy. > > > > Signed-off-by: Marcus Folkesson > > --- > > Any more thoughts on this? Reviewed-by: Michael Trimarchi It will be included in the next pull request. Michael > > Thanks, > Marcus Folkesson -- Michael Nazzareno Trimarchi Co

Re: [PATCH] mtd: nand: raw: omap_gpmc: Check return value of gpmc_nand_init

2024-08-27 Thread Michael Nazzareno Trimarchi
> can cause system crash. This is seen when "mtd list" is run with no NAND > > addon cards connected. > > > > > > Applied to u-boot/next, thanks! > > -- > Tom > > Thank you to pick it up, I did not see it Michael -- Michael Nazza

Re: xPL terminology

2024-08-27 Thread Michael Nazzareno Trimarchi
cing CONFIG_SPL_BUILD with > > CONFIG_XPL_BUILD would be less confusing. > > Yes. What do you think of E's idea of renaming all the options? I > quite liked it when I read it, but now I am thinking that having > everything be xPL is quite a nice convention. If we have SETUP_...

Re: [PATCH v2 3/3] mtd: rawnand: meson: read/write access for boot ROM pages

2024-08-26 Thread Michael Nazzareno Trimarchi
Hi On Mon, Aug 26, 2024 at 11:00 AM Arseniy Krasnov wrote: > > > > On 26.08.2024 10:16, Michael Nazzareno Trimarchi wrote: > > Hi > > > > On Mon, Aug 26, 2024 at 8:17 AM Arseniy Krasnov > > wrote: > >> > >> Boot ROM on Meson needs some pag

Re: [PATCH v2 3/3] mtd: rawnand: meson: read/write access for boot ROM pages

2024-08-26 Thread Michael Nazzareno Trimarchi
err(dev, "could not retrieve 'amlogic,boot-pages' > property: %d", > + ret); > + goto err_chip_buf_free; > + } > + > + ret = ofnode_read_u32(node, "amlogic,boot-page-step&quo

Re: [PATCH v2 2/3] mtd: rawnand: meson: refactor use of 'meson_nfc_cmd_access()'

2024-08-25 Thread Michael Nazzareno Trimarchi
NFC_CMD_SCRAMBLER_ENABLE); > - } else { > - meson_nfc_cmd_access(nand, raw, DIRREAD, > -NFC_CMD_SCRAMBLER_DISABLE); > - } > + meson_nfc_cmd_access(nand, raw, DIRREAD, page); > > meson_nfc_wait_

Re: [PATCH v2 1/3] mtd: rawnand: nand_base: support for 'NAND_IS_BOOT_MEDIUM' flag

2024-08-25 Thread Michael Nazzareno Trimarchi
ne NAND_USE_BOUNCE_BUFFER 0x0010 > +/* > + * Whether the NAND chip is a boot medium. Drivers might use this information > + * to select ECC algorithms supported by the boot ROM or similar > restrictions. > + */ > +#define NAND_IS_BOOT_MEDIUM0x0040 > > /* Options

Re: [PATCH v2 0/3] Meson: R/W support for pages used by boot ROM

2024-08-25 Thread Michael Nazzareno Trimarchi
Hi Aresenly On Fri, Aug 23, 2024 at 10:53 AM Neil Armstrong wrote: > > On 23/08/2024 10:29, Arseniy Krasnov wrote: > > Hi! Got it, thanks! > > > > On 23.08.2024 11:10, Michael Nazzareno Trimarchi wrote: > >> Hi Arseniy > >> > >> On Thu,

Re: [PATCH v2 0/3] Meson: R/W support for pages used by boot ROM

2024-08-23 Thread Michael Nazzareno Trimarchi
Hi Arseniy On Thu, Aug 22, 2024 at 9:04 AM Arseniy Krasnov wrote: > > Hi, thanks! > > Thanks, Arseniy > > On 22.08.2024 00:17, Michael Nazzareno Trimarchi wrote: > > Hi > > > > I will read them tomorrow ;) > > > > Thank you for understanding &

Re: [PATCH v2 0/3] Meson: R/W support for pages used by boot ROM

2024-08-21 Thread Michael Nazzareno Trimarchi
Hi I will read them tomorrow ;) Thank you for understanding Michael Il mer 21 ago 2024, 22:25 Arseniy Krasnov ha scritto: > Hi, sorry, pls ping 😄 > > Thanks > > On 08.07.2024 10:13, Arseniy Krasnov wrote: > > Patchset is based on patchset for Linux (today merged to nand-next): > > > https://

Re: Uboot net phy.c query

2024-08-20 Thread Michael Nazzareno Trimarchi
h I think > is unreasonable! Please give me an explanation if it is reasonable. > Best Regards! > nick.huang Please explain your problem better and what you are experiencing. A worked a bit on phy network on uboot but you should provide much more context on your problem Michael -- Mic

Re: [PATCH v3 8/9] ubi: implement support for LED activity

2024-08-18 Thread Michael Nazzareno Trimarchi
Hi On Sun, Aug 18, 2024 at 6:24 PM Christian Marangi wrote: > > On Wed, Aug 14, 2024 at 10:17:18AM +0200, Michael Nazzareno Trimarchi wrote: > > Hi all > > > > On Wed, Aug 14, 2024 at 6:34 AM Heiko Schocher wrote: > > > > > > Hello Christian, > &

Re: [PATCH v3 8/9] ubi: implement support for LED activity

2024-08-14 Thread Michael Nazzareno Trimarchi
cular event is connected to the dts or just on a board file Michael > bye, > Heiko > -- > DENX Software Engineering GmbH, Managing Director: Erika Unter > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 i...@amarulasolutions.com www.amarulasolutions.com

Re: [PATCH] ubifs: Call ubifs_iput when ubifs_iget is used

2024-08-10 Thread Michael Nazzareno Trimarchi
node); > > continue; > > } > > > > @@ -583,8 +584,10 @@ static unsigned long ubifs_findfile(struct super_block > > *sb, char *filename) > >*/ > > > > /* Found the node! */ &

Re: [PATCH] mtd: nand: raw: atmel: remove unnecessary return value

2024-08-09 Thread Michael Nazzareno Trimarchi
struct atmel_hsmc_nand_controller *nc; > > - int ret = -EIO; > > > > nc = to_hsmc_nand_controller(nand->controller); > > - > > - if (ret) > > - memcpy_fromio(buf, nc->sram.virt, mtd->writesize); > > + memcpy_fromio(buf, nc->sram.virt,

[PULL] Pull request for u-boot-nand-20240808

2024-08-08 Thread Michael Nazzareno Trimarchi
100644 drivers/mtd/ubi/block.c create mode 100644 drivers/mtd/ubi/part.c -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T.

Re: [PATCH v5 00/20] Introduce the lwIP network stack

2024-08-07 Thread Michael Nazzareno Trimarchi
| 0 > lib/lwip/u-boot/limits.h | 0 > lib/lwip/u-boot/lwipopts.h| 157 +++ > net/Kconfig | 49 +- > net/Makefile | 19 +- > net/eth-uclass.c

Re: [RFC PATCH] ubifs: Call ubifs_iput when ubifs_iget is used

2024-08-07 Thread Michael Nazzareno Trimarchi
indfile(struct super_block > > *sb, char *filename) > >*/ > > > > /* Found the node! */ > > - if (!next || *next == '\0') > > + if (!next || *next == '\0') { > > + ubifs_iput(inode); > > return inum; > > + } > > > > root_inum = inum; > > name = next; > > -- > > 2.43.0 > > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 i...@amarulasolutions.com www.amarulasolutions.com

Re: [RFC PATCH] ubifs: Call ubifs_iput when ubifs_iget is used

2024-08-06 Thread Michael Nazzareno Trimarchi
gt; -- > DENX Software Engineering GmbH, Managing Director: Erika Unter > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Off

Re: [EXTERNAL] Re: [PATCH 0/4] fs: ubifs: Fix crash and add safeguards

2024-08-05 Thread Michael Nazzareno Trimarchi
Hi I found few places, but I can not test changes against my code. Nice if someone start to commit and split by file this changes so we can test everything Micahel On Mon, Aug 5, 2024 at 12:54 PM Heiko Schocher wrote: > > Hello Michael, > > On 05.08.24 10:58, Michael Nazzareno Tri

Re: [EXTERNAL] Re: [PATCH 0/4] fs: ubifs: Fix crash and add safeguards

2024-08-05 Thread Michael Nazzareno Trimarchi
} /* Relative to cur dir */ @@ -575,6 +577,7 @@ static unsigned long ubifs_findfile(struct super_block *sb, char *filename) link_name, next == NULL ? "" : next); memcpy(symlinkpath, buf, sizeof(buf)); next = name = symlinkpath; + ubifs_iput(inode); continue; } @@ -583,8 +586,10 @@ static unsigned long ubifs_findfile(struct super_block *sb, char *filename) */ /* Found the node! */ - if (!next || *next == '\0') + if (!next || *next == '\0') { + ubifs_iput(inode); return inum; + } root_inum = inum; name = next; Should we not free inode_iget? Michael > +1 … thanks for testing. :-) > > > > It crashes with or without patch. With patch it takes 4,5 loops more to > > > crash. > > > > > > Log: > > > UBIFS error (ubi0:0 pid 0): ubifs_iget: failed to read inode 85, error -12 > > > "Synchronous Abort" handler, esr 0x9604 > > > > -12 = -ENOMEM > > > > So it seems, we have a memleak... > > If with my patch it takes more loops to crash, this suggests we have > more than one memory leak, and of them got fixed with my patch(es). > > > Yes, ubi/ubifs linux base is very old, but I tend to think that problem is > > in U-Boot adaption layer... > > I would also suspect the adaption layer. > > However, although my patch fixes one memory leak, that was not the > main reason doing this. The reason of the crash in my case was the > double free, and accessing invalid memory afterwards. So from my > perspective the patches are okay on their own, and looking after more > memory leaks should not be part of this series. > > Greets > Alex > > P.S.: not sure what's causing this, but I only got the mails from you > all through the mailing list. You can keep me in Cc, so I won't > overlook your answers easily. > > > > > bye, > > Heiko > > > > > > > > > Thanks, > > > Ravi > > > > > > > > > > Greets > > > > > Alex > > > > > > > > > > > > > > > > > Greets > > > > > > Alex > > > > > > > > > > > > > > > > > > > > bye, > > > > > > > Heiko > > > > > > > > > > > > > > > > Greets > > > > > > > > Alex > > > > > > > > > > > > > > > > [1] > > > > > > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rauc_rauc_blob_master_contrib_uboot.sh&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=3apjoJolwzwH82pd_c1HzSLzzrwfu9x1lSm802edgOg&m=lpy642UhqtTXHV0dd0xnOtQxkQSO5RC6FwcUbzt-FsNwd3QSXZsulfqC6dP9qV7G&s=wbnw_T9_r6taMKIFqJ2-wtj9Zv02OD7mbIy-ZZFRjRE&e= > > > > > > > > > > > > > > > > <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_rauc_rauc_blob_master_contrib_uboot.sh&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=3apjoJolwzwH82pd_c1HzSLzzrwfu9x1lSm802edgOg&m=lpy642UhqtTXHV0dd0xnOtQxkQSO5RC6FwcUbzt-FsNwd3QSXZsulfqC6dP9qV7G&s=wbnw_T9_r6taMKIFqJ2-wtj9Zv02OD7mbIy-ZZFRjRE&e=> > > > > > > > > > > > > > > > > Alexander Dahl (4): > > > > > > > > fs: ubifs: Fix memleak and double free in u-boot wrapper > > > > > > > > functions > > > > > > > > fs: ubifs: Set pointers to NULL after free > > > > > > > > fs: ubifs: Make k(z)alloc/kfree symmetric > > > > > > > > fs: ubifs: Add volume mounted check > > > > > > > > > > > > > > > > fs/ubifs/super.c | 8 ++-- > > > > > > > > fs/ubifs/ubifs.c | 31 +++ > > > > > > > > 2 files changed, 25 insertions(+), 14 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > base-commit: 65fbdab27224ee3943a89496b21862db83c34da2 > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > DENX Software Engineering GmbH, Managing Director: Erika > > > > > > > Unter > > > > > > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, > > > > > > > Germany > > > > > > > Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: > > > > > > > h...@denx.de > > > > > > > > -- > > > > DENX Software Engineering GmbH, Managing Director: Erika Unter > > > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > > > > Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de > > > > > > > > -- > > DENX Software Engineering GmbH, Managing Director: Erika Unter > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > > Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 i...@amarulasolutions.com www.amarulasolutions.com

Re: [PATCH 0/4] fs: ubifs: Fix crash and add safeguards

2024-07-31 Thread Michael Nazzareno Trimarchi
next 2 weeks ... Hmm.. and it would be good to get some Tested-by > > > from people with hardware... > > > > Take your time, no need to work in holidays. Would appreciate a > > Tested-by by anyone else though, maybe some of the raw NAND folks? >

Re: [PATCHv4 05/14] cpu: imx: fix the CPU frequency in cpu_imx_get_info()

2024-07-30 Thread Michael Nazzareno Trimarchi
req = plat->freq_mhz * 1000; > + info->cpu_freq = plat->freq_mhz * 100; > info->features = BIT(CPU_FEAT_L1_CACHE) | BIT(CPU_FEAT_MMU); Reviewed-by: Michael Trimarchi > return 0; > } > -- > 2.17.1 > -- Michael Nazzareno Trimarchi Co-Founder

Re: [PATCHv4 01/14] clk: imx8m: register ARM A53 core clock

2024-07-30 Thread Michael Nazzareno Trimarchi
static const char * const sys_pll3_bypass_sels[] = {"sys_pll3", > "sys_pll3_ref_sel", }; > > +static const char * const imx8mp_arm_core_sels[] = {"arm_a53_src", > "arm_pll_out", }; > + > static const char * const imx8mp_a53_sels[] = {&q

Re: [PATCH V2] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present for gate and mux

2024-07-26 Thread Michael Nazzareno Trimarchi
Hi Sam On Thu, Jul 25, 2024 at 4:41 AM Sam Protsenko wrote: > > On Wed, Jul 24, 2024 at 4:44 AM Michael Nazzareno Trimarchi > wrote: > > [snip] > > > > Ok , so you suggest to have something like in the core > > > > diff --git a/drivers/clk/clk-uclass

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-07-25 Thread Michael Nazzareno Trimarchi
Hi Sam Il mar 23 lug 2024, 22:53 Sam Protsenko ha scritto: > On Wed, Jul 3, 2024 at 10:00 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi all > > > > Working on the clock now. I have done a different implementation > > > > clk-mux, clk-gate I have a

Re: [PATCH v2 00/40] mmc: dw_mmc: Enable eMMC on E850-96 board

2024-07-25 Thread Michael Nazzareno Trimarchi
Hi all Il mar 9 lug 2024, 02:48 Sam Protsenko ha scritto: > On Thu, Jun 27, 2024 at 9:42 AM Tom Rini wrote: > > > > On Wed, Jun 26, 2024 at 10:12:12PM +0530, Anand Moon wrote: > > > Hi Sam, > > > > > > On Wed, 19 Jun 2024 at 02:26, Sam Protsenko < > semen.protse...@linaro.org> wrote: > > > > >

Re: [PATCH] clk: fix ccf_clk_get_rate

2024-07-25 Thread Michael Nazzareno Trimarchi
Hi On Thu, Jul 25, 2024 at 11:58 AM Z.Q. Hou wrote: > > Hi Michael, > > > -Original Message- > > From: Michael Nazzareno Trimarchi > > Sent: Thursday, July 25, 2024 5:26 PM > > To: Z.Q. Hou ; Simon Glass > > Cc: u-boot@lists.denx.de; tr..

Re: [PATCH v2] mtd: nand: raw: atmel: Use ONFI ECC params if available

2024-07-25 Thread Michael Nazzareno Trimarchi
f (chip->ecc.size) > > req.ecc.sectorsize = chip->ecc.size; > > + else if (chip->ecc_step_ds) > > + req.ecc.sectorsize = chip->ecc_step_ds; > > else > > req.ecc.sectorsize = ATMEL_PMECC_SECTOR_SIZE_

Re: [PATCH] clk: fix ccf_clk_get_rate

2024-07-25 Thread Michael Nazzareno Trimarchi
Hi On Thu, Jul 25, 2024 at 10:53 AM Z.Q. Hou wrote: > > Hi Michael, > > > -Original Message- > > From: Michael Nazzareno Trimarchi > > Sent: Thursday, July 25, 2024 3:32 PM > > To: Z.Q. Hou > > Cc: u-boot@lists.denx.de; tr...@konsulko.co

Re: [PATCH] clk: fix ccf_clk_get_rate

2024-07-25 Thread Michael Nazzareno Trimarchi
1..4c2c372cd3 100644 > --- a/drivers/clk/clk.c > +++ b/drivers/clk/clk.c > @@ -84,7 +84,8 @@ ulong ccf_clk_get_rate(struct clk *clk) > int err = clk_get_by_id(clk->id, &c); > > if (err) > - return err; > + return 0; > + >

Re: [PATCH V2] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present for gate and mux

2024-07-24 Thread Michael Nazzareno Trimarchi
Hi Sam On Wed, Jul 24, 2024 at 9:25 AM Michael Nazzareno Trimarchi wrote: > > Hi Sam > > On Tue, Jul 23, 2024 at 10:37 PM Sam Protsenko > wrote: > > > > On Fri, Jul 5, 2024 at 2:14 AM Michael Trimarchi > > wrote: > > > > > > Gate and mux doe

Re: [PATCH V2] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present for gate and mux

2024-07-24 Thread Michael Nazzareno Trimarchi
gt; + * @clk: A clock struct that was previously successfully requested by > > + * clk_request/get_by_*(). > > + * > > + * Return: clock rate in Hz, or -ve error code. > > + */ > > +ulong clk_set_parent_rate(struct clk *clk, ulong rate); > >

Re: [PATCH 13/14] spl: Create a function to init spl_load_info

2024-07-20 Thread Michael Nazzareno Trimarchi
in memory so we can jump to it. We > * allow any U-Boot binary to be used (u-boot.bin, u-boot-nodtb.bin, > diff --git a/test/image/spl_load.c b/test/image/spl_load.c > index 7cbad40ea0c..3b6206955d3 100644 > --- a/test/image/spl_load.c > +++ b/test/image/spl_load.c > @@ -343

Re: [PATCH] mtd: nand: raw: atmel: Use ONFI ECC params if available

2024-07-18 Thread Michael Nazzareno Trimarchi
with original information of it. Like: Upstream commit Try to report some original context from kernel Micahel > -- > Zixun LI > > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __

Re: [PATCH v6 0/6] Introduce UBI block device

2024-07-17 Thread Michael Nazzareno Trimarchi
++ > drivers/mtd/ubi/part.c | 99 +++ > env/ubi.c | 16 ++--- > include/part.h | 2 + > include/ubi_uboot.h | 13 +++- > 11 files changed, 348 insertions(+), 18 deletions(-) > create mode 100

Re: [PATCH] clk: imx8mn: add video clocks support

2024-07-14 Thread Michael Nazzareno Trimarchi
Hi Fabio On Mon, Apr 22, 2024 at 1:17 PM Fabio Estevam wrote: > > Hi Michael, > > On Mon, Apr 22, 2024 at 7:36 AM Michael Nazzareno Trimarchi > wrote: > > > Are you considering if I wrap properly with VIDEO IS_ENABLED? > > I prefer you resend this patch as part

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-07-10 Thread Michael Nazzareno Trimarchi
HI Fabio On Wed, Jul 10, 2024 at 3:43 PM Fabio Estevam wrote: > > On Wed, Jul 10, 2024 at 10:39 AM Michael Nazzareno Trimarchi > wrote: > > > clk dump > > > > It's how uboot is registering the clk in dts. My idea now was not to > > change it to not imp

Re: [PATCH 1/4] clk: imx: clk-imx8mn Fix nand and spi clock parent

2024-07-10 Thread Michael Nazzareno Trimarchi
o change it to not impact other architectures. I have a lot of changes but I don't want to address regression and fix and test before send more patches MIchael -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-07-03 Thread Michael Nazzareno Trimarchi
PARENT flag is > > > > also used in various IMX clock drivers and STM32MP13 clock driver. I > > > > guess without this change those flags will be basically ignored. > > > > > > > > Thanks! > > > > > > > > > > Hi Sean, >

Re: [PATCH 2/2] clk: imx: add mux ops for i.MX8M composite clk

2024-07-03 Thread Michael Nazzareno Trimarchi
Hi Fabio On Wed, Jul 3, 2024 at 3:44 PM Fabio Estevam wrote: > > Hi Michael, > > On Wed, Jul 3, 2024 at 6:15 AM Michael Trimarchi > wrote: > > > > Upstream Linux commit f90b68d6c8b0. > > > > The CORE/BUS root slice has following design, simplied graph: > > The difference is core not have pr

Re: [PATCH v3 19/19] CI: Allow running tests on sjg lab

2024-06-24 Thread Michael Nazzareno Trimarchi
: rpi2 > > + <<: *lab_dfn > > + > > +bob: > > + variables: > > +ROLE: bob > > + <<: *lab_dfn > > + > > +ff3399: > > + variables: > > +ROLE: ff3399 > > + <<: *lab_dfn > > + > > +coral: > &

Re: [PATCH v1 1/3] mtd: rawnand: nand_base: support for 'NAND_IS_BOOT_MEDIUM' flag

2024-06-24 Thread Michael Nazzareno Trimarchi
D_ROW_ADDR_3 0x4000 > > > > +/* > > + * Whether the NAND chip is a boot medium. Drivers might use this > > information > > + * to select ECC algorithms supported by the boot ROM or similar > > restrictions. > > + */ > > +#define NAND

Re: [PATCH 1/3] pxe: Add debugging for booting

2024-06-22 Thread Michael Nazzareno Trimarchi
Hi On Wed, Jun 19, 2024 at 2:34 PM Simon Glass wrote: > > Show which boot protocol is being used. > > Signed-off-by: Simon Glass > --- > > boot/pxe_utils.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/boot/pxe_utils.c b/boot/pxe_utils.c > index 4b22b

Re: [PATCH] dt-bindings: imx: Drop redundant imports with dts/upstream

2024-06-20 Thread Michael Nazzareno Trimarchi
Hi Sumit On Thu, Jun 20, 2024 at 6:55 AM Sumit Garg wrote: > > On Wed, 19 Jun 2024 at 18:51, Michael Nazzareno Trimarchi > wrote: > > > > Hi > > > > On Wed, Jun 19, 2024 at 3:07 PM Sumit Garg wrote: > > > > > > On Wed, 19 Jun 2024 at 18:2

Re: [PATCH v2] Makefile: Fix include directory for OF_UPSTREAM

2024-06-17 Thread Michael Nazzareno Trimarchi
at 12:44, Michael Nazzareno Trimarchi > wrote: > > > > Hi Sumit > > > > On Thu, Jun 13, 2024 at 9:02 AM Sumit Garg wrote: > > > > > > On Mon, 3 Jun 2024 at 20:38, Patrick Barsanti > > > wrote: > > > > > > > > Alway

Re: [PATCH v2] Makefile: Fix include directory for OF_UPSTREAM

2024-06-13 Thread Michael Nazzareno Trimarchi
e)/arch/arm/thumb1/include), \ > > + -I$(srctree)/arch/arm/thumb1/include)) \ > > + -I$(srctree)/arch/$(ARCH)/include \ > > + -include $(srctree)/include/linux/kconfig.h > > +else > > UBOOTINCLUDE:= \ > > -Iinclude \ > &g

Re: [PATCH v2] Makefile: Fix include directory for OF_UPSTREAM

2024-06-12 Thread Michael Nazzareno Trimarchi
HI On Wed, Jun 12, 2024 at 7:25 PM Tom Rini wrote: > > On Wed, Jun 12, 2024 at 10:17:12AM +0200, Michael Nazzareno Trimarchi wrote: > > Hi Tom > > > > On Mon, Jun 3, 2024 at 5:08 PM Patrick Barsanti > > wrote: > > > > > > Always prioritizin

Re: [PATCH v2] Makefile: Fix include directory for OF_UPSTREAM

2024-06-12 Thread Michael Nazzareno Trimarchi
Hi Marek On Wed, Jun 12, 2024 at 11:32 AM Marek Vasut wrote: > > On 6/3/24 5:07 PM, Patrick Barsanti wrote: > > Always prioritizing u-boot includes causes problems when trying to migrate > > boards to OF_UPSTREAM that have different local devicetree files with > > respect to the upstream ones, if

Re: [PATCH v2] Makefile: Fix include directory for OF_UPSTREAM

2024-06-12 Thread Michael Nazzareno Trimarchi
(srctree)/include) \ > @@ -837,6 +850,7 @@ UBOOTINCLUDE:= \ > -I$(srctree)/arch/$(ARCH)/include \ > -include $(srctree)/include/linux/kconfig.h \ > -I$(srctree)/dts/upstream/include > +endif > > NOSTDINC_FLAGS += -nostdinc -isystem $(shell $(CC) -print-fil

Re: [PATCH] Makefile: Fix include directory for OF_UPSTREAM

2024-05-31 Thread Michael Nazzareno Trimarchi
must reference the include/ directory. >> >> > # Needed to be compatible with the O= option >> >> > +ifeq ($(CONFIG_OF_UPSTREAM),y) >> >> > +UBOOTINCLUDE:= \ >> >> > + -I$(srctree)/dts/upstream/include \ >> >> &g

Re: [PATCH v2 0/6] Introduce UBI block device

2024-05-23 Thread Michael Nazzareno Trimarchi
Hi We queue them this afternoon Michael On Thu, May 23, 2024 at 12:49 PM Alexey Romanov wrote: > > > Hi Michael, > > On Mon, May 06, 2024 at 03:59:52PM +0200, Michael Nazzareno Trimarchi wrote: > > Hi Alexey > > > > Sorry will will put on CI > > Any news

Re: [EXTERNAL] Re: [PATCH] mtd: nand: pxa3xx: Incorrect bitflip return on page read

2024-05-21 Thread Michael Nazzareno Trimarchi
Hi Dario Can you add to next pull? Michael On Tue, May 21, 2024, 4:31 PM Ravi Minnikanti wrote: > Hi, > > Can you please merge this PR, if there are no more review comments? > > Thanks, > Ravi > On 5/6/24 11:28, Michael Nazz

Re: imx8mp: Flashing U-Boot into eMMC hardware partition via UUU

2024-05-10 Thread Michael Nazzareno Trimarchi
Hi Fabio On Fri, May 10, 2024 at 5:10 PM Fabio Estevam wrote: > > Hi Michael, > > On Fri, May 10, 2024 at 11:28 AM Michael Nazzareno Trimarchi > wrote: > > > You can just change as you want. We have this file in buildroot, uuu > > can run command on the device >

Re: imx8mp: Flashing U-Boot into eMMC hardware partition via UUU

2024-05-10 Thread Michael Nazzareno Trimarchi
UTPUT_DIR}/host/bin/uuu -v -b ${IMAGES_DIR}/nand-full.lst \ ${IMAGES_DIR}/flash.bin \ ${IMAGES_DIR}/flash.bin \ ${IMAGES_DIR}/rootfs.ubifs \ ${IMAGES_DIR}/Image \ ${IMAGES_DIR}/freescale/imx8mn-bsh-smm-s2.dtb Michael > > Thanks -- Michael Nazzareno Trimarchi Co-Founder & Chief

Re: [PATCH] mtd: nand: pxa3xx: Incorrect bitflip return on page read

2024-05-06 Thread Michael Nazzareno Trimarchi
Hi Ravi On Mon, May 6, 2024 at 7:33 PM Ravi Minnikanti wrote: > > On 5/6/24 00:35, Michael Nazzareno Trimarchi wrote: > > Hi Ravi > > > > On Tue, Apr 30, 2024 at 6:25 AM Ravi Minnikanti > > wrote: > >> > >> On

Re: [PATCH v2 0/6] Introduce UBI block device

2024-05-06 Thread Michael Nazzareno Trimarchi
/ubi/Makefile| 1 + > > drivers/mtd/ubi/block.c | 130 > > drivers/mtd/ubi/part.c | 99 +++ > > env/ubi.c | 16 ++--- > > include/part.h | 2 + > > include/ubi_u

Re: [EXTERNAL] Re: [PATCH] mtd: nand: pxa3xx: Incorrect bitflip return on page read

2024-05-06 Thread Michael Nazzareno Trimarchi
Hi Ravi On Tue, Apr 30, 2024 at 6:25 AM Ravi Minnikanti wrote: > > On 4/29/24 09:59, Michael Nazzareno Trimarchi wrote: > > > -- > > On Mon, Apr 29, 2024 at 6:22 PM Chris Packham > > wrote: > >

Re: imx8mn: bootcount does not increment

2024-05-02 Thread Michael Nazzareno Trimarchi
IT=y > CONFIG_SYS_BOOTCOUNT_MAGIC=0xB0C4 > CONFIG_SYS_BOOTCOUNT_ADDR=0x30370090 > CONFIG_SYS_BOOTCOUNT_SINGLEWORD=y > > and now bootcount increments. > Maybe you have anyway a bug on the evk when was not incrementing on environment Michael > Thanks, > > Fabio E

Re: [PATCH 030/149] board: bsh: Remove and add needed includes

2024-05-01 Thread Michael Nazzareno Trimarchi
/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c > b/board/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c > index 0ebf208be82a..c99896873991 100644 > --- a/board/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c > +++ b/board/bsh/imx8mn_smm_s2/imx8mn_smm_s2.c > @@ -3,7 +3,6 @@ > * Copyright 2021 Collabora Ltd. >

Re: [PATCH] mtd: nand: pxa3xx: Incorrect bitflip return on page read

2024-04-29 Thread Michael Nazzareno Trimarchi
>need_wait = 0; > > + /* > > +* Reset max_bitflips to zero. Once command is complete, > > +* max_bitflips for this READ is returned in ecc.read_page() > > +*/ > > + info->max_bitflips = 0; > > W

Re: [PATCH] ubi: Depend on MTD

2024-04-26 Thread Michael Nazzareno Trimarchi
Hi Dario On Fri, Apr 26, 2024 at 5:52 PM Tom Rini wrote: > > On Fri, Apr 26, 2024 at 07:18:18AM +0200, Heiko Schocher wrote: > > Hello Tom, > > > > On 11.04.24 08:09, Michael Nazzareno Trimarchi wrote: > > > Hi > > > > > > On Thu, Apr 11, 202

Re: [PATCH] clk: imx8mn: add video clocks support

2024-04-22 Thread Michael Nazzareno Trimarchi
Hi Fabio On Sun, Apr 21, 2024 at 10:54 PM Michael Nazzareno Trimarchi wrote: > > Hi Fabio > > On Sun, Apr 21, 2024 at 10:24 PM Fabio Estevam wrote: > > > > Hi Michael, > > > > On Sun, Apr 21, 2024 at 11:07 AM Michael Trimarchi > > wrote: > > &g

Re: [PATCH] clk: imx8mn: add video clocks support

2024-04-21 Thread Michael Nazzareno Trimarchi
de against > CONFIG_VIDEO or something, like done here: > https://source.denx.de/u-boot/custodians/u-boot-imx/-/commit/2b3310ef13998dfd03196a0806e03035212b102c Working on display panel integration on imx8m, trying to progress merging things up. Michael -- Michael Nazzareno Tr

Re: [PATCH v1] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2024-04-17 Thread Michael Nazzareno Trimarchi
Hi Dario did you add those patches in CI and test them again? Michael On Wed, Apr 17, 2024 at 8:44 PM Arseniy Krasnov wrote: > > Hello, > > Sorry, pls ping > > Thanks, Arseniy > > On 13.03.2024 09:46, Michael Nazzareno Trimarchi wrote: > > Hi Dario > > >

Re: [PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Michael Nazzareno Trimarchi
Hi On Mon, Apr 15, 2024 at 3:55 PM Michael Nazzareno Trimarchi wrote: > > Hi > > On Mon, Apr 15, 2024 at 3:48 PM Yasuharu Shibata > wrote: > > > > Hi Michael, > > > > On Mon, 15 Apr 2024 at 22:03, Michael Nazzareno Trimarchi > > wrote:

Re: [PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Michael Nazzareno Trimarchi
Hi On Mon, Apr 15, 2024 at 3:48 PM Yasuharu Shibata wrote: > > Hi Michael, > > On Mon, 15 Apr 2024 at 22:03, Michael Nazzareno Trimarchi > wrote: > > > > I think I have sent some time ago ;) > > > > Anyway look sane. I was having the same feeling on code

Re: [PATCH 1/1] net: wget: fix TCP sequence number wrap around issue

2024-04-15 Thread Michael Nazzareno Trimarchi
te(NETLOOP_FAIL); I think I have sent some time ago ;) Anyway look sane. I was having the same feeling on code inspection Reviewed-by: Michael Trimarchi > -- > 2.25.1 > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com

Re: [PATCH v3 0/3] Introduce mtdblock device

2024-04-11 Thread Michael Nazzareno Trimarchi
| 227 > > drivers/mtd/mtdpart.c | 69 +++ > > drivers/mtd/nand/spi/core.c | 20 > > include/linux/mtd/mtd.h | 12 ++ > > include/part.h | 3 + > > 9 files changed, 336 insertions(+), 1 deletio

Re: [PATCH] ubi: Depend on MTD

2024-04-10 Thread Michael Nazzareno Trimarchi
Michael Trimarchi > base-commit: 777c28460947371ada40868dc994dfe8537d7115 > change-id: 20240411-mtd-d2e811e17cc8 > > Best regards, > -- > John Watts > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com

Re: [PATCH v2 6/6] cmd: nand: Add new optional sub-command 'onfi'

2024-03-22 Thread Michael Nazzareno Trimarchi
HI On Fri, Mar 22, 2024 at 1:02 PM Alexander Dahl wrote: > > Hello Michael, > > Am Fri, Mar 22, 2024 at 12:54:27PM +0100 schrieb Michael Nazzareno Trimarchi: > > HI > > > > On Fri, Mar 22, 2024 at 12:46 PM Alexander Dahl wrote: > > > > > > Hello

Re: [PATCH v2 6/6] cmd: nand: Add new optional sub-command 'onfi'

2024-03-22 Thread Michael Nazzareno Trimarchi
ssed: 64, failed: 0 > > > > time: 11.661 seconds > > > > => nand info > > > > Device 0: nand0, sector size 256 KiB > > Manufacturer MACRONIX > > Model MX30LF4G28AD > > Device size512 MiB > > Page size 4096

Re: [PATCH v4] cmd: mtd: OTP access support

2024-03-22 Thread Michael Nazzareno Trimarchi
Hi Arseniy On Fri, Mar 22, 2024 at 9:14 AM Arseniy Krasnov wrote: > > Hi, > > On 22.03.2024 11:12, Michael Nazzareno Trimarchi wrote: > > Hi Arseniy > > > > On Wed, Mar 20, 2024 at 8:14 PM Arseniy Krasnov > > wrote: > >> > >> Add access

Re: [PATCH v4] cmd: mtd: OTP access support

2024-03-22 Thread Michael Nazzareno Trimarchi
; > + "mtd otpwrite\n" > + "mtd otplock \n" > + "mtd otpinfo[u|f]\n" > "\n" > "With:\n" > "\t: NAND

Re: [PATCH v2 6/6] cmd: nand: Add new optional sub-command 'onfi'

2024-03-21 Thread Michael Nazzareno Trimarchi
gt; TDF cycles: 15 (45 ns) > Data Bus Width: 8-bit bus > NWAIT Mode: 0 > Write operation controlled by NWE signal > Read operation controlled by NRD signal > > => time nand torture 0x80 0x100 > > NAND torture: device 0 offset 0x80 size 0x100 (block siz

Re: [PATCH 1/1] fs: ext4: all file paths are absolute

2024-03-20 Thread Michael Nazzareno Trimarchi
if (*dirname != '/') { > - printf("Please supply Absolute path\n"); > - return -1; > - } > - > /* TODO: input validation make equivalent to linux */ > depth_dirname = zalloc(strlen(dirname) + 1); > if (!de

Re: [PATCH v3] cmd: mtd: OTP access support

2024-03-20 Thread Michael Nazzareno Trimarchi
[u|f] \n" > + "mtd otpwrite\n" > + "mtd otplock \n" > + "mtd otpinfo [u|f]\n" > "\n" > "With

Re: [PATCH v2 5/6] mtd: nand: raw: atmel: Fix comment in timings preparation

2024-03-20 Thread Michael Nazzareno Trimarchi
d timings we calculated earlier, > * which gives: > * > -- Reviewed-by: Michael Trimarchi > 2.39.2 > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 i...@amarulasolutions.com www.amarulasolutions.com

Re: [PATCH v2] cmd: mtd: OTP access support

2024-03-12 Thread Michael Nazzareno Trimarchi
gt;>> + mtd = get_mtd_by_name(argv[1]); > >>> + if (IS_ERR_OR_NULL(mtd)) > >>> + return CMD_RET_FAILURE; > >>> + > >>> + if (user) > >>> + ret = mtd_get_user_prot_info(mtd, sizeof(otp_info), &retlen, > >>> +

Re: [PATCH v1] mtd: rawnand: macronix: OTP access for MX30LFxG18AC

2024-03-12 Thread Michael Nazzareno Trimarchi
; > > On 08.01.2024 21:33, Arseniy Krasnov wrote: > >> Sorry, pls ping > >> > >> Thanks, Arseniy -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __ Amarula S

Re: [PATCH] mtd: nand: raw: mt7621-nand: allow writing ecc region in raw mode

2024-03-12 Thread Michael Nazzareno Trimarchi
parity data */ > + mt7621_nfc_write_data(nfc, oob_ecc_ptr(nfc, i), > + nfc->spare_per_sector - NFI_FDM_SIZE); > } > Please describe better what regression you are trying to fix in the commit message Reviewed-by: Michael Trimarchi Michael > mt7621_nf

Re: [PATCH 3/4] mtd: nand: raw: Fix (most) Kconfig indentation

2024-03-07 Thread Michael Nazzareno Trimarchi
t; bool "Enables SPL-NAND driver which supports ELM based" > depends on SPL_NAND_SUPPORT && NAND_OMAP_GPMC && !OMAP34XX > default y > -help > + help > Hardware ECC correction. This is useful for platforms which have

Re: [PATCH 2/4] mtd: nand: raw: Port another option flag from Linux

2024-03-07 Thread Michael Nazzareno Trimarchi
me. This is needed when the > + * controller initializes the timings on itself or when it relies on > + * configuration done by the bootloader. > + */ > +#define NAND_KEEP_TIMINGS 0x0080 > + > /* Options set by nand scan */ > /* bbt has already been read */ > #de

Re: [PATCH 1/4] mtd: nand: raw: Use macro nand_to_mtd() where appropriate

2024-03-07 Thread Michael Nazzareno Trimarchi
td(chip); > const struct nand_manufacturer *manufacturer_desc; > int busw, ret; > u8 *id_data = chip->id.data; > -- > 2.39.2 > Reviewed-By: Michael Trimarchi -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 i...@amarulasolutions.com www.amarulasolutions.com

Re: [PATCH] cmd: sf: Fix sf probe crash

2024-03-04 Thread Michael Nazzareno Trimarchi
if (use_dt) { > >> - spi_flash_probe_bus_cs(bus, cs, &new); > >> - flash = dev_get_uclass_priv(new); > >> + ret = spi_flash_probe_bus_cs(bus, cs, &new); > >> + if (!ret) > >> + f

Re: [PATCH] mtd: spinand: Add support for XTX XT26xxxDxxxxx

2024-02-29 Thread Michael Nazzareno Trimarchi
; >> +NAND_MEMORG(1, 4096, 256, 64, 2048, 40, 1, 1, 1), > >> +NAND_ECCREQ(8, 512), > >> +SPINAND_INFO_OP_VARIANTS(&read_cache_variants, > >> + &write_cache_variant

Re: [PATCH] arm: dts: k3-binman: Make optee optional as requirement

2024-02-25 Thread Michael Nazzareno Trimarchi
}; > > }; > > > > @@ -360,6 +361,7 @@ > > entry = <0x9e80>; > > tee-os { > > filename = "tee-raw.bin"; > > + optional; > &g

Re: [PATCH v3] mtd: rawnand: Meson NAND controller support

2024-02-12 Thread Michael Nazzareno Trimarchi
elect_chip = meson_nfc_nand_select_chip; > + nand->read_byte = meson_nfc_nand_read_byte; > + nand->write_byte = meson_nfc_nand_write_byte; > + nand->dev_ready = meson_nfc_dev_ready; > + > + /* Buffer read/write routines */ > + nand->read_buf = meson_nfc_re

Re: [PATCH] lib: sparse: Fix error checking for write_sparse_chunk_raw

2024-02-01 Thread Michael Nazzareno Trimarchi
blk += blks; > -- > 2.35.1.1320.gc452695387.dirty > Reviewed-by: Michael Trimarchi Michael -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 i...@amarulasolutions.com www.amarulasolutions.com

  1   2   3   4   5   6   7   >