Re: [PATCH v9 22/37] drivers: misc: irq-uclass: Update irq_get_by_index

2024-10-16 Thread Moritz Fischer
T: Read the interrupts from the GIC node for ACPI MADT generation. > > Signed-off-by: Patrick Rudolph Reviewed-by: Moritz Fischer > --- > Changelog v9: > - Read interrupt-cells from interrupt parent > --- > arch/sandbox/dts/test.dts | 3 ++ > drivers/misc/irq-uclass.c | 66

Re: [PATCH v9 20/37] arm: gic-v3-its: Implement of_xlate

2024-10-16 Thread Moritz Fischer
SPIs > - ID0-ID15 are used for SGIs > - ID16-ID31 are used for PPIs > > TEST: Booted on qemu sbsa-ref that has a GICV3. > > Signed-off-by: Patrick Rudolph Reviewed-by: Moritz Fischer > --- > Changelog v9: > - Require at least 3 interrupt-cells > - Map SPI

Re: [PATCH v8 25/37] board: emulation: Add QEMU sbsa support

2024-10-15 Thread Moritz Fischer
Hi Patrick, On Mon, Oct 14, 2024 at 6:17 AM Patrick Rudolph wrote: > > Add support for Arm sbsa [1] v0.3+ that is supported by QEMU [2]. > > Unlike other Arm based platforms the machine only provides a minimal > FDT that contains number of CPUs, ammount of memory and machine-version. > The boot f

Re: [PATCH v8 20/37] arm: gic-v3-its: Implement of_xlate

2024-10-14 Thread Moritz Fischer
Hi Patrick, On Mon, Oct 14, 2024 at 6:16 AM Patrick Rudolph wrote: > > Translate IRQs by implementing of_xlate() as required by > irq_get_by_index() to parse interrupt properties. > > TEST: Booted on qemu sbsa-ref that has a GICV3. > > Signed-off-by: Patrick Rudolph > Reviewed-by: Simon Glass >

Re: [PATCH v8 22/37] drivers: misc: irq-uclass: Update irq_get_by_index

2024-10-14 Thread Moritz Fischer
Hi Patrick On Mon, Oct 14, 2024 at 6:16 AM Patrick Rudolph wrote: > > Support reading the "interrupts" property from the devicetree in case > the "interrupts-extended" property isn't found. As the "interrupts" > property is commonly used, this allows to parse all existing FDT and > makes irq_get_

Re: [PATCH 07/17] arm: acpi: Add generic ACPI methods

2024-08-24 Thread Moritz Fischer
Patrick, On Sat, Jul 27, 2024 at 12:21 AM Patrick Rudolph wrote: > > Add generic ACPI code to generate > - MADT GICC > - MADT GICD > > as commonly used on arm platforms. > > Signed-off-by: Patrick Rudolph > Cc: Tom Rini > Cc: Simon Glass > --- > arch/arm/include/asm/acpi_table.h | 18

Re: [PATCH 06/17] acpi: Add define for GTDT

2024-08-08 Thread Moritz Fischer
IVE_LOW BIT(1) > + > /** > * struct acpi_bgrt - Boot Graphics Resource Table (BGRT) > * > -- > 2.45.2 > Reviewed-by: Moritz Fischer

Re: [PATCH 05/17] serial: serial_pl01x: Implement .getinfo() for PL01

2024-08-08 Thread Moritz Fischer
On Sat, Jul 27, 2024 at 12:21 AM Patrick Rudolph wrote: > > From: Maximilian Brune > > When ACPI is enabled on arm it will use the getinfo function to fill > the SPCR ACPI table. > > Signed-off-by: Maximilian Brune > Cc: Simon Glass > Cc: Tom Rini Reviewed-by: Mo

Re: [PATCH v2 RESEND 2/2] nvme: Update nvme_scan_namespace to keep trying on busy

2024-01-18 Thread Moritz Fischer
On Tue, Jan 9, 2024 at 9:05 PM Moritz Fischer wrote: > > A busy controller shouldn't be game-over for all controllers, > so keep trying on hitting -EBUSY. > > This change brings the actual behavior of the routine in line > with what the descriptions says. > > Fixes:

[PATCH v2 RESEND 2/2] nvme: Update nvme_scan_namespace to keep trying on busy

2024-01-09 Thread Moritz Fischer
Signed-off-by: Moritz Fischer --- drivers/nvme/nvme.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index ec45f831a3..59a139baa0 100644 --- a/drivers/nvme/nvme.c +++ b/drivers/nvme/nvme.c @@ -695,7 +695,9 @@ int nvme_scan

[PATCH v2 RESEND 1/2] nvme: Fix error code and log to indicate busy

2024-01-09 Thread Moritz Fischer
Return -EBUSY if controller is found busy rather than -ENOMEM and update the error message accordingly. Fixes: 982388eaa991 ("nvme: Add NVM Express driver support") Reviewed-by: Simon Glass Signed-off-by: Moritz Fischer --- drivers/nvme/nvme.c | 4 ++-- 1 file changed, 2 insert

[PATCH v4] drivers: pci: Fix dm_pci_map_bar() to support 64b BARs

2024-01-09 Thread Moritz Fischer
This enables 64b BARs if CONFIG_SYS_PCI_64BIT is enabled. Reviewed-by: Philip Oberfichtner Reviewed-by: Simon Glass Signed-off-by: Moritz Fischer --- Changes from V3: - Rebased onto v2024.01 Changes from V2: - Turned IS_ENABLED() into #if defined to allow building on platforms that don&#

[PATCH v3] pci: Enable dm_pci_map_bar() for 64-bit BARs

2023-12-21 Thread Moritz Fischer
Allow dm_pci_map_bar() usage on systems with CONFIG_SYS_PCI_64BIT. Reviewed-by: Philip Oberfichtner Reviewed-by: Simon Glass Signed-off-by: Moritz Fischer --- Changes from V2: - Turned IS_ENABLED() into #if defined to allow building on platforms that don't define CONFIG_SYS_PCI_

Re: [PATCH v2 RESEND] pci: Enable dm_pci_map_bar() for 64-bit BARs

2023-12-21 Thread Moritz Fischer
Tom, On Thu, Dec 21, 2023 at 9:53 AM Tom Rini wrote: > > On Sun, Dec 17, 2023 at 12:52:09AM +, Moritz Fischer wrote: > > > Allow dm_pci_map_bar() usage on systems with CONFIG_SYS_PCI_64BIT. > > > > Reviewed-by: Philip Oberfichtner > > Reviewed-by: Simon

[PATCH v2 RESEND] pci: Enable dm_pci_map_bar() for 64-bit BARs

2023-12-16 Thread Moritz Fischer
Allow dm_pci_map_bar() usage on systems with CONFIG_SYS_PCI_64BIT. Reviewed-by: Philip Oberfichtner Reviewed-by: Simon Glass Signed-off-by: Moritz Fischer --- drivers/pci/pci-uclass.c | 11 +++ include/pci.h| 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff

[PATCH v2 2/2] nvme: Update scan namespace to keep trying on busy

2023-12-16 Thread Moritz Fischer
Signed-off-by: Moritz Fischer --- Changes from V1: - Added Simon's Reviewed-by --- drivers/nvme/nvme.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index ec45f831a3..59a139baa0 100644 --- a/drivers/nvme/nvme.c +++ b/drivers/n

[PATCH v2 1/2] nvme: Fix error code and log to indicate busy

2023-12-16 Thread Moritz Fischer
Return -EBUSY if controller is found busy rather than -ENOMEM and update the error message accordingly. Fixes: 982388eaa991 ("nvme: Add NVM Express driver support") Reviewed-by: Simon Glass Signed-off-by: Moritz Fischer --- Changes from V1: - Added Simon's Reviewed-by --- driv

[PATCH RESEND 2/2] nvme: Update nvme_scan_namespace to keep trying on busy

2023-12-01 Thread Moritz Fischer
A busy controller shouldn't be game-over for all controllers, so keep trying on hitting -EBUSY. This change brings the actual behavior of the routine in line with what the descriptions says. Fixes: 982388eaa991 ("nvme: Add NVM Express driver support") Signed-off-by: Moritz Fische

[PATCH RESEND 1/2] nvme: Fix error code and log to indicate busy

2023-12-01 Thread Moritz Fischer
Return -EBUSY if controller is found busy rather than -ENOMEM and update the error message accordingly. Fixes: 982388eaa991 ("nvme: Add NVM Express driver support") Signed-off-by: Moritz Fischer --- drivers/nvme/nvme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

Re: Setting up boot chain ACPI on ARM with STM32MPU

2023-11-29 Thread Moritz Fischer
Hi, On Wed, Nov 29, 2023 at 11:28 AM Simon Glass wrote: > > +Heinrich Schuchardt > > Hi, > > On Wed, 29 Nov 2023 at 08:29, Ba Gia Bao Phan > wrote: > > > > Hello everyone, > > > > I am a trainee at STMicroelectronics France. I am working on a project > > "Setting up a boot chain ACPI" for STM32

[PATCH v2] pci: Enable dm_pci_map_bar() for 64-bit BARs

2023-11-28 Thread Moritz Fischer
Allow dm_pci_map_bar() usage on systems with CONFIG_SYS_PCI_64BIT. Reviewed-by: Philip Oberfichtner Signed-off-by: Moritz Fischer --- Changes from v1: - Fixed commit message --- drivers/pci/pci-uclass.c | 11 +++ include/pci.h| 4 ++-- 2 files changed, 13 insertions(+), 2

[PATCH] pci: Enable dm_pci_map_bar() for 64-bit BARs

2023-11-24 Thread Moritz Fischer
Allow dm_pci_map_bar() usage on systems with CONFIG_PCI_SYS_64BIT. Signed-off-by: Moritz Fischer --- drivers/pci/pci-uclass.c | 11 +++ include/pci.h| 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c

[PATCH 2/2] nvme: Update scan namespace to keep trying on busy

2023-11-22 Thread Moritz Fischer
A busy controller shouldn't be game-over for all controllers, so keep trying on hitting -EBUSY. This change brings the actual behavior of the routine in line with what the descriptions says. Fixes: 982388eaa991 ("nvme: Add NVM Express driver support") Signed-off-by: Moritz Fische

[PATCH 1/2] nvme: Fix error code and log to indicate busy

2023-11-22 Thread Moritz Fischer
Return -EBUSY if controller is found busy rather than -ENOMEM and update the error message accordingly. Fixes: 982388eaa991 ("nvme: Add NVM Express driver support") Signed-off-by: Moritz Fischer --- drivers/nvme/nvme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[PATCH] MAINTAINERS: Fix ARCH_APPLE file paths

2023-11-22 Thread Moritz Fischer
Fixes a filepath in MAINTAINERS file that wasn't updated when renaming the files to match the new SoC name. Fixes: a4bd5e4120d6 ('arm: apple: Change SoC name from "m1" into "apple"') Signed-off-by: Moritz Fischer --- MAINTAINERS | 2 +- 1 file changed, 1 inse

Re: [PATCH 2/2] acpi: Move MCFG implementation to common lib

2022-02-07 Thread Moritz Fischer
Hi Simon, On Mon, Feb 7, 2022 at 12:22 PM Simon Glass wrote: > > Hi Moritz, > > On Sat, 5 Feb 2022 at 13:17, Moritz Fischer wrote: > > > > MCFG tables are used on multiple arches. Move to common ACPI lib. > > > > Cc: Simon Glass > > Signed-off-by: Mor

Re: [U-Boot] [OE-core] [PATCH] u-boot: Upgrade to 2017.09

2017-09-22 Thread Moritz Fischer
Hi Marek, On Fri, Sep 22, 2017 at 3:19 PM, Marek Vasut wrote: > On 09/21/2017 11:35 PM, Philip Balister wrote: >> On 09/19/2017 04:15 AM, Marek Vasut wrote: >>> On 09/18/2017 06:06 PM, Tom Rini wrote: On Mon, Sep 18, 2017 at 04:51:31PM +0100, Burton, Ross wrote: > On 18 September 2017 at

[U-Boot] [PATCH v3] i2c: muxes: pca954x: Add support for GPIO reset line

2017-09-12 Thread Moritz Fischer
This commit adds support for GPIO reset lines matching the common linux "reset-gpios" devicetree binding. Signed-off-by: Moritz Fischer Reviewed-by: Heiko Schocher Reviewed-by: Simon Glass --- Changes from v2: - Removed ifdef that would break build as suggested by Simon - Added S

[U-Boot] [PATCH v2] i2c: muxes: pca954x: Add support for GPIO reset line

2017-09-11 Thread Moritz Fischer
This commit adds support for GPIO reset lines matching the common linux "reset-gpios" devicetree binding. Signed-off-by: Moritz Fischer --- Changes from v1: - Simon's feedback on ifdef vs IS_ENABLED() --- drivers/i2c/muxes/pca954x.c | 42 +++

Re: [U-Boot] [PATCH] i2c: muxes: pca954x: Add support for GPIO reset line

2017-09-08 Thread Moritz Fischer
Hi Simon, On Fri, Sep 8, 2017 at 9:55 PM, Simon Glass wrote: > On 5 September 2017 at 12:24, Moritz Fischer wrote: >> This commit adds support for GPIO reset lines matching the >> common linux "reset-gpios" devicetree binding. >> >> Signed-off-by: Moritz

[U-Boot] [PATCH] i2c: muxes: pca954x: Add support for GPIO reset line

2017-09-05 Thread Moritz Fischer
This commit adds support for GPIO reset lines matching the common linux "reset-gpios" devicetree binding. Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Stefan Roese Cc: Marek Behún Cc: Simon Glass Cc: Michal Simek --- drivers/i2c/muxes/pca9

Re: [U-Boot] [PATCH 4/5] test: overlay: Add unit test for stacked overlay

2017-07-07 Thread Moritz Fischer
Hi Pantelis, nit inline On Fri, Jun 30, 2017 at 9:23 AM, Pantelis Antoniou wrote: > Verify that stacked overlays work. > > Signed-off-by: Pantelis Antoniou Reviewed-by: Moritz Fischer > --- > test/overlay/Makefile | 1 + > test/overlay/cmd_ut_overlay.

Re: [U-Boot] [RFC/PATCH 1/2] ni: zynq: Add support for NI Ettus Research Project Sulfur Rev2 SDR

2017-07-05 Thread Moritz Fischer
On Thu, Jun 29, 2017 at 3:22 AM, Michal Simek wrote: > On 23.6.2017 22:57, Moritz Fischer wrote: >> Add support for second revision of NI Ettus Research Project Sulfur >> Revision 2 SDR board. >> >> Signed-off-by: Moritz Fischer >> --- >> arch/arm/dts/Ma

Re: [U-Boot] [PATCH] arm: zynq: Label whole PL part as fpga_full region

2017-06-29 Thread Moritz Fischer
Hi Michal, can you / did you send this to the kernel ML, too? On Thu, Jun 29, 2017 at 3:14 AM, Michal Simek wrote: > This will simplify dt overlay structure for the whole PL. > > Signed-off-by: Michal Simek Reviewed-by: Moritz Fischer > --- > > arch/arm/dts/zynq-7000.dtsi

[U-Boot] [RFC/PATCH 2/2] ni: zynq: Add support for NI Ettus Research Project Sulfur Rev3 SDR

2017-06-23 Thread Moritz Fischer
Add support for second revision of NI Ettus Research Project Sulfur Revision 3 SDR board. Signed-off-by: Moritz Fischer --- arch/arm/dts/Makefile| 1 + arch/arm/dts/zynq-ni-sulfur-rev3-uboot.dtsi | 26 ++ arch/arm/dts/zynq-ni-sulfur-rev3.dts | 325

[U-Boot] [RFC/PATCH 1/2] ni: zynq: Add support for NI Ettus Research Project Sulfur Rev2 SDR

2017-06-23 Thread Moritz Fischer
Add support for second revision of NI Ettus Research Project Sulfur Revision 2 SDR board. Signed-off-by: Moritz Fischer --- arch/arm/dts/Makefile| 1 + arch/arm/dts/zynq-ni-sulfur-rev2-uboot.dtsi | 16 ++ arch/arm/dts/zynq-ni-sulfur-rev2.dts | 275

[U-Boot] [RFC/PATCH 0/2] Support for NI Ettus Research Project Sulfur

2017-06-23 Thread Moritz Fischer
le so suggestions are welcome. My reasoning was that future modifications might be easier if I don't have to mess with the common file via #if defined() for stuff that is NI/Ettus specific in the board/xilinx/zynq directory. Thanks, Moritz Moritz Fischer (2): ni: zynq: Add support for NI Ettu

Re: [U-Boot] [PATCH 1/2] common: image: update boot_get_fpga to support arbitrary fpga image

2017-02-20 Thread Moritz Fischer
Hi all, On Mon, Feb 20, 2017 at 6:59 AM, Michal Simek wrote: > Definitely I am open to improve this subsystem to make it more flexible. Over at linux-fpga ([1]) we're currently discussing the idea of coming up with a header format (vendor neutral) that we stitch onto the fpga image to allow the

Re: [U-Boot] ZYNQ direct MAC connection

2017-02-13 Thread Moritz Fischer
xed-link work for the cadence gem. Maybe you can use that as a starting point. It definitely does work. I'll submit the linux one eventually, feel free to comment or improve. Cheers, Moritz From 2526c6b641c5fb87b7469cd3fdef59de3d870b5e Mon Sep 17 00:00:00 2001 From: Moritz Fischer Date:

Re: [U-Boot] [PATCH] cros_ec: i2c: Add support for version 3 of the EC protocol

2017-01-27 Thread Moritz Fischer
Hi Simon, On Thu, Jan 26, 2017 at 3:23 PM, Simon Glass wrote: > Unfortunately due to travel I'm not going to be able to try this > out/review it for two more weeks. No problem, I'm travelling too at the moment. Moritz ___ U-Boot mailing list U-Boot@l

[U-Boot] [PATCH v2] cros_ec: i2c: Add support for version 3 of the EC protocol

2017-01-20 Thread Moritz Fischer
Add support for version 3 of the ec protocol. It basically works by stitching some additional header in front (special command code), and having a result and packet_length stitched on for the reply. Signed-off-by: Moritz Fischer Cc: Simon Glass Cc: u-boot@lists.denx.de --- Changes from v1

[U-Boot] [PATCH RESEND v2 3/4] i2c: i2c-cdns: Implement workaround for hold quirk of the rev 1.0

2017-01-16 Thread Moritz Fischer
, i.e. the I2C bus is known non-active. The workaround is based on the implementation in the linux-kernel. Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- Changes from v1: - Fixed the removal/addition of printf/debug --- drivers/i2c/i2c-cdns.c | 119

[U-Boot] [PATCH RESEND v2 4/4] i2c: i2c-cdns: No need for dedicated probe function

2017-01-16 Thread Moritz Fischer
The generic probe code in dm works, so get rid of the leftover cruft. Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- Changes from v1: - None --- drivers/i2c/i2c-cdns.c | 21 - 1 file changed, 21 deletions(-) diff --git a

[U-Boot] [PATCH RESEND v2 2/4] i2c: i2c-cdns: Reorder timeout loop for interrupt waiting

2017-01-16 Thread Moritz Fischer
Reorder the timeout loop such that we first check if the condition is already true, and then call udelay() so if the condition is already true, break early. Reviewed-by: Michal Simek Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- Changes from v1

[U-Boot] [PATCH RESEND v2 1/4] i2c: i2c-cdns: Detect unsupported sequences for rev 1.0

2017-01-16 Thread Moritz Fischer
when the IP can really not do it. Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- Changes from v1: - Removed additional blank lines - No longer modify printout paths - Rebased on top of prior patches for r1p14 support --- drivers/i2c/i2c-cdns.c | 66

[U-Boot] [PATCH v2] i2c: mux: Allow muxes to work as children of i2c bus without i2c-parent

2017-01-16 Thread Moritz Fischer
For mux check if the parent is already a device of UCLASS_I2C and if yes just use that. Otherwise see if someone specified an i2c-parent phandle. This mimics the behavior found in the Kernel, as it removes the requirement to explicitly specify a i2c-parent phandle. Signed-off-by: Moritz Fischer

[U-Boot] [PATCH] cros_ec: i2c: Add support for version 3 of the EC protocol

2017-01-12 Thread Moritz Fischer
Add support for version 3 of the ec protocol. It basically works by stitching some additional header in front (special command code), and having a result and packet_length stitched on for the reply. Signed-off-by: Moritz Fischer Cc: Simon Glass Cc: u-boot@lists.denx.de --- Hi Simon, I tested

[U-Boot] [RFC/PATCH] cros_ec: i2c: Group i2c write / read into single transaction

2017-01-12 Thread Moritz Fischer
Replace dm_i2c_write() / dm_i2c_read() with transaction using struct i2c_msg[2] in order to allow for i2c controller to detect write/read cycle to emit a repeated start condition. Signed-off-by: Moritz Fischer Cc: Simon Glass Cc: u-boot@lists.denx.de --- Hi Simon, since I don't have

[U-Boot] [PATCH v2 2/4] i2c: i2c-cdns: Reorder timeout loop for interrupt waiting

2017-01-06 Thread Moritz Fischer
Reorder the timeout loop such that we first check if the condition is already true, and then call udelay() so if the condition is already true, break early. Reviewed-by: Michal Simek Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- Changes from v1

[U-Boot] [PATCH v2 4/4] i2c: i2c-cdns: No need for dedicated probe function

2017-01-06 Thread Moritz Fischer
The generic probe code in dm works, so get rid of the leftover cruft. Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- Changes from v1: - None --- drivers/i2c/i2c-cdns.c | 21 - 1 file changed, 21 deletions(-) diff --git a

[U-Boot] [PATCH v2 1/4] i2c: i2c-cdns: Detect unsupported sequences for rev 1.0

2017-01-06 Thread Moritz Fischer
when the IP can really not do it. Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- Changes from v1: - Removed additional blank lines - No longer modify printout paths - Rebased on top of prior patches for r1p14 support --- drivers/i2c/i2c-cdns.c | 66

[U-Boot] [PATCH v2 3/4] i2c: i2c-cdns: Implement workaround for hold quirk of the rev 1.0

2017-01-06 Thread Moritz Fischer
, i.e. the I2C bus is known non-active. The workaround is based on the implementation in the linux-kernel. Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- Changes from v1: - Fixed the removal/addition of printf/debug --- drivers/i2c/i2c-cdns.c | 119

Re: [U-Boot] [PATCH] i2c: mux: Allow muxes to work as children of i2c bus without i2c-parent

2017-01-03 Thread Moritz Fischer
Hi Michal, On Tue, Jan 3, 2017 at 1:22 AM, Michal Simek wrote: > On 2.1.2017 20:20, Moritz Fischer wrote: >> Hi Michal, >> >> On Mon, Jan 2, 2017 at 6:24 AM, Michal Simek wrote: >>> On 29.12.2016 23:50, Moritz Fischer wrote: >>>> For mux check if the pa

Re: [U-Boot] [PATCH 1/4] i2c: i2c-cdns: Detect unsupported sequences for rev 1.0

2017-01-02 Thread Moritz Fischer
Hi Michal, On Mon, Jan 2, 2017 at 6:29 AM, Michal Simek wrote: > +Siva: please test it. > > On 27.12.2016 23:46, Moritz Fischer wrote: >> Revision 1.0 of this IP has a couple of issues, such as not supporting >> repeated start conditions for read transfers. >> >>

Re: [U-Boot] [PATCH] i2c: mux: Allow muxes to work as children of i2c bus without i2c-parent

2017-01-02 Thread Moritz Fischer
Hi Michal, On Mon, Jan 2, 2017 at 6:24 AM, Michal Simek wrote: > On 29.12.2016 23:50, Moritz Fischer wrote: >> For mux check if the parent is already a device of UCLASS_I2C and if yes >> just use that. Otherwise see if someone specified an i2c-parent phandle. >> This mimics

[U-Boot] [PATCH] i2c: mux: Allow muxes to work as children of i2c bus without i2c-parent

2016-12-29 Thread Moritz Fischer
For mux check if the parent is already a device of UCLASS_I2C and if yes just use that. Otherwise see if someone specified an i2c-parent phandle. This mimics the behavior found in the Kernel, as it removes the requirement to explicitly specify a i2c-parent phandle. Signed-off-by: Moritz Fischer

[U-Boot] [PATCH 4/4] i2c: i2c-cdns: No need for dedicated probe function

2016-12-27 Thread Moritz Fischer
The generic probe code in dm works, so get rid of the leftover cruft. Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- drivers/i2c/i2c-cdns.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/i2c/i2c-cdns.c b

[U-Boot] [PATCH 3/4] i2c: i2c-cdns: Implement workaround for hold quirk of the rev 1.0

2016-12-27 Thread Moritz Fischer
, i.e. the I2C bus is known non-active. The workaround is based on the implementation in the linux-kernel. Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- drivers/i2c/i2c-cdns.c | 121 - 1 file changed

[U-Boot] [PATCH 2/4] i2c: i2c-cdns: Reorder timeout loop for interrupt waiting

2016-12-27 Thread Moritz Fischer
Reorder the timeout loop such that we first check if the condition is already true, and then call udelay() so if the condition is already true, break early. Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- drivers/i2c/i2c-cdns.c | 2 +- 1 file

[U-Boot] [PATCH 1/4] i2c: i2c-cdns: Detect unsupported sequences for rev 1.0

2016-12-27 Thread Moritz Fischer
when the IP can really not do it. Signed-off-by: Moritz Fischer Cc: Heiko Schocher Cc: Michal Simek Cc: u-boot@lists.denx.de --- drivers/i2c/i2c-cdns.c | 69 -- 1 file changed, 55 insertions(+), 14 deletions(-) diff --git a/drivers/i2c/i2c-cdns.c

Re: [U-Boot] [PATCH] ARM64: zynqmp: Fix i2c node's compatible string

2016-12-24 Thread Moritz Fischer
Hi Michal, On Wed, Dec 21, 2016 at 11:35 PM, Michal Simek wrote: > compatible = "cdns,i2c-r1p14", "cdns,i2c-r1p10"; I keep getting that wrong .. .damn ... :) Will resubmit. > The same of course for u-boot where also p14 should be added to the driver. Yeah, I realized that part after submittin

[U-Boot] [PATCH 2/2] ARM64: zynqmp: Fix i2c node's compatible string

2016-12-22 Thread Moritz Fischer
The Zynq Ultrascale MP uses version 1.4 of the Cadence IP core which fixes some silicon bugs that needed software workarounds in Version 1.0 that was used on Zynq systems. Signed-off-by: Moritz Fischer Cc: Michal Simek Cc: Heiko Schocher --- arch/arm/dts/zynqmp.dtsi | 4 ++-- 1 file changed

[U-Boot] [PATCH 1/2] i2c: cdns: Add additional compatible string for r1p14 of the IP.

2016-12-22 Thread Moritz Fischer
Adding additional compatible string for version 1.4 of the IP block. Signed-off-by: Moritz Fischer Cc: Michal Simek Cc: Heiko Schocher --- drivers/i2c/i2c-cdns.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/i2c-cdns.c b/drivers/i2c/i2c-cdns.c index f49f60b..ef85a70 100644

[U-Boot] [PATCH] ARM64: zynqmp: Fix i2c node's compatible string

2016-12-21 Thread Moritz Fischer
From: Moritz Fischer The Zynq Ultrascale MP uses version 1.4 of the Cadence IP core which fixes some silicon bugs that needed software workarounds in Version 1.0 that was used on Zynq systems. Signed-off-by: Moritz Fischer Cc: Michal Simek Cc: Sören Brinkmann Cc: U-Boot List Cc: Rob Herring

Re: [U-Boot] [PATCH 2/4] ARM: zynq: Remove spi-max-frequency

2016-12-16 Thread Moritz Fischer
Hi Michal, On Fri, Dec 16, 2016 at 5:38 AM, Michal Simek wrote: > spi-max-frequency for spi bus depends on devices which are > connected to it. Remove this parameter from dtsi file. > > Signed-off-by: Michal Simek > --- > > arch/arm/dts/zynq-7000.dtsi | 2 -- > 1 file changed, 2 deletions(-) >

Re: [U-Boot] [PATCH] zynq: spi: Honour the activation / deactivation delay

2016-12-15 Thread Moritz Fischer
Michal, On Wed, Dec 14, 2016 at 11:23 PM, Michal Simek wrote: > On 14.12.2016 20:13, Moritz Fischer wrote: >> Whoops, >> >> On Thu, Dec 8, 2016 at 12:11 PM, Moritz Fischer >> wrote: >>> This is not currently implemented. Add support for this so that the &

Re: [U-Boot] [PATCH] zynq: spi: Honour the activation / deactivation delay

2016-12-14 Thread Moritz Fischer
Whoops, On Thu, Dec 8, 2016 at 12:11 PM, Moritz Fischer wrote: > This is not currently implemented. Add support for this so that the > Chrome OS EC can be used reliably. > > Signed-off-by: Moritz Fischer > Cc: Jagan Teki > Cc: Simon Glass > Cc: u-boot@lists.den

[U-Boot] [PATCH v2] ARM: dt: zynq: Add labels to cpu nodes to allow overriding OPPs.

2016-12-12 Thread Moritz Fischer
By adding labels to the cpu nodes in the dtsi, a dts that includes it can change the OPPs by referencing the cpu0 through the label. [Based on linux (400b6a0cbef55d1ae32808eaa1ef1c28820bf6ac)] Signed-off-by: Moritz Fischer Cc: Michal Simek Cc: u-boot@lists.denx.de --- Ok, since I fatfingered

[U-Boot] [PATCH 01/12] ARM: dt: zynq: Add labels to cpu nodes to allow overriding OPPs.

2016-12-12 Thread Moritz Fischer
By adding labels to the cpu nodes in the dtsi, a dts that includes it can change the OPPs by referencing the cpu0 through the label. [Based on linux (400b6a0cbef55d1ae32808eaa1ef1c28820bf6ac)] Signed-off-by: Moritz Fischer Cc: Michal Simek Cc: u-boot@lists.denx.de --- Hi Michal, I thought

[U-Boot] [PATCH] zynq: spi: Honour the activation / deactivation delay

2016-12-08 Thread Moritz Fischer
This is not currently implemented. Add support for this so that the Chrome OS EC can be used reliably. Signed-off-by: Moritz Fischer Cc: Jagan Teki Cc: Simon Glass Cc: u-boot@lists.denx.de --- drivers/spi/zynq_spi.c | 24 1 file changed, 24 insertions(+) diff --git a

Re: [U-Boot] [PATCH RESEND 6/9] eeprom: Add DS2431 support

2016-11-11 Thread Moritz Fischer
Hi Maxime, On Tue, Nov 8, 2016 at 2:19 AM, Maxime Ripard wrote: > Add a driver for the Maxim DS2431 1-Wire EEPROM > > Signed-off-by: Maxime Ripard > --- > drivers/eeprom/Kconfig | 6 ++ > drivers/eeprom/Makefile | 1 + > drivers/eeprom/ds2431.c | 38 ++

Re: [U-Boot] [PATCH RESEND 5/9] EEPROM: Add an EEPROM uclass

2016-11-11 Thread Moritz Fischer
Hi Maxime, On Fri, Nov 11, 2016 at 8:17 AM, Simon Glass wrote: > Hi Maxime, > > On 8 November 2016 at 03:19, Maxime Ripard > wrote: >> We might want to access data stored onto EEPROMs. Create a framework to >> provide a consistent API. > > We have UCLASS_I2C_EEPROM. Can we unify these? If not, p

[U-Boot] [PATCH v2] cmd: crosec: Move cros_ec_decode_region helper to cmd/cros_ec.c

2016-11-03 Thread Moritz Fischer
The cros_ec_decode_region() function is only used in combination with the crosec cmds. Move the function to the correct place. Signed-off-by: Moritz Fischer Cc: Simon Glass Cc: Masahiro Yamada Cc: u-boot@lists.denx.de --- Changes from v1: * make cros_ec_decode_region static * move over the

[U-Boot] [PATCH] cmd: crosec: Move crosec_decode_region helper to cmd/cros_ec.c

2016-10-28 Thread Moritz Fischer
The cros_ec_decode_region() function is only used in combination with the crosec cmds. Move the function to the correct place. Signed-off-by: Moritz Fischer Cc: Simon Glass Cc: Masahiro Yamada Cc: u-boot@lists.denx.de --- cmd/cros_ec.c | 16 drivers/misc/cros_ec.c

Re: [U-Boot] [PATCH] ARM: zynq: Extend picozed board support

2016-10-17 Thread Moritz Fischer
Hi Oscar, On Mon, Oct 17, 2016 at 5:33 PM, Oscar Gomez Fuente wrote: > Ok Michal, > > Then you're suggesting change the zynq-picozed.dts file to: If you're planning to include this into others, make it a .dtsi file. > > diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.dts

Re: [U-Boot] [PATCH 2/3] ARM: zynq(mp): remove unneeded CONFIG_USB_MAX_CONTROLLER_COUNT defines

2016-10-14 Thread Moritz Fischer
+86,6 @@ >> >> #ifdef CONFIG_USB_EHCI_ZYNQ >> # define CONFIG_EHCI_IS_TDI >> -# define CONFIG_USB_MAX_CONTROLLER_COUNT 2 >> >> # define CONFIG_SYS_DFU_DATA_BUF_SIZE0x60 >> # define DFU_DEFAULT_POLL_TIMEOUT300 >> > > Acked-by: Michal Simek Acked-by: Moritz Fischer Cheers, Moritz ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2] cmd: cros_ec: Move crosec commands to cmd subdirectory

2016-10-04 Thread Moritz Fischer
Move crosec commands from drivers/misc/cros_ec.c to cmd/cros_ec.c Acked-by: Simon Glass Signed-off-by: Moritz Fischer Cc: Simon Glass Cc: Heiko Schocher Cc: Bin Meng Cc: Miao Yan Cc: Masahiro Yamada Cc: Stefan Roese Cc: Przemyslaw Marczak Cc: Maxime Ripard Cc: Nishanth Menon Cc: u-boot

Re: [U-Boot] [PATCH] cmd: cros_ec: Move crosec commands to cmd subdirectory

2016-10-04 Thread Moritz Fischer
Hi Simon, On Tue, Oct 4, 2016 at 8:37 AM, Simon Glass wrote: >> +menu "Firmware commands" >> +config CMD_CROS_EC >> + bool "Enable crosec command" >> + depends on CROS_EC > > Can this be enabled by default if CROS_EC is enabled? At present I > think your change will disable it. Will

[U-Boot] [PATCH] cmd: cros_ec: Move crosec commands to cmd subdirectory

2016-10-03 Thread Moritz Fischer
Move crosec commands from drivers/misc/cros_ec.c to cmd/cros_ec.c Signed-off-by: Moritz Fischer Cc: Simon Glass Cc: Heiko Schocher Cc: Bin Meng Cc: Miao Yan Cc: Masahiro Yamada Cc: Stefan Roese Cc: Przemyslaw Marczak Cc: Maxime Ripard Cc: Nishanth Menon Cc: u-boot@lists.denx.de --- cmd

[U-Boot] [PATCH] cros_ec: Honor the google,remote-bus dt property

2016-09-27 Thread Moritz Fischer
Boards where ECs that use a I2C port != 0 specify this in the devicetree file via the google,remote-bus property. Previously this was ignored and hardcoded to port 0. Signed-off-by: Moritz Fischer Cc: Simon Glass Cc: Heiko Schocher Cc: u-boot@lists.denx.de --- drivers/i2c/cros_ec_tunnel.c

Re: [U-Boot] Chrome OS keyboard not responding on snow

2016-09-26 Thread Moritz Fischer
Hi Adam On Mon, Sep 26, 2016 at 12:35 PM, Adam Van Ymeren wrote: > I'm trying to run the latest u-boot on the old samsung exynos5250 > chromebook (snow_defconfig). I've managed to get the u-boot console > up but it doesn't respond to keyboard input. > > I managed to hack the startup procedure to

[U-Boot] [PATCH 1/2] cros_ec: Add function to read back flash parameters

2016-09-13 Thread Moritz Fischer
Add support for reading back flash parameters as reported by the ec. Signed-off-by: Moritz Fischer Cc: Simon Glass Cc: u-boot@lists.denx.de --- drivers/misc/cros_ec.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/misc/cros_ec.c b/drivers/misc/cros_ec.c

[U-Boot] [PATCH 2/2] cros_ec: Add crosec flashinfo command

2016-09-13 Thread Moritz Fischer
Add command to print out the flash info as reported by the ec. The data read back includes size, write block size, erase block size. Signed-off-by: Moritz Fischer Cc: Simon Glass Cc: u-boot@lists.denx.de --- drivers/misc/cros_ec.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a

[U-Boot] [PATCH v2] cros_ec: Fix issue with cros_ec_flash_write command

2016-09-12 Thread Moritz Fischer
This commit fixes an issue where data is written to an invalid memory location. The issue has been introduced in commit (88364387 cros: add cros_ec_driver) Cc: Simon Glass Cc: u-boot@lists.denx.de Signed-off-by: Moritz Fischer --- Changes from v1: - Fixed accidential change of command version

Re: [U-Boot] [PATCH] cros_ec: Fix issue with cros_ec_flash_write command

2016-09-12 Thread Moritz Fischer
Hi Simon, On Mon, Sep 12, 2016 at 1:48 PM, Moritz Fischer wrote: > - return ec_command_inptr(dev, EC_CMD_FLASH_WRITE, 0, > - &p, sizeof(p), NULL, 0) >= 0 ? 0 : -1; > + ret = ec_command_inptr(dev, EC_CMD_FLASH_WRITE, 1, > +

[U-Boot] [PATCH] cros_ec: Fix issue with cros_ec_flash_write command

2016-09-12 Thread Moritz Fischer
This commit fixes an issue where data is written to an invalid memory location. The issue has been introduced in commit 88364387 cros: add cros_ec_driver Signed-off-by: Moritz Fischer Cc: u-boot@lists.denx.de --- drivers/misc/cros_ec.c | 25 ++--- 1 file changed, 18

Re: [U-Boot] [PATCH 2/3] serial: zynq: Read information about clock from DT

2016-07-18 Thread Moritz Fischer
- >> 1 file changed, 27 insertions(+), 1 deletion(-) > > Reviewed-by: Simon Glass Reviewed-by: Moritz Fischer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCHv2][RESEND] spi: Add support for N25Q016A

2016-07-14 Thread Moritz Fischer
Jagan, thanks for your review! On Thu, Jul 14, 2016 at 12:01 AM, Jagan Teki wrote: > On 14 July 2016 at 00:00, Moritz Fischer wrote: >> Signed-off-by: Moritz Fischer >> --- >> drivers/mtd/spi/sf_params.c | 1 + >> 1 file changed, 1 insertion(+) >> >> d

[U-Boot] [PATCHv3] spi: Add support for N25Q016A

2016-07-14 Thread Moritz Fischer
This commit adds support in the spi-nor driver for the N25Q016A, a 16Mbit SPI NOR flash from Micron. Signed-off-by: Moritz Fischer --- drivers/mtd/spi/sf_params.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 4f37e33..0ac7971

[U-Boot] [PATCHv2][RESEND] spi: Add support for N25Q016A

2016-07-13 Thread Moritz Fischer
Signed-off-by: Moritz Fischer --- drivers/mtd/spi/sf_params.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 4f37e33..8ae4eea 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -83,6 +83,7 @@ const

[U-Boot] [PATCHv2][RESEND] spi: Add support for N25016A

2016-04-25 Thread Moritz Fischer
Signed-off-by: Moritz Fischer --- drivers/mtd/spi/sf_params.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 4f37e33..8ae4eea 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -83,6 +83,7 @@ const

Re: [U-Boot] [PATCHv2] sf: params: Add support for n25q016a

2016-04-12 Thread Moritz Fischer
On Thu, Mar 31, 2016 at 11:06 AM, Moritz Fischer wrote: > This commits adds support for the N25Q016A, a 16Mbit > serial NOR flash from Micron. > > Signed-off-by: Moritz Fischer > --- > Changes from v1: > > * RD_FULL > * WR_QPP as suggested by Marek > > drive

[U-Boot] [PATCHv2] sf: params: Add support for n25q016a

2016-03-31 Thread Moritz Fischer
This commits adds support for the N25Q016A, a 16Mbit serial NOR flash from Micron. Signed-off-by: Moritz Fischer --- Changes from v1: * RD_FULL * WR_QPP as suggested by Marek drivers/mtd/spi/sf_params.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi/sf_params.c b/drivers

Re: [U-Boot] [PATCH] sf: params: Add support for n25q016a

2016-03-30 Thread Moritz Fischer
Hi Marek, On Wed, Mar 30, 2016 at 5:34 PM, Marek Vasut wrote: > On 03/31/2016 12:23 AM, Moritz Fischer wrote: >> This commits adds support for the N25Q016A, a 16Mbit >> serial NOR flash from Micron. >> >> Signed-off-by: Moritz Fischer >> --- >> drive

[U-Boot] [PATCH] sf: params: Add support for n25q016a

2016-03-30 Thread Moritz Fischer
This commits adds support for the N25Q016A, a 16Mbit serial NOR flash from Micron. Signed-off-by: Moritz Fischer --- drivers/mtd/spi/sf_params.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 4f37e33..8ae4eea 100644 --- a

Re: [U-Boot] [PATCH] ARM: zynq: Enable SPL RAM support by default

2016-02-17 Thread Moritz Fischer
On Tue, Feb 16, 2016 at 11:39 PM, Michal Simek wrote: > Use RAM support in jtagboot mode. > > Signed-off-by: Michal Simek Reviewed-by: Moritz Fischer Looks good to me, Moritz ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.d

Re: [U-Boot] [PATCH] serial: zynq: Change logic in putc

2016-02-07 Thread Moritz Fischer
�� sdhci@ff17: 0 > Using default environment > > Signed-off-by: Michal Simek Reviewed-by: Moritz Fischer > --- > > drivers/serial/serial_zynq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/serial/serial_zynq.c b/drivers/seri

Re: [U-Boot] [PATCH] ARM: zynq: Remove unused SPI base addresses

2016-02-04 Thread Moritz Fischer
On Thu, Feb 4, 2016 at 1:07 AM, Michal Simek wrote: > Remove unused macros. Adresses are taken from DT. > > Signed-off-by: Michal Simek Reviewed-by: Moritz Fischer > --- > > arch/arm/include/asm/arch-zynqmp/hardware.h | 3 --- > arch/arm/mach-zynq/include/mach/hardware

Re: [U-Boot] [PATCH] ARM: zynq: Add function to get reboot status register value.

2016-01-27 Thread Moritz Fischer
Hi Michal, On Wed, Jan 27, 2016 at 2:15 PM, Michal Simek wrote: > On 27.1.2016 12:22, Moritz Fischer wrote: >> Signed-off-by: Moritz Fischer >> --- >> Hi Michal, >> >>I was planning to use this in future to boot into recovery mode. >>The chan

[U-Boot] [PATCH] ARM: zynq: Add function to get reboot status register value.

2016-01-27 Thread Moritz Fischer
Signed-off-by: Moritz Fischer --- Hi Michal, I was planning to use this in future to boot into recovery mode. The change is small enough I feel that we could directly take it. If you want to hold off until there's a user that's fine for me, too. Cheers, Moritz --- arc

  1   2   >