Re: [PATCH 1/1] bootflow: always initialize bootflow_iter_set_dev parameters

2024-04-12 Thread Nam Cao
On 2024-04-11 Nam Cao wrote: > On 11/Apr/2024 Heinrich Schuchardt wrote: > > method_flags may be passed uninitialized to bootflow_iter_set_dev() > > if dev is not NULL. > > > > Always initialize method_flags. > > > > Addresses-Coverity-ID: 467057 Uninitia

Re: [PATCH 1/1] bootflow: always initialize bootflow_iter_set_dev parameters

2024-04-10 Thread Nam Cao
On 11/Apr/2024 Heinrich Schuchardt wrote: > method_flags may be passed uninitialized to bootflow_iter_set_dev() > if dev is not NULL. > > Always initialize method_flags. > > Addresses-Coverity-ID: 467057 Uninitialized scalar variable > Signed-off-by: Heinrich Schuchardt

Re: [PATCH] starfive: visionfive2: switch to standard boot

2024-03-14 Thread Nam Cao
On 13/Mar/2024 Milan P. Stanić wrote: > On Wed, 2024-02-21 at 13:00, Nam Cao wrote: > > Distro boot scripts are deprecated. Use standard boot instead. > I had to enable 'CONFIG_CMD_SYSBOOT=y' in > configs/starfive_visionfive2_defconfig because it doesn't boot wit

[PATCH] bootstd: support scanning a single partition

2024-02-21 Thread Nam Cao
low scan mmc1:4 which scans only mmc device 1, partition 4. Signed-off-by: Nam Cao --- boot/bootdev-uclass.c | 35 +-- boot/bootflow.c | 3 +++ doc/develop/bootstd.rst | 4 include/bootflow.h | 3 +++ 4 files changed, 43 insertions(+), 2 del

[PATCH] starfive: visionfive2: switch to standard boot

2024-02-21 Thread Nam Cao
Distro boot scripts are deprecated. Use standard boot instead. Signed-off-by: Nam Cao --- configs/starfive_visionfive2_defconfig | 2 +- include/configs/starfive-visionfive2.h | 14 +- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/configs

[PATCH v2 2/2] riscv: dts: starfive: add regulator device

2024-01-29 Thread Nam Cao
Add the axp15060 regulator device. OpenSBI uses this device to perform board reset and shutdown. Signed-off-by: Nam Cao --- v2: "stf,axp15060-regulator" -> "x-powers,axp15060" to match Linux. arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi | 5 + 1 file changed

[PATCH v2 1/2] riscv: dts: jh7110: add power management unit controller node

2024-01-29 Thread Nam Cao
JH7110 has a power management unit controller node. Add this node. This device is used by OpenSBI during board reset/shutdown. Signed-off-by: Nam Cao --- arch/riscv/dts/jh7110.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/riscv/dts/jh7110.dtsi b/arch/riscv/dts/jh7110.dtsi

[PATCH v2 0/2] Add device tree nodes needed by OpenSBI on Visionfive 2

2024-01-29 Thread Nam Cao
This series adds 2 device tree nodes. These are needed by OpenSBI to perform reset/shutdown of the board. v2: - rename "compatible" property to match the one in Linux. - extra clarification in commit messages. Nam Cao (2): riscv: dts: jh7110: add power management unit contr

Re: riscv defconfig starfive visionfive2 env is nowhere, missing axp15060 regulator, misc vendor hacks for Milk-V Mars CM Lite

2024-01-26 Thread Nam Cao
On Fri, 26 Jan 2024 02:53:45 -0800 E Shattow wrote: > There is missing the AXP15060 power regulation in u-boot needed for SDCard > and networking. As it is happens to work for some variants and not others, > and not always. The AXP15060 driver exists in mainline Linux as a variant > of AXP20x and

Re: [PATCH 1/2] riscv: dts: starfive: add regulator device

2024-01-17 Thread Nam Cao
On Wed, 17 Jan 2024 12:15:25 +0100 Nam Cao wrote: > Add the axp15060 regulator device. OpenSBI uses this device to perform > board reset and shutdown. > > Signed-off-by: Nam Cao > --- > arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi | 5 + > 1 file changed, 5 in

[PATCH 2/2] riscv: dts: jh7110: add power management unit controller node

2024-01-17 Thread Nam Cao
JH7110 has a power management unit controller node. Add this node. This device is used by OpenSBI during board reset and shutdown. Signed-off-by: Nam Cao --- arch/riscv/dts/jh7110.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/riscv/dts/jh7110.dtsi b/arch/riscv/dts/jh7110

[PATCH 1/2] riscv: dts: starfive: add regulator device

2024-01-17 Thread Nam Cao
Add the axp15060 regulator device. OpenSBI uses this device to perform board reset and shutdown. Signed-off-by: Nam Cao --- arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi b/arch/riscv