Re: [PATCH v2 5/5] arm: apple: Do not list bootflows on boot

2024-04-18 Thread Neal Gompa
S_PBSIZE=276 > # CONFIG_DISPLAY_CPUINFO is not set > CONFIG_DISPLAY_BOARDINFO_LATE=y > +CONFIG_BOOTCOMMAND="bootflow scan -b" > CONFIG_BOARD_LATE_INIT=y > CONFIG_CMD_SELECT_FONT=y > # CONFIG_NET is not set > > -- > 2.44.0 > Reviewed-by: Neal Gompa -- 真実はいつも一つ!/ Always, there's only one truth!

Re: [PATCH v2 4/5] arm: apple: Switch to standard boot

2024-04-18 Thread Neal Gompa
) > -#endif > - > -#define BOOT_TARGET_DEVICES(func) \ > - BOOT_TARGET_NVME(func) \ > - BOOT_TARGET_USB(func) > - > -#include > +#define BOOT_TARGETS "nvme usb" > > #define CFG_EXTRA_ENV_SETTINGS \ > ENV_DEVICE_SETTINGS \ > - BOOTENV > + "boot_targets=" BOOT_TARGETS "\0" > > #endif > > -- > 2.44.0 > Reviewed-by: Neal Gompa -- 真実はいつも一つ!/ Always, there's only one truth!

Re: [PATCH 0/4] configs: apple: Switch to standard boot + small adjustments

2024-03-17 Thread Neal Gompa
++ > include/configs/apple.h| 24 > 3 files changed, 8 insertions(+), 21 deletions(-) > --- > base-commit: f3c979dd0053c082d2df170446923e7ce5edbc2d > change-id: 20240317-apple_config-981fcd9028b9 > LGTM. Reviewed-by: Neal Gompa -- 真実はいつも一つ!/ Always, there's only one truth!

Re: [PATCH v2 0/6] USB keyboard improvements for asahi / desktop systems

2024-03-17 Thread Neal Gompa
rs/usb/host/xhci.c | 126 > +++ > include/env_default.h| 11 > include/usb.h| 6 +++ > 7 files changed, 227 insertions(+), 50 deletions(-) > --- > base-commit: 37345abb97ef0dd9c50a03b2a72617612dcae585 > change-id: 20240218-asahi-keyboards-f2ddaf0022b2 > Series LGTM. Thanks for this! :) Reviewed-by: Neal Gompa -- 真実はいつも一つ!/ Always, there's only one truth!

Re: [PATCH v2] arm: apple: t602x: Add missing MMIO regions to memmap

2023-12-01 Thread Neal Gompa
.phys = 0x248000, > + .size = SZ_1G, > + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > + PTE_BLOCK_NON_SHARE | > + PTE_BLOCK_PXN | PTE_BLOCK_UXN > }, { > /* I/O */ > .virt = 0x258000, > > --- > base-commit: 43f2873fa98b1da6eb56d756315c7bd7db63db27 > change-id: 20231130-apple_t602x_extend_memmap-c82c522ca8c0 > LGTM. Reviewed-by: Neal Gompa -- 真実はいつも一つ!/ Always, there's only one truth!

Re: [PATCH v2 0/8] USB fixes: xHCI error handling

2023-10-29 Thread Neal Gompa
/host/xhci-ring.c | 99 > > drivers/usb/host/xhci.c | 9 > include/usb/xhci.h | 2 + > 3 files changed, 92 insertions(+), 18 deletions(-) > --- > base-commit: 7c0d668103abae3ec14cd96d882ba20134bb4529 > change-id: 20231027-usb-fixes-1-83bfc7013012 > Series LGTM. Reviewed-by: Neal Gompa -- 真実はいつも一つ!/ Always, there's only one truth!

Re: [PATCH 0/2] USB fixes: (Re)implement timeouts

2023-10-29 Thread Neal Gompa
- > drivers/usb/host/xhci-ring.c| 32 > drivers/usb/host/xhci.c | 28 > include/usb.h | 10 ++ > include/usb/xhci.h | 14 ++ > 10 files changed, 72 insertions(+), 63 deletions(-) > --- >

Re: [PATCH] usb: Ignore endpoints in non-zero altsettings

2023-10-29 Thread Neal Gompa
epno = dev->config.if_desc[ifno].no_of_ep; > if_desc = >config.if_desc[ifno]; > if (epno >= USB_MAXENDPOINTS) { > > --- > base-commit: 8ad1c9c26f7740806a162818b790d4a72f515b7e > change-id: 20231029-usb-fixes-4-ba6931acf217 > Irritating, but makes sense. Reviewed-by: Neal Gompa -- 真実はいつも一つ!/ Always, there's only one truth!

Re: [PATCH 0/4] USB fixes: Mass Storage bugs & 64bit support

2023-10-29 Thread Neal Gompa
9c26f7740806a162818b790d4a72f515b7e > change-id: 20231029-usb-fixes-3-c72f829ba61b Series LGTM. Reviewed-by: Neal Gompa -- 真実はいつも一つ!/ Always, there's only one truth!

Re: [PATCH 0/2] USB fixes: Add missing timeout, ignore YubiKeys

2023-10-29 Thread Neal Gompa
++ > 2 files changed, 26 insertions(+) > --- > base-commit: 8ad1c9c26f7740806a162818b790d4a72f515b7e > change-id: 20231029-usb-fixes-2-976486d1603c > Series LGTM. Reviewed-by: Neal Gompa -- 真実はいつも一つ!/ Always, there's only one truth!

Re: [PATCH 0/8] USB fixes: xHCI error handling

2023-10-27 Thread Neal Gompa
On Fri, Oct 27, 2023 at 2:58 PM Neal Gompa wrote: > > On Thu, Oct 26, 2023 at 7:26 PM Hector Martin wrote: > > > > This series is the first of a few bundles of USB fixes we have been > > carrying downstream on the Asahi U-Boot branch for a few months. > > > >

Re: [PATCH 0/8] USB fixes: xHCI error handling

2023-10-27 Thread Neal Gompa
+ > drivers/usb/host/xhci.c | 9 > include/usb/xhci.h | 2 + > 3 files changed, 92 insertions(+), 19 deletions(-) > --- > base-commit: fb428b61819444b9337075f49c72f326f5d12085 > change-id: 20231027-usb-fixes-1-83bfc7013012 > The series looks reaso