[U-Boot] [PATCH v5 1/1] usb: gadget: avoid variable name clipping in cb_getvar

From: Nicolas Le Bayon Instead of using a fixed-size array to store variable name, preferring a dynamic allocation treats correctly all variable name lengths. Variable names are growing through releases and features. By this way, name clipping is prevented. Signed-off-by: Nicolas Le Bayon

Re: [U-Boot] [PATCH v5 1/1] usb: gadget: avoid variable name clipping in cb_getvar

Hi Lukasz, Would it be possible to have a look at this patch and review it please? Thanks in advance for your time Best Regards Nicolas 2017-03-17 13:26 GMT+01:00 Marek Vasut : > On 03/17/2017 10:57 AM, Nicolas le bayon wrote: > > From: Nicolas Le Bayon > > > > Instead

Re: [U-Boot] [PATCH v5 1/1] usb: gadget: avoid variable name clipping in cb_getvar

Hi Lukasz, A kind reminder to look at this patch (already reviewed by Marek). Thanks in advance for your time Best Regards Nicolas 2017-03-21 9:53 GMT+01:00 Nicolas le bayon : > Hi Lukasz, > > Would it be possible to have a look at this patch and review it please? > > Thanks

[U-Boot] [PATCH v6 1/1] usb: gadget: avoid variable name clipping in cb_getvar

From: Nicolas Le Bayon Instead of using a fixed-size array to store variable name, preferring a dynamic allocation treats correctly all variable name lengths. Variable names are growing through releases and features. By this way, name clipping is prevented. Signed-off-by: Nicolas Le Bayon

Re: [U-Boot] [PATCH v6 1/1] usb: gadget: avoid variable name clipping in cb_getvar

2017-04-03 13:34 GMT+02:00 Marek Vasut : > On 04/03/2017 11:50 AM, Lukasz Majewski wrote: > > On Mon, 3 Apr 2017 11:28:44 +0200 > > Nicolas le bayon wrote: > > > >> From: Nicolas Le Bayon > >> > >> Instead of using a fixed-size array to store var

Re: [U-Boot] [PATCH RESEND v6] usb: gadget: avoid variable name clipping in cb_getvar

-Original Message- From: Marek Vasut [mailto:ma...@denx.de] Sent: lundi 3 avril 2017 15:25 To: Nicolas LE BAYON ; u-boot@lists.denx.de; lu...@denx.de Cc: nleba...@gmail.com; Patrice CHOTARD ; Jean-philippe ROMAIN Subject: Re: [U-Boot][PATCH RESEND v6] usb: gadget: avoid variable name

[U-Boot] generating a script file in FIT_SIGNATURE context

Hi all, In my setup, I have activated FIT (without signature in a first step), and I boot using standard script way (boot.scr), which I generate with the following command : mkimage -A arm -T script -C none -n "My boot script" -d boot.txt boot.scr It works fine, and I can "load" and "bootm" the

Re: [U-Boot] generating a script file in FIT_SIGNATURE context

From: Nicolas LE BAYON Sent: mardi 11 avril 2017 14:50 To: u-boot@lists.denx.de Subject: [U-Boot] generating a script file in FIT_SIGNATURE context Hi all, In my setup, I have activated FIT (without signature in a first step), and I boot using standard script way (boot.scr), which I generate

Re: [U-Boot] [PATCH] usb gadget: increase envstr size in cb_getvar

Hi, would it be possible to consider this patch please? Best Regards Nicolas 2016-09-21 10:43 GMT+02:00 Nicolas le bayon : > Hi, > > I propose you this patch in order to take into account strings larger than > actual size (32). I recently faced to 'fastboot.partition-type:us

Re: [U-Boot] [PATCH] usb gadget: increase envstr size in cb_getvar

; would it be possible to consider this patch please? >>> >>> Best Regards >>> Nicolas >>> >>> 2016-09-21 10:43 GMT+02:00 Nicolas le bayon : >>> >>> Hi, >>>> >>>> I propose you this patch in order to take into account strin

[U-Boot] [PATCH v2] usb: gadget: dynamic envstr size in cb_getvar

Hi, here is a second patch proposal with a dynamic size allocation for evstr in cb_getvar. Thanks in advance for your feedback/approval. Best Regards Nicolas --- --- drivers/usb/gadget/f_fastboot.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/f_f

Re: [U-Boot] [PATCH v2] usb: gadget: dynamic envstr size in cb_getvar

you a v3 release as soon as possible. Sorry agan Best Regards Nicolas 2017-03-10 13:22 GMT+01:00 Marek Vasut : > On 03/10/2017 12:03 PM, Nicolas le bayon wrote: > > Hi, > > > > here is a second patch proposal with a dynamic size allocation for evstr > in > >

[U-Boot] [PATCH v3] usb: gadget: dynamic envstr size in cb_getvar

From: Nicolas Le Bayon use dynamic allocation to consider all variable lengths Signed-off-by: Nicolas Le Bayon --- drivers/usb/gadget/f_fastboot.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget

Re: [U-Boot] [PATCH v3] usb: gadget: dynamic envstr size in cb_getvar

2017-03-10 17:52 GMT+01:00 Marek Vasut : > On 03/10/2017 05:31 PM, Nicolas le bayon wrote: > > From: Nicolas Le Bayon > > > > use dynamic allocation to consider all variable lengths > > Of what ? Where ? Why ? > Here is a proposal of updated label: usb: gadget: d

[U-Boot] [PATCH v4 1/1] usb: gadget: avoid variable name clipping in cb_getvar

From: Nicolas Le Bayon Instead of using a fixed-size array to store variable name, preferring a dynamic allocation treats correctly all variable name lengths. Variable names are growing through releases and features. By this way, name clipping is prevented. Signed-off-by: Nicolas Le Bayon

Re: [U-Boot] [PATCH v7] usb: gadget: avoid variable name clipping in cb_getvar

Hi, A kind reminder to look at this patch (already reviewed by Marek and acked by Lukasz), and if possible to put it in the next pull list, or the one after is timing is too short. Thanks in advance for your time Best Regards Nicolas -Original Message- From: Nicolas LE BAYON Sent

[U-Boot] usb start on a specific instance

Hi, Would it be possible to execute an "usb start" on one single instance in order to save boot time. Indeed, regarding the different USB ports on my platform, it takes a long time to scan all the instances. Because my boot system will always be on a specific instance, would it be possible to scan

[U-Boot] interaction between CONFIG_CMD_SAVEENV and CONFIG_BOOTCOMMAND

Hi Let me firstly explain my need. We use U-boot as a primary bootloader, with a bootcmd which loads and executes a script on one external device (SD ou USB). This script will continue the boot process (launch a kernel for example). The corresponding bootcmd defined in CONFIG_BOOTCOMMAND does this

Re: [U-Boot] interaction between CONFIG_CMD_SAVEENV and CONFIG_BOOTCOMMAND

Would that really be enough? Please keep in mind that "env save" (or "saveenv") is only responsible for storing the current environment into persistant storage. It does not modify the environment at all. To modify the environment, you can use quite a number of commands, including "env set", "env

Re: [U-Boot] interaction between CONFIG_CMD_SAVEENV and CONFIG_BOOTCOMMAND

Dear Wolfgang, Regarding your recommendations about U-Boot usage, I completely agree with that. In fact, In my description, I wouldn't give too many details, but your answer leads me to add some :-) As I told you, this "old" u-boot is used only as primary bootloader, and its main objective is jus

[U-Boot] [FASTBOOT] increase envstr[] length from 32 to 64

Hi, The following commit has been pushed in order to retrieve envrionment variables for fastboot: fastboot: allow retrieving fastboot variables from env (74322201dde4593dc3194c702e95e5760e6b497a) The file is drivers/usb/gadget/f_fastboot.c, function is cb_getvar It uses à 32-char array (char env

[U-Boot] fatwrite issue in sub-directories

Hi all, With a quite old u-boot release (October 2015 more or less), I has some different issues around fatwrite operations. I realigned a few things around FAT with latest release, and now I observe only one issue. Maybe this has been discussed here before, I searched but no success. I'd like to

Re: [U-Boot] fatwrite issue in sub-directories

Hi Benoît, 2016-07-20 21:42 GMT+02:00 Benoît Thébaudeau < benoit.thebaudeau@gmail.com>: > Hi Nicolas, > > On Wed, Jul 20, 2016 at 6:21 PM, Nicolas le bayon > wrote: > > Hi all, > > > > With a quite old u-boot release (October 2015 more or less), I

[U-Boot] Booting kernel/dtb with FIT image

Hi, Here is a problem I presently meet, any help or track to follow would be welcome. My U-boot (2016.09) loads a kernel and a dtb, and "bootm" all this. This is my reference, and this is correctly running. >From this, I'm trying to implement FIT image management, so I enabled CONFIG_FIT. On th

Re: [U-Boot] Booting kernel/dtb with FIT image

2017-01-13 23:39 GMT+01:00 André Przywara : > On 13/01/17 17:13, Nicolas le bayon wrote: > > Hi, > > > > Here is a problem I presently meet, any help or track to follow would be > > welcome. > > > > My U-boot (2016.09) loads a kernel and a dtb, and "

[U-Boot] [PATCH] usb gadget: increase envstr size in cb_getvar

Hi, I propose you this patch in order to take into account strings larger than actual size (32). I recently faced to 'fastboot.partition-type:userdata' (it was in Android context) but this could be the case for other purposes. I propose to simply double the size. Is it ok for you? Regards ---