Re: [PATCH v2 2/3] drivers: gpio: keep output value for input on sandbox

2020-09-14 Thread Philippe REYNES
> For testing purposes keep the output value when switching to input. > This allows us to manipulate the input value via the gpio command. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Philippe Reynes > --- > v2: > new patch > --- > drivers/gpio/sandbox

[PATCH v3 2/2] sandbox: enable support of generic udp protocol

2020-09-11 Thread Philippe Reynes
This commit enable the support of the generic udp protocol. Signed-off-by: Philippe Reynes Reviewed-by: Simon Glass --- Changelog: v3: - no change v2: - new patch in the serie configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs

[PATCH v3 1/2] net: add a generic udp protocol

2020-09-11 Thread Philippe Reynes
This commit adds a generic udp protocol framework in the network loop. So protocol based on udp may be implemented without modifying the network loop (for example custom wait magic packet). Signed-off-by: Philippe Reynes Reviewed-by: Simon Glass --- Changelog: v3: - add file doc/README.udp

Re: Improvements to FIT ciphering

2020-09-10 Thread Philippe REYNES
Hi Patrick, Sorry for the late answer, I was very busy in the beginning of september >> >> I agree that IV should be set in the FIT. >> >> So in the dts, we may have: >> cipher { >> algo = "aes256"; >> key-name-hint = "aeskey"; >> iv = "aesiv"; >> }; >> or (I propose) : >> cipher { >> algo =

Re: [PATCH 1/1] cmd/button: return button status

2020-09-04 Thread Philippe REYNES
> To make the button command useful in a shell script it should return the > status of the button: > > * 0 (true) - pressed, on > * 1 (false) - not pressed, off > > The button command takes only one argument. Correct maxargs. > > Signed-off-by: Heinrich Schucha

Re: [PATCH] net: add a generic udp protocol

2020-08-31 Thread Philippe REYNES
Hi Tom > On Fri, Aug 21, 2020 at 07:55:05PM +0200, Philippe Reynes wrote: > >> This commit adds a generic udp protocol framework in the >> network loop. So protocol based on udp may be implemented >> without modifying the network loop (for example custom >> wait ma

[PATCH v2 2/2] sandbox: enable support of generic udp protocol

2020-08-31 Thread Philippe Reynes
This commit enable the support of the generic udp protocol. Signed-off-by: Philippe Reynes --- Changelog: v2: - new patch in the serie configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 6e9f029..5ceff7d

[PATCH v2 1/2] net: add a generic udp protocol

2020-08-31 Thread Philippe Reynes
This commit adds a generic udp protocol framework in the network loop. So protocol based on udp may be implemented without modifying the network loop (for example custom wait magic packet). Signed-off-by: Philippe Reynes --- Changelog: v2: - no change include/net.h | 2 +- include/net

Re: Improvements to FIT ciphering

2020-08-24 Thread Philippe REYNES
Hi Patrick, >> >> Hi Patrick, >> >> Sorry for this late anwser, I was very busy this week. > > No problem! Again, sorry I was off and then busy. > Before I address your comments below, is there anything else I need to > do with the previous patches I posted? I haven't contributed to U-Boot >

[PATCH] net: add a generic udp protocol

2020-08-21 Thread Philippe Reynes
This commit adds a generic udp protocol framework in the network loop. So protocol based on udp may be implemented without modifying the network loop (for example custom wait magic packet). Signed-off-by: Philippe Reynes --- include/net.h | 2 +- include/net/udp.h | 31

Re: Improvements to FIT ciphering

2020-08-07 Thread Philippe REYNES
Hi Patrick, Sorry for this late anwser, I was very busy this week. > Hi Simon & Philippe, > > I've been thinking about this some more and have added a few points > below. I will need feedback before proposing any patches for the > remaining issues. > > On Fri, Jul 24, 2020 at 12:06 PM Patrick

Re: [PATCH] mkimage: fit: include image cipher in configuration signature

2020-07-30 Thread Philippe REYNES
an attacker from modifying cipher, key or iv properties. > > Signed-off-by: Patrick Oppenlander Reviewed-by: Philippe Reynes Regards, Philippe > --- > tools/image-host.c | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/tools/image-host.c b/t

Re: [PATCH v2 3/3] mkimage: fit: don't cipher ciphered data

2020-07-30 Thread Philippe REYNES
Hi Patrick, > From: Patrick Oppenlander > > Previously, mkimage -F could be run multiple times causing already > ciphered image data to be ciphered again. Reviewed-by: Philippe Reynes > Signed-off-by: Patrick Oppenlander Regards, Philippe > --- > to

Re: [PATCH v2 2/3] mkimage: fit: handle FDT_ERR_NOSPACE when ciphering

2020-07-30 Thread Philippe REYNES
Hi Patrick, > From: Patrick Oppenlander > > Also replace fdt_delprop/fdt_setprop with fdt_setprop as fdt_setprop can > replace an existing property value. Reviewed-by: Philippe Reynes > Signed-off-by: Patrick Oppenlander Regards, Philippe > --- > to

Re: [PATCH 3/3] mkimage: fit: don't cipher ciphered data

2020-07-29 Thread Philippe REYNES
Hi Patrick, > From: Patrick Oppenlander > > Previously, mkimage -F could be run multiple times causing already > ciphered image data to be ciphered again. Good catch, mkimage -F cipher data that are already ciphered, generating a broken FIT image. > Signed-off-by: Patrick Oppenlander >

Re: [PATCH 2/3] mkimage: fit: handle FDT_ERR_NOSPACE when ciphering

2020-07-29 Thread Philippe REYNES
Hi Patrick > From: Patrick Oppenlander > > This meant that the order of operations had to change. If we replace the > data property first then fail to add the data-size-unciphered property > the data will be ciphered again when retrying. This patch is good, but I disagree with the comment. It

Re: [PATCH 1/3] mkimage: fit: only process one cipher node

2020-07-29 Thread Philippe REYNES
; > + /* Process cipher node if present */ > + cipher_node_offset = fdt_subnode_offset(fit, image_noffset, "cipher"); use FIT_CIPHER_NODENAME instead of hardcoded "cipher" > + if (cipher_node_offset == -FDT_ERR_NOTFOUND) > + return 0; > + if (cipher_node_offset < 0) { > + printf("Failure getting cipher node\n"); > + return -1; > } > - > - return 0; > + if (!IMAGE_ENABLE_ENCRYPT || !keydir) > + return 0; > + return fit_image_process_cipher(keydir, keydest, fit, image_name, > + image_noffset, cipher_node_offset, data, size, cmdname); > } > > /** > -- > 2.27.0 Other than this little remark: Reviewed-by: Philippe Reynes Regards, Philippe

Re: Improvements to FIT ciphering

2020-07-29 Thread Philippe REYNES
Hi Simon and Patrick, Sorry, I've missed this serie of patches. I check them and send a review ASAP. Regards, Philippe > +Philippe Reynes too > > > On Mon, 27 Jul 2020 at 16:50, Patrick Oppenlander > wrote: >> >> On Fri, Jul 24, 2020 at 12:06 PM Pa

Re: [PATCH v2 8/8] test: dm: add a test for class button

2020-07-24 Thread Philippe REYNES
Hi Simon, > Hi Philippe, > > On Mon, 20 Jul 2020 at 08:30, Philippe REYNES > wrote: >> >> Hi Simon, >> >> > Hi Philippe, >> > >> > On Fri, 17 Jul 2020 at 06:22, Philippe Reynes >> > wrote: >> >> >> >&

[PATCH v3 3/8] cmd: button: add a new 'button' command

2020-07-24 Thread Philippe Reynes
Adds a command 'button' that provides the list of buttons supported by the board, and the state of a button. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v3: - no change v2 - no change cmd/Kconfig | 11 cmd/Makefile | 1 + cmd/button.c | 86

[PATCH v3 8/8] test: dm: add a test for class button

2020-07-24 Thread Philippe Reynes
Add a test to confirm that we can read button state using the button-gpio driver. Signed-off-by: Philippe Reynes --- Changelog: v3: - no change v2: - new commit in the serie test/dm/Makefile | 1 + test/dm/button.c | 74 2 files changed

[PATCH v3 6/8] sandbox: enable button

2020-07-24 Thread Philippe Reynes
Enable the support of button (driver and command) on sandbox. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v3: - no change v2: - no change configs/sandbox_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/sandbox_defconfig b/configs

[PATCH v3 4/8] sandbox: dtsi: add buttons

2020-07-24 Thread Philippe Reynes
Adds two buttons on sandbox so button framework may be tested. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v3: - update comptatible to "gpio-keys" v2: - no change arch/sandbox/dts/sandbox.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --

[PATCH v3 2/8] dm: button: add a driver for button driven by gpio

2020-07-24 Thread Philippe Reynes
Add a simple driver which allows use of buttons attached to GPIOs. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v3: - change compatible to gpio-keys and gpio-keys-polled (feedback from Neil Armstrong) v2: - remove useless default in Kconfig - re-order include - fix

[PATCH v3 1/8] dm: button: add an uclass for button

2020-07-24 Thread Philippe Reynes
Add a new uclass for button that implements two functions: - button_get_by_label - button_get_status Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v3: - no change v2: - re-order include - use uclass_id_foreach_dev - add comments to enum button_state_t drivers/Kconfig

[PATCH v3 7/8] test/py: add tests for the button commands

2020-07-24 Thread Philippe Reynes
Adds tests for the button commands. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v3: - update compatible to "gpio-keys" v2: - no change (button uclass test is added in another commit arch/sandbox/dts/test.dts| 14 ++ test/py/tests/test_butt

[PATCH v3 5/8] sandbox64: enable button

2020-07-24 Thread Philippe Reynes
Enable the support of button (driver and command) on sandbox64. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v3: - no change v2: - no change configs/sandbox64_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/sandbox64_defconfig b/configs

[PATCH] sandbox, test: change hog gpio

2020-07-24 Thread Philippe Reynes
ndbox:red LED 'sandbox:red' not found (err=-16) The gpio is already requested by hog, so it can't be enabled for led 'sandbox:red'. This commit change the gpio used by hog to 10, 11, 12 and 13, so the led command could be used again with 'sandbox:red' and 'sandbox:green'. Signed-off-by: Ph

Re: [PATCH v2 8/8] test: dm: add a test for class button

2020-07-20 Thread Philippe REYNES
Hi Simon, > Hi Philippe, > > On Fri, 17 Jul 2020 at 06:22, Philippe Reynes > wrote: >> >> Add a test to confirm that we can read button state >> using the button-gpio driver. >> >> Signed-off-by: Philippe Reynes >> --- >> Changelog: >&

Re: [PATCH 1/1] test/dm: check if devices exist

2020-07-17 Thread Philippe REYNES
Hi Heinrich > Running 'ut dm' on the sandbox without -D or -d results in segmentation > faults due to NULL pointer dereferences. > > Check that device pointers are non-NULL before using them. > > Use ut_assertnonnull() for pointers instead of ut_assert(). Tested-by: Philippe

[PATCH v2 3/8] cmd: button: add a new 'button' command

2020-07-17 Thread Philippe Reynes
Adds a command 'button' that provides the list of buttons supported by the board, and the state of a button. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v2 - no change cmd/Kconfig | 11 cmd/Makefile | 1 + cmd/button.c | 86

[PATCH v2 8/8] test: dm: add a test for class button

2020-07-17 Thread Philippe Reynes
Add a test to confirm that we can read button state using the button-gpio driver. Signed-off-by: Philippe Reynes --- Changelog: v2: - new commit in the serie test/dm/Makefile | 1 + test/dm/button.c | 74 2 files changed, 75 insertions

[PATCH v2 4/8] sandbox: dtsi: add buttons

2020-07-17 Thread Philippe Reynes
Adds two buttons on sandbox so button framework may be tested. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v2: - no change arch/sandbox/dts/sandbox.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/sandbox/dts/sandbox.dtsi b/arch/sandbox

[PATCH v2 7/8] test/py: add tests for the button commands

2020-07-17 Thread Philippe Reynes
Adds tests for the button commands. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v2: - no change (button uclass test is added in another commit arch/sandbox/dts/test.dts| 14 ++ test/py/tests/test_button.py | 19 +++ 2 files changed

[PATCH v2 2/8] dm: button: add a driver for button driven by gpio

2020-07-17 Thread Philippe Reynes
Add a simple driver which allows use of buttons attached to GPIOs. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v2: - remove useless default in Kconfig - re-order include - fix condition in button_gpio_remove drivers/button/Kconfig | 9 drivers/button

[PATCH v2 6/8] sandbox: enable button

2020-07-17 Thread Philippe Reynes
Enable the support of button (driver and command) on sandbox. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v2: - no change configs/sandbox_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index

[PATCH v2 1/8] dm: button: add an uclass for button

2020-07-17 Thread Philippe Reynes
Add a new uclass for button that implements two functions: - button_get_by_label - button_get_status Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v2: - re-order include - use uclass_id_foreach_dev - add comments to enum button_state_t drivers/Kconfig

[PATCH v2 5/8] sandbox64: enable button

2020-07-17 Thread Philippe Reynes
Enable the support of button (driver and command) on sandbox64. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- Changelog: v2: - no change configs/sandbox64_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig

[PATCH 5/7] sandbox64: enable button

2020-07-13 Thread Philippe Reynes
Enable the support of button (driver and command) on sandbox64. Signed-off-by: Philippe Reynes --- configs/sandbox64_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig index a3f049e..89ba504 100644 --- a/configs

[PATCH 7/7] test/py: add tests for the button commands

2020-07-13 Thread Philippe Reynes
Adds tests for the button commands. Signed-off-by: Philippe Reynes --- arch/sandbox/dts/test.dts| 14 ++ test/py/tests/test_button.py | 19 +++ 2 files changed, 33 insertions(+) create mode 100644 test/py/tests/test_button.py diff --git a/arch/sandbox/dts

[PATCH 4/7] sandbox: dtsi: add buttons

2020-07-13 Thread Philippe Reynes
Adds two buttons on sandbox so button framework may be tested. Signed-off-by: Philippe Reynes --- arch/sandbox/dts/sandbox.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/sandbox/dts/sandbox.dtsi b/arch/sandbox/dts/sandbox.dtsi index e1f68cd..bd87dac 100644

[PATCH 1/7] dm: button: add an uclass for button

2020-07-13 Thread Philippe Reynes
Add a new uclass for button that implements two functions: - button_get_by_label - button_get_status Signed-off-by: Philippe Reynes --- drivers/Kconfig| 2 ++ drivers/Makefile | 1 + drivers/button/Kconfig | 12 ++ drivers/button/Makefile

[PATCH 6/7] sandbox: enable button

2020-07-13 Thread Philippe Reynes
Enable the support of button (driver and command) on sandbox. Signed-off-by: Philippe Reynes --- configs/sandbox_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index 5b75693..67801ed 100644 --- a/configs/sandbox_defconfig

[PATCH 3/7] cmd: button: add a new 'button' command

2020-07-13 Thread Philippe Reynes
Adds a command 'button' that provides the list of buttons supported by the board, and the state of a button. Signed-off-by: Philippe Reynes --- cmd/Kconfig | 11 cmd/Makefile | 1 + cmd/button.c | 86 3 files changed, 98

[PATCH 2/7] dm: button: add a driver for button driven by gpio

2020-07-13 Thread Philippe Reynes
Add a simple driver which allows use of buttons attached to GPIOs. Signed-off-by: Philippe Reynes --- drivers/button/Kconfig | 10 drivers/button/Makefile | 1 + drivers/button/button-gpio.c | 111 +++ 3 files changed, 122 insertions

[PATCH] lib: libfdt: fdt_region: avoid NULL pointer access

2020-07-02 Thread Philippe Reynes
. Signed-off-by: Philippe Reynes --- common/fdt_region.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/fdt_region.c b/common/fdt_region.c index 6676590..ff12c51 100644 --- a/common/fdt_region.c +++ b/common/fdt_region.c @@ -65,6 +65,8 @@ int fdt_find_regions(const void *fdt, char

[PATCH v3 1/2] test/py: vboot: add a test to check fit signature on fit with padding

2020-04-29 Thread Philippe Reynes
The pytest vboot does all his tests on fit without padding. We add the same tests on fit with padding. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 52 - 1 file changed, 33 insertions(+), 19 deletions

[PATCH v3 2/2] rsa: sig: fix config signature check for fit with padding

2020-04-29 Thread Philippe Reynes
erty "data" but two properties: "data-offset" and "data-size". So to fix the check of signature, we also don't use the properties "data-offset" and "data-size" when checking the signature on config node. Reviewed-by: Simon Glass Signed-off-by:

[PATCH v3 0/2] test/py: vboot: fix signature check on config node

2020-04-29 Thread Philippe Reynes
signature on fit with padding. The second commit fixes the signature check on config node for fit with padding. Philippe Reynes (2): test/py: vboot: add a test to check fit signature on fit with padding rsa: sig: fix config signature check for fit with padding Changelog: v3: - rebase on master

[PATCH v2 2/2] rsa: sig: fix config signature check for fit with padding

2020-03-28 Thread Philippe Reynes
erty "data" but two properties: "data-offset" and "data-size". So to fix the check of signature, we also don't use the properties "data-offset" and "data-size" when checking the signature on config node. Reviewed-by: Simon Glass Signed-off-by: Phi

[PATCH v2 0/2] test/py: vboot: fix signature check on config node

2020-03-28 Thread Philippe Reynes
signature on fit with padding. The second commit fixes the signature check on config node for fit with padding. Philippe Reynes (2): test/py: vboot: add a test to check fit signature on fit with padding rsa: sig: fix config signature check for fit with padding Changelog: v2: - fix spelling

[PATCH v2 1/2] test/py: vboot: add a test to check fit signature on fit with padding

2020-03-28 Thread Philippe Reynes
The pytest vboot does all his tests on fit without padding. We add the same tests on fit with padding. Reviewed-by: Simon Glass Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 42 -- 1 file changed, 28 insertions(+), 14 deletions

[PATCH 2/2] rsa: sig: fix config signature check for fit with padding

2020-03-27 Thread Philippe Reynes
erty "data" but two properties: "data-offset" and "data-size". So to fix the check of signature, we also dont use the properties "data-offset" and "data-size" when checking the signature on config node. Signed-off-by: Philippe Reynes --- common/im

[PATCH 1/2] test/py: vboot: add a test to check fit signature on fit with padding

2020-03-27 Thread Philippe Reynes
The pytest vboot does all his tests on fit without padding. We add the same tests on fit with padding. Signed-off-by: Philippe Reynes --- test/py/tests/test_vboot.py | 42 -- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/test/py/tests

[PATCH 0/2] test/py: vboot: fix signature check on config node

2020-03-27 Thread Philippe Reynes
signature on fit with padding. The second commit fixes the signature check on config node for fit with padding. Philippe Reynes (2): test/py: vboot: add a test to check fit signature on fit with padding rsa: sig: fix config signature check for fit with padding common/image-sig.c | 2

Re: [PATCH v2] cmd: ubi: add a command to rename volume

2020-03-23 Thread Philippe REYNES
Hi Rasmus, > On 23/03/2020 18.16, Philippe REYNES wrote: > >>>> +#ifdef CONFIG_CMD_UBI_RENAME >>> >>> Can you use IS_ENABLED(CONFIG_...) and drop the #ifdef way above? >> >> I've sent a v3 where I use IS_ENABLED instead of #ifdef. >> B

[PATCH v4] cmd: ubi: add a command to rename volume

2020-03-23 Thread Philippe Reynes
This commit adds the command ubi rename to rename an ubi volume. The format of the command is: ubi rename . To enable this command, the option CMD_UBI_RENAME must be selected. Signed-off-by: Philippe Reynes --- cmd/Kconfig | 8 cmd/ubi.c | 39

Re: [PATCH v2] cmd: ubi: add a command to rename volume

2020-03-23 Thread Philippe REYNES
Hi Simon, > Hi Philippe, > > On Fri, 20 Mar 2020 at 03:55, Philippe Reynes > wrote: >> >> This commit add the command ubi rename to rename an ubi volume. > > adds > >> The format of the command is: ubi rename . >> To enable this comman

[PATCH v3] cmd: ubi: add a command to rename volume

2020-03-23 Thread Philippe Reynes
This commit adds the command ubi rename to rename an ubi volume. The format of the command is: ubi rename . To enable this command, the option CMD_UBI_RENAME must be selected. Signed-off-by: Philippe Reynes --- cmd/Kconfig | 8 cmd/ubi.c | 43

[PATCH v2] cmd: ubi: add a command to rename volume

2020-03-20 Thread Philippe Reynes
This commit add the command ubi rename to rename an ubi volume. The format of the command is: ubi rename . To enable this command, the option CMD_UBI_RENAME must be selected. Signed-off-by: Philippe Reynes --- cmd/Kconfig | 8 cmd/ubi.c | 43

Re: [*** MED SPAM ***]Re: [PATCH] cmd: ubi: add a command to rename volume

2020-03-20 Thread Philippe REYNES
Hi Wolfgang, > Dear Philippe, > > In message <1584644739-10258-1-git-send-email-philippe.rey...@softathome.com> > you wrote: >> This commit add the command ubi rename to rename an ubi volume. >> The format of the command is: ubi rename . > > Can we plase make this optional / configurable?

[PATCH] cmd: ubi: add a command to rename volume

2020-03-19 Thread Philippe Reynes
This commit add the command ubi rename to rename an ubi volume. The format of the command is: ubi rename . Signed-off-by: Philippe Reynes --- cmd/ubi.c | 37 + 1 file changed, 37 insertions(+) diff --git a/cmd/ubi.c b/cmd/ubi.c index cecf251..424f555 100644

Re: [PATCH v2 12/14] image: Use constants for 'required' and 'key-name-hint'

2020-03-18 Thread Philippe REYNES
> Objet: [PATCH v2 12/14] image: Use constants for 'required' and > 'key-name-hint' > These are used in multiple places so update them to use a shared #define. > > Signed-off-by: Simon Glass Reviewed-by: Philippe Reynes > --- > > Changes in v2: None >

Re: [PATCH 2/3] configs: use unified bcmbca nand controller

2020-03-09 Thread Philippe REYNES
> Objet: [PATCH 2/3] configs: use unified bcmbca nand controller > Signed-off-by: Nicolas Heemeryck > Cc: Philippe Reynes Reviewed-by: Philippe Reynes > --- > configs/bcm963158_ram_defconfig | 2 +- > configs/bcm968360bg_ram_defconfig | 2 +- > configs/bcm968580x

Re: [PATCH 3/3] brcmnand: drop arch specific nand controller

2020-03-09 Thread Philippe REYNES
> Objet: [PATCH 3/3] brcmnand: drop arch specific nand controller > Use instead the unified bcmbca controller. > > Signed-off-by: Nicolas Heemeryck > Cc: Philippe Reynes Reviewed-by: Philippe Reynes > --- > drivers/mtd/nand/raw/Kconfig | 18 --- > drivers/mtd/na

Re: [PATCH 1/3] nand: brcmnand: add bcmbca support

2020-03-09 Thread Philippe REYNES
> > The bcmbca controller should support all ARM based bcm63xxx, bcm68xx, > bcm67xx and bcm490x SoCs. > > Signed-off-by: Nicolas Heemeryck > Cc: Philippe Reynes Reviewed-by: Philippe Reynes > --- > drivers/mtd/nand/raw/Kconfig | 6 + > drivers/mtd/nand/raw/brcmnand/Make

[PATCH 6/6] bcm96750ref1: add initial support

2020-03-06 Thread Philippe Reynes
This add the initial support of the broadcom reference board bcm968360bg with a bcm68360 SoC. This board has 1 GB of RAM, 512 MB of flash (nand), 2 USB port, 1 UART, and 4 ethernet ports. Signed-off-by: Philippe Reynes --- arch/arm/Kconfig | 1 + arch/arm/dts

[PATCH 3/6] gpio: bcm6345: allow to use this driver on arm bcm6750

2020-03-06 Thread Philippe Reynes
This IP is also used on some arm SoC, so we allow to use it on arm bcm6750 too. Signed-off-by: Philippe Reynes --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index f751a8b..3a595b8 100644 --- a/drivers

[PATCH 4/6] nand: brcmnand: add bcm6750 support

2020-03-06 Thread Philippe Reynes
This adds the nand support for chipset bcm6750. Signed-off-by: Philippe Reynes --- drivers/mtd/nand/raw/Kconfig | 6 ++ drivers/mtd/nand/raw/brcmnand/Makefile | 1 + drivers/mtd/nand/raw/brcmnand/bcm6750_nand.c | 123 +++ 3 files changed, 130

[PATCH 5/6] watchdog: bcm6345: allow to use this driver on arm bcm6750

2020-03-06 Thread Philippe Reynes
This IP is also used on some arm SoC, so we allow to use it on arm bcm6750 too. Signed-off-by: Philippe Reynes --- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index d24c1e4..2dca5f6 100644

[PATCH 2/6] gpio: do not include on ARCH_BCM6750

2020-03-06 Thread Philippe Reynes
As no gpio.h is defined for this architecture, to avoid compilation failure, do not include for arch bcm6750. Signed-off-by: Philippe Reynes --- arch/arm/include/asm/gpio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm

[PATCH 1/6] bcm6750: add initial support

2020-03-06 Thread Philippe Reynes
This add the initial support of the broadcom bcm6750 SoC family. Signed-off-by: Philippe Reynes --- arch/arm/Kconfig | 7 ++ arch/arm/dts/bcm6750.dtsi | 193 ++ 2 files changed, 200 insertions(+) create mode 100644 arch/arm/dts/bcm6750

[PATCH] tools: image-host.c: remove uboot_aes.h

2020-02-18 Thread Philippe Reynes
The include uboot_aes.h is not usefull and it breaks the compilation on android, so we remove it. Signed-off-by: Philippe Reynes --- tools/image-host.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/image-host.c b/tools/image-host.c index 9483561..76a361b 100644 --- a/tools/image

[PATCH] test: aes: fix memleak

2020-02-06 Thread Philippe Reynes
memory and quit the function. Reported-by: Coverity (CID: 284403) Reported-by: Coverity (CID: 284404) Reported-by: Coverity (CID: 284405) Reported-by: Coverity (CID: 284406) Reported-by: Coverity (CID: 284407) Signed-off-by: Philippe Reynes --- test/lib/test_aes.c | 13 +++-- 1 file

Re: [PATCH V3 1/2] tpm: add a helper to iterate on all tpm devices

2020-01-09 Thread Philippe REYNES
Hi, Sorry, I forgot to report the Reviewed-by of Miquel Raynal. > Objet: [PATCH V3 1/2] tpm: add a helper to iterate on all tpm devices > This add a helper for_each_tpm_device that run > through all the tpm (1.x and 2.0) devices. > > Signed-off-by: Philippe Reynes Reviewed-by

Re: [PATCH V3 2/2] cmd: tpm: add a subcommand device

2020-01-09 Thread Philippe REYNES
the > subcommand device is not used before a tpm (or tpm2) > command, the device 0 is selected. > > Signed-off-by: Philippe Reynes Reviewed-by: Miquel Raynal > --- > cmd/tpm-common.c | 77 +--- > cmd/tpm-user-utils.h | 1 + >

[PATCH V3 2/2] cmd: tpm: add a subcommand device

2020-01-09 Thread Philippe Reynes
. Then the command tpm and tpm2 use the device selected with the subcommand device. To be compatible with previous behaviour, if the subcommand device is not used before a tpm (or tpm2) command, the device 0 is selected. Signed-off-by: Philippe Reynes --- cmd/tpm-common.c | 77

[PATCH V3 1/2] tpm: add a helper to iterate on all tpm devices

2020-01-09 Thread Philippe Reynes
This add a helper for_each_tpm_device that run through all the tpm (1.x and 2.0) devices. Signed-off-by: Philippe Reynes --- include/tpm-common.h | 3 +++ 1 file changed, 3 insertions(+) Changelog: v3: - use the helper uclass_foreach_dev_probe v2: - new patch, add an helper for tpm device

[PATCH] test/cmd_ut.c: fix cmd_ut_category

2020-01-09 Thread Philippe Reynes
if the prefix is not NULL, then we avoid to call the function strncmp with a NULL prefix. Reported-by: Coverity CID 281110 Fixes: 4ad4edfe ("cmd_ut: add a parameter prefix to the function cmd_ut_category") Signed-off-by: Philippe Reynes --- test/cmd_ut.c | 2 +- 1 file changed, 1 inser

[PATCH V2 2/2] cmd: tpm: add a subcommand device

2020-01-09 Thread Philippe Reynes
. Then the command tpm and tpm2 use the device selected with the subcommand device. To be compatible with previous behaviour, if the subcommand device is not used before a tpm (or tpm2) command, the device 0 is selected. Signed-off-by: Philippe Reynes --- cmd/tpm-common.c | 77

[PATCH V2 1/2] tpm: add a helper to iterate on all tpm devices

2020-01-09 Thread Philippe Reynes
This add a helper for_each_tpm_device that run through all the tpm (1.x and 2.0) devices. Signed-off-by: Philippe Reynes --- include/tpm-common.h | 6 ++ 1 file changed, 6 insertions(+) Changelog: v2: - new patch, add an helper for tpm device (idea from Miquel) diff --git a/include/tpm

[PATCH] cmd: tpm: add a subcommand device

2020-01-08 Thread Philippe Reynes
. Then the command tpm and tpm2 use the device selected with the subcommand device. To be compatible with previous behaviour, if the subcommand device is not used before a tpm (or tpm2) command, the device 0 is selected. Signed-off-by: Philippe Reynes --- cmd/tpm-common.c | 75

[PATCH 8/8] bcm968360bg: add initial support

2020-01-07 Thread Philippe Reynes
This add the initial support of the broadcom reference board bcm968360bg with a bcm68360 SoC. This board has 512 MB of RAM, 256 MB of flash (nand), 2 USB port, 1 UART, and 4 ethernet ports. Signed-off-by: Philippe Reynes --- arch/arm/Kconfig | 1 + arch/arm/dts

[PATCH 3/8] spi: bcm63xx-hsspi: allow to use this driver on arm bcm68360

2020-01-07 Thread Philippe Reynes
This IP is also used on some arm SoC, so we allow to use it on arm bcm68360 too. Signed-off-by: Philippe Reynes --- drivers/spi/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index fae2040..73d1a69 100644 --- a/drivers/spi

[PATCH 5/8] led: bcm6858: allow to use this driver on arm bcm68360

2020-01-07 Thread Philippe Reynes
This IP is also used on some arm SoC, so we allow to use it on arm bcm68360 too. Signed-off-by: Philippe Reynes --- drivers/led/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig index 5643939..6675934 100644 --- a/drivers/led

[PATCH 6/8] gpio: bcm6345: allow to use this driver on arm bcm68360

2020-01-07 Thread Philippe Reynes
This IP is also used on some arm SoC, so we allow to use it on arm bcm68360 too. Signed-off-by: Philippe Reynes --- drivers/gpio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 1de6f52..4e5a707 100644 --- a/drivers

[PATCH 4/8] nand: brcmnand: add bcm68360 support

2020-01-07 Thread Philippe Reynes
This adds the nand support for chipset bcm68360. Signed-off-by: Philippe Reynes --- drivers/mtd/nand/raw/Kconfig | 6 ++ drivers/mtd/nand/raw/brcmnand/Makefile| 1 + drivers/mtd/nand/raw/brcmnand/bcm68360_nand.c | 123 ++ 3 files changed, 130

[PATCH 7/8] gpio: do not include on ARCH_BCM68360

2020-01-07 Thread Philippe Reynes
As no gpio.h is defined for this architecture, to avoid compilation failure, do not include for arch bcm68360. Signed-off-by: Philippe Reynes --- arch/arm/include/asm/gpio.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/include/asm/gpio.h b/arch/arm

[PATCH 2/8] watchdog: bcm6345: allow to use this driver on arm bcm68360

2020-01-07 Thread Philippe Reynes
This IP is also used on some arm SoC, so we allow to use it on arm bcm68360 too. Signed-off-by: Philippe Reynes --- drivers/watchdog/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig index 8c16d69..2b8064d 100644

[PATCH 1/8] bcm68360: add initial support

2020-01-07 Thread Philippe Reynes
This add the initial support of the broadcom bcm68360 SoC family. Signed-off-by: Philippe Reynes --- arch/arm/Kconfig | 6 ++ arch/arm/dts/bcm68360.dtsi | 217 + 2 files changed, 223 insertions(+) create mode 100644 arch/arm/dts/bcm68360

[PATCH V4 4/4] aes: add test unit for aes196 and aes256

2020-01-06 Thread Philippe Reynes
This commit add test unit for aes196 and aes256. Signed-off-by: Philippe Reynes --- test/lib/test_aes.c | 4 1 file changed, 4 insertions(+) Changelog: v4: - no change v3: - new patch in this serie (in the previous version, the test to aes was added to pytest, now, we add test unit

[PATCH V4 2/4] aes: add support of aes192 and aes256

2020-01-06 Thread Philippe Reynes
Until now, we only support aes128. This commit add the support of aes192 and aes256. Signed-off-by: Philippe Reynes --- arch/arm/mach-tegra/tegra20/crypto.c | 41 ++- cmd/aes.c| 38 -- include/uboot_aes.h | 34

[PATCH V4 3/4] aes: add test unit for aes128

2020-01-06 Thread Philippe Reynes
This commit add test unit for aes128. Signed-off-by: Philippe Reynes --- test/lib/Makefile | 1 + test/lib/test_aes.c | 162 2 files changed, 163 insertions(+) create mode 100644 test/lib/test_aes.c Changelog: v4: - Put test/ headers

[PATCH V4 1/4] aes: add a define for the size of a block

2020-01-06 Thread Philippe Reynes
In the code, we use the size of the key for the size of the block. It's true when the key is 128 bits, but it become false for key of 192 bits and 256 bits. So to prepare the support of aes192 and 256, we introduce a constant for the iaes block size. Signed-off-by: Philippe Reynes --- cmd

[PATCH V4 0/4] aes: add support for aes192 and aes256

2020-01-06 Thread Philippe Reynes
a test unit for aes128, and the forth add a test unit for aes 196 and aes256. Philippe Reynes (4): aes: add a define for the size of a block aes: add support of aes192 and aes256 aes: add test unit for aes128 aes: add test unit for aes196 and aes256 arch/arm/mach-tegra/tegra20/crypto.c

Re: [PATCH V2 4/4] pytest: aes: add test for aes192 and aes256

2020-01-06 Thread Philippe REYNES
Hi Simon, > Hi Philippe, > > On Thu, 31 Oct 2019 at 07:33, Philippe REYNES > wrote: >> >> Hi Simonn >> >> > Hi Philippe, >> > >> > On Tue, 29 Oct 2019 at 11:29, Philippe Reynes >> > wrote: >> >>

[PATCH 2/2] u-boot: fit: add support to decrypt fit with aes

2019-12-18 Thread Philippe Reynes
This commit add to u-boot the support to decrypt fit image encrypted with aes. The FIT image contains the key name and the IV name. Then u-boot look for the key and IV in his device tree and decrypt images before moving to the next stage. Signed-off-by: Philippe Reynes --- common/image-cipher.c

[PATCH 1/2] mkimage: fit: add support to encrypt image with aes

2019-12-18 Thread Philippe Reynes
. Signed-off-by: Philippe Reynes --- Kconfig | 8 ++ common/Makefile | 1 + common/image-cipher.c | 63 +++ common/image-fit.c| 27 + include/image.h | 63 +++ include/u-boot/aes.h | 31 ++ lib/aes/aes-encrypt.c | 136

[PATCH] cmd_ut: add a parameter prefix to the function cmd_ut_category

2019-12-17 Thread Philippe Reynes
. Signed-off-by: Philippe Reynes --- include/test/suites.h | 4 +++- test/bloblist.c | 3 ++- test/cmd_ut.c | 12 ++-- test/compression.c| 3 ++- test/env/cmd_ut_env.c | 3 ++- test/lib/cmd_ut_lib.c | 2 +- test/optee

[U-Boot] [PATCH] cmd: cp: add missing map_sysmem

2019-12-02 Thread Philippe Reynes
The command cp fails on sandbox because the address is used directly. To fix this issue, we call the function map_sysmem to translate the address. Signed-off-by: Philippe Reynes --- cmd/mem.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/cmd/mem.c b/cmd

<    1   2   3   4   5   6   >