Vincent Stehlé writes:
Hi,
> Hi U-Boot folks,
>
> Hopefully this is the right way to report bugs. If not, please do not hesitate
> to let me know.
>
> I am hitting an issue with U-Boot v2021.07 on the ROCKPro64, when booting
> Linux
> with UEFI from USB. The kernel EFI stub will hang:
>
>
Kever Yang writes:
Hi,
> Hi Tom,
>
> Please pull the rockchip updates/fixes:
> - Fix rk3368 lion board support;
> - Fix px30 odroid-go2 board support;
> - Add rk3399 NanoPi R4s and NanoPi M4B board support;
Sorry for annoying you again. Is there some reply I missed about my
latest version of
In order to ensure that the VOP registers are in correct state,
add missing support for the VOP reset lines found in the device-tree
Signed-off-by: Arnaud Patard
Tested-by: Peter Robinson
Index: u-boot/drivers/video/rockchip/rk_vop.c
In order to ensure that the eDP registers are in correct state,
add missing support for the eDP reset lines found in the device-tree.
Signed-off-by: Arnaud Patard
Tested-by: Peter Robinson
Index: u-boot/drivers/video/rockchip/rk_edp.c
According to linux commit "drm/rockchip: analogix_dp: add rk3399 eDP
support" (82872e42bb1501dd9e60ca430f4bae45a469aa64), rk3288 and rk3399
eDP IPs are nearly the same, the difference is in the grf register
(SOC_CON6 versus SOC_CON20). So, change the code to use the right
register on each IP.
The
The debug string printing the device name, framebuffer address and of node
is using %lu as format for the framebuffer address, which is not so nice.
Change it to %lx.
Signed-off-by: Arnaud Patard
Tested-by: Peter Robinson
Index: u-boot/drivers/video/rockchip/rk_vop.c
When booting with EFI and graphics, the memory used for framebuffer
has to be reserved, otherwise it may leads to kernel memory
overwrite.
Signed-off-by: Arnaud Patard
Tested-by: Peter Robinson
Index: u-boot/drivers/video/rockchip/rk_vop.c
The linux code is setting polarity configuration to 3 but
uboot code is setting it to 1. Change the configuration to match the
linux configuration
Signed-off-by: Arnaud Patard
Tested-by: Peter Robinson
Index: u-boot/arch/arm/include/asm/arch-rockchip/edp_rk3288.h
The current code is using an hard coded enum and the of node reg value of
endpoint to find out if the endpoint is mipi/hdmi/lvds/edp/dp. The order
is different between rk3288, rk3399 vop little, rk3399 vop big.
A possible solution would be to make sure that the rk3288.dtsi and
rk3399.dtsi files
- uboot rockchip edp code is looking for a rockchip,panel property
for the edp dts node, so add it.
Signed-off-by: Arnaud Patard
Tested-by: Peter Robinson
Index: u-boot/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
===
---
In the code, the default polarity is set to positive/positive,
which is neither normal polarity or inverted polarity. It's
only the hardware default. This leads to booting linux with
wrong polarity setting.
Update the code to use PWM_DUTY_POSTIVE | PWM_INACTIVE_NEGATIVE
by default instead.
This patchset add support for the rk3399 eDP. It has been tested on the pinebook
pro and Google Kevin chromeos devices.
The changes have been written by studying the linux code, since I didn't find
any
manual for theses part of the RK3399 SoC.
On the linux kernel side, on recent kernels, it
Kever Yang writes:
Hi,
> Hi Tom,
>
> Please pull the rockchip updates/fixes:
> - New board: rk3328 NanoPi R2S board;
> - Fix init voltage for some rk3399 boards;
> - enable rng for rk3399 by default;
> - set default to SPI bus 1 for SPI-flash for some board;
> - add dwc PCIe controller driver
The debug string printing the device name, framebuffer address and of node
is using %lu as format for the framebuffer address, which is not so nice.
Change it to %lx.
Signed-off-by: Arnaud Patard
Index: u-boot/drivers/video/rockchip/rk_vop.c
This patchset add support for the rk3399 eDP. It has been tested on the pinebook
pro and Google Kevin chromeos devices.
The changes have been written by studying the linux code, since I didn't find
any
manual for theses part of the RK3399 SoC.
On the linux kernel side, on recent kernels, it
According to linux commit "drm/rockchip: analogix_dp: add rk3399 eDP
support" (82872e42bb1501dd9e60ca430f4bae45a469aa64), rk3288 and rk3399
eDP IPs are nearly the same, the difference is in the grf register
(SOC_CON6 versus SOC_CON20). So, change the code to use the right
register on each IP.
The
In order to ensure that the VOP registers are in correct state,
add missing support for the VOP reset lines found in the device-tree
Signed-off-by: Arnaud Patard
Index: u-boot/drivers/video/rockchip/rk_vop.c
===
---
In order to ensure that the eDP registers are in correct state,
add missing support for the eDP reset lines found in the device-tree.
Signed-off-by: Arnaud Patard
Index: u-boot/drivers/video/rockchip/rk_edp.c
===
---
When booting with EFI and graphics, the memory used for framebuffer
has to be reserved, otherwise it may leads to kernel memory
overwrite.
Signed-off-by: Arnaud Patard
Index: u-boot/drivers/video/rockchip/rk_vop.c
===
---
In the code, the default polarity is set to positive/positive,
which is neither normal polarity or inverted polarity. It's
only the hardware default. This leads to booting linux with
wrong polarity setting.
Update the code to use PWM_DUTY_POSTIVE | PWM_INACTIVE_NEGATIVE
by default instead.
- uboot rockchip edp code is looking for a rockchip,panel property
for the edp dts node, so add it.
Signed-off-by: Arnaud Patard
Index: u-boot/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
===
---
The linux code is setting polarity configuration to 3 but
uboot code is setting it to 1. Change the configuration to match the
linux configuration
Signed-off-by: Arnaud Patard
Index: u-boot/arch/arm/include/asm/arch-rockchip/edp_rk3288.h
The current code is using an hard coded enum and the of node reg value of
endpoint to find out if the endpoint is mipi/hdmi/lvds/edp/dp. The order
is different between rk3288, rk3399 vop little, rk3399 vop big.
A possible solution would be to make sure that the rk3288.dtsi and
rk3399.dtsi files
Kever Yang writes:
> Hi Arnaud,
>
> Thanks for your patch.
>
> Please use module name as subject prefix instead of a file name,
> eg. "rockchip: video: vop".
>
ok. will fix.
> On 2020/10/27 下午9:21, Arnaud Patard (Rtp) wrote:
>> The
According to linux commit "drm/rockchip: analogix_dp: add rk3399 eDP
support" (82872e42bb1501dd9e60ca430f4bae45a469aa64), rk3288 and rk3399
eDP IPs are nearly the same, the difference is in the grf register
(SOC_CON6 versus SOC_CON20). So, change the code to use the right
register on each IP.
The
In the code, the default polarity is set to positive/positive,
which is neither normal polarity or inverted polarity. It's
only the hardware default. This leads to booting linux with
wrong polarity setting.
Update the code to use PWM_DUTY_POSTIVE | PWM_INACTIVE_NEGATIVE
by default instead.
- uboot rockchip edp code is looking for a rockchip,panel property
for the edp dts node, so add it.
Signed-off-by: Arnaud Patard
Index: u-boot/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
===
---
The debug string printing the device name, framebuffer address and of node
is using %lu as format for the framebuffer address, which is not so nice.
Change it to %lx.
Signed-off-by: Arnaud Patard
Index: u-boot/drivers/video/rockchip/rk_vop.c
In order to ensure that the VOP registers are in correct state,
add missing support for the VOP reset lines found in the device-tree
Signed-off-by: Arnaud Patard
Index: u-boot/drivers/video/rockchip/rk_vop.c
===
---
This patchset add support for the rk3399 eDP. It has been tested on the pinebook
pro and Google Kevin chromeos devices.
The changes have been written by studying the linux code, since I didn't find
any
manual for theses part of the RK3399 SoC.
For Kevin devices, this patchset is needed:
The default configuration will use SYS_USB_EVENT_POLL for handling the
usb keyboard and it makes the system really slow (eg slow keypress,
loading kernel/initrd from grub-efi is taking ages).
Using CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE seems to be improving
things a lot, so use it.
Tested-by:
In order to ensure that the eDP registers are in correct state,
add missing support for the eDP reset lines found in the device-tree.
Signed-off-by: Arnaud Patard
Index: u-boot/drivers/video/rockchip/rk_edp.c
===
---
When booting with EFI and graphics, the memory used for framebuffer
has to be reserved, otherwise it may leads to kernel memory
overwrite.
Signed-off-by: Arnaud Patard
Index: u-boot/drivers/video/rockchip/rk_vop.c
===
---
The current code is using an hard coded enum and the of node reg value of
endpoint to find out if the endpoint is mipi/hdmi/lvds/edp/dp. The order
is different between rk3288, rk3399 vop little, rk3399 vop big.
A possible solution would be to make sure that the rk3288.dtsi and
rk3399.dtsi files
The linux code is setting polarity configuration to 3 but
uboot code is setting it to 1. Change the configuration to match the
linux configuration
Signed-off-by: Arnaud Patard
Index: u-boot/arch/arm/include/asm/arch-rockchip/edp_rk3288.h
Alper Nebi Yasak writes:
> On 25/09/2020 21:36, Arnaud Patard (Rtp) wrote:
>> The current code is setting the clock rate to 19200, but
>> due to the current device-tree configuration and linux code,
>> it should rather be 1.
>>
>
> This looks like i
Alper Nebi Yasak writes:
> On 25/09/2020 21:36, Arnaud Patard (Rtp) wrote:
>> The linux code is setting polarity configuration to 3 but
>> uboot code is setting it to 1. Change the configuration to match the
>> linux configuration
> FYI, coreboot does the same as existing
Alper Nebi Yasak writes:
Hi,
> On 25/09/2020 21:36, Arnaud Patard (Rtp) wrote:
>> According to linux commit "drm/rockchip: analogix_dp: add rk3399 eDP
>> support" (82872e42bb1501dd9e60ca430f4bae45a469aa64), rk3288 and rk3399
>> eDP IPs are nearly the same, the di
Alper Nebi Yasak writes:
> On 14/10/2020 22:31, Tom Rini wrote:
>> On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote:
>>> On 14/10/2020 18:24, Tom Rini wrote:
Ugh. In so far as anything can be re-licensed, who did it all
originally? I suspect coreboot isn't interested
Simon South writes:
> Simon South writes:
>> Has anyone managed to get the built-in keyboard of the Pinebook Pro
>> working with U-Boot?
>>
>> Even using the latest code, having USB started makes the U-boot
>> console feel sluggish while pressing keys on the keyboard produces no
>> result.
>
>
Alper Nebi Yasak writes:
Hi,
> On 25/09/2020 21:36, Arnaud Patard (Rtp) wrote:
>> This patchset add support for the rk3399 edp. It has been tested on the
>> pinebook
>> pro devices. The only missing part is a hack used to get stable edp output
>> after
>>
of use
> here as well:
>
> https://lists.denx.de/pipermail/u-boot/2020-September/427790.html
>
If this platform has a screen on rk3399 edp, I'll be happy to get tests /
comments / ... of my patches on it. I've only a pinebook pro, so it's
hard to know if something is platform specifi
The linux code is setting polarity configuration to 3 but
uboot code is setting it to 1. Change the configuration to match the
linux configuration
Signed-off-by: Arnaud Patard
Index: u-boot/drivers/video/rockchip/rk_edp.c
===
---
The default configuration will use SYS_USB_EVENT_POLL for handling the
usb keyboard and it makes the system really slow (eg slow keypress,
loading kernel/initrd from grub-efi is taking ages).
Using CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE seems to be improving
things a lot, so use it.
Tested-by:
When booting with EFI and graphics, the memory used for framebuffer
has to be reserved, otherwise it may leads to kernel memory
overwrite.
Signed-off-by: Arnaud Patard
Index: u-boot/drivers/video/rockchip/rk_vop.c
===
---
According to linux commit "drm/rockchip: analogix_dp: add rk3399 eDP
support" (82872e42bb1501dd9e60ca430f4bae45a469aa64), rk3288 and rk3399
eDP IPs are nearly the same, the difference is in the grf register
(SOC_CON6 versus SOC_CON20). So, change the code to use the right
register on each IP.
The
In the code, the default polarity is set to positive/positive,
which is neither normal polarity or inverted polarity. It's
only the hardware default. This leads to booting linux with
wrong polarity setting.
Update the code to use PWM_DUTY_POSTIVE | PWM_INACTIVE_NEGATIVE
by default instead.
The current code is using an hard coded enum and the of node reg value of
endpoint to find out if the endpoint is mipi/hdmi/lvds/edp/dp. The order
is different between rk3288, rk3399 vop little, rk3399 vop big.
A possible solution would be to make sure that the rk3288.dtsi and
rk3399.dtsi files
The current code is setting the clock rate to 19200, but
due to the current device-tree configuration and linux code,
it should rather be 1.
Signed-off-by: Arnaud Patard
Index: u-boot/drivers/video/rockchip/rk_edp.c
===
This patchset add support for the rk3399 edp. It has been tested on the pinebook
pro devices. The only missing part is a hack used to get stable edp output after
a warn reset, which is possibly specific to this device. I'm not sure if it's
suitable
for merge.
The changes have been written by
- uboot rockchip edp code is looking for a rockchip,panel property
for the edp dts node, so add it.
Signed-off-by: Arnaud Patard
Index: u-boot/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
===
---
Simon South writes:
> Arnaud Patard (Rtp) writes:
>> Did you check if everything needed is enabled in your configuration and
>> if the keyboard is detected after a usb start / usb tree ?
>
> It is detected, yes.
ok.
>
> I believe the configuration is fine; I see th
Simon South writes:
> Peter Robinson writes:
>> It should be fixed in the main devel repo, commit 3a5771249
>
> That commit enables the OHCI driver but doesn't lead to a working
> keyboard, at least for me.
>
> Have you actually tested this successfully on a PBP? (Has anyone else?)
> I wonder
Patrick Wildt writes:
> On Mon, Jun 08, 2020 at 10:18:19AM +0200, Arnaud Patard wrote:
>> Patrick Wildt writes:
>>
>> Hi,
>>
>> > The EDP_LCDC_SEL bit has to be set correctly to select vop0 or
>> > vop1, but so far we have set it in both conditions, which is not
>> > correct.
>> >
>> > Can
Patrick Wildt writes:
Hi,
> The EDP_LCDC_SEL bit has to be set correctly to select vop0 or
> vop1, but so far we have set it in both conditions, which is not
> correct.
>
> Can someone verify this is the correct way round? vop1 -> set,
> vop0 -> clear?
>
> Signed-off-by: Patrick Wildt
>
>
Hi,
> diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> new file mode 100644
> index 00..1a2e24d3ef
> --- /dev/null
> +++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> @@ -0,0 +1,43 @@
> +// SPDX-License-Identifier: GPL-2.0+
>
Fwiw, it looks like that this file is already in uboot:
https://gitlab.denx.de/u-boot/u-boot/-/blob/master/include/dt-bindings/leds/common.h
commit 423aabc43613b58d7b91a28a94791ab937afcd90
Author: Jerome Brunet
Date: Thu Mar 5 12:12:35 2020 +0100
dt-bindings: leds: import common led
eDP of my PBP and managed to get it. You
need more patches in order to get it. The vopl mipi and eDP endpoints
are inverted in the rk3399.dtsi file and the rk_edp.c file needs
patching. I've put my current patches and uboot configuration at
http://people.hupstream.com/~rtp/pbp/ in case you want to t
58 matches
Mail list logo
