Re: [EXTERNAL] Re: [PATCH] common: Kconfig: Fix CMD_BMP/BMP dependency

2023-07-14 Thread Samuel Dionne-Riel
Please do! On 7/14/23, Nikhil M Jain wrote: > > > On 10/07/23 20:36, Tom Rini wrote: >> On Sun, Jul 09, 2023 at 07:18:10PM -0400, Samuel Dionne-Riel wrote: >> >>> Using `default y` will not select BMP when CMD_BMP has been enabled, if >>> it was already co

[PATCH] common: Kconfig: Fix CMD_BMP/BMP dependency

2023-07-09 Thread Samuel Dionne-Riel
Using `default y` will not select BMP when CMD_BMP has been enabled, if it was already configured. By using `select`, if `CMD_BMP` is turned on, it will force the presence of `BMP`. Fixes: 072b0e16c482114d242580dd7a3197db5966705f Signed-off-by: Samuel Dionne-Riel --- cmd/Kconfig| 1

[PATCH v4] cmd: Add pause command

2022-08-18 Thread Samuel Dionne-Riel
sted using: make && ./u-boot -v -T -c 'ut lib lib_test_hush_pause' Signed-off-by: Samuel Dionne-Riel Cc: Simon Glass --- Hi! I believe everything is addressed. I took the comment about the sort order being wonky as needing no changes. Changes for v4 - No functional ch

[PATCH v3] cmd: Add pause command

2022-08-17 Thread Samuel Dionne-Riel
sted using: make && ./u-boot -v -T -c 'ut lib lib_test_hush_pause' Signed-off-by: Samuel Dionne-Riel --- Hi, I hit a snag when sending v2, and lines ended-up wrapped. In addition I also forgot to include the changelog. It seems the patch on patchwork was also broken in a wa

[PATCH v2] cmd: Add pause command

2022-08-17 Thread Samuel Dionne-Riel
ested with sandbox using: make && ./u-boot -v -T -c 'ut lib lib_test_hush_pause' Signed-off-by: Samuel Dionne-Riel --- cmd/Kconfig | 7 + cmd/Makefile| 1 + cmd/pause.c | 35 + configs/sandbox

[PATCH 3/4] cmd: Add vibrator command

2021-12-22 Thread Samuel Dionne-Riel
Signed-off-by: Samuel Dionne-Riel --- cmd/Kconfig| 10 cmd/Makefile | 1 + cmd/vibrator.c | 148 + 3 files changed, 159 insertions(+) create mode 100644 cmd/vibrator.c diff --git a/cmd/Kconfig b/cmd/Kconfig index e538e69a11

[PATCH 4/4] pinephone_defconfig: Add gpio vibrator support

2021-12-22 Thread Samuel Dionne-Riel
Signed-off-by: Samuel Dionne-Riel Cc: Samuel Holland --- configs/pinephone_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/pinephone_defconfig b/configs/pinephone_defconfig index 9d39204a43..72aaa4ea94 100644 --- a/configs/pinephone_defconfig +++ b/configs

[PATCH 1/4] drivers: Introduce vibrator uclass

2021-12-22 Thread Samuel Dionne-Riel
Signed-off-by: Samuel Dionne-Riel --- arch/sandbox/dts/test.dts | 10 +++ configs/sandbox_defconfig | 2 + drivers/Kconfig| 2 + drivers/Makefile | 1 + drivers/vibrator/Kconfig | 21 +++ drivers/vibrator/Makefile

[PATCH 2/4] vibrator: Add vibrator_gpio driver

2021-12-22 Thread Samuel Dionne-Riel
Signed-off-by: Samuel Dionne-Riel --- drivers/vibrator/Kconfig | 16 drivers/vibrator/Makefile| 1 + drivers/vibrator/vibrator_gpio.c | 122 +++ 3 files changed, 139 insertions(+) create mode 100644 drivers/vibrator/vibrator_gpio.c diff --git

[PATCH 0/4] Add vibration motor support to U-Boot

2021-12-22 Thread Samuel Dionne-Riel
few short vibrations. Samuel Dionne-Riel (4): drivers: Introduce vibrator uclass vibrator: Add vibrator_gpio driver cmd: Add vibrator command pinephone_defconfig: Add gpio vibrator support arch/sandbox/dts/test.dts | 10 ++ cmd/Kconfig| 10 ++ cmd

[PATCH] cmd: Add pause command

2021-12-20 Thread Samuel Dionne-Riel
ned-off-by: Samuel Dionne-Riel --- cmd/Kconfig | 7 +++ cmd/Makefile | 1 + cmd/pause.c | 35 +++ 3 files changed, 43 insertions(+) create mode 100644 cmd/pause.c diff --git a/cmd/Kconfig b/cmd/Kconfig index 5b30b13e43..26d5707f75 100644 --- a/cmd/Kconfig

[PATCH] cmd: env: Add `indirect` to indirectly set values

2021-12-20 Thread Samuel Dionne-Riel
can be optionally provided. Note: this acts on environment variables, not hush variables. Signed-off-by: Samuel Dionne-Riel Cc: Simon Glass Cc: "Marek BehĂșn" --- cmd/Kconfig | 4 cmd/nvedit.c | 45 + 2 files changed, 49 insertion

[PATCH] cmd: adc: Report return value on error

2021-12-20 Thread Samuel Dionne-Riel
Reporting the return value should always be done on error conditions, this way the developer can start debugging issues with more knowledge in-hand. Signed-off-by: Samuel Dionne-Riel --- cmd/adc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/adc.c b/cmd/adc.c

[PATCH] lib: export vsscanf

2021-12-20 Thread Samuel Dionne-Riel
The function was missing from exports, even though it loooks like the intent of the implementation in sscanf.c was to have it exported. Signed-off-by: Samuel Dionne-Riel Cc: Simon Glass --- This is needed for porting an external library to U-Boot, in WIP changes. It builds with a warning, and

[PATCH] tools: fdtgrep: Use unsigned chars for arrays

2021-02-10 Thread Samuel Dionne-Riel
Otherwise, values over 127 end up prefixed with ff. Signed-off-by: Samuel Dionne-Riel Cc: Simon Glass --- Minimal reproduction: ``` // repro.dts /dts-v1/; / { ra = [ 7f ]; rb = [ 80 ]; }; ``` Steps used to compile: $ dtc repro.dts > repro.dtb Without the fix: $ fdtg

[U-Boot] [PATCH v2] usb: Make USB_MUSB_PIO_ONLY selected by USB_MUSB_SUNXI

2019-11-28 Thread Samuel Dionne-Riel
This ensures the USB_MUSB_PIO_ONLY config is set to an apppropriate value from the changes enabling USB_MUSB_GADGET does. Namely, USB_MUSB_PIO_ONLY default to =y on USB_MUSB_SUNXI being y. Signed-off-by: Samuel Dionne-Riel --- Changes in v2: - Use select as a reverse-dependency As

[U-Boot] [PATCH] usb: Make USB_MUSB_PIO_ONLY conditional on USB_MUSB_{HOST, GADGET}

2019-11-22 Thread Samuel Dionne-Riel
..._defconfig, thus the default of USB_MUSB_PIO_ONLY is kept "# ... is not set". This, _is_ counter-intuitively a set value, meaning that the default will not be applied once USB_MUSB_SUNXI is set to y by toggling USB_MUSB_GADGET via menuconfig. Signed-off-by: Samuel Dionne-Riel --- Some