Re: [PATCH 1/4] rockchip: rk3588: Fix boot from SPI flash

RK3588-specific in a comment for > both conflicts (the ones that apply to everything except RK3588 to say to > use only for !RK3588, and the ones that apply to RK3588 only)? Can you say why it is so important to know that given enum is specific to given CPU here in the header file? I think that the enums in the bootrom.h should be as generic as possible. By using the possible enums in a static array, "solves" the problem of assigning the boot source to specific CPU. There is not need to make such grouping in the bootrom.h. -- Slawomir Stepien

Re: [PATCH 1/4] rockchip: rk3588: Fix boot from SPI flash

CE_FSPI_M0 = 3 > - BROM_BOOTSOURCE_FSPI_M1 = 4 > - BROM_BOOTSOURCE_FSPI_M2 = 6 Tested-by: Slawomir Stepien > Fixes: fd6e425be243 ("rockchip: rk3588-rock-5b: Enable boot from SPI NOR > flash") > Signed-off-by: Jonas Karlman > --- > arch/arm/include/asm/arch-ro

Re: [PATCH 1/2] rockchip: rk3588: Add SPINAND as boot device

On lis 03, 2023 11:03, Jonas Karlman wrote: > On 2023-11-03 10:34, Slawomir Stepien wrote: > > Hi Jonas and Kever > > > > Thanks for clarifying the situation Kever! Please see below my proposition. > > What do you think? > > Yes, this matches my proposition a

Re: [PATCH 1/2] rockchip: rk3588: Add SPINAND as boot device

Hi Jonas and Kever Thanks for clarifying the situation Kever! Please see below my proposition. What do you think? On lis 02, 2023 15:27, Kever Yang wrote: > Hi Jonas, > > On 2023/11/1 00:45, Jonas Karlman wrote: > > On 2023-10-31 17:13, Slawomir Stepien wrote: > >

Re: [PATCH 2/2] configs: orangepi-5-plus-rk3588: Build SPI image by default

On paź 31, 2023 17:49, Jonas Karlman wrote: > On 2023-10-31 17:13, Slawomir Stepien wrote: > > Flashing this image to the on-board flash is useful when you want to > > start Linux from a medium (e.g. nvme) without flashing u-boot elements > > to it. > > > >

[PATCH 2/2] configs: orangepi-5-plus-rk3588: Build SPI image by default

Flashing this image to the on-board flash is useful when you want to start Linux from a medium (e.g. nvme) without flashing u-boot elements to it. Signed-off-by: Slawomir Stepien --- configs/orangepi-5-plus-rk3588_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/orangepi-5

[PATCH 1/2] rockchip: rk3588: Add SPINAND as boot device

Mark the flash@0 as BROM_BOOTSOURCE_SPINAND. Fixes use of same-as-spl in u-boot,spl-boot-order prop on Orange Pi 5 Plus. Signed-off-by: Slawomir Stepien --- arch/arm/mach-rockchip/rk3588/rk3588.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-rockchip/rk3588/rk3588.c b/arch