Re: [U-Boot] [PATCH] IXP425: Fixing timer code Part 1/1

2008-12-21 Thread Stefan Althoefer
period < 64 seconds. do_sleep() now works correctly. Signed-off-by: Stefan Althoefer --- cpu/ixp/timer.c | 64 ++- 1 files changed, 49 insertions(+), 15 deletions(-) diff --git a/cpu/ixp/timer.c b/cpu/ixp/timer.c index 09d8ad5..d30adbc 100

Re: [U-Boot] [PATCH] drivers/net/e1000.c: missing terminator for supported devices

2008-12-20 Thread Stefan Althoefer
Signed-off-by: Stefan Althoefer --- Fu. copy and paste. This is the tab correct patch. drivers/net/e1000.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c index 2dcaa2c..a52749d 100644 --- a/drivers/net/e1000.c +++ b/drivers

[U-Boot] [Bug] IXP425 and e1000 network driver

2008-12-20 Thread Stefan Althoefer
Hi, I found that IXP425 (big endian ARM) did not work with e1000 network driver. The reason is broken access to controller registers. I get it working with this patch: --- a/drivers/net/e1000.c +++ b/drivers/net/e1000.c @@ -105,12 +105,15 @@ static void e1000_phy_hw_reset(struct e1000_h

[U-Boot] [PATCH] drivers/net/e1000.c: missing terminator for supported devices

2008-12-20 Thread Stefan Althoefer
Signed-off-by: Stefan Althoefer --- drivers/net/e1000.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c index 2dcaa2c..a52749d 100644 --- a/drivers/net/e1000.c +++ b/drivers/net/e1000.c @@ -82,6 +82,7 @@ static struct

Re: [U-Boot] [PATCH] IXP425: Fixing PCI access Part 1/1

2008-12-17 Thread Stefan Althoefer
Hi Wolfgang Denk, > >> @@ -304,9 +355,7 @@ void pci_ixp_init (struct pci_controller >> pci_write_config_word (0, PCI_CFG_COMMAND, INITIAL_PCI_CMD); >> REG_WRITE (PCI_CSR_BASE, PCI_ISR_OFFSET, PCI_ISR_PSE >> | PCI_ISR_PFE | PCI_ISR_PPE | PCI_ISR_AHBE); >> -#ifdef CONFIG_P

Re: [U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1

2008-12-17 Thread Stefan Althoefer
Jean-Christophe PLAGNIOL-VILLARD schrieb: > On 14:10 Wed 17 Dec , michael wrote: >> michael wrote: >>> Stefan Althoefer wrote: >>> >>>> Jean-Christophe PLAGNIOL-VILLARD schrieb: >>>> >>>> >>>> >>>

Re: [U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1

2008-12-16 Thread Stefan Althoefer
Jean-Christophe PLAGNIOL-VILLARD schrieb: >> >> diff -uprN u-boot-orig//lib_arm/board.c u-boot/lib_arm/board.c >> --- u-boot-orig//lib_arm/board.c 2008-12-02 17:25:32.0 +0100 >> +++ u-boot/lib_arm/board.c 2008-12-02 23:29:36.0 +0100 >> @@ -441,6 +441,11 @@ extern void davinci

Re: [U-Boot] [PATCH] IXP425: make cmd_go handle caches correctly Part 1/1

2008-12-16 Thread Stefan Althoefer
jump into stale code if you download a program several times. Signed-off-by: Stefan Althoefer --- > > Coding style: please use TABs for indentation. > Sorry for the spaces. BTW: In function calls: Is the space between function name are opening bracket desired or not? Seems this is han

Re: [U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

2008-12-16 Thread Stefan Althoefer
Jean-Christophe PLAGNIOL-VILLARD schrieb: >> +cfg_clk = *IXP425_EXP_CFG0 >> 21; > please use readx/writex The pointer dereference style is used throughout the other files in the IXP port as well. Shouldn't this be handled the same way in all files? >> >> +/* FIXME: is there any need fo

Re: [U-Boot] [PATCH] IXP425: Fixing timer code Part 1/1

2008-12-16 Thread Stefan Althoefer
Wolfgang Denk schrieb: > Dear Stefan Althoefer, > > In message <49384728.lmggwd1otzmugoap%stefan.althoe...@web.de> you wrote: >> With this patch, this is nonsense. Instead you should use: >> >> #ifdef CONFIG_USE_IRQ >> /* Interrupt driven timer wants syste

Re: [U-Boot] [PATCH] common: nvedit to protect additional ethernet addresses Part 1/1

2008-12-16 Thread Stefan Althoefer
Dear Wolfgang Denx, >> But your suggested optimizations will only be effective if someone tries to >> write to "serial#". This is not normally done (attempt can be considered >> an error). > > Can it? What make you think so? > > There are lots of boards that come fresh out of production with

Re: [U-Boot] [PATCH] IDE: Improving speed on reading data Part 1/1

2008-12-16 Thread Stefan Althoefer
my testplatform (Janz emPC-A400 with CompactFLASH card) this nearly doubled speed. Also, error handling has been improved, so that ide_read does not attempt to read beyond the last sector of the device. Signed-off-by: Stefan Althoefer --- > Can you please use git-format-patch to format the pa

Re: [U-Boot] [PATCH] common: nvedit to protect additional ethernet addresses Part 1/1

2008-12-16 Thread Stefan Althoefer
Dear Wolfgang Denk > Dear =?iso-8859-15?Q?Stefan_Alth=F6fer?=, > > In message <531234...@web.de> you wrote: >> Then maybe we should have >> >> #define CONFIG_ENV_PROTECTED_ITEM "ethaddr1,ethaddr2," >> >> in board configuration to have the greatest flexibility? > > Jerry Van Baren already sho

[U-Boot] [Bug] ARM: early environment broken

2008-12-08 Thread Stefan Althoefer
Hi, ---+ Problem in git u-boot(-arm) early access to environment (e.g. during serial_init) is broken (for CONFIG_ENV_IS_IN_EEPROM). ---+ Reason start_armboot() __asm__ __volatile__("": : :"memory"); memset ((void*)gd, 0, sizeof (gd_t)); gd->bd = (bd_t*)((char*)

[U-Boot] [PATCH V2 Inc1] IXP425: Fixing PCI access

2008-12-08 Thread Stefan Althoefer
This fixes conflict existing with IXP425_PCI_SIMPLE_MAPPING. BAR0 and BAR4 were both defined 0, which prevented external bus masters from accessing first 16MByte of main memory. This is an incrmental patch to patch posted 20081206. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> --- c

Re: [U-Boot] [Bug Report] USB: descriptor handling

2008-12-08 Thread Stefan Althoefer
Hi > > > With this change memory stick is identied correctly. I can do "fatls", > but I cannot read data correctly from the disk. But might be something > completely different issue The reason for this was corrupted PCI setup, which prevented the USB controller to bus-master to some memory

Re: [U-Boot] [PATCH] common: nvedit to protect additional ethernet addresses Part 1/1

2008-12-07 Thread Stefan Althoefer
Hi Wolfgang Denk > Dear Stefan Althoefer, > > In message <[EMAIL PROTECTED]> you wrote: >> You argue that the code should have a couple of hard to read else cases? > > That would be one way to avoid unnecessary tests. > > Probably not the most elegant appro

Re: [U-Boot] [PATCH] common: nvedit to protect additional ethernet addresses Part 1/1

2008-12-07 Thread Stefan Althoefer
Wolfgang Denk schrieb: > Dear Stefan Althoefer, > > In message <[EMAIL PROTECTED]> you wrote: >> From fdeee62f0902b25be1a2a6bf52fb714b0f4f9e59 Mon Sep 17 00:00:00 2001 >> From: Stefan Althoefer <[EMAIL PROTECTED]> >> Date: Sun, 7 Dec 2008 14:17:08 +010

[U-Boot] [Bug Report] USB: descriptor handling

2008-12-07 Thread Stefan Althoefer
Hi, I found a bug when working with the u-boot USB subsystem on IXP425 processor (big endian Xscale aka ARMv5). I recognized that the second usb_endpoint_descriptor of the attached memory stick was corrupted. The reason for this are the packed structures below (either u-boot and u-boot-usb): ---

Re: [U-Boot] [PATCH] common: nvedit to protect additional ethernet addresses Part 1/1

2008-12-07 Thread Stefan Althoefer
>From fdeee62f0902b25be1a2a6bf52fb714b0f4f9e59 Mon Sep 17 00:00:00 2001 From: Stefan Althoefer <[EMAIL PROTECTED]> Date: Sun, 7 Dec 2008 14:17:08 +0100 Subject: [PATCH] common: nvedit to protect additional ethernet addresses This adds "eth[0-9]+addr" to the protected environ

Re: [U-Boot] [PATCH] video: Add new driver for Silicon Motion SM501/SM502 Part 1/2

2008-12-07 Thread Stefan Althoefer
Dear All, > Dear Anatolij & Stefan, > > In message <[EMAIL PROTECTED]> you wrote: >>> Use CONFIG_VIDEO_SM501NEW to enable the driver. >> not sure if CONFIG_VIDEO_SM501NEW is a good chose here. Maybe >> we should use s.th. like CONFIG_VIDEO_SM50x. This applies to >> the file names too: sm50x.h, sm

Re: [U-Boot] [PATCH] IXP425: Fixing PCI access Part 1/1

2008-12-06 Thread Stefan Althoefer
I posted new version of patch to fix some more errors and style, so this is obsolete. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] video: Add new driver for Silicon Motion SM501/SM502 Part 1/2

2008-12-06 Thread Stefan Althoefer
Hi Anatolij, >> Use CONFIG_VIDEO_SM501NEW to enable the driver. > > not sure if CONFIG_VIDEO_SM501NEW is a good chose here. Maybe > we should use s.th. like CONFIG_VIDEO_SM50x. This applies to > the file names too: sm50x.h, sm50x.c, etc. Even better would > be a merge with the existing driver.

[U-Boot] [PATCH V2 1/1] IXP425: Fixing PCI access

2008-12-06 Thread Stefan Althoefer
e IXP initialization of memory spaces - fixed address and irq assignment to PCI devices - fixed pci_find_device - some reformatting Note: I think boards should always define IXP425_PCI_SIMPLE_MAPPING Patch was tested with Janz emPC-A400. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> --

Re: [U-Boot] [PATCH] common: nvedit to protect additional ethernet addresses Part 1/1

2008-12-05 Thread Stefan Althoefer
This patches cmd_nvedit to reject changes for "ethaddr." in addition to "ethaddr" and "serial#". This is intendend to protect changes to additional ethernet addresses (e.g. "ethernet1"). The code was rewritten to be more clear. Signed-off-by: Stefan Alth

[U-Boot] [PATCH] IXP425: Add new IXP425 board emPC-A400 Part 1/2

2008-12-04 Thread Stefan Althoefer
mission or patches are offending. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> diff -uprN u-boot-orig//board/empca400/cmd_npeload.c u-boot/board/empca400/cmd_npeload.c --- u-boot-orig//board/empca400/cmd_npeload.c 1970-01-01 01:00:00.0 +0100 +++ u-boot/board/empca400/cmd_n

[U-Boot] [PATCH] IXP425: Add new IXP425 board emPC-A400 Part 2/2

2008-12-04 Thread Stefan Althoefer
mission or patches are offending. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> diff -uprN u-boot-orig//board/empca400/cmd_bootce.c u-boot/board/empca400/cmd_bootce.c --- u-boot-orig//board/empca400/cmd_bootce.c1970-01-01 01:00:00.0 +0100 +++ u-boot/board/empca400/cmd_boot

[U-Boot] [PATCH] video: Add new driver for Silicon Motion SM501/SM502 Part 2/2

2008-12-04 Thread Stefan Althoefer
Use CONFIG_VIDEO_SM501NEW to enable the driver. This has been tested on Janz emPC-A400. On this platform the SM501 is connected via PCI. The patch is against "latest" u-boot git-repository Please (still) be patient if style of submission or patches are offending. Signed-off-by: Stefan Al

[U-Boot] [PATCH] video: Add new driver for Silicon Motion SM501/SM502 Part 1/2

2008-12-04 Thread Stefan Althoefer
Use CONFIG_VIDEO_SM501NEW to enable the driver. This has been tested on Janz emPC-A400. On this platform the SM501 is connected via PCI. The patch is against "latest" u-boot git-repository Please (still) be patient if style of submission or patches are offending. Signed-off-by: Stefan Al

[U-Boot] [PATCH] IXP425: Fixing timer code Part 1/1

2008-12-04 Thread Stefan Althoefer
offending. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> diff -uprN u-boot-orig//cpu/ixp/timer.c u-boot/cpu/ixp/timer.c --- u-boot-orig//cpu/ixp/timer.c2008-12-02 17:25:31.0 +0100 +++ u-boot/cpu/ixp/timer.c 2008-12-02 22:27:22.0 +0100 @@ -46,6 +46,8 @@ vo

[U-Boot] [PATCH] IXP425: Changing serial port initialization sequence Part 1/1

2008-12-04 Thread Stefan Althoefer
is against "latest" u-boot git-repository Please (still) be patient if style of submission or patches are offending. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> diff -uprN u-boot-orig//cpu/ixp/serial.c u-boot/cpu/ixp/serial.c --- u-boot-orig//cpu/ixp/serial.c

[U-Boot] [PATCH] IXP425: Fixing PCI access Part 1/1

2008-12-04 Thread Stefan Althoefer
Janz emPC-A400. The patch is against "latest" u-boot git-repository Please (still) be patient if style of submission or patches are offending. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> diff -uprN u-boot-orig//cpu/ixp/pci.c u-boot/cpu/ixp/pci.c --- u-boot-orig//cpu/

[U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1

2008-12-04 Thread Stefan Althoefer
strapping information from register and corrects the actual clock speed. Both information are displayed. The patch is against "latest" u-boot git-repository Please (still) be patient if style of submission or patches are offending. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> --

[U-Boot] [PATCH] IXP425: make cmd_go handle caches correctly Part 1/1

2008-12-04 Thread Stefan Althoefer
will jump into stale code if you download a program several times. The patch is against "latest" u-boot git-repository Please (still) be patient if style of submission or patches are offending. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> diff -uprN u-boot-orig/

[U-Boot] [PATCH] IDE: Improving speed on reading data Part 1/1

2008-12-04 Thread Stefan Althoefer
. Also the ide_wait() code was rewritten to have lower latency by polling more frequently for status. The patch is against "latest" u-boot git-repository Please (still) be patient if style of submission or patches are offending. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> --

[U-Boot] Part 1/0

2008-12-04 Thread Stefan Althoefer
The patch is against "latest" u-boot git-repository Please (still) be patient if style of submission or patches are offending. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> ___ U-Boot mailing list U-Boot@lists.denx.de http

[U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c Part 1/1

2008-12-04 Thread Stefan Althoefer
[PATCH] ARM: add IDE init to lib_arm/board.c This patch adds ide_init() to the arm boot process. The patch is against "latest" u-boot git-repository Please (still) be patient if style of submission or patches are offending. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]>

[U-Boot] [PATCH] ARM: Allow cross endian linux boot Part 1/1

2008-12-04 Thread Stefan Althoefer
yle of submission or patches are offending. Signed-off-by: Stefan Althoefer <[EMAIL PROTECTED]> diff -uprN u-boot-orig//lib_arm/bootm.c u-boot/lib_arm/bootm.c --- u-boot-orig//lib_arm/bootm.c2008-12-02 17:25:32.0 +0100 +++ u-boot/lib_arm/bootm.c 2008-12-03 11:37:05.0

[U-Boot] [PATCH] common: nvedit to protect additional ethernet addresses Part 1/1

2008-12-04 Thread stefan . althoefer
[PATCH] common: nvedit to protect additional ethernet addresses This patch adds "ethaddr1" and "ethaddr2" to the protected environment variables that can only be written once. The patch is against "latest" u-boot git-repository Please be patient if style of submission or patches are offendi