a keyboard device is found, while the Set_Protocol request
is issued quite some time later.
Signed-off-by: Stefan Brüns
---
common/usb_kbd.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/common/usb_kbd.c b/common/usb_kbd.c
index 60c6027e04..afad260
get_maintainer.pl quotes names which it considers unsafe, i.e. anything
containing [^a-zA-Z0-9_ \-]. This confuses patman, it will duplicate
addresses which are also in Series-to/cc. Strip the quotes.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
tools/patman/get_maintai
e a consistent experience across boards, and we
> > will not have to always chase all the defconfigs to provide it.
>
> I think there's a problem on A64 -- the Pine series are all designed to be
> host-only, and it's the most popular A64 board series.
No, it just means the *initial*
so
mention support for non-standard layouts in gdisk 1.0.3.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
doc/README.gpt | 33 +
1 file changed, 29 insertions(+), 4 deletions(-)
diff --git a/doc/README.gpt b/doc/README.gpt
index d3db8bce1c..7
genext2fs creates revision level 0 filesystems, which are not readable
by u-boot due to the initialized group descriptor size field.
f798b1dda1c5de818b806189e523d1b75db7e72d
Reported-by: Kever Yang <kever.y...@rock-chips.com>
Reported-by: frostyby...@protonmail.com
Signed-off-by: Stefan
From: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Instead of shuffling bits from two adjacent 16 bit words, use one 16 bit
word with the appropriate byte offset in the buffer.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/fat/fat.c | 34 +
is fine as it checks if any buffers needs flushing.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Benoît Thébaudeau <benoit.thebaudeau@gmail.com>
---
fs/fat/fat.c | 25 ++--
fs/fat/fat_w
The FAT is read/flushed in segments of 6 (FATBUFBLOCKS) disk sectors. The
last segment may be less than 6 sectors, cap the length.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Benoît Thébaudeau <benoit.thebaudeau@gmail.com>
---
fs/fat/fat.c |
Fix a possible filesystem corruption if the FS is almost full, and
remove some duplicate code.
Stefan Brüns (2):
fs/fat: Avoid corruption of sectors following the FAT
fs/fat: merge readwrite get_fatent_value() with readonly get_fatent()
fs/fat/fat.c | 26 +--
fs/fat
From: Stefan Brüns <stefan.bru...@rwth-aachen.de>
The runner actually has no console dependency, only on the log provided
by the console.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
Alternate approach to the previous patch, always pass the logfile, change
Fix a possible filesystem corruption if the FS is almost full, and
remove some duplicate code.
Stefan Brüns (1):
fs/fat: Avoid corruption of sectors following the FAT
Stefan Brüns (1):
fs/fat: merge readwrite get_fatent_value() with readonly get_fatent()
fs/fat/fat.c | 20
is fine as it checks if any buffers needs flushing.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/fat/fat.c | 19 +
fs/fat/fat_write.c | 118 +++--
2 files changed, 24 insertions(+), 113 deletions(-)
diff
From: Stefan Brüns <stefan.bru...@rwth-aachen.de>
The FAT is read/flushed in segments of 6 (FATBUFBLOCKS) disk sectors. The
last segment may be less than 6 sectors, cap the length.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/fat/fat.c | 1 +
fs/fat/fat_
From: Stefan Brüns <stefan.bru...@rwth-aachen.de>
The following checks are currently implemented:
1. listing a directory
2. verifying size of a file
3. veryfying md5sum for a file region
4. reading the beginning of a file
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
The runner actually has no console dependency, only on the log provided
by the console. Accept both u_boot_console or a multiplexed_log.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/py/u_boot_utils.py | 20 ++--
1 file changed, 14 insertions(+), 6 del
Support was already implemented, but not hooked up. This fixes several
fails in the test cases.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
v2:
- update ext4fs_read(...) calls from spl_ext.c
- move clamping to ext4fs_read_file(...), i.e. correct the check
for offse
After the latest changes, ext4 no longer has any fails.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/fs/fs-test.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh
index 6e71b61..b194864 100755
--- a/t
Support was already implemented, but not hooked up. This fixes several
fails in the test cases.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4fs.c | 15 +--
include/ext4fs.h | 2 +-
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/f
A sparse file may have regions not mapped by any extents, at the start
or at the end of the file, or anywhere between, thus not finding a
matching extent region is never an error.
Found by python filesystem tests.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
f
If a test uses a fixture which is expensive to setup, the fixture can
possibly created with session or module scope. As u_boot_console has
function scope, it can not be used in this case.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/py/conftest.p
The runner actually has no console dependency, only on the log provided
by the console. Accept both u_boot_console or a multiplexed_log.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/py/u_boot_utils.py | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
The following checks are currently implemented:
1. listing a directory
2. verifying size of a file
3. veryfying md5sum for a file region
4. reading the beginning of a file
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/py/tests/test_fs.py
regions of a file
4. Reading the head of a file
3. and 4. have some overlap, but the latter will also read sparse file regions.
As the old test, some parts need root privileges to mount the image.
Stefan Brüns (3):
test/py: expose config and log as session scoped fixture
test/py: Allow to pass
mksunxiboot is useful outside of u-boot, it is e.g. used by sunxi-tools.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
tools/Makefile | 1 +
tools/mksunxiboot.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/Makefile b/tools/Makefile
t_dfu[env__usb_dev_port0-env__dfu_config0]" ""
---
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/py/conftest.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/test/py/conftest.py b/test/py/conftest.py
index 5b3a923..ebef40d 100644
--- a/test/py/conftest.py
ter is
misleadingly indented as if it is guarded by the ‘for’
printf("\n--\n");
^~
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
cmd/tpm_test.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/cmd/tpm_test.c b/c
sanity check, so
that the check actually verifies the correct value.
So far this has not triggered any known bugs, but we're better off safe
than sorry.
If the buffer is to small, the returned memory_map_size indicates the
required size to the caller.
Signed-off-by: Stefan Brüns <stefan.
pool allocations and the corresponding
page allocation, we create an auxiliary struct efi_pool_allocation.
Given the allocation size free_pool size can handoff freeing the page
range, which was indirectly allocated by a call to allocate_pool,
to free_pages.
Signed-off-by: Stefan Brüns <stefan.
efi_allocate_pool_ext() for use by payloads and an internal helper
efi_allocate_pool() in efi_memory.c that handles the actual allocation.
While at it, change the magic 0xfff / 12 constants to the more obvious
EFI_PAGE_MASK/SHIFT defines.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
i
Use the same variable names as in search_dir, to make purpose of variables
more obvious.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4_common.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/fs/ext4/ext4_co
search_dir for directory traversal. This code
has the correct checks for direntlen >= sizeof(struct dirent), and
offset < blocksize.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4_common.c | 45 +
1 file changed
This patch series addresses Coverity defects CID 153383/153384.
The first patch is a preparation patch, the second addresses the
actual issue.
The last patch corrects the journal handling in the same function.
Stefan Brüns (3):
ext4: cleanup unlink_filename function
ext4: Fix handling
Instead of creating a journal entry for each directory block, even
if the block is unmodified, only log the modified block.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4_common.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
and e.g. socket files show up as regular files.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Acked-by: Simon Glass <s...@chromium.org>
---
arch/sandbox/cpu/os.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c
index 16af3f5..
.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Alexander Graf <ag...@suse.de>
---
include/efi_loader.h| 2 +-
lib/efi_loader/efi_memory.c | 11 +--
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/include/efi_loader.h b/include/
As soon as a mapping is unlinked from the list, there are no further
references to it, so it should be freed. If it not unlinked,
update the start address and length.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Alexander Graf <ag...@suse.de>
---
li
arithmetic, add some comments
Stefan Brüns (7):
efi_loader: Update description of internal efi_mem_carve_out
efi_loader: Fix memory map size check to avoid out-of-bounds access
efi_loader: Move efi_allocate_pool implementation to efi_memory.c
efi_loader: Track size of pool allocations to allow
Implementation essentially unchanged, but use EFI_PAGE_MASK/SHIFT
instead of numeric constants.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
include/efi_loader.h | 3 +++
lib/efi_loader/efi_boottime.c | 11 +--
lib/efi_loader/efi_memory.c | 11
allocate_pool has to return a buffer which is 8-byte aligned. Shift the
region returned by allocate_pages by 8 byte and store the size in the
headroom. The 8 byte overhead is neglegible, but provides the required
size when freeing the allocation later.
Signed-off-by: Stefan Brüns <stefan.
In 74c16acce30bb882ad5951829d8dafef8eea564c the return values where
changed, but the description was kept.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
lib/efi_loader/efi_memory.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/lib/efi_
The code assumes sorted mappings in descending address order. When
splitting a mapping, insert the new part next to the current mapping.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Alexander Graf <ag...@suse.de>
---
lib/efi_loader/efi_memory.c | 3 ++-
1
Do not overwrite the specified size of the provided buffer without
having checked it is sufficient.
If the buffer is to small, memory_map_size is updated to indicate the
required size, and an error code is returned.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
lib/efi_
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
arch/sandbox/cpu/os.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c
index 16af3f5..df2bd4c 100644
--- a/arch/sandbox/cpu/os.c
+++ b/arch/sandbox/cpu/os.c
@@ -363,6 +363,8
Using readdir_r limits the maximum file name length and may even be
unsafe, and is thus deprecated in since glibc 2.24.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
arch/sandbox/cpu/os.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff
Stefan Brüns (5):
sandbox/fs: Free memory allocated by os_dirent_ls
sandbox/fs: Make linking of nodes in os_dirent_ls more obvious
sandbox/fs: Use correct size path name buffer
sandbox/fs: Set correct filetype for unknown filetype
sandbox/fs: Use readdir instead of deprecated readdir_r
The readdir linux manpage explicitly states (quoting POSIX.1) that
sizeof(d_name) is not correct for determining the required size, but to
always use strlen. Grow the buffer if needed.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
arch/sandbox/cpu/os.c | 13 ++---
Previously, after reading/creating the second dirent, the second entry
would be chained to the first entry and the first entry would be linked
to head. Instead, immediately link the first entry to head.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
arch/sandbox/cpu/os
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/sandbox/sandboxfs.c | 1 +
include/os.h | 11 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/fs/sandbox/sandboxfs.c b/fs/sandbox/sandboxfs.c
index 2703eed..cd10fd6 100644
--- a/fs/s
The code assumes sorted mappings in descending address order. When
splitting a mapping, insert the new part next to the current mapping.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Alexander Graf <ag...@suse.de>
---
lib/efi_loader/efi_memory.c | 3 ++-
1
allocate_pool has to return a buffer which is 8-byte aligned. Shift the
region returned by allocate_pages by 8 byte and store the size in the
headroom. The 8 byte overhead is neglegible, but provides the required
size when freeing the allocation later.
Signed-off-by: Stefan Brüns <stefan.
In 74c16acce30bb882ad5951829d8dafef8eea564c the return values where
changed, but the description was kept.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
lib/efi_loader/efi_memory.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/lib/efi_
Do not overwrite the specified size of the provided buffer without
having checked it is sufficient.
If the buffer is to small, memory_map_size is updated to indicate the
required size, and an error code is returned.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
lib/efi_
.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Alexander Graf <ag...@suse.de>
---
lib/efi_loader/efi_memory.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c
index 72a5
As soon as a mapping is unlinked from the list, there are no further
references to it, so it should be freed. If it not unlinked,
update the start address and length.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Alexander Graf <ag...@suse.de>
---
li
- (Hopefully) clarified commit message
efi_loader: Track size of pool allocations to allow freeing
- rebased on top of 'efi_loader: Fix crash on 32-bit systems'
- assert correct address in efi_free_pool
- use EFI_PAGE_MASK instead of 0xfff, EFI_PAGE_SHIFT likewise
Stefan Brüns (6
As soon as a mapping is unlinked from the list, there are no further
references to it, so it should be freed. If it not unlinked,
update the start address and length.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
lib/efi_loader/efi_memory.c | 7 +--
1 file chan
memory_map_size as IN parameter specifies the size of the provided buffer.
If the buffer is to small, memory_map_size is updated to indicate the
required size, and an error code is returned.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
lib/efi_loader/efi_memory
In 74c16acce30bb882ad5951829d8dafef8eea564c the return values where
changed, but the description was kept.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
lib/efi_loader/efi_memory.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/lib/efi_
The code assumes sorted mappings in descending address order. When
splitting a mapping, insert the new part next to the current mapping.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
lib/efi_loader/efi_memory.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
Linux 4.8 no longer boots, as it runs out of descriptor space. Readding
the mapping allows reuse, and the next AllocatePool will likely not add
a new mapping.
Also fix some small issues found while debugging.
Stefan Brüns (6):
efi_loader: Update description of internal efi_mem_carve_out
allocate_pool has to return a buffer which is 8-byte aligned. Shift the
region returned by allocate_pages by 8 byte and store the size in the
headroom. The 8 byte overhead is neglegible, but provides the required
size when freeing the allocation later.
Signed-off-by: Stefan Brüns <stefan.
.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
lib/efi_loader/efi_memory.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c
index 5d71fdf..763b79f 100644
--- a/lib/efi_loader/efi_memory.c
Also adjust high 16/32 bits when free inode/block counts are modified.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
v2: rebase on last version of ext4 endian fixes
fs/ext4/ext4_common.c | 53 +++
fs/ext4/ext4_write.c
The helper functions encapsulate access of the block group descriptors,
independent of group descriptor size. The helpers also deal with the
endianess of the fields, and with split fields like free_blocks/
free_blocks_high.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Enable mounting of ext4 fs with 64bit feature, as it is supported now.
These had been disabled in 6f94ab6656ceffb3f2a972c8de4c554502b6f2b7.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4_common.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/f
The descriptor size is variable, thus array indices are not generically
applicable. The larger group descriptors also contain e.g. high parts
of block numbers, which have to be read and written.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4_common.c
Most importantly, the superblock provides the used group descriptor size,
which is required for the EXT4_FEATURE_INCOMPAT_64BIT.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
include/ext_common.h | 50 ++
1 file chang
Also adjust high 16/32 bits when free inode/block counts are modified.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4_common.c | 53 +++
fs/ext4/ext4_write.c | 40 ++
2 files c
The helper functions encapsulate access of the block group descriptors,
independent of group descriptor size. The helpers also deal with the
endianess of the fields, and with split fields like free_blocks/
free_blocks_high.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
f
The EXT4_FEATURE_INCOMPAT_64BIT changes the on disk layout. Use the
correct structure sizes/offsets and respect split high/low free
inode/block counts.
Stefan Brüns (7):
ext4: Update ext2/3/4 superblock, group descriptor and inode
structures
ext4: determine group descriptor size for 64bit
If EXT4_FEATURE_INCOMPAT_64BIT is set, the descriptor can be read from
the superblocks, otherwise it defaults to 32.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4_common.c | 18 ++
include/ext4fs.h | 2 ++
2 files changed, 16 insertions
The correct descriptor size must be used when calculating offsets, and
also to read the correct amount of data.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4_common.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/ext4_comm
Instead of providing the full path, specify directory and filename
separately. This allows to specify intermediate directories, required
for some additional tests.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/fs/fs-test.s
ext4 and fat code emit some diagnostic messages during command execution.
These additional lines force a match window size which strictly is not
necessary.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/fs/fs-test.sh | 26 +++---
1 file chang
/ and /./ should reference the same file.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/fs/fs-test.sh | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh
index 69abdab..520344b
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/fs/fs-test.sh | 10 ++
1 file changed, 10 insertions(+)
diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh
index b9c2306..69abdab 100755
--- a/test/fs/fs-test.sh
+++ b/test/fs/fs-test.sh
@@ -293,6 +293,12 @@ ${PREFIX}l
e in cleanup
Added:
test/fs: remove use of undefined WRITE_FILE variable
test/fs: strip noise from filesystem code prior to checking results
Stefan Brüns (5):
test/fs: Restructure file path specification to allow some flexibility
test/fs: remove use of undefined WRITE_FILE variable
The write file is created from $SMALL_FILE by appending ".w" on all
other occurences in the code.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/fs/fs-test.sh | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/test/fs/fs-test
argc is checked, but is off by one. In case is not specified,
create an empty file, which is identical to the ext4write behaviour.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
cmd/fat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cmd/fat.c
Current description does not match the function behaviour.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/fat/fat_write.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c
index babe9c8..0583af3 100644
--- a/
the on-disk blocks.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/fat/fat.c | 1 +
fs/fat/fat_write.c | 31 +++
include/fat.h | 1 +
3 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/fs/fat/fat.c b/fs/fat/fat.c
index 8
fatlength is a local variable which is no more used after the assignment.
s_name is not used in the function, save the strncpy.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/fat/fat_write.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/
Start cleanup of fat filesystem.
Stefan Brüns (4):
fs/fat: Remove two statements without effect
fs/fat: Do not write unmodified fat entries to disk
fs/fat: Correct description of determine_fatent function
cmd/fat: Do not crash on write when is not specified
cmd/fat.c | 4
Test for two corner cases in ext4 directory traversal.
Stefan Brüns (3):
test/fs: Restructure file path specification to allow some flexibility
test/fs: Check ext4 behaviour if dirent is first entry in directory
block
test/fs: Check writes using "." (same dir) relative path
Instead of providing the full path, specify directory and filename
separately. This allows to specify intermediate directories, required
for some additional tests.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/fs/fs-test.s
/ and /./ should reference the same file.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/fs/fs-test.sh | 27 +++
1 file changed, 27 insertions(+)
diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh
index cb2a765..46975ec 100755
--- a/test
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
test/fs/fs-test.sh | 11 +++
1 file changed, 11 insertions(+)
diff --git a/test/fs/fs-test.sh b/test/fs/fs-test.sh
index 12450ed..cb2a765 100755
--- a/test/fs/fs-test.sh
+++ b/test/fs/fs-test.sh
@@ -291,6 +291,12 @@ ${PREFIX}l
e2fsck warns about "Group descriptor 0 marked uninitialized without
feature set."
The bg_itable_unused field is only defined if FEATURE_RO_COMPAT_GDT_CSUM
is set, and should be set (kept) zero otherwise.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by:
ion will be done.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Lukasz Majewski <l.majew...@samsung.com>
---
fs/ext4/ext4_common.c | 34 --
1 file changed, 12 insertions(+), 22 deletions(-)
diff --git a/fs/ext4/ext4_common.c b/fs/ext
img ;
ext4write host 0 0 /2.5GB.file 1 '
The 2.5GB.file from the fs test is actually a sparse file.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4_common.c | 6 +++---
fs/ext4/ext4_write.c | 11 ++-
2 files changed, 13 insertions(+), 4 deletions(-)
d
blocks.
Actually the code to release the extent tree index blocks is still missing,
but at least add a FIXME at the appropriate place.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4_write.c | 110 ---
1 file chang
before pushing garbage to the disk.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Lukasz Majewski <l.majew...@samsung.com>
---
fs/ext4/ext4_common.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/fs/ext4/ext4_common.c b/fs/ext4/ext4_co
While directories can be read using the old linear scan method, adding a
new file would require updating the index tree (alternatively, the whole
tree could be removed).
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Lukasz Majewski <l.majew...@samsung.com>
Make sure the the extra_isize field (offset 128) is initialized to 0, to
mark any extra data as invalid.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Lukasz Majewski <l.majew...@samsung.com>
---
fs/ext4/ext4_write.c | 10 --
1 file changed, 4 inse
blocks, as the old code does.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Lukasz Majewski <l.majew...@samsung.com>
---
fs/ext4/ext4_common.c | 74 +--
1 file changed, 30 insertions(+), 44 deletions(-)
dif
If the same block is updated multiple times in a row during a single
file system operation, gd_index is decremented to use the same journal
entry again. Avoid loosing the already allocated buffer.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
---
fs/ext4/ext4_journal.c | 6 +++
. Revieved-by has been added as appropriate.
Stefan Brüns (16):
ext4: fix possible crash on directory traversal, ignore deleted entries
ext4: propagate error if creation of directory entry fails
ext4: Do not crash when trying to grow a directory using extents
ext4: Scan all directory blocks
and 16296-16297 -- 8103 + 1 + 8192 = 16296. This can be shown with
debugfs, commands 'ffb' and 'stat X240'.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Lukasz Majewski <l.majew...@samsung.com>
---
fs/ext4/ext4_common.c | 8 +---
1 file changed, 5 insertions(+),
temp_ptr should always be freed, even if the function is left via
goto fail.
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Lukasz Majewski <l.majew...@samsung.com>
---
fs/ext4/ext4_write.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
zero_buffer is never written, thus clearing it is pointless.
journal_buffer is completely initialized by ext4fs_devread (or in case
of failure, not used).
Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Reviewed-by: Lukasz Majewski <l.majew...@samsung.com>
---
fs/ext4/e
1 - 100 of 177 matches
Mail list logo
