Re: [PATCH v2 0/2] a little RPi watchdog cleanup

2024-07-15 Thread Stefan Roese
On 7/15/24 15:03, Rasmus Villemoes wrote: Stefan Roese writes: @Tom, I can't find these patches (and v1) in patchworks. Do you have an idea, why this is the case? Perhaps because they (v2) have already been merged to master via a PR from Peter? commit 1ca216522d4. Ah, I was not aware

Please pull u-boot-marvell/master

2024-07-15 Thread Stefan Roese
Hi Tom, please pull this small batch of Marvell related patches: - mvebu: Migrate to upstream DT for Synology DS116 (Armada 385) board (Tony) - mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

Re: [PATCH v3] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-07-15 Thread Stefan Roese
HCD=y -CONFIG_USB_STORAGE=y diff --git a/include/configs/ds414.h b/include/configs/ds414.h index 6fbcec0898..9525657558 100644 --- a/include/configs/ds414.h +++ b/include/configs/ds414.h @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0+ */ /* + * Copyright (C) 2024 Tony Dinh * Copyrig

Re: [PATCH] arm: dts: mvebu: Migrate to upstream DT for Synology DS116 (Armada 385) board

2024-07-15 Thread Stefan Roese
xhci0_vbus_pins: xhci0_vbus_pins { - marvell,pins = "mpp58"; - marvell,function = "gpio"; - }; - xhci1_vbus_pins: xhci1_vbus_pins { - marvell,pins = "mpp59"; - marvell,function = "gpio"; - }; -}; diff --git a/configs/ds116_defconfig b/configs/ds116_defconfig index 1fc7380216..bcc5f00fe5 100644 --- a/configs/ds116_defconfig +++ b/configs/ds116_defconfig @@ -16,7 +16,7 @@ CONFIG_SF_DEFAULT_SPEED=5000 CONFIG_ENV_SIZE=0x1 CONFIG_ENV_OFFSET=0x7E CONFIG_ENV_SECT_SIZE=0x1 -CONFIG_DEFAULT_DEVICE_TREE="armada-385-synology-ds116" +CONFIG_DEFAULT_DEVICE_TREE="marvell/armada-385-synology-ds116" CONFIG_SPL_TEXT_BASE=0x4030 CONFIG_SPL_SERIAL=y CONFIG_SPL_STACK=0x4002c000 @@ -56,6 +56,7 @@ CONFIG_CMD_CACHE=y CONFIG_CMD_TIME=y CONFIG_CMD_MTDPARTS=y CONFIG_MTDPARTS_DEFAULT="mtdparts=spi0.0:1m(u-boot),7040k(kernel),64k(u-boot-env),-(data)" +CONFIG_OF_UPSTREAM=y CONFIG_ENV_OVERWRITE=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_VERSION_VARIABLE=y Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH v2 0/2] a little RPi watchdog cleanup

2024-07-15 Thread Stefan Roese
CONFIG_HW_WATCHDOG block arch/arm/mach-bcm283x/reset.c | 7 ++- board/raspberrypi/rpi/rpi.c | 4 2 files changed, 2 insertions(+), 9 deletions(-) Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D

Re: [PATCH 2/2] board: rpi: remove leftover CONFIG_HW_WATCHDOG block

2024-07-11 Thread Stefan Roese
driver and its references), but this block was left behind. Another rpi watchdog driver has since been added, but that does not select HW_WATCHDOG, so this remains dead and unused. Remove it. Signed-off-by: Rasmus Villemoes Reviewed-by: Stefan Roese Thanks, Stefan --- board/raspberrypi

Re: [PATCH 1/2] arm: bcm283x: remove pointless empty hw_watchdog_disable

2024-07-11 Thread Stefan Roese
to drop these infos, then I won't object. Reviewed-by: Stefan Roese Thanks, Stefan Signed-off-by: Rasmus Villemoes --- arch/arm/mach-bcm283x/reset.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-bcm283x/reset.c b/arch/arm/mach-bcm283x/reset

Re: [PATCH v3] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-07-10 Thread Stefan Roese
Synology DS414 and DS214+ boards - Add SYS_THUMB_BUILD to reduce binary size - Add NET_RANDOM_ETHADDR - Add CONFIG_LBA48 and CONFIG_SYS_64BIT_LBA to support >2TB HDD/SDD Signed-off-by: Tony Dinh Reviewed-by: Stefan Roese @Phil, is this ready to be merged from your point of view as well? Tha

Re: [PATCH] arm: dts: mvebu: Migrate to upstream DT for Synology DS116 (Armada 385) board

2024-07-10 Thread Stefan Roese
100644 arch/arm/dts/armada-385-synology-ds116.dts Acked-by: Sumit Garg -Sumit Is this OK to be merged to next? I think so: Reviewed-by: Stefan Roese Thanks, Stefan All the best, Tony diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index a5c82ebf7a..75f7e616b4 100644

Please pull u-boot-marvell/master

2024-07-08 Thread Stefan Roese
Hi Tom, please pull the following Marvell MVEBU related patches into master: - Add mvebu_espressobin_ultra-88f3720_defconfig (Benjamin) - Update DTS for Thecus N2350 board (Tony) - Add "old" Marvell DDR3 training for Armada 38x

Re: [PATCH] mvebu: armada-8k: respect CONFIG_DISTRO_DEFAULTS

2024-07-08 Thread Stefan Roese
) \ @@ -40,6 +40,9 @@ func(DHCP, dhcp, na) #include +#else +#define BOOTENV +#endif #define CFG_EXTRA_ENV_SETTINGS \ "scriptaddr=0x6d0\0" \ Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Muni

Re: [PATCH u-boot-marvell 00/16] Turris Omnia DDR training changes

2024-07-08 Thread Stefan Roese
/old/silicon_if.h create mode 100644 drivers/ddr/marvell/a38x/old/xor.h Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80

Re: [PATCH] arm: dts: mvebu: Update DTS for Thecus N2350 board

2024-07-08 Thread Stefan Roese
5,7 +415,7 @@ compatible = "jedec,spi-nor"; reg = <0>; - spi-max-frequency = <10800>; + spi-max-frequency = <5000>; spi-cpha; partition@0 { Viele Grüße, Stefan Roese -- DENX Soft

Re: [PATCH] arm: mvebu: env_sf_get_env_addr() missing check for CONFIG_ENV_IS_IN_SPI_FLASH

2024-07-08 Thread Stefan Roese
_IS_IN_SPI_FLASH) && CONFIG_ENV_SPI_BUS == 0 && CONFIG_ENV_SPI_CS == 0 && \ CONFIG_ENV_OFFSET + CONFIG_ENV_SIZE <= MBUS_SPI_SIZE void *env_sf_get_env_addr(void) { Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter

Re: [PATCH v3] configs: add mvebu_espressobin_ultra-88f3720_defconfig

2024-07-08 Thread Stefan Roese
NFIG_WDT=y +CONFIG_WDT_ARMADA_37XX=y +CONFIG_SHA1=y +CONFIG_DM_RTC=y +CONFIG_RTC_PCF8563=y +# CONFIG_DEBUG_UART=y +# CONFIG_DEBUG_UART_BASE=0xd0012000 +# CONFIG_DEBUG_UART_CLOCK=25804800 +# CONFIG_DEBUG_UART_SHIFT=2 +# CONFIG_DEBUG_UART_ANNOUNCE=y Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH,

Re: [PATCH] arm: davinci: remove unused defines

2024-06-19 Thread Stefan Roese
ff-by: Emil Kronborg --- arch/arm/mach-davinci/include/mach/timer_defs.h | 16 1 file changed, 16 deletions(-) Reviewed-by: Stefan Roese Thanks, Stefan diff --git a/arch/arm/mach-davinci/include/mach/timer_defs.h b/arch/arm/mach-davinci/include/mach/timer_defs.

Re: [PATCH] arm: davinci: remove unused watchdog functions

2024-06-19 Thread Stefan Roese
mer_defs.h| 4 --- arch/arm/mach-davinci/timer.c | 31 --- 2 files changed, 35 deletions(-) Nice small cleanup: Reviewed-by: Stefan Roese Thanks, Stefan diff --git a/arch/arm/mach-davinci/include/mach/timer_defs.h b/arch/arm/mach-davinci/include/mach/timer_de

Re: [PATCH 12/20] cyclic: Rise default CYCLIC_MAX_CPU_TIME_US to 5000

2024-06-18 Thread Stefan Roese
Hi Jiaxun, On 6/18/24 16:00, Jiaxun Yang wrote: 在2024年6月18日六月 上午12:29,Tom Rini写道: [...] Acked-by: Stefan Roese Can we please get either this, or https://patchwork.ozlabs.org/project/uboot/patch/20240524210817.1953298-1-rasmus.villem...@prevas.dk/ merged for master? The number of false

Please pull u-boot-watchdog/master

2024-06-18 Thread Stefan Roese
Hi Tom, please pull the following cyclic related change to fix the CI build issue here: - cyclic: Rise default CYCLIC_MAX_CPU_TIME_US to 5000 (Jiaxun) Here the

Re: [PATCH 12/20] cyclic: Rise default CYCLIC_MAX_CPU_TIME_US to 5000

2024-06-18 Thread Stefan Roese
On 6/18/24 01:29, Tom Rini wrote: On Fri, Jun 14, 2024 at 04:13:54PM +0200, Stefan Roese wrote: On 6/12/24 18:50, Tom Rini wrote: On Wed, Jun 12, 2024 at 05:13:37PM +0100, Jiaxun Yang wrote: 在2024年6月12日六月 下午5:00,Tom Rini写道: [...] configs/octeon_nic23_defconfig | 1 - 2 files changed

Please pull u-boot-watchdog/next

2024-06-16 Thread Stefan Roese
Hi Tom, please pull the following watchdog & cyclic related patches: - misc cyclic infrastructure improvements (Rasmus) - watchdog_reset cleanup (Rasmus) Here the

Re: [PATCH 0/7] watchdog_reset cleanup

2024-06-16 Thread Stefan Roese
--- drivers/serial/ns16550.c | 8 +-- drivers/watchdog/wdt-uclass.c | 19 +- include/watchdog.h | 3 - 9 files changed, 17 insertions(+), 240 deletions(-) delete mode 100644 arch/sh/cpu/sh4/watchdog.c Viele Grüße, Stefan Roese -- DENX Software

Re: [PATCH v4 0/3] cyclic/watchdog patches

2024-06-16 Thread Stefan Roese
Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH 0/7] watchdog_reset cleanup

2024-06-16 Thread Stefan Roese
. Apart from the two sh4 patches, these are independent of each other and can be applied individually. Cc: Angelo Dureghello Cc: Christophe Leroy Cc: Huan Wang Cc: Nobuhiro Iwamatsu Thanks for continuing the cleanup here: Reviewed-by: Stefan Roese Thanks, Stefan Rasmus Villemoes (7

Re: [PATCH 12/20] cyclic: Rise default CYCLIC_MAX_CPU_TIME_US to 5000

2024-06-14 Thread Stefan Roese
this in mind when implementing), so: Acked-by: Stefan Roese Thanks, Stefan

Re: [PATCH v4 0/3] cyclic/watchdog patches

2024-05-21 Thread Stefan Roese
On 5/21/24 14:45, Rasmus Villemoes wrote: On 21/05/2024 13.54, Stefan Roese wrote: On 5/21/24 11:47, Rasmus Villemoes wrote: On 21/05/2024 10.46, Rasmus Villemoes wrote: A bit of a mixed bag. I've been wanting to submit something like 3/3 for a while. So when I stumbled on Marek's patch https

Re: [PATCH v4 0/3] cyclic/watchdog patches

2024-05-21 Thread Stefan Roese
On 5/21/24 11:47, Rasmus Villemoes wrote: On 21/05/2024 10.46, Rasmus Villemoes wrote: A bit of a mixed bag. I've been wanting to submit something like 3/3 for a while. So when I stumbled on Marek's patch https://lore.kernel.org/u-boot/20240316201416.211480-1-marek.vasut+rene...@mailbox.org/ ,

Re: [PATCH v2 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-21 Thread Stefan Roese
On 5/21/24 10:38, Rasmus Villemoes wrote: On 21/05/2024 08.57, Stefan Roese wrote: On 5/19/24 21:44, Rasmus Villemoes wrote: On 18/05/2024 09.34, Stefan Roese wrote: This introduces some problems when compiling e.g. sandbox: In file included from test/common/cyclic.c:10: test/common

Re: [PATCH v2 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-21 Thread Stefan Roese
On 5/19/24 21:44, Rasmus Villemoes wrote: On 18/05/2024 09.34, Stefan Roese wrote: This introduces some problems when compiling e.g. sandbox: In file included from test/common/cyclic.c:10: test/common/cyclic.c: In function ‘dm_test_cyclic_running’: test/common/cyclic.c:25:42: warning: passing

Re: [PATCH v2 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-18 Thread Stefan Roese
not emit a warning for a maybe-unused function and (2) see that it can actually never be reached, so not emit any code for it. Reviewed-by: Stefan Roese Signed-off-by: Rasmus Villemoes --- board/Marvell/octeon_nic23/board.c | 9 +--- cmd/cyclic.c | 12

Re: [PATCH 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-16 Thread Stefan Roese
this approach. And would like to pull this in as well, perhaps before leaving on a 2 week vacation mid of next week. Unfortunately this patch 3/3 does not apply on TOT any more. Could you please rebase and re-submit? Reviewed-by: Stefan Roese Thanks, Stefan diff --git a/board/Marvell

Re: [PATCH 07/11] watchdog: Add support for ADI SC5XX-family watchdog peripheral

2024-05-15 Thread Stefan Roese
/adi_wdt.c Reviewed-by: Stefan Roese Thanks, Stefan diff --git a/MAINTAINERS b/MAINTAINERS index c1685f0352..6feb7e540b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -618,6 +618,7 @@ F: drivers/pinctrl/pinctrl-adi-adsp.c F:drivers/serial/serial_adi_uart4.c F:drivers/timer

Re: [PATCH u-boot-mvebu 10/10] arm: mvebu: turris_omnia: Support old DDR3 training, selectable via env var

2024-05-15 Thread Stefan Roese
On 5/15/24 11:24, Marek Behún wrote: On Wed, 15 May 2024 11:10:09 +0200 Stefan Roese wrote: Hi Marek, On 5/15/24 10:59, Marek Behún wrote: On Mon, 6 May 2024 12:03:55 +0200 Stefan Roese wrote: Hi Marek, On 4/15/24 18:30, Marek Behún wrote: Support old DDR3 training code on Turris

Re: [PATCH 3/3] drivers: misc: Add driver to access ZynqMP efuses

2024-05-15 Thread Stefan Roese
Hi Lukas, On 5/15/24 08:33, Lukas Funke wrote: Hi Stefan, On 15.05.2024 08:12, Stefan Roese wrote: Hi Lukas, On 5/14/24 16:04, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke Add driver to access ZynqMP efuses. This is a u-boot port of [1]. [1] https://lore.kernel.org/all

Re: [PATCH u-boot-mvebu 10/10] arm: mvebu: turris_omnia: Support old DDR3 training, selectable via env var

2024-05-15 Thread Stefan Roese
Hi Marek, On 5/15/24 10:59, Marek Behún wrote: On Mon, 6 May 2024 12:03:55 +0200 Stefan Roese wrote: Hi Marek, On 4/15/24 18:30, Marek Behún wrote: Support old DDR3 training code on Turris Omnia, selectable by U-Boot enviroment variable. Users experiencing DDR3 initialization failures

Re: [PATCH 3/3] drivers: misc: Add driver to access ZynqMP efuses

2024-05-15 Thread Stefan Roese
quot;xlnx,zynqmp-nvmem-fw", }, + { /* sentinel */ }, +}; + +static const struct misc_ops zynqmp_efuse_ops = { + .read = zynqmp_nvmem_read, + .write = zynqmp_nvmem_write, +}; + +U_BOOT_DRIVER(zynqmp_efuse) = { + .name = "zynqmp_efuse", + .id = UCLASS_MI

Re: [PATCH 1/3] firmware: zynqmp: Add support to access efuses

2024-05-15 Thread Stefan Roese
ress, u32 *value); int zynqmp_mmio_write(const u32 address, const u32 mask, const u32 value); Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax:

Re: [PATCH 2/3] wdt-uclass: prevent multiple cyclic_register calls

2024-05-13 Thread Stefan Roese
Hi Rasmus, On 5/13/24 13:09, Rasmus Villemoes wrote: On 13/05/2024 12.40, Stefan Roese wrote: On 5/9/24 02:47, Rasmus Villemoes wrote: Currently, the cyclic_register() done in wdt_start() is not undone in wdt_stop(). Moreover, calling wdt_start multiple times (which is perfectly allowed

Re: [PATCH 2/3] wdt-uclass: prevent multiple cyclic_register calls

2024-05-13 Thread Stefan Roese
amp;& priv->running) + cyclic_unregister(priv->cyclic); + priv->running = false; } Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH 1/3] cyclic: stop strdup'ing name in cyclic_register()

2024-05-13 Thread Stefan Roese
ong as the cyclic_info is registered, so just make that a requirement. Signed-off-by: Rasmus Villemoes Reviewed-by: Stefan Roese Thanks, Stefan --- common/cyclic.c | 2 +- include/cyclic.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/cyclic.c b/common/cycli

Re: [PATCH u-boot-mvebu 10/10] arm: mvebu: turris_omnia: Support old DDR3 training, selectable via env var

2024-05-06 Thread Stefan Roese
--- a/board/CZ.NIC/turris_omnia/turris_omnia.c +++ b/board/CZ.NIC/turris_omnia/turris_omnia.c @@ -465,7 +465,7 @@ static bool omnia_read_eeprom(struct omnia_eeprom *oep) return true; } -static int omnia_get_ram_size_gb(void) +int omnia_get_ram_size_gb(void) { static int ram_

Re: [PATCH 010/149] board: Marvell: Remove and add needed includes

2024-05-02 Thread Stefan Roese
On 5/1/24 04:40, Tom Rini wrote: Remove from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Stefan Roese Cc: Chris Packham Cc: Tony Dinh Cc: Jason Cooper Cc: Siddarth Gore Cc: Aaron Williams --- arch/arm/mach-kirkwood

Re: [PATCH] arm: dts: kirkwood: Remove DTS files for Kirkwood boards

2024-04-04 Thread Stefan Roese
On 3/26/24 22:12, Tony Dinh wrote: Remove DTS and DTSI files for Kirkwood boards that have upstream supports. This patch depends on "arm: dts: kirkwood: Enable upstream DT on Kirkwood boards" https://patchwork.ozlabs.org/project/uboot/patch/20240322021747.14873-1-mibo...@gmail.com/

Please pull u-boot-marvell/master

2024-04-04 Thread Stefan Roese
Hi Tom, please pull the first batch of mostly Marvell related patches: - kirkwood: Switch to using upstream dts/dtsi files (Tony) - mvebu: Turris Omnia - New board revision support (Marek)

Re: [PATCH v3] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-04-04 Thread Stefan Roese
l NSA310S has an extensive overhaul in bindings and styles in upstream DTS version. Tested-by: Michael Walle # on lschv2 Acked-by: Sumit Garg Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh Applied to u-boot-marvell/master Thanks, Stefan --- Changes in v3: - Collect Reviewed/Test

Re: [PATCH u-boot-mvebu v4 00/18] Turris Omnia - New board revision support

2024-04-04 Thread Stefan Roese
On 4/4/24 09:50, Marek Behún wrote: changes since v3: - added missing files turris_common.c and turris_common.h to patch 05/18 - added comment to patch 11/18 before while (1); as discussed in v3 v1, v2 and v3 at:

Re: [PATCH u-boot-mvebu v3 00/18] Turris Omnia - New board revision support

2024-04-04 Thread Stefan Roese
ers/misc/turris_omnia_mcu.c create mode 100644 include/turris-omnia-mcu-interface.h Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

2024-03-28 Thread Stefan Roese
On 3/28/24 12:21, Marek Behún wrote: On Thu, 28 Mar 2024 11:04:45 +0100 Stefan Roese wrote: +static int mvebu_sysreset_request(struct udevice *dev, enum sysreset_t type) +{ + struct regmap *regmap = syscon_get_regmap(dev->parent); + uint bit; + + if (type != SYSRESET_C

Re: [PATCH u-boot-mvebu v3 05/18] arm: mvebu: turris_omnia: Implement getting board information from MCU

2024-03-28 Thread Stefan Roese
On 3/28/24 12:17, Marek Behún wrote: On Thu, 28 Mar 2024 10:56:01 +0100 Stefan Roese wrote: On 3/27/24 17:23, Marek Behún wrote: Implement reading board serial number, first MAC address and board version from MCU. MCU supports board information if the FEAT_BOARD_INFO feature bit is set

Re: [PATCH u-boot-mvebu v3 18/18] arm: mvebu: turris_omnia: Enable rng command in defconfig

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Now that Turris Omnia has a rng driver provided in the MCU driver, enable the rng command in defconfig. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- configs/turris_omnia_defconfig | 1 + 1 file changed, 1 insertion

Re: [PATCH u-boot-mvebu v3 17/18] misc: turris_omnia_mcu: Add support for rng provided by MCU

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Add support for true random number generator provided by the MCU on Turris Omnia. The MCU firmware supports TRNG if the FEAT_TRNG bit is set in features. In that case we bind the rng driver. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks

Re: [PATCH u-boot-mvebu v3 16/18] cmd: rng: Print "Abort" on -EINTR

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: In the rng command, print Abort instead of Reading RNG failed if the error number is -EINTR, which can happen if the user pressed CTRL-C. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- cmd/rng.c | 7 --- 1 file

Re: [PATCH u-boot-mvebu v3 15/18] arm: mvebu: turris_omnia: Enable poweroff command via sysreset in defconfig

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Enable support for the poweroff command via sysreset for Turris Omnia. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- configs/turris_omnia_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs

Re: [PATCH u-boot-mvebu v3 14/18] gpio: turris_omnia_mcu: Add support for system power off via sysreset

2024-03-28 Thread Stefan Roese
UCLASS_MISC. The sysreset and gpio device are bound as child devices of the MCU device. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- configs/turris_omnia_defconfig| 1 + drivers/gpio/Kconfig | 7 - drivers/gpio/Makefile

Re: [PATCH u-boot-mvebu v3 13/18] gpio: turris_omnia_mcu: Update firmware features reading

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Update firmware features reading to try reading 32 bits of features and fallback to reading 16 bits. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/gpio/turris_omnia_mcu.c | 32 ++-- 1

Re: [PATCH u-boot-mvebu v3 12/18] gpio: turris_omnia_mcu: Use byteorder conversion functions

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Use byteorder conversion function instead of manually assembling data from/to MCU. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/gpio/turris_omnia_mcu.c | 80 +++-- 1 file changed, 46

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Add driver model support for sysreset via mvebu system controller. This is currently only available for U-Boot proper. Signed-off-by: Marek Behún Only a minor comment below. Other than this: Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm

Re: [PATCH u-boot-mvebu v3 10/18] arm: mvebu: system-controller: Select mvebu-reset if DM_RESET && PCI_MVEBU

2024-03-28 Thread Stefan Roese
-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig index 62a2bc5958..623432a60e 100644 --- a/arch/arm/mach-mvebu/Kconfig +++ b/arch/arm/mach-mvebu/Kconfig

Re: [PATCH u-boot-mvebu v3 09/18] arm: mvebu: system-controller: Rework to use UCLASS_SYSCON

2024-03-28 Thread Stefan Roese
-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Kconfig | 11 arch/arm/mach-mvebu/Makefile| 2 +- arch/arm/mach-mvebu/system-controller.c | 76 ++--- 3 files changed, 54 insertions(+), 35 deletions(-) diff --git a/arch/arm/mach-mvebu/Kconfig

Re: [PATCH u-boot-mvebu v3 08/18] arm: mvebu: spl: Do not build mvebu-reset in SPL

2024-03-28 Thread Stefan Roese
BU depends on DM_RESET. But the driver should not be built for SPL. Indeed the PCI_MVEBU driver is not supported in SPL now, and so the mvebu-reset driver is not needed. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Makefile | 3 ++- 1 file

Re: [PATCH u-boot-mvebu v3 07/18] arm: mvebu: turris_omnia: Disable Atmel SHA node if not present

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: If the FEAT_CRYPTO feature bit is present in MCU features, the board crypto is implemented by MCU and the Atmel SHA chip is not present. Disable Atmel SHA device-tree node in that case. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH u-boot-mvebu v3 06/18] arm: mvebu: turris_omnia: Print board ECDSA public key if available

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: If MCU supports the FEAT_CRYPTO feature, read board ECDSA public key from MCU and print it. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_omnia/turris_omnia.c | 25 +++- 1 file

Re: [PATCH u-boot-mvebu v3 05/18] arm: mvebu: turris_omnia: Implement getting board information from MCU

2024-03-28 Thread Stefan Roese
. Signed-off-by: Marek Behún Minor comment below. Other than this: Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_atsha_otp.c | 27 +-- board/CZ.NIC/turris_omnia/Makefile | 2 +- board/CZ.NIC/turris_omnia/turris_omnia.c | 94

Re: [PATCH u-boot-mvebu v3 04/18] arm: mvebu: turris_omnia: Update MCU status and features reading

2024-03-28 Thread Stefan Roese
transaction fails. Handle both cases. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_omnia/turris_omnia.c | 100 +++ 1 file changed, 68 insertions(+), 32 deletions(-) diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b

Re: [PATCH u-boot-mvebu v3 03/18] arm: mvebu: turris_{omnia, mox}: Don't print model two times

2024-03-28 Thread Stefan Roese
checkboard() also does. Remove the second print. Fixes: 8cd4bf7dc9ba ("turris: Use checkboard() instead of show_board_info()") Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_mox/turris_mox.c | 5 + board/CZ.NIC/turris_omni

Re: [PATCH u-boot-mvebu v3 02/18] arm: mvebu: turris_omnia: Add header containing MCU command interface and use it

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Add header containing all MCU command definitions and use it in board code and in MCU driver. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_omnia/turris_omnia.c | 81 +++- drivers/gpio

Re: [PATCH u-boot-mvebu v3 01/18] arm: mvebu: turris_omnia: Enable LTO by default on Turris Omnia

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: U-Boot builds for Turris Omnia are approaching the limit of 0xf bytes, which is the size of the U-Boot partition on Omnia. Enable LTO to get more size optimized binaries. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v2] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-28 Thread Stefan Roese
Walle # on lschv2 Tony, many thanks to work on this consolidation. Very impressive results. I can't test anything of this though, but my plan would be to pull this in the upcoming merge window, if nobody complains. Reviewed-by: Stefan Roese Thanks, Stefan

Please pull u-boot-marvell/master

2024-03-05 Thread Stefan Roese
Hi Tom, please pull this next batch of mostly Marvell related patches: - net: mv88e6xxx: fix missing SMI address initialization (Marek) - mvebu: turris_omnia: Enable networking via ethernet switch (Marek) - mvebu: helios-4: add

Re: [PATCH v5] rng: Add Turris Mox rTWM RNG driver

2024-03-05 Thread Stefan Roese
probe = turris_rwtm_rng_probe, + .remove = turris_rwtm_rng_remove, + .priv_auto = sizeof(struct turris_rwtm_rng_priv), +}; Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH v2 3/3] board: helios-4: add config fragment for spi booting

2024-03-05 Thread Stefan Roese
=0x1 Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH v2 2/3] arm: mvebu: helios4_defconfig: enable setexpr command

2024-03-05 Thread Stefan Roese
is not set CONFIG_CMD_TFTPPUT=y CONFIG_CMD_CACHE=y CONFIG_CMD_TIME=y Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80

Re: [PATCH v2 1/3] arm: dts: armada-38x-solidrun-microsom: configure i2c0 bus

2024-03-05 Thread Stefan Roese
-frequency = <40>; + pinctrl-0 = <_pins>; + pinctrl-names = "default"; + status = "okay"; + eeprom@53 { compatible = "atmel,24c02"; reg = <0x53>; Viele Grüße, Stefan Roese -- DENX Software

Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Enable networking via ethernet switch

2024-03-05 Thread Stefan Roese
onfigs/turris_omnia_defconfig @@ -96,7 +96,9 @@ CONFIG_SPI_FLASH_WINBOND=y CONFIG_SPI_FLASH_MTD=y CONFIG_PHY_MARVELL=y CONFIG_PHY_FIXED=y +CONFIG_DM_DSA=y CONFIG_PHY_GIGE=y +CONFIG_MV88E6XXX=y CONFIG_MVNETA=y CONFIG_MII=y CONFIG_MVMDIO=y Viele Grüße, Stefan Roese -- DENX Software E

Re: [PATCH v2] net: mv88e6xxx: fix missing SMI address initialization

2024-03-05 Thread Stefan Roese
return -EINVAL; + } + priv->smi_addr = smi_addr; + /* probe internal mdio bus */ ret = mv88e6xxx_probe_mdio(dev); if (ret) Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office:

Re: [PATCH v2] net: mv88e6xxx: fix missing SMI address initialization

2024-03-05 Thread Stefan Roese
Hi Marek, On 3/4/24 15:48, Marek Behún wrote: Hi Stefan, On Wed, 14 Feb 2024 08:50:16 +0100 Stefan Roese wrote: Hi Ramon, On 1/9/24 10:37, Stefan Roese wrote: On 12/18/23 17:09, Marek Behún wrote: On Wed, 6 Dec 2023 15:35:56 +0100 Marek Mojík wrote: The mv88e6xxx driver does

Re: [PATCH v5] rng: Add Turris Mox rTWM RNG driver

2024-02-16 Thread Stefan Roese
rwtm_rng_remove, + .priv_auto = sizeof(struct turris_rwtm_rng_priv), +}; Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v2] net: mv88e6xxx: fix missing SMI address initialization

2024-02-13 Thread Stefan Roese
Hi Ramon, On 1/9/24 10:37, Stefan Roese wrote: On 12/18/23 17:09, Marek Behún wrote: On Wed, 6 Dec 2023 15:35:56 +0100 Marek Mojík wrote: The mv88e6xxx driver does not currently initialize the smi_addr field, but instead keeps the default zero value. This leads to driver being unusable

Re: [PATCH v4] rng: Add Turris Mox rTWM RNG driver

2024-02-13 Thread Stefan Roese
Hi Max, mostly some nitpicking comments below. On 2/11/24 14:04, Max Resch wrote: A RNG driver for Armada 3720 boards running the Turris Mox rWTM firmware from CZ.NIC in the secure processor. Signed-off-by: Max Resch --- Changes in v4: - wrongful/missing git rebase Changes in v3: -

Re: [PATCH v3] rng: Add Turris Mox rTWM RNG driver

2024-02-07 Thread Stefan Roese
struct turris_rwtm_rng_priv *priv = dev_get_priv(dev); + phys_addr_t phys = priv->buffer; - p = ((struct turris_rwtm_rng_priv *)dev_get_priv(dev))->buffer; - dma_free_coherent((void *)p); + dma_free_coherent((void *)phys); return 0; } Viele Grüße, Stefan Roese -- DENX So

Please pull u-boot-watchdog/master

2024-02-01 Thread Stefan Roese
Hi Tom, please pull the following watchdog related last minute fixes: - add andes atcwdt200 support (Randolph) Here the Azure build, without any issues:

Re: [PATCH V4 2/2] configs: andes: add watchdog support fot andes ae350

2024-02-01 Thread Stefan Roese
IG_BAUDRATE=38400 CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_ATCSPI200_SPI=y +# CONFIG_WATCHDOG_AUTOSTART is not set +CONFIG_WDT=y +CONFIG_WDT_ATCWDT200=y Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 G

Re: [PATCH V4 1/2] drivers: watchdog: add andes atcwdt200 support

2024-02-01 Thread Stefan Roese
.stop = atcwdt_wdt_stop, + .expire_now = atcwdt_wdt_expire_now, +}; + +static const struct udevice_id atcwdt_wdt_ids[] = { + {.compatible = "andestech,atcwdt200"}, + {} +}; + +U_BOOT_DRIVER(atcwdt) = { + .name = "atcwdt200", + .id = UCLASS_WDT, + .probe = a

Re: [PATCH V4 2/2] configs: andes: add watchdog support fot andes ae350

2024-02-01 Thread Stefan Roese
Hi Randolph, On 1/31/24 07:30, Randolph Lin wrote: On Wed, Jan 24, 2024 at 09:37:41AM +0100, Stefan Roese wrote: Hi Stefan, Thank you for testing and reviewing. I have checked the error message and the relationship to my patch. The reason for the failure has nothing to do with my patch. Could

Re: [PATCH V4 2/2] configs: andes: add watchdog support fot andes ae350

2024-01-24 Thread Stefan Roese
V # " CONFIG_CMD_IMLS=y CONFIG_CMD_MMC=y CONFIG_CMD_SF_TEST=y +CONFIG_CMD_WDT=y # CONFIG_CMD_SETEXPR is not set CONFIG_BOOTP_PREFER_SERVERIP=y CONFIG_CMD_CACHE=y @@ -50,3 +51,6 @@ CONFIG_BAUDRATE=38400 CONFIG_SYS_NS16550=y CONFIG_SPI=y CONFIG_ATCSPI200_SPI=y +# CONFIG_WATCHDOG_AUTOS

Please pull u-boot-marvell/master

2024-01-22 Thread Stefan Roese
Hi Tom, please pull this next batch of Marvell related patches: - solidrun: clearfog gtr: add serdes configuration (Josua) Here the Azure build, without any issues:

Re: [PATCH v2 0/2] board: solidrun: clearfog gtr: add serdes configuration

2024-01-22 Thread Stefan Roese
On 1/12/24 14:35, Josua Mayer wrote: Add missing configuration options for clearog gtr serdes: 1. select between sata and pci-e for serdes 0 2. configure serdes 2 for 2.5Gbps link with managed switch Signed-off-by: Josua Mayer --- Changes in v2: - change choice default logic to remove kconfig

Re: [PATCH 3/3] arm: mvebu: helios-4: add defconfig for spi booting

2024-01-22 Thread Stefan Roese
Hi Josua, On 1/13/24 18:22, Tom Rini wrote: On Sat, Jan 13, 2024 at 05:36:57PM +0100, Josua Mayer wrote: Add a new defconfig based on existing helios4_config file to support booting from spi flash. Settings for environment location are based on vendor u-boot:

Please pull u-boot-marvell/master

2024-01-10 Thread Stefan Roese
Hi Tom, please pull this next batch of Marvell related patches: - AC5: Use finer grained memory map (Chris) - Espressobin: Misc improvements (Robert) - eDPU: Support new board revision (Robert)

Re: [PATCH v3 3/3] arm: mvebu: eDPU: support new board revision

2024-01-10 Thread Stefan Roese
in U-Boot, so we disable both ports. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan --- Changes in v3: * Add check for DM_MDIO arch/arm/dts/armada-3720-eDPU-u-boot.dtsi | 13 ++- arch/arm/dts/armada-3720-eDPU.dts | 47

Re: [PATCH v3 2/3] arm: mvebu: Espressobin: move network setup into a separate function

2024-01-10 Thread Stefan Roese
be no functional change. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan --- Changes in v2: * Rebase on top of current master and resolve conflicts board/Marvell/mvebu_armada-37xx/board.c | 17 - 1 file changed, 12

Re: [PATCH v3 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2024-01-10 Thread Stefan Roese
be no functional change. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan --- board/Marvell/mvebu_armada-37xx/board.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/board/Marvell/mvebu_armada-37xx

Re: [PATCH] arm: mvebu: AC5: Use finer grained memory map

2024-01-10 Thread Stefan Roese
, + .attrs = AC5_PTE_BLOCK_DEVICE, + }, + { + .phys = 0x8000, + .virt = 0x8000, + .size = SZ_2G, + .attrs = AC5_PTE_BLOCK_DEVICE, }, { 0, Viele Grüße, Stefan Roese -- DENX Software

Re: [PATCH v3 1/3] arm: mvebu: Espressobin: move FDT fixup into a separate function

2024-01-09 Thread Stefan Roese
to a separate function and call it if compatible matches, there should be no functional change. Signed-off-by: Robert Marko Reviewed-by: Stefan Roese Hi Stefan, Since 2024.01 was released, can this series be pulled in now? It's on my list. I actually already started with some CI build tests. Hope

Re: [PATCH 1/2] arm: mvebu: clearfog gtr: add config option to select serdes0 interface

2024-01-09 Thread Stefan Roese
rd_serdes_map[0].serdes_mode = PEX_ROOT_COMPLEX_X1; + } } else if (sr_product_is(_tlv_data, "Clearfog Pro")) { /* handle recognized product as noop, no adjustment required */ } else if (sr_product_is(_tlv_data, "Clearfog Base&quo

Re: [PATCH v2] net: mv88e6xxx: fix missing SMI address initialization

2024-01-09 Thread Stefan Roese
return -EINVAL; + } + priv->smi_addr = smi_addr; + /* probe internal mdio bus */ ret = mv88e6xxx_probe_mdio(dev); if (ret) Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Ramon, this patch was assigned to me as an Marvell MVEBU patc

Re: [PATCH 2/4] watchdog: Add StarFive Watchdog driver

2023-12-04 Thread Stefan Roese
because JH7100 can be added later and have a consistency with the linux driver. Signed-off-by: Chanho Park Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/watchdog/Kconfig| 7 + drivers/watchdog/Makefile | 1 + drivers/watchdog/starfive_wdt.c | 329

Please pull u-boot-watchdog/master

2023-12-04 Thread Stefan Roese
Hi Tom, please pull the following watchdog related fix: - Correct watchdog timeout print message (Chanho Park) Here the Azure build, without any issues:

Re: [PATCH v2] watchdog: Correct watchdog timeout print message

2023-12-04 Thread Stefan Roese
s, 1000)); } return ret; Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de

Re: [PATCH 1/5] cyclic: Disable in SPL builds

2023-12-03 Thread Stefan Roese
from tools/../lib/sha1.c:25, from tools/generated/lib/sha1.c:1: include/cyclic.h:47:22: error: missing binary operator before token "(" 47 | #if CONFIG_IS_ENABLED(CYCLIC) | ^ Regards, Simon Viele Grüße, Stefan Roese -- DENX Softw

  1   2   3   4   5   6   7   8   9   10   >