Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-11 Thread Sughosh Ganu
On Thu, 10 Aug 2023 at 22:47, Tom Rini wrote: > > On Thu, Aug 10, 2023 at 10:39:06PM +0530, Sughosh Ganu wrote: > > On Thu, 10 Aug 2023 at 21:22, Tom Rini wrote: > > > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh Ganu wrote: > > > >

Re: [PATCH v8 7/9] sandbox: capsule: Generate capsule related files through binman

2023-08-10 Thread Sughosh Ganu
hi Simon, On Thu, 10 Aug 2023 at 22:57, Simon Glass wrote: > > Hi Sughosh, > > On Thu, 10 Aug 2023 at 08:24, Sughosh Ganu wrote: > > > > The EFI capsule files can now be generated as part of u-boot > > build through binman. Add capsule entry nodes for the sandbox &

Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-10 Thread Sughosh Ganu
On Thu, 10 Aug 2023 at 21:22, Tom Rini wrote: > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh Ganu wrote: > > > Build the mkeficapsule tool for all the sandbox variants. This tool > > will be used subsequently for testing capsule generation in binman. > > >

[PATCH v8 9/9] sandbox: trace: Increase trace buffer size

2023-08-10 Thread Sughosh Ganu
When running the trace test on the sandbox platform, the current size of 16MiB is no longer large enough for capturing the entire trace history, and results in truncation. Use a size of 32MiB for the trace buffer on the sandbox platform while running the trace test. Signed-off-by: Sughosh Ganu

[PATCH v8 8/9] doc: Add documentation to highlight capsule generation related updates

2023-08-10 Thread Sughosh Ganu
The EFI capsules can now be generated as part of u-boot build, through binman. Highlight these changes in the documentation. Signed-off-by: Sughosh Ganu --- Changess since V7: * Change the name of the file which contains the capsule entry binman nodes. doc/develop/uefi/uefi.rst | 16

[PATCH v8 7/9] sandbox: capsule: Generate capsule related files through binman

2023-08-10 Thread Sughosh Ganu
logic in the test setup which was used for generation of these capsule which is now superfluous. Signed-off-by: Sughosh Ganu --- Changes since V7: * Move the capsule generation logic to sandbox_capsule.dtsi and include that explicitly in test.dts and sandbox.dts. * Drop the u-boot.dtsi file which

[PATCH v8 5/9] btool: mkeficapsule: Add a bintool for EFI capsule generation

2023-08-10 Thread Sughosh Ganu
Add a bintool for generating EFI capsules. This calls the mkeficapsule tool which generates the capsules. Signed-off-by: Sughosh Ganu --- Changes since V7: None tools/binman/btool/mkeficapsule.py | 101 + 1 file changed, 101 insertions(+) create mode 100644 tools

[PATCH v8 6/9] binman: capsule: Add support for generating EFI capsules

2023-08-10 Thread Sughosh Ganu
Add support in binman for generating EFI capsules. The capsule parameters can be specified through the capsule binman entry. Also add test cases in binman for testing capsule generation. Signed-off-by: Sughosh Ganu --- Changes since V7: * Rebase on top of current upstream. * Drop the ReadEntries

[PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-10 Thread Sughosh Ganu
Build the mkeficapsule tool for all the sandbox variants. This tool will be used subsequently for testing capsule generation in binman. Signed-off-by: Sughosh Ganu --- Changes since V7: None tools/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/Kconfig b

[PATCH v8 3/9] sandbox: capsule: Add keys and certificates needed for capsule update testing

2023-08-10 Thread Sughosh Ganu
is to be used as malicious keys for testing authentication failure cases. The capsule_pub_key_good.crt is also converted to an EFI Signature List(ESL) file, SIGNER.esl, which is embedded in the platform's device-tree for capsule authentication. Signed-off-by: Sughosh Ganu --- Changes since V7: * Change

[PATCH v8 0/9] Enable EFI capsule generation through binman

2023-08-10 Thread Sughosh Ganu
the capsule and signature nodes. * Remove capsule generation logic from capsule update test setup. * Keep the logic to embed the public key in DTB in the test setup. * Change the name of the file which contains the capsule entry binman nodes. Sughosh Ganu (9): binman: bintool: Build a tool

[PATCH v8 1/9] binman: bintool: Build a tool from a list of commands

2023-08-10 Thread Sughosh Ganu
Add support to build a tool from source with a list of commands. This is useful when a tool can be built with multiple commands instead of a single command. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V7: None tools/binman/bintool.py | 19 +++ 1 file

[PATCH v8 2/9] nuvoton: npcm845-evb: Add a newline at the end of file

2023-08-10 Thread Sughosh Ganu
Add a newline at the end of the dts, without which the build fails when including a dtsi file. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas --- Changes since V7: * Rephrase the commit message arch/arm/dts/nuvoton-npcm845-evb.dts | 2 +- 1 file changed, 1

Re: [PATCH v7 08/11] binman: capsule: Add support for generating EFI capsules

2023-08-07 Thread Sughosh Ganu
hi Simon, On Mon, 7 Aug 2023 at 07:04, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 6 Aug 2023 at 13:27, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Mon, 7 Aug 2023 at 00:16, Simon Glass wrote: > > > > > > Hi Sughosh, > &

Re: [PATCH v7 04/11] capsule: authenticate: Add capsule public key in platform's dtb

2023-08-06 Thread Sughosh Ganu
hi Simon, On Mon, 7 Aug 2023 at 00:16, Simon Glass wrote: > > Hi, > > On Sun, 6 Aug 2023 at 11:25, Tom Rini wrote: > > > > On Sun, Aug 06, 2023 at 04:48:11PM +0530, Sughosh Ganu wrote: > > > On Sun, 6 Aug 2023 at 03:42, Tom Rini wrote: > > > > >

Re: [PATCH v7 08/11] binman: capsule: Add support for generating EFI capsules

2023-08-06 Thread Sughosh Ganu
hi Simon, On Mon, 7 Aug 2023 at 00:16, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 6 Aug 2023 at 09:35, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sat, 5 Aug 2023 at 22:50, Simon Glass wrote: > > > > > > Hi Sughosh, >

Re: [PATCH v7 08/11] binman: capsule: Add support for generating EFI capsules

2023-08-06 Thread Sughosh Ganu
hi Simon, On Sat, 5 Aug 2023 at 22:50, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 09:03, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu wrote: > > > > > > Add support in binman for

Re: [PATCH v7 04/11] capsule: authenticate: Add capsule public key in platform's dtb

2023-08-06 Thread Sughosh Ganu
On Sun, 6 Aug 2023 at 03:42, Tom Rini wrote: > > On Sat, Aug 05, 2023 at 09:03:53AM -0600, Simon Glass wrote: > > Hi Sughosh, > > > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu wrote: > > > > > > The EFI capsule authentication logic in u-boot expects

Re: [PATCH v7 09/11] sandbox: capsule: Generate capsule related files through binman

2023-08-06 Thread Sughosh Ganu
On Sun, 6 Aug 2023 at 03:48, Tom Rini wrote: > > On Sat, Aug 05, 2023 at 09:04:00AM -0600, Simon Glass wrote: > > Hi Sughosh, > > > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu wrote: > > > > > > The EFI capsule files can now be generated as part of u-bo

Re: [PATCH v7 08/11] binman: capsule: Add support for generating EFI capsules

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sun, 6 Aug 2023 at 00:35, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 12:42, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sat, 5 Aug 2023 at 20:34, Simon Glass wrote: > > > > > > Hi Sughosh, > &

Re: [PATCH v7 04/11] capsule: authenticate: Add capsule public key in platform's dtb

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sun, 6 Aug 2023 at 00:35, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 12:47, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sun, 6 Aug 2023 at 00:06, Simon Glass wrote: > > > > > > Hi Sughosh, > &

Re: [PATCH v7 09/11] sandbox: capsule: Generate capsule related files through binman

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sun, 6 Aug 2023 at 00:06, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 12:01, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sat, 5 Aug 2023 at 20:34, Simon Glass wrote: > > > > > > Hi Sughosh, > &

Re: [PATCH v7 03/11] sandbox: capsule: Add keys and certificates needed for capsule update testing

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sun, 6 Aug 2023 at 00:06, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 11:50, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sat, 5 Aug 2023 at 20:34, Simon Glass wrote: > > > > > > Hi Sughosh, > &

Re: [PATCH v7 04/11] capsule: authenticate: Add capsule public key in platform's dtb

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sun, 6 Aug 2023 at 00:06, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 11:54, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sat, 5 Aug 2023 at 20:34, Simon Glass wrote: > > > > > > Hi Sughosh, > &

Re: [PATCH v7 08/11] binman: capsule: Add support for generating EFI capsules

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sat, 5 Aug 2023 at 22:50, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 09:03, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu wrote: > > > > > > Add support in binman for

Re: [PATCH v7 08/11] binman: capsule: Add support for generating EFI capsules

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sat, 5 Aug 2023 at 20:34, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu wrote: > > > > Add support in binman for generating EFI capsules. The capsule > > parameters can be specified through the capsule binman

Re: [PATCH v7 10/11] doc: Add documentation to highlight capsule generation related updates

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sat, 5 Aug 2023 at 20:34, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu wrote: > > > > The EFI capsules can now be generated as part of u-boot build, through > > Please check your patches for 'U-Boot' throughout.

Re: [PATCH v7 07/11] btool: mkeficapsule: Add a bintool for EFI capsule generation

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sat, 5 Aug 2023 at 20:34, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu wrote: > > > > Add a bintool for generating EFI capsules. This calls the mkeficapsule > > tool which generates the capsules. >

Re: [PATCH v7 09/11] sandbox: capsule: Generate capsule related files through binman

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sat, 5 Aug 2023 at 20:34, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu wrote: > > > > The EFI capsule files can now be generated as part of u-boot > > build through binman. Add capsule entry nodes in the u

Re: [PATCH v7 11/11] sandbox: trace: Increase trace buffer size

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sat, 5 Aug 2023 at 20:34, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 05:36, Sughosh Ganu wrote: > > > > When running the trace test on the sandbox platform, the current size > > of 16MiB is no longer large enough for capturin

Re: [PATCH v7 04/11] capsule: authenticate: Add capsule public key in platform's dtb

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sat, 5 Aug 2023 at 20:34, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu wrote: > > > > The EFI capsule authentication logic in u-boot expects the public key > > in the form of an EFI Signature List(ESL) to be provided

Re: [PATCH v7 03/11] sandbox: capsule: Add keys and certificates needed for capsule update testing

2023-08-05 Thread Sughosh Ganu
hi Simon, On Sat, 5 Aug 2023 at 20:34, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 5 Aug 2023 at 05:35, Sughosh Ganu wrote: > > > > Add the private keys and public key certificates which are to be used > > for capsule authentication while testing the EFI ca

[PATCH v7 11/11] sandbox: trace: Increase trace buffer size

2023-08-05 Thread Sughosh Ganu
When running the trace test on the sandbox platform, the current size of 16MiB is no longer large enough for capturing the entire trace history, and results in truncation. Use a size of 32MiB for the trace buffer on the sandbox platform while running the trace test. Signed-off-by: Sughosh Ganu

[PATCH v7 10/11] doc: Add documentation to highlight capsule generation related updates

2023-08-05 Thread Sughosh Ganu
The EFI capsules can now be generated as part of u-boot build, through binman. Highlight these changes in the documentation. Signed-off-by: Sughosh Ganu --- Changes since V6: None doc/develop/uefi/uefi.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/develop/uefi

[PATCH v7 09/11] sandbox: capsule: Generate capsule related files through binman

2023-08-05 Thread Sughosh Ganu
binman nodes for generating the input files used for these capsules. Remove the corresponding logic which was used for generation of these input files which is now superfluous. Signed-off-by: Sughosh Ganu --- Changes since V6: * Use macros defined in sandbox_efi_capsule for GUIDs and capsule

[PATCH v7 08/11] binman: capsule: Add support for generating EFI capsules

2023-08-05 Thread Sughosh Ganu
Add support in binman for generating EFI capsules. The capsule parameters can be specified through the capsule binman entry. Also add test cases in binman for testing capsule generation. Signed-off-by: Sughosh Ganu --- Changes since V6: * Add macros for the GUID strings in sandbox_efi_capsule.h

[PATCH v7 07/11] btool: mkeficapsule: Add a bintool for EFI capsule generation

2023-08-05 Thread Sughosh Ganu
Add a bintool for generating EFI capsules. This calls the mkeficapsule tool which generates the capsules. Signed-off-by: Sughosh Ganu --- Changes since V6: * Split the changes for mkeficapsule btool into a separate patch, as suggested by Simon Glass. * Use the word commandline consistently

[PATCH v7 06/11] sandbox: Build the mkeficapsule tool for the sandbox variants

2023-08-05 Thread Sughosh Ganu
Build the mkeficapsule tool for all the sandbox variants. This tool will be used subsequently for testing capsule generation in binman. Signed-off-by: Sughosh Ganu --- Changes since V6: * New patch which has been split up from the binman capsule entry support patch from earlier version

[PATCH v7 05/11] doc: capsule: Document the new mechanism to embed ESL file into dtb

2023-08-05 Thread Sughosh Ganu
Update the document to specify how the EFI Signature List(ESL) file can be embedded into the platform's dtb as part of the u-boot build. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V6: None doc/develop/uefi/uefi.rst | 22 +- 1 file changed, 9

[PATCH v7 04/11] capsule: authenticate: Add capsule public key in platform's dtb

2023-08-05 Thread Sughosh Ganu
the CONFIG_EFI_CAPSULE_ESL_FILE symbol. Signed-off-by: Sughosh Ganu --- Changes since V6: * Populate the CONFIG_EFI_CAPSULE_ESL_FILE symbol for sandbox and sandbox_flattree which enable capsule authentication. Note: Simon Glass had asked me to rid of the CONFIG_EFI_HAVE_CAPSULE_SUPPORT ifdef used

[PATCH v7 03/11] sandbox: capsule: Add keys and certificates needed for capsule update testing

2023-08-05 Thread Sughosh Ganu
is to be used as malicious keys for testing authentication failure cases. The SIGNER.crt is also converted to an EFI Signature List(ESL) file, SIGNER.esl, which is embedded in the platform's device-tree for capsule authentication. Signed-off-by: Sughosh Ganu --- Changes since V6: * New patch that puts

[PATCH v7 02/11] nuvoton: npcm845-evb: Add a newline at the end of file

2023-08-05 Thread Sughosh Ganu
Add a newline at the end of the dts, without which the build fails when including the u-boot.dtsi file. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas --- Changes since V6: None arch/arm/dts/nuvoton-npcm845-evb.dts | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v7 01/11] binman: bintool: Build a tool from a list of commands

2023-08-05 Thread Sughosh Ganu
Add support to build a tool from source with a list of commands. This is useful when a tool can be built with multiple commands instead of a single command. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V6: None tools/binman/bintool.py | 19 +++ 1 file

[PATCH v7 00/11] Integrate EFI capsule tasks into u-boot's build flow

2023-08-05 Thread Sughosh Ganu
to capsule_input.bin. * Use macros defined in sandbox_efi_capsule for GUIDs and capsule input filenames. * Generate the capsule input files through binman text entries. * New patch for fixing CI trace test failure. Sughosh Ganu (11): binman: bintool: Build a tool from a list of commands nuvoton: npcm845

Re: [PATCH v6 9/9] sandbox: capsule: Generate capsule related files through binman

2023-08-04 Thread Sughosh Ganu
hi Simon, On Fri, 4 Aug 2023 at 08:32, Simon Glass wrote: > > Hi Sughosh, > > On Thu, 3 Aug 2023 at 05:18, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Wed, 2 Aug 2023 at 18:23, Simon Glass wrote: > > > > > > Hi Sughosh, > &

Re: [PATCH v6 6/9] binman: capsule: Add support for generating EFI capsules

2023-08-04 Thread Sughosh Ganu
hi Simon, On Fri, 4 Aug 2023 at 08:32, Simon Glass wrote: > > Hi Sughosh, > > On Thu, 3 Aug 2023 at 05:08, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Wed, 2 Aug 2023 at 18:23, Simon Glass wrote: > > > > > > Hi Sughosh, > &

Re: [PATCH v5 03/12] capsule: authenticate: Add capsule public key in platform's dtb

2023-08-03 Thread Sughosh Ganu
hi Simon, On Wed, 2 Aug 2023 at 18:22, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 1 Aug 2023 at 11:35, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Wed, 26 Jul 2023 at 19:56, Simon Glass wrote: > > > > > > Hi Sughosh, > > >

Re: [PATCH v6 9/9] sandbox: capsule: Generate capsule related files through binman

2023-08-03 Thread Sughosh Ganu
hi Simon, On Wed, 2 Aug 2023 at 18:23, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 1 Aug 2023 at 11:41, Sughosh Ganu wrote: > > > > The EFI capsule files can now be generated as part of u-boot > > build. This is done through binman. Add capsule entr

Re: [PATCH v6 3/9] capsule: authenticate: Add capsule public key in platform's dtb

2023-08-03 Thread Sughosh Ganu
hi Simon, On Wed, 2 Aug 2023 at 19:04, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 2 Aug 2023 at 06:52, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Tue, 1 Aug 2023 at 11:40, Sughosh Ganu wrote: > > > > > > The EFI capsule

Re: [PATCH v6 6/9] binman: capsule: Add support for generating EFI capsules

2023-08-03 Thread Sughosh Ganu
hi Simon, On Wed, 2 Aug 2023 at 18:23, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 1 Aug 2023 at 11:41, Sughosh Ganu wrote: > > > > Add support in binman for generating EFI capsules. The capsule > > parameters can be specified through the capsule binman

[PATCH v6 9/9] sandbox: capsule: Generate capsule related files through binman

2023-08-01 Thread Sughosh Ganu
was used for generating this FIT image. Signed-off-by: Sughosh Ganu --- Changes since V5: * Use the public key ESL file and other input files from the tree instead of the /tmp/capsules/ directory being used in previous version. * Use macros for other input files and certs. arch/sandbox/dts/u

[PATCH v6 8/9] test: capsule: Remove public key embed logic from capsule update test

2023-08-01 Thread Sughosh Ganu
-by: Sughosh Ganu --- Changes since V5: * Use the public key ESL file from the tree instead of the /tmp/capsules/ directory being used in previous version. configs/sandbox_defconfig| 1 + configs/sandbox_flattree_defconfig | 1 + test/py/tests/test_efi_capsule

[PATCH v6 7/9] doc: Add documentation to highlight capsule generation related updates

2023-08-01 Thread Sughosh Ganu
The EFI capsules can now be generated as part of u-boot build, through binman. Highlight these changes in the documentation. Signed-off-by: Sughosh Ganu --- Changes since V5: * Remove the documentation for generating the capsule through config file, as that functionality is not added through

[PATCH v6 6/9] binman: capsule: Add support for generating EFI capsules

2023-08-01 Thread Sughosh Ganu
Add support in binman for generating EFI capsules. The capsule parameters can be specified through the capsule binman entry. Also add test cases in binman for testing capsule generation. Signed-off-by: Sughosh Ganu --- Changes since V5: * Add support for the oemflag parameter used in FWU A/B

[PATCH v6 5/9] test: capsule: Add files needed for testing EFI capsule updates

2023-08-01 Thread Sughosh Ganu
will be embedded in the platform's DTB. Signed-off-by: Sughosh Ganu --- Changes since V5: * Get rid of the logic of keeping the files under the /tmp/capsules/ directory from earlier versions. * New patch which introduces the input files and certs needed for EFI capsule update testing in the tree

[PATCH v6 4/9] doc: capsule: Document the new mechanism to embed ESL file into dtb

2023-08-01 Thread Sughosh Ganu
Update the document to specify how the EFI Signature List(ESL) file can be embedded into the platform's dtb as part of the u-boot build. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V5: None doc/develop/uefi/uefi.rst | 22 +- 1 file changed, 9

[PATCH v6 3/9] capsule: authenticate: Add capsule public key in platform's dtb

2023-08-01 Thread Sughosh Ganu
the CONFIG_EFI_CAPSULE_ESL_FILE symbol. Signed-off-by: Sughosh Ganu --- Changes since V5: * None arch/arm/dts/u-boot.dtsi | 14 ++ arch/sandbox/dts/u-boot.dtsi | 17 + lib/efi_loader/Kconfig | 9 + 3 files changed, 40 insertions(+) create mode 100644 arch

[PATCH v6 2/9] nuvoton: npcm845-evb: Add a newline at the end of file

2023-08-01 Thread Sughosh Ganu
Add a newline at the end of the dts, without which the build fails when including the u-boot.dtsi file. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas --- Changes since V5: None arch/arm/dts/nuvoton-npcm845-evb.dts | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v6 1/9] binman: bintool: Build a tool from a list of commands

2023-08-01 Thread Sughosh Ganu
Add support to build a tool from source with a list of commands. This is useful when a tool can be built with multiple commands instead of a single command. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V5: None tools/binman/bintool.py | 19 +++ 1 file

[PATCH v6 0/9] Integrate EFI capsule tasks into u-boot's build flow

2023-08-01 Thread Sughosh Ganu
/capsules/ directory being used in previous version. * Use the public key ESL file and other input files from the tree instead of the /tmp/capsules/ directory being used in previous version. * Use macros for other input files and certs. Sughosh Ganu (9): binman: bintool: Build a tool from a list

Re: [PATCH v5 03/12] capsule: authenticate: Add capsule public key in platform's dtb

2023-08-01 Thread Sughosh Ganu
hi Simon, On Wed, 26 Jul 2023 at 19:56, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 26 Jul 2023 at 02:57, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Wed, 26 Jul 2023 at 04:22, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH v4 06/12] binman: capsule: Add support for generating capsules

2023-08-01 Thread Sughosh Ganu
hi Simon, On Wed, 26 Jul 2023 at 04:06, Simon Glass wrote: > > Hi Sughosh, > > On Thu, 20 Jul 2023 at 03:20, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Thu, 20 Jul 2023 at 00:41, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH v5 06/12] Dockerfile: capsule: Setup the files needed for capsule update testing

2023-07-26 Thread Sughosh Ganu
On Wed, 26 Jul 2023 at 22:09, Tom Rini wrote: > > On Wed, Jul 26, 2023 at 08:11:44PM +0530, Sughosh Ganu wrote: > > hi Simon, > > > > On Wed, 26 Jul 2023 at 19:41, Simon Glass wrote: > > > > > > Hi Tom, > > > > > > On Wed, 26 Jul 20

Re: [PATCH v4 06/12] binman: capsule: Add support for generating capsules

2023-07-26 Thread Sughosh Ganu
hi Simon, On Wed, 26 Jul 2023 at 04:06, Simon Glass wrote: > > Hi Sughosh, > > On Thu, 20 Jul 2023 at 03:20, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Thu, 20 Jul 2023 at 00:41, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH v5 06/12] Dockerfile: capsule: Setup the files needed for capsule update testing

2023-07-26 Thread Sughosh Ganu
hi Simon, On Wed, 26 Jul 2023 at 19:41, Simon Glass wrote: > > Hi Tom, > > On Wed, 26 Jul 2023 at 07:23, Tom Rini wrote: > > > > On Wed, Jul 26, 2023 at 03:16:38PM +0530, Sughosh Ganu wrote: > > > On Wed, 26 Jul 2023 at 04:26, Tom Rini wrote: > > > &g

Re: [PATCH v5 08/12] doc: Add documentation to highlight capsule generation related updates

2023-07-26 Thread Sughosh Ganu
hi Heinrich, On Tue, 25 Jul 2023 at 21:42, Heinrich Schuchardt wrote: > > On 25.07.23 10:57, Sughosh Ganu wrote: > > The UEFI capsule can now be generate by specifying the capsule > > parameters through a config file. Additionally, the capsules can be > > generated

Re: [PATCH v5 06/12] Dockerfile: capsule: Setup the files needed for capsule update testing

2023-07-26 Thread Sughosh Ganu
On Wed, 26 Jul 2023 at 18:53, Tom Rini wrote: > > On Wed, Jul 26, 2023 at 03:16:38PM +0530, Sughosh Ganu wrote: > > On Wed, 26 Jul 2023 at 04:26, Tom Rini wrote: > > > > > > On Tue, Jul 25, 2023 at 04:52:38PM -0600, Simon Glass wrote: > > > >

Re: [PATCH v5 08/12] doc: Add documentation to highlight capsule generation related updates

2023-07-26 Thread Sughosh Ganu
hi Simon, On Wed, 26 Jul 2023 at 04:24, Simon Glass wrote: > > Hi, > > On Tue, 25 Jul 2023 at 10:18, Heinrich Schuchardt wrote: > > > > On 25.07.23 10:57, Sughosh Ganu wrote: > > > The UEFI capsule can now be generate by specifying the capsule >

Re: [PATCH v5 06/12] Dockerfile: capsule: Setup the files needed for capsule update testing

2023-07-26 Thread Sughosh Ganu
On Wed, 26 Jul 2023 at 04:26, Tom Rini wrote: > > On Tue, Jul 25, 2023 at 04:52:38PM -0600, Simon Glass wrote: > > On Tue, 25 Jul 2023 at 02:58, Sughosh Ganu wrote: > > > > > > Support has being added through earlier commits to build capsules > > > and

Re: [PATCH v5 10/12] test: capsule: Remove public key embed logic from capsule update test

2023-07-26 Thread Sughosh Ganu
hi Simon, On Wed, 26 Jul 2023 at 04:24, Simon Glass wrote: > > On Tue, 25 Jul 2023 at 02:58, Sughosh Ganu wrote: > > > > The embedding of the public key EFI Signature List(ESL) file into the > > platform's DTB is now done at the time of u-boot build. Remove this &g

Re: [PATCH v5 03/12] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-26 Thread Sughosh Ganu
hi Simon, On Wed, 26 Jul 2023 at 04:22, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 25 Jul 2023 at 02:58, Sughosh Ganu wrote: > > > > The EFI capsule authentication logic in u-boot expects the public key > > in the form of an EFI Signature Li

Re: [PATCH v5 09/12] test: py: Setup capsule files for testing

2023-07-26 Thread Sughosh Ganu
hi Simon, On Wed, 26 Jul 2023 at 04:23, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 25 Jul 2023 at 02:58, Sughosh Ganu wrote: > > > > Support has being added through earlier commits to build capsules and > > embed the public key needed for capsule authenticati

[PATCH v5 12/12] sandbox: capsule: Generate capsule related files through binman

2023-07-25 Thread Sughosh Ganu
was used for generating this FIT image. Signed-off-by: Sughosh Ganu --- Changes since V4: * Define macros for the image GUIDs being used for generating the capsules. * Use lower case for image GUIDs. arch/sandbox/dts/u-boot.dtsi | 271 ++ test/py/tests

[PATCH v5 07/12] binman: capsule: Add support for generating capsules

2023-07-25 Thread Sughosh Ganu
Add support in binman for generating capsules. The capsule parameters can be specified either through a config file or through the capsule binman entry. Also add test cases in binman for capsule generation, and enable this testing on the sandbox_spl variant. Signed-off-by: Sughosh Ganu

[PATCH v5 10/12] test: capsule: Remove public key embed logic from capsule update test

2023-07-25 Thread Sughosh Ganu
-by: Sughosh Ganu --- Changes since V4: None configs/sandbox_defconfig| 1 + configs/sandbox_flattree_defconfig | 1 + test/py/tests/test_efi_capsule/conftest.py | 37 test/py/tests/test_efi_capsule/signature.dts | 10 -- 4 files changed, 9

[PATCH v5 11/12] sandbox: capsule: Add a config file for generating capsules

2023-07-25 Thread Sughosh Ganu
the config file on the sandbox variant. Signed-off-by: Sughosh Ganu --- Changes since V4: * Use a relative path for CONFIG_EFI_CAPSULE_CFG_FILE. * Remove logic to copy capsule config file to /tmp/capsules/ directory, as the capsule entry can handle relative paths. * Add a comment in the capsule

[PATCH v5 09/12] test: py: Setup capsule files for testing

2023-07-25 Thread Sughosh Ganu
up in the pytest configuration file for testing the capsule update feature. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V4: None test/py/conftest.py | 84 + 1 file changed, 84 insertions(+) diff --git a/test/py/conftest.py b/test

[PATCH v5 05/12] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-07-25 Thread Sughosh Ganu
. This path is to be used for generating capsules through a make target, with the parameters being parsed from the config file. Signed-off-by: Sughosh Ganu --- Changes since V4: None tools/Kconfig | 16 ++ tools/Makefile | 1 + tools/eficapsule.h | 115

[PATCH v5 08/12] doc: Add documentation to highlight capsule generation related updates

2023-07-25 Thread Sughosh Ganu
The UEFI capsule can now be generate by specifying the capsule parameters through a config file. Additionally, the capsules can be generated as part of u-boot build, through binman. Highlight these changes in the documentation. Signed-off-by: Sughosh Ganu --- Changes since V4: None doc/develop

[PATCH v5 06/12] Dockerfile: capsule: Setup the files needed for capsule update testing

2023-07-25 Thread Sughosh Ganu
up in the CI configuration docker file for testing the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V4: * New patch which moves the setting up of the files needed for testing the EFI capsule update feature to the Dockerfile. Note: Earlier, this setup was being d

[PATCH v5 01/12] binman: bintool: Build a tool from a list of commands

2023-07-25 Thread Sughosh Ganu
Add support to build a tool from source with a list of commands. This is useful when a tool can be built with multiple commands instead of a single command. Signed-off-by: Sughosh Ganu --- Changes since V4: * Pass the single command target names directly to the function instead of putting them

[PATCH v5 00/12] Integrate EFI capsule tasks into u-boot's build flow

2023-07-25 Thread Sughosh Ganu
for the image GUIDs being used. * Use lower case for image GUIDs. * Define macros for the image GUIDs being used for generating the capsules. * Use lower case for image GUIDs. Sughosh Ganu (12): binman: bintool: Build a tool from a list of commands nuvoton: npcm845-evb: Add a newline

[PATCH v5 04/12] doc: capsule: Document the new mechanism to embed ESL file into dtb

2023-07-25 Thread Sughosh Ganu
Update the document to specify how the EFI Signature List(ESL) file can be embedded into the platform's dtb as part of the u-boot build. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V4: None doc/develop/uefi/uefi.rst | 22 +- 1 file changed, 9

[PATCH v5 03/12] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-25 Thread Sughosh Ganu
the CONFIG_EFI_CAPSULE_ESL_FILE symbol. Signed-off-by: Sughosh Ganu --- Changes since V4: * Fix multi line comment format. * Drop additional blank line. * Remove the check for CONFIG_EFI_HAVE_CAPSULE_SUPPORT from arm's u-boot.dtsi. * Wrap the help text in the EFI_CAPSULE_ESL_FILE config at 72 chars

[PATCH v5 02/12] nuvoton: npcm845-evb: Add a newline at the end of file

2023-07-25 Thread Sughosh Ganu
Add a newline at the end of the dts, without which the build fails when including the u-boot.dtsi file. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V4: None arch/arm/dts/nuvoton-npcm845-evb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread Sughosh Ganu
On Thu, 20 Jul 2023 at 14:56, Michal Simek wrote: > > > > On 7/20/23 10:45, Sughosh Ganu wrote: > > On Thu, 20 Jul 2023 at 13:26, Michal Simek wrote: > >> > >> > >> > >> On 7/20/23 08:36, Sughosh Ganu wrote: > >>> O

Re: [PATCH v4 06/12] binman: capsule: Add support for generating capsules

2023-07-20 Thread Sughosh Ganu
hi Simon, On Thu, 20 Jul 2023 at 00:41, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 19 Jul 2023 at 02:42, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Wed, 19 Jul 2023 at 06:41, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread Sughosh Ganu
On Thu, 20 Jul 2023 at 13:26, Michal Simek wrote: > > > > On 7/20/23 08:36, Sughosh Ganu wrote: > > On Thu, 20 Jul 2023 at 11:37, Michal Simek wrote: > >> > >> Hi, > >> > >> On 7/20/23 07:49, AKASHI Takahiro wrote: > >>> Hi,

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread Sughosh Ganu
On Thu, 20 Jul 2023 at 11:37, Michal Simek wrote: > > Hi, > > On 7/20/23 07:49, AKASHI Takahiro wrote: > > Hi, > > > > On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote: > >> > >> > >> On 7/18/23 17:41, Heinrich Schuchardt wrote: > >>> On 13.07.23 16:35, Michal Simek wrote: >

Re: [PATCH v4 12/12] sandbox: capsule: Generate capsule related files through binman

2023-07-19 Thread Sughosh Ganu
hi Simon, On Wed, 19 Jul 2023 at 06:41, Simon Glass wrote: > > Hi Sughosh, > > On Mon, 17 Jul 2023 at 05:18, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH v4 06/12] binman: capsule: Add support for generating capsules

2023-07-19 Thread Sughosh Ganu
hi Simon, On Wed, 19 Jul 2023 at 06:41, Simon Glass wrote: > > Hi Sughosh, > > On Mon, 17 Jul 2023 at 04:44, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH v4 08/12] CI: capsule: Setup the files needed for capsule update testing

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > Support has being added through earlier commits to build capsules > > and embed the public key needed for capsule authenticati

Re: [PATCH v4 12/12] sandbox: capsule: Generate capsule related files through binman

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > The EFI capsule files can now be generated as part of u-boot > > build. This is done through binman. Add capsule entr

Re: [PATCH v4 01/12] binman: bintool: Build a tool from a list of commands

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > Add support to build a tool from source with a list of commands. This > > is useful when a tool can be built with multiple co

Re: [PATCH v4 06/12] binman: capsule: Add support for generating capsules

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > Add support in binman for generating capsules. The capsule parameters > > can be specified either through a config file or

Re: [PATCH v4 11/12] sandbox: capsule: Add a config file for generating capsules

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > Support has been added to the mkeficapsule tool to generate capsules > > by parsing the capsule parameters through a config file. Add a

Re: [PATCH v4 03/12] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-17 Thread Sughosh Ganu
hi Simon, On Sun, 16 Jul 2023 at 05:12, Simon Glass wrote: > > Hi Sughosh, > > On Sat, 15 Jul 2023 at 07:46, Sughosh Ganu wrote: > > > > The EFI capsule authentication logic in u-boot expects the public key > > in the form of an EFI Signature Li

[PATCH v4 12/12] sandbox: capsule: Generate capsule related files through binman

2023-07-15 Thread Sughosh Ganu
was used for generating this FIT image. Signed-off-by: Sughosh Ganu --- Changes since V3: * Use blob nodes instead of incbin for including the binaries in FIT image. * Enable generation of capsules with versioning support. arch/sandbox/dts/u-boot.dtsi | 265 ++ test

[PATCH v4 11/12] sandbox: capsule: Add a config file for generating capsules

2023-07-15 Thread Sughosh Ganu
the config file on the sandbox variant. Signed-off-by: Sughosh Ganu --- Changes since V3: * Use fstrings for format specifiers. * Add entries for generating capsules with version parameter. .azure-pipelines.yml | 2 + .gitlab-ci.yml| 2

[PATCH v4 10/12] test: capsule: Remove public key embed logic from capsule update test

2023-07-15 Thread Sughosh Ganu
-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V3: * Rebase on top of current master to work with test configuration for version support in capsule updates. configs/sandbox_defconfig| 1 + configs/sandbox_flattree_defconfig | 1 + test/py/tests

<    1   2   3   4   5   6   7   8   9   10   >