[PATCH v2 2/4] EFI: Do not consider OsIndications variable if CONFIG_EFI_IGNORE_OSINDICATIONS is enabled

2022-06-01 Thread Sughosh Ganu
the EFI_IGNORE_OSINDICATIONS config is enabled. Return an error code on not being able to read the variable only when EFI_IGNORE_OSINDICATIONS is not enabled. Signed-off-by: Sughosh Ganu --- Changes since V1: * Read the OsIndications variable, if present and clear

[PATCH v2 1/4] EFI: Populate descriptor_count value only when image_info_size is not zero

2022-06-01 Thread Sughosh Ganu
the descriptor_count value before it is known that the call to GetImageInfo has been made with the allocated buffer for the image descriptors. Signed-off-by: Sughosh Ganu Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- Changes since V1: None lib/efi_loader/efi_firmware.c | 5 ++--- 1

[PATCH v2 0/4] EFI: Miscellaneous capsule update fixes

2022-06-01 Thread Sughosh Ganu
for both FIT and raw image FMP instances. Sughosh Ganu (4): EFI: Populate descriptor_count value only when image_info_size is not zero EFI: Do not consider OsIndications variable if CONFIG_EFI_IGNORE_OSINDICATIONS is enabled EFI: Update the documentation to reflect the correct value

Re: [PATCH 2/3] EFI: Do not read OsIndications variable if EFI_IGNORE_OSINDICATIONS is enabled

2022-06-01 Thread Sughosh Ganu
hi Heinrich, On Wed, 1 Jun 2022 at 11:33, Heinrich Schuchardt wrote: > > On 5/31/22 09:15, Sughosh Ganu wrote: > > The EFI_IGNORE_OSINDICATIONS config symbol was introduced as a > > mechanism to have capsule updates work even on platforms where the > > Set

Re: efi_firmware_raw_get_image_info and efi_firmware_fit_get_image_info

2022-06-01 Thread Sughosh Ganu
hello Heinrich, On Wed, 1 Jun 2022 at 11:11, Heinrich Schuchardt wrote: > > Hello Sughosh, > > I can't see any difference between efi_firmware_raw_get_image_info() and > efi_firmware_fit_get_image_info(). Shouldn't we replace them by a single > function to avoid maintaining duplicate code? The

[PATCH 3/3] EFI: Update the documentation to reflect the correct value of OsIndications

2022-05-31 Thread Sughosh Ganu
The OsIndications is a 64 bit variable, and the current code expects the value of the variable to be 64 bit. Update the documentation to reflect this fact. Signed-off-by: Sughosh Ganu --- doc/develop/uefi/uefi.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop

[PATCH 2/3] EFI: Do not read OsIndications variable if EFI_IGNORE_OSINDICATIONS is enabled

2022-05-31 Thread Sughosh Ganu
the EFI_IGNORE_OSINDICATIONS config is enabled. Move the check to see if the config symbol is enabled at the beginning of the function. If the config is enabled, return a success code without checking for the existence of the variable. Signed-off-by: Sughosh Ganu --- lib/efi_loader/efi_capsule.c | 5 +++-- 1 file

[PATCH 1/3] EFI: Populate descriptor_count value only when image_info_size is not zero

2022-05-31 Thread Sughosh Ganu
the descriptor_count value before it is known that the call to GetImageInfo has been made with the allocated buffer for the image descriptors. Signed-off-by: Sughosh Ganu --- lib/efi_loader/efi_firmware.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader/efi_firmware.c b

[PATCH 0/3] EFI: Miscellaneous capsule update fixes

2022-05-31 Thread Sughosh Ganu
when the OsIndications variable is not set with EFI_IGNORE_OSINDICATIONS config enabled. The third patch updates the capsule update documentation to highlight the 64 bit value of OsIndications that needs to be set. Sughosh Ganu (3): EFI: Populate descriptor_count value only when image_info_size

Re: [PATCH] RockPi4: Add UEFI capsule update support

2022-05-16 Thread Sughosh Ganu
hi Peter, On Sat, 14 May 2022 at 13:44, Peter Robinson wrote: > > On Fri, May 13, 2022 at 7:50 AM Sughosh Ganu wrote: > > > > Add support for updating the idbloader and u-boot images through the > > UEFI capsule update functionality. Enable the modules req

[PATCH] RockPi4: Add UEFI capsule update support

2022-05-13 Thread Sughosh Ganu
values defined in the platform's config header(ROCKPI_4{B,C}_IDBLOADER_IMAGE_GUID and ROCKPI_4{B,C}_UBOOT_IMAGE_GUID). Signed-off-by: Sughosh Ganu --- arch/arm/mach-rockchip/Kconfig | 1 + board/rockchip/evb_rk3399/evb-rk3399.c | 190 - configs/rock-pi-4

[PATCH v8 8/8] doc: uefi: Update the capsule update related documentation

2022-04-15 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the additional definitions that need to be made per platform for supporting the capsule update feature. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu --- Changes since V7: * Add a comment about using

[PATCH v8 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-15 Thread Sughosh Ganu
the EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID and EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID values superfluous. Remove the --raw and --fit command line options as well. Also modify the mkeficapsule man page to reflect this change. Signed-off-by: Sughosh Ganu --- Changes since V7: None doc/mkeficapsule.1 | 12

[PATCH v8 6/8] FMP: Remove GUIDs for FIT and raw images

2022-04-15 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v8 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-04-15 Thread Sughosh Ganu
variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V7: None configs/sandbox64_defconfig | 1 - configs/sandbox_defconfig | 1

[PATCH v8 4/8] efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-15 Thread Sughosh Ganu
-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu --- Changes since V7: None lib/efi_loader/Kconfig| 2 ++ lib/efi_loader/efi_firmware.c | 5 + 2 files changed, 7 insertions(+) diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index 559b95a599..d50cd2563d 100644

[PATCH v8 3/8] capsule: Put a check for image index before the update

2022-04-15 Thread Sughosh Ganu
through the capsule, since the image_index is used to determine the location of the update on the storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu Reviewed-by: Ilias Apalodimas --- Changes since V7: None lib/efi_loader/efi_capsule.c | 8 +--- 1 file changed, 5

[PATCH v8 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-04-15 Thread Sughosh Ganu
of the EFI_SYSTEM_RESOURCE_ENTRY. Currently, all images are assigned a single GUID value, either an FIT GUID or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu --- Changes since V7

[PATCH v8 1/8] capsule: board: Add information needed for capsule updates

2022-04-15 Thread Sughosh Ganu
. Initialise this structure in the board file, and use the information for the capsule updates. Signed-off-by: Sughosh Ganu --- Changes since V7: None .../imx8mp_rsb3720a1/imx8mp_rsb3720a1.c | 29 +++ .../imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c | 28 +++ board

[PATCH v8 0/8] efi: capsule: Capsule Update fixes and enhancements

2022-04-15 Thread Sughosh Ganu
. * Add the capsule update test case for FIT images on sandbox64 and sandbox_flattree variants. * Add capsule update support on sandbox_flattree variant for enabling FIT capsule update testing as part of the python tests Sughosh Ganu (8): capsule: board: Add information needed for capsule

[PATCH v7 8/8] doc: uefi: Update the capsule update related documentation

2022-04-14 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the additional definitions that need to be made per platform for supporting the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V6: * Add example for the struct efi_fw_image array and struct

[PATCH v7 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-14 Thread Sughosh Ganu
the EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID and EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID values superfluous. Remove the --raw and --fit command line options as well. Also modify the mkeficapsule man page to reflect this change. Signed-off-by: Sughosh Ganu --- Changes since V6: * Reword the commit message to highlight

[PATCH v7 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-04-14 Thread Sughosh Ganu
variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V6: None configs/sandbox64_defconfig | 1 - configs/sandbox_defconfig | 1

[PATCH v7 6/8] FMP: Remove GUIDs for FIT and raw images

2022-04-14 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v7 4/8] efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-14 Thread Sughosh Ganu
-off-by: Sughosh Ganu --- Changes since V6: None lib/efi_loader/Kconfig| 2 ++ lib/efi_loader/efi_firmware.c | 5 + 2 files changed, 7 insertions(+) diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index 559b95a599..d50cd2563d 100644 --- a/lib/efi_loader/Kconfig +++ b

[PATCH v7 3/8] capsule: Put a check for image index before the update

2022-04-14 Thread Sughosh Ganu
through the capsule, since the image_index is used to determine the location of the update on the storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu Reviewed-by: Ilias Apalodimas --- Changes since V6: None lib/efi_loader/efi_capsule.c | 8 +--- 1 file changed, 5

[PATCH v7 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-04-14 Thread Sughosh Ganu
of the EFI_SYSTEM_RESOURCE_ENTRY. Currently, all images are assigned a single GUID value, either an FIT GUID or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu --- Changes since V6: * Use renamed struct efi_fw_image

[PATCH v7 1/8] capsule: board: Add information needed for capsule updates

2022-04-14 Thread Sughosh Ganu
. Initialise this structure in the board file, and use the information for the capsule updates. Signed-off-by: Sughosh Ganu --- Changes since V6: * Renamed struct efi_fw_images as struct efi_fw_image as suggested by Takahiro * Made corresponding change in all board files based on the rename done

[PATCH v7 0/8] efi: capsule: Capsule Update fixes and enhancements

2022-04-14 Thread Sughosh Ganu
for enabling FIT capsule update testing as part of the python tests Sughosh Ganu (8): capsule: board: Add information needed for capsule updates capsule: FMP: Populate the image descriptor array from platform data capsule: Put a check for image index before the update efi: Define

Re: [PATCH v6 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-04-13 Thread Sughosh Ganu
On Wed, 13 Apr 2022 at 12:05, AKASHI Takahiro wrote: > > On Tue, Apr 12, 2022 at 06:34:44PM +0530, Sughosh Ganu wrote: > > The current UEFI capsule updation code uses two GUID values, one for > > FIT images, and one for raw images across platforms. This logic is > > be

Re: [PATCH v6 8/8] doc: uefi: Update the capsule update related documentation

2022-04-13 Thread Sughosh Ganu
On Wed, 13 Apr 2022 at 11:48, AKASHI Takahiro wrote: > > On Tue, Apr 12, 2022 at 06:34:47PM +0530, Sughosh Ganu wrote: > > Update the capsule update functionality related documentation to > > refect the additional definitions that need to be made per platform > > for suppo

Re: [PATCH v6 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-13 Thread Sughosh Ganu
On Wed, 13 Apr 2022 at 11:53, AKASHI Takahiro wrote: > > On Wed, Apr 13, 2022 at 11:44:18AM +0530, Sughosh Ganu wrote: > > On Wed, 13 Apr 2022 at 11:35, AKASHI Takahiro > > wrote: > > > > > > On Tue, Apr 12, 2022 at 06:34:46PM +0530, Sughosh Ganu wrote: > &

Re: [PATCH v6 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-13 Thread Sughosh Ganu
On Wed, 13 Apr 2022 at 11:35, AKASHI Takahiro wrote: > > On Tue, Apr 12, 2022 at 06:34:46PM +0530, Sughosh Ganu wrote: > > While building a capsule, the GUID value of that specific image is to > > be passed through the --guid command option to the mkeficapsule >

[PATCH v6 8/8] doc: uefi: Update the capsule update related documentation

2022-04-12 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the additional definitions that need to be made per platform for supporting the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V5: None doc/develop/uefi/uefi.rst | 51

[PATCH v6 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-12 Thread Sughosh Ganu
options as well. Signed-off-by: Sughosh Ganu Acked-by: Ilias Apalodimas --- Changes since V5: None tools/eficapsule.h | 8 tools/mkeficapsule.c | 26 +- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a/tools/eficapsule.h b/tools/eficapsule.h

[PATCH v6 6/8] FMP: Remove GUIDs for FIT and raw images

2022-04-12 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v6 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-04-12 Thread Sughosh Ganu
variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V5: * Restart the platform before starting the tests. This is done to clear out any stale state from a previously run

[PATCH v6 4/8] efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-12 Thread Sughosh Ganu
-off-by: Sughosh Ganu --- Changes since V5: * Simplify the set_dfu_alt_info function definition to set the variable directly from dfu_string, as suggested by Heinrich. lib/efi_loader/Kconfig| 2 ++ lib/efi_loader/efi_firmware.c | 5 + 2 files changed, 7 insertions(+) diff --git

[PATCH v6 3/8] capsule: Put a check for image index before the update

2022-04-12 Thread Sughosh Ganu
through the capsule, since the image_index is used to determine the location of the update on the storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu Reviewed-by: Ilias Apalodimas --- Changes since V5: None lib/efi_loader/efi_capsule.c | 8 +--- 1 file changed, 5

[PATCH v6 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-04-12 Thread Sughosh Ganu
of the EFI_SYSTEM_RESOURCE_ENTRY. Currently, all images are assigned a single GUID value, either an FIT GUID or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu --- Changes since V5: None lib/efi_loader

[PATCH v6 1/8] capsule: board: Add information needed for capsule updates

2022-04-12 Thread Sughosh Ganu
. Initialise this structure in the board file, and use the information for the capsule updates. Signed-off-by: Sughosh Ganu --- Changes since V5: * Create a separate entry in fw_images array per config for boards with multiple configs as suggested by Heinrich. * Removed CONFIG_IS_ENABLED

[PATCH v6 0/8] efi: capsule: Capsule Update fixes and enhancements

2022-04-12 Thread Sughosh Ganu
update support on sandbox_flattree variant for enabling FIT capsule update testing as part of the python tests Sughosh Ganu (8): capsule: board: Add information needed for capsule updates capsule: FMP: Populate the image descriptor array from platform data capsule: Put a check for image index

Re: [PATCH v5 4/8] efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-11 Thread Sughosh Ganu
On Sat, 2 Apr 2022 at 15:00, Heinrich Schuchardt wrote: > > On 4/1/22 21:17, Sughosh Ganu wrote: > > Currently, there are a bunch of boards which enable the UEFI capsule > > update feature. The actual update of the firmware images is done > > through the dfu framework whi

Re: [PATCH v5 1/8] capsule: board: Add information needed for capsule updates

2022-04-11 Thread Sughosh Ganu
On Sat, 2 Apr 2022 at 14:34, Heinrich Schuchardt wrote: > > On 4/1/22 21:17, Sughosh Ganu wrote: > > Add a structure which defines the information that is needed for > > executing capsule updates on a platform. Some information in the > > structure is used for making

[PATCH v5 6/8] FMP: Remove GUIDs for FIT and raw images

2022-04-01 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v5 8/8] doc: uefi: Update the capsule update related documentation

2022-04-01 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the additional definitions that need to be made per platform for supporting the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V4: * Change the description of the platform data based on the changes

[PATCH v5 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-04-01 Thread Sughosh Ganu
options as well. Signed-off-by: Sughosh Ganu Acked-by: Ilias Apalodimas --- Changes since V4: None tools/eficapsule.h | 8 tools/mkeficapsule.c | 26 +- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a/tools/eficapsule.h b/tools/eficapsule.h

[PATCH v5 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-04-01 Thread Sughosh Ganu
for testing the capsule update code. Install the FMP instance for the FIT images on the sandbox64 and sandbox_flattree variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V4

[PATCH v5 3/8] capsule: Put a check for image index before the update

2022-04-01 Thread Sughosh Ganu
through the capsule, since the image_index is used to determine the location of the update on the storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu Reviewed-by: Ilias Apalodimas --- Changes since V4: None lib/efi_loader/efi_capsule.c | 8 +--- 1 file changed, 5

[PATCH v5 4/8] efi: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-01 Thread Sughosh Ganu
-off-by: Sughosh Ganu --- Changes since V4: * Define a weak function set_dfu_alt_info for setting the variable in a non board specific file as suggested by Ilias * Drop the definitions of set_dfu_alt_info that were being added in the board files lib/efi_loader/Kconfig| 2 ++ lib

[PATCH v5 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-04-01 Thread Sughosh Ganu
of the EFI_SYSTEM_RESOURCE_ENTRY. Currently, all images are assigned a single GUID value, either an FIT GUID or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu --- Changes since V4: * Drop the image_count variable

[PATCH v5 1/8] capsule: board: Add information needed for capsule updates

2022-04-01 Thread Sughosh Ganu
the information for the capsule updates. Signed-off-by: Sughosh Ganu --- Changes since V1: * Define a structure efi_capsule_update_info which includes the string for populating dfu_alt_info * Initialise the string for dfu_alt_info in the board file .../imx8mp_rsb3720a1/imx8mp_rsb3720a1.c

[PATCH v5 0/8] efi: capsule: Capsule Update fixes and enhancements

2022-04-01 Thread Sughosh Ganu
of the python tests Sughosh Ganu (8): capsule: board: Add information needed for capsule updates capsule: FMP: Populate the image descriptor array from platform data capsule: Put a check for image index before the update efi: Define set_dfu_alt_info() for boards with UEFI capsule update

Re: [PATCH v4 4/8] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-04-01 Thread Sughosh Ganu
hi Ilias, On Fri, 1 Apr 2022 at 01:05, Ilias Apalodimas wrote: > > Hi Sughosh, > > Some nots below > > On Thu, Mar 31, 2022 at 06:57:46PM +0530, Sughosh Ganu wrote: > > Currently, there are a bunch of boards which enable the UEFI capsule > > update feature. The

Re: [PATCH v4 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-03-31 Thread Sughosh Ganu
hi Ilias, On Thu, 31 Mar 2022 at 20:38, Ilias Apalodimas wrote: > > Hi Sughosh, > > On Thu, Mar 31, 2022 at 06:57:44PM +0530, Sughosh Ganu wrote: > > Currently, the image descriptor array that has been passed to the > > GetImageInfo function of the Firmware Manag

[PATCH v4 8/8] doc: uefi: Update the capsule update related documentation

2022-03-31 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the additional definitions that need to be made per platform for supporting the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V3: * Rephrase the commit message to indicate that the doc changes

[PATCH v4 5/8] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-03-31 Thread Sughosh Ganu
for testing the capsule update code. Install the FMP instance for the FIT images on the sandbox64 and sandbox_flattree variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V3

[PATCH v4 7/8] mkeficapsule: Remove raw and FIT GUID types

2022-03-31 Thread Sughosh Ganu
options as well. Signed-off-by: Sughosh Ganu --- Changes since V3: None tools/eficapsule.h | 8 tools/mkeficapsule.c | 26 +- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a/tools/eficapsule.h b/tools/eficapsule.h index 69c9c58c2f..d63b831443

[PATCH v4 4/8] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-03-31 Thread Sughosh Ganu
-by: Sughosh Ganu --- Changes since V3: * Do not remove the existing dfu_alt_info definitions made by platforms in the config files, as discussed with Masami. * Squash the selection of the SET_DFU_ALT_INFO config symbol for capsule update feature as part of this patch. .../imx8mp_rsb3720a1

[PATCH v4 6/8] FMP: Remove GUIDs for FIT and raw images

2022-03-31 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v4 1/8] capsule: Add Image GUIDs and image index for platforms using capsule updates

2022-03-31 Thread Sughosh Ganu
-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu Acked-by: Michal Simek --- Changes since V3: None .../imx8mp_rsb3720a1/imx8mp_rsb3720a1.c | 20 + .../imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c | 19 + board/emulation/qemu-arm/qemu-arm.c | 20

[PATCH v4 2/8] capsule: FMP: Populate the image descriptor array from platform data

2022-03-31 Thread Sughosh Ganu
or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu --- Changes since V3: None include/efi_loader.h | 3 ++ lib/efi_loader/efi_firmware.c | 91

[PATCH v4 3/8] capsule: Put a check for image index before the update

2022-03-31 Thread Sughosh Ganu
through the capsule, since the image_index is used to determine the location of the update on the storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Masami Hiramatsu --- Changes since V3: None lib/efi_loader/efi_capsule.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

[PATCH v4 0/8] efi: capsule: Capsule Update fixes and enhancements

2022-03-31 Thread Sughosh Ganu
update testing as part of the python tests Sughosh Ganu (8): capsule: Add Image GUIDs and image index for platforms using capsule updates capsule: FMP: Populate the image descriptor array from platform data capsule: Put a check for image index before the update board: Define set_dfu_alt_info

Re: [PATCH v3 5/9] capsule: kconfig: Select SET_DFU_ALT_INFO config symbol for capsule update

2022-03-31 Thread Sughosh Ganu
hi Masami, On Thu, 31 Mar 2022 at 13:11, Sughosh Ganu wrote: > > hi Masami, > > On Thu, 31 Mar 2022 at 08:18, Masami Hiramatsu > wrote: > > > > Hi, > > > > Even with this patch, if the platform configuration doesn't select > > EFI_CAPSULE

Re: [PATCH v3 5/9] capsule: kconfig: Select SET_DFU_ALT_INFO config symbol for capsule update

2022-03-31 Thread Sughosh Ganu
> > 2022年3月30日(水) 23:51 Sughosh Ganu : > > > > The capsule update code uses the dfu_alt_info variable for the actual > > update of the firmware component. The dfu_alt_info variable gives > > information needed to perform the update, like the device on which the > >

Re: [PATCH v3 4/9] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-03-31 Thread Sughosh Ganu
CONFIG_SET_DFU_ALT_INFO in the board's defconfig file, I will make that change in my next version. Thanks. -sughosh > > Thank you, > > 2022年3月30日(水) 23:51 Sughosh Ganu : > > > > Currently, there are a bunch of boards which enable the UEFI capsule > > update feature. The ac

[PATCH v3 9/9] doc: uefi: Update the capsule update related documentation

2022-03-30 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the fact that a unique image GUID is to be used per image that forms part of the capsule file. Signed-off-by: Sughosh Ganu --- Changes since V2: * Add a description for adding image index value and definition

[PATCH v3 8/9] mkeficapsule: Remove raw and FIT GUID types

2022-03-30 Thread Sughosh Ganu
options as well. Signed-off-by: Sughosh Ganu --- Changes since V2: None tools/eficapsule.h | 8 tools/mkeficapsule.c | 26 +- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a/tools/eficapsule.h b/tools/eficapsule.h index 69c9c58c2f..d63b831443

[PATCH v3 6/9] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-03-30 Thread Sughosh Ganu
for testing the capsule update code. Install the FMP instance for the FIT images on the sandbox64 and sandbox_flattree variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V2

[PATCH v3 7/9] FMP: Remove GUIDs for FIT and raw images

2022-03-30 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v3 4/9] board: Define set_dfu_alt_info() for boards with UEFI capsule update enabled

2022-03-30 Thread Sughosh Ganu
file, and use the function for populating the variable. With the function defined, the dfu framework populates the dfu_alt_info variable through the board file, instead of fetching the variable from the environment, thus making the update more robust. Signed-off-by: Sughosh Ganu --- Changes since

[PATCH v3 5/9] capsule: kconfig: Select SET_DFU_ALT_INFO config symbol for capsule update

2022-03-30 Thread Sughosh Ganu
update functionality is enabled. Signed-off-by: Sughosh Ganu --- Changes since V2: New Patch lib/efi_loader/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index e5e35fe51f..09fb8cbe75 100644 --- a/lib/efi_loader/Kconfig +++ b/lib

[PATCH v3 3/9] capsule: Put a check for image index before the update

2022-03-30 Thread Sughosh Ganu
through the capsule, since the image_index is used to determine the location of the update on the storage device. Signed-off-by: Sughosh Ganu --- Changes since V2: New patch lib/efi_loader/efi_capsule.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/efi_loader

[PATCH v3 1/9] capsule: Add Image GUIDs and image index for platforms using capsule updates

2022-03-30 Thread Sughosh Ganu
-by: Sughosh Ganu --- Changes since V2: * Add a new member image_index to the struct efi_fw_images to allow the platforms to define the values for images. * Address review comments from Michal Simek for the xilinx boards. * Fix double inclusion of efi_loader.h as was pointed out by Heiko

[PATCH v3 2/9] capsule: FMP: Populate the image descriptor array from platform data

2022-03-30 Thread Sughosh Ganu
or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu --- Changes since V2: * Use the image index values defined in the platform's fw_images array for the image descriptors include/efi_loader.h

[PATCH v3 0/9] efi: capsule: Capsule Update fixes and enhancements

2022-03-30 Thread Sughosh Ganu
removes the now unused FIT and raw image GUID values from the FMP module. The eighth patch removes the --raw and --fit command line parameters in the mkeficapsule utility. The ninth patch makes corresponding changes in the capsule update related documentation. Sughosh Ganu (9): capsule: Add

Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-27 Thread Sughosh Ganu
hi Masami, On Sat, 26 Mar 2022 at 16:17, Masami Hiramatsu wrote: > > Hi Sughosh, > > 2022年3月25日(金) 18:59 Sughosh Ganu : > > > > hi Masami, > > > > On Fri, 25 Mar 2022 at 10:58, Masami Hiramatsu > > wrote: > > > > > > Hi Sughosh, &

Re: [PATCH v2 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-26 Thread Sughosh Ganu
hi Heiko, On Sat, 26 Mar 2022 at 12:36, Heiko Thiery wrote: > > Hi > > Sughosh Ganu schrieb am Sa., 26. März 2022, 07:00: >> >> Currently, all platforms that enable capsule updates do so using >> either EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID or >> EF

[PATCH v2 6/6] mkeficapsule: Remove raw and FIT GUID types

2022-03-26 Thread Sughosh Ganu
options as well. Signed-off-by: Sughosh Ganu --- Changes since V1: None tools/eficapsule.h | 8 tools/mkeficapsule.c | 26 +- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a/tools/eficapsule.h b/tools/eficapsule.h index 69c9c58c2f..d63b831443

[PATCH v2 5/6] FMP: Remove GUIDs for FIT and raw images

2022-03-26 Thread Sughosh Ganu
The capsule update code has been modified for getting the image GUID values from the platform code. With this, each image now has a unique GUID value. With this change, there is no longer a need for defining GUIDs for FIT and raw images. Remove these GUID values. Signed-off-by: Sughosh Ganu

[PATCH v2 3/6] test: capsule: Modify the capsule tests to use GUID values for sandbox

2022-03-26 Thread Sughosh Ganu
for testing the capsule update code. Install the FMP instance for the FIT images on the sandbox64 and sandbox_flattree variant for testing capsule update for FIT images. This is being done by splitting the capsule update script for FIT and raw images. Signed-off-by: Sughosh Ganu --- Changes since V1

[PATCH v2 4/6] doc: uefi: Update the capsule update related documentation

2022-03-26 Thread Sughosh Ganu
Update the capsule update functionality related documentation to refect the fact that a unique image GUID is to be used per image that forms part of the capsule file. Signed-off-by: Sughosh Ganu --- Changes since V1: None doc/develop/uefi/uefi.rst | 10 -- 1 file changed, 8 insertions

[PATCH v2 2/6] capsule: FMP: Populate the image descriptor array from platform data

2022-03-26 Thread Sughosh Ganu
or a raw image GUID. This is fixed by obtaining the GUID values from the efi_fw_images array defined per platform. Signed-off-by: Sughosh Ganu --- Changes since V1: None include/efi_loader.h | 3 ++ lib/efi_loader/efi_firmware.c | 91 +++ 2 files changed

[PATCH v2 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-26 Thread Sughosh Ganu
descriptor array. Signed-off-by: Sughosh Ganu --- Changes since V1: * Make changes for the xilinx boards as suggested by Michal Simek. * Add a GUID for the sandbox FIT image .../imx8mp_rsb3720a1/imx8mp_rsb3720a1.c | 19 ++ .../imx8mm-cl-iot-gate/imx8mm-cl-iot-gate.c | 18

[PATCH v2 0/6] efi: capsule: Image GUID usage cleanup

2022-03-26 Thread Sughosh Ganu
corresponding changes in the capsule update related documentation. The fifth patch of the series removes the now unused FIT and raw image GUID values from the FMP module. The sixth patch of the series removes the --raw and --fit command line parameters in the mkeficapsule utility. Sughosh Ganu (6

Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-25 Thread Sughosh Ganu
Hiramatsu : > > > > Hi Sughosh, > > > > 2022年3月24日(木) 23:40 Sughosh Ganu : > > > > > > hi Masami, > > > > > > On Thu, 24 Mar 2022 at 19:14, Masami Hiramatsu > > > wrote: > > > > > > > > Hi Sughosh, > > &g

Re: [RFC PATCH 0/6] efi: capsule: Image GUID usage cleanup

2022-03-25 Thread Sughosh Ganu
hi Takahiro, On Fri, 25 Mar 2022 at 10:23, AKASHI Takahiro wrote: > > Sughosh, > > On Thu, Mar 24, 2022 at 06:08:55PM +0530, Sughosh Ganu wrote: > > > > This series is cleaning up the usage of the image GUIDs that are used > > in capsule update and the

Re: [PATCH v5 5/9] qemu: arm: Remove platform specific function to get RNG device

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Sun, 13 Mar 2022 at 20:18, Sughosh Ganu wrote: > > The Qemu platform has a function defined to get the random number > generator(RNG) device. However, the RNG device can be obtained simply > by searching for a device belonging to the RNG uclass. Remove the > super

Re: [PATCH v3 8/8] test: rng: Add a UT testcase for the rng command

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Fri, 4 Mar 2022 at 19:05, Sughosh Ganu wrote: > > The 'rng' command dumps a number of random bytes on the console. Add a > set of tests for the 'rng' command. The test function performs basic > sanity testing of the command. > > Since a unit test is being add

Re: [PATCH v5 9/9] test: rng: Add a UT testcase for the rng command

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Sun, 13 Mar 2022 at 20:19, Sughosh Ganu wrote: > > The 'rng' command dumps a number of random bytes on the console. Add a > set of tests for the 'rng' command. The test function performs basic > sanity testing of the command. > > Since a unit test is being add

Re: [PATCH v5 8/9] doc: rng: Add documentation for the rng command

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Sun, 13 Mar 2022 at 20:19, Sughosh Ganu wrote: > > Add a usage document for the 'rng' u-boot command. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Ilias Apalodimas > Reviewed-by: Simon Glass > --- > > Changes since V4: > > * Reflect the fa

Re: [PATCH v5 7/9] cmd: rng: Use a statically allocated array for random bytes

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Sun, 13 Mar 2022 at 20:19, Sughosh Ganu wrote: > > Use a statically allocated buffer on stack instead of using malloc for > reading the random bytes. Using a local array is faster than > allocating heap memory on every initiation of the command. > > Signed-of

Re: [PATCH v5 6/9] cmd: rng: Add support for selecting RNG device

2022-03-24 Thread Sughosh Ganu
hi Heinrich, On Mon, 14 Mar 2022 at 03:53, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 13 Mar 2022 at 08:49, Sughosh Ganu wrote: > > > > The 'rng' u-boot command is used for printing a select number of > > random bytes on the console. Currently, the RNG device f

Re: [RFC PATCH 6/6] mkeficapsule: Remove raw and FIT GUID types

2022-03-24 Thread Sughosh Ganu
On Thu, 24 Mar 2022 at 20:40, Michal Simek wrote: > > > > On 3/24/22 15:51, Sughosh Ganu wrote: > > On Thu, 24 Mar 2022 at 19:55, Michal Simek wrote: > >> > >> > >> > >> On 3/24/22 13:39, Sughosh Ganu wrote: > >>&g

Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-24 Thread Sughosh Ganu
On Thu, 24 Mar 2022 at 20:21, Michal Simek wrote: > > > > On 3/24/22 15:44, Sughosh Ganu wrote: > > On Thu, 24 Mar 2022 at 19:55, Michal Simek wrote: > >> > >> > >> > >> On 3/24/22 13:38, Sughosh Ganu wrote: > >>> Currently,

Re: [RFC PATCH 6/6] mkeficapsule: Remove raw and FIT GUID types

2022-03-24 Thread Sughosh Ganu
On Thu, 24 Mar 2022 at 19:55, Michal Simek wrote: > > > > On 3/24/22 13:39, Sughosh Ganu wrote: > > While building a capsule, the GUID value of that specific image is to > > be passed through the --guid command option to the mkeficapsul

Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-24 Thread Sughosh Ganu
On Thu, 24 Mar 2022 at 19:55, Michal Simek wrote: > > > > On 3/24/22 13:38, Sughosh Ganu wrote: > > Currently, all platforms that enable capsule updates do so using > > either EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID or > > EFI_FIRMWARE_IMAGE_TYPE_UBOOT_FIT_GUID.

Re: [RFC PATCH 1/6] capsule: Add Image GUIDs for platforms using capsule updates

2022-03-24 Thread Sughosh Ganu
hi Masami, On Thu, 24 Mar 2022 at 19:14, Masami Hiramatsu wrote: > > Hi Sughosh, > > 2022年3月24日(木) 21:39 Sughosh Ganu : > > > > Currently, all platforms that enable capsule updates do so using > > either EFI_FIRMWARE_IMAGE_TYPE_UBOOT_RAW_GUID or > > EF

[RFC PATCH 6/6] mkeficapsule: Remove raw and FIT GUID types

2022-03-24 Thread Sughosh Ganu
options as well. Signed-off-by: Sughosh Ganu --- tools/eficapsule.h | 8 tools/mkeficapsule.c | 26 +- 2 files changed, 1 insertion(+), 33 deletions(-) diff --git a/tools/eficapsule.h b/tools/eficapsule.h index 69c9c58c2f..d63b831443 100644 --- a/tools

<    5   6   7   8   9   10   11   12   13   14   >