Re: [PATCH v4 23/39] mach-snapdragon: carve out no-map regions

2024-02-20 Thread Sumit Garg
gions by address */ > + count = i; > + qsort(res, count, sizeof(struct fdt_resource), fdt_cmp_res); > + > + /* Now set the right attributes for them. Often a lot of the regions > are tightly packed together > +* so we can optimise the number of calls t

Re: [PATCH v4 22/39] mach-snapdragon: generate fdtfile automatically

2024-02-20 Thread Sumit Garg
+++ > 1 file changed, 101 insertions(+) > Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/mach-snapdragon/board.c > b/arch/arm/mach-snapdragon/board.c > index f445bed3af00..5a859aabd5c4 100644 > --- a/arch/arm/mach-snapdragon/board.

[PATCH 7/7] verdin-imx8mp_defconfig: Enable PCIe/NVMe support

2024-02-20 Thread Sumit Garg
Also, enable reset driver which is a prerequisite for PCIe support. Signed-off-by: Sumit Garg --- configs/verdin-imx8mp_defconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/configs/verdin-imx8mp_defconfig b/configs/verdin-imx8mp_defconfig index 22b8a334dfa..d8bd644322b 100644

[PATCH 1/7] clk: imx8mp: Add support for PCIe clocks

2024-02-20 Thread Sumit Garg
Pre-requisite to enable PCIe support on iMX8MP SoC. Signed-off-by: Sumit Garg --- drivers/clk/imx/clk-imx8mp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c index a21a3ce34bb..7dfc829df2c 100644 --- a/drivers/clk/imx/clk

[PATCH 5/7] phy: phy-imx8m-pcie: Add support for i.MX8M{M/P} PCIe PHY

2024-02-20 Thread Sumit Garg
Add initial support for i.MX8M{M/P} PCIe PHY. On i.MX8M{M/P} SoCs PCIe PHY initialization moved to this standalone PHY driver. Signed-off-by: Sumit Garg --- drivers/phy/Kconfig | 9 ++ drivers/phy/Makefile | 1 + drivers/phy/phy-imx8m-pcie.c | 246

[PATCH 2/7] reset: imx: Add support for i.MX8MP reset controller

2024-02-20 Thread Sumit Garg
Pre-requisite to enable PCIe support on iMX8MP SoC. Signed-off-by: Sumit Garg --- drivers/reset/reset-imx7.c | 114 + 1 file changed, 114 insertions(+) diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c index eaef2cc2cdf..c1de84dea8b 100644

[PATCH 0/7] imx8mp: Enable PCIe/NVMe support

2024-02-20 Thread Sumit Garg
endor: 0x126f Rev: T0828A0 Prod: AA000720 Type: Hard Disk Capacity: 122104.3 MB = 119.2 GB (250069680 x 512) Verdin iMX8MP # Verdin iMX8MP # load nvme 0 $loadaddr Sumit Garg (7): clk: imx8mp: Add support for PCIe clocks reset: imx: Add support for i.MX8MP

[PATCH 6/7] pci: Add DW PCIe controller support for iMX8MP SoC

2024-02-20 Thread Sumit Garg
IG_PCIE_DW_IMX8) += pcie_dw_imx8.o diff --git a/drivers/pci/pcie_dw_imx8.c b/drivers/pci/pcie_dw_imx8.c new file mode 100644 index 000..b9921644765 --- /dev/null +++ b/drivers/pci/pcie_dw_imx8.c @@ -0,0 +1,348 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2024 Linaro Ltd. + * + * Aut

[PATCH 3/7] imx8mp: power-domain: Add PCIe support

2024-02-20 Thread Sumit Garg
Pre-requisite to enable PCIe support on iMX8MP SoC. Signed-off-by: Sumit Garg --- drivers/power/domain/imx8mp-hsiomix.c | 50 +-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/drivers/power/domain/imx8mp-hsiomix.c b/drivers/power/domain/imx8mp-hsiomix.c

[PATCH 4/7] imx8mp: power-domain: Expose high performance PLL clock

2024-02-20 Thread Sumit Garg
PCIe PHY can use it when there is no external refclock provided. Signed-off-by: Sumit Garg --- drivers/power/domain/imx8mp-hsiomix.c | 79 +-- 1 file changed, 73 insertions(+), 6 deletions(-) diff --git a/drivers/power/domain/imx8mp-hsiomix.c b/drivers/power/domain

Re: [PATCH v4 21/39] mach-snapdragon: dynamic load addresses

2024-02-20 Thread Sumit Garg
/dragonboard410c/dragonboard410c.c | 2 +- > 3 files changed, 36 insertions(+), 1 deletion(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 672577d0ddcc..0dba77f86b49 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfi

Re: [PATCH v4 20/39] mach-snapdragon: generalise board support

2024-02-20 Thread Sumit Garg
| 67 +++ > configs/qcs404evb_defconfig | 5 +- > configs/starqltechn_defconfig| 41 - > include/configs/dragonboard845c.h| 20 --- > include/configs/qcom.h | 21 +++ > include/configs/

Re: [PATCH v4 19/39] board: dragonboard820c: use LINUX_KERNEL_IMAGE_HEADER

2024-02-20 Thread Sumit Garg
4 files changed, 1 insertion(+), 145 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/mach-snapdragon/Kconfig > b/arch/arm/mach-snapdragon/Kconfig > index ad6671081910..f897c393464f 100644 > --- a/arch/arm/mach-snapdragon/Kconfig > +++ b/arch/arm/mach-sna

Re: [PATCH v4 18/39] board: dragonboard410c: import board code from mach-snapdragon

2024-02-20 Thread Sumit Garg
| 2 +- > board/qualcomm/dragonboard410c/dragonboard410c.c | 48 +++- > 7 files changed, 45 insertions(+), 186 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/mach-snapdragon/Makefile > b/arch/arm/mach-snapdragon/Makefile > index 3a3a29

Re: [PATCH v4 17/39] board: dragonboard410c: upstream DT compat

2024-02-20 Thread Sumit Garg
| 22 ++- > include/dt-bindings/clock/qcom,gcc-msm8916.h | 179 > +++ > 8 files changed, 246 insertions(+), 96 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/dts/dragonboard410c.dts > b/arch/arm/d

Re: [PATCH v4 16/39] board: dragonboard410c: add chainloaded config fragment

2024-02-20 Thread Sumit Garg
t; --- > board/qualcomm/dragonboard410c/configs/chainloaded.config | 7 +++ > 1 file changed, 7 insertions(+) > Reviewed-by: Sumit Garg -Sumit > diff --git a/board/qualcomm/dragonboard410c/configs/chainloaded.config > b/board/qualcomm/dragonboard410c/configs/chainloade

Re: [PATCH v4 14/39] pinctrl: qcom: fix DT compatibility

2024-02-20 Thread Sumit Garg
8016.c | 26 +++ > drivers/pinctrl/qcom/pinctrl-apq8096.c | 16 +- > drivers/pinctrl/qcom/pinctrl-qcs404.c | 58 > -- > 3 files changed, 69 insertions(+), 31 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/

Re: [PATCH v4 13/39] pinctrl: qcom: stub support for special GPIOs

2024-02-20 Thread Sumit Garg
| 12 ++++ > 3 files changed, 34 insertions(+) > Reviewed-by: Sumit Garg -Sumit > diff --git a/arch/arm/mach-snapdragon/include/mach/gpio.h > b/arch/arm/mach-snapdragon/include/mach/gpio.h > index 8dac62f870b9..c373f5a4cf3d 100644 > --- a/arch/arm/mach-snapdragon/i

Re: [PATCH v4 15/39] pinctrl: qcom: apq8016: init pre-reloaction

2024-02-19 Thread Sumit Garg
e do this early enough. > > This is required to prevent the first few lines of UART log from being > dropped. > > Reported-by: Sumit Garg > Signed-off-by: Caleb Connolly > --- > drivers/pinctrl/qcom/pinctrl-apq8016.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by

Re: [PATCH v4 12/39] sandbox: dts: fix qcom pmic gpio

2024-02-19 Thread Sumit Garg
On Fri, 16 Feb 2024 at 02:22, Caleb Connolly wrote: > > Adjust the DT to match upstream bindings. > > Signed-off-by: Caleb Connolly > --- > arch/sandbox/dts/sandbox.dtsi | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > Reviewed-by: Sumit Garg -Su

Re: [PATCH v4 11/39] gpio: qcom_pmic: add pinctrl driver

2024-02-19 Thread Sumit Garg
> --- > drivers/gpio/qcom_pmic_gpio.c | 257 > +- > 1 file changed, 176 insertions(+), 81 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/gpio/qcom_pmic_gpio.c b/drivers/gpio/qcom_pmic_gpio.c > index 198cd84bc31e..

Re: [PATCH v4 08/39] serial: msm: fix clock handling and pinctrl

2024-02-19 Thread Sumit Garg
ints confusing > errors. > > Signed-off-by: Caleb Connolly > --- > arch/arm/dts/dragonboard410c.dts | 3 ++- > arch/arm/dts/dragonboard820c.dts | 3 ++- > drivers/serial/serial_msm.c | 25 + > 3 files changed, 9 insertions(+), 22 deletions(-

Re: [PATCH v4 07/39] serial: msm: add debug UART

2024-02-19 Thread Sumit Garg
On Fri, 16 Feb 2024 at 02:22, Caleb Connolly wrote: > > Introduce support for early debugging. This relies on the previous stage > bootloader to initialise the UART clocks, when running with U-Boot as > the primary bootloader this feature doesn't work. It will require a way > to configure the cloc

Re: [PATCH v4 06/39] clock/qcom: qcs404: fix clk_set_rate

2024-02-19 Thread Sumit Garg
e changed, 13 insertions(+), 12 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/clk/qcom/clock-qcs404.c b/drivers/clk/qcom/clock-qcs404.c > index f5b352803927..958312b88842 100644 > --- a/drivers/clk/qcom/clock-qcs404.c > +++ b/drivers/clk/qcom/clock-qcs404

Re: [PATCH v4 10/39] gpio: qcom_pmic: add a quirk to skip GPIO configuration

2024-02-19 Thread Sumit Garg
On Fri, 16 Feb 2024 at 02:22, Caleb Connolly wrote: > > Some platforms hard reset when attempting to configure PMIC GPIOs. Add > support for quirks specified in match data with a single quirk to skip > this configuration. We rely on the GPIO already be configured correctly, > which is always the c

Re: [PATCH v4 09/39] gpio: qcom_pmic: 1-based GPIOs

2024-02-19 Thread Sumit Garg
+++ > 1 file changed, 22 insertions(+) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/gpio/qcom_pmic_gpio.c b/drivers/gpio/qcom_pmic_gpio.c > index 6167c8411678..2a4fef8d28cb 100644 > --- a/drivers/gpio/qcom_pmic_gpio.c > +++ b/drivers/gpio/qcom_pmic

Re: [PATCH v4 05/39] clk/qcom: use upstream compatible properties

2024-02-19 Thread Sumit Garg
ompletely so I am not too worried about it. Reviewed-by: Sumit Garg -Sumit > > Reviewed-by: Neil Armstrong > Signed-off-by: Caleb Connolly > --- > arch/arm/dts/dragonboard410c.dts | 2 +- > drivers/clk/qcom/clock-apq8016.c | 2 +- > drivers/clk/qcom/clock-apq8096.c | 2

Re: [PATCH v4 04/39] dt-bindings: drop msm_sdhci binding

2024-02-19 Thread Sumit Garg
-- > 1 file changed, 25 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/doc/device-tree-bindings/mmc/msm_sdhci.txt > b/doc/device-tree-bindings/mmc/msm_sdhci.txt > deleted file mode 100644 > index 08a290c66931.. > --- a/doc/device-tr

Re: [PATCH v4 03/39] mmc: msm_sdhci: use modern clock handling

2024-02-19 Thread Sumit Garg
-- > 1 file changed, 47 insertions(+), 22 deletions(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/mmc/msm_sdhci.c b/drivers/mmc/msm_sdhci.c > index fe1e754bfde0..b63538fce20c 100644 > --- a/drivers/mmc/msm_sdhci.c > +++ b/drivers/mmc/msm_sdhci.

Re: [PATCH v4 01/39] arm: init: export prev_bl_fdt_addr

2024-02-19 Thread Sumit Garg
from the FDT, let the board > do their own validation instead. > > Reviewed-by: Tom Rini > Signed-off-by: Caleb Connolly > --- > arch/arm/lib/save_prev_bl_data.c | 5 + > include/init.h | 11 +++ > 2 files changed, 16 insertions(

Re: [PATCH v5 08/11] doc: devicetree: Updates for devicetree-rebasing subtree

2024-02-19 Thread Sumit Garg
On Fri, 16 Feb 2024 at 16:17, Paul Barker wrote: > > On 14/02/2024 13:32, Sumit Garg wrote: > > On Wed, 14 Feb 2024 at 03:01, Paul Barker > > wrote: > >> On 02/02/2024 13:05, Sumit Garg wrote: > >>> +Dependencies > >>> + > &

Re: [PATCH v4 00/39] Qualcomm generic board support

2024-02-19 Thread Sumit Garg
work to import dt-rebasing has been merged, we will drop > the imported DT and bindings again. > > --- > I have tested this series on the Dragonboard410c, Dragonboard820c, and > Dragonboard845c. I unfortunately don't have access to a QCS404 EVB board > to test. Thanks for inco

[PATCH] qcom_defconfig: Enable ethernet and I2C support

2024-02-19 Thread Sumit Garg
. So enable corresponding support as well. Signed-off-by: Sumit Garg --- This patch based upon Caleb's series [1]. [1] https://lore.kernel.org/all/20240215-b4-qcom-common-target-v4-0-ed06355c6...@linaro.org/ configs/qcom_defconfig | 24 +++- 1 file changed, 23 inser

Re: [PATCH v5 08/11] doc: devicetree: Updates for devicetree-rebasing subtree

2024-02-14 Thread Sumit Garg
+ Ian Campbell (Maintainer for devicetree-rebasing tree) Hi Paul, Thanks for your nice documentation review. On Wed, 14 Feb 2024 at 03:01, Paul Barker wrote: > > On 02/02/2024 13:05, Sumit Garg wrote: > > Encourage SoC/board maintainers to migrate to using devicetree-rebasing >

Re: [PATCH v5 06/11] dts: Add script to uprev dts/upstream subtree

2024-02-14 Thread Sumit Garg
Hi Marek, On Tue, 6 Feb 2024 at 11:50, Sumit Garg wrote: > > Hi Marek, > > On Tue, 6 Feb 2024 at 05:51, Marek Vasut wrote: > > > > On 2/2/24 14:05, Sumit Garg wrote: > > > dts/update-dts-subtree.sh is just a wrapper around git subtree commands. > > > U

Re: [PATCH v5 00/11] An effort to bring DT bindings compliance within U-Boot

2024-02-13 Thread Sumit Garg
On Tue, 6 Feb 2024 at 18:30, Tom Rini wrote: > > On Tue, Feb 06, 2024 at 10:57:12AM +0530, Sumit Garg wrote: > > Hi Tom, > > > > On Fri, 2 Feb 2024 at 23:32, Tom Rini wrote: > > > > > > On Fri, Feb 02, 2024 at 06:35:23PM +0530, Sum

Re: [PATCH] button: qcom-pmic: demote "unknown button" message to debug

2024-02-11 Thread Sumit Garg
- > drivers/button/button-qcom-pmic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/button/button-qcom-pmic.c > b/drivers/button/button-qcom-pmic.c > index 34a976d1e6c6..e6702139ca2d 100644 > --- a/driv

Re: [PATCH v5 06/11] dts: Add script to uprev dts/upstream subtree

2024-02-05 Thread Sumit Garg
Hi Marek, On Tue, 6 Feb 2024 at 05:51, Marek Vasut wrote: > > On 2/2/24 14:05, Sumit Garg wrote: > > dts/update-dts-subtree.sh is just a wrapper around git subtree commands. > > Usage from the top level U-Boot source tree, run: > > > > $ ./dts/update-dts-subtree.s

Re: [PATCH v5 00/11] An effort to bring DT bindings compliance within U-Boot

2024-02-05 Thread Sumit Garg
Hi Tom, On Fri, 2 Feb 2024 at 23:32, Tom Rini wrote: > > On Fri, Feb 02, 2024 at 06:35:23PM +0530, Sumit Garg wrote: > > > Changes in v5: > > -- > > - Rebased on tip of master (050a9b981d6a835133521b599be3ae189ce70f41) > > - Created v5_dt branch

[PATCH v5 11/11] dts: meson-gxbb: Drop redundant devicetree files

2024-02-02 Thread Sumit Garg
Since meson-gxbb based boards switched to using upstream DT, so drop redundant files from arch/arm/dts directory. Only *-u-boot.dtsi files kept in arch/arm/dts directory for these boards. Reviewed-by: Neil Armstrong Signed-off-by: Sumit Garg --- Changes in v5: - None Changes in v4: - None

[PATCH v5 10/11] dts: meson-gxbb: Switch to using upstream DT

2024-02-02 Thread Sumit Garg
ectly build DTB from dts/upstream/src/ including *-u-boot.dtsi files from arch/$(ARCH)/dts/ directory. Reviewed-by: Neil Armstrong Reviewed-by: Simon Glass Signed-off-by: Sumit Garg --- Changes in v5: - None Changes in v4: - Picked up review tag Changes in v3: - Dropped Makefile portio

[PATCH v5 09/11] MAINTAINERS: Add myself as devicetree-rebasing maintainer

2024-02-02 Thread Sumit Garg
Add myself as devicetree-rebasing maintainer. Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Signed-off-by: Sumit Garg --- Changes in v5: - None Changes in v4: - Switched subtree to be imported as dts/upstream sub-directory rather than devicetree-rebasing sub-directory to better

[PATCH v5 08/11] doc: devicetree: Updates for devicetree-rebasing subtree

2024-02-02 Thread Sumit Garg
Encourage SoC/board maintainers to migrate to using devicetree-rebasing subtree and maintain a regular sync with Linux kernel devicetree files and bindings. Along with that add documentation regarding how to run DT bindings schema checks. Signed-off-by: Sumit Garg --- Changes in v5: - Document

[PATCH v5 07/11] doc: devicetree: Align documentation to use Kconfig options

2024-02-02 Thread Sumit Garg
Since U-Boot switched away from manual CONFIG_* defines to Kconfig options, align devicetree documentation accordingly. Signed-off-by: Sumit Garg --- Changes in v5: - Fixed inappropriate documentation update. Changes in v4: - Separate patch to align documentation to use Kconfig symbols instead

[PATCH v5 06/11] dts: Add script to uprev dts/upstream subtree

2024-02-02 Thread Sumit Garg
dts/update-dts-subtree.sh is just a wrapper around git subtree commands. Usage from the top level U-Boot source tree, run: $ ./dts/update-dts-subtree.sh pull $ ./dts/update-dts-subtree.sh pick Signed-off-by: Sumit Garg --- Changes in v5: - Added support to cherry-pick fixes in subtree update

[PATCH v5 05/11] dts: Add alternative location for upstream DTB builds

2024-02-02 Thread Sumit Garg
platforms which currently are compliant with upstream Linux kernel devicetree files. Signed-off-by: Sumit Garg --- Changes in v5: - None Changes in v4: - Switched subtree to be imported as dts/upstream sub-directory rather than devicetree-rebasing sub-directory to better suite U-Boot

[PATCH v5 04/11] Makefile: Allow upstream DT subtree to provide DT includes

2024-02-02 Thread Sumit Garg
includes from U-Boot tree, so it shouldn't cause any conflicts. Tested-by: Bryan Brattlof Signed-off-by: Sumit Garg --- Changes in v5: - None Changes in v4: - New patch to reuse upstream DT includes by U-Boot as per Brian's use-case for TI K3 SoCs. Makefile | 3 ++

[PATCH v5 03/11] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2024-02-02 Thread Sumit Garg
-rebasing directory but still being able to include *-u-boot.dtsi files. Reviewed-by: Tom Rini Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Signed-off-by: Sumit Garg --- Changes in v5: - None Changes in v4: - Incorporate fix to resolve rk3399 migration issue reported by Simon

[PATCH v5 02/11] Makefile: Add support for DT bindings schema checks

2024-02-02 Thread Sumit Garg
to take place. Once that's done it can be added to CI builds to remain compliant with DT bindings. Reviewed-by: Simon Glass Tested-by: Simon Glass Signed-off-by: Sumit Garg --- Changes in v5: - None Changes in v4: - Switched subtree to be imported as dts/upstream sub-directory rather tha

[PATCH v5 01/11] CI: Exclude devicetree-rebasing subtree for CONFIG checks

2024-02-02 Thread Sumit Garg
Since devicetree-rebasing is an external repo with its own coding style, exclude it from Azure and gitlab CI CONFIG checks. Reviewed-by: Tom Rini Reviewed-by: Ilias Apalodimas Reviewed-by: Simon Glass Signed-off-by: Sumit Garg --- Changes in v5: - None Changes in v4: - Switched subtree to

[PATCH v5 00/11] An effort to bring DT bindings compliance within U-Boot

2024-02-02 Thread Sumit Garg
$ make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml:rtc.yaml $ make dtbs_check DT_SCHEMA_FILES=/gpio/ $ make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml Sumit Garg (11): CI: Exclude devicetree-rebasing subtree for CONFIG checks Makefile: Add support for DT bindings schema checks scr

Re: [PATCH] button: qcom-pmic: fix some error checking

2024-02-02 Thread Sumit Garg
his patch is mostly to make static checkers happy but it's obvious and > harmless. > > drivers/button/button-qcom-pmic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Sumit Garg -Sumit > diff --git a/drivers/button/button-qcom-pmic.c > b/drivers/

Re: [PATCH v3 26/36] dts: msm8916: import PMIC dtsi files

2024-02-02 Thread Sumit Garg
On Tue, 30 Jan 2024 at 19:35, Caleb Connolly wrote: > > Import the supporting pm8916.dtsi and msm8916-pm8916.dtsi files from > upstream in preparation for switching boards over. > > Taken from kernel tag v6.7 > > Reviewed-by: Neil Armstrong > Signed-off-by: Caleb Connolly > --- > arch/arm/dts/m

Re: [PATCH v3 27/36] dts: msm8916: replace with upstream DTS

2024-02-02 Thread Sumit Garg
On Tue, 30 Jan 2024 at 19:35, Caleb Connolly wrote: > > Drop the U-Boot specific dragonboard410c.dts in favour of the upstream > msm8916-sbc.dts. No additional changes are needed to this DTS for U-Boot > support. > > Taken from kernel tag v6.7 > > Reviewed-by: Neil Armstrong > Signed-off-by: Cale

Re: [PATCH v2 00/13] Introduce basic support for TI's AM62Px SoC family

2024-02-02 Thread Sumit Garg
Hi Bryan, On Thu, 1 Feb 2024 at 08:36, Bryan Brattlof wrote: > > Hello Again Everyone! > > **Note:** This series depends on the OF_UPSTREAM work from Sumit [0]. > Patch #11 was added to fix some Makefile.spl targets to allow SPL builds > to complete with the OF_UPSTREAM series. Thanks for your

Re: [PATCH v2 11/13] Makefile: remove hardcoded device tree source directory

2024-02-01 Thread Sumit Garg
x27;s dtbs depending on if OF_UPSTREAM > is selected or not. > > Signed-off-by: Bryan Brattlof > --- > Makefile | 18 ++ > scripts/Makefile.spl | 17 + > 2 files changed, 27 insertions(+), 8 deletions(-) > Reviewed-by: Sumit Ga

Re: [PATCH v3 20/36] mach-snapdragon: carve out no-map regions

2024-02-01 Thread Sumit Garg
On Thu, 1 Feb 2024 at 20:20, Caleb Connolly wrote: > > > > On 01/02/2024 12:07, Sumit Garg wrote: > > On Tue, 30 Jan 2024 at 19:35, Caleb Connolly > > wrote: > >> > >> On Qualcomm platforms, the TZ may already have certain memory regions > >> u

Re: [PATCH v3 03/36] mmc: msm_sdhci: use modern clock handling

2024-02-01 Thread Sumit Garg
On Thu, 1 Feb 2024 at 20:04, Caleb Connolly wrote: > > > > On 01/02/2024 08:19, Sumit Garg wrote: > > On Tue, 30 Jan 2024 at 19:35, Caleb Connolly > > wrote: > >> > >> Use the clk_* helper functions and the correct property name for clocks. > > &g

Re: [PATCH v3 17/36] mach-snapdragon: generalise board support

2024-02-01 Thread Sumit Garg
mm_region apq8016_mem_map[] = { > - { > - .virt = 0x0UL, /* Peripheral block */ > - .phys = 0x0UL, /* Peripheral block */ > - .size = 0x800UL, > - .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | > -

Re: [PATCH v3 33/36] dts: qcs404-evb: replace with upstream DT

2024-02-01 Thread Sumit Garg
ot;; > + function = "rgmii_mdio"; > + bias-pull-up; > + }; > + tx-pins { > + pins = "gpio67", "gpio66", "gpio65", "gpio64"; &

Re: [PATCH v3 33/36] dts: qcs404-evb: replace with upstream DT

2024-02-01 Thread Sumit Garg
gpio67", "gpio66", "gpio65", "gpio64"; > + function = "rgmii_tx"; > + bias-pull-up; > + drive-strength = <16>; > + }; > + rx-pins { &

Re: [PATCH v3 20/36] mach-snapdragon: carve out no-map regions

2024-02-01 Thread Sumit Garg
On Tue, 30 Jan 2024 at 19:35, Caleb Connolly wrote: > > On Qualcomm platforms, the TZ may already have certain memory regions > under protection by the time U-Boot starts. There is a rare case on some > platforms where the prefetcher might speculatively access one of these > regions resulting in a

Re: [PATCH v3 06/36] clock/qcom: qcs404: fix clk_set_rate

2024-02-01 Thread Sumit Garg
On Tue, 30 Jan 2024 at 19:35, Caleb Connolly wrote: > > We should be returning the rate that we set the clock to, drivers like > MMC rely on this. So fix it. I suppose following diff make sense on top of this patch given the MMC driver clock changes: diff --git a/drivers/clk/qcom/clock-qcs404.c

Re: [PATCH v3 35/36] pinctrl: qcom: fix DT compatibility

2024-02-01 Thread Sumit Garg
On Tue, 30 Jan 2024 at 19:35, Caleb Connolly wrote: > > Upstream devicetrees label GPIOs with "gpioX", not "GPIO_X", fix this > for SoCs where we're now using upstream DT. > > Signed-off-by: Caleb Connolly > --- > drivers/pinctrl/qcom/pinctrl-apq8016.c | 26 +- > drivers/

Re: [PATCH v3 03/36] mmc: msm_sdhci: use modern clock handling

2024-02-01 Thread Sumit Garg
On Tue, 30 Jan 2024 at 19:35, Caleb Connolly wrote: > > Use the clk_* helper functions and the correct property name for clocks. This still doesn't handle fixed clocks like in case of QCS404, upstream DT says: sdcc1: mmc@7804000 { compatible = "qcom,qcs404

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-31 Thread Sumit Garg
On Fri, 26 Jan 2024 at 12:35, Michal Simek wrote: > > > On 1/26/24 03:10, Marek Vasut wrote: > > On 1/26/24 00:19, Tom Rini wrote: > >> On Thu, Jan 25, 2024 at 05:38:23PM +0100, Marek Vasut wrote: > >>> On 1/25/24 16:04, Tom Rini wrote: > >>>> O

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-24 Thread Sumit Garg
On Thu, 25 Jan 2024 at 07:36, Marek Vasut wrote: > > On 1/24/24 09:16, Sumit Garg wrote: > > Hi, > > >>>> How do you propose to handle fixes to DTs which are applied to > >>>> linux-stable releases ? For example, if Linux 6.6(.0) ships a DT which >

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-24 Thread Sumit Garg
5AM +, Andre Przywara wrote: > > > > On Wed, 10 Jan 2024 16:05:36 +0530 > > > > Sumit Garg wrote: > > > > > > > > Hi, > > > > > > > > I certainly welcome this more automatic synchronisation of the DTs, > > > >

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-24 Thread Sumit Garg
Hi Marek, On Mon, 22 Jan 2024 at 05:47, Marek Vasut wrote: > > On 1/21/24 23:41, Caleb Connolly wrote: > > Hi, > > [...] > > >> How do you propose to handle fixes to DTs which are applied to > >> linux-stable releases ? For example, if Linux 6.6(.0) ships a DT which > >> has some defect that is f

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-23 Thread Sumit Garg
On Mon, 22 Jan 2024 at 05:31, Tom Rini wrote: > > On Sun, Jan 21, 2024 at 10:41:51PM +, Caleb Connolly wrote: > > > > > > On 21/01/2024 15:33, Marek Vasut wrote: > [snip] > > > Assume that there is some large breaking change in Linux 6.(n+1), > > > something which would be problematic for spec

Re: [PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-23 Thread Sumit Garg
Hi Nishanth, Apologies for the delayed response as I was on a long weekend vacation. On Fri, 19 Jan 2024 at 21:27, Nishanth Menon wrote: > > On 16:05-20240110, Sumit Garg wrote: > [...] > > Prerequisite > > > > > > This patch series requires devicet

Re: [PATCH v2 00/32] Qualcomm generic board support

2024-01-16 Thread Sumit Garg
On Fri, 22 Dec 2023 at 12:36, Sumit Garg wrote: > > On Thu, 21 Dec 2023 at 21:08, Caleb Connolly > wrote: > > > > > > > > On 20/12/2023 13:07, Sumit Garg wrote: > > > Hi Caleb, > > > > Hi Sumit, > > > > [...] > > > >

Re: [PATCH v2 00/32] Qualcomm generic board support

2024-01-11 Thread Sumit Garg
On Tue, 9 Jan 2024 at 17:03, Caleb Connolly wrote: > > > > On 09/01/2024 06:07, Sumit Garg wrote: > > On Fri, 5 Jan 2024 at 19:15, Caleb Connolly > > wrote: > >> > >> > >> > >> On 05/01/2024 13:14, Sumit Garg wrote: > >>>

Re: [PATCH v4 07/11] doc: devicetree: Align documentation to use Kconfig options

2024-01-10 Thread Sumit Garg
On Wed, 10 Jan 2024 at 18:01, Fabio Estevam wrote: > > On Wed, Jan 10, 2024 at 7:37 AM Sumit Garg wrote: > > > History > > --- > > > > -U-Boot configuration was previous done using CONFIG options in the board > > +U-Boot configuration was previous

[PATCH v4 11/11] dts: meson-gxbb: Drop redundant devicetree files

2024-01-10 Thread Sumit Garg
Since meson-gxbb based boards switched to using upstream DT, so drop redundant files from arch/arm/dts directory. Only *-u-boot.dtsi files kept in arch/arm/dts directory for these boards. Reviewed-by: Neil Armstrong Signed-off-by: Sumit Garg --- Changes in v4: - None Changes in v3: - Picked

[PATCH v4 10/11] dts: meson-gxbb: Switch to using upstream DT

2024-01-10 Thread Sumit Garg
ectly build DTB from dts/upstream/src/ including *-u-boot.dtsi files from arch/$(ARCH)/dts/ directory. Reviewed-by: Neil Armstrong Reviewed-by: Simon Glass Signed-off-by: Sumit Garg --- Changes in v4: - Picked up review tag Changes in v3: - Dropped Makefile portion and enabled OF_UPSTREAM fo

[PATCH v4 09/11] MAINTAINERS: Add myself as devicetree-rebasing maintainer

2024-01-10 Thread Sumit Garg
Add myself as devicetree-rebasing maintainer. Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Signed-off-by: Sumit Garg --- Changes in v4: - Switched subtree to be imported as dts/upstream sub-directory rather than devicetree-rebasing sub-directory to better suite U-Boot directory

[PATCH v4 08/11] doc: devicetree: Updates for devicetree-rebasing subtree

2024-01-10 Thread Sumit Garg
Encourage SoC/board maintainers to migrate to using devicetree-rebasing subtree and maintain a regular sync with Linux kernel devicetree files and bindings. Along with that add documentation regarding how to run DT bindings schema checks. Signed-off-by: Sumit Garg --- Changes in v4: - Switched

[PATCH v4 07/11] doc: devicetree: Align documentation to use Kconfig options

2024-01-10 Thread Sumit Garg
Since U-Boot switched away from manual CONFIG_* defines to Kconfig options, align devicetree documentation accordingly. Signed-off-by: Sumit Garg --- Changes in v4: - Separate patch to align documentation to use Kconfig symbols instead. doc/develop/devicetree/control.rst | 50

[PATCH v4 06/11] dts: Add script to uprev dts/upstream subtree

2024-01-10 Thread Sumit Garg
dts/update-dts-subtree.sh is just a wrapper around git subtree pull command. Usage from the top level U-Boot source tree, run: $ ./dts/update-dts-subtree.sh Signed-off-by: Sumit Garg --- Changes in v4: - New patch to add script dts/update-dts-subtree.sh as per Rob's comments. dts/updat

[PATCH v4 05/11] dts: Add alternative location for upstream DTB builds

2024-01-10 Thread Sumit Garg
platforms which currently are compliant with upstream Linux kernel devicetree files. Signed-off-by: Sumit Garg --- Changes in v4: - Switched subtree to be imported as dts/upstream sub-directory rather than devicetree-rebasing sub-directory to better suite U-Boot directory structure. - Added a

[PATCH v4 04/11] Makefile: Allow upstream DT subtree to provide DT includes

2024-01-10 Thread Sumit Garg
includes from U-Boot tree, so it shouldn't cause any conflicts. Tested-by: Bryan Brattlof Signed-off-by: Sumit Garg --- Changes in v4: - New patch to reuse upstream DT includes by U-Boot as per Brian's use-case for TI K3 SoCs. Makefile | 3 ++- scripts/Makefile.lib |

[PATCH v4 03/11] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2024-01-10 Thread Sumit Garg
-rebasing directory but still being able to include *-u-boot.dtsi files. Reviewed-by: Tom Rini Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Signed-off-by: Sumit Garg --- Changes in v4: - Incorporate fix to resolve rk3399 migration issue reported by Simon. Changes in v3: - Picked up

[PATCH v4 02/11] Makefile: Add support for DT bindings schema checks

2024-01-10 Thread Sumit Garg
to take place. Once that's done it can be added to CI builds to remain compliant with DT bindings. Reviewed-by: Simon Glass Tested-by: Simon Glass Signed-off-by: Sumit Garg --- Changes in v4: - Switched subtree to be imported as dts/upstream sub-directory rather than devicetree-rebasin

[PATCH v4 01/11] CI: Exclude devicetree-rebasing subtree for CONFIG checks

2024-01-10 Thread Sumit Garg
Since devicetree-rebasing is an external repo with its own coding style, exclude it from Azure and gitlab CI CONFIG checks. Reviewed-by: Tom Rini Reviewed-by: Ilias Apalodimas Reviewed-by: Simon Glass Signed-off-by: Sumit Garg --- Changes in v4: - Switched subtree to be imported as dts

[PATCH v4 00/11] An effort to bring DT bindings compliance within U-Boot

2024-01-10 Thread Sumit Garg
ated by ':'. $ make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml:rtc.yaml $ make dtbs_check DT_SCHEMA_FILES=/gpio/ $ make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml Sumit Garg (11): CI: Exclude devicetree-rebasing subtree for CONFIG checks Makefile: Add support for DT bindings schema che

Re: [PATCH v2 00/32] Qualcomm generic board support

2024-01-08 Thread Sumit Garg
On Fri, 5 Jan 2024 at 19:15, Caleb Connolly wrote: > > > > On 05/01/2024 13:14, Sumit Garg wrote: > > Hi Caleb, > > Hi Sumit, > > [snip] > > >> --- > >> I have tested this series on the Dragonboard410c, Dragonboard820c, and > > > >

Re: [PATCH v3 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2024-01-08 Thread Sumit Garg
On Tue, 9 Jan 2024 at 07:24, Bryan Brattlof wrote: > > On January 8, 2024 thus sayeth Sumit Garg: > > Hi Bryan, > > > > On Sat, 6 Jan 2024 at 02:12, Bryan Brattlof wrote: > > > > > > Hi Sumit! > > > > > > On December 28, 2023 thus

Re: [PATCH v3 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2024-01-07 Thread Sumit Garg
Hi Bryan, On Sat, 6 Jan 2024 at 02:12, Bryan Brattlof wrote: > > Hi Sumit! > > On December 28, 2023 thus sayeth Sumit Garg: > > Allow u-boot to build DTB from a different directory tree such that > > *-u-boot.dtsi files can be included from a common location. Currently &

Re: [PATCH] mach-snapdragon: Move APQ8016 SoC derived board code

2024-01-05 Thread Sumit Garg
On Thu, 4 Jan 2024 at 18:00, Caleb Connolly wrote: > > Hi Sumit, > > On 03/01/2024 13:07, Sumit Garg wrote: > > In order to avoid duplication of APQ8016 derived boards specific code, > > move common bits like USB pinctrl and fastboot to board-apq8016.c file. > >

Re: [PATCH v2 00/32] Qualcomm generic board support

2024-01-05 Thread Sumit Garg
> https://lore.kernel.org/u-boot/20231114-b4-qcom-dt-compat-v3-0-88a92f8f0...@linaro.org/ > [3]: > https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/tree/b4/qcom-common-target > > --- > Changes in v2: > - Split DTS changes to reduce patch size. > - Import full boa

Re: [PATCH v3 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2024-01-05 Thread Sumit Garg
24 at 03:45:10PM +0100, Michal Simek wrote: > >>>> Hi Tom, > >>>> > >>>> On 1/4/24 14:50, Tom Rini wrote: > >>>>> On Thu, Jan 04, 2024 at 06:52:32PM +0530, Sumit Garg wrote: > >>>>>> Hi Michal, > >>>>>> >

Re: [PATCH v3 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2024-01-04 Thread Sumit Garg
Hi Michal, On Thu, 4 Jan 2024 at 15:39, Michal Simek wrote: > > > > On 1/3/24 17:32, Tom Rini wrote: > > On Wed, Jan 03, 2024 at 09:19:40AM -0700, Rob Herring wrote: > >> On Thu, Dec 28, 2023 at 4:59 AM Sumit Garg wrote: > > [snip] > >>> +In or

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2024-01-04 Thread Sumit Garg
Hi Simon, On Thu, 28 Dec 2023 at 20:39, Simon Glass wrote: > > Hi Tom, Sumit, > > On Thu, Dec 28, 2023 at 2:03 PM Tom Rini wrote: > > > > On Thu, Dec 28, 2023 at 01:37:26PM +, Simon Glass wrote: > > > Hi Sumit, > > > > > >

Re: [PATCH v3 5/8] doc: devicetree: Updates for devicetree-rebasing subtree

2024-01-04 Thread Sumit Garg
On Wed, 3 Jan 2024 at 22:02, Tom Rini wrote: > > On Wed, Jan 03, 2024 at 09:19:40AM -0700, Rob Herring wrote: > > On Thu, Dec 28, 2023 at 4:59 AM Sumit Garg wrote: > [snip] > > > +In order to maintain devicetree files sync, U-Boot maintains a Git > > > subtree f

Re: [PATCH v3 0/8] An effort to bring DT bindings compliance within U-Boot

2024-01-04 Thread Sumit Garg
Hi Michal, On Wed, 3 Jan 2024 at 18:24, Michal Simek wrote: > > > > On 12/28/23 12:57, Sumit Garg wrote: > > Changes in v3: > > -- > > - Patch #4: Minor commit message update > > - Patch #5: Replace CONFIG_* with Kconfig options > > - Patc

[PATCH] mach-snapdragon: Move APQ8016 SoC derived board code

2024-01-03 Thread Sumit Garg
In order to avoid duplication of APQ8016 derived boards specific code, move common bits like USB pinctrl and fastboot to board-apq8016.c file. This will allow future board support like SE HMIBSC board etc to reuse it. Signed-off-by: Sumit Garg --- This patch is based on Caleb's Qcom c

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2024-01-02 Thread Sumit Garg
On Tue, 2 Jan 2024 at 21:07, Sumit Garg wrote: > > On Tue, 2 Jan 2024 at 19:36, Simon Glass wrote: > > > 3. Adjust the build system to use the dts/ directory for .dts files > > when OF_UPSTREAM is enabled > > > > Then it will be easy. People can enable OF

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2024-01-02 Thread Sumit Garg
Hi Tom, On Tue, 2 Jan 2024 at 23:36, Tom Rini wrote: > > On Tue, Jan 02, 2024 at 09:07:48PM +0530, Sumit Garg wrote: > > On Tue, 2 Jan 2024 at 19:36, Simon Glass wrote: > [snip] > > > 2. Choose a directory target for devicetree-rebasing. I see that > > > '

Re: [PATCH v3 4/8] dts: Add alternative location for upstream DTB builds

2024-01-02 Thread Sumit Garg
Mark Kettenis > > > wrote: > > > > > > > > > Date: Sun, 31 Dec 2023 15:39:53 -0500 > > > > > From: Tom Rini > > > > > > > > > > On Sun, Dec 31, 2023 at 07:28:52AM -0700, Simon Glass wrote: > > > > > >

<    1   2   3   4   5   6   7   8   9   >