Re: [U-Boot] [PATCH 2/2] powerpc/85xx: Report workaround of errata SATA-A001

2010-06-10 Thread Timur Tabi
); +       } +#endif +        return 0;  } How are you planning on handling chip-specific errata? Do you forsee do_errata() containing code for every erratum of every chip? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot

Re: [U-Boot] [PATCH] ppc/8xxx: Add is_core_disabled to remove disabled cores from dtb

2010-06-09 Thread Timur Tabi
); +               break; +       case 1: +               return (devdisr MPC85xx_DEVDISR_CPU1); +               break; And you don't need a 'break' after a 'return' in a switch-case statement. You also don't need parentheses around the expression in the 'return' statement. -- Timur Tabi Linux kernel

Re: [U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init()

2010-06-08 Thread Timur Tabi
On Tue, Jun 8, 2010 at 2:14 AM, Wolfgang Denk w...@denx.de wrote: Mike is right. If you change it here, _all_ similar places should be changed as well in the same commit. Well, since I don't want to change all the other code, I'll keep it as a signed int. -- Timur Tabi Linux kernel developer

[U-Boot] [PATCH] [v3] tsec: fix the return value for tsec_eth_init()

2010-06-08 Thread Timur Tabi
to ignore it. In general, if an function initializes only one device, then it should return a negative number if there's an error. If it initializes more than one device, then it should never return a negative number. Signed-off-by: Timur Tabi ti...@freescale.com --- drivers/net/tsec.c | 15

Re: [U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init()

2010-06-08 Thread Timur Tabi
Mike Frysinger wrote: the documentation currently states that a negative value is permissible and thus int is correct. as for the code that actually reads the result, that is by large common code, so logic along those lines isnt terribly important. The conclusion I drew from Andy's

Re: [U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init()

2010-06-08 Thread Timur Tabi
Reinhard Meyer (-VC) wrote: That poses the general question what a function that initializes several devices should do if one of the devices should return an error and what to return if ALL devices return an error. I believe the consensus is that any device initialization function that

Re: [U-Boot] [PATCH] [v2] powerpc: add support for the Freescale P1022DS reference board

2010-06-08 Thread Timur Tabi
Timur Tabi wrote: Add basic suport for the Freescale P1022DS reference board. Specifics: 1) 36-bit only 2) Booting from NOR flash only 3) Environment stored in NOR flash only 4) No SPI support 5) No DIU support Signed-off-by: Timur Tabi ti...@freescale.com --- Any comments

[U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init()

2010-06-07 Thread Timur Tabi
integer. Signed-off-by: Timur Tabi ti...@freescale.com --- drivers/net/tsec.c | 22 -- include/tsec.h |4 ++-- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c index 3e4c3bd..6ca9735 100644 --- a/drivers/net/tsec.c

Re: [U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init()

2010-06-07 Thread Timur Tabi
Mike Frysinger wrote: On Monday, June 07, 2010 14:31:27 Timur Tabi wrote: In general, if an function initializes only one device, then it should return a negative number if there's an error. If it initializes more than one device, then it should never return a negative number. This is why

[U-Boot] [PATCH] [v2] powerpc: add support for the Freescale P1022DS reference board

2010-06-04 Thread Timur Tabi
Add basic suport for the Freescale P1022DS reference board. Specifics: 1) 36-bit only 2) Booting from NOR flash only 3) Environment stored in NOR flash only 4) No SPI support 5) No DIU support Signed-off-by: Timur Tabi ti...@freescale.com --- v2: addresses most of Wolfgang's concerns. DIU

[U-Boot] [PATCH] tsec: fix the return value for tsec_eth_init()

2010-06-04 Thread Timur Tabi
to ignore it. Signed-off-by: Timur Tabi ti...@freescale.com --- drivers/net/tsec.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c index 3e4c3bd..abfc80a 100644 --- a/drivers/net/tsec.c +++ b/drivers/net/tsec.c @@ -97,12

Re: [U-Boot] [PATCH] tsec: fix the return value for tsec_eth_init()

2010-06-04 Thread Timur Tabi
Andy Fleming wrote: The old way continued even if one of the tsecs failed to initialize. Let's preserve the original behavior in that sense: for (i = 0; i num; i++) { ret = tsec_initialize(bis, tsecs[i]); if (ret = 0) count++; } This code has multiple levels

Re: [U-Boot] [PATCH] tsec: fix the return value for tsec_eth_init()

2010-06-04 Thread Timur Tabi
Andy Fleming wrote: You just noted that tsec_eth_init should return the number of tsecs initialized successfully. Therefore, the callers can check that number, and respond accordingly. tsec_initialize() can report the error. If we want more elaborate error handling, we can devise something.

Re: [U-Boot] [PATCH] 85xx/p2020ds: Use is_serdes_configured() to determine of PCIe enabled

2010-05-28 Thread Timur Tabi
-mem_phys, law_size_bits(pci_info-mem_size), pci_info-law_trgt_id); } /* duplicate for IO */ Ok, I'll add it to my list for the PCI revamp. -- Timur Tabi Linux kernel developer at Freescale

[U-Boot] [PATCH] fsl: add LAW target to fsl_pci_info structure

2010-05-28 Thread Timur Tabi
. This will allow future PCI[E] code to configure the LAW target automatically, rather than requiring each board to it for each PCI controller separately. Signed-off-by: Timur Tabi ti...@freescale.com --- Tested via MAKEALL. If this patch is accepted, I'll use it for the P1022DS board support that I'm

Re: [U-Boot] [PATCH] fsl: add LAW target to fsl_pci_info structure

2010-05-28 Thread Timur Tabi
Kumar Gala wrote: My pref is to leave the tabs. The 'law' field would be misaligned. I would need to insert lots of tabs. unsigned long regs; pci_addr_t mem_bus; phys_size_t mem_phys; pci_size_t mem_size; pci_addr_t io_bus;

Re: [U-Boot] [PATCH] fsl: add LAW target to fsl_pci_info structure

2010-05-28 Thread Timur Tabi
Kumar Gala wrote: Will wait til there is code that uses fsl_pci_info.law until this is applied. Can you push your ics307 patch to your repository? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 03/10] 83xx/85xx/86xx: LBC register cleanup

2010-05-28 Thread Timur Tabi
; Since you're using I/O accessors, does this still need to be volatile? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-27 Thread Timur Tabi
bigger memory sizes as well. I guess this will needed for more and more systems. Yes. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] [RFC] memsize.c: adapt get_ram_size() for address spaces 32 bit

2010-05-27 Thread Timur Tabi
phys_addr_t / phys_size_t data types instead. Signed-off-by: Wolfgang Denk w...@denx.de Cc: Timur Tabi ti...@freescale.com --- The problem is that on all of our PowerPC boards, the TLBs only map the lower 2GB of memory, regardless as to how much is present. So we still can't use get_ram_size

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-27 Thread Timur Tabi
to imrpove U-Boot for your boards? True. But I also want to get real work done in a timely manner. It's taking a lot longer than I expected to get support for this board approved. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-27 Thread Timur Tabi
a serious limitation. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-27 Thread Timur Tabi
say there is? That is, if there's only 1GB of RAM, and we do this: dram_size = get_ram_size(0, 2GB); That get_ram_size() will return 1GB? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http

Re: [U-Boot] [PATCH] [RFC] memsize.c: adapt get_ram_size() for address spaces 32 bit

2010-05-27 Thread Timur Tabi
mnemory bus. This is an RFC patch. My point is that sizeof(phys_addr_t) has got nothing to do with the size of the read/write operation, so I think it's wrong on all platforms. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-27 Thread Timur Tabi
into this sort of problem doing this type of memory sizing on PCs. Well, let's call this a bug in setting up the memory map for the system ;-) I thought get_ram_size() was supposed to safely determine how much RAM is actually in the system? Otherwise, it should be called verify_ram_size(). -- Timur

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-27 Thread Timur Tabi
to require me to use get_ram_size() in my P1022DS board patch? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] [RFC] memsize.c: adapt get_ram_size() for address spaces 32 bit

2010-05-27 Thread Timur Tabi
is supported, so I have no idea at compile-time how much memory is in the system. That's why I don't think calling get_ram_size() is appropriate for the P1022DS board. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot

Re: [U-Boot] [PATCH] 85xx/p2020ds: Use is_serdes_configured() to determine of PCIe enabled

2010-05-27 Thread Timur Tabi
, NULL); match hose-cfg_addr against reg off = fdt_node_offset_by_compatible(blob, off, pci_compat); } } Ok, I'll start working on this after I'm done with the P1022DS. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] 85xx/p2020ds: Use is_serdes_configured() to determine of PCIe enabled

2010-05-27 Thread Timur Tabi
, +law_size_bits(pci_info[num].mem_size), +LAW_TRGT_IF_PCIE_2); + set_next_law(pci_info[num].io_phys, +law_size_bits(pci_info[num].io_size), + LAW_TRGT_IF_PCIE_2); -- Timur Tabi Linux kernel

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-26 Thread Timur Tabi
this as an exercise to you :-) I'd rather not use subtypes, because I don't think we want anything like this: if (is_qe_firmware()) { /* embed QE firmware */ } else if (is_amd_fpga_firmware()) { /* embed AMD fpga firmware */ } ... -- Timur Tabi Linux

Re: [U-Boot] [PATCH] [OLT-M68K] Avoid 64bit division in print_size

2010-05-26 Thread Timur Tabi
On Wed, May 26, 2010 at 9:01 AM, Luigi 'Comio' Mantellini luigi.mantell...@idf-hit.com wrote: Signed-off-by: Luigi 'Comio' Mantellini luigi.mantell...@idf-hit.com --- You're a little late: http://git.denx.de/?p=u-boot.git;a=commit;h=f2d76ae4fdde180e120ea2d29d6ef881360b3cba -- Timur Tabi

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-26 Thread Timur Tabi
() will be the function that actually embeds the firmware into the device tree. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-26 Thread Timur Tabi
Scott Wood wrote: On Wed, May 26, 2010 at 11:38:27AM -0500, Timur Tabi wrote: I believe we should have a board-specific function that figures out how much extra space is needed, and just returns a single integer that the boot_relocate_fdt() uses to pad the FDT when it relocates it. Why

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-26 Thread Timur Tabi
, struct pci_controller *hose); Are you sure you would really rather see this as its own function? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-26 Thread Timur Tabi
is not the same code copy/pasted three times. Every line is different. Moving that code into a function is not going to simplify anything. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-26 Thread Timur Tabi
in the device tree? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-26 Thread Timur Tabi
= CONFIG_SYS_PCIE1_MEM_PHYS; x.mem_size = LAW_SIZE_512M; x.io_addr = CONFIG_SYS_PCIE1_IO_PHYS; x.io_size = LAW_SIZE_64K; x.pci_info = pci_info[num]; x.hose = pcie1_hose; configure_pci(x); I don't see how this is an improvement. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-26 Thread Timur Tabi
must have used grep wrong or something. I see what you're talking about now. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-26 Thread Timur Tabi
. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] 85xx/p2020ds: Use is_serdes_configured() to determine of PCIe enabled

2010-05-26 Thread Timur Tabi
CONFIG_SYS_PCIE3_ADDR (CONFIG_SYS_CCSRBAR+0xa000) /* pci2 */ -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] 85xx/p2020ds: Use is_serdes_configured() to determine of PCIe enabled

2010-05-26 Thread Timur Tabi
. It appears that there's no need to remember pci_info[0] and use pci_info[1] for the next PCIE device. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-26 Thread Timur Tabi
, pci_info.regs); first_free_busno = fsl_pci_init_port(pci_info, hose, first_free_busno); } else { printf(PCIE%u: disabled\n, num); } } -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-25 Thread Timur Tabi
to use to pass the address and/or size of the firmware FIT image to boot_relocate_fdt()? Obviously, you don't like CONFIG_SYS_FDT_PAD, but I want to know what direction to go in before I start coding. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-25 Thread Timur Tabi
something about an environment variable, but I can't find that email any more. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-25 Thread Timur Tabi
of RAM? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-25 Thread Timur Tabi
the firmware from the FIT image and embeds it into the device tree, in a QE-specific way. I just want to make sure that we're on the same page. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de

Re: [U-Boot] [PATCH v2] Move ICS CLK chip frequenty calculation code into a common board library

2010-05-24 Thread Timur Tabi
and should be removed. It doesn't do what the comment says it does, and as you said earlier, rounding is wrong for this function. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman

Re: [U-Boot] [PATCH] ppc/85xx: Add a structure defn for PIXIS registers

2010-05-24 Thread Timur Tabi
On Mon, May 24, 2010 at 1:12 PM, Kumar Gala ga...@kernel.crashing.org wrote: +} pixis_t  __attribute__ ((aligned(1))); What's the aligned(1) for? Asked Timur, I copied it from the ngpixis.h header Hmmm... I think I might have meant __packed__ instead of aligned(1). -- Timur Tabi Linux

Re: [U-Boot] [PATCH v2] Move ICS CLK chip frequenty calculation code into a common board library

2010-05-24 Thread Timur Tabi
redundant calls to the function. But the problem is that it needs to be a const __attribute__, and the debug() call would need to be deleted for it to be valid anyway. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot

[U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block

2010-05-24 Thread Timur Tabi
variables to avoid some typecasts. Signed-off-by: Timur Tabi ti...@freescale.com --- common/image.c | 83 +++- 1 files changed, 28 insertions(+), 55 deletions(-) diff --git a/common/image.c b/common/image.c index 8d4be14..e19732c 100644

Re: [U-Boot] [PATCH v3] Move ICS CLK chip frequenty calculation code into a common board library

2010-05-24 Thread Timur Tabi
ICS307 code. Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- Acked-by: Timur Tabi ti...@freescale.com -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] ppc/85xx: Add a structure defn for PIXIS registers

2010-05-23 Thread Timur Tabi
, and it gets confused if there's more than one typedef struct pixis in the file. You don't have to worry about any more boards using these structures. Gary M. said that all future boards will use ngpixis. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-21 Thread Timur Tabi
probably need to be made later, because I would probably need to change all the board header files at once. It's not trivial. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-21 Thread Timur Tabi
, I don't want to modify every other board in the same patch set. I'll try to fix it anyway, though. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] powerpc: add support for the FreescaleP1022DS reference board

2010-05-21 Thread Timur Tabi
power on the board, it says this: Board: P1022DS Sys ID: 0x19, Sys Ver: 0x02, FPGA Ver: 0x04, vBank: 0 How can I tell if I have a rev2 board? There's a sticker that says, sch-26191 rev b -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot

Re: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library

2010-05-21 Thread Timur Tabi
get_board_ddr_clk(void); +#endif I don't think we need the #ifndef __ASSEMBLY__ here. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-21 Thread Timur Tabi
MPC86xx_SYS_INFO sys_info_t; void get_sys_info ( sys_info_t * ); #endif Suggestions? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr clocks to speed.c

2010-05-21 Thread Timur Tabi
there. This eliminates the need to define the prototypes in the board config files. Signed-off-by: Timur Tabi ti...@freescale.com --- I'm posting the patch for review, and if everyone likes it, inclusion in the 85xx repo. Comments welcome. arch/powerpc/cpu/mpc85xx/speed.c |4 1 files

Re: [U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr clocks to speed.c

2010-05-21 Thread Timur Tabi
Scott Wood wrote: On 05/21/2010 01:07 PM, Timur Tabi wrote: On most Freescale 85xx boards, the CONFIG_SYS_CLK_FREQ and CONFIG_DDR_CLK_FREQ macros are defined like this: Like what? Doh. Git commit delete those lines because they began with a #. This was supposed to be there: #define

Re: [U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr clocks to speed.c

2010-05-21 Thread Timur Tabi
is resolved, I'll probably post a patch that unifies the functions in some way. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr clocks to speed.c

2010-05-21 Thread Timur Tabi
Timur Tabi wrote: Well, you'll have to convince Wolfgang of that, not me. He won't accept my P1022DS board patch until I fix this problem. Actually, if you look at Kumar's ICS307 patch, you'll see he fixes this problem for any board that uses the ICS307: -#ifndef __ASSEMBLY__ -extern

Re: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library

2010-05-21 Thread Timur Tabi
On Fri, May 21, 2010 at 4:18 AM, Kumar Gala ga...@kernel.crashing.org wrote: +COBJS-$(CONFIG_P2020DS)                += ics307_clk.o How about changing this to: COBJS-$(CONFIG_ICS307_REFCLK_HZ) += ics307_clk.o -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library

2010-05-21 Thread Timur Tabi
)); Is this rounding algorithm the reason why I get output like this: Clock Configuration: CPU0:799.992 MHz, CPU1:799.992 MHz, CCB:399.996 MHz, DDR:299.997 MHz (599.994 MT/s data rate) (Asynchronous), LBC:25 MHz If so, maybe we should fix it? -- Timur Tabi Linux kernel developer

Re: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library

2010-05-21 Thread Timur Tabi
On Fri, May 21, 2010 at 1:59 PM, Timur Tabi timur.t...@gmail.com wrote: Is this rounding algorithm the reason why I get output like this: Clock Configuration:       CPU0:799.992 MHz, CPU1:799.992 MHz,       CCB:399.996 MHz,       DDR:299.997 MHz (599.994 MT/s data rate) (Asynchronous), LBC

Re: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library

2010-05-21 Thread Timur Tabi
not align vertically?). This makes me wonder why you use a %-4s format in arch/powerpc/cpu/mpc8?xx/cpu.c - may I recommend changing this into %s (if you don't care about vertical alignment), or something like %4s else? I'm okay with that. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library

2010-05-21 Thread Timur Tabi
. The problem is that strmhz() rounds to the nearest KHz. I wonder if that's really useful. Perhaps we should make it act more like print_size(), where it prints KHz, MHz, or GHz as appropriate, and rounds to the nearest 10th, instead of 1000th. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library

2010-05-21 Thread Timur Tabi
be less useful, and require changes to MANY boards (essentially all of them) as the output format needs to be adjusted. How about adding a function to strmhz.c that acts like print_size(), and then the caller can choose which one he wants? We could call it print_hz or print_freq. -- Timur Tabi

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-20 Thread Timur Tabi
On Thu, May 20, 2010 at 3:28 AM, Wolfgang Denk w...@denx.de wrote: Dear Timur Tabi, In message 4bf4623b.1080...@freescale.com you wrote: Why would this in any way be a board specific implementation? This makes no sense to me. The feature to include some binary data into the DTB is IMO

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-20 Thread Timur Tabi
= 1; Kumar, what do you think about having boot_relocate_fdt() always relocate the fdt, even if it is already in the bootmap? That would ensure that it gets resized and put into an lmb region. -- Timur Tabi Linux kernel developer at Freescale ___ U

[U-Boot] [PATCH 1/2] fsl/85xx: add clkdvdr to global utilities structure definition

2010-05-20 Thread Timur Tabi
Add the 'clkdvdr' to the 85xx definition of struct ccsr_gur. Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/include/asm/immap_85xx.h |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/immap_85xx.h b/arch/powerpc/include/asm

[U-Boot] [PATCH 2/2] fsl: rename 'dma' to 'brdcfg1' in the ngPIXIS structure

2010-05-20 Thread Timur Tabi
The ngPIXIS is a board-specific FPGA, but the definition of the registers is mostly consistent. On boards where it matter, register 9 is called 'brdcfg1' instead of 'dma', so rename the variable in the ngpixis_t definition. Signed-off-by: Timur Tabi ti...@freescale.com --- board/freescale

[U-Boot] [PATCH v2] fsl/85xx: add clkdvdr and pmuxcr2 to global utilities structure definition

2010-05-20 Thread Timur Tabi
Add the 'clkdvdr' and 'pmuxcr2' registers to the 85xx definition of struct ccsr_gur. Signed-off-by: Timur Tabi ti...@freescale.com --- This patch replaces fsl/85xx: add clkdvdr to global utilities structure definition. Thanks to Sergei Shtylyov. arch/powerpc/include/asm/immap_85xx.h |9

[U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-20 Thread Timur Tabi
Add basic suport for the Freescale P1022DS reference board. Signed-off-by: Timur Tabi ti...@freescale.com --- This patch requires the following two patches to be applied first: fsl/85xx: add clkdvdr and pmuxcr2 to global utilities structure definition fsl: rename 'dma' to 'brdcfg1

Re: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

2010-05-20 Thread Timur Tabi
don't know how that got in there. My eyes saw #define and not #undef. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-19 Thread Timur Tabi
is expanded by that value. [Note that it does not help that *you* *shout* *at* *me* all the time that you need this *now*. This does not make your patch any better.] Shouting is done with ALL CAPS. Framing words with asterisks is used to designate emphasis. -- Timur Tabi Linux kernel developer

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-19 Thread Timur Tabi
of fdt_increase_size() and just copy it into boot_relocate_fdt(). In fact, I think that's what I will do. I thought I was being polite by simply re-using an existing function, but I'd rather just copy the code into boot_relocate_fdt() if it means I don't have to argue with you about it. -- Timur Tabi Linux

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-19 Thread Timur Tabi
to fdt_increase_size(). However, you said you would reject any patch that uses fdt_open_into() in this manner, so we're back to square one. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo

[U-Boot] [PATCH] libfdt: introduce function fdt_get_max_phandle

2010-05-19 Thread Timur Tabi
Introduce function fdt_get_max_phandle(), which returns the largest value of all phandles in a device tree. This is useful for allocating a new phandle property, since all phandles must be unique. Signed-off-by: Timur Tabi ti...@freescale.com --- include/libfdt.h| 20

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-18 Thread Timur Tabi
fdt_increase_size()! -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-18 Thread Timur Tabi
. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] u-boot 1.1.2 boot latest powerpc based kernel?

2010-05-17 Thread Timur Tabi
is still one of data transferred to the kernel, right? How does bd_info work with the DTS info? That, I don't know. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u

Re: [U-Boot] hardware flash protect kept during a reboot?

2010-05-17 Thread Timur Tabi
FLASH chips. I put a printf() in flash_real_protect(), so I know that's not the problem. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-17 Thread Timur Tabi
in the next merge window, so that when rebase our internal repository on the next release, this patch will already be available. It makes our internal development easier. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot

Re: [U-Boot] libfdt: make fdt_increase_size() available to everyone

2010-05-15 Thread Timur Tabi
that the space after the fdt is available. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] standalone hello_world example crashes on PowerPC

2010-05-14 Thread Timur Tabi
use the nm command to find the entry point. That web page implies that compiling hello_world.c unmodified will always put the entry point at 40004. The statement, It's configured to run at address 0x00040004 is false. -- Timur Tabi Linux Kernel Developer @ Freescale

[U-Boot] flash_real_protect() and CFI_CMDSET_AMD_STANDARD

2010-05-14 Thread Timur Tabi
the need for Rafael Campos' patch: http://lists.denx.de/pipermail/u-boot/2008-July/037419.html It looks as if Rafael removed support for hardware flash protection from all AMD standard/extended flash chips that are not made by Atmel. -- Timur Tabi Linux kernel developer at Freescale

[U-Boot] hardware flash protect kept during a reboot?

2010-05-14 Thread Timur Tabi
[] array is initialized on every boot. However, since I was using hardware protection, I expect the chip will still protect the sector. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de

Re: [U-Boot] u-boot 1.1.2 boot latest powerpc based kernel?

2010-05-13 Thread Timur Tabi
and a specific (older) U-Boot will work together. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] standalone hello_world example crashes on PowerPC

2010-05-13 Thread Timur Tabi
7FE38804 0005 0005838E Call backtrace: 00040030 Exception in kernel pc 0 signal 0 ### ERROR ### Please RESET the board ### I just want to make sure I'm not doing anything dumb before I start debugging it. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH v3] Avoid use of divides in print_size

2010-05-11 Thread Timur Tabi
that the divides where always powers of two, preventing optimisation. Signed-off-by: Nick Thompson nick.thomp...@ge.com --- Acked-by: Timur Tabi ti...@freescale.com I don't know if this solves the problem on ARM, but it works on PowerPC. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] Avoid use of divides in print_size.

2010-05-10 Thread Timur Tabi
-- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Avoid use of divides in print_size.

2010-05-10 Thread Timur Tabi
- 2.8 EiB 6485183463413514240 - 5.6 EiB 12970366926827028480 - 11.2 EiB 7493989779944505344 - 6.5 EiB That last one is probably an overflow. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http

[U-Boot] [PATCH 2/3] libfdt: make fdt_increase_size() available to everyone

2010-05-10 Thread Timur Tabi
it's going to add data, instead of hoping that the DTS was compiled with the right -p value. Signed-off-by: Timur Tabi ti...@freescale.com --- common/fdt_support.c | 20 ++-- include/fdt_support.h |1 + 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/common

Re: [U-Boot] [PATCH 2/3] libfdt: make fdt_increase_size() available to everyone

2010-05-10 Thread Timur Tabi
On Mon, May 10, 2010 at 4:26 PM, Timur Tabi ti...@freescale.com wrote: The function fdt_increase_size() increases the size of the device tree by the given amount.  This is useful for any code that wants to add a node or large property, to avoid the possibility of running out of space.  It's

Re: [U-Boot] Building for da830 fails

2010-05-07 Thread Timur Tabi
like it's related to integers. Also, this patch fixes a real bug in print_size(), so we can't just back it out. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Building for da830 fails

2010-05-07 Thread Timur Tabi
() and see if that helps. It must have something to do with __extension__. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Building for da830 fails

2010-05-07 Thread Timur Tabi
that in order to support support printing 64-bit numbers on ARM, we might need to completely rewrite print_size() to avoid division on 64-bit numbers. Wolfgang, do you have any suggestions? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot

Re: [U-Boot] [PATCH 2/2] remove main CHANGELOG file

2010-05-05 Thread Timur Tabi
from the repository. I don't see why you can't run a script to regenerate it when you need it. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] [v6] allow print_size to print large numbers on 32-bit systems

2010-05-03 Thread Timur Tabi
Wolfgang, if you have no objections, please apply this patch. On Tue, Apr 13, 2010 at 1:16 PM, Timur Tabi ti...@freescale.com wrote: Modify print_size() so that it can accept numbers larger than 4GB on 32-bit systems. Add support for display terabyte, petabyte, and exabyte sizes.  Change

Re: [U-Boot] [PATCH 1/2] [v2] fix print_size printing fractional gigabyte numbers on 32-bit platforms

2010-05-03 Thread Timur Tabi
Wolfgang, if you have no objections, please apply this patch. On Tue, Apr 13, 2010 at 1:16 PM, Timur Tabi ti...@freescale.com wrote: In print_size(), the math that calculates the fractional remainder of a number used the same integer size as a physical address.  However, the 10 * factor

<    1   2   3   4   5   6   7   >