Re: [U-Boot] [PATCH 3/3] mpc83xx: turn on icache in core initialization to improve u-boot boot time

2010-04-19 Thread Timur Tabi
| \ +                                HID0_ENABLE_DYNAMIC_POWER_MANAGMENT) What was so special about the 8349ITX that icache() didn't work? You're changing the HDI0 values for all of the 83xx boards, but AFAIK, only the ITX had this problem. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH 3/3] mpc83xx: turn on icache in core initialization to improve u-boot boot time

2010-04-19 Thread Timur Tabi
) || defined(CONFIG_MPC83xx) icache_enable (); /* it's time to enable the instruction cache */ #endif Kim references the ITX in this patch, but I don't see how the problem I just described is fixed. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH 3/3] mpc83xx: turn on icache in core initialization to improve u-boot boot time

2010-04-19 Thread Timur Tabi
causes U-Boot to hang or crash. Therefore, I don't think any 83xx cache-related patch is complete until MPC8349ITX.h includes CONFIG_MPC83xx. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http

[U-Boot] [PATCH] [v5] allow print_size to print large numbers on 32-bit systems

2010-04-13 Thread Timur Tabi
Modify print_size() so that it can accept numbers larger than 4GB on 32-bit systems. Add support for display terabyte, petabyte, and exabyte sizes. Change the output to use International Electrotechnical Commission binary prefix standard. Signed-off-by: Timur Tabi ti...@freescale.com

[U-Boot] [PATCH 2/2] [v6] allow print_size to print large numbers on 32-bit systems

2010-04-13 Thread Timur Tabi
Modify print_size() so that it can accept numbers larger than 4GB on 32-bit systems. Add support for display terabyte, petabyte, and exabyte sizes. Change the output to use International Electrotechnical Commission binary prefix standard. Signed-off-by: Timur Tabi ti...@freescale.com

[U-Boot] [PATCH 1/2] [v2] fix print_size printing fractional gigabyte numbers on 32-bit platforms

2010-04-13 Thread Timur Tabi
to disassociate this function from the size of a physical address. Signed-off-by: Timur Tabi ti...@freescale.com --- lib/display_options.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/display_options.c b/lib/display_options.c index 2dc2567..08a7914 100644 --- a/lib

Re: [U-Boot] [PATCH] [v3] fix print_size printing fractional gigabyte numbers on 32-bit platforms

2010-04-12 Thread Timur Tabi
On Fri, Apr 9, 2010 at 3:10 PM, Wolfgang Denk w...@denx.de wrote: Dear Timur Tabi, In message 1269990179-23666-1-git-send-email-ti...@freescale.com you wrote: In print_size(), the math that calculates the fractional remainder of a number used the same integer size as a physical address

Re: [U-Boot] [PATCH] allow print_size to print large numbers on 32-bit systems

2010-04-12 Thread Timur Tabi
on it now. I did notice something odd, though. The strings for sizes are GB, MB, and kB. Why is the k lowercase? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] allow print_size to print large numbers on 32-bit systems

2010-04-12 Thread Timur Tabi
that K=1024 when talking about memory sizes, but whatever) I've never seen K=1000 and k=1024. Then why don't we do mB instead of MB? By your logical, M=100 and m=1048576 -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U

Re: [U-Boot] [PATCH] allow print_size to print large numbers on 32-bit systems

2010-04-12 Thread Timur Tabi
Wolfgang Denk wrote: We should use standardized names now, i. e. GiB, MiB, KiB, etc. Ugh. I'm not sure everyone recognizes those acronyms. I'm expecting a lot of people to say, What the hell is MiB? Men in Black? -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] allow print_size to print large numbers on 32-bit systems

2010-04-12 Thread Timur Tabi
honestly believe that there was no confusion and that the introduction of KiB and its ilk just makes things worse, not better. No one is going to compare memory sizes in kilobytes with distances in kilometers and get confused. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] allow print_size to print large numbers on 32-bit systems

2010-04-12 Thread Timur Tabi
nor 1.44 MiB. Let's use the official standard units, please. We may not like them, but at least they will not cause a $125 million Mars orbiter to crash... Alright. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot

[U-Boot] [PATCH] [v2] allow print_size to print large numbers on 32-bit systems

2010-04-12 Thread Timur Tabi
Modify print_size() so that it can accept numbers larger than 4GB on 32-bit systems. Add support for display terabyte, petabyte, and exabyte sizes. Change the output to use International Electrotechnical Commission binary prefix standard. Signed-off-by: Timur Tabi ti...@freescale.com

[U-Boot] [PATCH] [v3] allow print_size to print large numbers on 32-bit systems

2010-04-12 Thread Timur Tabi
Modify print_size() so that it can accept numbers larger than 4GB on 32-bit systems. Add support for display terabyte, petabyte, and exabyte sizes. Change the output to use International Electrotechnical Commission binary prefix standard. Signed-off-by: Timur Tabi ti...@freescale.com

[U-Boot] [PATCH] [v4] allow print_size to print large numbers on 32-bit systems

2010-04-12 Thread Timur Tabi
Modify print_size() so that it can accept numbers larger than 4GB on 32-bit systems. Add support for display terabyte, petabyte, and exabyte sizes. Change the output to use International Electrotechnical Commission binary prefix standard. Signed-off-by: Timur Tabi ti...@freescale.com

Re: [U-Boot] [PATCH] allow print_size to print large numbers on 32-bit systems

2010-04-09 Thread Timur Tabi
Wolfgang Denk wrote: Dear Timur Tabi, In message 1269990179-23666-2-git-send-email-ti...@freescale.com you wrote: Modify print_size() so that it can accept numbers larger than 4GB on 32-bit systems. Signed-off-by: Timur Tabi ti...@freescale.com --- include/common.h |2

Re: [U-Boot] [PATCH] fsl-diu: Using I/O accessor to CCSR space

2010-04-08 Thread Timur Tabi
-specific sized integers. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-mpc85xx

2010-04-08 Thread Timur Tabi
On Wed, Apr 7, 2010 at 5:23 PM, Wolfgang Denk w...@denx.de wrote: Applied, thanks. Wolfgang, would you also please apply my two print_size() patches? They're not 85xx-specific, but I posted them to this list around the same time. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH v1 1/2] fsl_sata: Add the workaround for errata SATA-A001

2010-04-08 Thread Timur Tabi
On Thu, Apr 8, 2010 at 6:32 PM, Dave Liu dave...@freescale.com wrote: +#if defined(CONFIG_FSL_SATA_V2) defined(CONFIG_FSL_SATA_ERRATUM_A001) Is there ever a situation where CONFIG_FSL_SATA_ERRATUM_A001 is defined but CONFIG_FSL_SATA_V2 is not defined? -- Timur Tabi Linux kernel developer

Re: [U-Boot] [PATCH] POST: Added ECC memory test for mpc83xx.

2010-04-07 Thread Timur Tabi
direct writes and then follow-up with a sync(), as long as he comments it? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] fsl-diu: Using I/O accessor to CCSR space

2010-04-07 Thread Timur Tabi
thing here. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] POST: Added ECC memory test for mpc83xx.

2010-04-07 Thread Timur Tabi
for ppcDWstore: .globl ppcDWstore ppcDWstore: lfd 1, 0(r4) stfd1, 0(r3) blr I just don't understand why it exists. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http

Re: [U-Boot] [PATCH] POST: Added ECC memory test for mpc83xx.

2010-04-07 Thread Timur Tabi
On Wed, Apr 7, 2010 at 10:17 AM, Michael Zaidman michael.zaid...@gmail.com wrote: This is the fastest way to copy 64 bit words. Of course, DW==double word. I should drink more coffee. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot

Re: [U-Boot] [PATCH] POST: Added ECC memory test for mpc83xx.

2010-04-06 Thread Timur Tabi
why you're not using I/O accessors. At this point, I'm not 100% clear whether the use of volatile is okay. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] POST: Added ECC memory test for mpc83xx.

2010-04-06 Thread Timur Tabi
does this: static inline void sync(void) { __asm__ __volatile__ (sync : : : memory); } The memory tells the compiler that this function is a memory barrier, which means it won't try to reorder any reads/writes *after* the sync. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] POST: Added ECC memory test for mpc83xx.

2010-04-02 Thread Timur Tabi
On Fri, Apr 2, 2010 at 8:49 AM, Michael Zaidman michael.zaid...@gmail.com wrote: +inline static void ecc_clear(volatile ddr83xx_t *ddr) Please use I/O accessors instead of volatile. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot

[U-Boot] [PATCH] [v2] p2020ds: add alternate boot bank support using the ngPIXIS FPGA

2010-04-01 Thread Timur Tabi
a register dedicated for this purpose. Because the ngPIXIS is so different from the previous PIXIS, a new file is introduced: ngpixis.c. Also update the P2020DS checkboard() function to use the new macros defined in the header file. Signed-off-by: Timur Tabi ti...@freescale.com --- board/freescale

[U-Boot] [PATCH] [v2] fsl: improve the PIXIS code and fix a few bugs

2010-03-31 Thread Timur Tabi
to make it easier for specific boards to support variations in the PIXIS registers sets. No current boards appears to need this feature. Fix the definition of CONFIG_SYS_PIXIS_VBOOT_MASK for the MPC8610 HPCD. Apparently, pixis_reset altbank has never worked on this board. Signed-off-by: Timur Tabi ti

Re: [U-Boot] [PATCH v2] mpc86xx: set the DDR BATs after calculating true DDR size

2010-03-30 Thread Timur Tabi
(). -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] fix print_size printing fractional gigabyte numbers on 32-bit platforms

2010-03-30 Thread Timur Tabi
to disassociate this function from the size of a physical address. Signed-off-by: Timur Tabi ti...@freescale.com --- include/common.h |2 +- lib_generic/display_options.c |5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/include/common.h b/include/common.h

Re: [U-Boot] [PATCH] fix print_size printing fractional gigabyte numbers on 32-bit platforms

2010-03-30 Thread Timur Tabi
. I'll test 5.5GB and see what it does. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] fsl: improve the PIXIS code and fix a few bugs

2010-03-30 Thread Timur Tabi
On Wed, Mar 17, 2010 at 5:39 PM, Timur Tabi ti...@freescale.com wrote: Refactor and document the Freescale PIXIS code, used on most 85xx and 86xx boards.  This makes the code easier to read and more flexible. This patch breaks all 5121, because I forgot to modify diu.c. I'll post a new version

Re: [U-Boot] [PATCH] fix print_size printing fractional gigabyte numbers on 32-bit platforms

2010-03-30 Thread Timur Tabi
. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] [v2] fix print_size printing fractional gigabyte numbers on 32-bit platforms

2010-03-30 Thread Timur Tabi
to disassociate this function from the size of a physical address. Signed-off-by: Timur Tabi ti...@freescale.com --- include/common.h |2 +- lib_generic/display_options.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/common.h b/include/common.h

Re: [U-Boot] [PATCH] [v2] fix print_size printing fractional gigabyte numbers on 32-bit platforms

2010-03-30 Thread Timur Tabi
, there's a lot of value in being able to print 4GB numbers on a 32-bit system, and it seems silly to make two patches. I'll post a new patch, and Wolfgang can decide what he wants. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing

[U-Boot] [PATCH] [v3] fix print_size printing fractional gigabyte numbers on 32-bit platforms

2010-03-30 Thread Timur Tabi
to disassociate this function from the size of a physical address. Signed-off-by: Timur Tabi ti...@freescale.com --- lib_generic/display_options.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib_generic/display_options.c b/lib_generic/display_options.c index 2dc2567

[U-Boot] [PATCH] allow print_size to print large numbers on 32-bit systems

2010-03-30 Thread Timur Tabi
Modify print_size() so that it can accept numbers larger than 4GB on 32-bit systems. Signed-off-by: Timur Tabi ti...@freescale.com --- include/common.h |2 +- lib_generic/display_options.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/common.h

Re: [U-Boot] [PATCH v2] mpc86xx: set the DDR BATs after calculating true DDR size

2010-03-30 Thread Timur Tabi
it tell Linux that we have 1.5GB of DDR. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] mpc86xx: set the DDR BATs after calculating true DDR size

2010-03-30 Thread Timur Tabi
four BATS on the MPC8641 HPCN. Do we want to tell customers that U-Boot/Linux only supports power-of-two sizes of DDR? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u

Re: [U-Boot] [PATCH v2] mpc86xx: set the DDR BATs after calculating true DDR size

2010-03-30 Thread Timur Tabi
with the issue on both 86xx/44x/85xx I don't know about 44x, but like I said, I don't think it's a problem in 85xx, because we use up to 8 TLBs to map DDR, which is more than enough to cover all memory size possibilities. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH v2] mpc86xx: set the DDR BATs after calculating true DDR size

2010-03-30 Thread Timur Tabi
know. But please add a comment to the changelog and/or source code that it will limit DDR for U-Boot and Linux to the next lowest power of two. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http

Re: [U-Boot] [PATCH] mpc86xx: set the DDR BATs after calculating true DDR size

2010-03-30 Thread Timur Tabi
couldn't glean whether we need the M bit set to make DMA work. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] mpc86xx: set the DDR BATs after calculating true DDR size

2010-03-30 Thread Timur Tabi
sensical, and if you've got to change the patch, anyway, we might as well clean this up. I used a spreadsheet to help me figure out the algorithm, so I wouldn't say that 2 is more sensical, but I don't really care either way. I don't see how it improves the readability, though. -- Timur

[U-Boot] [PATCH] mpc86xx: adjust the DDR BATs after calculating true DDR size

2010-03-29 Thread Timur Tabi
). Signed-off-by: Timur Tabi ti...@freescale.com --- board/freescale/mpc8610hpcd/mpc8610hpcd.c |2 + board/freescale/mpc8641hpcn/mpc8641hpcn.c |2 + cpu/mpc86xx/cpu.c | 44 + include/asm-ppc/mmu.h |4 ++- include

Re: [U-Boot] [PATCH] mpc86xx: adjust the DDR BATs after calculating true DDR size

2010-03-29 Thread Timur Tabi
prefer to see symmetry here. I used KB to keep the sizes of numbers small. The smallest value is 128KB, so it's not *that* arbitrary. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de

Re: [U-Boot] [PATCH] mpc86xx: set the DDR BATs after calculating true DDR size

2010-03-29 Thread Timur Tabi
| BATU_VP) -#define CONFIG_SYS_IBAT0L      (BATL_PP_RW | BATL_MEMCOHERENCE ) -#define CONFIG_SYS_IBAT0U      CONFIG_SYS_DBAT0U +#define CONFIG_SYS_IBAT0L      (BATL_PP_RW | BATL_MEMCOHERENCE) Why do we need BATL_MEMCOHERENCE on 8641 but not on 8610? -- Timur Tabi Linux kernel developer

Re: [U-Boot] [PATCH] mpc8610hpcd: set the guarded bit to DBAT of system memory

2010-03-26 Thread Timur Tabi
that provides a real fix. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] fsl: improve the PIXIS code and fix a few bugs

2010-03-22 Thread Timur Tabi
On Wed, Mar 17, 2010 at 5:39 PM, Timur Tabi ti...@freescale.com wrote: Refactor and document the Freescale PIXIS code, used on most 85xx and 86xx boards.  This makes the code easier to read and more flexible. Kumar, please pick this up for the next merge window. Thanks. -- Timur Tabi Linux

[U-Boot] [PATCH] p2020ds: add alternate boot bank support using the ngPIXIS FPGA

2010-03-22 Thread Timur Tabi
a register dedicated for this purpose. Because the ngPIXIS is so different from the previous PIXIS, a new file is introduced: ngpixis.c. Also update the P2020DS checkboard() function to use the new macros defined in the header file. Signed-off-by: Timur Tabi ti...@freescale.com --- board/freescale

Re: [U-Boot] [PATCH] p2020ds: add alternate boot bank support using the ngPIXIS FPGA

2010-03-22 Thread Timur Tabi
CONFIG_FSL_PIXIS     1       /* use common PIXIS code */ +#define CONFIG_FSL_NGPIXIS             /* use common ngPIXIS code */ Please use TABs for vertical alignment. Please fix globally. Ok. -- Timur Tabi Linux kernel developer at Freescale ___ U

Re: [U-Boot] [PATCH 4/6] fsl_diu_fb.c: add support for RLE8 bitmaps

2010-03-21 Thread Timur Tabi
the diu driver to do so. Can you be more specific? What does the DIU driver do wrong? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] What is CONFIG_HAS_DATAFLASH?

2010-03-05 Thread Timur Tabi
CONFIG_HAS_DATAFLASH. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] What is CONFIG_HAS_DATAFLASH?

2010-03-05 Thread Timur Tabi
Wolfgang Denk wrote: Dear Timur Tabi, In message ed82fe3e1003050915r6e677102mb47a448293e62...@mail.gmail.com you wrote: Can someone tell me what CONFIG_HAS_DATAFLASH does? I know this sounds like an act of darin, but how about having a look at the README ? [And I really wonder why

Re: [U-Boot] What is CONFIG_HAS_DATAFLASH?

2010-03-05 Thread Timur Tabi
, you can't access flash. CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS will allow the saveenv command to continue working under this situation. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de

Re: [U-Boot] [PATCH v5] zlib: updated to v.1.2.3

2010-01-22 Thread Timur Tabi
1FFBE5A8 1FFC11F8 1FFA7338 1FF9F568 machine check My guess is that the machine check and the -2 error are related. Does anyone have a clue what the problem really is? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot

Re: [U-Boot] [PATCH v5] zlib: updated to v.1.2.3

2010-01-22 Thread Timur Tabi
= print hdbootarg hdbootarg=setenv bootargs root=$rfsdev console=$consoledev,$baudrate $othbootargs $single -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH 2/3] fsl_i2c: Add CONFIG_FSL_I2C_CUSTOM_{DFSR/FDR}

2009-09-17 Thread Timur Tabi
Joakim Tjernlund wrote: +#ifdef CONFIG_FSL_I2C_CUSTOM_FDR + fdr = CONFIG_FSL_I2C_CUSTOM_FDR; + speed = i2c_clk / divider; /* Fake something */ How about setting 'speed' to CONFIG_SYS_I2C_SPEED? -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH 2/2] fsl_i2c: Add CONFIG_FSL_I2C_CUSTOM_DFSR

2009-09-15 Thread Timur Tabi
that lets you change the speed. Otherwise, the code will have no idea what speed the bus is really running at. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] fsl_i2c: Add CONFIG_FSL_I2C_CUSTOM_DFSR

2009-09-15 Thread Timur Tabi
Joakim Tjernlund wrote: No, the impact on speed from DFSR is pretty small so it will be close enough. How small? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u

Re: [U-Boot] fsl_i2c: increase I2C timeout values and make them configurable

2009-09-14 Thread Timur Tabi
the value. The table is actually derived from the same algorithm. The problem with the table is that it does not allow for flexibility in choosing dfsr. When I implemented the table code, I did not think that this was a problem, but apparently it is. -- Timur Tabi Linux kernel developer

Re: [U-Boot] fsl_i2c: increase I2C timeout values and make them configurable

2009-09-11 Thread Timur Tabi
now. Sorry. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] fsl_i2c: increase I2C timeout values and make them configurable

2009-09-10 Thread Timur Tabi
that computed the values of fdr/dfsr. I nack'd that patch because I thought the algorithm was too convoluted, but perhaps what we really need is a combination of sorts. The code should read the value of DFSR from the register, and then calculate an appropriate FDR to go with it. -- Timur Tabi Linux

Re: [U-Boot] fsl_i2c: increase I2C timeout values and make them configurable

2009-09-10 Thread Timur Tabi
to change the code. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] fsl_i2c: increase I2C timeout values and make them configurable

2009-09-10 Thread Timur Tabi
that DFSR and FDR are just two values that work together to create a divider. Is there something special about DFSR? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u

Re: [U-Boot] fsl_i2c: increase I2C timeout values and make them configurable

2009-09-10 Thread Timur Tabi
of DFSR and FDR. The values of DFSR==22 are for frequencies that are normally not published. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] fsl_i2c: increase I2C timeout values and make them configurable

2009-09-10 Thread Timur Tabi
Joakim Tjernlund wrote: From AN2919, chap. 4.1: C = 50*T, C is dfsr and T is i2c_period in nano seconds. Argh, my copy of AN2919 is old! Mine doesn't have any of this stuff in it. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing

Re: [U-Boot] fsl_i2c: increase I2C timeout values and make them configurable

2009-09-09 Thread Timur Tabi
, I2C_WRITE_BIT, 0)) return -1; if (__i2c_write(a[4 - alen], alen) != alen) return -1; and so on. i = 0; /* No error so far */ -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http

Re: [U-Boot] [PATCH 2/2] fsl: add register read-back to set_law()

2009-09-05 Thread Timur Tabi
LAW-mapped memory right away might fail. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Odd value for I2C_TIMEOUT in fsl_i2c.c

2009-09-04 Thread Timur Tabi
always have been misinterpeted. I think the original code was correct, because it was counting clock ticks. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Odd value for I2C_TIMEOUT in fsl_i2c.c

2009-09-04 Thread Timur Tabi
Peter Tyser wrote: If this is the case, the timeout should be the maximum (or reasonable maximum) time an I2C transaction could take. How long is that? Is one millisecond good enough? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot

Re: [U-Boot] Odd value for I2C_TIMEOUT in fsl_i2c.c

2009-09-04 Thread Timur Tabi
is happier with 500 is a mystery to me. Also, should we be using the same value for the timeout in i2c_wait4bus() and i2c_wait()? It looks like i2c_wait() should have a much shorter timeout than i2c_wait4bus()? -- Timur Tabi Linux kernel developer at Freescale

[U-Boot] [PATCH 2/2] fsl: add register read-back to set_law()

2009-09-04 Thread Timur Tabi
After programming a new LAW, we should read-back the LAWAR register so that we sync the writes. Otherwise, code that attempts to use the new LAW-mapped memory might fail. Signed-off-by: Timur Tabi ti...@freescale.com --- drivers/misc/fsl_law.c |3 ++- 1 files changed, 2 insertions(+), 1

Re: [U-Boot] [PATCH 2/2] fsl: add register read-back to set_law()

2009-09-04 Thread Timur Tabi
On Fri, Sep 4, 2009 at 5:05 PM, Timur Tabiti...@freescale.com wrote: After programming a new LAW, we should read-back the LAWAR register so that we sync the writes.  Otherwise, code that attempts to use the new LAW-mapped memory might fail. Signed-off-by: Timur Tabi ti...@freescale.com Just

[U-Boot] Odd value for I2C_TIMEOUT in fsl_i2c.c

2009-09-03 Thread Timur Tabi
I2C_TIMEOUT 1000 Surely, one millisecond is not too long of a timeout? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] fsl: sys_eeprom: Fix 'may be used uninitialized' warning

2009-09-01 Thread Timur Tabi
that any of Freescale's 8[356]xx boards can't handle a large I2C block write of about 50 bytes or so? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] fsl: sys_eeprom: Fix 'may be used uninitialized' warning

2009-09-01 Thread Timur Tabi
Anton Vorontsov wrote: p.s. Timur, since the patch has changed, I couldn't preserve your previous Ack. I'm okay with this version, too. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http

[U-Boot] [PATCH v2] fsl: simplify the mac id command, improve boot-time informational message

2009-08-28 Thread Timur Tabi
after any field is changed, so that the CRC is always correct. Signed-off-by: Timur Tabi ti...@freescale.com --- board/freescale/common/sys_eeprom.c | 81 +-- 1 files changed, 49 insertions(+), 32 deletions(-) diff --git a/board/freescale/common/sys_eeprom.c b

Re: [U-Boot] [PATCH] fsl: simplify the mac id command, improve boot-time informational message

2009-08-27 Thread Timur Tabi
Wolfgang? Are you okay with this part of my patch? On Wed, Aug 19, 2009 at 9:40 AM, Kumar Galaga...@kernel.crashing.org wrote: On Aug 18, 2009, at 5:28 PM, Timur Tabi wrote: The mac id command took a 4-character parameter as the identifier string. However, for any given board, only one

Re: [U-Boot] [PATCH 2/2] e1000: fix PCI memory addressing

2009-08-24 Thread Timur Tabi
. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] e1000: fix PCI memory addressing

2009-08-22 Thread Timur Tabi
Unless you're talking about the summary. I figured the changes were harmless and just added them as a freebie. It's not worth submitting a different patch for just these. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot

[U-Boot] [PATCH] e500: improve MPIC initialization

2009-08-20 Thread Timur Tabi
The MPIC initialization code for Freescale e500 CPUs was not using I/O accessors, and it was not issuing a read-back to the MPIC after setting mixed mode. This may be the cause of a spurious interrupt on some systems. Signed-off-by: Timur Tabi ti...@freescale.com --- cpu/mpc85xx/interrupts.c

Re: [U-Boot] [PATCH] e500: improve MPIC initialization

2009-08-20 Thread Timur Tabi
. Signed-off-by: Timur Tabi ti...@freescale.com The git summary should be 85xx: ... not e500: Kumar, please amend the title if you apply this patch. Thanks. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de

[U-Boot] [PATCH] fsl: simplify the mac id command, improve boot-time informational message

2009-08-18 Thread Timur Tabi
after any field is changed, so that the CRC is always correct. Signed-off-by: Timur Tabi ti...@freescale.com --- board/freescale/common/sys_eeprom.c | 79 +-- lib_ppc/board.c |1 + 2 files changed, 48 insertions(+), 32 deletions(-) diff

[U-Boot] [PATCH 2/2] e1000: fix PCI memory addressing

2009-08-17 Thread Timur Tabi
The Intel E1000 driver was making assumptions about the relationship between some virtual, physical, and PCI addresses. Also fix some bad usage of the DEBUGOUT macro Signed-off-by: Timur Tabi ti...@freescale.com --- drivers/net/e1000.c | 17 + 1 files changed, 9 insertions

Re: [U-Boot] [PATCH 2/2] e1000: fix PCI memory addressing

2009-08-17 Thread Timur Tabi
-off-by: Timur Tabi ti...@freescale.com -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Make TFTP Quiet

2009-08-10 Thread Timur Tabi
feels wrong. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] PLATFORM_CPPFLAGS ?

2009-08-06 Thread Timur Tabi
. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-mpc83xx

2009-07-29 Thread Timur Tabi
web page would allow other people to tag their patches for you. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Please pull u-boot-mpc85xx (updated)

2009-07-24 Thread Timur Tabi
was going to review this patch, but it's not in his 'net' git repository. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] MPC8377EWLAN: Fix DDR configuration bug

2009-07-14 Thread Timur Tabi
to fix the bug that u-boot and kernel can not smoothly work because of insufficient DDR2 chip output strength. The setting of DDR2 output strength is changed from reduced to full status. You forgot a Signed-off-by: line here. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH 1/2] Add ntel PCIE PRO/1000 Network Driver support

2009-07-13 Thread Timur Tabi
after it's been approved here. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3] remove _IO_BASE and KSEG1ADDR from board configuration files

2009-07-09 Thread Timur Tabi
no longer need to define it. The _IO_BASE macro is also automatically defined to 0 if it isn't already set, so there's no need to define that macro either in the board configuration files. Signed-off-by: Timur Tabi ti...@freescale.com Acked-by: Nobuhiro Iwamatsu iwama...@nigauri.org Acked

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-19 Thread Timur Tabi
2009/6/19 André Schwarz andre.schw...@matrix-vision.de: MVBLM7 is mpc8343 ... please apply your patch. I posted another version of my patch that include MVBLM7. Please ACK that patch. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot

Re: [U-Boot] [PATCH] [PATCH v2] remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-19 Thread Timur Tabi
Kim Phillips wrote: -#define _IO_BASE0xfe00 /* points to PCI I/O space */ - but the PN62 doesn't set it to 0! Doh! I don't know how I missed that. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing

[U-Boot] [PATCH v3] remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-19 Thread Timur Tabi
to define that macro either in the board configuration files. Signed-off-by: Timur Tabi ti...@freescale.com Acked-by: Nobuhiro Iwamatsu iwama...@nigauri.org Acked-by: Andy Fleming aflem...@freescale.com Acked-by: Andre Schwarz andre.schw...@matrix-vision.de --- v3: removed the change for PN62.h, which

[U-Boot] [PATCH] [PATCH v2] remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-17 Thread Timur Tabi
to define that macro either in the board configuration files. Signed-off-by: Timur Tabi ti...@freescale.com --- include/configs/HIDDEN_DRAGON.h |4 +--- include/configs/M5253DEMO.h |1 - include/configs/M5253EVBE.h |1 - include/configs/M54455EVB.h |1 - include/configs

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Timur Tabi
Kim Phillips wrote: it's missing other boards like the MVBLM7, mpc7448hpc2... I'm not familiar with those boards, so I didn't touch them. If you give me a list of which boards I should add, I can post an updated version of the patch. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Timur Tabi
are: HIDDEN_DRAGON.h M5253DEMO.h M5253EVBE.h M54455EVB.h mpc7448hpc2.h MVBLM7.h PN62.h r2dplus.h I think all but the last are PPC boards. Should I include those? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Timur Tabi
Ok, I need a consensus. It's not clear to me if I should post a patch that 1) Updates only FSL boards 2) Updates all PPC boards 3) Updates all boards -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Timur Tabi
#define _IO_BASE0x #define KSEG1ADDR(x)(x) So PPC isn't the only architecture affected by this. However, since I don't have an SH cross-compiler, I can't test it. -- Timur Tabi Linux kernel developer at Freescale

<    1   2   3   4   5   6   7   >