[U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-15 Thread Timur Tabi
to define that macro either in the board configuration files. Signed-off-by: Timur Tabi ti...@freescale.com --- include/configs/MPC8349ITX.h |7 --- include/configs/MPC8536DS.h |6 -- include/configs/MPC8544DS.h |6 -- include/configs/MPC8572DS.h |6 -- include

Re: [U-Boot] [PATCH 00/11] 85xx/86xx dma updates

2009-05-26 Thread Timur Tabi
, while the 85xx is all big-endian. 83xx DMA = Elo DMA controller 85xx/86xx DMA = Elo Plus DMA controller The Elo Plus supports list descriptors in addition to link descriptors. The Elo only supports link descriptors. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] 85xx: Always attempt ethernet device tree fixup

2009-05-21 Thread Timur Tabi
ethernet nodes that match (or aliases) we will not attempt to do anything. Signed-off-by: Kumar Gala ga...@kernel.crashing.org Acked-by: Timur Tabi ti...@freescale.com -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot

Re: [U-Boot] [PATCH 10/15 v2] Update the number of ethxaddr in reading system eeprom

2009-05-21 Thread Timur Tabi
address is greater than %u, force it to %u.\n, MAX_NUM_PORTS, MAX_NUM_PORTS); But since you defined MAX_NUM_PORTS, you should also do this: u8 mac[MAX_NUM_PORTS][6]; /* 0x42 - 0x71 MAC addresses */ To indicate where the dependency on 8 comes from. -- Timur Tabi Linux

Re: [U-Boot] Cross-compiling U-Boot on Mac OS X -- can't find crc32.c?

2009-05-20 Thread Timur Tabi
On Wed, May 20, 2009 at 12:31 AM, Wolfgang Denk w...@denx.de wrote: It's you who has OS X, and who has a problem. Only when Ah itchez, Ah scratchez. Just so I'm clear on this, you're saying that you're not really concerned about how well U-Boot works for other people? -- Timur Tabi Linux

Re: [U-Boot] Cross-compiling U-Boot on Mac OS X -- can't find crc32.c?

2009-05-20 Thread Timur Tabi
understand how it works when it *does* work. A functioning build process on OS X will allow me to do more work on U-Boot, adding more features and fixing more bugs, than I normally would be able to do. But I can't fix every problem myself. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] Cross-compiling U-Boot on Mac OS X -- can't find crc32.c?

2009-05-19 Thread Timur Tabi
. The kernel is orders of magnitude more complex than U-Boot, and yet I can build it just fine on OS X. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] uboot relocate_code() function

2009-05-11 Thread Timur Tabi
relocate_code * -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Cross-compiling U-Boot on Mac OS X -- can't find crc32.c?

2009-05-05 Thread Timur Tabi
On Mon, May 4, 2009 at 7:47 PM, Mike Frysinger vap...@gentoo.org wrote: On Monday 04 May 2009 09:27:11 Timur Tabi wrote: On Fri, May 1, 2009 at 7:10 PM, Jean-Christophe wrote: to compile on Mac OS you will have to move to the laster Mainline , What is that? the latest git source tree

Re: [U-Boot] Cross-compiling U-Boot on Mac OS X -- can't find crc32.c?

2009-05-04 Thread Timur Tabi
On Fri, May 1, 2009 at 7:10 PM, Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: to compile on Mac OS you will have to move to the laster Mainline , What is that? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list

Re: [U-Boot] Cross-compiling U-Boot on Mac OS X -- can't find crc32.c?

2009-05-02 Thread Timur Tabi
, that would be okay for now. But according to Jean-Chrisophe's email, it looks like this would be not be trivial to fix. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman

[U-Boot] Cross-compiling U-Boot on Mac OS X -- can't find crc32.c?

2009-05-01 Thread Timur Tabi
it doesn't compile. Has anyone tried this before? What am I missing? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] recommended place to identify hardware using i2c-eeprom data.

2009-04-16 Thread Timur Tabi
trying to do. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/7] Remove individual I2C commands and cleanup

2009-04-16 Thread Timur Tabi
the individual commands. I reviewed the code briefly, and it looks okay. The general idea is good, so I ACK these patches. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman

Re: [U-Boot] DBCR0 reset problem in MPC8548CDS

2009-04-16 Thread Timur Tabi
*) (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_GBL_DATA_OFFSET); That usually means that your LAWBARs are misprogrammed. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] net: fix ULI 526x macro usage in netdev.h

2009-04-09 Thread Timur Tabi
Change netdev.h to use CONFIG_ULI526X instead of CONFIG_ULI526. CONFIG_ULI526X is used everywhere else, so that's the correct macro name. Without this fix, Ethernet will not work on the Freescale MPC8610 HPCD. Signed-off-by: Timur Tabi ti...@freescale.com --- include/netdev.h |2 +- 1

Re: [U-Boot] [PATCH] Add I2C speed and divider formula for ColdFire

2009-04-09 Thread Timur Tabi
? I don't think accuracy is that important. The advantage of a table is that it's easier to debug and the code is simpler. I'm inclined to NACK this patch. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] use of C99

2009-04-08 Thread Timur Tabi
are it's not even going to define stack space for it. #ifdef CONFIG_COOL_FEATURE        {                u32 myvarrocks = foo * bar * bar;                gd-neato = myvarrocks        } #endif Is this an acceptable compromise? This is what we do today, and I think it's ugly. -- Timur Tabi Linux

Re: [U-Boot] use of C99

2009-04-08 Thread Timur Tabi
(for understanding). Sorry, I don't understand what you're talking about. The #ifdefs are used to enable feature-specific code on platforms that have that feature. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http

Re: [U-Boot] use of C99

2009-04-08 Thread Timur Tabi
. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] use of C99

2009-04-08 Thread Timur Tabi
be variables declared at the top of iterators. That's just my two cents. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] use of C99

2009-04-08 Thread Timur Tabi
ugly than variable declarations right in the middle of 200 lines of code. This is where I disagree. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] use of C99

2009-04-08 Thread Timur Tabi
to get to work. The person who has a car is obviously going to tell you that your life will be easier if you get a car also. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo

Re: [U-Boot] [PATCH 2/3] MPC85xx: Load and enable QE microcode patch in IRAM

2009-03-27 Thread Timur Tabi
hillel.a...@freescale.com Just for the record: Acked-by: Timur Tabi ti...@freescale.com -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] MPC8572E I2C bus speed after emulator reset

2009-03-27 Thread Timur Tabi
represent, according to the table, a divider of 768. The RM also says that I2C clock is 1/2 CCB, so that means that your CCB should be 400,000 * 768 * 2 = 614MHz. Is that right? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U

Re: [U-Boot] [PATCH 4/9 v3] 83xx, i2c: add mux support for fsl_i2c

2009-02-25 Thread Timur Tabi
hope I can retrigger it. I was willing to write a lot of the code to implement that change (getting rid of i2c_xxx_bus_num), but aer Wolfgang shot it down, I gave up. If you do manage to turn the tide, let me know. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH 4/9 v3] 83xx, i2c: add mux support for fsl_i2c

2009-02-23 Thread Timur Tabi
On Thu, Feb 19, 2009 at 10:24 AM, Heiko Schocher h...@denx.de wrote: Signed-off-by: Heiko Schocher h...@denx.de --- Could you add a description that says what I2C mux support is? That would make it easier to review this patch. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH v3] MPC8349ITX: several config issues fixed

2009-02-17 Thread Timur Tabi
On Tue, Feb 17, 2009 at 3:49 PM, Kumar Gala ga...@kernel.crashing.org wrote: The default value is 256M so I don't thing the change is need anymore. Huh? I think his patch is supposed to address the fact that 256MB is the limit, and he wants to add more. -- Timur Tabi Linux kernel developer

Re: [U-Boot] [PATCH 17/40] Blackfin: overhaul i2c driver

2009-02-11 Thread Timur Tabi
On Wed, Feb 11, 2009 at 5:58 PM, Mike Frysinger vap...@gentoo.org wrote: will you post a patch to fix the issue or shall i ? I'd rather you do it, because then you can test the code to make sure it really works. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH v3] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

2008-12-16 Thread Timur Tabi
board specific file. Ugh. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

2008-12-16 Thread Timur Tabi
the idea of a current i2c bus is a bad one. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

2008-12-16 Thread Timur Tabi
I2C design. You guys obviously have everything under control, so good luck. -- Timur Tabi Linux Kernel Developer @ Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

2008-12-15 Thread Timur Tabi
low-priority for me, though. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v3] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

2008-12-03 Thread Timur Tabi
All implementations of the functions i2c_reg_read() and i2c_reg_write() are identical. We can save space and simplify the code by converting these functions into inlines and putting them in i2c.h. Signed-off-by: Timur Tabi [EMAIL PROTECTED] --- v3: add 8xx-specific code, and include PRINTDs

[U-Boot] What is NetState?

2008-12-03 Thread Timur Tabi
Is there any documentation for this global variable? I'm trying to fix a bug in NetStartAgain(), and I'm trying to understand the purpose of this variable. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de

[U-Boot] i2c_reg_read() on 8xx

2008-10-22 Thread Timur Tabi
, CONFIG_SYS_I2C_SLAVE); i2c_read(i2c_addr, reg, 1, buf, 1); return (buf); } Is the call to i2c_init() necessary on 8xx boards? Shouldn't I2C have already been initialized? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U

Re: [U-Boot] [PATCH] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

2008-10-20 Thread Timur Tabi
Mike Frysinger wrote: dont wait ... it'll be a bit before i post it, so it'll be easier if i just rebase against that If I post the patch that assumes that that i2c_reg_read() passes 1 instead of 0, it'll break blackfin. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] [PATCH] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

2008-10-19 Thread Timur Tabi
you? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] 85xx: properly document MPC85xx_PORDEVSR2_SEC_CFG

2008-10-18 Thread Timur Tabi
(bit 28)? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2][for v2008.10] 85xx: Using proper I2C source clock divider for MPC8544

2008-10-17 Thread Timur Tabi
. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2][for v2008.10] 85xx: Using proper I2C source clock divider for MPC8544

2008-10-17 Thread Timur Tabi
, and just say that code comments are unnecessary because the git log contains everything we need to know? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

2008-10-05 Thread Timur Tabi
-boot/2008-October/041173.html On Thu, Oct 2, 2008 at 10:06 AM, Timur Tabi [EMAIL PROTECTED] wrote: All implementations of the functions i2c_reg_read() and i2c_reg_write() are identical. We can save space and simplify the code by converting these functions into inlines and putting them in i2c.h

Re: [U-Boot] [PATCH] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

2008-10-04 Thread Timur Tabi
: alignment. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] i2c: merge all i2c_reg_read() and i2c_reg_write() into inline functions

2008-10-03 Thread Timur Tabi
Wolfgang, Who is the maintainer for I2C? I don't know who needs to ACK this patch for it to go in, and I don't know who's supposed to pick it up, either. On Thu, Oct 2, 2008 at 10:06 AM, Timur Tabi [EMAIL PROTECTED] wrote: All implementations of the functions i2c_reg_read() and i2c_reg_write

<    2   3   4   5   6   7