Re: [U-Boot] xyz-modem: Change getc timeout loop waiting

Hi, On 08/01/2018 08:54 AM, Alexander Sverdlin wrote: Is the timeout a watchdog timeout or some communication freeze? I suppose, it reports false-positive timeout back to ymodem code. Because all it does is terminating communication gracefully (with 'C' and a bunch of CANs). If you are using

Re: [U-Boot] xyz-modem: Change getc timeout loop waiting

Hi, On 08/01/2018 03:15 AM, Alexander Sverdlin wrote: This commit breaks YMODEM SPL->U-Boot boot on Beagle Bone, transfer is aborted (because of timeout) after 497kb (u-boot.img is around 570kb). Reverting the commit repairs YMODEM boot. Is the timeout a watchdog timeout or some

Re: [U-Boot] [PATCH] SPL: Add FIT data-position property support

<fcoo...@ti.com> > Cc: George McCollister <george.mccollis...@gmail.com> > Cc: Tuomas Tynkkynen <tuomas.tynkky...@iki.fi> > Cc: Jean-Jacques Hiblot <jjhib...@ti.com> > Cc: Rick Altherr <ralth...@google.com> > Cc: Tom Rini <tr...@konsulko.com> >

[U-Boot] [PATCH] splash_source: Verify FIT magic

e. Cc: Anatolij Gustschin <ag...@denx.de> Acked-by: Tomas Melin <tomas.me...@vaisala.com> --- common/splash_source.c | 5 + 1 file changed, 5 insertions(+) diff --git a/common/splash_source.c b/common/splash_source.c index 867a798..30e6a0d 100644 --- a/common/splash_sou

[U-Boot] [PATCH] cosmetic: bootcount: correct comment for used scratch register

Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- drivers/bootcount/bootcount_davinci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/bootcount/bootcount_davinci.c b/drivers/bootcount/bootcount_davinci.c index fa87b5e..17829be 100644 --- a/d

Re: [U-Boot] [PATCH v3 1/2] common: image: update boot_get_fpga to support arbitrary fpga image

Hi Dalon, On 02/22/2017 06:00 AM, Simon Glass wrote: > Hi Dalon, > > On 20 February 2017 at 07:56, Dalon Westergreen wrote: >> The implementation of boot_get_fpga only supported one fpga family. >> This modification allows for any of the fpga devices supported by >>

Re: [U-Boot] [PATCH v2] splash: fix splash source flags check

is defined as 0, so a check against & will > never be true. These flags are never combined so do a check > against == instead. > > Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> > Reviewed-by: Tom Rini <tr...@konsulko.com> > --- > > Changes in v2: >

[U-Boot] [PATCH v5 1/2] splash: sort include files

Sort include files in accordance to U-Boot coding style. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- Changes in v5: - None Changes in v4: - Added missing changelog Changes in v3: - Change patch order so that include sort patch comes prior to adding new include Changes

[U-Boot] [PATCH v5 2/2] splash: add support for loading splash from a FIT image

Enable support for loading a splash image from within a FIT image. The image is assumed to be generated with mkimage -E flag to hold the data external to the FIT. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- Changes in v5: - Change two debug() statements to use printf(),

Re: [U-Boot] [PATCH v4 2/2] splash: add support for loading splash from a FIT image

Hi Igor, Simon, On 12/26/2016 09:24 AM, Igor Grinberg wrote: > Hi Tomas, > > Sorry for the late response... > > On 12/20/16 07:29, Tomas Melin wrote: >> Hi Igor, Simon, >> >> On 12/15/2016 11:08 AM, Igor Grinberg wrote: >>> Hi Tomas, >>> >

Re: [U-Boot] [PATCH v4 2/2] splash: add support for loading splash from a FIT image

Hi Igor, Simon, On 12/15/2016 11:08 AM, Igor Grinberg wrote: > Hi Tomas, > > On 12/14/16 16:23, Tomas Melin wrote: >> Hi Simon, Igor, >> >> On 12/14/2016 02:53 PM, Igor Grinberg wrote: >>> On 12/13/16 22:29, Simon Glass wrote: >>>>>>&

Re: [U-Boot] [PATCH v4 2/2] splash: add support for loading splash from a FIT image

Hi Simon, Igor, On 12/14/2016 02:53 PM, Igor Grinberg wrote: > On 12/13/16 22:29, Simon Glass wrote: > > I think two above debug() are very legitimate - no need to shout if no > FIT image > or no splash in it... > >> + res = fit_image_get_data_offset(fit_header,

[U-Boot] [PATCH v4 2/2] splash: add support for loading splash from a FIT image

Enable support for loading a splash image from within a FIT image. The image is assumed to be generated with mkimage -E flag to hold the data external to the FIT. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- Changes in v4: - Added missing changelog Changes in v3: - Add documen

[U-Boot] [PATCH v4 1/2] splash: sort include files

Sort include files in accordance to u-boot coding style. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- Changes in v4: - Added missing changelog Changes in v3: - Change patch order so that include sort patch comes prior to adding new include Changes in v2: - Add separate

[U-Boot] [PATCH v3 2/2] splash: add support for loading splash from a FIT image

Enable support for loading a splash image from within a FIT image. The image is assumed to be generated with mkimage -E flag to hold the data external to the FIT. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- common/image-fit.c | 48

[U-Boot] [PATCH v3 1/2] splash: sort include files

Sort include files in accordance to u-boot coding style. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- common/splash_source.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/common/splash_source.c b/common/splash_source.c index d300e46..70d724f

Re: [U-Boot] [PATCH v2 1/2] splash: add support for loading splash from a FIT image

Hi Simon, On 11/29/2016 11:40 PM, Simon Glass wrote: > Hi Tomas, > > On 25 November 2016 at 02:45, Tomas Melin <tomas.me...@vaisala.com> wrote: >> Enable support for loading a splash image from within a FIT image. >> The image is assumed to be generated with mkimage

Re: [U-Boot] [PATCH v3] mmc: add bkops-enable command

Hi Jaehoon, On 11/28/2016 06:58 AM, Jaehoon Chung wrote: > > Applied on u-boot-mmc. > Before applied this patch from patchwork, i changed Author from your email to > your name, is it ok? > Thanks! Yes that is perfectly ok. BR, Tomas ___ U-Boot

[U-Boot] [PATCH v2 1/2] splash: add support for loading splash from a FIT image

Enable support for loading a splash image from within a FIT image. The image is assumed to be generated with mkimage -E flag to hold the data external to the FIT. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- common/image-fit.c | 49 ++

[U-Boot] [PATCH v2 2/2] splash: sort include files

Sort include files in accordance to u-boot coding style. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- common/splash_source.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/common/splash_source.c b/common/splash_source.c index 9ca523d..4

Re: [U-Boot] [PATCH] splash: add support for loading splash from a FIT image

Hi Simon, On 11/24/2016 04:20 AM, Simon Glass wrote: >> diff --git a/common/splash_source.c b/common/splash_source.c >> index 72df2c1..d72aee1 100644 >> --- a/common/splash_source.c >> +++ b/common/splash_source.c >> @@ -16,6 +16,7 @@ >> #include >> #include >> #include >> +#include > >

[U-Boot] [PATCH v3] mmc: add bkops-enable command

. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- cmd/Kconfig | 9 + cmd/mmc.c | 32 drivers/mmc/mmc.c | 34 ++ include/mmc.h | 6 ++ 4 files changed, 81 insertions(+) diff --git a/cmd/Kconfig

Re: [U-Boot] [PATCH v2] mmc: add bkops-enable command

Hi Jaehoon, On 11/25/2016 09:47 AM, Jaehoon Chung wrote: > Hi Tomas, > > On 11/25/2016 04:32 PM, Tomas Melin wrote: >> Add new command that provides possibility to enable the >> background operations handshake functionality >> (BKOPS_EN, EXT_CSD

Re: [U-Boot] [RFC PATCH 1/1] Read mmc device memory capacity from EXT_CSD if memory is addressed by sector

Hi Jaehoon, On 11/24/2016 03:55 AM, Jaehoon Chung wrote: > Hi Tomas, > > On 11/23/2016 10:04 PM, Tomas Melin wrote: >> Hi, >> >> We have successfully been using this patch to fix the problem mentioned in >> the >> original message. Could this be picke

[U-Boot] [PATCH] Read mmc device memory capacity from EXT_CSD if memory is addressed by sector

From: Frank Bormann Hello Everyone, I believe, there is a bug in the mmc driver code pertaining to how u-boot detects memory size of an mmc device. However, I am not 100% sure, my solution conforms to the JEDEC standard. So I am putting it up for discussion. Previously,

[U-Boot] [PATCH v2] mmc: add bkops-enable command

. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- cmd/Kconfig | 7 +++ cmd/mmc.c | 32 drivers/mmc/mmc.c | 32 include/mmc.h | 6 ++ 4 files changed, 77 insertions(+) diff --git a/cmd/Kconfig

Re: [U-Boot] [RFC PATCH 1/1] Read mmc device memory capacity from EXT_CSD if memory is addressed by sector

Hi, We have successfully been using this patch to fix the problem mentioned in the original message. Could this be picked up upstream? BR, Tomas On Wed Feb 5 21:00:42 CET 2014, Frank Bormann wrote: >Hello Everyone, > >I believe, there is a bug in the mmc driver code pertaining to how u-boot

[U-Boot] [PATCH] post: cosmetic: fix typo

From: Niko Mauno <niko.ma...@vaisala.com> Change 'date' to 'data'. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- post/drivers/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/post/drivers/memory.c b/post/drivers/memory.c index d512fa5..89

Re: [U-Boot] mmc: add bkops-enable command

Hi Jaehoon, On 11/23/2016 11:53 AM, Jaehoon Chung wrote: > On 11/21/2016 04:52 PM, Tomas Melin wrote: >> Is your meaning by this that you think that the kernel driver implementation >> is insufficient, and that you therefore do not recommmend using bkops >> functionality

[U-Boot] [PATCH] splash: add support for loading splash from a FIT image

Enable support for loading a splash image from within a FIT image. The image is assumed to be generated with mkimage -E flag to hold the data external to the FIT. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- common/splash_source.

[U-Boot] [PATCH] xyz-modem: Change getc timeout loop waiting

(). Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- common/xyzModem.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/common/xyzModem.c b/common/xyzModem.c index 5656aac..e0d87db 100644 --- a/common/xyzModem.c +++ b/common/xyzModem.c @@ -71,12

Re: [U-Boot] mmc: add bkops-enable command

Hi Jaehoon, On 11/18/2016 07:07 AM, Jaehoon Chung wrote: >> On 11/16/2016 03:39 PM, Jaehoon Chung wrote: >>> >>> On 11/16/2016 10:12 PM, Tomas Melin wrote: >>>> Hi, >>>> >>>> On 11/16/2016 02:05 PM, Jaehoon Chung wrote: >>>&

Re: [U-Boot] mmc: add bkops-enable command

Hi, Thank you for your valuable comments and for taking the time to respond. Please see below for further comments. On 11/16/2016 03:39 PM, Jaehoon Chung wrote: > > On 11/16/2016 10:12 PM, Tomas Melin wrote: >> Hi, >> >> On 11/16/2016 02:05 PM, Jaehoon Chung wrote:

Re: [U-Boot] mmc: add bkops-enable command

adds to that same palette of commands that are needed when properly configuring an eMMC device. One possible option going forward could be putting all eMMC-configure related commands behind a common CONFIG_ option. BR, Tomas > >> >> Signed-off-by: Tomas Melin <tomas.me.

[U-Boot] [PATCH] spl: remove redundant call to parse_image_header()

Image header was checked twice. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- common/spl/spl_ymodem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/common/spl/spl_ymodem.c b/common/spl/spl_ymodem.c index 13e8e51..957894d 100644 --- a/common/spl/spl_ymodem.c +++ b/comm

[U-Boot] [PATCH] splash: fix splash source flags check

SPLASH_STORAGE_RAW is defined as 0, so a check against & will never be true. These flags are never combined so do a check against == instead. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- common/splash_source.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

[U-Boot] [PATCH] spl: add check for FIT-header when loading image

Add check for FDT_MAGIC, otherwise also legacy images will be loaded as a FIT. With this check in place, the loader works correct both with legacy and FIT images. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- common/spl/spl_spi.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

[U-Boot] [PATCH] mmc: add bkops-enable command

Add new command for enabling the background operations handshake functionality (BKOPS_EN, EXT_CSD byte [163]) on eMMC devices. This is an optional feature of eMMCs, the setting is write-once. Signed-off-by: Tomas Melin <tomas.me...@vaisala.com> --- cmd/mmc.c