Hi Joe!
...
> > +1 from me as well.
...
> > Joe, whats your opinion on this?
...
> Do we really think this is a strong use-case? This seem like the type of
> thing I
> would expect to tweak for testing through mii / mdio commands and then
> configure the device tree based on that. This is prett
> No. But with your comments above (which make total sense), I tend to NAK
> this ability to configure the PHY skew timings via environment variables.
Understood, I'll focus on the devicetree implementation and a README to help
non-expert users use the MII command for board bringup & debug p
Hi Stefan
> >
> > Setting the skews in DT would indeed be preferable in my opinion.
> +1 from me.
Agreed. I'll focus on a devicetree based implementation, and editing phy values
during board debug and bringup can be addressed with debug/development notes.
I'd be willing to publish these somewh
Hi Marek! Comments and answers follow
> Hi Vince!
> > > We already do this kind of a programming in
> > > board/altera/socfpga/socfpga.c in board_phy_config(), don't we ?
> >
> > Yes, good point. This patch series is a first in some upcoming patches to
> > make this better. The Linux implemen
Hi Marek!
> We already do this kind of a programming in board/altera/socfpga/socfpga.c
> in board_phy_config(), don't we ?
Yes, good point. This patch series is a first in some upcoming patches to make
this better. The Linux implementation uses devicetree settings to set the
skews, so if we wer
This patch adds a function to read a signed integer from the uboot environment
for the Micrel ksz9031 Phy driver to read postive and negatice skew values
from the uboot environment.
Signed-off-by: Vince Bridgers
---
common/cmd_nvedit.c | 22 +-
include/common.h| 1 +
2
Micrel devicetree settings when that is eventually supported.
Vince Bridgers (2):
cmd: Add getenv_long to support reading signed integers from the uboot
env
net: phy: Add ability to program the ksz9031 skew values from the
uboot env
common/cmd_nvedit.c | 22 +++-
drivers/net
values may be negative or positive, therefore depends on UBoot environment
support to read positive or negative values in units of picoseconds.
Signed-off-by: Vince Bridgers
---
drivers/net/phy/micrel.c | 299 ++-
1 file changed, 298 insertions(+), 1
8 matches
Mail list logo
