Re: [U-Boot] [RFC PATCH 1/7] dm: usb: Add a uclass for USB controllers

2015-03-09 Thread Vivek Gautam
sb_dev[usb->dev_index].devnum = -1; > +} > + > +UCLASS_DRIVER(usb) = { > + .id = UCLASS_USB, > + .name = "usb", > + .flags = DM_UC_FLAG_SEQ_ALIAS, > +/* > + .child_pre_probe = usb_child_

Re: [U-Boot] [RFC PATCH 1/7] dm: usb: Add a uclass for USB controllers

2015-03-09 Thread Vivek Gautam
Hi, On Mon, Mar 9, 2015 at 11:50 AM, Vivek Gautam wrote: Sorry i was in the middle of adding comment and the message just got sent. I will add other comments here. > Hi Simon, > > > On Sat, Jan 31, 2015 at 12:34 AM, Simon Glass wrote: >> Add a uclass that can represent a U

Re: [U-Boot] [RFC PATCH 3/7] dm: usb: Adjust users of the USB stack to work with driver model

2015-02-25 Thread Vivek Gautam
ev, fdt_addr_t *hccrp, > + fdt_addr_t *hcorp); > + int (*control)(struct udevice *dev, struct usb_device *udev, > + unsigned long pipe, void *buffer, int length, > + struct devrequest *setup)

Re: [U-Boot] [RFC PATCH 0/7] RFC: dm: Add USB support

2015-02-25 Thread Vivek Gautam
sb/dev/usb-emul-uclass.c > create mode 100644 drivers/usb/host/usb-sandbox.c > create mode 100644 drivers/usb/host/usb-uclass.c > > -- > 2.2.0.rc0.207.ga3a616c > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH RFC v2 0/6] usb: host: Add driver model support

2015-02-24 Thread Vivek Gautam
Hi Simon, On Tue, Feb 24, 2015 at 10:17 PM, Simon Glass wrote: > Hi Vivek, > > On 18 February 2015 at 06:30, Vivek Gautam wrote: >> Hi Simon, >> >> >> On Wed, Feb 18, 2015 at 6:45 PM, Simon Glass wrote: >>> +mailing list >>> >>> On

Re: [U-Boot] [PATCH RFC v2 0/6] usb: host: Add driver model support

2015-02-18 Thread Vivek Gautam
Hi Simon, On Wed, Feb 18, 2015 at 6:45 PM, Simon Glass wrote: > +mailing list > > On 18 February 2015 at 06:14, Simon Glass wrote: >> Hi Vivek, >> >> On 18 February 2015 at 03:40, Vivek Gautam wrote: >>> Hi Marek, Simon, >>> >>> This patch

[U-Boot] [PATCH RFC 5/6] arm: exynos5: Enable EHCI and XHCI hcds through device tree.

2015-02-18 Thread Vivek Gautam
Add devices for XHCI-HCD and EHCI-HCD in exynos5 family. Signed-off-by: Vivek Gautam --- arch/arm/dts/exynos5.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/dts/exynos5.dtsi b/arch/arm/dts/exynos5.dtsi index 238acb8..5cdf406 100644 --- a/arch/arm/dts/exynos5.dtsi

[U-Boot] [PATCH RFC 6/6] configs: smdk5250: Enable using XHCI and EHCI together

2015-02-18 Thread Vivek Gautam
With driver model now we can enable both EHCI and XHCI on Exynos5250. Signed-off-by: Vivek Gautam --- include/configs/exynos5-common.h|3 +++ include/configs/exynos5250-common.h |3 +++ include/configs/smdk5250.h |2 ++ 3 files changed, 8 insertions(+) diff --git a

[U-Boot] [PATCH RFC 3/6] dm: usb-host: Add UCLASS driver for USB

2015-02-18 Thread Vivek Gautam
Adding a UCLASS driver for USB based on driver-model, to facilitate binding mutiple host-controllers to their respective drivers, and thereby enable using mutiple controllers simultaneously on a platform. Signed-off-by: Vivek Gautam --- drivers/usb/host/Kconfig |9 drivers/usb

[U-Boot] [PATCH RFC 4/6] dm: usb-host: Add support for driver model in o/e/xhci.

2015-02-18 Thread Vivek Gautam
Adding support for driver model and necessary callbacks in ohci/ehci/xhci. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-hcd.c | 36 drivers/usb/host/ohci-hcd.c | 35 --- drivers/usb/host/xhci.c | 34

[U-Boot] [PATCH RFC v2 0/6] usb: host: Add driver model support

2015-02-18 Thread Vivek Gautam
know you comments on what you think of current approach. Thanks Vivek [1] [PATCH RFC 0/2] usb: host: Add a wrapper layer for mutiple host support http://lists.denx.de/pipermail/u-boot/2014-June/182559.html Vivek Gautam (6): usb: Rename usb_submit_int_msg() API to usb_int_msg() dm: usb: Make

[U-Boot] [PATCH RFC 1/6] usb: Rename usb_submit_int_msg() API to usb_int_msg()

2015-02-18 Thread Vivek Gautam
Until yet usb_**_msg() APIs don't contain the string 'submit'. Rename it to make things uniform. This is also helping while adding a host translational layer wherein we are using usb_submit_**_msg string to name APIs. Signed-off-by: Vivek Gautam --- common/usb.c |

[U-Boot] [PATCH RFC 2/6] dm: usb: Make necessary changes in framework for driver model

2015-02-18 Thread Vivek Gautam
Add wrapper functions for usb layer operations for control, bulk, interrupt transfers to accomodate support for driver model. Signed-off-by: Vivek Gautam --- common/usb.c | 99 common/usb_hub.c |2 +- include/dm/uclass-id.h

Re: [U-Boot] [PATCH RFC 0/2] usb: host: Add a wrapper layer for mutiple host support

2014-06-25 Thread Vivek Gautam
Hi Simon, Marek, On Thu, Jun 26, 2014 at 10:04 AM, Vivek Gautam wrote: sorry for spamming, the earlier message got sent by mistake. > On Thu, Jun 26, 2014 at 8:00 AM, Simon Glass wrote: >> Hi Marek, >> >> On 25 June 2014 02:33, Marek Vasut wrote: >>> On Wednes

Re: [U-Boot] [PATCH RFC 0/2] usb: host: Add a wrapper layer for mutiple host support

2014-06-25 Thread Vivek Gautam
ng both things in the tree in the interim.. > > As to the size increase, yes it will increase the size, but not that > much, and after all, aren't we trying to move the code to dm? > > Regards, > Simon > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH RFC 0/2] usb: host: Add a wrapper layer for mutiple host support

2014-06-24 Thread Vivek Gautam
Hi Marek, On Tue, Jun 24, 2014 at 7:56 PM, Marek Vasut wrote: > On Tuesday, June 24, 2014 at 04:10:20 PM, Vivek Gautam wrote: >> Hi Marek, >> >> It's been very long since we had discussion for introducing the wrapper >> layer to enable using multiple u

[U-Boot] [PATCH 2/2] RFC: usb: host: Introduce host translational layer

2014-06-24 Thread Vivek Gautam
Introduce a wrapper layer to translate submit_**_msg() APIs as well as usb_lowlevel_**() APIs so as to enable using mutiple controller types viz. OHCI/EHCI/XHCI. This is still WIP, with support for APIs translation for EHCI and XHCI only. Signed-off-by: Vivek Gautam --- common/usb.c

[U-Boot] [PATCH 1/2] usb: Rename usb_submit_int_msg() API to usb_int_msg()

2014-06-24 Thread Vivek Gautam
Until yet usb_**_msg() APIs don't contain the string 'submit'. Rename it to make things uniform. This is also helping while adding a host translational layer wherein we are using usb_submit_**_msg string to name APIs. Signed-off-by: Vivek Gautam --- common/usb.c |

[U-Boot] [PATCH RFC 0/2] usb: host: Add a wrapper layer for mutiple host support

2014-06-24 Thread Vivek Gautam
send an RFC for this approach. Let me know you comments on what you think of current approach. Thanks Vivek Vivek Gautam (2): usb: Rename usb_submit_int_msg() API to usb_int_msg() RFC: usb: host: Introduce host translational layer common/usb.c | 12 +++-- common/usb_kb

Re: [U-Boot] [PATCH 5/8] usb: xhci-exynos5: Add support for multiple USB 3.0 controllers

2014-01-07 Thread Vivek Gautam
On Tue, Jan 7, 2014 at 4:29 PM, Marek Vasut wrote: > On Tuesday, January 07, 2014 at 10:15:20 AM, Vivek Gautam wrote: > > [...] > > Minor rant, please trim the email when replying so it contains only the > relevant > parts. Otherwise, the irrelevant noise might cause

Re: [U-Boot] [PATCH 5/8] usb: xhci-exynos5: Add support for multiple USB 3.0 controllers

2014-01-07 Thread Vivek Gautam
On Mon, Jan 6, 2014 at 9:21 PM, Marek Vasut wrote: > On Monday, January 06, 2014 at 10:29:40 AM, Vivek Gautam wrote: >> Add required support to use multiple USB 3.0 controllers available >> on exynos5420 SoC. >> >> Signed-off-by: Vivek Gautam >> --- >

Re: [U-Boot] [PATCH 8/8] config: smdk5420: Enable support for multiple XHCI controllers

2014-01-07 Thread Vivek Gautam
On Tue, Jan 7, 2014 at 2:44 PM, Marek Vasut wrote: > On Tuesday, January 07, 2014 at 09:55:37 AM, Vivek Gautam wrote: >> HI Marek, >> >> >> On Mon, Jan 6, 2014 at 9:24 PM, Marek Vasut wrote: >> >> Thanks for reviewing this. :-) >> >> > On

Re: [U-Boot] [PATCH 5/8] usb: xhci-exynos5: Add support for multiple USB 3.0 controllers

2014-01-07 Thread Vivek Gautam
Hi Minkyu Kang, On Tue, Jan 7, 2014 at 11:00 AM, Minkyu Kang wrote: > Dear Vivek Gautam, > > On 06/01/14 18:29, Vivek Gautam wrote: >> Add required support to use multiple USB 3.0 controllers available >> on exynos5420 SoC. >> >> Signed-off-by: Vivek Gautam >

Re: [U-Boot] [PATCH 7/8] smdk5420: Correct the vbus gpio configuration for USB controller

2014-01-07 Thread Vivek Gautam
On Tue, Jan 7, 2014 at 1:19 PM, Marek Vasut wrote: > On Tuesday, January 07, 2014 at 07:37:46 AM, Vivek Gautam wrote: >> Hi Marek, >> >> On Mon, Jan 6, 2014 at 9:22 PM, Marek Vasut wrote: >> > On Monday, January 06, 2014 at 10:29:42 AM, Vivek Gautam wrote: >&g

Re: [U-Boot] [PATCH 8/8] config: smdk5420: Enable support for multiple XHCI controllers

2014-01-07 Thread Vivek Gautam
HI Marek, On Mon, Jan 6, 2014 at 9:24 PM, Marek Vasut wrote: Thanks for reviewing this. :-) > On Monday, January 06, 2014 at 10:29:43 AM, Vivek Gautam wrote: >> Update USB_MAX_CONTROLLER_COUNT to be '2' to enable support >> for both usb 3.0 controllers on exynos5420

Re: [U-Boot] [PATCH 7/8] smdk5420: Correct the vbus gpio configuration for USB controller

2014-01-06 Thread Vivek Gautam
Hi Marek, On Mon, Jan 6, 2014 at 9:22 PM, Marek Vasut wrote: > On Monday, January 06, 2014 at 10:29:42 AM, Vivek Gautam wrote: >> On smdk5420 two availbale XHCI controllers require VBUS GPIO >> to be configured, the EHCI however doesn't have any such VBUS >> GPIO. S

[U-Boot] [PATCH 5/8] usb: xhci-exynos5: Add support for multiple USB 3.0 controllers

2014-01-06 Thread Vivek Gautam
Add required support to use multiple USB 3.0 controllers available on exynos5420 SoC. Signed-off-by: Vivek Gautam --- arch/arm/cpu/armv7/exynos/power.c| 18 -- arch/arm/include/asm/arch-exynos/cpu.h | 10 arch/arm/include/asm/arch-exynos/power.h |2 +- drivers/usb

[U-Boot] [PATCH 2/8] arm: exynos5420: Add base addresses for USB 3.0

2014-01-06 Thread Vivek Gautam
Adding missing base addresses for XHCI and USB3-PHY, to enable support for XHCI on exynos5420 systems. Signed-off-by: Vivek Gautam --- arch/arm/include/asm/arch-exynos/cpu.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm/arch-exynos/cpu.h b/arch

[U-Boot] [PATCH 7/8] smdk5420: Correct the vbus gpio configuration for USB controller

2014-01-06 Thread Vivek Gautam
On smdk5420 two availbale XHCI controllers require VBUS GPIO to be configured, the EHCI however doesn't have any such VBUS GPIO. So correcting the available board_usb_vbus_init() function to the needs. Signed-off-by: Vivek Gautam --- board/samsung/smdk5420/smdk5420.c | 11 ++- 1

[U-Boot] [PATCH 4/8] config: exynos5: Enable XHCI on all Exynos5 systems

2014-01-06 Thread Vivek Gautam
XHCI host controller is present on Exynos5250 as well as Exynos5420, so enabling the correseponding config for all Exynos5 systems. Signed-off-by: Vivek Gautam --- include/configs/exynos5-dt.h|7 +++ include/configs/exynos5250-dt.h |7 --- 2 files changed, 7 insertions(+), 7

[U-Boot] [PATCH 6/8] dts: exynos5420: Move device node for xhci 2nd controller

2014-01-06 Thread Vivek Gautam
XHCI's 2nd controller is present on all Exynos5420 machines, so moving the corresponding node from board dts to SoC dts for exynos5420. Signed-off-by: Vivek Gautam --- arch/arm/dts/exynos5420.dtsi | 12 board/samsung/dts/exynos5420-smdk5420.dts | 12 --

[U-Boot] [PATCH 3/8] dts: exynos5250: Remove explicit device node of 'xhci'

2014-01-06 Thread Vivek Gautam
Device node for 'xhci' already exists in 'exynos5' dtsi file, so we don't need an explicit mention about it again in 'exynos5250' dtsi file. Signed-off-by: Vivek Gautam --- arch/arm/dts/exynos5250.dtsi | 14 -- 1 file changed, 14 deletions(-) d

[U-Boot] [PATCH 0/8] Exynos5420: Add support for XHCI controller

2014-01-06 Thread Vivek Gautam
upport for 'xhci' on exynos5420 based systems. The Vbus GPIO patch in the series is using the non-dt style of configuring the GPIOs (using board_usb_vbus_init helper function). Vivek Gautam (8): arm: exynos5420: Fix base address for USBPHY arm: exynos5420: Add base addresses for USB 3

[U-Boot] [PATCH 8/8] config: smdk5420: Enable support for multiple XHCI controllers

2014-01-06 Thread Vivek Gautam
Update USB_MAX_CONTROLLER_COUNT to be '2' to enable support for both usb 3.0 controllers on exynos5420. NOTE: To use EHCI on exynos5420, this change will need to be reverted, since there's only one EHCI controller available on exynos5420. Signed-off-by: Vivek Gautam ---

[U-Boot] [PATCH 1/8] arm: exynos5420: Fix base address for USBPHY

2014-01-06 Thread Vivek Gautam
'USBPHY' which denotes USB 2.0 PHY is available on exynos5420 Add it's base address rather than making it 'DEVICE_NOT_AVAILABLE' Signed-off-by: Vivek Gautam --- arch/arm/include/asm/arch-exynos/cpu.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [U-Boot] [PATCH 1/2] exynos5250: usb: Fix VBus gpio numbers for ehci and xhci controllers

2014-01-03 Thread Vivek Gautam
On Fri, Jan 3, 2014 at 4:10 PM, Vivek Gautam wrote: > The gpio_*() apis require the exact gpio line number to deduce > the gpio bank and the gpio pin addresses. > So fix the gpio number for VBUS used for EHCI ports as well as > XHCI ports on exynos5250 boards. > > Signed-of

Re: [U-Boot] [PATCH 2/2] smdk5250: Remove 'board_usb_vbus_init()' function

2014-01-03 Thread Vivek Gautam
On Fri, Jan 3, 2014 at 4:10 PM, Vivek Gautam wrote: > Previously as a part of moving the VBUS gpio support to device tree > following patch removed this and added relevant support in driver: > 4a271cb exynos: usb: Switch USB VBUS GPIOs to be device tree configured > > Recent cha

[U-Boot] [PATCH 2/2] smdk5250: Remove 'board_usb_vbus_init()' function

2014-01-03 Thread Vivek Gautam
removing it now. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Minkyu Kang Cc: Marek Vasut --- board/samsung/smdk5250/smdk5250.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/board/samsung/smdk5250/smdk5250.c b/board/samsung/smdk5250/smdk5250.c index 943c29a

[U-Boot] [PATCH 1/2] exynos5250: usb: Fix VBus gpio numbers for ehci and xhci controllers

2014-01-03 Thread Vivek Gautam
The gpio_*() apis require the exact gpio line number to deduce the gpio bank and the gpio pin addresses. So fix the gpio number for VBUS used for EHCI ports as well as XHCI ports on exynos5250 boards. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Minkyu Kang Cc: Marek Vasut --- board

Re: [U-Boot] - Help with usb3503 hub enumeration

2013-09-24 Thread Vivek Gautam
Hi, On Sun, Sep 15, 2013 at 4:55 AM, Suriyan Ramasami wrote: > Hello All and especially Dan Murphy, > Reading thru the mailing list Dan seems to have worked on usb3503a + > LAN9730 enumeration wrt the OMAP5. Hence, I seek his help and anyone else! > >This is with regards to an odroid-u2.

Re: [U-Boot] [PATCH v3 00/10] USB: XHCI: Add xHCI host controller stack driver

2013-09-24 Thread Vivek Gautam
On Tue, Sep 24, 2013 at 12:30 PM, Marek Vasut wrote: > Dear Vivek Gautam, > >> Hi Marek, >> >> On Mon, Sep 23, 2013 at 8:59 PM, Marek Vasut wrote: >> > Dear Vivek Gautam, >> > >> >> + Marek, Dan, Julius, Simon and Vikas for this cover

Re: [U-Boot] [PATCH v3 00/10] USB: XHCI: Add xHCI host controller stack driver

2013-09-23 Thread Vivek Gautam
Hi Marek, On Mon, Sep 23, 2013 at 8:59 PM, Marek Vasut wrote: > Dear Vivek Gautam, > >> + Marek, Dan, Julius, Simon and Vikas for this cover patch ;-) >> > [...] > > Thanks, I have the patches lined up. Just waiting for Dans' talk with Sarah. > Maybe we should

Re: [U-Boot] [PATCH v3 01/10] usb: Move 'bmRequestType' USB device request macros from EHCI header

2013-09-16 Thread Vivek Gautam
Hi Marek, On Tue, Sep 17, 2013 at 8:32 AM, Marek Vasut wrote: > Dear Vivek Gautam, > >> Macros defining bmRequestType field of USB device request, >> given in table 9.2 USB 2.0 spec, are rather generic macros >> which can be further used by other Host controller stac

Re: [U-Boot] [PATCH v3 00/10] USB: XHCI: Add xHCI host controller stack driver

2013-09-14 Thread Vivek Gautam
+ Marek, Dan, Julius, Simon and Vikas for this cover patch ;-) On Sat, Sep 14, 2013 at 2:02 PM, Vivek Gautam wrote: > Based on 'master' branch of u-boot-usb tree. > > The series also includes patches to support xHCI on exynos5250, > including required driver, device tre

[U-Boot] [PATCH v3 10/10] exynos: dts: Add USB VBUS GPIOs to the device tree

2013-09-14 Thread Vivek Gautam
Signed-off-by: Vivek Gautam Cc: Simon Glass Cc: Minkyu Kang Cc: Marek Vasut --- Changes since v2: - This patch is newly added in this version of the series. board/samsung/dts/exynos5250-smdk5250.dts |4 board/samsung/dts/exynos5250-snow.dts |8 2 files changed, 12

[U-Boot] [PATCH v3 09/10] exynos: usb: Switch USB VBUS GPIOs to be device tree configured

2013-09-14 Thread Vivek Gautam
initialization into the USB host controller drivers which they belong to, and uses the samsung,vbus-gpio parameter in the device tree to configure it. Signed-off-by: Julius Werner Signed-off-by: Vivek Gautam Cc: Simon Glass Cc: Minkyu Kang Cc: Marek Vasut --- Changes since v2: - This patch is newly

[U-Boot] [PATCH v3 07/10] config: arm: exynos5250: Define CONFIG_SYS_CACHELINE_SIZE

2013-09-14 Thread Vivek Gautam
XHCI stack driver needs this to align buffers to CacheLine boundary. So define the same to be '64' Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut --- Changes since v2: - Nothing include/configs/exynos5250-dt.h |

[U-Boot] [PATCH v3 08/10] temp: config: exynos5250: Enable xHCI support for Exynos5

2013-09-14 Thread Vivek Gautam
again needs to enable CONFIG_USB_EHCI, CONFIG_USB_EHCI_EXYNOS once again in exynos5-dt config. Signed-off-by: Vikas C Sajjan Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut --- Changes since v2: - Eliminating the EHCI configs rather

[U-Boot] [PATCH v3 04/10] arm: exynos: Add methods to control power to USB 3.0 PHY

2013-09-14 Thread Vivek Gautam
Adding methods to turn on/off power to USB3.0 type PHY as and when required by the controller. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut --- Changes since v2: - Nothing. arch/arm/cpu/armv7/exynos/power.c| 22

[U-Boot] [PATCH v3 06/10] exynos5: dts: Add device node for XHCI

2013-09-14 Thread Vivek Gautam
Adding device node for xhci host controller to enable usb 3.0 on exynos5250. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut --- Changes since v2: - Nothing. arch/arm/dts/exynos5250.dtsi | 12 1 files changed

[U-Boot] [PATCH v3 03/10] USB: XHCI: Add xHCI host controller support for Exynos5

2013-09-14 Thread Vivek Gautam
This adds driver layer for xHCI controller in Samsung's exynos5 soc. This interacts with xHCI host controller stack. Signed-off-by: Vikas C Sajjan Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut --- Changes since v2: - Rep

[U-Boot] [PATCH v3 05/10] exynos5: dts: Add COMPAT string data for USB 3.0 PHY and XHCI

2013-09-14 Thread Vivek Gautam
Adding required compatible string for xHCI host controller as well as USB 3.0 PHY to enable dt support for usb 3.0 on exynos5. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut --- Changes since v2: - Nothing. include/fdtdec.h

[U-Boot] [PATCH v3 01/10] usb: Move 'bmRequestType' USB device request macros from EHCI header

2013-09-14 Thread Vivek Gautam
Macros defining bmRequestType field of USB device request, given in table 9.2 USB 2.0 spec, are rather generic macros which can be further used by other Host controller stacks. So moving them to usb_defs header. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc

[U-Boot] [PATCH v3 00/10] USB: XHCI: Add xHCI host controller stack driver

2013-09-14 Thread Vivek Gautam
eturn -1' globally to return meaningful error numbers. - Added required comment in common/usb.c for not calling first get_descriptor request for XHCI. Julius Werner (2): exynos: usb: Switch USB VBUS GPIOs to be device tree configured exynos: dts: Add USB VBUS GPIOs to the device tree

[U-Boot] [PATCH v2 5/7] exynos5: dts: Add device node for XHCI

2013-08-21 Thread Vivek Gautam
Adding device node for xhci host controller to enable usb 3.0 on exynos5250. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut --- arch/arm/dts/exynos5250.dtsi | 12 1 files changed, 12 insertions(+), 0 deletions

[U-Boot] [PATCH v2 7/7] temp: config: exynos5250: Enable xHCI support for Exynos5

2013-08-21 Thread Vivek Gautam
This enables support for xHCI host controller on Exynos5 and further disables EHCI support, to make sure only one host controller is enabled at a time. Signed-off-by: Vikas C Sajjan Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut

[U-Boot] [PATCH v2 6/7] config: arm: exynos5250: Define CONFIG_SYS_CACHELINE_SIZE

2013-08-21 Thread Vivek Gautam
XHCI stack driver needs this to align buffers to CacheLine boundary. So define the same to be '64' Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut --- include/configs/exynos5250-dt.h |2 ++ 1 files changed, 2 insert

[U-Boot] [PATCH v2 2/7] USB: XHCI: Add xHCI host controller support for Exynos5

2013-08-21 Thread Vivek Gautam
This adds driver layer for xHCI controller in Samsung's exynos5 soc. This interacts with xHCI host controller stack. Signed-off-by: Vikas C Sajjan Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut --- arch/arm/include/asm

[U-Boot] [PATCH v2 0/7] USB: XHCI: Add xHCI host controller stack driver

2013-08-21 Thread Vivek Gautam
ve had EHCI and XHCI working simultaneously. Dan, I have posted the exynos specific patches also alongwith the xHCI stack, just in case someone want to test on exynos5250. I am still available, if you want me to change structurally how dwc3 and exynos stuff is covered in this series.

[U-Boot] [PATCH v2 3/7] arm: exynos: Add methods to control power to USB 3.0 PHY

2013-08-21 Thread Vivek Gautam
Adding methods to turn on/off power to USB3.0 type PHY as and when required by the controller. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut --- arch/arm/cpu/armv7/exynos/power.c| 22 ++ arch/arm

[U-Boot] [PATCH v2 4/7] exynos5: dts: Add COMPAT string data for USB 3.0 PHY and XHCI

2013-08-21 Thread Vivek Gautam
Adding required compatible string for xHCI host controller as well as USB 3.0 PHY to enable dt support for usb 3.0 on exynos5. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Minkyu Kang Cc: Dan Murphy Cc: Marek Vasut --- include/fdtdec.h |2 ++ lib/fdtdec.c

Re: [U-Boot] [PATCH 0/7] USB: XHCI: Add xHCI host controller stack driver

2013-07-31 Thread Vivek Gautam
Hi Dan, On Wed, Jul 31, 2013 at 6:31 PM, Dan Murphy wrote: > Vivek > On 07/02/2013 07:59 AM, Vivek Gautam wrote: >> This change adds necessary xHCI host controller stack layer. >> This stack will eventually interact with SoC specific USB 3.0 >> controller drivers to e

Re: [U-Boot] Regression due to 020bbcb "usb: hub: Power-cycle on root-hub ports"

2013-07-09 Thread Vivek Gautam
On Tue, Jul 9, 2013 at 1:23 AM, Stephen Warren wrote: > On 07/08/2013 01:50 PM, Marek Vasut wrote: >> Dear Stephen Warren, >> >> [...] >> >>> I had already tested the commit in your tree right before the reverts >>> (a36466c50b1b3614c3cfdae194227f7dd8e2c592); that's how I noticed that >>> the reve

Re: [U-Boot] Regression due to 020bbcb "usb: hub: Power-cycle on root-hub ports"

2013-07-08 Thread Vivek Gautam
Hi Marek, On Mon, Jul 8, 2013 at 6:33 PM, Marek Vasut wrote: > Hi guys, > >> On Mon, Jul 1, 2013 at 10:11 PM, Stephen Warren >> wrote: >> > On 07/01/2013 07:49 AM, Vivek Gautam wrote: >> >> Hi Marek, >> >> >> >> On Sun, Jun 30, 2

Re: [U-Boot] [PATCH 0/7] USB: XHCI: Add xHCI host controller stack driver

2013-07-03 Thread Vivek Gautam
Hi Marek, On Wed, Jul 3, 2013 at 2:57 AM, Marek Vasut wrote: > Dear Dan Murphy, > >> Vivek >> >> On 07/02/2013 07:59 AM, Vivek Gautam wrote: >> > This change adds necessary xHCI host controller stack layer. >> > This stack will eventually interact

Re: [U-Boot] Regression due to 020bbcb "usb: hub: Power-cycle on root-hub ports"

2013-07-02 Thread Vivek Gautam
On Mon, Jul 1, 2013 at 10:11 PM, Stephen Warren wrote: > On 07/01/2013 07:49 AM, Vivek Gautam wrote: >> Hi Marek, >> >> >> On Sun, Jun 30, 2013 at 10:08 PM, Marek Vasut wrote: >>> Dear Stephen Warren, >>> >>>> (Sorry to those on to/cc;

[U-Boot] [PATCH 7/7] temp: ARM: EXYNOS5: Enable xHCI support for Exynos5

2013-07-02 Thread Vivek Gautam
This enables support for xHCI host controller on Exynos5 and further disables EHCI support, to make sure only one host controller is enabled at a time. Signed-off-by: Vikas C Sajjan Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Marek Vasut --- include/configs/exynos5250

[U-Boot] [PATCH 5/7] exynos5: dts: Add COMPAT string data for USB 3.0 PHY and XHCI

2013-07-02 Thread Vivek Gautam
Adding required compatible string for xHCI host controller as well as USB 3.0 PHY to enable dt support for usb 3.0 on exynos5. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Marek Vasut --- include/fdtdec.h |2 ++ lib/fdtdec.c |2 ++ 2 files changed, 4

[U-Boot] [PATCH 6/7] exynos5: dts: Add device node for XHCI

2013-07-02 Thread Vivek Gautam
Adding device node for xhci host controller to enable usb 3.0 on exynos5250. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Marek Vasut --- arch/arm/dts/exynos5250.dtsi | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/arm/dts

[U-Boot] [PATCH 4/7] arm: exynos: Add methods to control power to USB 3.0 PHY

2013-07-02 Thread Vivek Gautam
Adding methods to turn on/off power to USB3.0 type PHY as and when required by the controller. Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Marek Vasut --- arch/arm/cpu/armv7/exynos/power.c| 22 ++ arch/arm/include/asm/arch-exynos/power.h

[U-Boot] [PATCH 3/7] USB: XHCI: Add xHCI host controller support for Exynos5

2013-07-02 Thread Vivek Gautam
This adds driver layer for xHCI controller in Samsung's exynos5 soc. This interacts with xHCI host controller stack. Signed-off-by: Vikas C Sajjan Signed-off-by: Vivek Gautam Cc: Julius Werner Cc: Simon Glass Cc: Marek Vasut --- arch/arm/include/asm/arch-exynos/cpu.h |8 +

[U-Boot] [PATCH 1/7] arm: exynos5250: Define CONFIG_SYS_CACHELINE_SIZE

2013-07-02 Thread Vivek Gautam
XHCI stack driver needs this to align buffers to CacheLine boundary. So define the same to be '64' Signed-off-by: Vivek Gautam Cc: Minkyu Kang Cc: Julius Werner Cc: Simon Glass Cc: Marek Vasut --- include/configs/exynos5250-dt.h |2 ++ 1 files changed, 2 insertions(+), 0

[U-Boot] [PATCH 0/7] USB: XHCI: Add xHCI host controller stack driver

2013-07-02 Thread Vivek Gautam
exynos5250, including required driver, device tree changes and a temporary config change to test things finally on smdk5250. Vivek Gautam (7): arm: exynos5250: Define CONFIG_SYS_CACHELINE_SIZE USB: xHCI: Add stack support for xHCI USB: XHCI: Add xHCI host controller support for Exynos5 a

Re: [U-Boot] Regression due to 020bbcb "usb: hub: Power-cycle on root-hub ports"

2013-07-01 Thread Vivek Gautam
Hi Marek, On Sun, Jun 30, 2013 at 10:08 PM, Marek Vasut wrote: > Dear Stephen Warren, > >> (Sorry to those on to/cc; I'm resending this so it goes to the correct >> mailing list) Dear Stephen, sorry for the delay in responding to this. >> >> Commit 020bbcb "usb: hub: Power-cycle on root-hub po

Re: [U-Boot] [PATCH 2/2] usb: gadget: Use unaligned access for wMaxPacketSize

2013-05-13 Thread Vivek Gautam
Hi, On Mon, May 13, 2013 at 4:20 PM, Kyungmin Park wrote: > On Mon, May 13, 2013 at 7:23 PM, Vivek Gautam wrote: > >> Use get_unaligned() while fetching wMaxPacketSize to avoid >> voilating any alignment rules. typo here s/voilating/violating >> > > It's an

[U-Boot] [PATCH 2/2] usb: gadget: Use unaligned access for wMaxPacketSize

2013-05-13 Thread Vivek Gautam
Use get_unaligned() while fetching wMaxPacketSize to avoid voilating any alignment rules. Signed-off-by: Vivek Gautam Cc: Lukasz Majewski Cc: Piotr Wilczek Cc: Kyungmin Park Cc: Lukasz Dalek Cc: Marek Vasut --- Just did a build test on u-boot-usb/master branch. Need to be tested further

[U-Boot] [PATCH 1/2] usb: Use get_unaligned() in usb_endpoint_maxp() for wMaxPacketSize

2013-05-13 Thread Vivek Gautam
... == Signed-off-by: Vivek Gautam Cc: Ilya Yanok Cc: Marek Vasut --- Based on u-boot-usb/next. Tested with 'u-boot-usb/master' branch. include/linux/usb/ch9.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include

Re: [U-Boot] [U-Boot,v3,7/8] usb: hub: Reset only usb 2.0 ports

2013-04-30 Thread Vivek Gautam
Hi Marek, On Wed, Apr 24, 2013 at 11:38 AM, Vivek Gautam wrote: > On Wed, Apr 24, 2013 at 5:51 AM, Marek Vasut wrote: >> Dear Julius Werner, >> >>> Sorry, forgot this one yesterday. I would consider to just drop/revert >>> this patch entirely. It's not wro

Re: [U-Boot] [PATCH 0/3] usb: ss: Fixes for super speed framework

2013-04-24 Thread Vivek Gautam
Hi Marek, On Thu, Apr 25, 2013 at 8:32 AM, Marek Vasut wrote: > Dear Vivek Gautam, > >> This patch series fixes changes for Super speed framework >> which got pulled-in 'u-boot-usb/next'. >> First patch fixes Port Status and Port feature macro constants, >

Re: [U-Boot] [PATCH 3/3] usb: common: Use a global definition for 'min3'

2013-04-24 Thread Vivek Gautam
CC: Tom Rini On Wed, Apr 24, 2013 at 6:20 PM, Vivek Gautam wrote: > We can use a common global method for calculating minimum of > 3 numbers. Put the same in 'common header' and let 'ehci' > use it. > > Signed-off-by: Vivek Gautam > ---

[U-Boot] [PATCH 3/3] usb: common: Use a global definition for 'min3'

2013-04-24 Thread Vivek Gautam
We can use a common global method for calculating minimum of 3 numbers. Put the same in 'common header' and let 'ehci' use it. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-hcd.c | 10 -- include/common.h| 25 +

[U-Boot] [PATCH 2/3] usb: fix: Fixing Port status and feature number constants

2013-04-24 Thread Vivek Gautam
Fix the Port status bit constants and Port feature number constants as a part of USB 2.0 and USB 3.0 Hub class. Signed-off-by: Vivek Gautam --- common/usb_hub.c | 40 include/usb_defs.h | 39 +++ 2 files changed

[U-Boot] [PATCH 1/3] usb: hub: Parallelize power-cycling of root-hub ports

2013-04-24 Thread Vivek Gautam
-enable the power subsequently. Signed-off-by: Vivek Gautam --- common/usb_hub.c | 23 ++- 1 files changed, 14 insertions(+), 9 deletions(-) diff --git a/common/usb_hub.c b/common/usb_hub.c index 1e225e6..dad0409 100644 --- a/common/usb_hub.c +++ b/common/usb_hub.c @@ -105,22

[U-Boot] [PATCH 0/3] usb: ss: Fixes for super speed framework

2013-04-24 Thread Vivek Gautam
tions with Linux kernel. Based on u-boot-usb/next branch with following patch reverted: usb: hub: Reset only usb 2.0 ports Vivek Gautam (3): usb: hub: Parallelize power-cycling of root-hub ports usb: fix: Fixing Port status and feature number constants usb: common: Use a global definition

Re: [U-Boot] [PATCH] usb: common: Use a global definition for 'min3'

2013-04-23 Thread Vivek Gautam
Hi Marek, On Wed, Apr 24, 2013 at 11:49 AM, Vivek Gautam wrote: > On Mon, Apr 22, 2013 at 7:15 PM, Tom Rini wrote: >> On Fri, Apr 19, 2013 at 01:29:12PM +0200, Marek Vasut wrote: >>> Dear Vivek Gautam, >>> >>> > We can use a common global method for calc

Re: [U-Boot] [PATCH] usb: common: Use a global definition for 'min3'

2013-04-23 Thread Vivek Gautam
On Mon, Apr 22, 2013 at 7:15 PM, Tom Rini wrote: > On Fri, Apr 19, 2013 at 01:29:12PM +0200, Marek Vasut wrote: >> Dear Vivek Gautam, >> >> > We can use a common global method for calculating minimum of >> > 3 numbers. Put the same in 'common header' a

Re: [U-Boot] [U-Boot,v3,7/8] usb: hub: Reset only usb 2.0 ports

2013-04-23 Thread Vivek Gautam
gt; > require software reset to advance them to 'Enabled' state. >> > Thereby, inferring that software need to reset USB 2.0 protocol >> > ports invariably (as per EHCI spec or xHCI spec). >> > >> > Signed-off-by: Vivek Gautam >> > >> &

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-22 Thread Vivek Gautam
Hi Marek, On Tue, Apr 23, 2013 at 7:54 AM, Marek Vasut wrote: > Dear Vivek Gautam, > >> Hi Marek, >> >> On Sat, Apr 20, 2013 at 5:27 PM, Marek Vasut wrote: >> > Dear Julius Werner, >> > >> >> These patches haven't gone in yet, right? I

Re: [U-Boot] [U-Boot, v3, 3/8] usb: hub: Power-cycle on root-hub ports

2013-04-22 Thread Vivek Gautam
Hi, On Tue, Apr 23, 2013 at 3:32 AM, Julius Werner wrote: >> This 20ms delay is truely being taken to be on safer side (twice of >> Power-on-to-power-good), >> its not observational. >> In my earlier patch-series, we were doing the same way as you are >> suggesting here (power-on >> ports only i

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-22 Thread Vivek Gautam
Hi Julius, On Tue, Apr 23, 2013 at 3:44 AM, Julius Werner wrote: >>> I would reword "Additions" to "Changes" and explicitly state that these >>> fields >>> concern the new USB 3.0 hub descriptor format, which is different and >>> exclusively applies to SuperSpeed hubs. >> >> This bit fields are

Re: [U-Boot] [U-Boot, v3, 3/8] usb: hub: Power-cycle on root-hub ports

2013-04-22 Thread Vivek Gautam
HI Julius, On Sat, Apr 20, 2013 at 12:30 AM, Julius Werner wrote: >> XHCI ports are powered on after a H/W reset, however >> EHCI ports are not. So disabling and re-enabling power >> on all ports invariably. >> >> Signed-off-by: Amar >> Signed-off-by: Vivek

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-21 Thread Vivek Gautam
Hi Marek, On Sat, Apr 20, 2013 at 5:27 PM, Marek Vasut wrote: > Dear Julius Werner, > >> These patches haven't gone in yet, right? I think Vivek wants to >> discuss/update them himself, he just asked me to move my reviews to >> this thread. > > They're not in, but they're already pushed in my tr

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-21 Thread Vivek Gautam
xHCI. >> >> Signed-off-by: Vikas C Sajjan >> Signed-off-by: Vivek Gautam >> >> --- >> Changes from v2: >> - Replacing if-else with switch-case in portspeed() in cmd_usb.c >> >> common/cmd_usb.c | 24 ++-- >> comm

[U-Boot] [PATCH] usb: common: Use a global definition for 'min3'

2013-04-19 Thread Vivek Gautam
We can use a common global method for calculating minimum of 3 numbers. Put the same in 'common header' and let 'ehci' use it. Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-hcd.c | 10 -- include/common.h|5 + 2 files changed, 5 inserti

Re: [U-Boot] [PATCH v3 0/8] usb: ss: Some fixes and cleanup for USB super-speed support

2013-04-18 Thread Vivek Gautam
On Fri, Apr 19, 2013 at 12:45 AM, Marek Vasut wrote: > Hi Julius, > >> Hi Marek, >> >> I'm sorry, that must have slipped by when I ported the change from my >> local fork. Your patch is correct, you just need to add the "ctrl->" >> there. > > Well, next time please make sure to compile-test your p

Re: [U-Boot] [PATCH v3 0/8] usb: ss: Some fixes and cleanup for USB super-speed support

2013-04-18 Thread Vivek Gautam
On Thu, Apr 18, 2013 at 6:08 PM, Marek Vasut wrote: > Dear Vivek Gautam, > >> Hi, >> >> On Sun, Apr 14, 2013 at 10:44 PM, Marek Vasut wrote: >> > Dear Vivek Gautam, >> > >> >> Based on 'u-boot-usb' master branch. >> &g

Re: [U-Boot] [PATCH v3 0/8] usb: ss: Some fixes and cleanup for USB super-speed support

2013-04-18 Thread Vivek Gautam
HI Marek, On Thu, Apr 18, 2013 at 4:29 PM, Vivek Gautam wrote: > On Thu, Apr 18, 2013 at 11:54 AM, Vivek Gautam > wrote: >> Hi Marek, >> >> >> On Sun, Apr 14, 2013 at 11:43 PM, Marek Vasut wrote: >>> Dear Vivek Gautam, >>> >>>> Base

Re: [U-Boot] [PATCH v3 0/8] usb: ss: Some fixes and cleanup for USB super-speed support

2013-04-18 Thread Vivek Gautam
On Thu, Apr 18, 2013 at 11:54 AM, Vivek Gautam wrote: > Hi Marek, > > > On Sun, Apr 14, 2013 at 11:43 PM, Marek Vasut wrote: >> Dear Vivek Gautam, >> >>> Based on 'u-boot-usb' master branch. >>> >>> This patch-series includes majorly

Re: [U-Boot] [PATCH v3 0/8] usb: ss: Some fixes and cleanup for USB super-speed support

2013-04-17 Thread Vivek Gautam
Hi, On Sun, Apr 14, 2013 at 10:44 PM, Marek Vasut wrote: > Dear Vivek Gautam, > >> Based on 'u-boot-usb' master branch. >> >> This patch-series includes majorly some clean-up, few fixes and >> then some basic super-speed usb infrastructure addition,

Re: [U-Boot] [PATCH v3 0/8] usb: ss: Some fixes and cleanup for USB super-speed support

2013-04-17 Thread Vivek Gautam
Hi Marek, On Sun, Apr 14, 2013 at 11:43 PM, Marek Vasut wrote: > Dear Vivek Gautam, > >> Based on 'u-boot-usb' master branch. >> >> This patch-series includes majorly some clean-up, few fixes and >> then some basic super-speed usb infrastructure addition,

  1   2   >