Re: [PATCH] Fix neighbor discovery ethernet address saving

2024-05-13 Thread Vyacheslav V. Mitrofanov
rver_ethaddr (and it's > checking > to make sure that net_nd_packet_mac isn't NULL before copying). > > Also, the current code serves no purpose.  The current code is, "if > net_nd_packet_mac is NULL, set it to stack variable neigh_eth_addr, > then > set net_nd_p

Re: [PATCH] Fix neighbor discovery ethernet address saving

2024-05-05 Thread Vyacheslav V. Mitrofanov
On Mon, 2024-04-29 at 11:51 -0700, seanedm...@linux.microsoft.com wrote: > s...@yadro.com > > From: Sean Edmond > > When a successful neighbor advertisement is received, the ethernet > address should be saved for later use to avoid having to redo the > neighbor discovery

Re: [PATCH 2/2] net: ipv6: network protocol structures should be packed

2023-05-19 Thread Vyacheslav V. Mitrofanov
On Thu, 2023-05-18 at 11:24 -0700, emohand...@linux.microsoft.com wrote: > From: Ehsan Mohandesi > > The structure icmp6_ra_prefix_info needs to be packed because it is > read > from a network stream. > > Signed-off-by: Ehsan Mohandesi > --- > include/net6.h | 2 +- > 1 file changed, 1

Re: [PATCH 1/2] net: ipv6: router advertisement message length should be within limits

2023-05-19 Thread Vyacheslav V. Mitrofanov
On Thu, 2023-05-18 at 11:24 -0700, emohand...@linux.microsoft.com wrote: > > From: Ehsan Mohandesi > > The argument len passed to function process_ra is the length of the > IPv6 > router advertisement message and needs to be between 0 and MTU > because > it is assigned to remaining_option_len

Re: [PATCH v4 1/3] net: ipv6: Add support for default gateway discovery.

2023-05-10 Thread Vyacheslav V. Mitrofanov
On Wed, 2023-05-10 at 13:05 +0300, Sergei Antonov wrote: > > Hey! It was added without "__packed", see > https://lists.denx.de/pipermail/u-boot/2023-May/517370.html > Hello, Sergei. I see Ehsan hadn't sent v5 before v4 was applied. I would make a patch with __packed attribute and post it.

Re: [PATCH v4 1/3] net: ipv6: Add support for default gateway discovery.

2023-04-24 Thread Vyacheslav V. Mitrofanov
On Fri, 2023-04-21 at 17:08 -0700, emohand...@linux.microsoft.com wrote: > > From: Ehsan Mohandesi > > In IPv6, the default gateway and prefix length are determined by > receiving > a router advertisement as defined in - > https://www.rfc-editor.org/rfc/rfc4861. > > Add support for sending

Re: [PATCH v4 3/3] test: eth: IPv6 network discovery unit test

2023-04-24 Thread Vyacheslav V. Mitrofanov
On Fri, 2023-04-21 at 17:08 -0700, emohand...@linux.microsoft.com wrote: > «Внимание! Данное письмо от внешнего адресата!» > > From: Ehsan Mohandesi > > Test router advertisement validation and processing functions. > > Signed-off-by: Ehsan Mohandesi > --- > test/dm/eth.c | 88 >

Re: [PATCH v4 2/3] test/py: IPv6 network discovery test

2023-04-24 Thread Vyacheslav V. Mitrofanov
On Fri, 2023-04-21 at 17:08 -0700, emohand...@linux.microsoft.com wrote: > «Внимание! Данное письмо от внешнего адресата!» > > From: Ehsan Mohandesi > > Test the IPv6 network discovery feature if indicated by boardenv > file. > > Signed-off-by: Ehsan Mohandesi > --- >

Re: [PATCH v4 1/3] net: ipv6: Add support for default gateway discovery.

2023-04-24 Thread Vyacheslav V. Mitrofanov
On Fri, 2023-04-21 at 17:08 -0700, emohand...@linux.microsoft.com wrote: > > From: Ehsan Mohandesi > > In IPv6, the default gateway and prefix length are determined by > receiving > a router advertisement as defined in - > https://www.rfc-editor.org/rfc/rfc4861. > > Add support for sending

Re: [PATCH v3 1/3] net: ipv6: Add support for default gateway discovery.

2023-04-20 Thread Vyacheslav V. Mitrofanov
Hello Ehsan! I tried to apply your patches and found out that there are some conflicts. I think you use your custom version. Check it please. Thanks! On Wed, 2023-04-12 at 09:10 -0700, emohand...@linux.microsoft.co wrote: From: Ehsan Mohandesi > > > #endif /* __NDISC_H__ */ > diff --git

Re: [PATCH v2 1/4] Revert "net: ipv6: Add support for default gateway discovery."

2023-04-11 Thread Vyacheslav V. Mitrofanov
On Mon, 2023-04-10 at 12:34 -0700, emohand...@linux.microsoft.com wrote: > > From: Ehsan Mohandesi > > This reverts commit 0af1035a55d9c1486b2db43ee70ff0a63affd4f4. > > Signed-off-by: Ehsan Mohandesi > > Conflicts: > cmd/Kconfig > include/net.h > include/net6.h >

Re: [PATCH] net: ipv6: Add support for default gateway discovery.

2023-03-23 Thread Vyacheslav V. Mitrofanov
On Thu, 2023-03-23 at 16:44 +, Ehsan Mohandesi wrote: > > Hi Viacheslav, > > > -Original Message- > > From: Vyacheslav V. Mitrofanov > > Sent: Thursday, March 16, 2023 3:47 AM > > To: u-boot@lists.denx.de; emohand...@linux.microsoft.com > &g

Re: [PATCH] net: ipv6: Add support for default gateway discovery.

2023-03-16 Thread Vyacheslav V. Mitrofanov
On Thu, 2023-03-02 at 08:58 -0800, emohand...@linux.microsoft.com wrote: > > From: Ehsan Mohandesi > > In IPv6, the default gateway and prefix length are determined by > receiving > a router advertisement as defined in - > https://www.rfc-editor.org/rfc/rfc4861. > > Add support for sending

Re: [PATCH 2/2] net: dhcp6: pxe: Add DHCP/PXE commands for IPv6

2023-03-05 Thread Vyacheslav V. Mitrofanov
> From: Sean Edmond > > Adds commands to support DHCP and PXE with IPv6. > > New commands added (when IPv6 is enabled): > - dhcp6 > - pxe get -ipv6 > - pxe boot -ipv6 > > Signed-off-by: Sean Edmond > --- > boot/bootmeth_distro.c | 2 +- > boot/bootmeth_pxe.c| 4 +- > boot/pxe_utils.c

Re: [PATCH 1/2] net: dhcp6: Add DHCPv6 (DHCP for IPv6)

2023-03-05 Thread Vyacheslav V. Mitrofanov
> From: Sean Edmond > > Adds DHCPv6 protocol to u-boot. > > Allows for address assignement with DHCPv6 4-message exchange > (SOLICIT->ADVERTISE->REQUEST->REPLY). Includes DHCPv6 options > required by RFC 8415. Also adds DHCPv6 options required > for PXE boot. > > New configs added: > -

Re: [PATCH 0/2] net: DHCPv6 protocol and commands

2023-03-05 Thread Vyacheslav V. Mitrofanov
> From: Sean Edmond > > The recently integrated IPv6 patch series relies on the link-local > address, > or a statically assigned IPv6 address for network operations. This > patch > series adds IPv6 address assignment through DHCPv6. > > The implementation meets the requirements in RFC 8415 for

Re: [PATCH] net: ipv6: fix alignment errors on ARM

2023-01-19 Thread Vyacheslav V. Mitrofanov
On Thu, 2023-01-19 at 14:05 +0300, Sergei Antonov wrote: > > On Thu, 19 Jan 2023 at 11:18, Vyacheslav V. Mitrofanov > wrote: > > On Wed, 2023-01-18 at 20:52 +0300, Sergei Antonov wrote: > > > Commands "ping6" and "tftpboot ... -ipv6" did not work on AR

Re: [PATCH] net: ipv6: fix alignment errors on ARM

2023-01-19 Thread Vyacheslav V. Mitrofanov
On Wed, 2023-01-18 at 20:52 +0300, Sergei Antonov wrote: > Commands "ping6" and "tftpboot ... -ipv6" did not work on ARM because > machine code expects 4-byte alignment and some structures from net6.h > are not aligned in memory. > > Fix by adding __packed, since it is already used in this file.

Re: [PATCH] net: ipv6: Fixed IPv6 string to address conversion off-by-one error

2023-01-16 Thread Vyacheslav V. Mitrofanov
On Fri, 2023-01-13 at 09:27 -0800, emohand...@linux.microsoft.com wrote: > From: Ehsan Mohandesi > > One extra character was being checked in the IPv6 string which caused > the > last character of the address to be neither '\0' nor ':'. This raises > an > error condition and causes the function

Re: [PATCH] net: ipv6: Fix IPv6 netmask parsing

2023-01-08 Thread Vyacheslav V. Mitrofanov
On Fri, 2023-01-06 at 14:22 -0800, seanedm...@linux.microsoft.com wrote: > From: Sean Edmond > > It should be possible to specify a netmask when > setting a static IPv6 address. For example: > setenv ip6addr 2001:cafe:cafe:cafe::100/64 > > The net_prefix_length and net_ip6 should be updated >