[PATCH v2] board: rpi: Update memory layout for Aarch64

2024-07-23 Thread Walter Lozano
kernel to allow boards with 512 MB to have enough free space for other artifacts, such as ramdisk. Signed-off-by: Walter Lozano --- Changes in v2: Bump space reserved for linux from 50 MB to 128 MB board/raspberrypi/rpi/rpi.env | 25 ++--- 1 file changed, 18 insertions

Re: [PATCH] board: rpi: Update memory layout for Aarch64

2024-07-17 Thread Walter Lozano
On 7/17/24 12:44, Tom Rini wrote: On Wed, Jul 17, 2024 at 11:59:50AM +0100, Peter Robinson wrote: On Tue, 16 Jul 2024 at 18:21, Tom Rini wrote: On Tue, Jul 16, 2024 at 02:16:02PM -0300, Walter Lozano wrote: ARM and Aarch64 have different restrictions and trying to accommodate larger

[PATCH] board: rpi: Update memory layout for Aarch64

2024-07-16 Thread Walter Lozano
ARM and Aarch64 have different restrictions and trying to accommodate larger kernels like the ones used in distros can be challenging. For this reason, separate the layout and rearrange the map for Aarch64 to support kernels larger than 36 MB. Signed-off-by: Walter Lozano --- board/raspberrypi

Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

2021-12-07 Thread Walter Lozano
Hi Simon, On 11/24/21 21:12, Simon Glass wrote: Hi Walter, On Mon, 2 Aug 2021 at 13:29, Walter Lozano wrote: Hi Simon, On 8/1/21 11:50 PM, Simon Glass wrote: Hi Walter, On Sun, 1 Aug 2021 at 20:45, Walter Lozano wrote: Hi Simon, Thanks for checking this bug, I'm glad that you were

Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

2021-08-02 Thread Walter Lozano
Hi Simon, On 8/1/21 11:50 PM, Simon Glass wrote: Hi Walter, On Sun, 1 Aug 2021 at 20:45, Walter Lozano wrote: Hi Simon, Thanks for checking this bug, I'm glad that you were able to come with fix quickly. I have some questions, I hope that you find some time to help me understand. On

Re: [PATCH] dtoc: Correct the intarray-widening test case

2021-08-02 Thread Walter Lozano
Hi Simon, On 8/2/21 10:37 AM, Simon Glass wrote: This case was intended to check that widening an int array with an int does nothing. Fix it. Reported-by: Walter Lozano Signed-off-by: Simon Glass --- tools/dtoc/test_fdt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 2/3] dtoc: Fix widening an int array to an int

2021-08-01 Thread Walter Lozano
Hi Simon, I know you already merged this one but I have some doubts I would like to check with you. On 7/28/21 10:23 PM, Simon Glass wrote: An int array can hold a single int so we should not need to do anything in the widening operation. However due to a quirk in the code, an int[3] widened

Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

2021-08-01 Thread Walter Lozano
Hi Simon, Thanks for checking this bug, I'm glad that you were able to come with fix quickly. I have some questions, I hope that you find some time to help me understand. On 7/28/21 10:23 PM, Simon Glass wrote: The current name is confusing because the logic is actually backwards from what y

Re: [PATCH] dtoc: Check that a parent is not missing

2021-07-25 Thread Walter Lozano
Hi Simon, Thanks for the patch, it will be a nice way to spot errors and avoid headaches! On 7/7/21 8:22 AM, Simon Glass wrote: With of-platdata-inst we want to set up a reference to each devices' parent device, if there is one. If we find that the device has a parent (i.e. is not a root node

Re: [PATCH 8/8] dtoc: Update documentation to cover warnings in more detail

2021-07-05 Thread Walter Lozano
vides the array of compatible strings and the second +provides the uclass ID. + This paragraph sound strange, maybe "Checks are are also made to confirm that the referenced driver..." but your English is better than mine. Reviewed-by: Walter Lozano Regards, Walter + Caveats ---

Re: [PATCH 7/8] dtoc: Detect drivers which do not parse correctly

2021-07-05 Thread Walter Lozano
tools/dtoc/src_scan.py | 7 ++- tools/dtoc/test_src_scan.py | 38 + 2 files changed, 44 insertions(+), 1 deletion(-) Reviewed-by: Walter Lozano Thanks! Walter diff --git a/tools/dtoc/src_scan.py b/tools/dtoc/src_scan.py index 847677757d9..3bef59d6

Re: [PATCH 4/8] dtoc: Correct the re_compat regular expression

2021-07-05 Thread Walter Lozano
ed-by: Walter Lozano Thanks! Walter diff --git a/tools/dtoc/src_scan.py b/tools/dtoc/src_scan.py index 6c37a71e978..6e8e1ba51a0 100644 --- a/tools/dtoc/src_scan.py +++ b/tools/dtoc/src_scan.py @@ -452,8 +452,8 @@ class Scanner: # Collect the compatible string, e.g. 'rockchip,

Re: [PATCH 3/8] dtoc: Allow multiple warnings for a driver

2021-07-05 Thread Walter Lozano
s --- tools/dtoc/src_scan.py | 24 1 file changed, 20 insertions(+), 4 deletions(-) Reviewed-by: Walter Lozano Thank you, it is indeed something worth to be added! Walter diff --git a/tools/dtoc/src_scan.py b/tools/dtoc/src_scan.py index 1dbb56712a3..6c37a71e978 100

Re: [PATCH 2/8] dtoc: Convert to use ArgumentParser

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: Use this parser instead of OptionParser, which is deprecated. Signed-off-by: Simon Glass --- tools/dtoc/main.py | 51 -- 1 file changed, 27 insertions(+), 24 deletions(-) Reviewed-by: Walter

Re: [PATCH 1/8] dtoc: Avoid using subscripts on match objects

2021-07-05 Thread Walter Lozano
Hi Simon, On 7/4/21 3:19 PM, Simon Glass wrote: These are not supported before Python 3.6 so avoid them. Signed-off-by: Simon Glass --- tools/dtoc/src_scan.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Walter Lozano Thanks! Walter diff --git a/tools/dtoc

Re: [PATCH 00/30] dm: Implement OF_PLATDATA_INST in driver model (part E)

2021-01-06 Thread Walter Lozano
Hi Simon, On 12/31/20 1:09 AM, Simon Glass wrote: This series builds on the recent dtoc implementation of build-time device instantiation. It adds the required driver model support, which is basically a few more data structures. With this, sandbox_spl and chromebook_coral both use the new feat

Re: [PATCH 08/49] dm: Rename U_BOOT_DEVICE() to U_BOOT_DRVINFO()

2021-01-05 Thread Walter Lozano
ely used, since boards should use devicetree to declare devices. Rename it to U_BOOT_DRVINFO(), which indicates clearly that this is declaring a new driver_info record, not a device. Signed-off-by: Simon Glass I couldn't agree more. Reviewed-by: Walter Lozano Thanks, --- ...

Re: [PATCH 09/49] dm: Rename DM_GET_DEVICE() to DM_DRVINFO_GET()

2021-01-05 Thread Walter Lozano
related macros. Signed-off-by: Simon Glass Reviewed-by: Walter Lozano Thanks, --- doc/driver-model/of-plat.rst | 2 +- include/dm/platdata.h| 10 +++--- tools/dtoc/dtb_platdata.py | 4 ++-- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/doc/driver-model/of

Re: [PATCH 45/49] dm: of-platadata: Add option for device instantiation

2021-01-05 Thread Walter Lozano
On 12/29/20 12:35 AM, Simon Glass wrote: Add Kconfig options to support build-time device instantiation. When fully implemented, this will allow dtoc to create U-Boot devices (i.e. struct udevice records) at build time, thus reducing code space in SPL. For now this defaults to off, but will be

Re: [PATCH 5/5] dtoc: Tidy up Python style in dtb_platdata

2020-11-12 Thread Walter Lozano
Hi Simon, Thanks for this series. I've tried to test it but I had issues to apply it. I have tried in u-boot, both master and next, and u-boot-dm. Could you please point me to the right tree/version? On 9/11/20 00:36, Simon Glass wrote: Update this, mostly to add comments for argument and re

Re: [PATCH] imx: mx6cuboxi: Disable CONFIG_IMX_THERMAL

2020-10-29 Thread Walter Lozano
On 29/10/20 12:19, Tom Rini wrote: On Thu, Oct 29, 2020 at 07:14:55AM +0200, Baruch Siach wrote: Hi Simon, Adding Walter to Cc. On Thu, Oct 29 2020, Simon Glass wrote: This feature is incompatble with of-platdata since it uses the U_BOOT_DEVICE() macro. With of-platdata the only devices per

Re: [RFC 3/4] dtoc: add support for generate stuct udevice_id

2020-09-07 Thread Walter Lozano
Hi Simon, On 6/9/20 22:44, Simon Glass wrote: Hi Walter, On Fri, 7 Aug 2020 at 11:23, Walter Lozano wrote: Hi Simon On 7/8/20 13:23, Simon Glass wrote: Hi Walter, On Wed, 29 Jul 2020 at 10:00, Walter Lozano wrote: Hi Simon, On 28/7/20 23:42, Simon Glass wrote: Hi Walter, On Sun, 26

Re: [RFC PATCH v2 0/3] RFC: tiny-dm: Proposal for using driver model in SPL

2020-08-15 Thread Walter Lozano
Hi Simon, On 16/8/20 00:06, Simon Glass wrote: Hi Walter, On Sun, 26 Jul 2020 at 20:45, Walter Lozano wrote: Hi Simon, On 10/7/20 01:12, Walter Lozano wrote: Hi Simon, On 2/7/20 18:10, Simon Glass wrote: This series provides a proposed enhancement to driver model to reduce overhead in

Re: [RFC 3/4] dtoc: add support for generate stuct udevice_id

2020-08-07 Thread Walter Lozano
Hi Simon On 7/8/20 13:23, Simon Glass wrote: Hi Walter, On Wed, 29 Jul 2020 at 10:00, Walter Lozano wrote: Hi Simon, On 28/7/20 23:42, Simon Glass wrote: Hi Walter, On Sun, 26 Jul 2020 at 20:16, Walter Lozano wrote: Hi Simon, On 26/7/20 11:53, Simon Glass wrote: Hi Walter, On Tue, 7

[PATCH 0/2] drivers: use of_match_ptr to avoid references when OF_PLATDATA is used

2020-07-29 Thread Walter Lozano
In order to save extra bytes when OF_PLATDATA is enabled avoid referencing compatible strings and additional functions by extending the use of of_match_ptr taking into account this configuration. Walter Lozano (2): core: improve of_match_ptr with OF_PLATDATA drivers: use of_match_ptr to

[PATCH 1/2] core: improve of_match_ptr with OF_PLATDATA

2020-07-29 Thread Walter Lozano
Currently of_match_ptr is used to avoid referencing compatible strings when OF_CONTROL is not enabled. This behaviour could be improved by taking into account also OF_PLATDATA, as when this configuration is enabled the compatible strings are not used at all. Signed-off-by: Walter Lozano

[PATCH 2/2] drivers: use of_match_ptr to avoid references when OF_PLATDATA is used

2020-07-29 Thread Walter Lozano
As when OF_PLATDATA is used compatible strings are not used at all remove their reference to save extra bytes. Also in the cases where this was done with #define change to of_match_ptr to improve readability. Signed-off-by: Walter Lozano --- drivers/clk/clk_fixed_factor.c| 2

Re: [RFC 3/4] dtoc: add support for generate stuct udevice_id

2020-07-29 Thread Walter Lozano
Hi Simon, On 28/7/20 23:42, Simon Glass wrote: Hi Walter, On Sun, 26 Jul 2020 at 20:16, Walter Lozano wrote: Hi Simon, On 26/7/20 11:53, Simon Glass wrote: Hi Walter, On Tue, 7 Jul 2020 at 08:08, Walter Lozano wrote: Hi Simon On 6/7/20 16:21, Simon Glass wrote: Hi Walter, On Fri, 19

[PATCH v3 4/6] mmc: fsl_esdhc_imx: add CD support when OF_PLATDATA is enabled

2020-07-29 Thread Walter Lozano
After enabling OF_PLATDATA support to both MMC and GPIO drivers add the support for card detection. Signed-off-by: Walter Lozano Reviewed-by: Simon Glass --- Changes in v3: - Change #ifdef to if when possible drivers/mmc/fsl_esdhc_imx.c | 25 - 1 file changed, 24

Re: [PATCH v2 3/6] gpio: mxc_gpio: add OF_PLATDATA support

2020-07-29 Thread Walter Lozano
Hi Stefano, On 27/7/20 09:10, Stefano Babic wrote: Hi Walter, On 22.07.20 15:14, Walter Lozano wrote: Continuing with the OF_PLATADATA support for iMX6 to reduce SPL footprint, add it to mxc_gpio. Thanks to this, it will be possible to enable card detection on MMC driver. Signed-off-by

[PATCH v3 5/6] drivers: rename more drivers to match compatible string

2020-07-29 Thread Walter Lozano
Continuing with the approach in commit rename additional drivers to allow the OF_PLATDATA support. Signed-off-by: Walter Lozano Reviewed-by: Simon Glass --- (no changes since v1) drivers/pinctrl/nxp/pinctrl-imx6.c | 6 -- drivers/video/imx/mxc_ipuv3_fb.c | 4 ++-- 2 files changed, 6

[PATCH v3 6/6] mx6cuboxi: enable OF_PLATDATA

2020-07-29 Thread Walter Lozano
As both MMC and GPIO driver now supports OF_PLATDATA, enable it in defconfig in order to reduce the SPL footprint. After applying this setting the SPL reduction is 5 KB, which partially compensates the increment due to DM. Signed-off-by: Walter Lozano Reviewed-by: Simon Glass --- (no changes

[PATCH v3 3/6] gpio: mxc_gpio: add OF_PLATDATA support

2020-07-29 Thread Walter Lozano
Continuing with the OF_PLATADATA support for iMX6 to reduce SPL footprint, add it to mxc_gpio. Thanks to this, it will be possible to enable card detection on MMC driver. Signed-off-by: Walter Lozano --- Changes in v3: - Rework to resolve merge conflicts drivers/gpio/mxc_gpio.c | 26

[PATCH v3 1/6] mmc: fsl_esdhc_imx: rename driver name to match ll_entry

2020-07-29 Thread Walter Lozano
As discussed in commit rename fsl_esdhc_imx driver to allow the OF_PLATDATA support. Signed-off-by: Walter Lozano Reviewed-by: Simon Glass --- (no changes since v1) drivers/mmc/fsl_esdhc_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/fsl_esdhc_imx.c b

[PATCH v3 2/6] mmc: fsl_esdhc_imx: add OF_PLATDATA support

2020-07-29 Thread Walter Lozano
In order to reduce the footprint of SPL by removing dtb and library overhead, add OF_PLATDATA support to fsl_esdhc_imx. This initial approach does not support card detection, which will be enabled after adding OF_PLATDATA support to GPIO. Signed-off-by: Walter Lozano Reviewed-by: Simon Glass

[PATCH v3 0/6] mx6cuboxi: enable OF_PLATDATA with MMC support

2020-07-29 Thread Walter Lozano
: - Improve commit message with footprint reduction Walter Lozano (6): mmc: fsl_esdhc_imx: rename driver name to match ll_entry mmc: fsl_esdhc_imx: add OF_PLATDATA support gpio: mxc_gpio: add OF_PLATDATA support mmc: fsl_esdhc_imx: add CD support when OF_PLATDATA is enabled drivers: rename

[PATCH v2] dtoc: add coverage test for unicode error

2020-07-28 Thread Walter Lozano
Add an additional test to dtoc in order improve the coverage, specifically to take into account the case of unicode error when scanning drivers. Signed-off-by: Walter Lozano --- Changes in v2: - Add missing files - Extend scan_drivers to use both relative and absolute paths tools/dtoc

Re: [PATCH] dtoc: add coverage test for unicode error

2020-07-28 Thread Walter Lozano
Hi Simon, On 27/7/20 20:35, Simon Glass wrote: Hi Walter, On Mon, 20 Jul 2020 at 12:29, Walter Lozano wrote: Add an additional test to dtoc in order improve the coverage, specifically to take into account the case of unicode error when scanning drivers. Signed-off-by: Walter Lozano

Re: [RFC PATCH v2 0/3] RFC: tiny-dm: Proposal for using driver model in SPL

2020-07-26 Thread Walter Lozano
Hi Simon, On 10/7/20 01:12, Walter Lozano wrote: Hi Simon, On 2/7/20 18:10, Simon Glass wrote: This series provides a proposed enhancement to driver model to reduce overhead in SPL. These patches should not be reviewed other than to comment on the approach. The code is all lumped together

Re: [RFC 3/4] dtoc: add support for generate stuct udevice_id

2020-07-26 Thread Walter Lozano
Hi Simon, On 26/7/20 11:53, Simon Glass wrote: Hi Walter, On Tue, 7 Jul 2020 at 08:08, Walter Lozano wrote: Hi Simon On 6/7/20 16:21, Simon Glass wrote: Hi Walter, On Fri, 19 Jun 2020 at 15:12, Walter Lozano wrote: Based on several reports there is an increasing concern in the impact of

[PATCH v2 2/3] drivers: avoid using aliases on drivers when OF_PLATDATA is enabled

2020-07-22 Thread Walter Lozano
: Walter Lozano --- Changes in v2: - Remove aliases from drivers drivers/gpio/mxs_gpio.c | 10 ++ drivers/mmc/mxsmmc.c| 10 ++ drivers/spi/mxs_spi.c | 10 ++ 3 files changed, 6 insertions(+), 24 deletions(-) diff --git a/drivers/gpio/mxs_gpio.c b/drivers/gpio/mxs_gpio.c

[PATCH v2 1/3] dtoc: look for compatible string aliases in driver list

2020-07-22 Thread Walter Lozano
being declared correctly. This patch adds dtoc's support for try all the compatible strings in the dtb node, in an effort to find the correct driver. Signed-off-by: Walter Lozano --- (no changes since v1) tools/dtoc/dtb_platdata.py | 45 tools

[PATCH v2 3/3] dtoc: remove compatible string aliases support

2020-07-22 Thread Walter Lozano
After latest improvements in dtoc, compatible strings are checked against driver and driver alias list to get a valid driver name. With this new feature the list of compatible string aliases seems not useful any more. Signed-off-by: Walter Lozano --- (no changes since v1) tools/dtoc

[PATCH v2 0/3] dtoc: improve compatible string aliases support

2020-07-22 Thread Walter Lozano
longer needed. Last, remove compatible string aliases from dtoc which were used to generate mappings between struct names. This is not longer needed since now a valid driver name is used. Changes in v2: - Remove aliases from drivers Walter Lozano (3): dtoc: look for compatible string aliases in

Re: [PATCH v2 0/6] mx6cuboxi: enable OF_PLATDATA with MMC support

2020-07-22 Thread Walter Lozano
alter Changes in v2: - Improve commit message with footprint reduction Walter Lozano (6): mmc: fsl_esdhc_imx: rename driver name to match ll_entry mmc: fsl_esdhc_imx: add OF_PLATDATA support gpio: mxc_gpio: add OF_PLATDATA support mmc: fsl_esdhc_imx: add CD support when OF_PLATDATA is en

[PATCH v2 5/6] drivers: rename more drivers to match compatible string

2020-07-22 Thread Walter Lozano
Continuing with the approach in commit rename additional drivers to allow the OF_PLATDATA support. Signed-off-by: Walter Lozano --- (no changes since v1) drivers/pinctrl/nxp/pinctrl-imx6.c | 6 -- drivers/video/imx/mxc_ipuv3_fb.c | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions

[PATCH v2 2/6] mmc: fsl_esdhc_imx: add OF_PLATDATA support

2020-07-22 Thread Walter Lozano
In order to reduce the footprint of SPL by removing dtb and library overhead add OF_PLATDATA support to fsl_esdhc_imx. This initial approach does not support card detection, which will be enabled after adding OF_PLATDATA support to GPIO. Signed-off-by: Walter Lozano --- (no changes since v1

[PATCH v2 1/6] mmc: fsl_esdhc_imx: rename driver name to match ll_entry

2020-07-22 Thread Walter Lozano
As discussed in commit rename fsl_esdhc_imx driver to allow the OF_PLATDATA support. Signed-off-by: Walter Lozano --- (no changes since v1) drivers/mmc/fsl_esdhc_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc

[PATCH v2 3/6] gpio: mxc_gpio: add OF_PLATDATA support

2020-07-22 Thread Walter Lozano
Continuing with the OF_PLATADATA support for iMX6 to reduce SPL footprint, add it to mxc_gpio. Thanks to this, it will be possible to enable card detection on MMC driver. Signed-off-by: Walter Lozano --- (no changes since v1) drivers/gpio/mxc_gpio.c | 18 +- 1 file changed, 17

[PATCH v2 0/6] mx6cuboxi: enable OF_PLATDATA with MMC support

2020-07-22 Thread Walter Lozano
CD, the OF_PLATDATA support is also implemented on GPIO driver. Changes in v2: - Improve commit message with footprint reduction Walter Lozano (6): mmc: fsl_esdhc_imx: rename driver name to match ll_entry mmc: fsl_esdhc_imx: add OF_PLATDATA support gpio: mxc_gpio: add OF_PLATDATA support

Re: [PATCH 6/6] mx6cuboxi: enable OF_PLATDATA

2020-07-22 Thread Walter Lozano
Hi Fabio, On 21/7/20 17:58, Fabio Estevam wrote: Hi Walter, On Tue, Jul 21, 2020 at 2:24 PM Walter Lozano wrote: As both MMC and GPIO driver now supports OF_PLATDATA, enable it in defconfig in order to reduce the SPL footprint. Could you add in the commit log how many kB of SPL size

[PATCH v2 6/6] mx6cuboxi: enable OF_PLATDATA

2020-07-22 Thread Walter Lozano
As both MMC and GPIO driver now supports OF_PLATDATA, enable it in defconfig in order to reduce the SPL footprint. After applying this setting the SPL reduction is 5 KB, which partially compensates the increment due to DM. Signed-off-by: Walter Lozano --- Changes in v2: - Improve commit message

[PATCH v2 4/6] mmc: fsl_esdhc_imx: add CD support when OF_PLATDATA is enabled

2020-07-22 Thread Walter Lozano
After enabling OF_PLATDATA support to both MMC and GPIO drivers add the support for card detection. Signed-off-by: Walter Lozano --- (no changes since v1) drivers/mmc/fsl_esdhc_imx.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/mmc

[PATCH 5/6] drivers: rename more drivers to match compatible string

2020-07-21 Thread Walter Lozano
Continuing with the approach in commit rename additional drivers to allow the OF_PLATDATA support. Signed-off-by: Walter Lozano --- drivers/pinctrl/nxp/pinctrl-imx6.c | 6 -- drivers/video/imx/mxc_ipuv3_fb.c | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a

[PATCH 6/6] mx6cuboxi: enable OF_PLATDATA

2020-07-21 Thread Walter Lozano
As both MMC and GPIO driver now supports OF_PLATDATA, enable it in defconfig in order to reduce the SPL footprint. Signed-off-by: Walter Lozano --- configs/mx6cuboxi_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/mx6cuboxi_defconfig b/configs/mx6cuboxi_defconfig index

[PATCH 4/6] mmc: fsl_esdhc_imx: add CD support when OF_PLATDATA is enabled

2020-07-21 Thread Walter Lozano
After enabling OF_PLATDATA support to both MMC and GPIO drivers add the support for card detection. Signed-off-by: Walter Lozano --- drivers/mmc/fsl_esdhc_imx.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers

[PATCH 3/6] gpio: mxc_gpio: add OF_PLATDATA support

2020-07-21 Thread Walter Lozano
Continuing with the OF_PLATADATA support for iMX6 to reduce SPL footprint, add it to mxc_gpio. Thanks to this, it will be possible to enable card detection on MMC driver. Signed-off-by: Walter Lozano --- drivers/gpio/mxc_gpio.c | 18 +- 1 file changed, 17 insertions(+), 1

[PATCH 1/6] mmc: fsl_esdhc_imx: rename driver name to match ll_entry

2020-07-21 Thread Walter Lozano
As discussed in commit rename fsl_esdhc_imx driver to allow the OF_PLATDATA support. Signed-off-by: Walter Lozano --- drivers/mmc/fsl_esdhc_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c index 5b61eeb214

[PATCH 2/6] mmc: fsl_esdhc_imx: add OF_PLATDATA support

2020-07-21 Thread Walter Lozano
In order to reduce the footprint of SPL by removing dtb and library overhead add OF_PLATDATA support to fsl_esdhc_imx. This initial approach does not support card detection, which will be enabled after adding OF_PLATDATA support to GPIO. Signed-off-by: Walter Lozano --- drivers/mmc

[PATCH 0/6] mx6cuboxi: enable OF_PLATDATA with MMC support

2020-07-21 Thread Walter Lozano
CD, the OF_PLATDATA support is also implemented on GPIO driver. Walter Lozano (6): mmc: fsl_esdhc_imx: rename driver name to match ll_entry mmc: fsl_esdhc_imx: add OF_PLATDATA support gpio: mxc_gpio: add OF_PLATDATA support mmc: fsl_esdhc_imx: add CD support when OF_PLATDATA is enabled

[PATCH] dtoc: add coverage test for unicode error

2020-07-20 Thread Walter Lozano
Add an additional test to dtoc in order improve the coverage, specifically to take into account the case of unicode error when scanning drivers. Signed-off-by: Walter Lozano --- tools/dtoc/dtb_platdata.py | 14 +++--- tools/dtoc/test_dtoc.py| 18 ++ 2 files changed

Re: dtoc code-coverage tests

2020-07-19 Thread Walter Lozano
Hi Simon, On 19/7/20 15:30, Simon Glass wrote: Hi Walter, I am seeing a test failure with code coverage - it is at 99%. It looks to be due to an exception that doesn't occur in the tests (UnicodeDecodeError). Could you please take a look? You should be able to test it by calling scan_driver wi

[PATCH 2/2] dtoc: remove compatible string aliases support

2020-07-16 Thread Walter Lozano
After latest improvements in dtoc, compatible strings are checked against driver and driver alias list to get a valid driver name. With this new feature the list of compatible string aliases seems not useful any more. Signed-off-by: Walter Lozano --- tools/dtoc/dtb_platdata.py | 13

[PATCH 0/2] dtoc: improve compatible string aliases support

2020-07-16 Thread Walter Lozano
to generate mappings between struct names. This is not longer needed since now a valid driver name is used. Walter Lozano (2): dtoc: look for compatible string aliases in driver list dtoc: remove compatible string aliases support tools/dtoc/dtb_platdata.py | 58

[PATCH 1/2] dtoc: look for compatible string aliases in driver list

2020-07-16 Thread Walter Lozano
being declared correctly. This patch adds dtoc's support for try all the compatible strings in the dtb node, in an effort to find the correct driver. Signed-off-by: Walter Lozano --- tools/dtoc/dtb_platdata.py | 45 tools/dtoc/dtoc_test_aliases.dts

Re: [RFC PATCH v2 0/3] RFC: tiny-dm: Proposal for using driver model in SPL

2020-07-09 Thread Walter Lozano
Hi Simon, On 2/7/20 18:10, Simon Glass wrote: This series provides a proposed enhancement to driver model to reduce overhead in SPL. These patches should not be reviewed other than to comment on the approach. The code is all lumped together in a few patches and so cannot be applied as is. For

Re: [RFC 1/4] dtoc: add POC for dtb shrink

2020-07-07 Thread Walter Lozano
Hi Rasmus, On 7/7/20 11:53, Rasmus Villemoes wrote: On 07/07/2020 16.32, Walter Lozano wrote: Hi Rasmus, On 7/7/20 11:15, Rasmus Villemoes wrote: On 19/06/2020 23.11, Walter Lozano wrote: Some additional reduction could be possible by only keeping the nodes for whose compatible string is

Re: [RFC 1/4] dtoc: add POC for dtb shrink

2020-07-07 Thread Walter Lozano
Hi Rasmus, On 7/7/20 11:15, Rasmus Villemoes wrote: On 19/06/2020 23.11, Walter Lozano wrote: Some additional reduction could be possible by only keeping the nodes for whose compatible string is supported by any enabled driver. However, this requires to add extra logic to parse config files

Re: [RFC 3/4] dtoc: add support for generate stuct udevice_id

2020-07-07 Thread Walter Lozano
Hi Simon On 6/7/20 16:21, Simon Glass wrote: Hi Walter, On Fri, 19 Jun 2020 at 15:12, Walter Lozano wrote: Based on several reports there is an increasing concern in the impact of adding additional features to drivers based on compatible strings. A good example of this situation is found in

Re: [RFC 1/4] dtoc: add POC for dtb shrink

2020-07-07 Thread Walter Lozano
Hi Simon, Thanks for your time. On 6/7/20 16:21, Simon Glass wrote: Hi Walter, On Fri, 19 Jun 2020 at 15:11, Walter Lozano wrote: Based on several reports and discussions [1], [2] it is clear that U-Boot's footprint is always a concern, and any kind of reduction is an improvement

Re: [RFC 2/4] dtoc: add initial support for deleting DTB nodes

2020-07-07 Thread Walter Lozano
Hi Simon, On 6/7/20 16:21, Simon Glass wrote: Hi Walter, On Fri, 19 Jun 2020 at 15:12, Walter Lozano wrote: This patch introduce a test for deleting DTB nodes using Python library. Signed-off-by: Walter Lozano --- tools/dtoc/dtb_platdata.py | 28 tools/dtoc

Re: [PATCH v1 1/1] mkimage: Fix error message if write less data then expected

2020-07-07 Thread Walter Lozano
Hi Mylene, On 7/7/20 05:25, Mylene Josserand wrote: Hi, On 6/9/20 8:49 PM, Walter Lozano wrote: Hi Mylene, Thanks for you patch. On 5/6/20 05:01, Mylène Josserand wrote: Add a new error message in case the size of data written are shorter than the one expected. Currently, it will lead to

Re: [PATCH v5 04/14] dtoc: add support to scan drivers

2020-07-03 Thread Walter Lozano
Hi Simon, On 3/7/20 13:08, Simon Glass wrote: Hi Walter, On Fri, 3 Jul 2020 at 05:07, Walter Lozano wrote: Currently dtoc scans dtbs to convert them to struct platdata and to generate U_BOOT_DEVICE entries. These entries need to be filled with the driver name, but at this moment the

Re: [PATCH v4 04/14] dtoc: add support to scan drivers

2020-07-03 Thread Walter Lozano
On 2/7/20 16:47, Simon Glass wrote: Hi Walter, On Thu, 25 Jun 2020 at 19:43, Simon Glass wrote: On Wed, 24 Jun 2020 at 22:10, Walter Lozano wrote: Currently dtoc scans dtbs to convert them to struct platdata and to generate U_BOOT_DEVICE entries. These entries need to be filled with the

[PATCH v5 04/14] dtoc: add support to scan drivers

2020-07-03 Thread Walter Lozano
case a name is not valid. Signed-off-by: Walter Lozano --- (no changes since v1) tools/dtoc/dtb_platdata.py| 91 +-- tools/dtoc/dtoc_test_driver_alias.dts | 20 ++ tools/dtoc/test_dtoc.py | 33 ++ 3 files changed, 140 insertions(+), 4

Re: [PATCH v6 1/3] gpio-uclass.c: save the GPIOD flags also in the gpio descriptor

2020-07-02 Thread Walter Lozano
On 30/6/20 13:19, Walter Lozano wrote: Hi Heiko On 22/5/20 06:08, Heiko Schocher wrote: save the GPIOD_ flags also in the gpio descriptor. Signed-off-by: Heiko Schocher Reviewed-by: Patrick Delaunay Fixes: 788ea834124b ("gpio: add function _dm_gpio_set_dir_flags") Thanks fo

Re: [PATCH] rockchip: rk3399: allow deselecting SPL_ATF_NO_PLATFORM_PARAM

2020-06-30 Thread Walter Lozano
s it possible to get console output at the correct baudrate on TF. Tested-by: Walter Lozano Regards, Walter --- For some background, see this thread on the TF-A list [1]. Since the corresponding required change isn't in a tagged version of TF-A yet, and I don't know how many RK3399

Re: [PATCH v6 1/3] gpio-uclass.c: save the GPIOD flags also in the gpio descriptor

2020-06-30 Thread Walter Lozano
Hi Heiko On 22/5/20 06:08, Heiko Schocher wrote: save the GPIOD_ flags also in the gpio descriptor. Signed-off-by: Heiko Schocher Reviewed-by: Patrick Delaunay Fixes: 788ea834124b ("gpio: add function _dm_gpio_set_dir_flags") Thanks for this fix, without it the MMC driver of my iMX6 Humming

Re: [RFC 0/4] drivers: footprint reduction proposal

2020-06-26 Thread Walter Lozano
Hi Tom, On 22/6/20 12:25, Walter Lozano wrote: Hi Tom, On 22/6/20 11:20, Tom Rini wrote: On Mon, Jun 22, 2020 at 11:12:40AM -0300, Walter Lozano wrote: Hi Tom, On 19/6/20 18:48, Tom Rini wrote: On Fri, Jun 19, 2020 at 06:11:36PM -0300, Walter Lozano wrote: Based on several reports and

Re: [PATCH v4 02/14] dtoc: add missing code comments

2020-06-26 Thread Walter Lozano
Hi Simon, On 25/6/20 22:42, Simon Glass wrote: On Wed, 24 Jun 2020 at 22:10, Walter Lozano wrote: Add missing information about internal class members in order to make the code easier to follow. Signed-off-by: Walter Lozano --- tools/dtoc/dtb_platdata.py | 3 +++ 1 file changed, 3

Re: [PATCH v4 12/14] arm: dts: include gpio nodes for card detect

2020-06-26 Thread Walter Lozano
Hi Adam, On 26/6/20 09:26, Adam Ford wrote: On Thu, Jun 25, 2020 at 11:37 PM Adam Ford wrote: On Wed, Jun 24, 2020 at 11:11 PM Walter Lozano wrote: Several MMC drivers use GPIO for card detection with cd-gpios property in the MMC node pointing to a GPIO node. However, as U-Boot tries to

[PATCH v3 00/14] improve OF_PLATDATA support

2020-06-25 Thread Walter Lozano
coverage - Improve documentation - Improve format Walter Lozano (14): drivers: rename drivers to match compatible string dtoc: add missing code comments core: add support for U_BOOT_DRIVER_ALIAS dtoc: add support to scan drivers dtoc: add option to disable warnings dm: doc: update of-p

[PATCH v4 00/14] improve OF_PLATDATA support

2020-06-25 Thread Walter Lozano
Fix out-of-trees usage of dtoc - Fix test coverage - Improve documentation - Improve format Walter Lozano (14): drivers: rename drivers to match compatible string dtoc: add missing code comments core: add support for U_BOOT_DRIVER_ALIAS dtoc: add support to scan drivers dtoc: add o

[PATCH v4 13/14] dtoc: update dtb_platdata to support cd-gpios

2020-06-24 Thread Walter Lozano
Currently dtoc does not support the property cd-gpios used to declare the gpios for card detect in mmc. This patch adds support to cd-gpios property. Signed-off-by: Walter Lozano --- tools/dtoc/dtb_platdata.py | 16 ++-- tools/dtoc/test_dtoc.py| 2 +- 2 files changed, 11

[PATCH v4 10/14] dtoc: extend dtoc to use struct driver_info when linking nodes

2020-06-24 Thread Walter Lozano
extends dtoc to use struct driver_info when populating information about linked nodes, which makes it easier to later get the devices created. In this context, reimplement functions like clk_get_by_index_platdata() which made use of the previous approach. Signed-off-by: Walter Lozano --- drivers

[PATCH v4 12/14] arm: dts: include gpio nodes for card detect

2020-06-24 Thread Walter Lozano
associated to cd-gpios. This patch, fixes several ocurrence of this issue. Signed-off-by: Walter Lozano --- arch/arm/dts/da850-evm-u-boot.dtsi| 4 arch/arm/dts/da850-lcdk-u-boot.dtsi | 4 arch/arm/dts/rk3288-u-boot.dtsi | 4 arch/arm/dts/rk3288

[PATCH v4 11/14] dm: doc: update of-plat with new phandle support

2020-06-24 Thread Walter Lozano
Update documentation to reflect the new phandle support when OF_PLATDATA is used. Now phandles are implemented as pointers to U_BOOT_DEVICE, which makes it possible to get a pointer to the actual device. Signed-off-by: Walter Lozano --- doc/driver-model/of-plat.rst | 24

[PATCH v4 09/14] sandbox: Move section u_boot_list to make it RW

2020-06-24 Thread Walter Lozano
In order to be able to update data in u_boot_list, move this section to make it RW. Signed-off-by: Walter Lozano --- arch/sandbox/cpu/u-boot-spl.lds | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sandbox/cpu/u-boot-spl.lds b/arch/sandbox/cpu/u-boot-spl.lds index

[PATCH v4 14/14] dtoc: add test for cd-gpios

2020-06-24 Thread Walter Lozano
Add a test for dtoc taking into account the cd-gpios property. Signed-off-by: Walter Lozano --- tools/dtoc/dtoc_test_phandle_cd_gpios.dts | 42 ++ tools/dtoc/test_dtoc.py | 67 +++ 2 files changed, 109 insertions(+) create mode 100644 tools

[PATCH v4 08/14] core: extend struct driver_info to point to device

2020-06-24 Thread Walter Lozano
driver_info adding a pointer to udevice which is populated during the bind process, allowing to generate a set of functions to get the device based on its struct driver_info. Signed-off-by: Walter Lozano --- drivers/core/device.c | 26 +++--- drivers/core/root.c | 4

[PATCH v4 03/14] core: add support for U_BOOT_DRIVER_ALIAS

2020-06-24 Thread Walter Lozano
. Signed-off-by: Walter Lozano --- drivers/clk/at91/pmc.c| 2 ++ drivers/gpio/mxs_gpio.c | 2 ++ drivers/gpio/sandbox.c| 2 ++ drivers/i2c/rk_i2c.c | 2 ++ drivers/mmc/mxsmmc.c | 1 + drivers/mmc/rockchip_dw_mmc.c | 3 +++ drivers

[PATCH v4 07/14] core: drop const for struct driver_info

2020-06-24 Thread Walter Lozano
In order to prepare for a new support of phandle when OF_PLATDATA is used drop the const for struct driver_info as this struct will need to be updated on runtime. Signed-off-by: Walter Lozano --- drivers/core/device.c| 2 +- drivers/core/root.c | 2 +- include/dm/device

[PATCH v4 04/14] dtoc: add support to scan drivers

2020-06-24 Thread Walter Lozano
case a name is not valid. Signed-off-by: Walter Lozano --- tools/dtoc/dtb_platdata.py | 91 -- tools/dtoc/test_dtoc.py| 33 ++ 2 files changed, 120 insertions(+), 4 deletions(-) diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc

[PATCH v4 05/14] dtoc: add option to disable warnings

2020-06-24 Thread Walter Lozano
As dtoc now performs checks for valid driver names, when running dtoc tests several warnings arise as these tests don't use valid driver names. This patch adds an option to disable those warning, which is only intended for running tests. Signed-off-by: Walter Lozano --- tools

[PATCH v4 06/14] dm: doc: update of-plat with the support for driver aliases

2020-06-24 Thread Walter Lozano
Update the documentation with the support for driver aliases using U_BOOT_DRIVER_ALIAS. Signed-off-by: Walter Lozano --- doc/driver-model/of-plat.rst | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/doc/driver-model/of-plat.rst b/doc/driver-model/of-plat.rst

[PATCH v4 02/14] dtoc: add missing code comments

2020-06-24 Thread Walter Lozano
Add missing information about internal class members in order to make the code easier to follow. Signed-off-by: Walter Lozano --- tools/dtoc/dtb_platdata.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py index ecfe0624d1

[PATCH v4 01/14] drivers: rename drivers to match compatible string

2020-06-24 Thread Walter Lozano
the linker list and the used in the struct driver_info. In order to make things a bit more clear, rename the drivers names. This will also help for further OF_PLATDATA improvements, such as checking for valid driver names. Signed-off-by: Walter Lozano --- .../mach-at91/arm926ejs

[PATCH v3 14/14] dtoc: add test for cd-gpios

2020-06-24 Thread Walter Lozano
Add a test for dtoc taking into account the cd-gpios property. Signed-off-by: Walter Lozano --- tools/dtoc/dtoc_test_phandle_cd_gpios.dts | 42 ++ tools/dtoc/test_dtoc.py | 67 +++ 2 files changed, 109 insertions(+) create mode 100644 tools

[PATCH v3 13/14] dtoc: update dtb_platdata to support cd-gpios

2020-06-24 Thread Walter Lozano
Currently dtoc does not support the property cd-gpios used to declare the gpios for card detect in mmc. This patch adds support to cd-gpios property. Signed-off-by: Walter Lozano --- tools/dtoc/dtb_platdata.py | 16 ++-- tools/dtoc/test_dtoc.py| 2 +- 2 files changed, 11

[PATCH v3 08/14] core: extend struct driver_info to point to device

2020-06-24 Thread Walter Lozano
driver_info adding a pointer to udevice which is populated during the bind process, allowing to generate a set of functions to get the device based on its struct driver_info. Signed-off-by: Walter Lozano --- drivers/core/device.c | 26 +++--- drivers/core/root.c | 4

  1   2   3   >