Re: [PATCH] board: ti: am62x: Add variable device tree in env

2023-07-31 Thread Andrew Davis
the DT to load for kernel (in theory these should have the same name but it still feels like a misuse). How about we just skip to removing this logic as you suggest, set name_fdt directly and remove the `default_device_tree` env var. Andrew Signed-off-by: Jason Kacines --- board/ti/am62x

Re: [PATCH v2 1/2] board: ti: am64x: Recognize AM64-HSEVM

2023-07-31 Thread Andrew Davis
On 7/31/23 7:27 AM, Roger Quadros wrote: AM64-HSEVM is AM64-GPEVM with High Security Device. Gets rid of "Unidentified board claims AM64-HSEVM in eeprom header". Signed-off-by: Roger Quadros --- Acked-by: Andrew Davis board/ti/am64x/evm.c | 3 ++- 1 file changed, 2 insert

Re: [PATCH V2 1/3] omap: timer: add ti,am654-timer compatibility

2023-07-26 Thread Andrew Davis
On 7/26/23 10:10 AM, Nishanth Menon wrote: From: Sjoerd Simons THe TI AM654 timer is compatible with the omap-timer implementation, so s/THe/The add it to the id list s/id list/compatible ID list. Andrew Signed-off-by: Sjoerd Simons Reviewed-by: Tom Rini Tested-by: Ravi Gunasekaran

Re: [PATCH 6/6] doc: board: ti: Add beagleplay documentation

2023-07-26 Thread Andrew Davis
t now, but after that it will be automatic. Not sure if it is worth documenting a flag that is going away.. Andrew

Re: [PATCH 6/6] doc: board: ti: Add beagleplay documentation

2023-07-26 Thread Andrew Davis
On 7/26/23 11:21 AM, Tom Rini wrote: On Wed, Jul 26, 2023 at 09:59:16AM -0500, Andrew Davis wrote: On 7/25/23 5:45 PM, Tom Rini wrote: On Tue, Jul 25, 2023 at 05:00:15PM -0500, Nishanth Menon wrote: On 17:35-20230725, Tom Rini wrote: On Tue, Jul 25, 2023 at 01:52:53PM -0500, Nishanth Menon

[PATCH v2 2/2] configs: keystone2: Change to using env files

2023-07-25 Thread Andrew Davis
Move to using .env file for setting up environment variables for K2x_evm. Signed-off-by: Andrew Davis --- board/ti/ks2_evm/Kconfig | 12 +++ board/ti/ks2_evm/k2e_evm.env | 12 +++ board/ti/ks2_evm/k2g_evm.env | 45 + board/ti

[PATCH v2 1/2] configs: keystone2: Unwind KERNEL_MTD_PARTS definition

2023-07-25 Thread Andrew Davis
This is more complex than it needs to be and makes converting these boards over to plain text env files more difficult. Remove setting mtdparts as the DTS already contain the partitions. While here also drop the conflicting definitions from the K2 defconfigs. Signed-off-by: Andrew Davis

Re: [PATCH 1/2] configs: keystone2: Unwind KERNEL_MTD_PARTS definition

2023-07-25 Thread Andrew Davis
On 7/25/23 12:18 PM, Tom Rini wrote: On Tue, Jul 25, 2023 at 11:40:58AM -0500, Andrew Davis wrote: This is more complex than it needs to be and makes converting these boards over to plain text env files more difficult. Simplify this environment variable scheme. Signed-off-by: Andrew Davis

[PATCH 2/2] configs: keystone2: Change to using env files

2023-07-25 Thread Andrew Davis
Move to using .env file for setting up environment variables for K2x_evm. Signed-off-by: Andrew Davis --- board/ti/ks2_evm/Kconfig | 12 +++ board/ti/ks2_evm/k2e_evm.env | 13 +++ board/ti/ks2_evm/k2g_evm.env | 46 + board/ti

[PATCH 1/2] configs: keystone2: Unwind KERNEL_MTD_PARTS definition

2023-07-25 Thread Andrew Davis
This is more complex than it needs to be and makes converting these boards over to plain text env files more difficult. Simplify this environment variable scheme. Signed-off-by: Andrew Davis --- include/configs/k2e_evm.h| 5 + include/configs/k2g_evm.h| 4

[PATCH 2/2] ti: keystone2: Move common Kconfig selections to under ARCH_KEYSTONE

2023-07-25 Thread Andrew Davis
These select/imply settings are common to the whole architecture not just these boards, move these settings to the architecture config. Signed-off-by: Andrew Davis --- arch/arm/Kconfig | 5 + arch/arm/mach-keystone/Kconfig | 20 2 files changed, 5

[PATCH 1/2] ti: keystone2: Imply NFS command support

2023-07-25 Thread Andrew Davis
TI KS2 boards have the nfs command in their common environment boot configuration, enable this command. Signed-off-by: Andrew Davis --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index bdd535fd73f..c019e56d404 100644 --- a/arch/arm

[PATCH] MAINTAINERS: Take maintainership of TI KeyStone2 support

2023-07-25 Thread Andrew Davis
Add arch/arm/mach-keystone/ into K2 board directory MAINTAINERS file. Convert current entries into regex match style. Assign maintainership to myself. Signed-off-by: Andrew Davis --- board/ti/ks2_evm/MAINTAINERS | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff

[PATCH] configs: k2x_evm: Always include FIT loading support

2023-07-14 Thread Andrew Davis
Non-HS boards can use FIT images so include the env var commands for these unconditionally. Signed-off-by: Andrew Davis --- include/configs/k2e_evm.h | 11 ++- include/configs/k2hk_evm.h | 11 ++- include/configs/k2l_evm.h | 11 ++- 3 files changed, 6 insertions(+), 27

Re: [PATCH 14/18] board: ti: keys: add .key and .crt for fit signature signing

2023-07-14 Thread Andrew Davis
reasonable cleanups. But the second half I'm not so sure about and depends on the binman patches. Andrew 2 files changed, 84 insertions(+) diff --git a/board/ti/keys/custMpk.crt b/board/ti/keys/custMpk.crt new file mode 100644 index ..01bd64aae577 --- /dev/null +++ b/board/ti

Re: [PATCH 01/18] arch: mach-k3: security: fix the check for authentication

2023-07-14 Thread Andrew Davis
for both == GP and != HS-SE? Seems like this logic could still be buggy. Could you explain here exactly what you are trying to do here. Andrew +!ti_secure_cert_detected(*p_image))) return; /* Clean out image so it can be seen by system firmware */

Re: [PATCH v1 1/3] arm: k3: Fix ft_system_setup so it can be enabled on any SoC

2023-07-12 Thread Andrew Davis
On 7/12/23 9:32 AM, Francesco Dolcini wrote: On Wed, Jul 12, 2023 at 09:15:21AM -0500, Andrew Davis wrote: On 7/12/23 8:47 AM, Francesco Dolcini wrote: From: Emanuele Ghidoli ft_system_setup cannot be enabled on SoC without msmc sram otherwise fdt_fixup_msmc_ram function fails causing system

Re: [PATCH v1 2/3] arm: mach-k3: am62: Add CTRLMMR_WKUP_JTAG_DEVICE_ID register definition

2023-07-12 Thread Andrew Davis
0x4300 +#define CTRLMMR_WKUP_JTAG_DEVICE_ID (WKUP_CTRL_MMR0_BASE + 0x18) We have similar defines in arch/arm/mach-k3/include/mach/hardware.h, if these are common that might be a better spot. Andrew +#define JTAG_DEV_ID_MASK GENMASK(31, 18) +#define

Re: [PATCH v1 1/3] arm: k3: Fix ft_system_setup so it can be enabled on any SoC

2023-07-12 Thread Andrew Davis
hat needed it. Andrew { - int ret; - - ret = fdt_fixup_msmc_ram(blob, "/bus@10", "sram@7000"); - if (ret < 0) - ret = fdt_fixup_msmc_ram(blob, "/interconnect@10", -"sram@700

Re: [PATCH v4] dt-bindings: riscv: deprecate riscv,isa

2023-07-01 Thread Andrew Jones
On Fri, Jun 30, 2023 at 07:04:04PM +0100, Conor Dooley wrote: > From: Conor Dooley ... > +oneOf: > + - required: > + - riscv,isa > + - required: > + - riscv,isa-base > + I guess this means a DT must have either isa or isa-base, but not both. What should QEMU and other platforms which

Re: [PATCH v4 23/23] configs: am64x: Enable TI_SECURE_DEV options

2023-05-22 Thread Andrew Davis
On 5/22/23 7:35 AM, Kamlesh Gurudasani wrote: Neha Malcom Francis writes: Hi Andrew On 18/05/23 22:09, Andrew Davis wrote: On 5/18/23 9:27 AM, Neha Malcom Francis wrote: From: Kamlesh Gurudasani AM64x family of SoCs by default will have some level of security enforcement checking. Enable

Re: [PATCH v4 23/23] configs: am64x: Enable TI_SECURE_DEV options

2023-05-18 Thread Andrew Davis
Signed-off-by: Neha Francis Signed-off-by: Neha Malcom Francis --- This fix is independent of the binman changes and should go in first anyway to keep bisectability. Andrew configs/am64x_evm_a53_defconfig | 1 + configs/am64x_evm_r5_defconfig | 1 + 2 files changed, 2 insertions(+) diff

Re: [PATCH v4 05/23] j721e: dts: binman: Package tiboot3.bin, sysfw.itb, tispl.bin, u-boot.img

2023-05-18 Thread Andrew Davis
ts just fine on GP devices as SPL knows how to strip out the signature during boot when it detects it is running on a GP device. None of the above is a big deal and nothing worth holding up this series over, I'll send patches later after this is taken into -next. Andrew

Re: [PATCH v1] dt-bindings: riscv: deprecate riscv,isa

2023-05-18 Thread Andrew Jones
=== > > Create a new file to store the extension meanings, each in the form > riscv,isa-extension- and a new riscv,isa-base property to replace > the missing aspect of riscv,isa - the base ISA implemented by a hart. > As a starting point, properties were added for extensions currently use

Re: [PATCH] arm: mach-k3: arm64-mmu: do not map ATF and OPTEE regions in A53 MMU

2023-05-11 Thread Andrew Davis
region are at different location for am64 and am62/am62a. We should find a way to get the reserved regions from DT, this table is growing unmaintainable. Andrew Signed-off-by: Kamlesh Gurudasani --- arch/arm/mach-k3/arm64-mmu.c | 64 +--- 1 file changed, 59

Re: [PATCH] firmware: ti_sci: Add missing LF in error message

2023-05-10 Thread Andrew Davis
00: Message not acknowledgedAuthentication failed!" Fix ths by adding the missing linefeed character. s/ths/this Signed-off-by: Andreas Dannenberg --- Good find, Acked-by: Andrew Davis drivers/firmware/ti_sci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v2] arch: arm: mach-k3: Delete tifs node in DT fixup

2023-05-01 Thread Andrew Davis
e and hiding this. Same story for TIFS and ATF, they use some variable amount of the end of SRAM. I'd prefer being explicit and keep these nodes. Andrew But in any case, u-boot removes this code before passing to OS. https://elixir.bootlin.com/u-boot/latest/source/arch/arm/mach-k3/com

Re: [PATCH v3 11/19] am64x: dts: binman: Package tiboot3.bin, tispl.bin u-boot.img

2023-04-25 Thread Andrew Davis
SYSFW binaries available with them. Would this ever need to happen? We provide all three firmware types for all our SoCs out in public[0], why would anyone only have one type of firmware available? Andrew [0] https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/tree/ti-sysfw?h=ti-

[PATCH] environment: ti: Add get_fit_config command to get FIT config string

2023-04-25 Thread Andrew Davis
lt is fdtfile needs mangled when used to select a config node from OE made FIT image. Do this here. Signed-off-by: Andrew Davis --- include/configs/ti_armv7_common.h | 3 ++- include/environment/ti/ti_armv7_common.env | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --gi

[PATCH 10/17] arm: dts: am3x: Update IOPAD to PADCONF to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Several DTS files have been updated in the Linux kernel with a new PADCONF macro replacing the IOPAD version. Sync for the same here. Signed-off-by: Andrew Davis --- arch/arm/dts/am335x-base0033.dts| 48 ++-- arch/arm/dts/am335x-chiliboard.dts | 66 +++--- arch/arm/dts/am335x

[PATCH 16/17] arm: dts: keystone: Non-functional changes sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
This is a collection of all the whitespace, renames, comment, and other changes that should not change the DT functionality from Linux v6.3-rc6. Signed-off-by: Andrew Davis --- arch/arm/dts/keystone-clocks.dtsi | 52 +- arch/arm/dts/keystone-k2e-clocks.dtsi | 8 +-- arch

[PATCH 13/17] arm: dts: dra7x: Non-functional changes sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
This is a collection of all the whitespace, renames, comment, and other changes that should not change the DT functionality from Linux v6.3-rc6. Signed-off-by: Andrew Davis --- arch/arm/dts/am571x-idk.dts| 6 +- arch/arm/dts/am572x-idk-common.dtsi| 8 +- arch/arm/dts

[PATCH 11/17] arm: dts: am437x: Update to IOPAD to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Several DTS files have been updated in the Linux kernel with a new IOPAD macro. Sync for the same here. Signed-off-by: Andrew Davis --- arch/arm/dts/am437x-gp-evm.dts | 315 - arch/arm/dts/am437x-sk-evm.dts | 290 +++--- 2 files changed

[PATCH 12/17] arm: dts: am3x: Non-functional changes sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
This is a collection of all the whitespace, renames, comment, and other changes that should not change the DT functionality from Linux v6.3-rc6. Signed-off-by: Andrew Davis --- arch/arm/dts/am335x-bone-common.dtsi | 1 - arch/arm/dts/am335x-boneblack-hdmi.dtsi | 7 +- arch

[PATCH 15/17] arm: dts: omap: Non-functional changes sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
This is a collection of all the whitespace, renames, comment, and other changes that should not change the DT functionality from Linux v6.3-rc6. Signed-off-by: Andrew Davis --- arch/arm/dts/omap-gpmc-smsc911x.dtsi | 6 ++-- arch/arm/dts/omap-gpmc-smsc9221.dtsi | 6 ++-- arch

[PATCH 14/17] arm: dts: dm8x: Non-functional changes sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
This is a collection of all the whitespace, renames, comment, and other changes that should not change the DT functionality from Linux v6.3-rc6. Signed-off-by: Andrew Davis --- arch/arm/dts/da850-evm.dts | 20 ++-- arch/arm/dts/da850-lego-ev3.dts | 2 +- arch/arm/dts/da850

[PATCH 08/17] arm: dts: omap5x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/omap5-board-common.dtsi | 2 +- arch/arm/dts/omap5-core-thermal.dtsi | 7 ++- arch/arm/dts/omap5-gpu-thermal.dtsi | 7 ++- arch/arm/dts/omap5-uevm.dts | 2 +- arch/arm/dts/omap5.dtsi | 2 +- 5 files changed, 7 insertions

[PATCH 17/17] Revert "arm: dts: dra7*/am57xx-idk-evm-u-boot: Add ipu early boot DT changes"

2023-04-11 Thread Andrew Davis
This reverts commit 5717294230bc3578959960003be898433642. This does not exist in upstream kernel.org and breaks boot on DRA7-EVMs. Drop the same. Signed-off-by: Andrew Davis --- arch/arm/dts/am57xx-idk-common-u-boot.dtsi | 1 - arch/arm/dts/dra7-evm-u-boot.dtsi | 1 - arch/arm/dts

[PATCH 09/17] arm: dts: keystone: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/keystone-clocks.dtsi | 7 ++- arch/arm/dts/keystone-k2e-clocks.dtsi | 7 ++- arch/arm/dts/keystone-k2e-evm.dts | 7 ++- arch/arm/dts/keystone-k2e-netcp.dtsi | 7 ++- arch/arm/dts/keystone-k2e.dtsi | 7 ++- arch

[PATCH 01/17] arm: dts: am3x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/am335x-base0033.dts| 5 + arch/arm/dts/am335x-chiliboard.dts | 7 ++- arch/arm/dts/am335x-chilisom.dtsi | 7 ++- arch/arm/dts/am335x-evm.dts | 7 ++- arch/arm/dts/am335x-evmsk.dts | 7

[PATCH 07/17] arm: dts: omap4x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/omap4-cpu-thermal.dtsi | 7 ++- arch/arm/dts/omap4-panda-common.dtsi | 2 +- arch/arm/dts/omap4-panda-es.dts | 2 +- arch/arm/dts/omap4-panda.dts | 2 +- arch/arm/dts/omap4-sdp-es23plus.dts | 2 +- arch/arm/dts/omap4-sdp.dts

[PATCH 00/17] Sync TI Device Trees with Linux v6.3-rc6

2023-04-11 Thread Andrew Davis
the only functional change, it fixes boot on DRA7-EVMs. Thanks, Andrew Andrew Davis (17): arm: dts: am3x: Update devicetree header comments to sync with v6.3-rc6 arm: dts: am43x: Update devicetree header comments to sync with v6.3-rc6 arm: dts: am57x: Update devicetree header

[PATCH 02/17] arm: dts: am43x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/am4372.dtsi| 7 ++- arch/arm/dts/am437x-gp-evm.dts | 7 ++- arch/arm/dts/am437x-idk-evm.dts | 7 ++- arch/arm/dts/am437x-sk-evm.dts | 7 ++- arch/arm/dts/am43x-epos-evm.dts | 7 ++- arch/arm/dts/am43xx-clocks.dtsi | 5

[PATCH 05/17] arm: dts: dra7x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/dra7-dspeve-thermal.dtsi | 7 ++- arch/arm/dts/dra7-evm-common.dtsi | 7 ++- arch/arm/dts/dra7-evm.dts | 7 ++- arch/arm/dts/dra7-iva-thermal.dtsi| 7 ++- arch/arm/dts/dra7-mmc-iodelay.dtsi| 2 +- arch/arm

[PATCH 06/17] arm: dts: omap3x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/omap-gpmc-smsc9221.dtsi | 1 + arch/arm/dts/omap3-beagle-xm-ab.dts | 7 ++- arch/arm/dts/omap3-beagle-xm.dts | 7 ++- arch/arm/dts/omap3-beagle.dts| 7

[PATCH 04/17] arm: dts: dm8x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/da850-evm.dts | 7 ++- arch/arm/dts/da850-lcdk.dts | 3 +-- arch/arm/dts/da850-lego-ev3.dts | 6 +- arch/arm/dts/da850.dtsi | 6 +- arch/arm/dts/dm8168-evm.dts | 6 +- arch/arm/dts/dm816x-clocks.dtsi | 6

[PATCH 03/17] arm: dts: am57x: Update devicetree header comments to sync with v6.3-rc6

2023-04-11 Thread Andrew Davis
Signed-off-by: Andrew Davis --- arch/arm/dts/am571x-idk.dts| 7 ++- arch/arm/dts/am5729-beagleboneai.dts | 1 + arch/arm/dts/am572x-idk-common.dtsi| 2 +- arch/arm/dts/am572x-idk.dts| 7 ++- arch/arm/dts/am574x-idk.dts| 2

Re: [PATCH 0/8] Add ESM support for J721E and J7200

2023-04-11 Thread Andrew Davis
/k3-j7200-r5-common-proc-board-u-boot.dtsi I know Praneeth and Andrew have already commented internally, I just wanted to summarize publicly Thank you for sending this out! Unfortunately some of these dt node updates where never sent to the kernel. We'll need to get these merged over there

[PATCH v4 12/12] arm: mach-k3: Remove empty sys_proto.h include

2023-04-06 Thread Andrew Davis
This header file is now empty, remove it. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/am642_init.c | 2 -- arch/arm/mach-k3/am654_init.c | 1 - arch/arm/mach-k3/common.c | 1 - arch/arm/mach-k3/include/mach

[PATCH v4 11/12] arm: mach-k3: Move J721s2 SPL init functions to mach-k3

2023-04-06 Thread Andrew Davis
This matches AM64 and J721e and removes the need to forward declare k3_spl_init(), k3_mem_init(), and check_rom_loaded_sysfw() in sys_proto.h. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/include/mach/sys_proto.h | 3 -- arch/arm/mach-k3/j721s2_init.c

[PATCH v4 01/12] arm: mach-k3: Move MSMC fixup to SoC level

2023-04-06 Thread Andrew Davis
is no longer board level. Enable OF_SYSTEM_SETUP in the configurations that use this to keep functionality the same. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/common.c | 16 arch/arm/mach-k3/include/mach/sys_proto.h | 1

[PATCH v4 07/12] arm: mach-k3: Move sysfw-loader.h out of mach includes

2023-04-06 Thread Andrew Davis
This header is only used locally by K3 init files, no need to have it up with the global mach includes. Move into local includes. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/am625_init.c | 2 +- arch/arm/mach-k3/am62a7_init.c

[PATCH v4 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-04-06 Thread Andrew Davis
These probably should be in some system wide header given their use. Until then move them out of K3 sys_proto.h so we can finish cleaning that header out. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/include/mach/sys_proto.h | 4 drivers/ram/k3-am654

[PATCH v4 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-06 Thread Andrew Davis
This matches how it was done for pre-K3 TI platforms and it allows us to move the forward declaration out of sys_proto.h. It also removes the need for K3_BOARD_DETECT as one is free to simply override the weak function in their board files as needed. Signed-off-by: Andrew Davis Reviewed-by

[PATCH v4 09/12] arm: mach-k3: Remove unused fdt_disable_node()

2023-04-06 Thread Andrew Davis
This function is not used currently; remove it. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/common.c | 19 --- arch/arm/mach-k3/include/mach/sys_proto.h | 1 - 2 files changed, 20 deletions(-) diff --git a/arch/arm/mach-k3

[PATCH v4 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-06 Thread Andrew Davis
and later use. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 20 -- arch/arm/mach-k3/common.h | 3 --- arch/arm/mach-k3/include/mach/hardware.h | 25 +++ arch/arm/mach-k3/include/mach/sys_proto.h | 3 --- 4 files

[PATCH v4 06/12] arm: mach-k3: Make release_resources_for_core_shutdown() common

2023-04-06 Thread Andrew Davis
This function is the same for each device when it needs to shutdown the R5 core. Move this to the common section and move the remaining device specific ID list to the device hardware include. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/am642_init.c

[PATCH v4 03/12] soc: soc_ti_k3: Use hardware.h to remove definition duplication

2023-04-06 Thread Andrew Davis
The K3 JTAG and SoC ID information is already stored in the K3 arch hardware file, include that and use its definitions here. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- drivers/soc/Kconfig | 2 +- drivers/soc/soc_ti_k3.c | 30 +- 2 files

[PATCH v4 04/12] configs: j721x_evm: Remove unneeded check for SYS_K3_SPL_ATF

2023-04-06 Thread Andrew Davis
The TARGET_x_R5_EVM check is already enough to limit these defines to only the correct builds. Remove the extra outer check. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- board/ti/j721e/j721e.env | 2 -- board/ti/j721s2/j721s2.env | 2 -- 2 files changed, 4 deletions

[PATCH v4 05/12] configs: j721s2_evm.h: Remove refrences to J7200 EVM

2023-04-06 Thread Andrew Davis
The J7200 EVM will not include this file, this J7200 checks look to be a copy/paste errora from j721e_evm.h, which J7200 *can* include. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- include/configs/j721s2_evm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 00/12] Remove K3 misc sys_proto.h header

2023-04-06 Thread Andrew Davis
Hello all, Some minor cleanups with end patch removing sys_proto.h. Why? Becouse I don't like headers of "miscellaneous". Thanks, Andrew Changes from v3: - [2/12] Fix copy/paste error (thanks Christian) - add more tags and rebase on latest Changes from v2: - Reworked patc

Re: [PATCH v3 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-06 Thread Andrew Davis
and add the rest of the SoC IDs for completeness and later use. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 20 -- arch/arm/mach-k3/common.h | 3 --- arch/arm/mach-k3/include/mach/hardware.h | 25 +++ arch/arm

[PATCH v3 12/12] arm: mach-k3: Remove empty sys_proto.h include

2023-04-06 Thread Andrew Davis
This header file is now empty, remove it. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 2 -- arch/arm/mach-k3/am654_init.c | 1 - arch/arm/mach-k3/common.c | 1 - arch/arm/mach-k3/include/mach/sys_proto.h | 10 -- arch/arm

[PATCH v3 11/12] arm: mach-k3: Move J721s2 SPL init functions to mach-k3

2023-04-06 Thread Andrew Davis
This matches AM64 and J721e and removes the need to forward declare k3_spl_init(), k3_mem_init(), and check_rom_loaded_sysfw() in sys_proto.h. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/include/mach/sys_proto.h | 3 -- arch/arm/mach-k3/j721s2_init.c

[PATCH v3 09/12] arm: mach-k3: Remove unused fdt_disable_node()

2023-04-06 Thread Andrew Davis
This function is not used currently; remove it. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/common.c | 19 --- arch/arm/mach-k3/include/mach/sys_proto.h | 1 - 2 files changed, 20 deletions(-) diff --git a/arch/arm/mach-k3

[PATCH v3 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-06 Thread Andrew Davis
This matches how it was done for pre-K3 TI platforms and it allows us to move the forward declaration out of sys_proto.h. It also removes the need for K3_BOARD_DETECT as one is free to simply override the weak function in their board files as needed. Signed-off-by: Andrew Davis --- arch/arm

[PATCH v3 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-04-06 Thread Andrew Davis
These probably should be in some system wide header given their use. Until then move them out of K3 sys_proto.h so we can finish cleaning that header out. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/include/mach/sys_proto.h | 4 drivers/ram/k3-am654

[PATCH v3 07/12] arm: mach-k3: Move sysfw-loader.h out of mach includes

2023-04-06 Thread Andrew Davis
This header is only used locally by K3 init files, no need to have it up with the global mach includes. Move into local includes. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/am625_init.c | 2 +- arch/arm/mach-k3/am62a7_init.c

[PATCH v3 06/12] arm: mach-k3: Make release_resources_for_core_shutdown() common

2023-04-06 Thread Andrew Davis
This function is the same for each device when it needs to shutdown the R5 core. Move this to the common section and move the remaining device specific ID list to the device hardware include. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/am642_init.c

[PATCH v3 05/12] configs: j721s2_evm.h: Remove refrences to J7200 EVM

2023-04-06 Thread Andrew Davis
The J7200 EVM will not include this file, this J7200 checks look to be a copy/paste errora from j721e_evm.h, which J7200 *can* include. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- include/configs/j721s2_evm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 04/12] configs: j721x_evm: Remove unneeded check for SYS_K3_SPL_ATF

2023-04-06 Thread Andrew Davis
The TARGET_x_R5_EVM check is already enough to limit these defines to only the correct builds. Remove the extra outer check. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- board/ti/j721e/j721e.env | 2 -- board/ti/j721s2/j721s2.env | 2 -- 2 files changed, 4 deletions

[PATCH v3 03/12] soc: soc_ti_k3: Use hardware.h to remove definition duplication

2023-04-06 Thread Andrew Davis
The K3 JTAG and SoC ID information is already stored in the K3 arch hardware file, include that and use its definitions here. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- drivers/soc/Kconfig | 2 +- drivers/soc/soc_ti_k3.c | 30 +- 2 files

[PATCH v3 01/12] arm: mach-k3: Move MSMC fixup to SoC level

2023-04-06 Thread Andrew Davis
is no longer board level. Enable OF_SYSTEM_SETUP in the configurations that use this to keep functionality the same. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/common.c | 16 arch/arm/mach-k3/include/mach/sys_proto.h | 1

[PATCH v3 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-06 Thread Andrew Davis
and later use. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 20 -- arch/arm/mach-k3/common.h | 3 --- arch/arm/mach-k3/include/mach/hardware.h | 25 +++ arch/arm/mach-k3/include/mach/sys_proto.h | 3 --- 4 files

[PATCH v3 00/12] Remove K3 misc sys_proto.h header

2023-04-06 Thread Andrew Davis
Hello all, Some minor cleanups with end patch removing sys_proto.h. Why? Becouse I don't like headers of "miscellaneous". Thanks, Andrew Changes from v2: - Reworked patch [2/12] to use static and turned it into common macro - Removed "EEPROM" from comment as boar

Re: [PATCH v2 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-04-06 Thread Andrew Davis
ns in their own mach-x/ dirs' miscellaneous header file. Collecting all the declarations into one header is a different problem for a different series, this series just moves them out of mach-k3/ for now. Andrew Do not take this a strong no as I am only doing some drive-by comments. With

Re: [PATCH v2 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-05 Thread Andrew Davis
needed. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig | 5 - arch/arm/mach-k3/am642_init.c | 4 ++-- arch/arm/mach-k3/am654_init.c | 4 ++-- arch/arm/mach-k3/common.c | 10 ++ arch/arm/mach-k3/common.h

[PATCH v2 11/12] arm: mach-k3: Move J721s2 SPL init functions to mach-k3

2023-04-05 Thread Andrew Davis
This matches AM64 and J721e and removes the need to forward declare k3_spl_init(), k3_mem_init(), and check_rom_loaded_sysfw() in sys_proto.h. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/include/mach/sys_proto.h | 3 -- arch/arm/mach-k3/j721s2_init.c| 64

[PATCH v2 12/12] arm: mach-k3: Remove empty sys_proto.h include

2023-04-05 Thread Andrew Davis
This header file is now empty, remove it. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 2 -- arch/arm/mach-k3/am654_init.c | 1 - arch/arm/mach-k3/common.c | 1 - arch/arm/mach-k3/include/mach/sys_proto.h | 10 -- arch/arm

[PATCH v2 06/12] arm: mach-k3: Make release_resources_for_core_shutdown() common

2023-04-05 Thread Andrew Davis
This function is the same for each device when it needs to shutdown the R5 core. Move this to the common section and move the remaining device specific ID list to the device hardware include. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 51

[PATCH v2 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-05 Thread Andrew Davis
This matches how it was done for pre-K3 TI platforms and it allows us to move the forward declaration out of sys_proto.h. It also removes the need for K3_BOARD_DETECT as one is free to simply override the weak function in their board files as needed. Signed-off-by: Andrew Davis --- arch/arm

[PATCH v2 10/12] arm: mach-k3: Move sdelay() and wait_on_value() declaration

2023-04-05 Thread Andrew Davis
These probably should be in some system wide header given their use. Until then move them out of K3 sys_proto.h so we can finish cleaning that header out. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/include/mach/sys_proto.h | 4 drivers/ram/k3-am654-ddrss.c | 4 2

[PATCH v2 09/12] arm: mach-k3: Remove unused fdt_disable_node()

2023-04-05 Thread Andrew Davis
This function is not used currently; remove it. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c | 19 --- arch/arm/mach-k3/include/mach/sys_proto.h | 1 - 2 files changed, 20 deletions(-) diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3

[PATCH v2 04/12] configs: j721x_evm: Remove unneeded check for SYS_K3_SPL_ATF

2023-04-05 Thread Andrew Davis
The TARGET_x_R5_EVM check is already enough to limit these defines to only the correct builds. Remove the extra outer check. Signed-off-by: Andrew Davis --- board/ti/j721e/j721e.env | 2 -- board/ti/j721s2/j721s2.env | 2 -- 2 files changed, 4 deletions(-) diff --git a/board/ti/j721e

[PATCH v2 03/12] soc: soc_ti_k3: Use hardware.h to remove definition duplication

2023-04-05 Thread Andrew Davis
The K3 JTAG and SoC ID information is already stored in the K3 arch hardware file, include that and use its definitions here. Signed-off-by: Andrew Davis --- drivers/soc/Kconfig | 2 +- drivers/soc/soc_ti_k3.c | 30 +- 2 files changed, 10 insertions(+), 22

[PATCH v2 02/12] arm: mach-k3: Move J721e SoC detection out of common section

2023-04-05 Thread Andrew Davis
This belongs in the J721e specific file as it is the only place this is used. Any board level users should use the SOC driver. While here, move the J721e and J7200 SoC IDs out of sys_proto.h and into hardware.h. Add the rest of the SoC IDs for completeness and later use. Signed-off-by: Andrew

[PATCH v2 05/12] configs: j721s2_evm.h: Remove refrences to J7200 EVM

2023-04-05 Thread Andrew Davis
The J7200 EVM will not include this file, this J7200 checks look to be a copy/paste errora from j721e_evm.h, which J7200 *can* include. Signed-off-by: Andrew Davis --- include/configs/j721s2_evm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/j721s2_evm.h b

[PATCH v2 00/12] Remove K3 misc sys_proto.h header

2023-04-05 Thread Andrew Davis
Hello all, Some minor cleanups with end patch removing sys_proto.h. Why? Becouse I don't like headers of "miscellaneous". Thanks, Andrew Changes from v1: - Added reviewed by tag - Rebased on latest Andrew Davis (12): arm: mach-k3: Move MSMC fixup to SoC level arm: mach-k3:

[PATCH v2 07/12] arm: mach-k3: Move sysfw-loader.h out of mach includes

2023-04-05 Thread Andrew Davis
This header is only used locally by K3 init files, no need to have it up with the global mach includes. Move into local includes. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am625_init.c | 2 +- arch/arm/mach-k3/am62a7_init.c | 2 +- arch/arm/mach

[PATCH v2 01/12] arm: mach-k3: Move MSMC fixup to SoC level

2023-04-05 Thread Andrew Davis
is no longer board level. Enable OF_SYSTEM_SETUP in the configurations that use this to keep functionality the same. Signed-off-by: Andrew Davis Reviewed-by: Christian Gmeiner --- arch/arm/mach-k3/common.c | 16 arch/arm/mach-k3/include/mach/sys_proto.h | 1

Re: [PATCH 08/12] arm: mach-k3: Add weak do_board_detect() to common file

2023-04-05 Thread Andrew Davis
On 4/2/23 5:44 AM, Christian Gmeiner wrote: Hi Andrew Am Do., 30. März 2023 um 22:30 Uhr schrieb Andrew Davis : This matches how it was done for pre-K3 TI platforms and it allows us to move the forward declaration out of sys_proto.h. It also removes the need to check for TI_I2C_BOARD_DETECT

Re: [PATCH v2 00/18] Migration to using binman to generate

2023-04-04 Thread Andrew Davis
rm support strategy. Thank you! For the whole series, Acked-by: Andrew Davis [0] https://lists.denx.de/pipermail/u-boot/2023-April/514400.html

[PATCH] binman: Use unsigned long over typedef ulong

2023-04-04 Thread Andrew Davis
d for typedef'ing it in some of the tests, so also remove those. Signed-off-by: Andrew Davis --- include/binman_sym.h| 8 tools/binman/test/blob_syms.c | 2 -- tools/binman/test/u_boot_binman_syms.c | 2 -- tools/binman/test/u_boot_binman_s

Re: [PATCH v2 05/18] j721e: dts: binman: Package tiboot3.bin, sysfw.itb, tispl.bin, u-boot.img

2023-04-04 Thread Andrew Davis
or all the DM/SYSFW files for all the platforms in this series. Thanks, Andrew

Re: [PATCH v2 02/18] binman: ti-secure: Add support for TI signing

2023-04-04 Thread Andrew Davis
necessary for booting of K3 devices. Signed-off-by: Neha Malcom Francis --- [...] +++ b/tools/binman/etype/ti_secure.py @@ -0,0 +1,83 @@ +# SPDX-License-Identifier: GPL-2.0+ +# Copyright 20 Looks like this Copyright string got broken, I see this in a couple spots. Andrew

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Andrew Davis
On 3/31/23 1:36 PM, Tom Rini wrote: On Fri, Mar 31, 2023 at 01:23:23PM -0500, Andrew Davis wrote: On 3/31/23 1:11 PM, Tom Rini wrote: On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote: On 3/31/23 12:04 PM, Nishanth Menon wrote: On 16:06-20230330, Ryan Eatmon wrote: The oe-core

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Andrew Davis
On 3/31/23 1:11 PM, Tom Rini wrote: On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote: On 3/31/23 12:04 PM, Nishanth Menon wrote: On 16:06-20230330, Ryan Eatmon wrote: The oe-core class for assembling the fitImage includes the vendor sub-directory (with the / changed to _) in the

Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core

2023-03-31 Thread Andrew Davis
to go and fix it with non-standard? The dtbs need to have their dir prefixed or there could be collisions Andrew "if test $fdtfile = undefined; then " \ "echo WARNING: Could not determine device tree to use; fi; \0" \ &q

[PATCH 06/12] arm: mach-k3: Make release_resources_for_core_shutdown() common

2023-03-30 Thread Andrew Davis
This function is the same for each device when it needs to shutdown the R5 core. Move this to the common section and move the remaining device specific ID list to the device hardware include. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 51

[PATCH 12/12] arm: mach-k3: Remove empty sys_proto.h include

2023-03-30 Thread Andrew Davis
This header file is now empty, remove it. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 2 -- arch/arm/mach-k3/am654_init.c | 1 - arch/arm/mach-k3/common.c | 1 - arch/arm/mach-k3/include/mach/sys_proto.h | 10 -- arch/arm

<    1   2   3   4   5   6   7   8   9   10   >