On 3/31/23 1:11 PM, Tom Rini wrote:
On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote:
On 3/31/23 12:04 PM, Nishanth Menon wrote:
On 16:06-20230330, Ryan Eatmon wrote:
The oe-core class for assembling the fitImage includes the vendor
sub-directory (with the / changed to _) in the
to go and fix it with non-standard?
The dtbs need to have their dir prefixed or there could be collisions
Andrew
"if test $fdtfile = undefined; then " \
"echo WARNING: Could not determine device tree to use; fi;
\0" \
&q
This function is the same for each device when it needs to shutdown
the R5 core. Move this to the common section and move the remaining
device specific ID list to the device hardware include.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/am642_init.c | 51
This header file is now empty, remove it.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/am642_init.c | 2 --
arch/arm/mach-k3/am654_init.c | 1 -
arch/arm/mach-k3/common.c | 1 -
arch/arm/mach-k3/include/mach/sys_proto.h | 10 --
arch/arm
This matches AM64 and J721e and removes the need to forward
declare k3_spl_init(), k3_mem_init(), and check_rom_loaded_sysfw()
in sys_proto.h.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/include/mach/sys_proto.h | 3 --
arch/arm/mach-k3/j721s2_init.c| 64
is no
longer board level. Enable OF_SYSTEM_SETUP in the configurations that use
this to keep functionality the same.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/common.c | 16
arch/arm/mach-k3/include/mach/sys_proto.h | 1 -
board/siemens/iot2050/board.c
These probably should be in some system wide header given their use.
Until then move them out of K3 sys_proto.h so we can finish cleaning
that header out.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/include/mach/sys_proto.h | 4
drivers/ram/k3-am654-ddrss.c | 4
2
The K3 JTAG and SoC ID information is already stored in the K3 arch
hardware file, include that and use its definitions here.
Signed-off-by: Andrew Davis
---
drivers/soc/Kconfig | 2 +-
drivers/soc/soc_ti_k3.c | 30 +-
2 files changed, 10 insertions(+), 22
board detection.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/am642_init.c | 3 +--
arch/arm/mach-k3/am654_init.c | 3 +--
arch/arm/mach-k3/common.c | 10 ++
arch/arm/mach-k3/common.h | 2 ++
arch/arm/mach-k3/include/mach
The TARGET_x_R5_EVM check is already enough to limit these defines to
only the correct builds. Remove the extra outer check.
Signed-off-by: Andrew Davis
---
include/configs/j721e_evm.h | 4 +---
include/configs/j721s2_evm.h | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git
This function is not used currently; remove it.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/common.c | 19 ---
arch/arm/mach-k3/include/mach/sys_proto.h | 1 -
2 files changed, 20 deletions(-)
diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3
This header is only used locally by K3 init files, no need to have it
up with the global mach includes. Move into local includes.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/am625_init.c | 2 +-
arch/arm/mach-k3/am62a7_init.c | 2 +-
arch/arm/mach
This belongs in the J721e specific file as it is the only place
this is used. Any board level users should use the SOC driver.
While here, move the J721e and J7200 SoC IDs out of sys_proto.h
and into hardware.h. Add the rest of the SoC IDs for completeness
and later use.
Signed-off-by: Andrew
The J7200 EVM will not include this file, all these J7200 checks look
to be copy/paste errors from j721e_evm.h, which J7200 *can* include.
Signed-off-by: Andrew Davis
---
include/configs/j721s2_evm.h | 23 ++-
1 file changed, 2 insertions(+), 21 deletions(-)
diff --git a
On Tue, Mar 28, 2023 at 11:54 AM Tom Rini wrote:
>
> Per the GCC bug listed below, the way we do linker lists is relying on
> undefined behavior that seems to work in gcc, but doesn't always work in
> clang. Andrew suggests rewriting our start/end macros in a different way
>
: Jayesh Choudhary
---
Matches what we do in j721e_init.c, LGTM,
Reviewed-by: Andrew Davis
arch/arm/mach-k3/j721s2_init.c | 53 ++
1 file changed, 53 insertions(+)
diff --git a/arch/arm/mach-k3/j721s2_init.c b/arch/arm/mach-k3/j721s2_init.c
index 09e55ed456
9c45d
--- /dev/null
+++ b/arch/arm/mach-k3/include/mach/j784s4_hardware.h
@@ -0,0 +1,41 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * K3: J784S4 SoC definitions, structures etc.
+ *
+ * (C) Copyright (C) 2022 Texas Instruments Incorporated - http://www.ti.com/
Why two (C)? And the address should have https not http. Fix this everywhere in
this series.
Andrew
On 3/1/23 1:21 PM, Jan Kiszka wrote:
On 01.03.23 19:34, Andrew Davis wrote:
On 3/1/23 12:29 PM, Jan Kiszka wrote:
On 01.03.23 18:26, Andrew Davis wrote:
On 2/28/23 12:19 PM, Jan Kiszka wrote:
From: Su Baocheng
Due to different signature keys, the PG1 and the PG2 boards can no
longer use
On 3/1/23 12:29 PM, Jan Kiszka wrote:
On 01.03.23 18:26, Andrew Davis wrote:
On 2/28/23 12:19 PM, Jan Kiszka wrote:
From: Su Baocheng
Due to different signature keys, the PG1 and the PG2 boards can no
longer use the same FSBL (tiboot3). This makes it impossible anyway to
maintaine a single
On 2/28/23 12:19 PM, Jan Kiszka wrote:
From: Jan Kiszka
This feature is desired on the platform.
As you can see here your split defconfigs are already out of sync
and need special maintenance :)
Andrew
Signed-off-by: Jan Kiszka
---
configs/iot2050_pg1_defconfig | 1 +
configs
check changing the output name).
Andrew
A new target is added to indicates the build is for PG1 vs. PG2 boards.
Hence now the variants have separated defconfig files.
The runtime board_is_sr1() check does make no sense anymore, so remove
it and replace with build time check.
Documentation is
nd I think we are already
trying to do too much all at once as is. Perhaps we could take
this current solution posted here with the intent to remove it in
the near future. Thoughts?
Andrew
[0]
https://git.ti.com/cgit/security-development-tools/core-secdev-k3/tree/scripts/fit-image-secure.sh
[1]
the build will emit warnings, for non-HS
devices these can be ignored.
Signed-off-by: Manorit Chawdhry
---
This will help with keeping the HS and non-HS configs in sync :)
Acked-by: Andrew Davis
configs/j7200_evm_a72_defconfig| 3 +-
configs/j7200_evm_r5_defconfig | 1
On Sun, Jan 8, 2023, at 08:57, Simon Glass wrote:
> This board is useful for benchmarking overall U-Boot performance. Enable
> the bootstage feature so we get a report.
>
> Since this returns to the boot rom before finishing executing
> board_init_r() in SPL, add a few bootstage calls so that we c
should not be an issue for any K3
device, so make it default for all.
Signed-off-by: Neha Malcom Francis
---
Acked-by: Andrew Davis
Changes since v1:
- added ARM64 to conditions to default to 0x40
common/spl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/spl
On 1/10/23 3:25 PM, Judith Mendez wrote:
List some common boot modes and their corresponding switch
settings for AM62 SK.
Signed-off-by: Judith Mendez
---
Acked-by: Andrew Davis
doc/board/ti/am62x_sk.rst | 29 +
1 file changed, 29 insertions(+)
diff --git a
ed-by: Andrew Davis
[0]
https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/tree/plat/ti/k3/common/drivers/ti_sci/ti_sci_protocol.h#n50
drivers/firmware/ti_sci.c | 2 +-
drivers/firmware/ti_sci.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/fir
Before this was named just evm, which doesn't match the naming
of the other TI board file directory and makes it look like a
common directory for evms. Name this omap3evm.
Signed-off-by: Andrew Davis
---
Changes from v1:
- Call dir omap3evm instead of omap3
arch/arm/mach-omap2/omap3/Kc
On 10/7/22 10:21 PM, Derald Woods wrote:
On Fri, Oct 07, 2022 at 12:33:14PM -0500, Andrew Davis wrote:
Before this was named just evm, which doesn't match the naming
of the other TI board file directory and makes it look like a
common directory for evms. Name this omap3.
Signed-off-by: A
This matches how this would be done in Linux and these functions
do the alignment for us which makes the code look cleaner.
Signed-off-by: Andrew Davis
---
common/bouncebuf.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/common/bouncebuf.c b/common
evice uses the split binary
+ flow)
+
+.. code-block:: bash
+
+ # inside k3-image-gen source
+ make CROSS_COMPILE=$CC32 SOC={SOC} SOC_TYPE={hs,gp} \
+TI_SECURE_DEV_PKG= \
s/securit/security
Andrew
+SYSFW_PATH= \
+
SYSFW_HS_INNER_CERT_PATH=
+
+At this point you should have a
* BASH code should be labeled as such.
* Code blocks should be indented by 4 spaces.
Fix these here.
Suggested-by: Heinrich Schuchardt
Signed-off-by: Andrew Davis
---
Changes from v2:
- None
Changes from v1:
- New patch with fixes suggested by Heinrich
doc/board/ti/j721e_evm.rst | 24
J721e needs DM firmware when using updated SYSFW. Add steps to fetch,
build, and deploy the same.
Signed-off-by: Andrew Davis
---
Changes from v2:
- s/DM/DM Firmware
Changes from v1:
- None
doc/board/ti/j721e_evm.rst | 16 ++--
1 file changed, 10 insertions(+), 6 deletions
On 11/6/22 2:49 AM, Heinrich Schuchardt wrote:
On 11/1/22 15:06, Andrew Davis wrote:
On 10/7/22 6:47 PM, Heinrich Schuchardt wrote:
On 10/7/22 22:37, Andrew Davis wrote:
J721e needs DM firmware when using updated SYSFW. Add steps to fetch,
build, and deploy the same.
Signed-off-by: Andrew
er doc/board/ti/ is needed as well for the series,
thanks!
I see we do have some files at board/ti/{j721e,j721s2}/README with some
good info on all this firmware source/building. Much of that info is
common and could be factored out into a "generic TI 64 bit build doc".
Andrew
* BASH code should be labeled as such.
* Code blocks should be indented by 4 spaces.
Fix these here.
Suggested-by: Heinrich Schuchardt
Signed-off-by: Andrew Davis
---
Changes from v1:
- New patch with fixes suggested by Heinrich
doc/board/ti/j721e_evm.rst | 24
1
J721e needs DM firmware when using updated SYSFW. Add steps to fetch,
build, and deploy the same.
Signed-off-by: Andrew Davis
---
Changes from v1:
- None
doc/board/ti/j721e_evm.rst | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/doc/board/ti
On 10/7/22 6:47 PM, Heinrich Schuchardt wrote:
On 10/7/22 22:37, Andrew Davis wrote:
J721e needs DM firmware when using updated SYSFW. Add steps to fetch,
build, and deploy the same.
Signed-off-by: Andrew Davis
---
doc/board/ti/j721e_evm.rst | 16 ++--
1 file changed, 10
The functions board_fit_image_post_process() and board_tee_image_process()
are not actually board specific (despite their names). Any board using the
OMAP2 family can use these functions. Move them to boot-common.c.
Signed-off-by: Andrew Davis
---
arch/arm/mach-omap2/boot-common.c | 16
J721e needs DM firmware when using updated SYSFW. Add steps to fetch,
build, and deploy the same.
Signed-off-by: Andrew Davis
---
doc/board/ti/j721e_evm.rst | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/doc/board/ti/j721e_evm.rst b/doc/board/ti
This matches the others here.
Signed-off-by: Andrew Davis
---
tools/k3_gen_x509_cert.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/k3_gen_x509_cert.sh b/tools/k3_gen_x509_cert.sh
index 029247c105..d9cde07417 100755
--- a/tools/k3_gen_x509_cert.sh
+++ b/tools
These hardware register definitions are common for all K3, remove
duplicate data them by moving them to hardware.h.
While here do some minor whitespace cleanup + grouping.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/am642_init.c | 1 -
arch/arm/mach-k3/include/mach
Before this was named just evm, which doesn't match the naming
of the other TI board file directory and makes it look like a
common directory for evms. Name this omap3.
Signed-off-by: Andrew Davis
---
arch/arm/mach-omap2/omap3/Kconfig | 2 +-
board/ti/{evm => omap3}/Kconfig | 2 +
This matches how this would be done in Linux and these functions
do the alignment for us which makes the code look cleaner.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/security.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/arch/arm/mach-k3/security.c
DMA operations should function on DMA addresses, not virtual addresses.
Although these are usually the same in U-Boot, it is more correct
to be explicit with our types here.
Signed-off-by: Andrew Davis
---
drivers/dma/dma-uclass.c | 2 +-
drivers/dma/sandbox-dma-test.c | 4 ++--
drivers
We should clean the caches before any DMA operation and clean+invalidate
after. This matches what the DMA framework does for us already but adds
it to the two functions here in this driver that don't yet go through the
new DMA framework.
Signed-off-by: Andrew Davis
---
drivers/dma/ti-ed
The DMA'd memory area needs cleaned and invalidated after the DMA
write so that any stale cache lines do not mask new data.
Signed-off-by: Andrew Davis
---
drivers/dma/dma-uclass.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/dma-uclas
This matches what we did for pre-K3 devices. This allows us to build
boot commands that can check for our device type at runtime.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/common.c | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/mach-k3/common.c b/arch/arm/mach-k3
just a network interface name problem. Any device
with a number/letter in it is unstable. I2C bus devices: i2c0,
i2c1... SPI bus deviceS: spi0, spi1..., Block devices, sda, sdb, sdc,
TPM device, tpm0, tpm1. Nothing is stable in the kernel.
Andrew
on't see why this time
should be any different.
DSA is somewhat special because it is very old. It comes from before
the times of DT. Its DT binding was proposed relatively earl in DT
times, and would be rejected in modern days. But the rules of ABI mean
the label property will be valid forever. But i very much doubt it
will spread to interfaces in general.
Andrew
On 7/25/22 11:57 AM, Tom Rini wrote:
On Fri, Jul 15, 2022 at 11:34:32AM -0500, Andrew Davis wrote:
K3 SoCs are available in a number of device types such as
GP, HS-FS, EMU, etc. Like OMAP SoCs we can detect this at runtime
and should print this out as part of the SoC information line.
We add
We don't need to print the same message in every location, just
print it in the function that fails and remove all the extra
message printouts.
Signed-off-by: Andrew Davis
---
drivers/firmware/ti_sci.c | 40 ---
1 file changed, 4 insertions(+), 36 dele
We can check if the message was acknowledged in the common
ti_sci_do_xfer() which lets us remove it from after each call to this
function. This simplifies the code and reduces binary size.
Signed-off-by: Andrew Davis
---
drivers/firmware/ti_sci.c | 165 ++
1
This ti_sci_do_xfer() function already prints out the reason for the
failure, and the caller of each of these functions should also notify
the user of the failed task. Remove this extra level of error message.
Signed-off-by: Andrew Davis
---
drivers/firmware/ti_sci.c | 132
benefit to this due to the larger function size reducing
cache locality, but there is a huge size penalty. Remove inline keyword.
Signed-off-by: Andrew Davis
---
drivers/firmware/ti_sci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers
-16090.4
Andrew
Andrew Davis (4):
firmware: ti_sci: Reduce output on ti_sci_do_xfer error
firmware: ti_sci: Factor out message alloc failed message
firmware: ti_sci: Remove inline keyword from functions
firmware: ti_sci: Move ACK checking to ti_sci_do_xfer() function
drivers/firmware
On 7/16/22 7:00 AM, Simon Glass wrote:
Hi Andrew,
On Fri, 15 Jul 2022 at 09:35, Andrew Davis wrote:
From: "Andrew F. Davis"
Print statements in SPL depend on lib/common support, due to this many
such print statements are ifdef'd. Instead of checking at each call site
move t
The ISW_ENTRY_ADDR symbol was used for OMAP devices in place of
SPL_TEXT_BASE. Keystone2 HS devices were not using it right either.
Remove ISW_ENTRY_ADDR and use SPL_TEXT_BASE directly.
Signed-off-by: Andrew Davis
---
arch/arm/Kconfig | 15 ---
arch/arm/mach
Read the swrv.txt file from the TI Security Development Tools when
TI_SECURE_DEVICE is enabled. This allows us to set our software
revision in one place and have it used by all the tools that create
TI x509 boot certificates.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/config.mk | 8
From: Yogesh Siraswar
The x509 certificate SWRV is currently hard-coded to 0. This need to be
updated to 1 for j721e 1.1, j7200 and am64x. It is don't care for other
k3 devices.
Added new config K3_X509_SWRV to k3. Default is set to 1.
Signed-off-by: Yogesh Siraswar
Reviewed-by: Dave Gerlach
but if we run into a signed image we should at
least try to ignore the certificate and boot the image anyway. This could
help with users of GP devices who only have HS images available.
If this does happen, print a nice big warning.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/secur
device boot.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/common.c| 51 +++-
arch/arm/mach-k3/common.h| 10 +
arch/arm/mach-k3/include/mach/hardware.h | 10 +
3 files changed, 70 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach
We can skip the image authentication check at runtime if the device is GP.
This reduces the delta between GP and HS U-Boot builds. End goal is
to re-unify the two build types into one build that can run on all
device types.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/Makefile | 3
On HS-FS devices signing boot images is optional. To ease use
we check if we are HS-FS and if no certificate is attached
to the image we skip the authentication step with a warning
that this will fail when the device is set to security enforcing.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3
This isn't strictly needed as these firewalls should all be disabled on
GP, but it also doesn't hurt, so do this unconditionally to remove this
use of CONFIG_TI_SECURE_DEVICE.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/am6_init.c | 4
arch/arm/mach-k3/j721e_init.c | 4 ---
Sync new additions to non-HS defconfig with HS defconfig.
Signed-off-by: Andrew Davis
---
configs/am57xx_hs_evm_defconfig | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/configs/am57xx_hs_evm_defconfig b/configs/am57xx_hs_evm_defconfig
index aa0b466d95
Additions have been made to the non-HS defconfig without the same
being made to the HS defconfig, sync them.
Signed-off-by: Andrew Davis
---
configs/j721e_hs_evm_a72_defconfig | 42 ++
configs/j721e_hs_evm_r5_defconfig | 56 +-
2 files changed
Additions have been made to the non-HS defconfig without the same
being made to the HS defconfig, sync them.
Signed-off-by: Andrew Davis
---
configs/am65x_hs_evm_a53_defconfig | 23 ++-
configs/am65x_hs_evm_r5_defconfig | 8
2 files changed, 30 insertions(+), 1
On AM43xx HS devices, QSPI boot is XIP and we use a single stage
bootloader. Add a defconfig for this.
Signed-off-by: Andrew Davis
---
MAINTAINERS | 1 +
configs/am43xx_hs_evm_qspi_defconfig | 74
2 files changed, 75 insertions(+)
create
From: "Andrew F. Davis"
Print statements in SPL depend on lib/common support, due to this many
such print statements are ifdef'd. Instead of checking at each call site
move the check to the common.h header and remove these inline checks.
Signed-off-by: Andrew F. Davis
Reviewed-
clear and matches all the K3 devices added since.
Signed-off-by: Andrew Davis
---
arch/arm/dts/Makefile | 2 +-
arch/arm/mach-k3/Kconfig | 14 +++---
arch/arm/mach-k3/Makefile | 2 +-
arch/arm/mach-k3/{am6_init.c
The content of these files are only used in SPL builds. The contents are
already ifdef for the same, remove that and only include the whole file
in the build when building for SPL.
Signed-off-by: Andrew Davis
---
arch/arm/mach-k3/Makefile | 13 -
arch/arm/mach-k3/am625_init.c
This is no longer needed as the SA2UL can now be shared with Linux.
Leave the SA2UL DT node enabled.
Signed-off-by: Andrew Davis
---
board/ti/am65x/evm.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/board/ti/am65x/evm.c b/board/ti/am65x/evm.c
index 7182a8cad1..8a0a506a3e
this all has to change when you add HS.
Please start with that.
Andrew
Signed-off-by: Tarun Sahu
[n-fran...@ti.com: added tests for addition of etype]
Signed-off-by: Neha Malcom Francis
---
Makefile | 1 +
tools/binman/entries.rst | 11 +++
ned-off-by: Corentin LABBE
---
If no one was using this data I wonder if the compiler could have removed
it with LTO enabled.. Something to think on.
Acked-by: Andrew Davis
board/ti/am335x/board.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/ti/am335x/board
o we don't upstream their support).
am335x_hs_evm_defconfig - eMMC/SD
am335x_hs_evm_uart_defconfig - UART
So feel free to chop anything that is not related to these two
boot modes from the HS configs to keep the size down. Sometimes things
creep in over the releases and we run-out of spac
from ti.com
to see what it is doing. Any pointers on how to get it?
cheers,
-roger
Did you try to access using the browser using https link?
I am able to access the script by cloning
git://git.ti.com/security-development-tools/core-secdev-k3.git
Aha! sure I can access that.
But according t
#x27;d prefer
to know the file-format details (and maybe replicate them in binman) if
you could afford to publish them, though...
This is a question to Nishanth/Andrew.
What file format are we talking about here? If it is the signed format,
it's an attached x509 certificate, that is alrea
h clang's ASAN
instrumentation which tries to add redzones between the linker list
elements, causing expected accesses to fail. However, clang doesn't try
to add redzones to user sections, which are names with all alphanumeric
and underscore characters.
Signed-off-by: Andrew Scull
Revie
e sandbox EFI and getopt refactoring, they obstruct the series
- resolve a couple more ASAN errors
- fix LTO, xtensa and MIPS builds
- add ASAN build targets for CI
Andrew Scull (13):
serial: sandbox: Fix buffer underflow in puts
sandbox: Rename EFI runtime sections
sandbox: Rename getopt
On 5/25/22 3:30 AM, Roger Quadros wrote:
Hi Andrew,
On 25/05/2022 01:03, Andrew Davis wrote:
On 5/9/22 2:29 AM, Roger Quadros wrote:
Introduce k3-am642-evm-binman.dtsi to provide binman configuration.
R5 build is still not converted to use binman so restrict binman.dtsi
to A53 builds only
"arm-trusted-firmware";
+ load = ;
+ entry = ;
+ atf-bl31 {
+ filename = "bl31.bin"
On Thu May 19, 2022 at 9:37 PM AEST, Alper Nebi Yasak wrote:
> On 16/05/2022 14:07, Andrew Abbott wrote:
> > Binman is now being used to build the final flashable images for
> > Rockchip devices, thus enabling it for all Rockchip targets here. But
> > it is not yet being use
On Thu May 19, 2022 at 9:36 PM AEST, Alper Nebi Yasak wrote:
> > For RK3399 targets:
> >
> > - u-boot.rom
> > - SPI image specific to the bob Chromebook target (see
> > c4cea2bbf995764f325a907061c22ecd6768cf7b).
>
> I'm not sure we need anything special for the rk3399 chromebooks. I
> th
On Thu May 19, 2022 at 9:36 PM AEST, Alper Nebi Yasak wrote:
> Also see another attempt for this [1] and the comments to that for a
> more complete picture, though I'll try writing all the points here anyway.
>
> [1] binman: support mkimage separate files
> https://lore.kernel.org/u-boot/2022030419
On Thu May 19, 2022 at 9:35 PM AEST, Alper Nebi Yasak wrote:
> > - I noticed that ATF generation for ARM64 Rockchip is done via a Python
> > script
> > instead of binman. I don't currently know how to change that over to
> > binman,
> > but is that something worth pursuing as part of this?
>
OCKPi 4B defconfig and get a
u-boot-rockchip-spi.bin to be generated that would take your patch into
account as-is.
Thanks,
Andrew
On Tue, 17 May 2022 at 09:06, Heinrich Schuchardt wrote:
>
> On 4/14/22 15:59, Andrew Scull wrote:
> > Rename the sections used to implement linker lists so they begin with
> > '__u_boot_list' rather than '.u_boot_list'. The double underscore at the
>
Update the Rockchip documentation for image generation with binman,
including the new automatically-created SPI image.
Signed-off-by: Andrew Abbott
---
Changes in v2:
- Remove note from docs about different offsets in SPI flash for
different SoCs - this was a bad assumption on my part, it
Using the new SPI image generation, build an image for the Pine64
ROCKPro64 board.
Signed-off-by: Andrew Abbott
---
(no changes since v1)
arch/arm/mach-rockchip/rk3399/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-rockchip/rk3399/Kconfig
b/arch/arm/mach-rockchip
Binman is now being used to build the final flashable images for
Rockchip devices, thus enabling it for all Rockchip targets here. But
it is not yet being used to generate the FIT image (u-boot.itb),
thus we need to force it to be built.
Signed-off-by: Andrew Abbott
---
Question: Will this
_SYS_SPI_U_BOOT_OFFS', so this change should not functionally
change the offset for any of the affected boards.
Signed-off-by: Andrew Abbott
---
(no changes since v1)
arch/arm/dts/rk3368-lion-haikou-u-boot.dtsi | 1 -
arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 4
arch/arm/dts/rk339
These are obsoleted by a previous patch which added binman image
definitions for Rockchip SD/MMC and SPI images.
Signed-off-by: Andrew Abbott
---
(no changes since v1)
Makefile | 31 +++
1 file changed, 3 insertions(+), 28 deletions(-)
diff --git a/Makefile b
flash image, in
addition to the generic SD/MMC image.
Signed-off-by: Andrew Abbott
---
Question: Does this break/not play nicely with rockchip-optee
generation? It creates u-boot.itb for rk3288 targets. That would need to
run before what I've implemented here?
Changes in v2:
- Revert u-boot-roc
This pulls in binman definitions so images can be built for all
Rockchip platforms.
Signed-off-by: Andrew Abbott
---
(no changes since v1)
arch/arm/dts/rk3308-u-boot.dtsi | 2 ++
arch/arm/dts/rk3328-u-boot.dtsi | 2 ++
arch/arm/dts/rk3368-u-boot.dtsi | 1 +
arch/arm/dts/rk3568-u-boot.dtsi | 2
ned-off-by: Andrew Abbott
---
This is a bit of a messy implementation for now and would probably break
existing uses of mkimage that rely on the concatenation behaviour.
Questions:
- Should this be a separate entry type, or an option to the mkimage
entry type that enables this behaviour?
- What kind
part, it doesn't work
this way.
- Update name of SD/MMC image in the docs from u-boot-rockchip-sdmmc.bin
to u-boot-rockchip.bin.
Andrew Abbott (8):
binman: mkimage: Support ':'-separated inputs
rockchip: Add binman definitions for final images
soc: rockchip: Include com
The virtio-rng driver is extremely simple, making it suitable for
testing more of the virtio uclass logic. Have the sandbox driver bind
the virtio-rng driver rather than the virtio-blk driver so it can be
used in tests.
Signed-off-by: Andrew Scull
Reviewed-by: Simon Glass
---
drivers/virtio
Add a regression test for virtio-rng reading beyond the end of its
buffer if the virtio device provides an invalid length.
Signed-off-by: Andrew Scull
Reviewed-by: Simon Glass
---
test/dm/Makefile | 1 +
test/dm/virtio_rng.c | 52
2 files
Check the length of data written by the device is consistent with the
size of the buffers to avoid out-of-bounds memory accesses in case
values aren't consistent.
Signed-off-by: Andrew Scull
Cc: Sughosh Ganu
Reviewed-by: Simon Glass
---
drivers/virtio/virtio_rng.c | 3 +++
1 file chang
301 - 400 of 1033 matches
Mail list logo
