[PATCH v2 2/2] tools: k3_gen_x509_cert: Set default early HS JTAG access to disabled

2020-05-27 Thread Andrew F. Davis
security on HS, due to this change the default to disabled. This should only effect those working on early HS boot code, which is a limited crowd who will already know how to re-enable this access as needed. Signed-off-by: Andrew F. Davis --- Changes from v1: - Split into two patches as suggested by

[PATCH v2 1/2] tools: k3_gen_x509_cert: Allow selecting early JTAG debug value

2020-05-27 Thread Andrew F. Davis
behavior. Signed-off-by: Andrew F. Davis --- Changes from v1: - Split into two patches as suggested by Lokesh - Expanded explanation for default value change tools/k3_gen_x509_cert.sh | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/tools/k3_gen_x509_cert.sh

Re: [PATCH 4/4] kbuild: arm: Fix duplicate builds of dtbs

2020-05-18 Thread Andrew F. Davis
On 5/8/20 11:54 AM, Jan Kiszka wrote: > On 08.05.20 17:40, Andrew F. Davis wrote: >> On 5/4/20 8:38 AM, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> Build the secured board dtbs (.dtb_HS) as part of the regular dtb build >>> on CONFIG_TI_SECUR

Re: [PATCH 4/4] kbuild: arm: Fix duplicate builds of dtbs

2020-05-08 Thread Andrew F. Davis
In the same run, fix needless rebuilding of the secured spl dtb. > > Fixes: 508369672ca3 ("arm: mach-k3: Add secure device build support") > CC: Andrew F. Davis > Signed-off-by: Jan Kiszka > --- > arch/arm/dts/Makefile | 6 -- > arch/arm/mach-k3/

Re: am65x build issues

2020-04-30 Thread Andrew F. Davis
first round of parsing, due to the .dtb files not existing and no rules existing for them. The .dtb files are not being generated by a rule with their name so Make doesn't understand they will be generated later, because U-Boot uses scripting for dtbs and uses target "dtbs". So we are

[PATCH] arm: K3: Increase default SYSFW image size allocation

2020-04-30 Thread Andrew F. Davis
: Andrew F. Davis --- arch/arm/mach-k3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig index a13cbef9b5..c7d186149b 100644 --- a/arch/arm/mach-k3/Kconfig +++ b/arch/arm/mach-k3/Kconfig @@ -119,7 +119,7 @@ config

Re: [PATCH] tools: k3_gen_x509_cert: Allow selecting early JTAG debug value

2020-04-23 Thread Andrew F. Davis
On 4/23/20 2:38 AM, Lokesh Vutla wrote: > > > On 22/04/20 10:39 PM, Andrew F. Davis wrote: >> When authenticating the initial boot binary the ROM will check a debug >> type value in the certificate and based on that open JTAG access to that >> core. >> >> T

[PATCH] tools: k3_gen_x509_cert: Allow selecting early JTAG debug value

2020-04-22 Thread Andrew F. Davis
from unintentionally leaving this open. On non-HS devices JTAG is left open anyway so this does not change behavior on those devices. Change the default to off and allow it to be switched back on by command line flag if needed. Signed-off-by: Andrew F. Davis --- tools/k3_gen_x509_cert.sh | 14

Re: [U-Boot] [PATCH] defconfigs: am65x_hs_evm: Sync HS and non-HS defconfigs

2020-03-10 Thread Andrew F. Davis
On 3/10/20 4:15 AM, Lokesh Vutla wrote: > > > On 09/03/20 9:56 PM, Andrew F. Davis wrote: >> Additions have been made to the non-HS defconfig without the same >> being made to the HS defconfig, sync them. > > As I said earlier, It is not easy for everyone to enab

[U-Boot] [PATCH v2] defconfigs: am65x_hs_evm: Sync HS and non-HS defconfigs

2020-03-10 Thread Andrew F. Davis
Additions have been made to the non-HS defconfig without the same being made to the HS defconfig, sync them. Signed-off-by: Andrew F. Davis --- Changes from v1: - Rebased on u-boot-ti/next configs/am65x_hs_evm_a53_defconfig | 49 +++--- configs

[U-Boot] [PATCH] defconfigs: am65x_hs_evm: Sync HS and non-HS defconfigs

2020-03-09 Thread Andrew F. Davis
Additions have been made to the non-HS defconfig without the same being made to the HS defconfig, sync them. Signed-off-by: Andrew F. Davis --- configs/am65x_hs_evm_a53_defconfig | 50 +++--- configs/am65x_hs_evm_r5_defconfig | 7 + 2 files changed, 53 insertions

[U-Boot] [PATCH] board: ti: README: Update OP-TEE binary name

2020-03-05 Thread Andrew F. Davis
The OP-TEE binary to use is renamed to v2 as the v1 binary has been deprecated and is no longer built by default. Reported-by: Grygorii Strashko Signed-off-by: Andrew F. Davis --- board/ti/am65x/README | 2 +- board/ti/j721e/README | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH] tools: image-host.c: remove uboot_aes.h

2020-02-19 Thread Andrew F. Davis
+Praneeth On 2/18/20 11:23 AM, Philippe Reynes wrote: > The include uboot_aes.h is not usefull and > it breaks the compilation on android, so > we remove it. > > Signed-off-by: Philippe Reynes > --- > tools/image-host.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/image-host.c

[U-Boot] [PATCH] defconfig: k2x_hs: Remove DTB_RESELECT to fix DHCP issue

2020-02-14 Thread Andrew F. Davis
with the installation of the secure boot monitor. This patch also removes the above configs for the K2 GP devices, as they are not needed, and to keep the differences between the GP and HS defconfigs to a minimum. Signed-off-by: Madan Srinivas Signed-off-by: Andrew F. Davis --- configs

Re: [PATCH v3 02/10] arm: k3: Add support for loading non linux remote cores

2020-01-24 Thread Andrew F. Davis
On 1/24/20 3:42 AM, Tero Kristo wrote: > On 23/01/2020 19:19, Keerthy wrote: >> >> >> On 23/01/20 10:35 pm, Andrew F. Davis wrote: >>> On 1/23/20 11:44 AM, Keerthy wrote: >>>> >>>> >>>> On 23/01/20 6:54 pm, Andrew F. Davis wrote: &g

Re: [PATCH v3 02/10] arm: k3: Add support for loading non linux remote cores

2020-01-23 Thread Andrew F. Davis
On 1/23/20 11:44 AM, Keerthy wrote: > > > On 23/01/20 6:54 pm, Andrew F. Davis wrote: >> On 1/22/20 11:10 PM, Keerthy wrote: >>> >>> >>> On 22/01/20 9:55 pm, Andrew F. Davis wrote: >>>> On 1/21/20 8:10 PM, keerthy wrote: >>>>>

Re: [PATCH v3 02/10] arm: k3: Add support for loading non linux remote cores

2020-01-23 Thread Andrew F. Davis
On 1/22/20 11:10 PM, Keerthy wrote: > > > On 22/01/20 9:55 pm, Andrew F. Davis wrote: >> On 1/21/20 8:10 PM, keerthy wrote: >>> >>> >>> On 1/21/2020 6:26 PM, Andrew F. Davis wrote: >>>> On 1/21/20 6:07 AM, Keerthy wrote: >>>>

Re: [PATCH v3 02/10] arm: k3: Add support for loading non linux remote cores

2020-01-22 Thread Andrew F. Davis
On 1/21/20 8:10 PM, keerthy wrote: > > > On 1/21/2020 6:26 PM, Andrew F. Davis wrote: >> On 1/21/20 6:07 AM, Keerthy wrote: >>> Add MAIN domain R5FSS0 remoteproc support from spl. This enables >>> loading the elf firmware in SPL and starting the remotecore. &

Re: [PATCH v3 10/10] env: nowhere: set default enviroment

2020-01-21 Thread Andrew F. Davis
On 1/21/20 6:07 AM, Keerthy wrote: > set default enviroment so that set_env calls succeed > when ENV_IS_NOWHERE is alone set. > Capitalize first letter of a sentence. Also no need to line wrap at 50 chars.. For last line: "when only ENV_IS_NOWHERE is set." reads better. An

Re: [PATCH v3 08/10] configs: j721e_evm_r5: Enable R5F remoteproc support

2020-01-21 Thread Andrew F. Davis
_SPL_SEPARATE_BSS=y > CONFIG_SPL_EARLY_BSS=y > CONFIG_SPL_ENV_SUPPORT=y > +CONFIG_SPL_FS_EXT4=y ? Not in commit message. Andrew > CONFIG_SPL_I2C_SUPPORT=y > CONFIG_SPL_DM_MAILBOX=y > CONFIG_SPL_DM_RESET=y > @@ -92,6 +93,7 @@ CONFIG_SPL_DM_REGULATOR=y

Re: [PATCH v3 07/10] include: configs: j721e_evm: Add env variables for mcu_r5fss0_core0 & main_r5fss0_core0

2020-01-21 Thread Andrew F. Davis
;mainr5f0_0fwname=/lib/firmware/j7-main-r5f0_0-fw\0"\ > + "mcur5f0_0loadaddr=8900\0" \ > + "mcur5f0_0fwname=/lib/firmware/j7-mcu-r5f0_0-fw\0" \ New convention for env vars I'm pushing is: names start with "name_" and addresses s

Re: [PATCH v3 02/10] arm: k3: Add support for loading non linux remote cores

2020-01-21 Thread Andrew F. Davis
n_linux_remote_cores(void) > +{ > + int size = 0, ret; > + u32 loadaddr = 0; > + > + size = load_firmware("mainr5f0_0fwname", "mainr5f0_0loadaddr", > + &loadaddr); > + if (size <= 0) > + goto e

Re: [PATCH v3 01/10] lib: elf: Move the generic elf loading/validating functions to lib

2020-01-21 Thread Andrew F. Davis
t; diff --git a/lib/Kconfig b/lib/Kconfig > index d040a87d26..b155ced4b2 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -601,4 +601,7 @@ config TEST_FDTDEC > config LIB_DATE > bool > > +config ELF LIB_ELF? Andrew

[U-Boot] [PATCH v2 6/6] configs: Add configs for J721e High Security EVM

2020-01-10 Thread Andrew F. Davis
ESS option set to 'y' CONFIG_BOOTCOMMAND uses FIT images for booting Signed-off-by: Andrew F. Davis Reviewed-by: Lokesh Vutla --- configs/j721e_hs_evm_a72_defconfig | 116 + configs/j721e_hs_evm_r5_defconfig | 105 ++ 2 files changed, 221 ins

[U-Boot] [PATCH v2 5/6] arm: K3: Increase default SYSFW image size allocation

2020-01-10 Thread Andrew F. Davis
-by: Andrew F. Davis Reviewed-by: Lokesh Vutla --- arch/arm/mach-k3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig index 5583241943..2e111bbf27 100644 --- a/arch/arm/mach-k3/Kconfig +++ b/arch/arm/mach-k3/Kconfig

[U-Boot] [PATCH v2 4/6] arm: K3: Disable ROM configured firewalls

2020-01-10 Thread Andrew F. Davis
in re configuring the firewalls, it is concluded to clean this up in bootloaders. So disable all the firewalls that ROM doesn't open up the full address space. Signed-off-by: Andrew F. Davis Signed-off-by: Venkateswara Rao Mandela Signed-off-by: Lokesh Vutla --- arch/arm/mach-k3/am6_i

[U-Boot] [PATCH v2 3/6] arm: K3: Fix header comment match AM6 specific file function

2020-01-10 Thread Andrew F. Davis
This file used to be the common location for K3 init when AM6 was the only device, but common code was moved to common.c and this file became AM6 specific, correct this header text. Signed-off-by: Andrew F. Davis Reviewed-by: Lokesh Vutla --- arch/arm/mach-k3/am6_init.c | 2 +- 1 file changed

[U-Boot] [PATCH v2 2/6] configs: ti: Factor out call to 'args_mmc' into MMC common environment

2020-01-10 Thread Andrew F. Davis
not be MMC specific. Without the call to 'args_mmc' the command 'loadfit' becomes just a call to 'run_fit' so remove the indirection and call 'run_fit' directly, this removes the need for 'loadfit' command (which was misnamed anyway). Drop it. Signed-off-

[U-Boot] [PATCH v2 0/6] J721e HS device support

2020-01-10 Thread Andrew F. Davis
and testing. Although not strictly needed they do allow J721e HS to just work out-of-box by the time the last patch adds the defconfigs. Thanks, Andrew Changes from v1: - Rebase on master and re-sync defconfigs Andrew F. Davis (6): configs: j721e_evm.h: Sync J721e environment configuration

[U-Boot] [PATCH v2 1/6] configs: j721e_evm.h: Sync J721e environment configuration with AM65x

2020-01-10 Thread Andrew F. Davis
Some of the environment configuration in AM65x is not available in J721e due to additions on one but not the other. These two platforms are similar enough these common definitions should be factored out to a common area, prepare for this by synchronizing them. Signed-off-by: Andrew F. Davis

Re: [U-Boot] [PATCH 0/6] J721e HS device support

2020-01-10 Thread Andrew F. Davis
On 1/10/20 1:38 PM, Andrew F. Davis wrote: > Hi Tom, > > Looks like -next wasn't used for this, ping on getting this into master now? > Looks like a minor merge conflict now in master for this, I'll post a v2 to help with that. Andrew > Thanks, > Andrew >

Re: [U-Boot] [PATCH 0/6] J721e HS device support

2020-01-10 Thread Andrew F. Davis
Hi Tom, Looks like -next wasn't used for this, ping on getting this into master now? Thanks, Andrew On 12/16/19 3:50 PM, Andrew F. Davis wrote: > Hi Tom, > > I see you have a -next again, if you don't want to take this for the > v2020.01 perhaps this could be a good

[U-Boot] [PATCH v2] spl: Move check for SPL_LIBCOMMON support to header

2020-01-07 Thread Andrew F. Davis
Print statements in SPL depend on lib/common support, due to this many such print statements are ifdef'd. Instead of checking at each call site move the check to the common.h header and remove these inline checks. Signed-off-by: Andrew F. Davis Reviewed-by: Simon Glass --- common/common_

[U-Boot] [PATCH] arm: mach-k3: security: Clean image out of cache before authentication

2020-01-07 Thread Andrew F. Davis
version. Signed-off-by: Andrew F. Davis --- arch/arm/mach-k3/security.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/mach-k3/security.c b/arch/arm/mach-k3/security.c index 4e011ee10e..83b037f189 100644 --- a/arch/arm/mach-k3/security.c +++ b/arch/arm/mach-k3

[U-Boot] [PATCH] arm: mach-k3: Warn when node to disable is not found

2020-01-07 Thread Andrew F. Davis
Not finding a node that we try to disable does not always need to be fatal to boot but should at least print out a warning. Return error from fdt_disable_node as it did fail to disable the node, but only warn in the case of disabling the TRNG as this will not prevent boot. Signed-off-by: Andrew F

[U-Boot] [PATCH] defconfigs: Add a config for AM43xx High Security EVM with QSPI Boot support

2020-01-07 Thread Andrew F. Davis
On AM43xx HS devices, QSPI boot is XIP and we use a single stage bootloader. Add a defconfig for this. Signed-off-by: Andrew F. Davis --- MAINTAINERS | 1 + configs/am43xx_hs_evm_qspi_defconfig | 65 2 files changed, 66 insertions

[U-Boot] [PATCH] defconfigs: am43xx_hs_evm: Sync HS and non-HS defconfigs

2020-01-07 Thread Andrew F. Davis
Sync new additions to non-HS defconfig with HS defconfig. Signed-off-by: Andrew F. Davis --- configs/am43xx_hs_evm_defconfig | 15 +++ 1 file changed, 15 insertions(+) diff --git a/configs/am43xx_hs_evm_defconfig b/configs/am43xx_hs_evm_defconfig index d399ab7ed3..0255bcd994 100644

[U-Boot] [PATCH] defconfigs: am335x_hs_evm: Sync HS and non-HS defconfigs

2020-01-07 Thread Andrew F. Davis
Sync new additions to non-HS defconfig with HS defconfig. Signed-off-by: Andrew F. Davis --- configs/am335x_hs_evm_defconfig | 13 ++--- configs/am335x_hs_evm_uart_defconfig | 13 ++--- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/configs

Re: [U-Boot] [PATCH 1/3] tools: dumpimage: Provide more feedback on internal errors

2020-01-07 Thread Andrew F. Davis
On 11/13/19 11:14 AM, Andrew F. Davis wrote: > On 9/17/19 5:09 PM, Andrew F. Davis wrote: >> The dumpimage utility errors out in a number of places without providing >> sufficient feedback to allow the user to easily determine what has gone >> wrong. Add additional error messa

Re: [U-Boot] [PATCH 0/6] J721e HS device support

2019-12-16 Thread Andrew F. Davis
Hi Tom, I see you have a -next again, if you don't want to take this for the v2020.01 perhaps this could be a good candidate for the next? Andrew On 11/20/19 10:59 PM, Lokesh Vutla wrote: > > > On 20/11/19 11:10 PM, Andrew F. Davis wrote: >> Hello all, >> >

[U-Boot] [PATCH 1/6] configs: j721e_evm.h: Sync J721e environment configuration with AM65x

2019-11-20 Thread Andrew F. Davis
Some of the environment configuration in AM65x is not available in J721e due to additions on one but not the other. These two platforms are similar enough these common definitions should be factored out to a common area, prepare for this by synchronizing them. Signed-off-by: Andrew F. Davis

[U-Boot] [PATCH 3/6] arm: K3: Fix header comment match AM6 specific file function

2019-11-20 Thread Andrew F. Davis
This file used to be the common location for K3 init when AM6 was the only device, but common code was moved to common.c and this file became AM6 specific, correct this header text. Signed-off-by: Andrew F. Davis --- arch/arm/mach-k3/am6_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[U-Boot] [PATCH 6/6] configs: Add configs for J721e High Security EVM

2019-11-20 Thread Andrew F. Davis
ESS option set to 'y' CONFIG_BOOTCOMMAND uses FIT images for booting Signed-off-by: Andrew F. Davis --- configs/j721e_hs_evm_a72_defconfig | 106 + configs/j721e_hs_evm_r5_defconfig | 102 +++ 2 files changed, 208 insertions(

[U-Boot] [PATCH 5/6] arm: K3: Increase default SYSFW image size allocation

2019-11-20 Thread Andrew F. Davis
-by: Andrew F. Davis --- arch/arm/mach-k3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig index 5583241943..2e111bbf27 100644 --- a/arch/arm/mach-k3/Kconfig +++ b/arch/arm/mach-k3/Kconfig @@ -119,7 +119,7 @@ config

[U-Boot] [PATCH 2/6] configs: ti: Factor out call to 'args_mmc' into MMC common environment

2019-11-20 Thread Andrew F. Davis
not be MMC specific. Without the call to 'args_mmc' the command 'loadfit' becomes just a call to 'run_fit' so remove the indirection and call 'run_fit' directly, this removes the need for 'loadfit' command (which was misnamed anyway). Drop it. Signed-off

[U-Boot] [PATCH 4/6] arm: K3: Disable ROM configured firewalls

2019-11-20 Thread Andrew F. Davis
in re configuring the firewalls, it is concluded to clean this up in bootloaders. So disable all the firewalls that ROM doesn't open up the full address space. Signed-off-by: Andrew F. Davis Signed-off-by: Venkateswara Rao Mandela Signed-off-by: Lokesh Vutla --- arch/arm/mach-k3/am6_i

[U-Boot] [PATCH 0/6] J721e HS device support

2019-11-20 Thread Andrew F. Davis
and testing. Although not strictly needed they do allow J721e HS to just work out-of-box by the time the last patch adds the defconfigs. Thanks, Andrew Andrew F. Davis (6): configs: j721e_evm.h: Sync J721e environment configuration with AM65x configs: ti: Factor out call to 'args_mmc'

Re: [U-Boot] [PATCH 1/3] tools: dumpimage: Provide more feedback on internal errors

2019-11-13 Thread Andrew F. Davis
On 9/17/19 5:09 PM, Andrew F. Davis wrote: > The dumpimage utility errors out in a number of places without providing > sufficient feedback to allow the user to easily determine what has gone > wrong. Add additional error messages to make the cause of the failure > more obvious. >

[U-Boot] [PATCH] configs: j721e_evm_r5_defconfig: Remove SPL multi-DTB FIT support

2019-11-07 Thread Andrew F. Davis
: Andrew F. Davis --- configs/j721e_evm_r5_defconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/configs/j721e_evm_r5_defconfig b/configs/j721e_evm_r5_defconfig index b7168eceb4..57a8cf61e6 100644 --- a/configs/j721e_evm_r5_defconfig +++ b/configs/j721e_evm_r5_defconfig @@ -45,8 +45,6

Re: [U-Boot] Regression in fastboot on X15 due to CDCE913 enabling

2019-10-24 Thread Andrew F. Davis
Yes, this patch is applicable upstream as well. I did not get time to > post this series to upstream list. > >> ^^^ >> >>>>> >>>> >>>> I can confirm that that patch helps. If it's a proper fix, can you

[U-Boot] [PATCH] arm: K3: Increase default SYSFW image size allocation

2019-10-01 Thread Andrew F. Davis
. Signed-off-by: Andrew F. Davis --- arch/arm/mach-k3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig index 9652c96a78..de1c1cc73f 100644 --- a/arch/arm/mach-k3/Kconfig +++ b/arch/arm/mach-k3/Kconfig @@ -98,7 +98,7

[U-Boot] [PATCH] ARM: keystone2: update the default addresses of the secure monitor

2019-09-17 Thread Andrew F. Davis
From: Jean-Jacques Hiblot To accommodate the growth of u-boot, we need to shift the location of the secure monitor. Moving it 64kB further. Signed-off-by: Jean-Jacques Hiblot --- include/configs/ti_armv7_keystone2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/includ

[U-Boot] [PATCH] board: ti: am654: Disable TRNG node for HS devices

2019-09-17 Thread Andrew F. Davis
On HS devices the access to TRNG is restricted on the non-secure ARM side, disable the node in DT to prevent firewall violations. Signed-off-by: Andrew F. Davis --- arch/arm/mach-k3/common.c | 20 arch/arm/mach-k3/include/mach/sys_proto.h | 2 ++ board/ti

[U-Boot] [PATCH 1/3] tools: dumpimage: Provide more feedback on internal errors

2019-09-17 Thread Andrew F. Davis
The dumpimage utility errors out in a number of places without providing sufficient feedback to allow the user to easily determine what has gone wrong. Add additional error messages to make the cause of the failure more obvious. Signed-off-by: Andrew F. Davis --- tools/dumpimage.c | 14

[U-Boot] [PATCH 3/3] tools: dumpimage: Fall-though to print usage for help command

2019-09-17 Thread Andrew F. Davis
This has the same result but some compilers will warn about this fall-through if there are statements as part of the label block. Signed-off-by: Andrew F. Davis --- tools/dumpimage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/dumpimage.c b/tools/dumpimage.c index d5f893daf1

[U-Boot] [PATCH 2/3] tools: fit_image: Use fit_image_get_data_and_size for getting offset/size

2019-09-17 Thread Andrew F. Davis
easier to find out why. Signed-off-by: Andrew F. Davis --- tools/fit_image.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/fit_image.c b/tools/fit_image.c index 5aca634b5e..0e4c2271ce 100644 --- a/tools/fit_image.c +++ b/tools/fit_image.c @@ -738,9 +738,14

[U-Boot] [PATCH] configs: ti: Use addr_fit for run_fit environment variable

2019-09-17 Thread Andrew F. Davis
When running 'run_fit' the FIT file should have been loaded at 'addr_fit', although at this point they should be the same use this variable instead of 'loadaddr'. Signed-off-by: Andrew F. Davis --- include/configs/ti_armv7_common.h | 2 +- 1 file changed, 1 ins

[U-Boot] [PATCH 2/2] configs: am65x_hs_evm: Use FIT images when booting HS devices

2019-08-26 Thread Andrew F. Davis
HS devices use the FIT post processing step to authenticate boot images. Set the configured boot command to load FIT by default. Signed-off-by: Andrew F. Davis --- configs/am65x_hs_evm_a53_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs

[U-Boot] [PATCH 1/2] configs: ti: Add environment support commands for FIT loading

2019-08-26 Thread Andrew F. Davis
Some parts of these commands can be reused, add them to common files. Signed-off-by: Andrew F. Davis --- include/configs/am65x_evm.h | 3 +++ include/configs/ti_armv7_common.h | 8 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/include/configs/am65x_evm.h b

[U-Boot] [PATCH 3/3] configs: Rename environment variable fit_bootfile to name_fit

2019-08-12 Thread Andrew F. Davis
Like we did with 'fit_loadaddr' to 'addr_fit', the variable 'fit_bootfile' contains a name and so should be prefixed with name_. Make this change here. Signed-off-by: Andrew F. Davis --- include/configs/ti_armv7_common.h| 4 ++-- include/configs/ti_armv7_key

[U-Boot] [PATCH 2/3] configs: Rename environment variable fit_loadaddr to addr_fit

2019-08-12 Thread Andrew F. Davis
would work across all board that using the this naming convention. We can do this one variable at a time, start here with addr_fit. Signed-off-by: Andrew F. Davis --- include/configs/k2g_evm.h| 2 +- include/configs/ti_armv7_common.h| 4 ++-- include/configs/ti_armv7_keysto

[U-Boot] [PATCH 1/3] configs: Remove unneeded overlay_files environment variable

2019-08-12 Thread Andrew F. Davis
The variable 'name_overlays' serves the same purpose. Remove 'overlay_files' and use 'name_overlays' everywhere. Signed-off-by: Andrew F. Davis --- include/configs/am65x_evm.h | 5 ++--- include/configs/j721e_evm.h | 6 ++ 2 files changed, 4 insertions(+)

Re: [U-Boot] [PATCH v2] omap: Correct the fastboot product var

2019-07-25 Thread Andrew F. Davis
that user tries to flash images to the board which > those images were built for. > > Signed-off-by: Sam Protsenko > --- Much cleaner like this, thanks, Acked-by: Andrew F. Davis > Changes in v2: > - reuse the value from $board_name instead of hard-coding it to > "beagle

Re: [U-Boot] [PATCH] board: ti: am57xx: Correct the fastboot product var

2019-07-25 Thread Andrew F. Davis
On 7/25/19 10:43 AM, Sam Protsenko wrote: > On Thu, Jul 25, 2019 at 5:05 PM Andrew F. Davis wrote: >> >> On 7/25/19 9:22 AM, Sam Protsenko wrote: >>> "fastboot flashall" expects "fastboot getvar product" to be >>> "beagle_x15board". I

Re: [U-Boot] [PATCH] board: ti: am57xx: Correct the fastboot product var

2019-07-25 Thread Andrew F. Davis
uot;fastboot.product", "beagle_x15board"); This doesn't seem right.. This is common source for all AM57x based boards, the only thing we can return here is "am57xx". Either fastboot needs some sort of conversion on its side, or we set the exact board name the same way we

[U-Boot] [PATCH v2] arm: mach-keystone: Use appended original image size in image processing

2019-07-16 Thread Andrew F. Davis
-by: Andrew F. Davis --- Changes from v1: - Use get_unaligned_le32 - Fixup header/copyright while here arch/arm/mach-keystone/mon.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-keystone/mon.c b/arch/arm/mach-keystone/mon.c index 51af028590

Re: [U-Boot] [PATCH] env: ti: boot: Use ttyS2 instead of ttyO2

2019-07-16 Thread Andrew F. Davis
On 7/16/19 9:15 AM, Sam Protsenko wrote: > Hi Andrew, > > On Mon, Jul 15, 2019 at 10:15 PM Andrew F. Davis wrote: >> >> On 7/12/19 1:38 PM, Sam Protsenko wrote: >>> ttyO2 console enables legacy CONFIG_SERIAL_OMAP driver in kernel. >>> Now

Re: [U-Boot] [PATCH] env: ti: boot: Use ttyS2 instead of ttyO2

2019-07-15 Thread Andrew F. Davis
S_INDEX == 1) This CONFIG_CONS_INDEX is not enabled for this platform, meaning the non-default console is chosen by default, it's not caused by this patch but while you are here could you fix that up? Just set: #define CONSOLEDEV "ttyS0" and drop all the #ifdef stuff, makes

[U-Boot] [PATCH] arm: mach-keystone: Use appended original image size in image processing

2019-07-12 Thread Andrew F. Davis
-by: Andrew F. Davis --- arch/arm/mach-keystone/mon.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-keystone/mon.c b/arch/arm/mach-keystone/mon.c index 51af028590..b7ffe277c1 100644 --- a/arch/arm/mach-keystone/mon.c +++ b/arch/arm/mach-keystone/mon.c

[U-Boot] [PATCH] fs: fat: Fix possible double free of fatbuf

2019-05-16 Thread Andrew F. Davis
fat_itr_root() allocates fatbuf so we free it on the exit path, if the function fails we should not free it, check the return value and skip freeing if the function fails. Signed-off-by: Andrew F. Davis --- fs/fat/fat.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

Re: [U-Boot] [PATCH 13/18] arm: K3: am654: Map common EEPROM data into SRAM scratch space

2019-05-09 Thread Andrew F. Davis
s. After R5 SPL has finished bootloading is handled by A53 cores, the R5 will be repurposed and other software will run on it, possibly wiping out the memory here. Anything we want to pass form R5 to A53 should use a non-R5-local memory, not this scratchpad. We need the same for passing the original

Re: [U-Boot] [PATCH 07/18] configs: am65x_hs_evm_defconfig: Enable I2C support

2019-05-08 Thread Andrew F. Davis
4 > configs/am65x_hs_evm_r5_defconfig | 4 Thanks for not forgetting HS :) For all the _hs defconfig changes in this series: Acked-by: Andrew F. Davis > 2 files changed, 8 insertions(+) > > diff --git a/configs/am65x_hs_evm_a53_defconfig > b/configs/am65x_hs_evm_a53_defconf

[U-Boot] [PATCH] firmware: ti_sci: Always request response from firmware

2019-04-29 Thread Andrew F. Davis
TI-SCI firmware will only respond to messages when the TI_SCI_FLAG_REQ_ACK_ON_PROCESSED flag is set. Most messages already do this, set this for the ones that do not. Signed-off-by: Andrew F. Davis Tested-by: Alejandro Hernandez --- drivers/firmware/ti_sci.c | 11 ++- 1 file changed, 6

Re: [U-Boot] [PATCH v3 0/7] AM65x HS device support

2019-04-25 Thread Andrew F. Davis
On 4/12/19 12:54 PM, Andrew F. Davis wrote: > Hello all, > > This series brings up HS device support on the AM65x platform. Support > for HS on K3 family devices is a bit different than previous devices > but for the most part all that has been abstracted into the SECDEV > packa

Re: [U-Boot] [U-Boot,v2,0/7] AM65x HS device support

2019-04-12 Thread Andrew F. Davis
On 4/12/19 12:27 PM, Tom Rini wrote: > On Thu, Feb 21, 2019 at 04:35:05PM -0600, Andrew F. Davis wrote: > >> Hello all, >> >> This series brings up HS device support on the AM65x platform. Support >> for HS on K3 family devices is a bit different than previous device

[U-Boot] [PATCH v3 6/7] configs: Add configs for AM65x High Security EVM

2019-04-12 Thread Andrew F. Davis
o 'y' Signed-off-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by: Andreas Dannenberg --- MAINTAINERS| 2 + configs/am65x_hs_evm_a53_defconfig | 77 + configs/am65x_hs_evm_r5_defconfig | 90 ++ 3

[U-Boot] [PATCH v3 7/7] doc: Update info on using K3 secure devices

2019-04-12 Thread Andrew F. Davis
Signed-off-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by: Andreas Dannenberg --- doc/README.ti-secure | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/doc/README.ti-secure b/doc/README.ti-secure index 76950253ac..27c0eaa77f 100644 --- a/doc

[U-Boot] [PATCH v3 0/7] AM65x HS device support

2019-04-12 Thread Andrew F. Davis
, Andrew Changes from v2: - Rebased on latest master Changes from v1: - Commented on use of .data section - Use ti_sci_msg_hdr header directly when possible - Rebase and add Reviewed-bys - Will add makefile cleanup later as it also affects files unrelated to this series Andrew F. Davis (7

[U-Boot] [PATCH v3 2/7] firmware: ti_sci: Add support for firewall management

2019-04-12 Thread Andrew F. Davis
TI-SCI message protocol provides support for controlling the firewall configurations available in SoC. Introduce support for the set of TI-SCI message protocol APIs that provide us with this capability of controlling firewalls. Signed-off-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by

[U-Boot] [PATCH v3 1/7] arm: K3: Avoid use of MCU_PSRAM0 before SYSFW is loaded

2019-04-12 Thread Andrew F. Davis
.data section. This section is used as .bss will be cleared between saving this value and using it. Signed-off-by: Andrew F. Davis Reviewed-by: Andreas Dannenberg Reviewed-by: Lokesh Vutla --- arch/arm/mach-k3/am6_init.c | 13 - arch/arm/mach-k3/include/mach

[U-Boot] [PATCH v3 3/7] firmware: ti_sci: Modify auth_boot TI-SCI API to match new version

2019-04-12 Thread Andrew F. Davis
SYSFW version 2019.01 introduces a slightly modified version of this API, add support for it here. Signed-off-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by: Andreas Dannenberg --- drivers/firmware/ti_sci.c | 25 - drivers/firmware/ti_sci.h

[U-Boot] [PATCH v3 5/7] arm: mach-k3: Add secure device build support

2019-04-12 Thread Andrew F. Davis
K3 HS devices require signed binaries for boot, use the SECDEV tools to sign the boot artifacts during build. Signed-off-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by: Andreas Dannenberg --- MAINTAINERS | 1 + arch/arm/mach-k3/config.mk| 25

[U-Boot] [PATCH v3 4/7] arm: mach-k3: Add secure device support

2019-04-12 Thread Andrew F. Davis
-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by: Andreas Dannenberg --- MAINTAINERS | 1 + arch/arm/Kconfig| 2 +- arch/arm/mach-k3/Makefile | 1 + arch/arm/mach-k3/security.c | 63 + 4 files changed, 66 insertions(+), 1

Re: [U-Boot] [PATCH v2 1/7] arm: K3: Avoid use of MCU_PSRAM0 before SYSFW is loaded

2019-04-10 Thread Andrew F. Davis
On 2/21/19 6:10 PM, Tom Rini wrote: > On Thu, Feb 21, 2019 at 04:35:06PM -0600, Andrew F. Davis wrote: > >> On HS devices the 512b region of reset isolated memory called >> MCU_PSRAM0 is firewalled by default. Until SYSFW is loaded we >> cannot use this memory. It is onl

Re: [U-Boot] [PATCH v3 06/13] mmc: sdhci: Add support for sdhci-caps-mask

2019-03-27 Thread Andrew F. Davis
> + int ret; > + > + ret = dev_read_u32_array(host->mmc->dev, "sdhci-caps-mask", > + mask, 2); You can't do this, host->mmc is not setup at this point, you will get a null pointer deref here. (On K3 dereferencing zero does not throw an error so it masks th

Re: [U-Boot] [PATCH] configs: ti: Move FIT image load address to avoid overwrite

2019-03-26 Thread Andrew F. Davis
On 3/26/19 11:21 AM, Tom Rini wrote: > On Tue, Mar 26, 2019 at 10:12:01AM -0500, Andrew F. Davis wrote: > >> The FIT image is loaded to 0x8700_ followed by extracting from that >> several large images also into the 0x8x00_ range. Large images >> can end up overwri

[U-Boot] [PATCH] configs: ti: Move FIT image load address to avoid overwrite

2019-03-26 Thread Andrew F. Davis
least 256MB of DRAM, if less then more careful planning will be required for that platform. Signed-off-by: Andrew F. Davis --- include/configs/ti_armv7_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h

Re: [U-Boot] [PATCH 00/11] Fix Ethernet boot in am335x

2019-03-21 Thread Andrew F. Davis
On 3/21/19 10:22 AM, Andrew F. Davis wrote: > On 3/18/19 3:24 AM, Faiz Abbas wrote: >> The following patches fix ethernet boot in am335x. >> >> Enabling OF_CONTROL in SPL makes it overflow the sram size. To avoid > > If you are overflowing SRAM on the non-H

Re: [U-Boot] [PATCH 00/11] Fix Ethernet boot in am335x

2019-03-21 Thread Andrew F. Davis
just build for am335x_hs_evm_defconfig and it should break build if you out of space. Thanks, Andrew > this, I am using static platdata in the am335x board file instead of > the fdtdec_*() calls used in ofdata_to_platdata(). > > Patches 1-5 isolate the two operations of getting pla

[U-Boot] [PATCH v2 5/7] arm: mach-k3: Add secure device build support

2019-02-21 Thread Andrew F. Davis
K3 HS devices require signed binaries for boot, use the SECDEV tools to sign the boot artifacts during build. Signed-off-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by: Andreas Dannenberg --- MAINTAINERS | 1 + arch/arm/mach-k3/config.mk| 25

[U-Boot] [PATCH v2 6/7] configs: Add a config for AM65x High Security EVM

2019-02-21 Thread Andrew F. Davis
o 'y' Signed-off-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by: Andreas Dannenberg --- MAINTAINERS| 2 + configs/am65x_hs_evm_a53_defconfig | 74 configs/am65x_hs_evm_r5_defconfig | 90 ++ 3 files chan

[U-Boot] [PATCH v2 7/7] doc: Update info on using K3 secure devices

2019-02-21 Thread Andrew F. Davis
Signed-off-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by: Andreas Dannenberg --- doc/README.ti-secure | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/doc/README.ti-secure b/doc/README.ti-secure index 76950253ac..27c0eaa77f 100644 --- a/doc

[U-Boot] [PATCH v2 3/7] firmware: ti_sci: Modify auth_boot TI-SCI API to match new version

2019-02-21 Thread Andrew F. Davis
SYSFW version 2019.01 introduces a slightly modified version of this API, add support for it here. Signed-off-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by: Andreas Dannenberg --- drivers/firmware/ti_sci.c | 25 - drivers/firmware/ti_sci.h

[U-Boot] [PATCH v2 1/7] arm: K3: Avoid use of MCU_PSRAM0 before SYSFW is loaded

2019-02-21 Thread Andrew F. Davis
.data section. This section is used as .bss will be cleared between saving this value and using it. Signed-off-by: Andrew F. Davis Reviewed-by: Andreas Dannenberg Reviewed-by: Lokesh Vutla --- arch/arm/mach-k3/am6_init.c | 13 - arch/arm/mach-k3/include/mach

[U-Boot] [PATCH v2 4/7] arm: mach-k3: Add secure device support

2019-02-21 Thread Andrew F. Davis
-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by: Andreas Dannenberg --- MAINTAINERS | 1 + arch/arm/Kconfig| 2 +- arch/arm/mach-k3/Makefile | 1 + arch/arm/mach-k3/security.c | 63 + 4 files changed, 66 insertions(+), 1

[U-Boot] [PATCH v2 2/7] firmware: ti_sci: Add support for firewall management

2019-02-21 Thread Andrew F. Davis
TI-SCI message protocol provides support for controlling the firewall configurations available in SoC. Introduce support for the set of TI-SCI message protocol APIs that provide us with this capability of controlling firewalls. Signed-off-by: Andrew F. Davis Reviewed-by: Tom Rini Reviewed-by

[U-Boot] [PATCH v2 0/7] AM65x HS device support

2019-02-21 Thread Andrew F. Davis
, Andrew Changes from v1: - Commented on use of .data section - Use ti_sci_msg_hdr header directly when possible - Rebase and add Reviewed-bys - Will add makefile cleanup later as it also affects files unrelated to this series Andrew F. Davis (7): arm: K3: Avoid use of MCU_PSRAM0 before

Re: [U-Boot] [PATCH 5/7] arm: mach-k3: Add secure device build support

2019-02-18 Thread Andrew F. Davis
On 2/16/19 4:18 PM, Tom Rini wrote: > On Fri, Feb 15, 2019 at 05:43:32PM +0530, Lokesh Vutla wrote: >> >> >> On 2/15/2019 4:25 AM, Andrew F. Davis wrote: >>> On 2/13/19 9:46 PM, Lokesh Vutla wrote: >>>> >>>> >>>> On 14/02/19 1

Re: [U-Boot] [PATCH 5/7] arm: mach-k3: Add secure device build support

2019-02-14 Thread Andrew F. Davis
On 2/13/19 9:46 PM, Lokesh Vutla wrote: > > > On 14/02/19 12:07 AM, Andrew F. Davis wrote: >> K3 HS devices require signed binaries for boot, use the SECDEV tools >> to sign the boot artifacts during build. >> >> Signed-off-by: Andrew F. Davis >> --- >

Re: [U-Boot] [PATCH 1/7] arm: K3: Avoid use of MCU_PSRAM0 before SYSFW is loaded

2019-02-14 Thread Andrew F. Davis
On 2/13/19 9:32 PM, Lokesh Vutla wrote: > > > On 14/02/19 12:07 AM, Andrew F. Davis wrote: >> On HS devices the 512b region of reset isolated memory called >> MCU_PSRAM0 is firewalled by default. Until SYSFW is loaded we >> cannot use this memory. It is only used to s

<    1   2   3   4   5   6   7   8   9   10   >