Re: [PATCH] linker_lists.h: Add attribute used to ll_entry_start macro

2023-03-23 Thread appujee
changes. On Thu, Mar 23, 2023 at 3:44 PM Tom Rini wrote: > > On Thu, Mar 23, 2023 at 03:38:33PM -0700, appujee wrote: > > > added comments: > > https://lists.denx.de/pipermail/u-boot/2023-March/513078.html > > OK, and that references a gcc bugzilla entry where Andre

Re: [PATCH] linker_lists.h: Add attribute used to ll_entry_start macro

2023-03-23 Thread appujee
added comments: https://lists.denx.de/pipermail/u-boot/2023-March/513078.html On Thu, Mar 23, 2023 at 1:31 PM Tom Rini wrote: > > On Thu, Mar 23, 2023 at 01:29:29PM -0700, appujee wrote: > > > > So, saying "unused" and then "used" doesn't seem to make any se

[PATCH] linker_lists.h: Adding comments to clarify attribute(used)

2023-03-23 Thread appujee
>From 807a20a152cbebcc70ab81de825a28da94a07ab6 Mon Sep 17 00:00:00 2001 From: AdityaK Date: Thu, 23 Mar 2023 15:30:15 -0700 Subject: [PATCH] [PATCH] linker_lists.h: Adding comments to clarify attribute(used) Change-Id: I2878f458b8955cac23acd54f4cfaafe7f132935b Signed-off-by: AdityaK Tom Rini

Re: [PATCH] linker_lists.h: Add attribute used to ll_entry_start macro

2023-03-23 Thread appujee
> So, saying "unused" and then "used" doesn't seem to make any sense. unused and used attributes do not cancel each other. They have different semantics. I agree this part of the code needs some attention. zero sized arrays are not C compliant as I understand it, even more so when it is declared