Re: [PATCH v2 0/2] a little RPi watchdog cleanup

2024-07-15 Thread Stefan Roese
On 7/15/24 15:03, Rasmus Villemoes wrote: Stefan Roese writes: @Tom, I can't find these patches (and v1) in patchworks. Do you have an idea, why this is the case? Perhaps because they (v2) have already been merged to master via a PR from Peter? commit 1ca216522d4. Ah, I was not aware

Please pull u-boot-marvell/master

2024-07-15 Thread Stefan Roese
(Tony) Here the Azure build, without any issues: https://dev.azure.com/sr0718/u-boot/_build/results?buildId=373=results Thanks, Stefan The following changes since commit b182816c1fb436916661949213c543bf4d42250b: turris_1x

Re: [PATCH v3] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-07-15 Thread Stefan Roese
Synology DS414 and DS214+ boards - Add SYS_THUMB_BUILD to reduce binary size - Add NET_RANDOM_ETHADDR - Add CONFIG_LBA48 and CONFIG_SYS_64BIT_LBA to support >2TB HDD/SDD Signed-off-by: Tony Dinh Applied to u-boot-marvell/master Thanks, Stefan --- Changes in v3: - Restore misc_init_r() to supp

Re: [PATCH] arm: dts: mvebu: Migrate to upstream DT for Synology DS116 (Armada 385) board

2024-07-15 Thread Stefan Roese
On 5/22/24 23:51, Tony Dinh wrote: Enable OF_UPSTREAM to use upstream DT and add marvell/ prefix to the DEFAULT_DEVICE_TREE in DS116 defconfig. Remove current DTS in arch/arm/dts/ directory. Signed-off-by: Tony Dinh Applied to u-boot-marvell/master Thanks, Stefan --- arch/arm/dts

Re: [PATCH v2 0/2] a little RPi watchdog cleanup

2024-07-15 Thread Stefan Roese
@Tom, I can't find these patches (and v1) in patchworks. Do you have an idea, why this is the case? Thanks, Stefan On 7/12/24 11:07, Rasmus Villemoes wrote: Two related leftovers I found while looking at remaining hw_watchdog/CONFIG_HW_WATCHDOG items. v2: Add Stefan's R-bs. Trim commit log

Re: [PATCH 2/2] board: rpi: remove leftover CONFIG_HW_WATCHDOG block

2024-07-11 Thread Stefan Roese
driver and its references), but this block was left behind. Another rpi watchdog driver has since been added, but that does not select HW_WATCHDOG, so this remains dead and unused. Remove it. Signed-off-by: Rasmus Villemoes Reviewed-by: Stefan Roese Thanks, Stefan --- board/raspberrypi

Re: [PATCH 1/2] arm: bcm283x: remove pointless empty hw_watchdog_disable

2024-07-11 Thread Stefan Roese
to drop these infos, then I won't object. Reviewed-by: Stefan Roese Thanks, Stefan Signed-off-by: Rasmus Villemoes --- arch/arm/mach-bcm283x/reset.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-bcm283x/reset.c b/arch/arm/mach-bcm283x/reset

Re: [PATCH v3] arm: mvebu: Enable bootstd and other modernization for Synology DS414 (Armada XP) board

2024-07-10 Thread Stefan Roese
Synology DS414 and DS214+ boards - Add SYS_THUMB_BUILD to reduce binary size - Add NET_RANDOM_ETHADDR - Add CONFIG_LBA48 and CONFIG_SYS_64BIT_LBA to support >2TB HDD/SDD Signed-off-by: Tony Dinh Reviewed-by: Stefan Roese @Phil, is this ready to be merged from your point of view as well? Tha

Re: [PATCH] arm: dts: mvebu: Migrate to upstream DT for Synology DS116 (Armada 385) board

2024-07-10 Thread Stefan Roese
Hi Tony, On 7/9/24 22:27, Tony Dinh wrote: Hi Stefan, On Thu, May 23, 2024 at 12:27 AM Sumit Garg wrote: On Thu, 23 May 2024 at 03:22, Tony Dinh wrote: Enable OF_UPSTREAM to use upstream DT and add marvell/ prefix to the DEFAULT_DEVICE_TREE in DS116 defconfig. Remove current DTS in arch

Please pull u-boot-marvell/master

2024-07-08 Thread Stefan Roese
Armada 38x and Turris Omnia (Marek) - Misc turris_omnia changes (Marek) Here the Azure build, without any issues: https://dev.azure.com/sr0718/u-boot/_build/results?buildId=372=results Thanks, Stefan The following changes si

Re: [PATCH] mvebu: armada-8k: respect CONFIG_DISTRO_DEFAULTS

2024-07-08 Thread Stefan Roese
the value of CONFIG_DISTRO_DEFAULTS. Signed-off-by: Robert Marko Applied to u-boot-marvell/master Thanks, Stefan --- include/configs/mvebu_armada-8k.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/configs/mvebu_armada-8k.h b/include/configs/mvebu_armada-8k.h

Re: [PATCH u-boot-marvell 00/16] Turris Omnia DDR training changes

2024-07-08 Thread Stefan Roese
On 6/18/24 17:34, Marek Behún wrote: Hi Stefan, this is v2 of the series adds some changes to DDR3 training for Armada 38x and Turris Omnia. I also put one unrelated patch (Fix ethernet PHY reset gpio FDT fixup) here. It depends on stuff in Tom's next branch. Applied to u-boot-marvell

Re: [PATCH] arm: dts: mvebu: Update DTS for Thecus N2350 board

2024-07-08 Thread Stefan Roese
://www.macronix.com/Lists/Datasheet/Attachments/8575/MX25L3205D,%203V,%2032Mb,%20v1.5.pdf I'll wait for Stefan to review the patch and let him decide whether I should send in a V2 patch or he will modify the commit description. I've changed the commit message accordingly. Applied to u-boot-marvell

Re: [PATCH] arm: mvebu: env_sf_get_env_addr() missing check for CONFIG_ENV_IS_IN_SPI_FLASH

2024-07-08 Thread Stefan Roese
be provided. Signed-off-by: Tony Dinh Applied to u-boot-marvell/master Thanks, Stefan --- arch/arm/mach-mvebu/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-mvebu/cpu.c b/arch/arm/mach-mvebu/cpu.c index 7c62a5dbb6..6dd729ae6e 100644 --- a/arch/arm

Re: [PATCH v3] configs: add mvebu_espressobin_ultra-88f3720_defconfig

2024-07-08 Thread Stefan Roese
On 5/30/24 06:47, Benjamin Schneider wrote: Add support for a Marvell Armada 3720 device variant Signed-off-by: Benjamin Schneider Applied to u-boot-marvell/master Thanks, Stefan --- Changes in v3: - Fix typo in MAINTAINERS board/Marvell/mvebu_armada-37xx/MAINTAINERS | 5

Re: [PATCH] arm: davinci: remove unused defines

2024-06-19 Thread Stefan Roese
ff-by: Emil Kronborg --- arch/arm/mach-davinci/include/mach/timer_defs.h | 16 1 file changed, 16 deletions(-) Reviewed-by: Stefan Roese Thanks, Stefan diff --git a/arch/arm/mach-davinci/include/mach/timer_defs.h b/arch/arm/mach-davinci/include/mach/timer_defs.

Re: [PATCH] arm: davinci: remove unused watchdog functions

2024-06-19 Thread Stefan Roese
mer_defs.h| 4 --- arch/arm/mach-davinci/timer.c | 31 --- 2 files changed, 35 deletions(-) Nice small cleanup: Reviewed-by: Stefan Roese Thanks, Stefan diff --git a/arch/arm/mach-davinci/include/mach/timer_defs.h b/arch/arm/mach-davinci/include/mach/timer_de

Re: [PATCH 12/20] cyclic: Rise default CYCLIC_MAX_CPU_TIME_US to 5000

2024-06-18 Thread Stefan Roese
Hi Jiaxun, On 6/18/24 16:00, Jiaxun Yang wrote: 在2024年6月18日六月 上午12:29,Tom Rini写道: [...] Acked-by: Stefan Roese Can we please get either this, or https://patchwork.ozlabs.org/project/uboot/patch/20240524210817.1953298-1-rasmus.villem...@prevas.dk/ merged for master? The number of false

Please pull u-boot-watchdog/master

2024-06-18 Thread Stefan Roese
the Azure build, without any issues: https://dev.azure.com/sr0718/u-boot/_build/results?buildId=371=results Thanks, Stefan The following changes since commit 16324b43db3f2b4fbbc3b701893fcfc4104f33fb: Merge tag 'u-boot-nand-20240617' of https://source.denx.de/u-boot/custodians/u-boot-nand-flash (2024

Re: [PATCH 12/20] cyclic: Rise default CYCLIC_MAX_CPU_TIME_US to 5000

2024-06-18 Thread Stefan Roese
On 6/18/24 01:29, Tom Rini wrote: On Fri, Jun 14, 2024 at 04:13:54PM +0200, Stefan Roese wrote: On 6/12/24 18:50, Tom Rini wrote: On Wed, Jun 12, 2024 at 05:13:37PM +0100, Jiaxun Yang wrote: 在2024年6月12日六月 下午5:00,Tom Rini写道: [...] configs/octeon_nic23_defconfig | 1 - 2 files changed

Please pull u-boot-watchdog/next

2024-06-16 Thread Stefan Roese
Here the Azure build, without any issues: https://dev.azure.com/sr0718/u-boot/_build/results?buildId=369=results Thanks, Stefan The following changes since commit 0786dd573d0793417852e009dee3148ebdd163f3: test/py: net_boot: Add test cases for net boot (2024-06-13 16:31:24 -0600) are avail

Re: [PATCH 0/7] watchdog_reset cleanup

2024-06-16 Thread Stefan Roese
. Apart from the two sh4 patches, these are independent of each other and can be applied individually. Cc: Angelo Dureghello Cc: Christophe Leroy Cc: Huan Wang Cc: Nobuhiro Iwamatsu Applied to u-boot-watchdog/next Thanks, Stefan Rasmus Villemoes (7): m68k: remove dead code wdt

Re: [PATCH v4 0/3] cyclic/watchdog patches

2024-06-16 Thread Stefan Roese
: Add R-bs from Stefan. Fixup whitespace in the doc/ part. Rebase to current master (676903c1b97), fixing trivial conflict with 301bac6047c8. Rasmus Villemoes (3): cyclic: stop strdup'ing name in cyclic_register() wdt-uclass: prevent multiple cyclic_register calls cyclic: make clients embed

Re: [PATCH 0/7] watchdog_reset cleanup

2024-06-16 Thread Stefan Roese
. Apart from the two sh4 patches, these are independent of each other and can be applied individually. Cc: Angelo Dureghello Cc: Christophe Leroy Cc: Huan Wang Cc: Nobuhiro Iwamatsu Thanks for continuing the cleanup here: Reviewed-by: Stefan Roese Thanks, Stefan Rasmus Villemoes (7

Re: [PATCH 12/20] cyclic: Rise default CYCLIC_MAX_CPU_TIME_US to 5000

2024-06-14 Thread Stefan Roese
this in mind when implementing), so: Acked-by: Stefan Roese Thanks, Stefan

Re: [PATCH v4 0/3] cyclic/watchdog patches

2024-05-21 Thread Stefan Roese
On 5/21/24 14:45, Rasmus Villemoes wrote: On 21/05/2024 13.54, Stefan Roese wrote: On 5/21/24 11:47, Rasmus Villemoes wrote: On 21/05/2024 10.46, Rasmus Villemoes wrote: A bit of a mixed bag. I've been wanting to submit something like 3/3 for a while. So when I stumbled on Marek's patch https

Re: [PATCH v4 0/3] cyclic/watchdog patches

2024-05-21 Thread Stefan Roese
perhaps Tom has some ideas? Regarding this cyclic patch: Still some problems, MIPS64 related at least, octeon_nic23 target: https://dev.azure.com/sr0718/0cded7c3-6e6a-4b57-8d0f-65c99496c42f/_apis/build/builds/357/logs/415 Thanks, Stefan

Re: [PATCH v2 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-21 Thread Stefan Roese
On 5/21/24 10:38, Rasmus Villemoes wrote: On 21/05/2024 08.57, Stefan Roese wrote: On 5/19/24 21:44, Rasmus Villemoes wrote: On 18/05/2024 09.34, Stefan Roese wrote: This introduces some problems when compiling e.g. sandbox: In file included from test/common/cyclic.c:10: test/common

Re: [PATCH v2 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-21 Thread Stefan Roese
On 5/19/24 21:44, Rasmus Villemoes wrote: On 18/05/2024 09.34, Stefan Roese wrote: This introduces some problems when compiling e.g. sandbox: In file included from test/common/cyclic.c:10: test/common/cyclic.c: In function ‘dm_test_cyclic_running’: test/common/cyclic.c:25:42: warning: passing

Re: [PATCH v2 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-18 Thread Stefan Roese
not emit a warning for a maybe-unused function and (2) see that it can actually never be reached, so not emit any code for it. Reviewed-by: Stefan Roese Signed-off-by: Rasmus Villemoes --- board/Marvell/octeon_nic23/board.c | 9 +--- cmd/cyclic.c | 12

Re: [PATCH 3/3] cyclic: make clients embed a struct cyclic_info in their own data structure

2024-05-16 Thread Stefan Roese
this approach. And would like to pull this in as well, perhaps before leaving on a 2 week vacation mid of next week. Unfortunately this patch 3/3 does not apply on TOT any more. Could you please rebase and re-submit? Reviewed-by: Stefan Roese Thanks, Stefan diff --git a/board/Marvell

Re: [PATCH 07/11] watchdog: Add support for ADI SC5XX-family watchdog peripheral

2024-05-15 Thread Stefan Roese
/adi_wdt.c Reviewed-by: Stefan Roese Thanks, Stefan diff --git a/MAINTAINERS b/MAINTAINERS index c1685f0352..6feb7e540b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -618,6 +618,7 @@ F: drivers/pinctrl/pinctrl-adi-adsp.c F:drivers/serial/serial_adi_uart4.c F:drivers/timer

Re: [PATCH u-boot-mvebu 10/10] arm: mvebu: turris_omnia: Support old DDR3 training, selectable via env var

2024-05-15 Thread Stefan Roese
On 5/15/24 11:24, Marek Behún wrote: On Wed, 15 May 2024 11:10:09 +0200 Stefan Roese wrote: Hi Marek, On 5/15/24 10:59, Marek Behún wrote: On Mon, 6 May 2024 12:03:55 +0200 Stefan Roese wrote: Hi Marek, On 4/15/24 18:30, Marek Behún wrote: Support old DDR3 training code on Turris

Re: [PATCH 3/3] drivers: misc: Add driver to access ZynqMP efuses

2024-05-15 Thread Stefan Roese
Hi Lukas, On 5/15/24 08:33, Lukas Funke wrote: Hi Stefan, On 15.05.2024 08:12, Stefan Roese wrote: Hi Lukas, On 5/14/24 16:04, lukas.funke-...@weidmueller.com wrote: From: Lukas Funke Add driver to access ZynqMP efuses. This is a u-boot port of [1]. [1] https://lore.kernel.org/all

Re: [PATCH u-boot-mvebu 10/10] arm: mvebu: turris_omnia: Support old DDR3 training, selectable via env var

2024-05-15 Thread Stefan Roese
Hi Marek, On 5/15/24 10:59, Marek Behún wrote: On Mon, 6 May 2024 12:03:55 +0200 Stefan Roese wrote: Hi Marek, On 4/15/24 18:30, Marek Behún wrote: Support old DDR3 training code on Turris Omnia, selectable by U-Boot enviroment variable. Users experiencing DDR3 initialization failures

Re: [PATCH 3/3] drivers: misc: Add driver to access ZynqMP efuses

2024-05-15 Thread Stefan Roese
quot;xlnx,zynqmp-nvmem-fw", }, + { /* sentinel */ }, +}; + +static const struct misc_ops zynqmp_efuse_ops = { + .read = zynqmp_nvmem_read, + .write = zynqmp_nvmem_write, +}; + +U_BOOT_DRIVER(zynqmp_efuse) = { + .name = "zynqmp_efuse", + .id = UCLASS_MI

Re: [PATCH 1/3] firmware: zynqmp: Add support to access efuses

2024-05-15 Thread Stefan Roese
ress), + lower_32_bits(address), 0, 0, ret_payload); Same here. Thanks, Stefan + + *out = ret_payload[1]; + + return ret; +} + int zynqmp_pm_is_function_supported(const u32 api_id, const u32 id) { int ret; diff --git a/include/zynqmp_firmware.h b/include/zynqmp_firmware.h i

Re: [PATCH 2/3] wdt-uclass: prevent multiple cyclic_register calls

2024-05-13 Thread Stefan Roese
Hi Rasmus, On 5/13/24 13:09, Rasmus Villemoes wrote: On 13/05/2024 12.40, Stefan Roese wrote: On 5/9/24 02:47, Rasmus Villemoes wrote: Currently, the cyclic_register() done in wdt_start() is not undone in wdt_stop(). Moreover, calling wdt_start multiple times (which is perfectly allowed

Re: [PATCH 2/3] wdt-uclass: prevent multiple cyclic_register calls

2024-05-13 Thread Stefan Roese
work here. I do have a question regarding this patch though. AFAIU, it's a valid use-case to enable 2 different watchdog devices. And this patch will prevent such a setup. Or do I misunderstand this? Thanks, Stefan Signed-off-by: Rasmus Villemoes --- drivers/watchdog/wdt-uclass.c | 9 +++-

Re: [PATCH 1/3] cyclic: stop strdup'ing name in cyclic_register()

2024-05-13 Thread Stefan Roese
ong as the cyclic_info is registered, so just make that a requirement. Signed-off-by: Rasmus Villemoes Reviewed-by: Stefan Roese Thanks, Stefan --- common/cyclic.c | 2 +- include/cyclic.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/cyclic.c b/common/cycli

Re: [PATCH 60/81] serial: Remove and add needed includes

2024-05-09 Thread Stefan Bosch
On 02.05.24 03:31, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini Tested-by: Stefan Bosch Looks ok, tested on FriendlyElec-Board NanoPC-T2 (s5p4418_nanopi2_defconfig). Thanks a lot! --- Cc: Tom Rini Cc

Re: [PATCH 51/81] pinctrl: Remove and add needed includes

2024-05-09 Thread Stefan Bosch
On 02.05.24 03:31, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini Tested-by: Stefan Bosch Looks ok, tested on FriendlyElec-Board NanoPC-T2 (s5p4418_nanopi2_defconfig). Thanks a lot! --- Cc: Ryan Chen Cc

Re: [PATCH 50/81] phy: Remove and add needed includes

2024-05-09 Thread Stefan Bosch
On 02.05.24 03:31, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini Tested-by: Stefan Bosch Looks ok, tested on FriendlyElec-Board NanoPC-T2 (s5p4418_nanopi2_defconfig). Thanks a lot! --- Cc: Jagan Teki

Re: [PATCH 33/81] gpio: Remove and add needed includes

2024-05-09 Thread Stefan Bosch
On 02.05.24 03:30, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini Tested-by: Stefan Bosch Looks ok, tested on FriendlyElec-Board NanoPC-T2 (s5p4418_nanopi2_defconfig). Thanks a lot! --- Cc: Tom Rini Cc

Re: [PATCH 19/81] clk: Remove and add needed includes

2024-05-09 Thread Stefan Bosch
On 02.05.24 03:30, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini Tested-by: Stefan Bosch Looks ok, tested on FriendlyElec-Board NanoPC-T2 (s5p4418_nanopi2_defconfig). Thanks a lot! --- Cc: Lukasz

Re: [PATCH 74/81] video: Remove and add needed includes

2024-05-09 Thread Stefan Bosch
On 02.05.24 03:31, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini Tested-by: Stefan Bosch Looks ok, tested on FriendlyElec-Board NanoPC-T2 (s5p4418_nanopi2_defconfig). Thanks a lot! --- Cc: Anatolij

Re: [PATCH 53/81] pwm: Remove and add needed includes

2024-05-09 Thread Stefan Bosch
On 02.05.24 03:31, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini Tested-by: Stefan Bosch Looks ok, tested on FriendlyElec-Board NanoPC-T2 (s5p4418_nanopi2_defconfig). Thanks a lot! --- Cc: Tom Rini Cc

Re: [PATCH 35/81] i2c: Remove and add needed includes

2024-05-09 Thread Stefan Bosch
On 02.05.24 03:30, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini Tested-by: Stefan Bosch Looks ok, tested on FriendlyElec-Board NanoPC-T2 (s5p4418_nanopi2_defconfig). Thanks a lot! --- Cc: Heiko

Re: [PATCH 04/81] arm: nexell: Add missing

2024-05-09 Thread Stefan Bosch
On 02.05.24 03:30, Tom Rini wrote: This file has many "Linux" style types in it, add Signed-off-by: Tom Rini Reviewed-by: Stefan Bosch Thanks for your awesome work! --- Cc: Stefan Bosch --- arch/arm/mach-nexell/include/mach/mipi_display.h | 2 ++ 1 file changed, 2

Re: [PATCH 062/149] board: friendlyarm: Remove and add needed includes

2024-05-08 Thread Stefan Bosch
On 01.05.24 04:41, Tom Rini wrote: Remove from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini Reviewed-by: Stefan Bosch Tested-by: Stefan Bosch Looks good, tested on FriendlyElec-Board NanoPC-T2. Thanks a lot! --- Cc: Stefan

Re: [PATCH 17/33] arm: nexell: Remove and add needed includes

2024-05-08 Thread Stefan Bosch
On 30.04.24 15:35, Tom Rini wrote: Remove from all mach-nexell files and when needed add missing include files directly. Signed-off-by: Tom Rini Reviewed-by: Stefan Bosch Tested-by: Stefan Bosch Looks good, tested on FriendlyElec-Board NanoPC-T2. Thanks a lot! --- Cc: Stefan Bosch

Re: [PATCH u-boot-mvebu 10/10] arm: mvebu: turris_omnia: Support old DDR3 training, selectable via env var

2024-05-06 Thread Stefan Roese
/ddr3_debug.c:776:12: warning: 'ddr3_tip_access_atr' declared 'static' but never defined [-Wunused-function] 776 | static int ddr3_tip_access_atr(u32 dev_num, u32 flag_id, u32 value, u32 **ptr); |^~~ Please take a look. Thanks, Stefan diff --git a/arch/arm

Re: [PATCH 010/149] board: Marvell: Remove and add needed includes

2024-05-02 Thread Stefan Roese
On 5/1/24 04:40, Tom Rini wrote: Remove from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Stefan Roese Cc: Chris Packham Cc: Tony Dinh Cc: Jason Cooper Cc: Siddarth Gore Cc: Aaron Williams --- arch/arm/mach-kirkwood

[PATCH v1] arm: dts: verdin-imx8mm/imx8mp: use gpio-hog for sleep moci

2024-04-17 Thread Stefan Eichenberger
From: Stefan Eichenberger In Linux, we allow sleep moci to be turned off when the carrier board supports it and the system is in suspend. In U-Boot, however, we want the sleep moci to be always on. So we use a gpio hog and disable the regulator. This change is necessary because we switched

[PATCH v1] arm: dts: verdin-am62: use gpio-hog for sleep moci

2024-04-17 Thread Stefan Eichenberger
From: Stefan Eichenberger In Linux, we allow sleep moci to be turned off when the carrier board supports it and the system is in suspend. In U-Boot, however, we want the sleep moci to be always on. So we use a gpio hog and disable the regulator. This change is necessary because we switched

Re: [PATCH] arm: dts: kirkwood: Remove DTS files for Kirkwood boards

2024-04-04 Thread Stefan Roese
Signed-off-by: Tony Dinh Applied to u-boot-marvell/master Thanks, Stefan --- arch/arm/dts/Makefile | 28 +- arch/arm/dts/kirkwood-6192.dtsi | 88 -- arch/arm/dts/kirkwood-6281.dtsi | 90 -- arch/arm/dts/kirkwood-6282.dtsi

Please pull u-boot-marvell/master

2024-04-04 Thread Stefan Roese
) Here the Azure build, without any issues: https://dev.azure.com/sr0718/u-boot/_build/results?buildId=343=results Thanks, Stefan The following changes since commit cdfcc37428e06f4730ab9a17cc084eeb7676ea1a: Merge tag 'u-boot-dfu-next-20240402' of https://source.denx.de

Re: [PATCH v3] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-04-04 Thread Stefan Roese
l NSA310S has an extensive overhaul in bindings and styles in upstream DTS version. Tested-by: Michael Walle # on lschv2 Acked-by: Sumit Garg Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh Applied to u-boot-marvell/master Thanks, Stefan --- Changes in v3: - Collect Reviewed/Test

Re: [PATCH u-boot-mvebu v4 00/18] Turris Omnia - New board revision support

2024-04-04 Thread Stefan Roese
create mode 100644 drivers/misc/turris_omnia_mcu.c create mode 100644 include/turris-omnia-mcu-interface.h Applied to u-boot-marvell/master Thanks, Stefan

Re: [PATCH u-boot-mvebu v3 00/18] Turris Omnia - New board revision support

2024-04-04 Thread Stefan Roese
Hi Marek, On 3/27/24 17:23, Marek Behún wrote: Hi Stefan, this is v3 of series adding support for new board revision of Turris Omnia. Changes since v2: - patch 2: updated MCU command interface header - patch 6: fixed bug setting \0 as end of string in src array instead of dst

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Stefan Wahren
Hi Laurent, Am 02.04.24 um 22:08 schrieb Laurent Pinchart: Hello, ... Stefan, I'm quite unfamiliar with the Raspberry Pi upstreaming process (despite having sent patches for ages :-)), do I understand correctly that this patch will go through your tree, or do I need to work with someone else

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-04-02 Thread Stefan Wahren
Am 02.04.24 um 10:58 schrieb Ivan T. Ivanov: Hi, On 2024-03-28 01:37, Laurent Pinchart wrote: On Wed, Mar 27, 2024 at 07:49:38AM +0100, Stefan Wahren wrote: Hi, [add Peter and Ivan] Am 26.03.24 um 20:58 schrieb Laurent Pinchart: > Hello, > > This small series includes a few drive

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

2024-03-28 Thread Stefan Roese
On 3/28/24 12:21, Marek Behún wrote: On Thu, 28 Mar 2024 11:04:45 +0100 Stefan Roese wrote: +static int mvebu_sysreset_request(struct udevice *dev, enum sysreset_t type) +{ + struct regmap *regmap = syscon_get_regmap(dev->parent); + uint bit; + + if (type != SYSRESET_C

Re: [PATCH u-boot-mvebu v3 05/18] arm: mvebu: turris_omnia: Implement getting board information from MCU

2024-03-28 Thread Stefan Roese
On 3/28/24 12:17, Marek Behún wrote: On Thu, 28 Mar 2024 10:56:01 +0100 Stefan Roese wrote: On 3/27/24 17:23, Marek Behún wrote: Implement reading board serial number, first MAC address and board version from MCU. MCU supports board information if the FEAT_BOARD_INFO feature bit is set

Re: [PATCH u-boot-mvebu v3 18/18] arm: mvebu: turris_omnia: Enable rng command in defconfig

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Now that Turris Omnia has a rng driver provided in the MCU driver, enable the rng command in defconfig. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- configs/turris_omnia_defconfig | 1 + 1 file changed, 1 insertion

Re: [PATCH u-boot-mvebu v3 17/18] misc: turris_omnia_mcu: Add support for rng provided by MCU

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Add support for true random number generator provided by the MCU on Turris Omnia. The MCU firmware supports TRNG if the FEAT_TRNG bit is set in features. In that case we bind the rng driver. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks

Re: [PATCH u-boot-mvebu v3 16/18] cmd: rng: Print "Abort" on -EINTR

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: In the rng command, print Abort instead of Reading RNG failed if the error number is -EINTR, which can happen if the user pressed CTRL-C. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- cmd/rng.c | 7 --- 1 file

Re: [PATCH u-boot-mvebu v3 15/18] arm: mvebu: turris_omnia: Enable poweroff command via sysreset in defconfig

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Enable support for the poweroff command via sysreset for Turris Omnia. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- configs/turris_omnia_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs

Re: [PATCH u-boot-mvebu v3 14/18] gpio: turris_omnia_mcu: Add support for system power off via sysreset

2024-03-28 Thread Stefan Roese
UCLASS_MISC. The sysreset and gpio device are bound as child devices of the MCU device. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- configs/turris_omnia_defconfig| 1 + drivers/gpio/Kconfig | 7 - drivers/gpio/Makefile

Re: [PATCH u-boot-mvebu v3 13/18] gpio: turris_omnia_mcu: Update firmware features reading

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Update firmware features reading to try reading 32 bits of features and fallback to reading 16 bits. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/gpio/turris_omnia_mcu.c | 32 ++-- 1

Re: [PATCH u-boot-mvebu v3 12/18] gpio: turris_omnia_mcu: Use byteorder conversion functions

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Use byteorder conversion function instead of manually assembling data from/to MCU. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- drivers/gpio/turris_omnia_mcu.c | 80 +++-- 1 file changed, 46

Re: [PATCH u-boot-mvebu v3 11/18] arm: mvebu: system-controller: Add support for SYSRESET

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Add driver model support for sysreset via mvebu system controller. This is currently only available for U-Boot proper. Signed-off-by: Marek Behún Only a minor comment below. Other than this: Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm

Re: [PATCH u-boot-mvebu v3 10/18] arm: mvebu: system-controller: Select mvebu-reset if DM_RESET && PCI_MVEBU

2024-03-28 Thread Stefan Roese
-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig index 62a2bc5958..623432a60e 100644 --- a/arch/arm/mach-mvebu/Kconfig +++ b/arch/arm/mach-mvebu/Kconfig

Re: [PATCH u-boot-mvebu v3 09/18] arm: mvebu: system-controller: Rework to use UCLASS_SYSCON

2024-03-28 Thread Stefan Roese
-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Kconfig | 11 arch/arm/mach-mvebu/Makefile| 2 +- arch/arm/mach-mvebu/system-controller.c | 76 ++--- 3 files changed, 54 insertions(+), 35 deletions(-) diff --git a/arch/arm/mach-mvebu/Kconfig

Re: [PATCH u-boot-mvebu v3 08/18] arm: mvebu: spl: Do not build mvebu-reset in SPL

2024-03-28 Thread Stefan Roese
BU depends on DM_RESET. But the driver should not be built for SPL. Indeed the PCI_MVEBU driver is not supported in SPL now, and so the mvebu-reset driver is not needed. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- arch/arm/mach-mvebu/Makefile | 3 ++- 1 file

Re: [PATCH u-boot-mvebu v3 07/18] arm: mvebu: turris_omnia: Disable Atmel SHA node if not present

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: If the FEAT_CRYPTO feature bit is present in MCU features, the board crypto is implemented by MCU and the Atmel SHA chip is not present. Disable Atmel SHA device-tree node in that case. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH u-boot-mvebu v3 06/18] arm: mvebu: turris_omnia: Print board ECDSA public key if available

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: If MCU supports the FEAT_CRYPTO feature, read board ECDSA public key from MCU and print it. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_omnia/turris_omnia.c | 25 +++- 1 file

Re: [PATCH u-boot-mvebu v3 05/18] arm: mvebu: turris_omnia: Implement getting board information from MCU

2024-03-28 Thread Stefan Roese
. Signed-off-by: Marek Behún Minor comment below. Other than this: Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_atsha_otp.c | 27 +-- board/CZ.NIC/turris_omnia/Makefile | 2 +- board/CZ.NIC/turris_omnia/turris_omnia.c | 94

Re: [PATCH u-boot-mvebu v3 04/18] arm: mvebu: turris_omnia: Update MCU status and features reading

2024-03-28 Thread Stefan Roese
transaction fails. Handle both cases. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_omnia/turris_omnia.c | 100 +++ 1 file changed, 68 insertions(+), 32 deletions(-) diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b

Re: [PATCH u-boot-mvebu v3 03/18] arm: mvebu: turris_{omnia, mox}: Don't print model two times

2024-03-28 Thread Stefan Roese
checkboard() also does. Remove the second print. Fixes: 8cd4bf7dc9ba ("turris: Use checkboard() instead of show_board_info()") Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_mox/turris_mox.c | 5 + board/CZ.NIC/turris_omni

Re: [PATCH u-boot-mvebu v3 02/18] arm: mvebu: turris_omnia: Add header containing MCU command interface and use it

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: Add header containing all MCU command definitions and use it in board code and in MCU driver. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan --- board/CZ.NIC/turris_omnia/turris_omnia.c | 81 +++- drivers/gpio

Re: [PATCH u-boot-mvebu v3 01/18] arm: mvebu: turris_omnia: Enable LTO by default on Turris Omnia

2024-03-28 Thread Stefan Roese
On 3/27/24 17:23, Marek Behún wrote: U-Boot builds for Turris Omnia are approaching the limit of 0xf bytes, which is the size of the U-Boot partition on Omnia. Enable LTO to get more size optimized binaries. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v2] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-28 Thread Stefan Roese
, and including *-u-boot.dtsi files from arch/arm/dts/ directory. Background: Hi Stefan, Hi Michael, I did a survey and we currently have 28 Kirkwood boards. Using some commands and filters, here are the finding. git grep -li arch_kirkwood configs | xargs grep DEVICE_TREE | cut -d '"' -f2 | xargs -

Re: [PATCH v2 0/3] dt-bindings: arm: bcm: raspberrypi,bcm2835-firmware: Drive-by fixes

2024-03-27 Thread Stefan Wahren
Hi, [add Peter and Ivan] Am 26.03.24 um 20:58 schrieb Laurent Pinchart: Hello, This small series includes a few drive-by fixes for DT validation errors. The first patch has been posted previously in v1 ([1], and now addresses a small review comment. I think it's good to go. The next two

Please pull u-boot-marvell/master

2024-03-05 Thread Stefan Roese
config fragment for spi booting et al (Josua) - rng: Add Turris Mox rTWM RNG driver (Max) Here the Azure build, without any issues: https://dev.azure.com/sr0718/u-boot/_build/results?buildId=341=results Thanks, Stefan The following

Re: [PATCH v5] rng: Add Turris Mox rTWM RNG driver

2024-03-05 Thread Stefan Roese
On 2/15/24 17:57, Max Resch wrote: A RNG driver for Armada 3720 boards running the Turris Mox rWTM firmware from CZ.NIC in the secure processor. Signed-off-by: Max Resch Applied to u-boot-marvell/master Thanks, Stefan --- Changes in v5: - check return code turris_rwtm_rng_fill_entropy

Re: [PATCH v2 3/3] board: helios-4: add config fragment for spi booting

2024-03-05 Thread Stefan Roese
can be applied on top of helios4_defconfig by make: make helios4_defconfig spiboot.config Signed-off-by: Josua Mayer Applied to u-boot-marvell/master Thanks, Stefan --- board/kobol/helios4/spiboot.config | 4 1 file changed, 4 insertions(+) diff --git a/board/kobol/helios4

Re: [PATCH v2 2/3] arm: mvebu: helios4_defconfig: enable setexpr command

2024-03-05 Thread Stefan Roese
On 2/2/24 16:13, Josua Mayer wrote: Update the helios4 defconfig to enable the 'setexpr' command, which is a default and useful for various complex boot-scripts. Signed-off-by: Josua Mayer Applied to u-boot-marvell/master Thanks, Stefan --- configs/helios4_defconfig | 1 - 1 file

Re: [PATCH v2 1/3] arm: dts: armada-38x-solidrun-microsom: configure i2c0 bus

2024-03-05 Thread Stefan Roese
, pinctrl and clock speed. Copy these settings from mainline. This fixes accessing i2c bus from u-boot commandline. Signed-off-by: Josua Mayer Applied to u-boot-marvell/master Thanks, Stefan --- arch/arm/dts/armada-38x-solidrun-microsom.dtsi | 5 + 1 file changed, 5 insertions

Re: [PATCH u-boot-marvell] arm: mvebu: turris_omnia: Enable networking via ethernet switch

2024-03-05 Thread Stefan Roese
On 12/19/23 10:55, Marek Behún wrote: From: Marek Mojík The Turris Omnia contains the Marvell 88E6176 ethernet switch. Add config options and device tree to enable the support. Signed-off-by: Marek Mojík Signed-off-by: Marek Behún Applied to u-boot-marvell/master Thanks, Stefan

Re: [PATCH v2] net: mv88e6xxx: fix missing SMI address initialization

2024-03-05 Thread Stefan Roese
address from device tree. Signed-off-by: Marek Mojík Applied to u-boot-marvell/master Thanks, Stefan --- drivers/net/mv88e6xxx.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/mv88e6xxx.c b/drivers/net/mv88e6xxx.c index c073f81e72..8fbbc1cacc 100644 --- a/drivers/net

Re: [PATCH v2] net: mv88e6xxx: fix missing SMI address initialization

2024-03-05 Thread Stefan Roese
Hi Marek, On 3/4/24 15:48, Marek Behún wrote: Hi Stefan, On Wed, 14 Feb 2024 08:50:16 +0100 Stefan Roese wrote: Hi Ramon, On 1/9/24 10:37, Stefan Roese wrote: On 12/18/23 17:09, Marek Behún wrote: On Wed, 6 Dec 2023 15:35:56 +0100 Marek Mojík wrote: The mv88e6xxx driver does

Re: Booting RPi5B with latest git

2024-02-17 Thread Stefan Wahren
Hi John, Am 17.02.24 um 17:33 schrieb John: I am running Arch ARM on a RPi4B and also on a RPi5B. My RPi4B can boot the vanilla kernel package (linux-aarch64) with the latest uboot-raspberrypi (2024.04-rc2) just fine. btw the mainline kernel doesn't have any RPi 5 support yet. So you will

Re: [PATCH v5] rng: Add Turris Mox rTWM RNG driver

2024-02-16 Thread Stefan Roese
rwtm_rng_remove, + .priv_auto = sizeof(struct turris_rwtm_rng_priv), +}; Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v2] net: mv88e6xxx: fix missing SMI address initialization

2024-02-13 Thread Stefan Roese
Hi Ramon, On 1/9/24 10:37, Stefan Roese wrote: On 12/18/23 17:09, Marek Behún wrote: On Wed, 6 Dec 2023 15:35:56 +0100 Marek Mojík wrote: The mv88e6xxx driver does not currently initialize the smi_addr field, but instead keeps the default zero value. This leads to driver being unusable

Re: [PATCH v4] rng: Add Turris Mox rTWM RNG driver

2024-02-13 Thread Stefan Roese
e" }, + {}, +}; + +U_BOOT_DRIVER(turris_rwtm_rng) = { + .name = "turris-rwtm-rng", + .id = UCLASS_RNG, + .of_match = turris_rwtm_rng_match, + .ops= _rwtm_rng_ops, + .probe = turris_rwtm_rng_probe, + .remove = turris_rwtm_rng_remove, + .priv_auto = sizeof(struct turris_rwtm_rng_priv), +}; Thanks, Stefan

Re: [PATCH v3] rng: Add Turris Mox rTWM RNG driver

2024-02-07 Thread Stefan Roese
); + phys_addr_t phys; You've now just sent the update v2->v3. As v2 is not applied yet this is not the way to do it. Please squash this patch into the v2 one a send this as v3 or even better v4 now. Thanks, Stefan size_t size; int ret; - p = ((struct turris_rwtm_rng_p

Please pull u-boot-watchdog/master

2024-02-01 Thread Stefan Roese
://dev.azure.com/sr0718/u-boot/_build/results?buildId=339=results Thanks, Stefan The following changes since commit b6d8969bcb94321dfed1399f2eaa8768ba42caaa: Merge tag 'u-boot-at91-2024.04-a' of https://source.denx.de/u-boot/custodians/u-boot-at91 (2024-01-31 10:44:33 -0500) are available

Re: [PATCH V4 2/2] configs: andes: add watchdog support fot andes ae350

2024-02-01 Thread Stefan Roese
On 1/24/24 07:21, Randolph wrote: It adds the ATCWDT200 support for Andes AE350 platform. It also enables wdt command support. Signed-off-by: CL Wang Signed-off-by: Randolph Reviewed-by: Leo Yu-Chi Liang Applied to u-boot-watchdog/master Thanks, Stefan --- configs/ae350_rv32_defconfig

Re: [PATCH V4 1/2] drivers: watchdog: add andes atcwdt200 support

2024-02-01 Thread Stefan Roese
On 1/24/24 07:21, Randolph wrote: This patch adds an implementation of the Andes watchdog ATCWDT200 driver. Signed-off-by: CL Wang Signed-off-by: Randolph Reviewed-by: Leo Yu-Chi Liang Applied to u-boot-watchdog/master Thanks, Stefan --- drivers/watchdog/Kconfig | 6

  1   2   3   4   5   6   7   8   9   10   >