Re: [U-Boot] [PATCH] mx6: gpio: read data register if direction is out

2014-06-24 Thread Stefano Babic
you are describing looks an issue in your pinmux configuration because you do not set the SION bit, as requested to read back the value of the GPIO from the Pad Register. I assume that if you read the value from the DR register, you do not read the current value of the p

Re: [U-Boot] [PATCH 3/3] mx6sl: Add initial support for mx6slevk board

2013-04-09 Thread Stefano Babic
registers and > check what clocks can be turned off. > > This may take some time though as it needs proper testing. > > I suggest that we keep the current clock settings as is, so that the > board support can reach U-boot, then later I can submit a patch for > turning off the unneed

Re: [U-Boot] zmodem ?

2013-04-09 Thread Stefano Babic
s supported. > > Is my understanding correct? Yes, it is Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Re: [U-Boot] [PATCH v2] spi: mxc_spi: Set master mode for all channels

2013-04-09 Thread Stefano Babic
g_read(®s->ctrl); > + /* > + * Reset SPI and set all CSs to master mode, if toggling > + * between slave and master mode we might see a glitch > + * on the clock line > + */ > + reg_ctrl = MXC_CSPICTRL_MODE_MASK; > + reg_write(®s->ctrl, reg_ct

Re: [U-Boot] [PATCH] mx31pdk: Remove watchdog support

2013-04-09 Thread Stefano Babic
Benoit's patchset will flow into the release - then this one should also be merged. Acked-by: Stefano Babic Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165

Re: [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers

2013-04-09 Thread Stefano Babic
TL = IOMUXC_BASE_ADDR + 0x7AC, /* input select */ > + IOMUXSW_PAD_END = IOMUXC_BASE_ADDR + 0x7A4, /* last Pad control */ > + IOMUXSW_INPUT_CTL = IOMUXC_BASE_ADDR + 0x7A8, /* input select */ > IOMUXSW_INPUT_END = IOMUXC_BASE_ADDR + 0x9F4, /* last input select */ > };

Re: [U-Boot] [PATCH] mx6qsabre{sd, auto}: Fix environment as 'mmc rescan' takes no arguments

2013-04-13 Thread Stefano Babic
quot;if mmc rescan; then " \ > "if run loadbootscript; then " \ > "run bootscript; " \ > "else " \ > Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- =

Re: [U-Boot] [PATCH v2] spi: mxc_spi: Set master mode for all channels

2013-04-13 Thread Stefano Babic
On 10/04/2013 14:01, Fabio Estevam wrote: > Hi Stefano, > > On Wed, Apr 10, 2013 at 3:10 AM, Stefano Babic wrote: > >> I am afraid you are breaking MX3x / MX25 because you add >> MXC_CSPICTRL_MODE_MASK only to MX5 / MX6. > > It will not break other platforms becau

Re: [U-Boot] [PATCH 0/5] vybrid: Add vybrid CPU and vf600 tower board support

2013-04-13 Thread Stefano Babic
his SOC ? I understand in your patchset that ESDHC is reused, I think also FEC, I wonder that UART is not. - Which image is produced ? I do not understand why you need a new type if you reuse the same rule (mkimage for imx

Re: [U-Boot] [PATCH 3/5] vybrid: add uart driver support

2013-04-13 Thread Stefano Babic
getc(void) > +{ > + while (!(in_8(UART_CONSOLE + US1) & US1_RDRF)) > + WATCHDOG_RESET(); > + Generally : do not use BASE + offset as here. Use C structures, instead. We have already ARM accessors (in8 is defined for powerpc). Use functions in io.h This driver is very s

Re: [U-Boot] [PATCH 4/5] vybrid: add eSDHC driver support

2013-04-13 Thread Stefano Babic
040); > #endif I am also not sure if we need CONFIG_VYBRID (but then it should be ARCH_VYBRID) or we can let flow these processors into the i.MX family. Best regards, Stefano Babic -- = DENX Software Engineering GmbH,

Re: [U-Boot] [PATCH 2/5] vybrid: add Freescale vybrid vf600 tower board support

2013-04-13 Thread Stefano Babic
define CONFIG_SYS_RX_ETH_BUFFER 8 > +#define CONFIG_SYS_FAULT_ECHO_LINK_DOWN > + > +#define CONFIG_SYS_FEC0_PINMUX 0 > +#define CONFIG_SYS_FEC1_PINMUX 0 > +#define CONFIG_SYS_FEC0_IOBASE MACNET0_BASE_ADDR &

Re: [U-Boot] [PATCH] arm: imx: Change iomux functions to void type

2013-04-13 Thread Stefano Babic
3_setup_multiple_pads(iomux_v3_cfg_t const *pad_list, > +void imx_iomux_v3_setup_pad(iomux_v3_cfg_t pad); > +void imx_iomux_v3_setup_multiple_pads(iomux_v3_cfg_t const *pad_list, >unsigned count); > > #endif /* __MACH_IOMUX_V3_H__*/ > Rig

[U-Boot] [PULL] : Please pull u-boot-imx

2013-04-14 Thread Stefano Babic
Hallo Albert, I have a couple of fixes for the release. Please pull from u-boot-imx, thanks ! The following changes since commit d36b39bf0d1dbe4ef03f7fc1f20b2e52eb90acf5: spi: mxc_spi: Fix ECSPI reset handling (2013-04-04 10:23:09 +0200) are available in the git repository at: git://www.de

Re: [U-Boot] [Patch] fsl_esdhc: Fix DMA transfer completion waiting loop

2013-04-14 Thread Stefano Babic
000) > > I can't say anything to the content of the patches ;) > > But are this patch and the patch from Eric > > http://patchwork.ozlabs.org/patch/233595/ > > fine and should be applied together, now? I see the same. I apply both on u-boot-imx and send an updat

[U-Boot] [PULL] : Please pull u-boot-imx

2013-04-14 Thread Stefano Babic
Sorry Albert, there are two more fixes that I have not merged before. Please pull from u-boot-imx again, thanks. The following changes since commit 0f1411bc8dade4472ca802f46f75714e67301bb0: spi: mxc_spi: Set master mode for all channels (2013-04-13 17:46:42 +0200) are available in the git rep

Re: [U-Boot] [PATCH v3] imx: Add titanium board support (i.MX6 based)

2013-04-16 Thread Stefano Babic
; + printf("FEC MXC: %s:failed\n", __func__); > + > + return 0; > +} > + > +int board_early_init_f(void) > +{ > + setup_iomux_uart(); > + > + return 0; > +} > + > +/* > + * Do not overwrite the console > + * Use always serial for

Re: [U-Boot] [PATCH v2] mx35 iomux: correct offsets of IOMUX registers

2013-04-16 Thread Stefano Babic
f-by: Philip Paeps > --- Applied to u-boot-imx, -next branch, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 G

Re: [U-Boot] [PATCH] mx28evk: add trimffs to nand command

2013-04-16 Thread Stefano Babic
On 08/04/2013 20:59, Eric Bénard wrote: > this is usefull when writing an UBI image which contains > and UBIFS volume (check README.nand and UBI FAQ for more details) > > Signed-off-by: Eric Bénard > --- Applied to u-boot-imx, -next branch, thanks. Best regards

Re: [U-Boot] [PATCH] arm: imx: Change iomux functions to void type

2013-04-16 Thread Stefano Babic
On 11/04/2013 11:06, Stefan Roese wrote: > They never return anything also than 0, so lets change the function > to void instead. > > Signed-off-by: Stefan Roese > --- Applied to u-boot-imx, -next branch, thanks. Best regards

Re: [U-Boot] [PATCH] ARM: mx6: define CONFIG_ARM_ERRATA_742230

2013-04-16 Thread Stefano Babic
230 > #define CONFIG_ARM_ERRATA_743622 > #define CONFIG_ARM_ERRATA_751472 > This is a fix, but the release is coming (end of the week). What do you think if I push this to -next ? Best regards, Stefano -- = DENX Softwa

Re: [U-Boot] [PATCH] ARM: mx6: define CONFIG_ARM_ERRATA_742230

2013-04-17 Thread Stefano Babic
ing the workaround for this errata. So for safety, let's > define CONFIG_ARM_ERRATA_742230 to enable the workaround on i.MX6. > > Signed-off-by: Shawn Guo > --- Applied to u-boot-imx, -next branch, thanks. Best regards, Stefano Babic -- ===

Re: [U-Boot] [PATCH v4] imx: Add titanium board support (i.MX6 based)

2013-04-17 Thread Stefano Babic
On 16/04/2013 14:55, Stefan Roese wrote: > Titanium is a i.MX6 based board from ProjectionDesign / Barco. This > patch adds support for this board with the newly introduced NAND > support for i.MX6. > > Signed-off-by: Stefan Roese > Cc: Stefano Babic > Cc: Fabio Estevam &g

Re: [U-Boot] [PATCH 3/3] mx6sl: Add initial support for mx6slevk board

2013-04-17 Thread Stefano Babic
f the unneeded clocks. Ok, let's do in this way - I agree that U-boot should only turn on the clocks that it requires and do not touch the rest. But let's start pushing this into u-boot-imx and then we can trim this setup. Best regards, Stefano -- ==

Re: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL

2013-04-19 Thread Stefano Babic
id such #ifdef's? Here, we could for example refer > to the board name (CONFIG_SYS_BOARD if you like the name, or some > custom defined CONFIG_BOARD_NAME like other boards do). And who does set CONFIG_MX6Q ? You drop it, but I do not see who sets it. Best regards, Stefano Babic --

Re: [U-Boot] [PATCH] imx: Add support for the SabreSD shipped with i.MX6DL

2013-04-19 Thread Stefano Babic
On 19/04/2013 10:27, Eric Bénard wrote: > Hi Stefano, > Hi Eric, >>> Can we please avoid such #ifdef's? Here, we could for example refer >>> to the board name (CONFIG_SYS_BOARD if you like the name, or some >>> custom defined CONFIG_BOARD_NAME like ot

Re: [U-Boot] [PATCH 3/3] mx6sl: Add initial support for mx6slevk board

2013-04-22 Thread Stefano Babic
On 21/04/2013 19:00, Fabio Estevam wrote: > Hi Stefano, > > On Wed, Apr 17, 2013 at 5:48 AM, Stefano Babic wrote: > >> Ok, let's do in this way - I agree that U-boot should only turn on the >> clocks that it requires and do not touch the rest. But let's start &

Re: [U-Boot] [PATCH] imx: Add titanium board support (i.MX6 based)

2013-04-22 Thread Stefano Babic
On 10/04/2013 09:17, Stefan Roese wrote: > Titanium is a i.MX6 based board from ProjectionDesign / Barco. This > patch adds support for this board with the newly introduced NAND > support for i.MX6. > > Signed-off-by: Stefan Roese > --- Applied to u-boot-imx, thanks. Bes

Re: [U-Boot] [PATCH] imx: Add titanium board support (i.MX6 based)

2013-04-22 Thread Stefano Babic
On 22/04/2013 10:12, Stefan Roese wrote: > On 22.04.2013 10:07, Stefano Babic wrote: >> On 10/04/2013 09:17, Stefan Roese wrote: >>> Titanium is a i.MX6 based board from ProjectionDesign / Barco. This >>> patch adds support for this board with the newly introduced

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-24 Thread Stefano Babic
back that probably not all boards need u-boot.imx (a board without SD for example). At least we need an update of the README, but I think it is not bad to have a new entry in boards.cfg. Apart of that and not related to this patch, if we in future use SPL also for booting from SD, we can get a si

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-25 Thread Stefano Babic
D. > > Ok, I fail to grasp what is wanted from me. Shall I rework the patch somehow? > How? Do we want m53evk_sd and m53evk_nand targets ? At least add documentation in the README. It is only your choice if you will add two different targets to boards.cfg Best regards, Stefano -- ==

Re: [U-Boot] [PATCH v4 01/10] imx: Homogenize and fix fuse register definitions

2013-04-25 Thread Stefano Babic
udeau > --- Very nice work, Benoît ! Acked-by: Stefano Babic Best regards, Stefano Babic > Changes in v4: > - Convert spaces to tabs. > > Changes in v3: > - Rebase against latest u-boot-imx/master. > - Fix the number of banks on i.MX6. > - Rename iim to ocotp on i.

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-25 Thread Stefano Babic
ide the storage, and only to be as much flexible as possible, each storage has defined its own offset. However, Freescale uses the same offset (0x400) for most storages (NAND, SD..) and another one for NOR or OneNAND (0x1000). Maybe it is easier to have only

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-25 Thread Stefano Babic
On 25/04/2013 10:38, Stefan Roese wrote: > Hi Stefano, > > On 25.04.2013 09:31, Stefano Babic wrote: >> On 24/04/2013 12:59, Benoît Thébaudeau wrote: >> >>>> Apart of that and not related to this patch, if we in future use SPL >>>> also for booting

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-25 Thread Stefano Babic
n other mediums (e.g. SPI NOR, > NAND) this padded image would be easier (less error prone) to handle. If a board can boot only from a single storage, yes. Or at least from storages with have the same offset. For example, if we have a board with SPI-NOR and NAND, the offsets are different am

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-25 Thread Stefano Babic
gt; NAND) this padded image would be easier (less error prone) to handle. > > For NAND, we already have u-boot-with-nand-spl.imx. Is it padded at the beginnig ? I have thought the pad is between SPL and u-boot based on CONFIG_SPL_PAD_TO, but we need to flash always at the right offset. Rega

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-25 Thread Stefano Babic
u-boot.bin, > no >padding to compensate for imx offset, any non-NAND SPL + u-boot usage, > - u-boot-with-nand-spl.imx: (FCB (filling normal imx offset) + SPL) padded to >CONFIG_SPL_PAD_TO + uImaged-u-boot.bin, NAND SPL + u-boot usage. Right, I see

Re: [U-Boot] [PATCH V2 6/6] arm: mx5: Add support for DENX M53EVK

2013-04-25 Thread Stefano Babic
On 25/04/2013 15:36, Marek Vasut wrote: > Dear Stefano Babic, > Hi Marek, >> At least add documentation in the README. It is only your choice if you >> will add two different targets to boards.cfg > > I'd prefer not to do that. We're currently booting f

Re: [U-Boot] [PATCH] arm: imx: Codingstyle enhancement of include/asm/arch-mx6/crm_regs.h

2013-04-25 Thread Stefano Babic
On 11/04/2013 11:39, Stefan Roese wrote: > Add spaces before and after "<<". > > Please note that I intentionally didn't wrap the > 80 lines for > the sake of better readability. > > Signed-off-by: Stefan Roese > --- Applied to u-b

Re: [U-Boot] [PATCH] mx35 iomux: correct input select register index

2013-04-25 Thread Stefano Babic
imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-81

Re: [U-Boot] [PATCH] imx: mx6q_4x_mt41j128.cfg: Setup CCM_CCOSR register

2013-04-25 Thread Stefano Babic
n > arch/arm/mach-imx/mach-imx6q.c > from the mainline kernel. > > mx6q_4x_mt41j128.cfg is also used by mx6qsabresd, and it is safe to use it for > this board as well. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot

Re: [U-Boot] [PATCH] nitrogen6x: Setup CCM_CCOSR register

2013-04-25 Thread Stefano Babic
t; > Also, according to Eric Nelson: "enabling the clock will > remove squeal after an ungraceful reboot (watchdog) if hooked up to speakers." > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, -nex

Re: [U-Boot] [PATCH v3 1/7] mx6qsabre{sd, auto}: Add update_sd_firmware support

2013-04-25 Thread Stefano Babic
On 19/04/2013 15:41, Otavio Salvador wrote: > This allow for easy update of firmware in the SD card from a running > U-Boot. > > Signed-off-by: Otavio Salvador > --- Applied to u-boot-imx, -next branch, thanks. Best regards

Re: [U-Boot] [PATCH v3 2/7] mx6qsabresd: Return status when initializing MMC

2013-04-25 Thread Stefano Babic
On 19/04/2013 15:41, Otavio Salvador wrote: > Signed-off-by: Otavio Salvador > --- Applied to u-boot-imx, -next branch, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk &a

Re: [U-Boot] [PATCH v3 3/7] wandboard: Use env storage info for mmcdev/mmcpart

2013-04-25 Thread Stefano Babic
On 19/04/2013 15:41, Otavio Salvador wrote: > This makes environment and mmcdev/mmcpart in sync with SYS_MMC_ENV_DEV > and SYS_MMC_ENV_PART settings. > > Signed-off-by: Otavio Salvador > --- Applied to u-boot-imx, -next branch, thanks. Best regards

Re: [U-Boot] [PATCH v3 4/7] wandboard: Add update_sd_firmware support

2013-04-25 Thread Stefano Babic
+++ > 1 file changed, 16 insertions(+) > Applied to u-boot-imx branch, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich

Re: [U-Boot] [PATCH v3 5/7] wandboard: Add card detection for SOM MicroSD card

2013-04-25 Thread Stefano Babic
applied to u-boot-imx, master branch. Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-8219

Re: [U-Boot] [PATCH v3 6/7] wandboard: Add support for Carrier Board MicroSD card

2013-04-25 Thread Stefano Babic
imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-81

Re: [U-Boot] [PATCH v3 7/7] wandboard: Add boot selection support

2013-04-25 Thread Stefano Babic
to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 F

Re: [U-Boot] [PATCH v5 1/2] mx51evk: Update environment in order to allow booting a dt kernel

2013-04-25 Thread Stefano Babic
evam > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone

Re: [U-Boot] [PATCH v5 2/2] mx51evk: Do not force the rootfs type

2013-04-25 Thread Stefano Babic
> > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82

Re: [U-Boot] [PATCH 1/3] mx5: Define a common get_board_rev()

2013-04-25 Thread Stefano Babic
--- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-

Re: [U-Boot] [PATCH 2/3] mx5: Select CONFIG_REVISION_TAG

2013-04-25 Thread Stefano Babic
ed to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53

Re: [U-Boot] [PATCH 3/3] mx53ard: Move register masks into imx-regs.h

2013-04-25 Thread Stefano Babic
On 25/04/2013 02:44, Fabio Estevam wrote: > From: Fabio Estevam > > imx-regs.h is more appropriate location for containing register masks. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best rega

Re: [U-Boot] [PATCH v3 1/3] iomux-v3: Place pad control definitions into common file

2013-04-25 Thread Stefano Babic
t; -#define PAD_CTL_DSE_80ohm(3 << 3) > -#define PAD_CTL_DSE_60ohm(4 << 3) > -#define PAD_CTL_DSE_48ohm(5 << 3) > -#define PAD_CTL_DSE_40ohm(6 << 3) > -#define PAD_CTL_DSE_34ohm(7 << 3) > -#define PAD_CTL_SRE_FAST (1 << 0) >

Re: [U-Boot] [PATCH v3 1/3] iomux-v3: Place pad control definitions into common file

2013-04-25 Thread Stefano Babic
t; anyway I suppose that the mx51evk does not work correctly. Can you take >> a look at this issue ? > > I have already made a patch for that among other things. I will post it > tomorrow. You're great ! Thanks to fix problems when they happen (and also bef

Re: [U-Boot] [PATCH 1/2] mxs: mxsboot: Move sdcard BCB header to 4 sectors offset

2013-04-26 Thread Stefano Babic
be used by >> both SoCs avoiding code duplication. >> >> This idea was given by Marek Vasut >> >> Signed-off-by: Otavio Salvador > > On M28EVK > Tested-by: Marek Vasut > Ok, thanks, I push it to -master Best regards, Stefano Babic -- =

Re: [U-Boot] [PATCH 1/2] mxs: mxsboot: Move sdcard BCB header to 4 sectors offset

2013-04-26 Thread Stefano Babic
duplication. > > This idea was given by Marek Vasut > > Signed-off-by: Otavio Salvador > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk

Re: [U-Boot] [PATCH 2/2] mx53ard: Rework default environment to support FDT, MMC and netboot

2013-04-26 Thread Stefano Babic
> --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone:

Re: [U-Boot] [PATCH v4 01/10] imx: Homogenize and fix fuse register definitions

2013-04-26 Thread Stefano Babic
: Alignment should match open parenthesis #2088: FILE: drivers/misc/mxc_ocotp.c:79: + if (bank >= ARRAY_SIZE((*regs)->bank) || + word >= ARRAY_SIZE((*regs)->bank[0].fuse_regs) >> 2 || I will not care about this. Best regards, Stefano Babic -- ===

Re: [U-Boot] [PATCH v4 01/10] imx: Homogenize and fix fuse register definitions

2013-04-26 Thread Stefano Babic
On 26/04/2013 10:03, Benoît Thébaudeau wrote: > Hi Stefano, > Hi Benoît, >> I would like to apply your patches and I see some warning from >> clearpatch. Some of them are very annoying and I think to ignore them, >> but before doing that I ask to ML about it. It seems

Re: [U-Boot] [PATCH 1/2] tools: arm: imx: Implement BOOT_OFFSET command for imximage

2013-04-26 Thread Stefano Babic
h/imx-common/ so the board-specific imximage.cfg > can include this file to avoid magic constants. > > The syntax of BOOT_OFFSET command is "BOOT_OFFSET ". > > Signed-off-by: Marek Vasut > Cc: Albert ARIBAUD > Cc: Benoît Thébaudeau > Cc: Fabio Estevam > Cc

Re: [U-Boot] [PATCH] mx23: Put back RAM voltage level to its original value

2013-04-27 Thread Stefano Babic
noone will come up with real fix > when > there is a "good enough plaster" put on to cover the real problem. I agree that we have not yet found a clear cause of the behavior - but ler me say that is quite bound to the hardware and how voltage is applied to the DDR. As t

Re: [U-Boot] [PATCH] mx23: Put back RAM voltage level to its original value

2013-04-28 Thread Stefano Babic
> > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.

Re: [U-Boot] [PATCH v4 01/10] imx: Homogenize and fix fuse register definitions

2013-04-28 Thread Stefano Babic
au > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Pho

Re: [U-Boot] [PATCH v4 02/10] imx: Add useful fuse definitions

2013-04-28 Thread Stefano Babic
On 23/04/2013 22:17, Benoît Thébaudeau wrote: > Define the UID (SoC unique ID) fuses, and the fuses available for the user. > > Signed-off-by: Benoît Thébaudeau > --- Applied to u-boot-imx, thanks. Best regards, S

Re: [U-Boot] [PATCH v4 03/10] Add fuse API and commands

2013-04-28 Thread Stefano Babic
On 23/04/2013 22:17, Benoît Thébaudeau wrote: > This can be useful for fuse-like hardware, OTP SoC options, etc. > > Signed-off-by: Benoît Thébaudeau > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- ==

Re: [U-Boot] [PATCH v4 10/10] imx: Document fuse assignments for MAC addresses

2013-04-28 Thread Stefano Babic
On 23/04/2013 22:17, Benoît Thébaudeau wrote: > Signed-off-by: Benoît Thébaudeau > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev

Re: [U-Boot] [PATCH v4 04/10] Add fsl_iim driver

2013-04-28 Thread Stefano Babic
> drivers/misc/Makefile |1 + > drivers/misc/fsl_iim.c| 286 > + > 7 files changed, 340 insertions(+) > create mode 100644 doc/README.fsl_iim > create mode 100644 drivers/misc/fsl_iim.c > Applied to u-boot

Re: [U-Boot] [PATCH v4 06/10] mx51evk: Enable support for iim

2013-04-28 Thread Stefano Babic
On 23/04/2013 22:17, Benoît Thébaudeau wrote: > This allows to test the iim driver in the mainline tree. > > Signed-off-by: Benoît Thébaudeau > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- ==

Re: [U-Boot] [PATCH v4 05/10] mpc: iim: Switch to common fsl_iim

2013-04-28 Thread Stefano Babic
On 23/04/2013 22:17, Benoît Thébaudeau wrote: > Make all mpc512x code point to the new common fsl_iim driver, and remove the > former mpc512x-specific iim driver. > > Signed-off-by: Benoît Thébaudeau > --- Applied to u-boot-imx, thanks. Best regards

Re: [U-Boot] [PATCH v4 07/10] Add mxc_ocotp driver

2013-04-28 Thread Stefano Babic
On 23/04/2013 22:17, Benoît Thébaudeau wrote: > Add an mxc_ocotp driver for i.MX6. > > Signed-off-by: Benoît Thébaudeau > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engi

Re: [U-Boot] [PATCH v4 08/10] mx6qsabrelite: Enable support for ocotp

2013-04-28 Thread Stefano Babic
On 23/04/2013 22:17, Benoît Thébaudeau wrote: > Signed-off-by: Benoît Thébaudeau > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev

Re: [U-Boot] [PATCH v4 09/10] nitrogen6x: Enable support for ocotp

2013-04-28 Thread Stefano Babic
On 23/04/2013 22:17, Benoît Thébaudeau wrote: > Signed-off-by: Benoît Thébaudeau > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev

Re: [U-Boot] [PATCH 1/2] tools: arm: imx: Implement BOOT_OFFSET command for imximage

2013-04-28 Thread Stefano Babic
h/imx-common/ so the board-specific imximage.cfg > can include this file to avoid magic constants. > > The syntax of BOOT_OFFSET command is "BOOT_OFFSET ". > > Signed-off-by: Marek Vasut > Cc: Albert ARIBAUD > Cc: Benoît Thébaudeau > Cc: Fabio Estevam > Cc

Re: [U-Boot] [PATCH 1/4] imx: iomux-v3: Fix common pad control definitions

2013-04-28 Thread Stefano Babic
ions are actually common to some other i.MX > (25/35/53), so move them to the common iomux-v3.h (just like what is done in > Linux's), and select the correct definitions depending on whether CONFIG_MX6 > is > defined or not. > > Signed-off-by: Benoît Thébaudeau

Re: [U-Boot] [PATCH 2/4] imx: iomux-v3: cosmetic: Reorganize definitions

2013-04-28 Thread Stefano Babic
> 1 file changed, 19 insertions(+), 14 deletions(-) > Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.

Re: [U-Boot] [PATCH 3/4] imx: iomux-v3: Restore Linux's NEW_PAD_CTRL() macro

2013-04-28 Thread Stefano Babic
On 26/04/2013 13:34, Benoît Thébaudeau wrote: > This macro will be useful for future changes. > > Signed-off-by: Benoît Thébaudeau > --- > arch/arm/include/asm/imx-common/iomux-v3.h |3 +++ > 1 file changed, 3 insertions(+) > Applied to u-boot-imx, thanks. Best r

Re: [U-Boot] [PATCH 4/4] imx: iomux-v3: Include PKE and PUE to pad control pull definitions

2013-04-28 Thread Stefano Babic
ut this patch does not change the > behavior, so it just removes the meaningless pull value from those > definitions. > > Signed-off-by: Benoît Thébaudeau > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic --

Re: [U-Boot] [PATCH 1/5] vybrid: add vybrid CPU support

2013-04-28 Thread Stefano Babic
example: #ifdef CONFIG_MVF600 > case 0x00080: return "EXTERNAL RESET"; #endif > > Does this kind of ifdef acceptable? Thanks. Only if there are some differences, but most code is shared. We have a get_reset_cause() in imx-common/cpu.c, but also a specific get_reset_cause() for mx

Re: [U-Boot] [PATCH 4/6] imx: mx35pdk: Convert to iomux-v3

2013-04-30 Thread Stefano Babic
On 29/04/2013 22:39, Benoît Thébaudeau wrote: > Hi Stefano, > Hi Benoît, > On Monday, April 29, 2013 10:41:18 PM, Benoît Thébaudeau wrote: >> There is no change of behavior. >> >> Signed-off-by: Benoît Thébaudeau >> --- > [...] >> diff --git a/bo

Re: [U-Boot] [PATCH] Fix references to the documentation files

2013-05-01 Thread Stefano Babic
Anatolij Gustschin > Cc: Prafulla Wadaskar > Cc: Stefano Babic > --- > board/LaCie/net2big_v2/kwbimage.cfg |2 +- > board/LaCie/netspace_v2/kwbimage-is2.cfg |2 +- > board/LaCie/netspace_v2/kwbimage-ns2l.cfg|2 +- > board/LaCie/netspace_v2/kwbima

Re: [U-Boot] [PATCH 8/9] mxs: spl_mem_init: Skip the initialization of some DRAM_CTL registers

2013-05-05 Thread Stefano Babic
if (!(i == 8 || i == 27 || i == 28 || i == 35)) > +#endif I will suggest you add also a comment here telling that the registers are reserved. I know you explain this in commit message, but people look directly into the code and it will be easire to understand why you do that. Best regards, St

Re: [U-Boot] [PATCH 12/12] imx: mx5: Remove legacy iomux support

2013-05-05 Thread Stefano Babic
-applied >> m53evk: >> - You rebase your series on mine? >> - I rebase my series on yours? > > Did you not send this stuff after m53evk? So let's let Stefano merge it all > in > sequence (poor Stefano though, patches seem to be piling up). Well, I confess th

Re: [U-Boot] [PATCH 12/12] imx: mx5: Remove legacy iomux support

2013-05-05 Thread Stefano Babic
gt;>> Signed-off-by: Benoît Thébaudeau >>>>> >>>>> Yes, good move >>>>> >>>>> Reviewed-by: Marek Vasut >>>> >>>> How do you plan to handle the conversion to iomux-v3 of the >>>> not-yet-applied >

Re: [U-Boot] [PATCH v5 0/7] mx23: Make DDR initialization stable

2013-05-05 Thread Stefano Babic
tlets resulted on > zero errors. > > Adjust U-boot so that it can also pass the 'memtester' stress test. > > After this series was applied, no more DDR errors were observed on a mx23evk. > Applied (whole series

Re: [U-Boot] [PATCH V3 2/2] arm: mx5: Add support for DENX M53EVK

2013-05-05 Thread Stefano Babic
gt; Cc: Fabio Estevam > Cc: Scott Wood > Cc: Stefano Babic > Cc: Tom Rini > Cc: Wolfgang Denk > --- Applied to u-boot-imx, thanks. Benoit's 24/25 will then fix the remaining issue - I am applying also that. Best regards, Stefano Babic -- ===

Re: [U-Boot] [PATCH V2 1/6] imx: Align the imximage header and payload to multiples of 4k

2013-05-05 Thread Stefano Babic
noît Thébaudeau > Cc: Fabio Estevam > Cc: Scott Wood > Cc: Stefano Babic > Cc: Tom Rini > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang De

Re: [U-Boot] [PATCH 5/6] arm: mx5: Add NAND clock handling

2013-05-05 Thread Stefano Babic
On 19/04/2013 06:10, Marek Vasut wrote: > Augment the MX5 clock code with function to enable and configure > NFC clock. This is necessary to get NFC working on MX5. > > Signed-off-by: Marek Vasut > Cc: Albert ARIBAUD > Cc: Benoît Thébaudeau > Cc: Fabio Estevam > Cc: S

Re: [U-Boot] [PATCH 4/6] arm: mx5: Add SPL support code to MX5

2013-05-05 Thread Stefano Babic
On 19/04/2013 06:10, Marek Vasut wrote: > Fix minor adjustments needed to get SPL framework building on MX5. > > Signed-off-by: Marek Vasut > Cc: Albert ARIBAUD > Cc: Benoît Thébaudeau > Cc: Fabio Estevam > Cc: Scott Wood > Cc: Stefano Babic > Cc: Tom Rini &

Re: [U-Boot] [PATCH v3 24/25] imx: m53evk: Convert to iomux-v3

2013-05-05 Thread Stefano Babic
On 03/05/2013 22:43, Benoît Thébaudeau wrote: > Hi Stefano, Marek, > > On Friday, May 3, 2013 10:32:36 PM, Benoît Thébaudeau wrote: >> There is no change of behavior, except for the folloing line that has been >> removed because the iomux mode was not set accordingly and th

Re: [U-Boot] [PATCH] mxs: Explain why some mx23 DDR registers are not configured

2013-05-06 Thread Stefano Babic
On 06/05/2013 04:11, Fabio Estevam wrote: > From: Fabio Estevam > > Put an explanation in the source code as to why some DDR registers do not > need to be configured. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best r

Re: [U-Boot] [PATCH 1/3] mx23: Operate DDR voltage supply at 2.5V

2013-05-06 Thread Stefano Babic
On 06/05/2013 03:52, Fabio Estevam wrote: > From: Fabio Estevam > > After the recent fixes in the mx23 DDR setup, it is safe to operate DDR > voltage > at the recommended 2.5V voltage level again. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks

Re: [U-Boot] [PATCH 2/3] mx23evk: Do not set voltage selection bit for SSP pads

2013-05-06 Thread Stefano Babic
On 06/05/2013 03:52, Fabio Estevam wrote: > From: Fabio Estevam > > mx23 SSP pad registers do not contain voltage selection bit, so just remove > it. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best r

Re: [U-Boot] [PATCH 3/3] mx23_olinuxino: Do not set voltage selection bit for SSP pads

2013-05-06 Thread Stefano Babic
On 06/05/2013 03:52, Fabio Estevam wrote: > From: Fabio Estevam > > mx23 SSP pad registers do not contain voltage selection bit, so just remove > it. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks. Best r

Re: [U-Boot] [PATCH] arm: mx23: Fix VDDMEM misconfiguration

2013-05-06 Thread Stefano Babic
> 0V__| > > Moreover, VDDIO on MX23 uses 25mV steps while MX28 uses 50mV steps, > fix this difference too. > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Otavio Salvador > Cc: Stefano

Re: [U-Boot] [PATCH] imx: mx35pdk: Fix MUX2_CTR GPIO

2013-05-06 Thread Stefano Babic
> > imx_iomux_v3_setup_pad(MX35_PAD_COMPARE__GPIO1_5); > > - gpio_direction_output(IMX_GPIO_NR(2, 5), 1); > + gpio_direction_output(IMX_GPIO_NR(1, 5), 1); > } > > val = mc9sdz60_reg_read(MC9SDZ60_REG_GPIO_1) | 0x04; > Thanks

Re: [U-Boot] [PATCH 3/4] arm: mxs: Add MXS LCDIF driver

2013-05-06 Thread Stefano Babic
t; Cc: Anatolij Gustschin >> Cc: Fabio Estevam >> Cc: Otavio Salvador >> Cc: Stefano Babic > > Acked-by: Anatolij Gustschin > Thanks, Anatolji Marek, also this patchset will flow now. Regards, Stefano -- =

Re: [U-Boot] [PATCH 4/4] arm: mxs: video: Enable MXS LCDIF on M28EVK

2013-05-06 Thread Stefano Babic
On 28/04/2013 21:20, Marek Vasut wrote: > Enable LCD output support on M28EVK. > > Signed-off-by: Marek Vasut > Cc: Anatolij Gustschin > Cc: Fabio Estevam > Cc: Otavio Salvador > Cc: Stefano Babic > --- Applied to u-boot-imx, thanks. Bes

Re: [U-Boot] [PATCH 2/4] arm: mxs: Add LCDIF registers for i.MX233

2013-05-06 Thread Stefano Babic
On 28/04/2013 21:20, Marek Vasut wrote: > Extend the regs-lcdif.h with registers for i.MX233. > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Otavio Salvador > Cc: Stefano Babic > --- Applied to u-boot-imx, thanks. Best r

<    1   2   3   4   5   6   7   8   9   10   >